winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
June 2010
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
663 discussions
Start a n
N
ew thread
Octavian Voicu : ntdll: Show one-time ERR if NOFILE limit is reached.
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: 0d8e7983c14cd0c8f0672dfd16b5a452ded7849e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0d8e7983c14cd0c8f0672dfd1…
Author: Octavian Voicu <octavian.voicu(a)gmail.com> Date: Fri Jun 11 12:13:17 2010 +0300 ntdll: Show one-time ERR if NOFILE limit is reached. --- dlls/ntdll/file.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index b5d1c14..30b93aa 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -87,6 +87,7 @@ #include "ddk/ntddser.h" WINE_DEFAULT_DEBUG_CHANNEL(ntdll); +WINE_DECLARE_DEBUG_CHANNEL(winediag); mode_t FILE_umask = 0; @@ -203,6 +204,11 @@ static NTSTATUS FILE_CreateFile( PHANDLE handle, ACCESS_MASK access, POBJECT_ATT break; } } + else if (io->u.Status == STATUS_TOO_MANY_OPENED_FILES) + { + static int once; + if (!once++) ERR_(winediag)( "Too many open files, ulimit -n probably needs to be increased\n" ); + } return io->u.Status; }
1
0
0
0
Andrew Nguyen : winealsa.drv: Replicate the snd_pcm_recover alsa-lib implementation to cope with older alsa-lib versions .
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: 13a7708abb481f2903db6b62efcf53a0a7f7b79e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=13a7708abb481f2903db6b62e…
Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Fri Jun 11 03:54:24 2010 -0500 winealsa.drv: Replicate the snd_pcm_recover alsa-lib implementation to cope with older alsa-lib versions. --- dlls/winealsa.drv/alsa.c | 45 +++++++++++++++++++++++++++++------------ dlls/winealsa.drv/alsa.h | 2 +- dlls/winealsa.drv/dsoutput.c | 2 +- dlls/winealsa.drv/waveout.c | 4 +- 4 files changed, 36 insertions(+), 17 deletions(-) diff --git a/dlls/winealsa.drv/alsa.c b/dlls/winealsa.drv/alsa.c index 9eb50cd..4f0f1ce 100644 --- a/dlls/winealsa.drv/alsa.c +++ b/dlls/winealsa.drv/alsa.c @@ -2,6 +2,7 @@ * Wine Driver for ALSA * * Copyright 2002 Eric Pouech + * Copyright 2006 Jaroslav Kysela * Copyright 2007 Maarten Lankhorst * * This file has a few shared generic subroutines shared among the alsa @@ -556,24 +557,42 @@ out: /************************************************************************** - * ALSA_XRUNRecovery [internal] + * wine_snd_pcm_recover [internal] * - * used to recovery from XRUN errors (buffer underflow/overflow) + * Code slightly modified from alsa-lib v1.0.23 snd_pcm_recover implementation. + * used to recover from XRUN errors (buffer underflow/overflow) */ -int ALSA_XRUNRecovery(WINE_WAVEDEV * wwo, int err) +int wine_snd_pcm_recover(snd_pcm_t *pcm, int err, int silent) { - if (err == -EPIPE) { /* under-run */ - err = snd_pcm_prepare(wwo->pcm); - if (err < 0) - ERR( "underrun recovery failed. prepare failed: %s\n", snd_strerror(err)); + if (err > 0) + err = -err; + if (err == -EINTR) /* nothing to do, continue */ return 0; - } else if (err == -ESTRPIPE) { - while ((err = snd_pcm_resume(wwo->pcm)) == -EAGAIN) - sleep(1); /* wait until the suspend flag is released */ + if (err == -EPIPE) { + const char *s; + if (snd_pcm_stream(pcm) == SND_PCM_STREAM_PLAYBACK) + s = "underrun"; + else + s = "overrun"; + if (!silent) + ERR("%s occurred", s); + err = snd_pcm_prepare(pcm); + if (err < 0) { + ERR("cannot recover from %s, prepare failed: %s", s, snd_strerror(err)); + return err; + } + return 0; + } + if (err == -ESTRPIPE) { + while ((err = snd_pcm_resume(pcm)) == -EAGAIN) + /* wait until suspend flag is released */ + poll(NULL, 0, 1000); if (err < 0) { - err = snd_pcm_prepare(wwo->pcm); - if (err < 0) - ERR("recovery from suspend failed, prepare failed: %s\n", snd_strerror(err)); + err = snd_pcm_prepare(pcm); + if (err < 0) { + ERR("cannot recover from suspend, prepare failed: %s", snd_strerror(err)); + return err; + } } return 0; } diff --git a/dlls/winealsa.drv/alsa.h b/dlls/winealsa.drv/alsa.h index 7c2f0f4..d961dce 100644 --- a/dlls/winealsa.drv/alsa.h +++ b/dlls/winealsa.drv/alsa.h @@ -187,7 +187,7 @@ const char * ALSA_getFormat(WORD wFormatTag); BOOL ALSA_NearMatch(int rate1, int rate2); DWORD ALSA_bytes_to_mmtime(LPMMTIME lpTime, DWORD position, WAVEFORMATPCMEX* format); void ALSA_TraceParameters(snd_pcm_hw_params_t * hw_params, snd_pcm_sw_params_t * sw, int full); -int ALSA_XRUNRecovery(WINE_WAVEDEV * wwo, int err); +int wine_snd_pcm_recover(snd_pcm_t *pcm, int err, int silent); void ALSA_copyFormat(LPWAVEFORMATEX wf1, LPWAVEFORMATPCMEX wf2); BOOL ALSA_supportedFormat(LPWAVEFORMATEX wf); diff --git a/dlls/winealsa.drv/dsoutput.c b/dlls/winealsa.drv/dsoutput.c index bb81621..8a277de 100644 --- a/dlls/winealsa.drv/dsoutput.c +++ b/dlls/winealsa.drv/dsoutput.c @@ -406,7 +406,7 @@ static HRESULT WINAPI IDsDriverBufferImpl_Unlock(PIDSDRIVERBUFFER iface, if (ret == -EPIPE) { WARN("Underrun occurred\n"); - snd_pcm_recover(This->pcm, -EPIPE, 1); + wine_snd_pcm_recover(This->pcm, -EPIPE, 1); ret = snd_pcm_writei(This->pcm, pvAudio1, writelen); /* Advance mmap pointer a little to make dsound notice the underrun and respond to it */ diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 4001f26..18693c1 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -110,7 +110,7 @@ static BOOL wodUpdatePlayedTotal(WINE_WAVEDEV* wwo, snd_pcm_status_t* ps) if (state != SND_PCM_STATE_RUNNING && state != SND_PCM_STATE_PREPARED) { WARN("Unexpected state (%d) while updating Total Played, resetting\n", state); - snd_pcm_recover(wwo->pcm, -EPIPE, 0); + wine_snd_pcm_recover(wwo->pcm, -EPIPE, 0); delay=0; } @@ -244,7 +244,7 @@ static int wodPlayer_WriteMaxFrags(WINE_WAVEDEV* wwo, DWORD* frames) written = (wwo->write)(wwo->pcm, lpWaveHdr->lpData + wwo->dwPartialOffset, toWrite); if ( written < 0) { /* XRUN occurred. let's try to recover */ - ALSA_XRUNRecovery(wwo, written); + wine_snd_pcm_recover(wwo->pcm, written, 0); written = (wwo->write)(wwo->pcm, lpWaveHdr->lpData + wwo->dwPartialOffset, toWrite); } if (written <= 0) {
1
0
0
0
Andrew Nguyen : configure: Avoid breaking compilation if AC_PACKAGE_URL is unavailable when regenerating with older autoconf .
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: dd12cf71100c9ab98439834ac2c54fb0483a2376 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=dd12cf71100c9ab98439834ac…
Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Fri Jun 11 03:20:38 2010 -0500 configure: Avoid breaking compilation if AC_PACKAGE_URL is unavailable when regenerating with older autoconf. --- configure.ac | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/configure.ac b/configure.ac index 21c0203..eed1487 100644 --- a/configure.ac +++ b/configure.ac @@ -19,6 +19,10 @@ m4_ifdef([AS_VAR_IF],,[AC_DEFUN([AS_VAR_IF], [AS_IF([test "x$$1" = x""$2], [$3], [$4])], [eval as_val=\$$1 AS_IF([test "x$as_val" = x""$2], [$3], [$4])])])])dnl +dnl autoconf versions before 2.64 don't have AC_PACKAGE_URL +m4_ifdef([AC_PACKAGE_URL],, + [AC_DEFINE([PACKAGE_URL], ["
http://www.winehq.org
"], [Define to the home page for this package.]) + AC_SUBST([PACKAGE_URL], ["
http://www.winehq.org
"])])dnl dnl **** Command-line arguments ****
1
0
0
0
Louis Lenders : xinput1_3: Quiet a noisy fixme.
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: ba1659762ee1d4dfec3c9b4909699befc29e98b6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ba1659762ee1d4dfec3c9b490…
Author: Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> Date: Fri May 28 20:44:51 2010 +0200 xinput1_3: Quiet a noisy fixme. --- dlls/xinput1_3/xinput1_3_main.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/dlls/xinput1_3/xinput1_3_main.c b/dlls/xinput1_3/xinput1_3_main.c index fc55cef..6d6399f 100644 --- a/dlls/xinput1_3/xinput1_3_main.c +++ b/dlls/xinput1_3/xinput1_3_main.c @@ -93,7 +93,10 @@ DWORD WINAPI XInputGetKeystroke(DWORD dwUserIndex, DWORD dwReserve, PXINPUT_KEYS DWORD WINAPI XInputGetCapabilities(DWORD dwUserIndex, DWORD dwFlags, XINPUT_CAPABILITIES* pCapabilities) { - FIXME("(%d %d %p)\n", dwUserIndex, dwFlags, pCapabilities); + static int warn_once; + + if (!warn_once++) + FIXME("(%d %d %p)\n", dwUserIndex, dwFlags, pCapabilities); if (dwUserIndex < XUSER_MAX_COUNT) {
1
0
0
0
Dylan Smith : wordpad: Provide buffer for replace with text.
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: 975dd904ef8c1ddf6c08ebe465cc382c073dd1a0 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=975dd904ef8c1ddf6c08ebe46…
Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Fri Jun 11 00:44:16 2010 -0400 wordpad: Provide buffer for replace with text. --- programs/wordpad/wordpad.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/programs/wordpad/wordpad.c b/programs/wordpad/wordpad.c index 0bf5d0c..3b8b6bc 100644 --- a/programs/wordpad/wordpad.c +++ b/programs/wordpad/wordpad.c @@ -1302,6 +1302,7 @@ static LRESULT handle_findmsg(LPFINDREPLACEW pFr) static void dialog_find(LPFINDREPLACEW fr, BOOL replace) { static WCHAR findBuffer[MAX_STRING_LEN]; + static WCHAR replaceBuffer[MAX_STRING_LEN]; /* Allow only one search/replace dialog to open */ if(hFindWnd != NULL) @@ -1315,8 +1316,10 @@ static void dialog_find(LPFINDREPLACEW fr, BOOL replace) fr->hwndOwner = hMainWnd; fr->Flags = FR_HIDEUPDOWN; fr->lpstrFindWhat = findBuffer; + fr->lpstrReplaceWith = replaceBuffer; fr->lCustData = -1; - fr->wFindWhatLen = MAX_STRING_LEN*sizeof(WCHAR); + fr->wFindWhatLen = sizeof(findBuffer); + fr->wReplaceWithLen = sizeof(replaceBuffer); if(replace) hFindWnd = ReplaceTextW(fr);
1
0
0
0
Dylan Smith : wordpad: Native RegisterClassExW requires cbSize to be set.
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: d10ce5df2654dc483d7bc44554e062562a220fa9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d10ce5df2654dc483d7bc4455…
Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Fri Jun 11 00:43:44 2010 -0400 wordpad: Native RegisterClassExW requires cbSize to be set. --- programs/wordpad/wordpad.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/programs/wordpad/wordpad.c b/programs/wordpad/wordpad.c index c90e7b5..0bf5d0c 100644 --- a/programs/wordpad/wordpad.c +++ b/programs/wordpad/wordpad.c @@ -2671,6 +2671,7 @@ int CALLBACK WinMain(HINSTANCE hInstance, HINSTANCE hOldInstance, LPSTR szCmdPar hAccel = LoadAcceleratorsW(hInstance, wszAccelTable); + wc.cbSize = sizeof(wc); wc.style = CS_HREDRAW | CS_VREDRAW; wc.lpfnWndProc = WndProc; wc.cbClsExtra = 0;
1
0
0
0
Nikolay Sivov : msvcrt: Fix __lconv_init() prototype.
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: 90013af6f932d7553290f1eb42490ec7f4d94f46 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=90013af6f932d7553290f1eb4…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Jun 11 03:57:53 2010 +0400 msvcrt: Fix __lconv_init() prototype. --- dlls/msvcr90/msvcr90.c | 1 + dlls/msvcrt/locale.c | 3 ++- 2 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/msvcr90/msvcr90.c b/dlls/msvcr90/msvcr90.c index 43a1834..0d7d101 100644 --- a/dlls/msvcr90/msvcr90.c +++ b/dlls/msvcr90/msvcr90.c @@ -93,6 +93,7 @@ int CDECL _initterm_e(_INITTERM_E_FN *table, _INITTERM_E_FN *end) while (!res && table < end) { if (*table) { + TRACE("calling %p\n", **table); res = (**table)(); if (res) TRACE("function %p failed: 0x%x\n", *table, res); diff --git a/dlls/msvcrt/locale.c b/dlls/msvcrt/locale.c index a347962..5a27de0 100644 --- a/dlls/msvcrt/locale.c +++ b/dlls/msvcrt/locale.c @@ -541,10 +541,11 @@ struct MSVCRT_lconv * CDECL MSVCRT_localeconv(void) /********************************************************************* * __lconv_init (MSVCRT.@) */ -void CDECL __lconv_init(void) +int CDECL __lconv_init(void) { /* this is used to make chars unsigned */ charmax = 255; + return 0; } /*********************************************************************
1
0
0
0
Igor Paliychuk : kernel32: Update Ukrainian translations.
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: 4801209c5c1a2eda950d1c89e53d9e907be79c63 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4801209c5c1a2eda950d1c89e…
Author: Igor Paliychuk <Igor-hkr(a)mail.ru> Date: Thu Jun 10 19:05:34 2010 +0300 kernel32: Update Ukrainian translations. --- dlls/kernel32/nls/ukr.nls | 28 ++++++++++++++-------------- 1 files changed, 14 insertions(+), 14 deletions(-) diff --git a/dlls/kernel32/nls/ukr.nls b/dlls/kernel32/nls/ukr.nls index 865fd2d..a32aac5 100644 --- a/dlls/kernel32/nls/ukr.nls +++ b/dlls/kernel32/nls/ukr.nls @@ -64,7 +64,7 @@ STRINGTABLE LANGUAGE LANG_UKRAINIAN, SUBLANG_DEFAULT LOCALE_S2359 "" LOCALE_SABBREVCTRYNAME "UKR" LOCALE_SABBREVDAYNAME1 "��" - LOCALE_SABBREVDAYNAME2 "��" + LOCALE_SABBREVDAYNAME2 "��" LOCALE_SABBREVDAYNAME3 "��" LOCALE_SABBREVDAYNAME4 "��" LOCALE_SABBREVDAYNAME5 "��" @@ -82,7 +82,7 @@ STRINGTABLE LANGUAGE LANG_UKRAINIAN, SUBLANG_DEFAULT LOCALE_SABBREVMONTHNAME9 "���" LOCALE_SABBREVMONTHNAME10 "���" LOCALE_SABBREVMONTHNAME11 "���" - LOCALE_SABBREVMONTHNAME12 "���" + LOCALE_SABBREVMONTHNAME12 "���" LOCALE_SABBREVMONTHNAME13 "" LOCALE_SCOUNTRY "Ukraine" LOCALE_SCURRENCY "���." @@ -107,18 +107,18 @@ STRINGTABLE LANGUAGE LANG_UKRAINIAN, SUBLANG_DEFAULT LOCALE_SLONGDATE "d MMMM yyyy' �.'" LOCALE_SMONDECIMALSEP "," LOCALE_SMONGROUPING "3;0" - LOCALE_SMONTHNAME1 "ѳ����" - LOCALE_SMONTHNAME2 "�����" - LOCALE_SMONTHNAME3 "��������" - LOCALE_SMONTHNAME4 "������" - LOCALE_SMONTHNAME5 "�������" - LOCALE_SMONTHNAME6 "�������" - LOCALE_SMONTHNAME7 "������" - LOCALE_SMONTHNAME8 "�������" - LOCALE_SMONTHNAME9 "��������" - LOCALE_SMONTHNAME10 "�������" - LOCALE_SMONTHNAME11 "��������" - LOCALE_SMONTHNAME12 "�������" + LOCALE_SMONTHNAME1 "ѳ����\0����" + LOCALE_SMONTHNAME2 "�����\0������" + LOCALE_SMONTHNAME3 "��������\0�������" + LOCALE_SMONTHNAME4 "������\0�����" + LOCALE_SMONTHNAME5 "�������\0������" + LOCALE_SMONTHNAME6 "�������\0������" + LOCALE_SMONTHNAME7 "������\0�����" + LOCALE_SMONTHNAME8 "�������\0������" + LOCALE_SMONTHNAME9 "��������\0�������" + LOCALE_SMONTHNAME10 "�������\0������" + LOCALE_SMONTHNAME11 "��������\0���������" + LOCALE_SMONTHNAME12 "�������\0������" LOCALE_SMONTHNAME13 "" LOCALE_SMONTHOUSANDSEP "�" LOCALE_SNAME "uk-UA"
1
0
0
0
Damjan Jovanovic : kernel32: CopyFile cannot overwrite a file with itself.
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: 3f1404bf29676d79dd76ffd31e2630bb9f2b0b60 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3f1404bf29676d79dd76ffd31…
Author: Damjan Jovanovic <damjan.jov(a)gmail.com> Date: Thu Jun 10 22:14:13 2010 +0200 kernel32: CopyFile cannot overwrite a file with itself. --- dlls/kernel32/path.c | 2 +- dlls/kernel32/tests/file.c | 12 ++++++++++++ 2 files changed, 13 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/path.c b/dlls/kernel32/path.c index c319cb5..2bfd062 100644 --- a/dlls/kernel32/path.c +++ b/dlls/kernel32/path.c @@ -911,7 +911,7 @@ BOOL WINAPI CopyFileW( LPCWSTR source, LPCWSTR dest, BOOL fail_if_exists ) return FALSE; } - if ((h2 = CreateFileW( dest, GENERIC_WRITE, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, + if ((h2 = CreateFileW( dest, GENERIC_WRITE, FILE_SHARE_READ, NULL, fail_if_exists ? CREATE_NEW : CREATE_ALWAYS, info.dwFileAttributes, h1 )) == INVALID_HANDLE_VALUE) { diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index b6f066e..fcc7fc0 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -598,6 +598,10 @@ static void test_CopyFileA(void) ok( retok && ret == sizeof(prefix), "WriteFile error %d\n", GetLastError()); ok(GetFileSize(hfile, NULL) == sizeof(prefix), "source file has wrong size\n"); + /* copying a file to itself must fail */ + retok = CopyFileA(source, source, FALSE); + ok( !retok && (GetLastError() == ERROR_SHARING_VIOLATION || broken(GetLastError() == ERROR_FILE_EXISTS) /* Win 9x */), + "copying a file to itself didn't fail (ret=%d, err=%d)\n", retok, GetLastError()); /* get the file time and change it to prove the difference */ ret = GetFileTime(hfile, NULL, NULL, &ft1); ok( ret, "GetFileTime error %d\n", GetLastError()); @@ -618,6 +622,14 @@ static void test_CopyFileA(void) ret = CopyFileA(source, dest, FALSE); ok(ret, "CopyFileA: error %d\n", GetLastError()); + /* destination file is write-locked during copy */ + hfile = CreateFileA(dest, GENERIC_WRITE, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); + ok(hfile != INVALID_HANDLE_VALUE, "failed to open destination file, error %d\n", GetLastError()); + retok = CopyFileA(source, dest, FALSE); + ok(!retok && GetLastError() == ERROR_SHARING_VIOLATION, + "copying to a write-locked file didn't fail (ret=%d, err=%d)\n", ret, GetLastError()); + CloseHandle(hfile); + /* make sure that destination has correct size */ hfile = CreateFileA(dest, GENERIC_READ, FILE_SHARE_READ, NULL, OPEN_EXISTING, 0, 0); ok(hfile != INVALID_HANDLE_VALUE, "failed to open destination file\n");
1
0
0
0
Nikolay Sivov : msvcrt: Add _scwprintf implementation.
by Alexandre Julliard
11 Jun '10
11 Jun '10
Module: wine Branch: master Commit: 97807760cad4bbbb06a072faa0c34b66ba952d55 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=97807760cad4bbbb06a072faa…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Jun 10 23:54:30 2010 +0400 msvcrt: Add _scwprintf implementation. --- dlls/msvcr100/msvcr100.spec | 2 +- dlls/msvcr80/msvcr80.spec | 2 +- dlls/msvcr90/msvcr90.spec | 2 +- dlls/msvcrt/msvcrt.spec | 2 +- dlls/msvcrt/wcs.c | 14 ++++++++++++++ 5 files changed, 18 insertions(+), 4 deletions(-) diff --git a/dlls/msvcr100/msvcr100.spec b/dlls/msvcr100/msvcr100.spec index b0b8172..44c5b31 100644 --- a/dlls/msvcr100/msvcr100.spec +++ b/dlls/msvcr100/msvcr100.spec @@ -1012,7 +1012,7 @@ @ stub _scprintf_l @ stub _scprintf_p @ stub _scprintf_p_l -@ stub _scwprintf +@ varargs _scwprintf(wstr) msvcrt._scwprintf @ stub _scwprintf_l @ stub _scwprintf_p @ stub _scwprintf_p_l diff --git a/dlls/msvcr80/msvcr80.spec b/dlls/msvcr80/msvcr80.spec index a8ba61e..256031c 100644 --- a/dlls/msvcr80/msvcr80.spec +++ b/dlls/msvcr80/msvcr80.spec @@ -857,7 +857,7 @@ @ stub _scprintf_l @ stub _scprintf_p @ stub _scprintf_p_l -@ stub _scwprintf +@ varargs _scwprintf(wstr) msvcrt._scwprintf @ stub _scwprintf_l @ stub _scwprintf_p @ stub _scwprintf_p_l diff --git a/dlls/msvcr90/msvcr90.spec b/dlls/msvcr90/msvcr90.spec index df65a5c..a2bed36 100644 --- a/dlls/msvcr90/msvcr90.spec +++ b/dlls/msvcr90/msvcr90.spec @@ -843,7 +843,7 @@ @ stub _scprintf_l @ stub _scprintf_p @ stub _scprintf_p_l -@ stub _scwprintf +@ varargs _scwprintf(wstr) msvcrt._scwprintf @ stub _scwprintf_l @ stub _scwprintf_p @ stub _scwprintf_p_l diff --git a/dlls/msvcrt/msvcrt.spec b/dlls/msvcrt/msvcrt.spec index 88a2ab9..bba06d6 100644 --- a/dlls/msvcrt/msvcrt.spec +++ b/dlls/msvcrt/msvcrt.spec @@ -801,7 +801,7 @@ # stub _scprintf # stub _scprintf_l # stub _scprintf_p_l -# stub _scwprintf +@ varargs _scwprintf(wstr) MSVCRT__scwprintf # stub _scwprintf_l # stub _scwprintf_p_l @ cdecl _searchenv(str str ptr) diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c index 4485db3..03ecc7f 100644 --- a/dlls/msvcrt/wcs.c +++ b/dlls/msvcrt/wcs.c @@ -1247,6 +1247,20 @@ int CDECL MSVCRT_sprintf_s( char *str, MSVCRT_size_t num, const char *format, .. } /********************************************************************* + * _scwprintf (MSVCRT.@) + */ +int CDECL MSVCRT__scwprintf( const MSVCRT_wchar_t *format, ... ) +{ + __ms_va_list ap; + int r; + + __ms_va_start( ap, format ); + r = MSVCRT_vsnwprintf( NULL, INT_MAX, format, ap ); + __ms_va_end( ap ); + return r; +} + +/********************************************************************* * swprintf (MSVCRT.@) */ int CDECL MSVCRT_swprintf( MSVCRT_wchar_t *str, const MSVCRT_wchar_t *format, ... )
1
0
0
0
← Newer
1
...
41
42
43
44
45
46
47
...
67
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
Results per page:
10
25
50
100
200