wine-commits January 2011

wine-commits@winehq.org

2 participants
879 discussions

Greg Geldorp : d3d9/tests: Skip tests if not running in the foreground.
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: 5c9ce61e9bfb647c3c2de329eab793f024c6a997 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5c9ce61e9bfb647c3c2de329e… Author: Greg Geldorp <ggeldorp(a)vmware.com> Date: Wed Jan 12 14:13:47 2011 +0100 d3d9/tests: Skip tests if not running in the foreground. --- dlls/d3d9/tests/device.c | 24 ++++++++++++++++++------ 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c index 671afbf..41d1446 100644 --- a/dlls/d3d9/tests/device.c +++ b/dlls/d3d9/tests/device.c @@ -2385,6 +2385,7 @@ struct wndproc_thread_param HWND dummy_window; HANDLE window_created; HANDLE test_finished; + BOOL running_in_foreground; }; static LRESULT CALLBACK test_proc(HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam) @@ -2428,6 +2429,7 @@ static DWORD WINAPI wndproc_thread(void *param) p->dummy_window = CreateWindowA("d3d9_test_wndproc_wc", "d3d9_test", WS_MAXIMIZE | WS_VISIBLE | WS_CAPTION, 0, 0, 640, 480, 0, 0, 0, 0); + p->running_in_foreground = SetForegroundWindow(p->dummy_window); ret = SetEvent(p->window_created); ok(ret, "SetEvent failed, last error %#x.\n", GetLastError()); @@ -2508,9 +2510,14 @@ static void test_wndproc(void) tmp = GetFocus(); ok(tmp == device_window, "Expected focus %p, got %p.\n", device_window, tmp); - tmp = GetForegroundWindow(); - ok(tmp == thread_params.dummy_window, "Expected foreground window %p, got %p.\n", - thread_params.dummy_window, tmp); + if (thread_params.running_in_foreground) + { + tmp = GetForegroundWindow(); + ok(tmp == thread_params.dummy_window, "Expected foreground window %p, got %p.\n", + thread_params.dummy_window, tmp); + } + else + skip("Not running in foreground, skip foreground window test\n"); flush_events(); @@ -2647,9 +2654,14 @@ static void test_wndproc_windowed(void) tmp = GetFocus(); ok(tmp == device_window, "Expected focus %p, got %p.\n", device_window, tmp); - tmp = GetForegroundWindow(); - ok(tmp == thread_params.dummy_window, "Expected foreground window %p, got %p.\n", - thread_params.dummy_window, tmp); + if (thread_params.running_in_foreground) + { + tmp = GetForegroundWindow(); + ok(tmp == thread_params.dummy_window, "Expected foreground window %p, got %p.\n", + thread_params.dummy_window, tmp); + } + else + skip("Not running in foreground, skip foreground window test\n"); filter_messages = focus_window;

1 0

Greg Geldorp : d3d8/tests: Skip tests if not running in the foreground.
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: c1736fed2d3d6d90745ede2f77eac8dd2c0bec2f URL: http://source.winehq.org/git/wine.git/?a=commit;h=c1736fed2d3d6d90745ede2f7… Author: Greg Geldorp <ggeldorp(a)vmware.com> Date: Wed Jan 12 14:12:27 2011 +0100 d3d8/tests: Skip tests if not running in the foreground. --- dlls/d3d8/tests/device.c | 24 ++++++++++++++++++------ 1 files changed, 18 insertions(+), 6 deletions(-) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index ef040c1..e4aabf4 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -1541,6 +1541,7 @@ struct wndproc_thread_param HWND dummy_window; HANDLE window_created; HANDLE test_finished; + BOOL running_in_foreground; }; static LRESULT CALLBACK test_proc(HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam) @@ -1584,6 +1585,7 @@ static DWORD WINAPI wndproc_thread(void *param) p->dummy_window = CreateWindowA("d3d8_test_wndproc_wc", "d3d8_test", WS_MAXIMIZE | WS_VISIBLE | WS_CAPTION, 0, 0, 640, 480, 0, 0, 0, 0); + p->running_in_foreground = SetForegroundWindow(p->dummy_window); ret = SetEvent(p->window_created); ok(ret, "SetEvent failed, last error %#x.\n", GetLastError()); @@ -1667,9 +1669,14 @@ static void test_wndproc(void) tmp = GetFocus(); ok(tmp == device_window, "Expected focus %p, got %p.\n", device_window, tmp); - tmp = GetForegroundWindow(); - ok(tmp == thread_params.dummy_window, "Expected foreground window %p, got %p.\n", - thread_params.dummy_window, tmp); + if (thread_params.running_in_foreground) + { + tmp = GetForegroundWindow(); + ok(tmp == thread_params.dummy_window, "Expected foreground window %p, got %p.\n", + thread_params.dummy_window, tmp); + } + else + skip("Not running in foreground, skip foreground window test\n"); flush_events(); @@ -1806,9 +1813,14 @@ static void test_wndproc_windowed(void) tmp = GetFocus(); ok(tmp == device_window, "Expected focus %p, got %p.\n", device_window, tmp); - tmp = GetForegroundWindow(); - ok(tmp == thread_params.dummy_window, "Expected foreground window %p, got %p.\n", - thread_params.dummy_window, tmp); + if (thread_params.running_in_foreground) + { + tmp = GetForegroundWindow(); + ok(tmp == thread_params.dummy_window, "Expected foreground window %p, got %p.\n", + thread_params.dummy_window, tmp); + } + else + skip("Not running in foreground, skip foreground window test\n"); filter_messages = focus_window;

1 0

Greg Geldorp : gdi32/tests: Allow ANSI_CHARSET for some tests.
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: 33a5cdbf795f4e3cfa14fa76c6c54e36cfd70c08 URL: http://source.winehq.org/git/wine.git/?a=commit;h=33a5cdbf795f4e3cfa14fa76c… Author: Greg Geldorp <ggeldorp(a)vmware.com> Date: Wed Jan 12 14:11:43 2011 +0100 gdi32/tests: Allow ANSI_CHARSET for some tests. --- dlls/gdi32/tests/font.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c index 28bdcc2..4230ebc 100644 --- a/dlls/gdi32/tests/font.c +++ b/dlls/gdi32/tests/font.c @@ -2706,7 +2706,7 @@ todo_wine /* Wine uses Arial for all substitutions */ !lstrcmpiA(buf, "MS Sans Serif"), /* win2k3 */ "Got %s\n", buf); cs = GetTextCharset(hdc); - ok(cs == expected_cs, "expected %d, got %d\n", expected_cs, cs); + ok(cs == expected_cs || cs == ANSI_CHARSET, "expected %d, got %d\n", expected_cs, cs); DeleteObject(SelectObject(hdc, hfont)); memset(&lf, 0, sizeof(lf)); @@ -2771,7 +2771,7 @@ todo_wine /* Wine uses Arial for all substitutions */ !lstrcmpiA(buf, "MS Sans Serif"), /* win2k3 */ "got %s for font %s\n", buf, font_subst[i].name); cs = GetTextCharset(hdc); - ok(cs == expected_cs, "expected %d, got %d for font %s\n", expected_cs, cs, font_subst[i].name); + ok(cs == expected_cs || cs == ANSI_CHARSET, "expected %d, got %d for font %s\n", expected_cs, cs, font_subst[i].name); DeleteObject(SelectObject(hdc, hfont)); }

1 0

Hans Leidekker : msi: Fix parsing of patch product codes (valgrind).
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: d08378a06f90ececa883d71ea02f7619f38aef29 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d08378a06f90ececa883d71ea… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Jan 12 14:04:28 2011 +0100 msi: Fix parsing of patch product codes (valgrind). --- dlls/msi/action.c | 3 +-- dlls/msi/msi.c | 21 +++++++++------------ dlls/msi/msipriv.h | 1 + 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 8f2d116..725ea2f 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -465,8 +465,7 @@ UINT msi_parse_command_line( MSIPACKAGE *package, LPCWSTR szCommandLine, return ERROR_SUCCESS; } - -static LPWSTR* msi_split_string( LPCWSTR str, WCHAR sep ) +WCHAR **msi_split_string( const WCHAR *str, WCHAR sep ) { LPCWSTR pc; LPWSTR p, *ret = NULL; diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c index 266bd89..948ae35 100644 --- a/dlls/msi/msi.c +++ b/dlls/msi/msi.c @@ -299,7 +299,8 @@ done: return r; } -static UINT get_patch_product_codes( LPCWSTR szPatchPackage, WCHAR **product_codes ) + +static UINT get_patch_product_codes( LPCWSTR szPatchPackage, WCHAR ***product_codes ) { MSIHANDLE patch, info = 0; UINT r, type; @@ -332,23 +333,22 @@ static UINT get_patch_product_codes( LPCWSTR szPatchPackage, WCHAR **product_cod } r = MsiSummaryInfoGetPropertyW( info, PID_TEMPLATE, &type, NULL, NULL, codes, &size ); - if (r != ERROR_SUCCESS) - msi_free( codes ); - else - *product_codes = codes; + if (r == ERROR_SUCCESS) + *product_codes = msi_split_string( codes, ';' ); done: MsiCloseHandle( info ); MsiCloseHandle( patch ); + msi_free( codes ); return r; } static UINT MSI_ApplyPatchW(LPCWSTR szPatchPackage, LPCWSTR szProductCode, LPCWSTR szCommandLine) { - UINT r; + UINT r, i; DWORD size; LPCWSTR cmd_ptr = szCommandLine; - LPWSTR beg, end, cmd, codes = NULL; + LPWSTR cmd, *codes = NULL; BOOL succeeded = FALSE; static const WCHAR fmt[] = {'%','s',' ','P','A','T','C','H','=','"','%','s','"',0}; @@ -376,17 +376,14 @@ static UINT MSI_ApplyPatchW(LPCWSTR szPatchPackage, LPCWSTR szProductCode, LPCWS r = MsiConfigureProductExW(szProductCode, INSTALLLEVEL_DEFAULT, INSTALLSTATE_DEFAULT, cmd); else { - beg = codes; - while ((end = strchrW(beg, '}'))) + for (i = 0; codes[i]; i++) { - *(end + 1) = '\0'; - r = MsiConfigureProductExW(beg, INSTALLLEVEL_DEFAULT, INSTALLSTATE_DEFAULT, cmd); + r = MsiConfigureProductExW(codes[i], INSTALLLEVEL_DEFAULT, INSTALLSTATE_DEFAULT, cmd); if (r == ERROR_SUCCESS) { TRACE("patch applied\n"); succeeded = TRUE; } - beg = end + 2; } if (succeeded) diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h index 3f482ea..47a35b8 100644 --- a/dlls/msi/msipriv.h +++ b/dlls/msi/msipriv.h @@ -958,6 +958,7 @@ extern void msi_feature_set_state(MSIPACKAGE *, MSIFEATURE *, INSTALLSTATE); extern MSIASSEMBLY *load_assembly(MSIPACKAGE *, MSICOMPONENT *); extern UINT install_assembly(MSIPACKAGE *, MSICOMPONENT *); extern WCHAR *font_version_from_file(const WCHAR *); +extern WCHAR **msi_split_string(const WCHAR *, WCHAR); /* media */

1 0

Hans Leidekker : msi: Fix a memory leak (valgrind).
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: 94f4c0f07ded9d282db54523e049725029a8f5d2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=94f4c0f07ded9d282db54523e… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Jan 12 14:04:13 2011 +0100 msi: Fix a memory leak (valgrind). --- dlls/msi/action.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/msi/action.c b/dlls/msi/action.c index 7ccc7c6..8f2d116 100644 --- a/dlls/msi/action.c +++ b/dlls/msi/action.c @@ -2735,6 +2735,7 @@ static UINT ITERATE_WriteRegistryValues(MSIRECORD *row, LPVOID param) { ERR("Could not create key %s\n", debugstr_w(keypath)); msi_free(uikey); + msi_free(keypath); return ERROR_SUCCESS; } @@ -2786,6 +2787,7 @@ static UINT ITERATE_WriteRegistryValues(MSIRECORD *row, LPVOID param) msi_free(value_data); msi_free(deformated); msi_free(uikey); + msi_free(keypath); return ERROR_SUCCESS; }

1 0

Michael Stefaniuc : avifil32: Avoid the forward declaration of the IAVIStream methods.
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: c567d1e4619d8486a7b37140b26905ba685dddde URL: http://source.winehq.org/git/wine.git/?a=commit;h=c567d1e4619d8486a7b37140b… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Jan 12 11:21:56 2011 +0100 avifil32: Avoid the forward declaration of the IAVIStream methods. --- dlls/avifil32/acmstream.c | 177 ++++++++++++++++++++------------------------- 1 files changed, 79 insertions(+), 98 deletions(-) diff --git a/dlls/avifil32/acmstream.c b/dlls/avifil32/acmstream.c index 5ff84d5..50e868b 100644 --- a/dlls/avifil32/acmstream.c +++ b/dlls/avifil32/acmstream.c @@ -36,38 +36,6 @@ WINE_DEFAULT_DEBUG_CHANNEL(avifile); /***********************************************************************/ -static HRESULT WINAPI ACMStream_fnQueryInterface(IAVIStream*iface,REFIID refiid,LPVOID *obj); -static ULONG WINAPI ACMStream_fnAddRef(IAVIStream*iface); -static ULONG WINAPI ACMStream_fnRelease(IAVIStream* iface); -static HRESULT WINAPI ACMStream_fnCreate(IAVIStream*iface,LPARAM lParam1,LPARAM lParam2); -static HRESULT WINAPI ACMStream_fnInfo(IAVIStream*iface,AVISTREAMINFOW *psi,LONG size); -static LONG WINAPI ACMStream_fnFindSample(IAVIStream*iface,LONG pos,LONG flags); -static HRESULT WINAPI ACMStream_fnReadFormat(IAVIStream*iface,LONG pos,LPVOID format,LONG *formatsize); -static HRESULT WINAPI ACMStream_fnSetFormat(IAVIStream*iface,LONG pos,LPVOID format,LONG formatsize); -static HRESULT WINAPI ACMStream_fnRead(IAVIStream*iface,LONG start,LONG samples,LPVOID buffer,LONG buffersize,LONG *bytesread,LONG *samplesread); -static HRESULT WINAPI ACMStream_fnWrite(IAVIStream*iface,LONG start,LONG samples,LPVOID buffer,LONG buffersize,DWORD flags,LONG *sampwritten,LONG *byteswritten); -static HRESULT WINAPI ACMStream_fnDelete(IAVIStream*iface,LONG start,LONG samples); -static HRESULT WINAPI ACMStream_fnReadData(IAVIStream*iface,DWORD fcc,LPVOID lp,LONG *lpread); -static HRESULT WINAPI ACMStream_fnWriteData(IAVIStream*iface,DWORD fcc,LPVOID lp,LONG size); -static HRESULT WINAPI ACMStream_fnSetInfo(IAVIStream*iface,AVISTREAMINFOW*info,LONG infolen); - -static const struct IAVIStreamVtbl iacmst = { - ACMStream_fnQueryInterface, - ACMStream_fnAddRef, - ACMStream_fnRelease, - ACMStream_fnCreate, - ACMStream_fnInfo, - ACMStream_fnFindSample, - ACMStream_fnReadFormat, - ACMStream_fnSetFormat, - ACMStream_fnRead, - ACMStream_fnWrite, - ACMStream_fnDelete, - ACMStream_fnReadData, - ACMStream_fnWriteData, - ACMStream_fnSetInfo -}; - typedef struct _IAVIStreamImpl { /* IUnknown stuff */ IAVIStream IAVIStream_iface; @@ -102,28 +70,63 @@ typedef struct _IAVIStreamImpl { &__bytes, ACM_STREAMSIZEF_DESTINATION); \ *(a) = __bytes / This->lpInFormat->nBlockAlign; } while(0) -static HRESULT AVIFILE_OpenCompressor(IAVIStreamImpl *This); - -HRESULT AVIFILE_CreateACMStream(REFIID riid, LPVOID *ppv) +static HRESULT AVIFILE_OpenCompressor(IAVIStreamImpl *This) { - IAVIStreamImpl *pstream; - HRESULT hr; + HRESULT hr; - assert(riid != NULL && ppv != NULL); + /* pre-conditions */ + assert(This != NULL); + assert(This->pStream != NULL); - *ppv = NULL; + if (This->has != NULL) + return AVIERR_OK; - pstream = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IAVIStreamImpl)); - if (pstream == NULL) - return AVIERR_MEMORY; + if (This->lpInFormat == NULL) { + /* decode or encode the data from pStream */ + hr = AVIStreamFormatSize(This->pStream, This->sInfo.dwStart, &This->cbInFormat); + if (FAILED(hr)) + return hr; + This->lpInFormat = HeapAlloc(GetProcessHeap(), 0, This->cbInFormat); + if (This->lpInFormat == NULL) + return AVIERR_MEMORY; - pstream->IAVIStream_iface.lpVtbl = &iacmst; + hr = IAVIStream_ReadFormat(This->pStream, This->sInfo.dwStart, + This->lpInFormat, &This->cbInFormat); + if (FAILED(hr)) + return hr; - hr = IAVIStream_QueryInterface(&pstream->IAVIStream_iface, riid, ppv); - if (FAILED(hr)) - HeapFree(GetProcessHeap(), 0, pstream); + if (This->lpOutFormat == NULL) { + /* we must decode to default format */ + This->cbOutFormat = sizeof(PCMWAVEFORMAT); + This->lpOutFormat = HeapAlloc(GetProcessHeap(), 0, This->cbOutFormat); + if (This->lpOutFormat == NULL) + return AVIERR_MEMORY; - return hr; + This->lpOutFormat->wFormatTag = WAVE_FORMAT_PCM; + if (acmFormatSuggest(NULL, This->lpInFormat, This->lpOutFormat, + This->cbOutFormat, ACM_FORMATSUGGESTF_WFORMATTAG) != S_OK) + return AVIERR_NOCOMPRESSOR; + } + } else if (This->lpOutFormat == NULL) + return AVIERR_ERROR; /* To what should I encode? */ + + if (acmStreamOpen(&This->has, NULL, This->lpInFormat, This->lpOutFormat, + NULL, 0, 0, ACM_STREAMOPENF_NONREALTIME) != S_OK) + return AVIERR_NOCOMPRESSOR; + + /* update AVISTREAMINFO structure */ + This->sInfo.dwSampleSize = This->lpOutFormat->nBlockAlign; + This->sInfo.dwScale = This->lpOutFormat->nBlockAlign; + This->sInfo.dwRate = This->lpOutFormat->nAvgBytesPerSec; + This->sInfo.dwQuality = (DWORD)ICQUALITY_DEFAULT; + SetRectEmpty(&This->sInfo.rcFrame); + + /* convert positions and sizes to output format */ + CONVERT_STREAM_to_THIS(&This->sInfo.dwStart); + CONVERT_STREAM_to_THIS(&This->sInfo.dwLength); + CONVERT_STREAM_to_THIS(&This->sInfo.dwSuggestedBufferSize); + + return AVIERR_OK; } static inline IAVIStreamImpl *impl_from_IAVIStream(IAVIStream *iface) @@ -681,63 +684,41 @@ static HRESULT WINAPI ACMStream_fnSetInfo(IAVIStream *iface, return E_FAIL; } -/***********************************************************************/ +static const struct IAVIStreamVtbl iacmst = { + ACMStream_fnQueryInterface, + ACMStream_fnAddRef, + ACMStream_fnRelease, + ACMStream_fnCreate, + ACMStream_fnInfo, + ACMStream_fnFindSample, + ACMStream_fnReadFormat, + ACMStream_fnSetFormat, + ACMStream_fnRead, + ACMStream_fnWrite, + ACMStream_fnDelete, + ACMStream_fnReadData, + ACMStream_fnWriteData, + ACMStream_fnSetInfo +}; -static HRESULT AVIFILE_OpenCompressor(IAVIStreamImpl *This) +HRESULT AVIFILE_CreateACMStream(REFIID riid, LPVOID *ppv) { - HRESULT hr; - - /* pre-conditions */ - assert(This != NULL); - assert(This->pStream != NULL); - - if (This->has != NULL) - return AVIERR_OK; - - if (This->lpInFormat == NULL) { - /* decode or encode the data from pStream */ - hr = AVIStreamFormatSize(This->pStream, This->sInfo.dwStart, &This->cbInFormat); - if (FAILED(hr)) - return hr; - This->lpInFormat = HeapAlloc(GetProcessHeap(), 0, This->cbInFormat); - if (This->lpInFormat == NULL) - return AVIERR_MEMORY; - - hr = IAVIStream_ReadFormat(This->pStream, This->sInfo.dwStart, - This->lpInFormat, &This->cbInFormat); - if (FAILED(hr)) - return hr; + IAVIStreamImpl *pstream; + HRESULT hr; - if (This->lpOutFormat == NULL) { - /* we must decode to default format */ - This->cbOutFormat = sizeof(PCMWAVEFORMAT); - This->lpOutFormat = HeapAlloc(GetProcessHeap(), 0, This->cbOutFormat); - if (This->lpOutFormat == NULL) - return AVIERR_MEMORY; + assert(riid != NULL && ppv != NULL); - This->lpOutFormat->wFormatTag = WAVE_FORMAT_PCM; - if (acmFormatSuggest(NULL, This->lpInFormat, This->lpOutFormat, - This->cbOutFormat, ACM_FORMATSUGGESTF_WFORMATTAG) != S_OK) - return AVIERR_NOCOMPRESSOR; - } - } else if (This->lpOutFormat == NULL) - return AVIERR_ERROR; /* To what should I encode? */ + *ppv = NULL; - if (acmStreamOpen(&This->has, NULL, This->lpInFormat, This->lpOutFormat, - NULL, 0, 0, ACM_STREAMOPENF_NONREALTIME) != S_OK) - return AVIERR_NOCOMPRESSOR; + pstream = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(IAVIStreamImpl)); + if (pstream == NULL) + return AVIERR_MEMORY; - /* update AVISTREAMINFO structure */ - This->sInfo.dwSampleSize = This->lpOutFormat->nBlockAlign; - This->sInfo.dwScale = This->lpOutFormat->nBlockAlign; - This->sInfo.dwRate = This->lpOutFormat->nAvgBytesPerSec; - This->sInfo.dwQuality = (DWORD)ICQUALITY_DEFAULT; - SetRectEmpty(&This->sInfo.rcFrame); + pstream->IAVIStream_iface.lpVtbl = &iacmst; - /* convert positions and sizes to output format */ - CONVERT_STREAM_to_THIS(&This->sInfo.dwStart); - CONVERT_STREAM_to_THIS(&This->sInfo.dwLength); - CONVERT_STREAM_to_THIS(&This->sInfo.dwSuggestedBufferSize); + hr = IAVIStream_QueryInterface(&pstream->IAVIStream_iface, riid, ppv); + if (FAILED(hr)) + HeapFree(GetProcessHeap(), 0, pstream); - return AVIERR_OK; + return hr; }

1 0

Michael Stefaniuc : avifil32: COM cleanup for acmstream.c.
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: 1f8e505dc2814a3ea551b094b546d71173a1ea84 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1f8e505dc2814a3ea551b094b… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Jan 12 11:19:49 2011 +0100 avifil32: COM cleanup for acmstream.c. --- dlls/avifil32/acmstream.c | 37 +++++++++++++++++++++---------------- 1 files changed, 21 insertions(+), 16 deletions(-) diff --git a/dlls/avifil32/acmstream.c b/dlls/avifil32/acmstream.c index 7794f54..5ff84d5 100644 --- a/dlls/avifil32/acmstream.c +++ b/dlls/avifil32/acmstream.c @@ -70,7 +70,7 @@ static const struct IAVIStreamVtbl iacmst = { typedef struct _IAVIStreamImpl { /* IUnknown stuff */ - const IAVIStreamVtbl *lpVtbl; + IAVIStream IAVIStream_iface; LONG ref; /* IAVIStream stuff */ @@ -117,19 +117,24 @@ HRESULT AVIFILE_CreateACMStream(REFIID riid, LPVOID *ppv) if (pstream == NULL) return AVIERR_MEMORY; - pstream->lpVtbl = &iacmst; + pstream->IAVIStream_iface.lpVtbl = &iacmst; - hr = IAVIStream_QueryInterface((IAVIStream*)pstream, riid, ppv); + hr = IAVIStream_QueryInterface(&pstream->IAVIStream_iface, riid, ppv); if (FAILED(hr)) HeapFree(GetProcessHeap(), 0, pstream); return hr; } +static inline IAVIStreamImpl *impl_from_IAVIStream(IAVIStream *iface) +{ + return CONTAINING_RECORD(iface, IAVIStreamImpl, IAVIStream_iface); +} + static HRESULT WINAPI ACMStream_fnQueryInterface(IAVIStream *iface, REFIID refiid, LPVOID *obj) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); TRACE("(%p,%s,%p)\n", iface, debugstr_guid(refiid), obj); @@ -146,7 +151,7 @@ static HRESULT WINAPI ACMStream_fnQueryInterface(IAVIStream *iface, static ULONG WINAPI ACMStream_fnAddRef(IAVIStream *iface) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); ULONG ref = InterlockedIncrement(&This->ref); TRACE("(%p) -> %d\n", iface, ref); @@ -160,7 +165,7 @@ static ULONG WINAPI ACMStream_fnAddRef(IAVIStream *iface) static ULONG WINAPI ACMStream_fnRelease(IAVIStream* iface) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); ULONG ref = InterlockedDecrement(&This->ref); TRACE("(%p) -> %d\n", iface, ref); @@ -209,7 +214,7 @@ static ULONG WINAPI ACMStream_fnRelease(IAVIStream* iface) static HRESULT WINAPI ACMStream_fnCreate(IAVIStream *iface, LPARAM lParam1, LPARAM lParam2) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); TRACE("(%p,0x%08lX,0x%08lX)\n", iface, lParam1, lParam2); @@ -262,7 +267,7 @@ static HRESULT WINAPI ACMStream_fnCreate(IAVIStream *iface, LPARAM lParam1, static HRESULT WINAPI ACMStream_fnInfo(IAVIStream *iface,LPAVISTREAMINFOW psi, LONG size) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); TRACE("(%p,%p,%d)\n", iface, psi, size); @@ -289,7 +294,7 @@ static HRESULT WINAPI ACMStream_fnInfo(IAVIStream *iface,LPAVISTREAMINFOW psi, static LONG WINAPI ACMStream_fnFindSample(IAVIStream *iface, LONG pos, LONG flags) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); TRACE("(%p,%d,0x%08X)\n",iface,pos,flags); @@ -317,7 +322,7 @@ static LONG WINAPI ACMStream_fnFindSample(IAVIStream *iface, LONG pos, static HRESULT WINAPI ACMStream_fnReadFormat(IAVIStream *iface, LONG pos, LPVOID format, LONG *formatsize) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); TRACE("(%p,%d,%p,%p)\n", iface, pos, format, formatsize); @@ -352,7 +357,7 @@ static HRESULT WINAPI ACMStream_fnReadFormat(IAVIStream *iface, LONG pos, static HRESULT WINAPI ACMStream_fnSetFormat(IAVIStream *iface, LONG pos, LPVOID format, LONG formatsize) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); HRESULT hr; @@ -399,7 +404,7 @@ static HRESULT WINAPI ACMStream_fnRead(IAVIStream *iface, LONG start, LONG buffersize, LPLONG bytesread, LPLONG samplesread) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); HRESULT hr; DWORD size; @@ -520,7 +525,7 @@ static HRESULT WINAPI ACMStream_fnWrite(IAVIStream *iface, LONG start, LPLONG sampwritten, LPLONG byteswritten) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); HRESULT hr; ULONG size; @@ -613,7 +618,7 @@ static HRESULT WINAPI ACMStream_fnWrite(IAVIStream *iface, LONG start, static HRESULT WINAPI ACMStream_fnDelete(IAVIStream *iface, LONG start, LONG samples) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); TRACE("(%p,%d,%d)\n", iface, start, samples); @@ -647,7 +652,7 @@ static HRESULT WINAPI ACMStream_fnDelete(IAVIStream *iface, LONG start, static HRESULT WINAPI ACMStream_fnReadData(IAVIStream *iface, DWORD fcc, LPVOID lp, LPLONG lpread) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); TRACE("(%p,0x%08X,%p,%p)\n", iface, fcc, lp, lpread); @@ -659,7 +664,7 @@ static HRESULT WINAPI ACMStream_fnReadData(IAVIStream *iface, DWORD fcc, static HRESULT WINAPI ACMStream_fnWriteData(IAVIStream *iface, DWORD fcc, LPVOID lp, LONG size) { - IAVIStreamImpl *This = (IAVIStreamImpl *)iface; + IAVIStreamImpl *This = impl_from_IAVIStream(iface); TRACE("(%p,0x%08x,%p,%d)\n", iface, fcc, lp, size);

1 0

Andrew Nguyen : advapi32: Convert the trustee name buffer based on trustee form in SetEntriesInAclA.
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: 97fa635fc71d80252445e4f3c5d42a93c90c586b URL: http://source.winehq.org/git/wine.git/?a=commit;h=97fa635fc71d80252445e4f3c… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Tue Jan 11 23:37:51 2011 -0600 advapi32: Convert the trustee name buffer based on trustee form in SetEntriesInAclA. --- dlls/advapi32/security.c | 178 ++++++++++++++++++++++++++++++++++++--------- 1 files changed, 142 insertions(+), 36 deletions(-) diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index 629a264..de090dc 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -3515,6 +3515,114 @@ BOOL WINAPI SetAclInformation( PACL pAcl, LPVOID pAclInformation, return TRUE; } +DWORD trustee_name_A_to_W(TRUSTEE_FORM form, char *trustee_nameA, WCHAR **ptrustee_nameW) +{ + DWORD len; + + switch (form) + { + case TRUSTEE_IS_NAME: + { + WCHAR *wstr = NULL; + + if (trustee_nameA) + { + len = MultiByteToWideChar( CP_ACP, 0, trustee_nameA, -1, NULL, 0 ); + if (!(wstr = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ))) + return ERROR_NOT_ENOUGH_MEMORY; + + MultiByteToWideChar( CP_ACP, 0, trustee_nameA, -1, wstr, len ); + } + + *ptrustee_nameW = wstr; + return ERROR_SUCCESS; + } + case TRUSTEE_IS_OBJECTS_AND_NAME: + { + OBJECTS_AND_NAME_A *objA = (OBJECTS_AND_NAME_A *)trustee_nameA; + OBJECTS_AND_NAME_W *objW = NULL; + + if (objA) + { + if (!(objW = HeapAlloc( GetProcessHeap(), 0, sizeof(OBJECTS_AND_NAME_W) ))) + return ERROR_NOT_ENOUGH_MEMORY; + + objW->ObjectsPresent = objA->ObjectsPresent; + objW->ObjectType = objA->ObjectType; + objW->ObjectTypeName = NULL; + objW->InheritedObjectTypeName = NULL; + objW->ptstrName = NULL; + + if (objA->ObjectTypeName) + { + len = MultiByteToWideChar( CP_ACP, 0, objA->ObjectTypeName, -1, NULL, 0 ); + if (!(objW->ObjectTypeName = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ))) + goto error; + MultiByteToWideChar( CP_ACP, 0, objA->ObjectTypeName, -1, objW->ObjectTypeName, len ); + } + + if (objA->InheritedObjectTypeName) + { + len = MultiByteToWideChar( CP_ACP, 0, objA->InheritedObjectTypeName, -1, NULL, 0 ); + if (!(objW->InheritedObjectTypeName = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ))) + goto error; + MultiByteToWideChar( CP_ACP, 0, objA->InheritedObjectTypeName, -1, objW->InheritedObjectTypeName, len ); + } + + if (objA->ptstrName) + { + len = MultiByteToWideChar( CP_ACP, 0, objA->ptstrName, -1, NULL, 0 ); + if (!(objW->ptstrName = HeapAlloc( GetProcessHeap(), 0, len * sizeof(WCHAR) ))) + goto error; + MultiByteToWideChar( CP_ACP, 0, objA->ptstrName, -1, objW->ptstrName, len ); + } + } + + *ptrustee_nameW = (WCHAR *)objW; + return ERROR_SUCCESS; +error: + HeapFree( GetProcessHeap(), 0, objW->InheritedObjectTypeName ); + HeapFree( GetProcessHeap(), 0, objW->ObjectTypeName ); + HeapFree( GetProcessHeap(), 0, objW ); + return ERROR_NOT_ENOUGH_MEMORY; + } + /* These forms do not require conversion. */ + case TRUSTEE_IS_SID: + case TRUSTEE_IS_OBJECTS_AND_SID: + *ptrustee_nameW = (WCHAR *)trustee_nameA; + return ERROR_SUCCESS; + default: + return ERROR_INVALID_PARAMETER; + } +} + +void free_trustee_name(TRUSTEE_FORM form, WCHAR *trustee_nameW) +{ + switch (form) + { + case TRUSTEE_IS_NAME: + HeapFree( GetProcessHeap(), 0, trustee_nameW ); + break; + case TRUSTEE_IS_OBJECTS_AND_NAME: + { + OBJECTS_AND_NAME_W *objW = (OBJECTS_AND_NAME_W *)trustee_nameW; + + if (objW) + { + HeapFree( GetProcessHeap(), 0, objW->ptstrName ); + HeapFree( GetProcessHeap(), 0, objW->InheritedObjectTypeName ); + HeapFree( GetProcessHeap(), 0, objW->ObjectTypeName ); + HeapFree( GetProcessHeap(), 0, objW ); + } + + break; + } + /* Other forms did not require allocation, so no freeing is necessary. */ + default: + break; + } +} + /****************************************************************************** * SetEntriesInAclA [ADVAPI32.@] */ @@ -3522,7 +3630,8 @@ DWORD WINAPI SetEntriesInAclA( ULONG count, PEXPLICIT_ACCESSA pEntries, PACL OldAcl, PACL* NewAcl ) { DWORD err = ERROR_SUCCESS; - PEXPLICIT_ACCESSW pEntriesW; + EXPLICIT_ACCESSW *pEntriesW; + int alloc_index, free_index; TRACE("%d %p %p %p\n", count, pEntries, OldAcl, NewAcl); @@ -3532,46 +3641,43 @@ DWORD WINAPI SetEntriesInAclA( ULONG count, PEXPLICIT_ACCESSA pEntries, if (!count && !OldAcl) return ERROR_SUCCESS; - pEntriesW = HeapAlloc( GetProcessHeap(), 0, count*sizeof(EXPLICIT_ACCESSW) ); - if (pEntriesW) - { - int i, len; - LPWSTR wstr = NULL; - PEXPLICIT_ACCESSW ptrW = pEntriesW; - PEXPLICIT_ACCESSA ptrA = pEntries; + pEntriesW = HeapAlloc( GetProcessHeap(), 0, count * sizeof(EXPLICIT_ACCESSW) ); + if (!pEntriesW) + return ERROR_NOT_ENOUGH_MEMORY; - for (i = 0; i < count; ++i, ++ptrA, ++ptrW) + for (alloc_index = 0; alloc_index < count; ++alloc_index) + { + pEntriesW[alloc_index].grfAccessPermissions = pEntries[alloc_index].grfAccessPermissions; + pEntriesW[alloc_index].grfAccessMode = pEntries[alloc_index].grfAccessMode; + pEntriesW[alloc_index].grfInheritance = pEntries[alloc_index].grfInheritance; + pEntriesW[alloc_index].Trustee.pMultipleTrustee = NULL; /* currently not supported */ + pEntriesW[alloc_index].Trustee.MultipleTrusteeOperation = pEntries[alloc_index].Trustee.MultipleTrusteeOperation; + pEntriesW[alloc_index].Trustee.TrusteeForm = pEntries[alloc_index].Trustee.TrusteeForm; + pEntriesW[alloc_index].Trustee.TrusteeType = pEntries[alloc_index].Trustee.TrusteeType; + + err = trustee_name_A_to_W( pEntries[alloc_index].Trustee.TrusteeForm, + pEntries[alloc_index].Trustee.ptstrName, + &pEntriesW[alloc_index].Trustee.ptstrName ); + if (err != ERROR_SUCCESS) { - ptrW->grfAccessPermissions = ptrA->grfAccessPermissions; - ptrW->grfAccessMode = ptrA->grfAccessMode; - ptrW->grfInheritance = ptrA->grfInheritance; - ptrW->Trustee.pMultipleTrustee = NULL; /* currently not supported */ - ptrW->Trustee.MultipleTrusteeOperation = ptrA->Trustee.MultipleTrusteeOperation; - ptrW->Trustee.TrusteeForm = ptrA->Trustee.TrusteeForm; - ptrW->Trustee.TrusteeType = ptrA->Trustee.TrusteeType; - wstr = NULL; - if (ptrA->Trustee.ptstrName) - { - len = MultiByteToWideChar( CP_ACP, 0, ptrA->Trustee.ptstrName, -1, NULL, 0 ); - wstr = HeapAlloc( GetProcessHeap(), 0, len*sizeof(WCHAR)); - MultiByteToWideChar( CP_ACP, 0, ptrA->Trustee.ptstrName, -1, wstr, len ); - } - ptrW->Trustee.ptstrName = wstr; - } - - err = SetEntriesInAclW( count, pEntriesW, OldAcl, NewAcl ); + if (err == ERROR_INVALID_PARAMETER) + WARN("bad trustee form %d for trustee %d\n", + pEntries[alloc_index].Trustee.TrusteeForm, alloc_index); - ptrW = pEntriesW; - for (i = 0; i < count; ++i, ++ptrW) - { - HeapFree( GetProcessHeap(), 0, ptrW->Trustee.ptstrName ); + goto cleanup; } - HeapFree( GetProcessHeap(), 0, pEntriesW ); - } - else - { - err = ERROR_NOT_ENOUGH_MEMORY; } + + err = SetEntriesInAclW( count, pEntriesW, OldAcl, NewAcl ); + +cleanup: + /* Free any previously allocated trustee name buffers, taking into account + * a possible out-of-memory condition while building the EXPLICIT_ACCESSW + * list. */ + for (free_index = 0; free_index < alloc_index; ++free_index) + free_trustee_name( pEntriesW[free_index].Trustee.TrusteeForm, pEntriesW[free_index].Trustee.ptstrName ); + + HeapFree( GetProcessHeap(), 0, pEntriesW ); return err; }

1 0

Dylan Smith : richedit: Clear non-default style when changing to plain text mode.
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: d43cddcc8351215eb4f60e1a41439e29261f1268 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d43cddcc8351215eb4f60e1a4… Author: Dylan Smith <dylan.ah.smith(a)gmail.com> Date: Wed Jan 12 02:23:40 2011 -0500 richedit: Clear non-default style when changing to plain text mode. Although the text must be empty for the mode to change to plain text mode, there still may be a non-default style for the temporary insert style and style for the end of text run. --- dlls/riched20/editor.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c index 48b64c9..aace0ea 100644 --- a/dlls/riched20/editor.c +++ b/dlls/riched20/editor.c @@ -4332,6 +4332,18 @@ LRESULT ME_HandleMessage(ME_TextEditor *editor, UINT msg, WPARAM wParam, { mask |= TM_RICHTEXT | TM_PLAINTEXT; changes |= wParam & (TM_RICHTEXT | TM_PLAINTEXT); + if (wParam & TM_PLAINTEXT) { + /* Clear selection since it should be possible to select the + * end of text run for rich text */ + ME_InvalidateSelection(editor); + ME_SetCursorToStart(editor, &editor->pCursors[0]); + editor->pCursors[1] = editor->pCursors[0]; + /* plain text can only have the default style. */ + ME_ClearTempStyle(editor); + ME_AddRefStyle(editor->pBuffer->pDefaultStyle); + ME_ReleaseStyle(editor->pCursors[0].pRun->member.run.style); + editor->pCursors[0].pRun->member.run.style = editor->pBuffer->pDefaultStyle; + } } /* FIXME: Currently no support for undo level and code page options */ editor->mode = (editor->mode & ~mask) | changes;

1 0

Ken Thomases : winemenubuilder: On Mac, size is implicit in ICNS slot; don' t search for best.
by Alexandre Julliard 12 Jan '11

12 Jan '11

Module: wine Branch: master Commit: e72a37e9604ae1a14d4928abbe7551aac8c38cdf URL: http://source.winehq.org/git/wine.git/?a=commit;h=e72a37e9604ae1a14d4928abb… Author: Ken Thomases <ken(a)codeweavers.com> Date: Wed Jan 12 00:17:30 2011 -0600 winemenubuilder: On Mac, size is implicit in ICNS slot; don't search for best. --- programs/winemenubuilder/winemenubuilder.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/programs/winemenubuilder/winemenubuilder.c b/programs/winemenubuilder/winemenubuilder.c index 8cafce0..56ff158 100644 --- a/programs/winemenubuilder/winemenubuilder.c +++ b/programs/winemenubuilder/winemenubuilder.c @@ -839,7 +839,6 @@ static HRESULT platform_write_icon(IStream *icoStream, int exeIndex, LPCWSTR ico int numEntries; struct { int index; - int maxPixels; int maxBits; } best[ICNS_SLOTS]; int indexes[ICNS_SLOTS]; @@ -857,7 +856,6 @@ static HRESULT platform_write_icon(IStream *icoStream, int exeIndex, LPCWSTR ico for (i = 0; i < ICNS_SLOTS; i++) { best[i].index = -1; - best[i].maxPixels = 0; best[i].maxBits = 0; } for (i = 0; i < numEntries; i++) @@ -872,11 +870,9 @@ static HRESULT platform_write_icon(IStream *icoStream, int exeIndex, LPCWSTR ico slot = size_to_slot(width); if (slot < 0) continue; - if (iconDirEntries[i].wBitCount >= best[slot].maxBits && - (height * width) >= best[slot].maxPixels) + if (iconDirEntries[i].wBitCount >= best[slot].maxBits) { best[slot].index = i; - best[slot].maxPixels = height * width; best[slot].maxBits = iconDirEntries[i].wBitCount; } }

1 0

← Newer
1
...
51
52
53
54
55
56
57
...
88
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits January 2011