wine-commits October 2011

wine-commits@winehq.org

3 participants
783 discussions

Marcus Meissner : winecfg: Added missing break (Coverity).
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: 90c8798266cf3996b599109ae48983749ea4f024 URL: http://source.winehq.org/git/wine.git/?a=commit;h=90c8798266cf3996b599109ae… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sun Oct 16 13:04:35 2011 +0200 winecfg: Added missing break (Coverity). --- programs/winecfg/audio.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/programs/winecfg/audio.c b/programs/winecfg/audio.c index e43d89b..dc3e2bc 100644 --- a/programs/winecfg/audio.c +++ b/programs/winecfg/audio.c @@ -371,6 +371,8 @@ AudioDlgProc (HWND hDlg, UINT uMsg, WPARAM wParam, LPARAM lParam) } break; } + break; + case WM_SHOWWINDOW: set_window_title(hDlg); break;

1 0

Marcus Meissner : dsound: Added missing LeaveCriticalSection (Coverity).
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: 07d72eb57099f5537fce3b053943f91fb9158de8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=07d72eb57099f5537fce3b053… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sun Oct 16 13:09:44 2011 +0200 dsound: Added missing LeaveCriticalSection (Coverity). --- dlls/dsound/capture.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c index 77ce7b6..92dc24f 100644 --- a/dlls/dsound/capture.c +++ b/dlls/dsound/capture.c @@ -1036,6 +1036,7 @@ static HRESULT DirectSoundCaptureDevice_Initialize( if(FAILED(hr)){ DeleteCriticalSection(&device->lock); HeapFree(GetProcessHeap(), 0, device); + LeaveCriticalSection(&DSOUND_capturers_lock); return DSERR_NODRIVER; }

1 0

Marcus Meissner : wined3d: Fixed sizeof (Coverity).
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: f90d40261057b5f4c9dc4190129df6275e6a0c79 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f90d40261057b5f4c9dc41901… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sun Oct 16 23:11:48 2011 +0200 wined3d: Fixed sizeof (Coverity). --- dlls/wined3d/swapchain.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index 126a991..1678dce 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -987,7 +987,7 @@ static HRESULT swapchain_init(struct wined3d_swapchain *swapchain, WINED3DSURFTY const struct wined3d_gl_info *gl_info = &device->adapter->gl_info; - swapchain->context = HeapAlloc(GetProcessHeap(), 0, sizeof(swapchain->context)); + swapchain->context = HeapAlloc(GetProcessHeap(), 0, sizeof(*swapchain->context)); if (!swapchain->context) { ERR("Failed to create the context array.\n");

1 0

Marcus Meissner : winhttp: Fixed sizeof calls (Coverity).
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: 8648c1314011afd6300f97f9671af6797a205a02 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8648c1314011afd6300f97f96… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Sun Oct 16 22:55:32 2011 +0200 winhttp: Fixed sizeof calls (Coverity). --- dlls/winhttp/tests/winhttp.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 24478ad..01b74e3 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -659,7 +659,8 @@ static void test_WinHttpAddHeaders(void) test_header_name, buffer, &len, &index); ok(ret == TRUE, "WinHttpQueryHeaders failed: %u\n", GetLastError()); ok(index == 1, "WinHttpQueryHeaders failed to increment index.\n"); - ok(memcmp(buffer, reverse ? test_flag_coalesce_reverse : test_flag_coalesce, sizeof(reverse ? test_flag_coalesce_reverse : test_flag_coalesce)) == 0, "WinHttpQueryHeaders returned incorrect string.\n"); + ok(memcmp(buffer, reverse ? test_flag_coalesce_reverse : test_flag_coalesce, + reverse ? sizeof(test_flag_coalesce_reverse) : sizeof(test_flag_coalesce)) == 0, "WinHttpQueryHeaders returned incorrect string.\n"); len = sizeof(buffer); ret = WinHttpQueryHeaders(request, WINHTTP_QUERY_CUSTOM | WINHTTP_QUERY_FLAG_REQUEST_HEADERS, @@ -683,7 +684,8 @@ static void test_WinHttpAddHeaders(void) test_header_name, buffer, &len, &index); ok(ret == TRUE, "WinHttpQueryHeaders failed: %u\n", GetLastError()); ok(index == 1, "WinHttpQueryHeaders failed to increment index.\n"); - ok(memcmp(buffer, reverse ? test_flag_coalesce_comma_reverse : test_flag_coalesce_comma, sizeof(reverse ? test_flag_coalesce_comma_reverse : test_flag_coalesce_comma)) == 0, + ok(memcmp(buffer, reverse ? test_flag_coalesce_comma_reverse : test_flag_coalesce_comma, + reverse ? sizeof(test_flag_coalesce_comma_reverse) : sizeof(test_flag_coalesce_comma)) == 0, "WinHttpQueryHeaders returned incorrect string.\n"); len = sizeof(buffer); @@ -709,7 +711,8 @@ static void test_WinHttpAddHeaders(void) test_header_name, buffer, &len, &index); ok(ret == TRUE, "WinHttpQueryHeaders failed: %u\n", GetLastError()); ok(index == 1, "WinHttpQueryHeaders failed to increment index.\n"); - ok(memcmp(buffer, reverse ? test_flag_coalesce_semicolon_reverse : test_flag_coalesce_semicolon, sizeof(reverse ? test_flag_coalesce_semicolon_reverse : test_flag_coalesce_semicolon)) == 0, + ok(memcmp(buffer, reverse ? test_flag_coalesce_semicolon_reverse : test_flag_coalesce_semicolon, + reverse ? sizeof(test_flag_coalesce_semicolon_reverse) : sizeof(test_flag_coalesce_semicolon)) == 0, "WinHttpQueryHeaders returned incorrect string.\n"); len = sizeof(buffer);

1 0

Henri Verbeet : wined3d: Make the device parameter to wined3d_device_get_depth_stencil() const.
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: fcd1de2b09b11ce8fb67cd3457e7448b04b6b81c URL: http://source.winehq.org/git/wine.git/?a=commit;h=fcd1de2b09b11ce8fb67cd345… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Sun Oct 16 21:55:33 2011 +0200 wined3d: Make the device parameter to wined3d_device_get_depth_stencil() const. --- dlls/wined3d/device.c | 3 ++- include/wine/wined3d.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index c56dfe5..10ea92d 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -4962,7 +4962,8 @@ HRESULT CDECL wined3d_device_get_render_target(const struct wined3d_device *devi return WINED3D_OK; } -HRESULT CDECL wined3d_device_get_depth_stencil(struct wined3d_device *device, struct wined3d_surface **depth_stencil) +HRESULT CDECL wined3d_device_get_depth_stencil(const struct wined3d_device *device, + struct wined3d_surface **depth_stencil) { TRACE("device %p, depth_stencil %p.\n", device, depth_stencil); diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index b93bfb2..7e382e1 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -2211,7 +2211,7 @@ HRESULT __cdecl wined3d_device_get_clip_plane(const struct wined3d_device *devic HRESULT __cdecl wined3d_device_get_clip_status(const struct wined3d_device *device, WINED3DCLIPSTATUS *clip_status); HRESULT __cdecl wined3d_device_get_creation_parameters(struct wined3d_device *device, WINED3DDEVICE_CREATION_PARAMETERS *creation_parameters); -HRESULT __cdecl wined3d_device_get_depth_stencil(struct wined3d_device *device, +HRESULT __cdecl wined3d_device_get_depth_stencil(const struct wined3d_device *device, struct wined3d_surface **depth_stencil); HRESULT __cdecl wined3d_device_get_device_caps(const struct wined3d_device *device, WINED3DCAPS *caps); HRESULT __cdecl wined3d_device_get_display_mode(const struct wined3d_device *device,

1 0

Henri Verbeet : wined3d: Make the device parameter to wined3d_device_get_render_target() const.
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: ebbd5ecf7c41a0a9afde070a5e2341a61e439de9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ebbd5ecf7c41a0a9afde070a5… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Sun Oct 16 21:55:32 2011 +0200 wined3d: Make the device parameter to wined3d_device_get_render_target() const. --- dlls/wined3d/device.c | 2 +- include/wine/wined3d.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 20bf808..c56dfe5 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -4939,7 +4939,7 @@ void CDECL wined3d_device_clear_rendertarget_view(struct wined3d_device *device, if (FAILED(hr)) ERR("Color fill failed, hr %#x.\n", hr); } -HRESULT CDECL wined3d_device_get_render_target(struct wined3d_device *device, +HRESULT CDECL wined3d_device_get_render_target(const struct wined3d_device *device, UINT render_target_idx, struct wined3d_surface **render_target) { TRACE("device %p, render_target_idx %u, render_target %p.\n", diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index e466400..b93bfb2 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -2238,7 +2238,7 @@ HRESULT __cdecl wined3d_device_get_raster_status(const struct wined3d_device *de UINT swapchain_idx, WINED3DRASTER_STATUS *raster_status); HRESULT __cdecl wined3d_device_get_render_state(const struct wined3d_device *device, WINED3DRENDERSTATETYPE state, DWORD *value); -HRESULT __cdecl wined3d_device_get_render_target(struct wined3d_device *device, +HRESULT __cdecl wined3d_device_get_render_target(const struct wined3d_device *device, UINT render_target_idx, struct wined3d_surface **render_target); HRESULT __cdecl wined3d_device_get_sampler_state(const struct wined3d_device *device, UINT sampler_idx, WINED3DSAMPLERSTATETYPE state, DWORD *value);

1 0

Henri Verbeet : wined3d: Also restore the pixel format in context_restore_gl_context().
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: 25b1130b44c2d64effbf259ba174fc5a32d33c4d URL: http://source.winehq.org/git/wine.git/?a=commit;h=25b1130b44c2d64effbf259ba… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Sun Oct 16 21:55:31 2011 +0200 wined3d: Also restore the pixel format in context_restore_gl_context(). --- dlls/wined3d/context.c | 29 ++++++++++++++++++++++++----- dlls/wined3d/wined3d_private.h | 1 + 2 files changed, 25 insertions(+), 5 deletions(-) diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index ef8b94e..fc66a98 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -724,7 +724,8 @@ static BOOL context_set_pixel_format(const struct wined3d_gl_info *gl_info, HDC { if (!SetPixelFormat(dc, format, NULL)) { - ERR("Failed to set pixel format %d on device context %p, last error %#x.\n", + /* This may also happen if the dc belongs to a destroyed window. */ + WARN("Failed to set pixel format %d on device context %p, last error %#x.\n", format, dc, GetLastError()); return FALSE; } @@ -758,8 +759,16 @@ static BOOL context_set_pixel_format(const struct wined3d_gl_info *gl_info, HDC static BOOL context_set_gl_context(struct wined3d_context *ctx) { struct wined3d_swapchain *swapchain = ctx->swapchain; + BOOL backup = FALSE; - if (!pwglMakeCurrent(ctx->hdc, ctx->glCtx)) + if (!context_set_pixel_format(ctx->gl_info, ctx->hdc, ctx->pixel_format)) + { + WARN("Failed to set pixel format %d on device context %p.\n", + ctx->pixel_format, ctx->hdc); + backup = TRUE; + } + + if (backup || !pwglMakeCurrent(ctx->hdc, ctx->glCtx)) { HDC dc; @@ -804,8 +813,15 @@ static BOOL context_set_gl_context(struct wined3d_context *ctx) return TRUE; } -static void context_restore_gl_context(HDC dc, HGLRC gl_ctx) +static void context_restore_gl_context(const struct wined3d_gl_info *gl_info, HDC dc, HGLRC gl_ctx, int pf) { + if (!context_set_pixel_format(gl_info, dc, pf)) + { + ERR("Failed to restore pixel format %d on device context %p.\n", pf, dc); + context_set_current(NULL); + return; + } + if (!pwglMakeCurrent(dc, gl_ctx)) { ERR("Failed to restore GL context %p on device context %p, last error %#x.\n", @@ -876,9 +892,11 @@ static void context_destroy_gl_resources(struct wined3d_context *context) HGLRC restore_ctx; HDC restore_dc; unsigned int i; + int restore_pf; restore_ctx = pwglGetCurrentContext(); restore_dc = pwglGetCurrentDC(); + restore_pf = GetPixelFormat(restore_dc); if (context->valid && restore_ctx != context->glCtx) context_set_gl_context(context); @@ -961,7 +979,7 @@ static void context_destroy_gl_resources(struct wined3d_context *context) if (restore_ctx) { - context_restore_gl_context(restore_dc, restore_ctx); + context_restore_gl_context(gl_info, restore_dc, restore_ctx, restore_pf); } else if (pwglGetCurrentContext() && !pwglMakeCurrent(NULL, NULL)) { @@ -1060,7 +1078,7 @@ void context_release(struct wined3d_context *context) if (!--context->level && context->restore_ctx) { TRACE("Restoring GL context %p on device context %p.\n", context->restore_ctx, context->restore_dc); - context_restore_gl_context(context->restore_dc, context->restore_ctx); + context_restore_gl_context(context->gl_info, context->restore_dc, context->restore_ctx, context->restore_pf); context->restore_ctx = NULL; context->restore_dc = NULL; } @@ -1081,6 +1099,7 @@ static void context_enter(struct wined3d_context *context) current_gl, pwglGetCurrentDC()); context->restore_ctx = current_gl; context->restore_dc = pwglGetCurrentDC(); + context->restore_pf = GetPixelFormat(context->restore_dc); } } } diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index e5ed787..ebe277b 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1099,6 +1099,7 @@ struct wined3d_context UINT level; HGLRC restore_ctx; HDC restore_dc; + int restore_pf; HGLRC glCtx; HWND win_handle; HDC hdc;

1 0

Henri Verbeet : wined3d: Don' t try to access the swapchain of a destroyed context in context_set_gl_context ().
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: cdc9aadf5c9144920caefcfe7a0e12915ee0ce38 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cdc9aadf5c9144920caefcfe7… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Sun Oct 16 21:55:30 2011 +0200 wined3d: Don't try to access the swapchain of a destroyed context in context_set_gl_context(). --- dlls/wined3d/context.c | 11 +++++++++++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index 3353434..ef8b94e 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -768,6 +768,17 @@ static BOOL context_set_gl_context(struct wined3d_context *ctx) ctx->valid = 0; WARN("Trying fallback to the backup window.\n"); + /* FIXME: If the context is destroyed it's no longer associated with + * a swapchain, so we can't use the swapchain to get a backup dc. To + * make this work windowless contexts would need to be handled by the + * device. */ + if (ctx->destroyed) + { + FIXME("Unable to get backup dc for destroyed context %p.\n", ctx); + context_set_current(NULL); + return FALSE; + } + if (!(dc = swapchain_get_backup_dc(swapchain))) { context_set_current(NULL);

1 0

Henri Verbeet : wined3d: Don't bother updating the context' s window in context_destroy_gl_resources().
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: dfea2ab6f49bf986482c9784c4788b86323132f4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dfea2ab6f49bf986482c9784c… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Sun Oct 16 21:55:29 2011 +0200 wined3d: Don't bother updating the context's window in context_destroy_gl_resources(). context_update_window() accesses the swapchain, which may not exist if this is a destroyed context, and we don't do anything that needs displaying here anyway. --- dlls/wined3d/context.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/context.c b/dlls/wined3d/context.c index 9d15176..3353434 100644 --- a/dlls/wined3d/context.c +++ b/dlls/wined3d/context.c @@ -869,7 +869,6 @@ static void context_destroy_gl_resources(struct wined3d_context *context) restore_ctx = pwglGetCurrentContext(); restore_dc = pwglGetCurrentDC(); - context_update_window(context); if (context->valid && restore_ctx != context->glCtx) context_set_gl_context(context); else restore_ctx = NULL;

1 0

Vitaliy Margolen : dinput: Put some checks back into GetDeviceData for DirectInput 8.
by Alexandre Julliard 17 Oct '11

17 Oct '11

Module: wine Branch: master Commit: aba1ed78daaaa3de17761dc94471760048ce24c5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aba1ed78daaaa3de17761dc94… Author: Vitaliy Margolen <wine-patches(a)kievinfo.com> Date: Sun Oct 16 12:36:50 2011 -0600 dinput: Put some checks back into GetDeviceData for DirectInput 8. --- dlls/dinput/device.c | 6 ++++++ dlls/dinput8/tests/device.c | 36 +++++++++++++++++++++++++++++++++++- 2 files changed, 41 insertions(+), 1 deletions(-) diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c index 75b3cb5..b088eff 100644 --- a/dlls/dinput/device.c +++ b/dlls/dinput/device.c @@ -1283,6 +1283,12 @@ HRESULT WINAPI IDirectInputDevice2WImpl_GetDeviceData(LPDIRECTINPUTDEVICE8W ifac TRACE("(%p) %p -> %p(%d) x%d, 0x%08x\n", This, dod, entries, entries ? *entries : 0, dodsize, flags); + if (This->dinput->dwVersion == 0x0800) + { + if (!This->acquired) return DIERR_NOTACQUIRED; + if (!This->queue_len) return DIERR_NOTBUFFERED; + } + if (!This->queue_len) return DI_OK; if (dodsize < sizeof(DIDEVICEOBJECTDATA_DX3)) diff --git a/dlls/dinput8/tests/device.c b/dlls/dinput8/tests/device.c index 30c702f..ab44cf3 100644 --- a/dlls/dinput8/tests/device.c +++ b/dlls/dinput8/tests/device.c @@ -69,12 +69,13 @@ static void test_device_input( HRESULT hr; DIDEVICEOBJECTDATA obj_data; DWORD data_size = 1; + int i; hr = IDirectInputDevice8_Acquire(lpdid); ok (SUCCEEDED(hr), "Failed to acquire device hr=%08x\n", hr); if (event_type == INPUT_KEYBOARD) - keybd_event( event, 0, 0, 0); + keybd_event( event, DIK_SPACE, 0, 0); if (event_type == INPUT_MOUSE) mouse_event( event, 0, 0, 0, 0); @@ -89,6 +90,28 @@ static void test_device_input( } ok (obj_data.uAppData == expected, "Retrieval of action failed uAppData=%lu expected=%d\n", obj_data.uAppData, expected); + + /* Check for buffer owerflow */ + for (i = 0; i < 17; i++) + if (event_type == INPUT_KEYBOARD) + { + keybd_event( VK_SPACE, DIK_SPACE, 0, 0); + keybd_event( VK_SPACE, DIK_SPACE, KEYEVENTF_KEYUP, 0); + } + else if (event_type == INPUT_MOUSE) + { + mouse_event(MOUSEEVENTF_LEFTDOWN, 1, 1, 0, 0); + mouse_event(MOUSEEVENTF_LEFTUP, 1, 1, 0, 0); + } + + IDirectInputDevice8_Poll(lpdid); + + data_size = 1; + hr = IDirectInputDevice8_GetDeviceData(lpdid, sizeof(obj_data), &obj_data, &data_size, 0); + ok(hr == DI_BUFFEROVERFLOW, "GetDeviceData() failed: %08x\n", hr); + data_size = 1; + hr = IDirectInputDevice8_GetDeviceData(lpdid, sizeof(obj_data), &obj_data, &data_size, 0); + ok(hr == DI_OK && data_size == 1, "GetDeviceData() failed: %08x cnt:%d\n", hr, data_size); } static void test_build_action_map( @@ -134,6 +157,9 @@ static BOOL CALLBACK enumeration_callback( DIPROPDWORD dp; DIPROPRANGE dpr; struct enum_data *data = pvRef; + DWORD cnt; + DIDEVICEOBJECTDATA buffer[5]; + if (!data) return DIENUM_CONTINUE; data->ndevices++; @@ -180,6 +206,10 @@ static BOOL CALLBACK enumeration_callback( ok (SUCCEEDED(hr), "GetProperty failed hr=%08x\n", hr); ok (dp.dwData == data->lpdiaf->dwBufferSize, "SetActionMap must set the buffer, buffersize=%d\n", dp.dwData); + cnt = 1; + hr = IDirectInputDevice_GetDeviceData(lpdid, sizeof(buffer[0]), buffer, &cnt, 0); + ok(hr == DIERR_NOTACQUIRED, "GetDeviceData() failed hr=%08x\n", hr); + /* Test axis range */ memset(&dpr, 0, sizeof(dpr)); dpr.diph.dwSize = sizeof(dpr); @@ -198,6 +228,10 @@ static BOOL CALLBACK enumeration_callback( hr = IDirectInputDevice8_Acquire(lpdid); ok (SUCCEEDED(hr), "Acquire failed hr=%08x\n", hr); + cnt = 1; + hr = IDirectInputDevice_GetDeviceData(lpdid, sizeof(buffer[0]), buffer, &cnt, 0); + ok(hr == DI_OK, "GetDeviceData() failed hr=%08x\n", hr); + /* SetActionMap should not work on an acquired device */ hr = IDirectInputDevice8_SetActionMap(lpdid, data->lpdiaf, NULL, 0); ok (hr == DIERR_ACQUIRED, "SetActionMap succeeded with an acquired device hr=%08x\n", hr);

1 0

← Newer
1
...
40
41
42
43
44
45
46
...
79
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits October 2011