wine-commits October 2011

wine-commits@winehq.org

3 participants
783 discussions

Francois Gouget : kernel32/tests: Test K32GetProcessImageFileNameA() and improve the QueryFullProcessImageNameA() tests.
by Alexandre Julliard 04 Oct '11

04 Oct '11

Module: wine Branch: master Commit: 80ba9f35979a8042197c26019f84dad6074172e9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=80ba9f35979a8042197c26019… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Oct 4 05:11:40 2011 +0200 kernel32/tests: Test K32GetProcessImageFileNameA() and improve the QueryFullProcessImageNameA() tests. --- dlls/kernel32/tests/process.c | 64 +++++++++++++++++++++++++++++++++++++---- 1 files changed, 58 insertions(+), 6 deletions(-) diff --git a/dlls/kernel32/tests/process.c b/dlls/kernel32/tests/process.c index 61e3069..dfb2d2a 100644 --- a/dlls/kernel32/tests/process.c +++ b/dlls/kernel32/tests/process.c @@ -62,6 +62,7 @@ static LPVOID (WINAPI *pVirtualAllocEx)(HANDLE, LPVOID, SIZE_T, DWORD, DWORD); static BOOL (WINAPI *pVirtualFreeEx)(HANDLE, LPVOID, SIZE_T, DWORD); static BOOL (WINAPI *pQueryFullProcessImageNameA)(HANDLE hProcess, DWORD dwFlags, LPSTR lpExeName, PDWORD lpdwSize); static BOOL (WINAPI *pQueryFullProcessImageNameW)(HANDLE hProcess, DWORD dwFlags, LPWSTR lpExeName, PDWORD lpdwSize); +static DWORD (WINAPI *pK32GetProcessImageFileNameA)(HANDLE,LPSTR,DWORD); /* ############################### */ static char base[MAX_PATH]; @@ -204,6 +205,7 @@ static int init(void) pVirtualFreeEx = (void *) GetProcAddress(hkernel32, "VirtualFreeEx"); pQueryFullProcessImageNameA = (void *) GetProcAddress(hkernel32, "QueryFullProcessImageNameA"); pQueryFullProcessImageNameW = (void *) GetProcAddress(hkernel32, "QueryFullProcessImageNameW"); + pK32GetProcessImageFileNameA = (void *) GetProcAddress(hkernel32, "K32GetProcessImageFileNameA"); return 1; } @@ -1638,21 +1640,70 @@ static void test_GetProcessVersion(void) CloseHandle(pi.hThread); } -static void test_ProcessNameA(void) +static void test_GetProcessImageFileNameA(void) +{ + DWORD rc; + CHAR process[MAX_PATH]; + static const char harddisk[] = "\\Device\\HarddiskVolume"; + + if (!pK32GetProcessImageFileNameA) + { + win_skip("K32GetProcessImageFileNameA is unavailable\n"); + return; + } + + /* callers must guess the buffer size */ + SetLastError(0xdeadbeef); + rc = pK32GetProcessImageFileNameA(GetCurrentProcess(), NULL, 0); + ok(!rc && GetLastError() == ERROR_INSUFFICIENT_BUFFER, + "K32GetProcessImageFileNameA(no buffer): returned %u, le=%u\n", rc, GetLastError()); + + *process = '\0'; + rc = pK32GetProcessImageFileNameA(GetCurrentProcess(), process, sizeof(process)); + expect_eq_d(rc, lstrlenA(process)); + if (strncmp(process, harddisk, lstrlenA(harddisk))) + { + todo_wine win_skip("%s is probably on a network share, skipping tests\n", process); + return; + } + + if (!pQueryFullProcessImageNameA) + win_skip("QueryFullProcessImageNameA unavailable (added in Windows Vista)\n"); + else + { + CHAR image[MAX_PATH]; + DWORD length; + + length = sizeof(image); + expect_eq_d(TRUE, pQueryFullProcessImageNameA(GetCurrentProcess(), PROCESS_NAME_NATIVE, image, &length)); + expect_eq_d(length, lstrlenA(image)); + ok(lstrcmpi(process, image) == 0, "expected '%s' to be equal to '%s'\n", process, image); + } +} + +static void test_QueryFullProcessImageNameA(void) { #define INIT_STR "Just some words" DWORD length, size; - CHAR buf[1024]; + CHAR buf[MAX_PATH], module[MAX_PATH]; if (!pQueryFullProcessImageNameA) { win_skip("QueryFullProcessImageNameA unavailable (added in Windows Vista)\n"); return; } + + *module = '\0'; + SetLastError(0); /* old Windows don't reset it on success */ + size = GetModuleFileNameA(NULL, module, sizeof(module)); + ok(size && GetLastError() != ERROR_INSUFFICIENT_BUFFER, "GetModuleFileName failed: %u le=%u\n", size, GetLastError()); + /* get the buffer length without \0 terminator */ - length = 1024; + length = sizeof(buf); expect_eq_d(TRUE, pQueryFullProcessImageNameA(GetCurrentProcess(), 0, buf, &length)); expect_eq_d(length, lstrlenA(buf)); + ok((buf[0] == '\\' && buf[1] == '\\') || + lstrcmpi(buf, module) == 0, "expected %s to match %s\n", buf, module); /* when the buffer is too small * - function fail with error ERROR_INSUFFICIENT_BUFFER @@ -1685,7 +1736,7 @@ static void test_ProcessNameA(void) expect_eq_d(ERROR_INVALID_PARAMETER, GetLastError()); } -static void test_ProcessName(void) +static void test_QueryFullProcessImageNameW(void) { HANDLE hSelf; WCHAR module_name[1024]; @@ -1888,8 +1939,9 @@ START_TEST(process) test_ExitCode(); test_OpenProcess(); test_GetProcessVersion(); - test_ProcessNameA(); - test_ProcessName(); + test_GetProcessImageFileNameA(); + test_QueryFullProcessImageNameA(); + test_QueryFullProcessImageNameW(); test_Handles(); test_SystemInfo(); test_RegistryQuota();

1 0

Marcus Meissner : dsound: Make a function static, remove a no longer used array.
by Alexandre Julliard 04 Oct '11

04 Oct '11

Module: wine Branch: master Commit: 1533965e8cff7a1908c3fc626e08ec8b4b786801 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1533965e8cff7a1908c3fc626… Author: Marcus Meissner <meissner(a)suse.de> Date: Tue Oct 4 02:38:06 2011 +0200 dsound: Make a function static, remove a no longer used array. --- dlls/dsound/capture.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/dsound/capture.c b/dlls/dsound/capture.c index 7569254..61a8228 100644 --- a/dlls/dsound/capture.c +++ b/dlls/dsound/capture.c @@ -822,8 +822,6 @@ static HRESULT IDirectSoundCaptureBufferImpl_Create( /******************************************************************************* * DirectSoundCaptureDevice */ -DirectSoundCaptureDevice * DSOUND_capture[MAXWAVEDRIVERS]; - static HRESULT DirectSoundCaptureDevice_Create( DirectSoundCaptureDevice ** ppDevice) { @@ -880,8 +878,8 @@ static ULONG DirectSoundCaptureDevice_Release( return ref; } -void CALLBACK DSOUND_capture_timer(UINT timerID, UINT msg, DWORD_PTR user, - DWORD_PTR dw1, DWORD_PTR dw2) +static void CALLBACK DSOUND_capture_timer(UINT timerID, UINT msg, DWORD_PTR user, + DWORD_PTR dw1, DWORD_PTR dw2) { DirectSoundCaptureDevice *device = (DirectSoundCaptureDevice*)user; UINT32 packet_frames, packet_bytes, avail_bytes;

1 0

Andrew Eikum : winmm: Handle DRV_QUERYMAPPABLE in waveXxxMessage.
by Alexandre Julliard 04 Oct '11

04 Oct '11

Module: wine Branch: master Commit: e19be58e90a5707acbb317af0ffa6e7464d51ab6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e19be58e90a5707acbb317af0… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Tue Oct 4 08:24:27 2011 -0500 winmm: Handle DRV_QUERYMAPPABLE in waveXxxMessage. --- dlls/winmm/tests/wave.c | 6 ++++++ dlls/winmm/waveform.c | 4 ++++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/dlls/winmm/tests/wave.c b/dlls/winmm/tests/wave.c index 921216b..6405cf8 100644 --- a/dlls/winmm/tests/wave.c +++ b/dlls/winmm/tests/wave.c @@ -30,6 +30,7 @@ #include "winnls.h" #include "mmsystem.h" #define NOBITMAP +#include "mmddk.h" #include "mmreg.h" #include "ks.h" #include "ksguid.h" @@ -891,6 +892,11 @@ static void wave_out_test_device(UINT_PTR device) "waveOutGetDevCapsW(%s): unexpected return value %s\n", dev_name(device),wave_out_error(rc)); + rc=waveOutMessage((HWAVEOUT)device, DRV_QUERYMAPPABLE, 0, 0); + ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_NOTSUPPORTED, + "DRV_QUERYMAPPABLE(%s): unexpected return value %s\n", + dev_name(device),wave_out_error(rc)); + nameA=NULL; rc=waveOutMessage((HWAVEOUT)device, DRV_QUERYDEVICEINTERFACESIZE, (DWORD_PTR)&size, 0); diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c index 0aa6320..658fd24 100644 --- a/dlls/winmm/waveform.c +++ b/dlls/winmm/waveform.c @@ -2780,6 +2780,8 @@ UINT WINAPI waveOutMessage(HWAVEOUT hWaveOut, UINT uMessage, (DWORD_PTR*)dwParam1, TRUE); case DRV_QUERYFUNCTIONINSTANCEID: return WINMM_QueryInstanceID(HandleToULong(hWaveOut), (WCHAR*)dwParam1, dwParam2, TRUE); + case DRV_QUERYMAPPABLE: + return MMSYSERR_NOERROR; } return MMSYSERR_NOTSUPPORTED; @@ -3152,6 +3154,8 @@ UINT WINAPI waveInMessage(HWAVEIN hWaveIn, UINT uMessage, (DWORD_PTR*)dwParam1, FALSE); case DRV_QUERYFUNCTIONINSTANCEID: return WINMM_QueryInstanceID(HandleToULong(hWaveIn), (WCHAR*)dwParam1, dwParam2, FALSE); + case DRV_QUERYMAPPABLE: + return MMSYSERR_NOERROR; } return MMSYSERR_NOTSUPPORTED;

1 0

Nikolay Sivov : kernel32/tests: Move CompareStringA data to a table.
by Alexandre Julliard 04 Oct '11

04 Oct '11

Module: wine Branch: master Commit: 17af6e394a1747ea54ce2abe7012ea77e806b789 URL: http://source.winehq.org/git/wine.git/?a=commit;h=17af6e394a1747ea54ce2abe7… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Oct 2 01:40:59 2011 +0400 kernel32/tests: Move CompareStringA data to a table. --- dlls/kernel32/tests/locale.c | 141 +++++++++++++++-------------------------- 1 files changed, 52 insertions(+), 89 deletions(-) diff --git a/dlls/kernel32/tests/locale.c b/dlls/kernel32/tests/locale.c index e13247e..f5b77f7 100644 --- a/dlls/kernel32/tests/locale.c +++ b/dlls/kernel32/tests/locale.c @@ -1135,12 +1135,63 @@ static void test_GetNumberFormatA(void) } } +struct comparestringa_entry { + LCID lcid; + DWORD flags; + const char *first; + int first_len; + const char *second; + int second_len; + int ret; +}; + +static const struct comparestringa_entry comparestringa_data[] = { + { LOCALE_SYSTEM_DEFAULT, 0, "EndDialog", -1, "_Property", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "osp_vba.sreg0070", -1, "_IEWWBrowserComp", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "r", -1, "\\", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "osp_vba.sreg0031", -1, "OriginalDatabase", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "AAA", -1, "aaa", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "AAA", -1, "aab", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "AAA", -1, "Aab", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, ".AAA", -1, "Aab", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, ".AAA", -1, "A.ab", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "aa", -1, "AB", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "aa", -1, "Aab", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "aB", -1, "Aab", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "Ba", -1, "bab", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "{100}{83}{71}{71}{71}", -1, "Global_DataAccess_JRO", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "a", -1, "{", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "A", -1, "{", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "3.5", 0, "4.0", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "3.5", -1, "4.0", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "3.520.4403.2", -1, "4.0.2927.10", -1, CSTR_LESS_THAN }, + /* hyphen and apostrophe are treated differently depending on whether SORT_STRINGSORT specified or not */ + { LOCALE_SYSTEM_DEFAULT, 0, "-o", -1, "/m", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "/m", -1, "-o", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, SORT_STRINGSORT, "-o", -1, "/m", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, SORT_STRINGSORT, "/m", -1, "-o", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "'o", -1, "/m", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "/m", -1, "'o", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, SORT_STRINGSORT, "'o", -1, "/m", -1, CSTR_LESS_THAN }, + { LOCALE_SYSTEM_DEFAULT, SORT_STRINGSORT, "/m", -1, "'o", -1, CSTR_GREATER_THAN }, + { LOCALE_SYSTEM_DEFAULT, 0, "aLuZkUtZ", 8, "aLuZkUtZ", 9, CSTR_EQUAL }, + { LOCALE_SYSTEM_DEFAULT, 0, "aLuZkUtZ", 7, "aLuZkUtZ\0A", 10, CSTR_LESS_THAN } +}; static void test_CompareStringA(void) { - int ret; + int ret, i; LCID lcid = MAKELCID(MAKELANGID(LANG_FRENCH, SUBLANG_DEFAULT), SORT_DEFAULT); + for (i = 0; i < sizeof(comparestringa_data)/sizeof(struct comparestringa_entry); i++) + { + const struct comparestringa_entry *entry = &comparestringa_data[i]; + + ret = CompareStringA(entry->lcid, entry->flags, entry->first, entry->first_len, + entry->second, entry->second_len); + ok(ret == entry->ret, "%d: got %d, expected %d\n", i, ret, entry->ret); + } + ret = CompareStringA(lcid, NORM_IGNORECASE, "Salut", -1, "Salute", -1); ok (ret== 1, "(Salut/Salute) Expected 1, got %d\n", ret); @@ -1189,89 +1240,6 @@ static void test_CompareStringA(void) ret = lstrcmpA(NULL, ""); ok (ret == -1 || broken(ret == -2) /* win9x */, "lstrcmpA(NULL, \"\") should return -1, got %d\n", ret); - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT,0,"EndDialog",-1,"_Property",-1); - ok( ret == 3, "EndDialog vs _Property ... expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT,0,"osp_vba.sreg0070",-1,"_IEWWBrowserComp",-1); - ok( ret == 3, "osp_vba.sreg0070 vs _IEWWBrowserComp ... expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT,0,"r",-1,"\\",-1); - ok( ret == 3, "r vs \\ ... expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT,0,"osp_vba.sreg0031", -1, "OriginalDatabase", -1 ); - ok( ret == 3, "osp_vba.sreg0031 vs OriginalDatabase ... expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "AAA", -1, "aaa", -1 ); - ok( ret == 3, "AAA vs aaa expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "AAA", -1, "aab", -1 ); - ok( ret == 1, "AAA vs aab expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "AAA", -1, "Aab", -1 ); - ok( ret == 1, "AAA vs Aab expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, ".AAA", -1, "Aab", -1 ); - ok( ret == 1, ".AAA vs Aab expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, ".AAA", -1, "A.ab", -1 ); - ok( ret == 1, ".AAA vs A.ab expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "aa", -1, "AB", -1 ); - ok( ret == 1, "aa vs AB expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "aa", -1, "Aab", -1 ); - ok( ret == 1, "aa vs Aab expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "aB", -1, "Aab", -1 ); - ok( ret == 3, "aB vs Aab expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "Ba", -1, "bab", -1 ); - ok( ret == 1, "Ba vs bab expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "{100}{83}{71}{71}{71}", -1, "Global_DataAccess_JRO", -1 ); - ok( ret == 1, "{100}{83}{71}{71}{71} vs Global_DataAccess_JRO expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "a", -1, "{", -1 ); - ok( ret == 3, "a vs { expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "A", -1, "{", -1 ); - ok( ret == 3, "A vs { expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "3.5", 0, "4.0", -1 ); - ok(ret == 1, "3.5/0 vs 4.0/-1 expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "3.5", -1, "4.0", -1 ); - ok(ret == 1, "3.5 vs 4.0 expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "3.520.4403.2", -1, "4.0.2927.10", -1 ); - ok(ret == 1, "3.520.4403.2 vs 4.0.2927.10 expected 1, got %d\n", ret); - - /* hyphen and apostrophe are treated differently depending on - * whether SORT_STRINGSORT specified or not - */ - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "-o", -1, "/m", -1 ); - ok(ret == 3, "-o vs /m expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "/m", -1, "-o", -1 ); - ok(ret == 1, "/m vs -o expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, SORT_STRINGSORT, "-o", -1, "/m", -1 ); - ok(ret == 1, "-o vs /m expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, SORT_STRINGSORT, "/m", -1, "-o", -1 ); - ok(ret == 3, "/m vs -o expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "'o", -1, "/m", -1 ); - ok(ret == 3, "'o vs /m expected 3, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "/m", -1, "'o", -1 ); - ok(ret == 1, "/m vs 'o expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, SORT_STRINGSORT, "'o", -1, "/m", -1 ); - ok(ret == 1, "'o vs /m expected 1, got %d\n", ret); - - ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, SORT_STRINGSORT, "/m", -1, "'o", -1 ); - ok(ret == 3, "/m vs 'o expected 3, got %d\n", ret); if (0) { /* this requires collation table patch to make it MS compatible */ ret = CompareStringA(LOCALE_SYSTEM_DEFAULT, 0, "'o", -1, "-o", -1 ); @@ -1311,11 +1279,6 @@ static void test_CompareStringA(void) ok(ret == 1, "-m vs `o expected 1, got %d\n", ret); } - ret = CompareStringA(LOCALE_USER_DEFAULT, 0, "aLuZkUtZ", 8, "aLuZkUtZ", 9); - ok(ret == 2, "aLuZkUtZ vs aLuZkUtZ\\0 expected 2, got %d\n", ret); - - ret = CompareStringA(LOCALE_USER_DEFAULT, 0, "aLuZkUtZ", 7, "aLuZkUtZ\0A", 10); - ok(ret == 1, "aLuZkUtZ vs aLuZkUtZ\\0A expected 1, got %d\n", ret); /* WinXP handles embedded NULLs differently than earlier versions */ ret = CompareStringA(LOCALE_USER_DEFAULT, 0, "aLuZkUtZ", 8, "aLuZkUtZ\0A", 10);

1 0

Vincent Povirk : gdiplus: Fix pointer math for the 64-bit tests.
by Alexandre Julliard 04 Oct '11

04 Oct '11

Module: wine Branch: master Commit: 203d29d93aebce08548c38c0d2d3b9d41d114cc4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=203d29d93aebce08548c38c0d… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Oct 4 14:11:06 2011 -0500 gdiplus: Fix pointer math for the 64-bit tests. --- dlls/gdiplus/gdiplus.c | 2 +- dlls/gdiplus/image.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/gdiplus/gdiplus.c b/dlls/gdiplus/gdiplus.c index 8026f6e..9c3478b 100644 --- a/dlls/gdiplus/gdiplus.c +++ b/dlls/gdiplus/gdiplus.c @@ -407,7 +407,7 @@ BOOL lengthen_path(GpPath *path, INT len) void convert_32bppARGB_to_32bppPARGB(UINT width, UINT height, BYTE *dst_bits, INT dst_stride, const BYTE *src_bits, INT src_stride) { - UINT x, y; + INT x, y; for (y=0; y<height; y++) { const BYTE *src=src_bits+y*src_stride; diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index 4ae1d64..ce14ef6 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -1404,7 +1404,7 @@ GpStatus WINGDIPAPI GdipCreateHBITMAPFromBitmap(GpBitmap* bitmap, if (result) { lockeddata.Stride = -width * 4; - lockeddata.Scan0 = bits - (lockeddata.Stride * (height - 1)); + lockeddata.Scan0 = bits + (width * 4 * (height - 1)); stat = GdipBitmapLockBits(bitmap, NULL, ImageLockModeRead|ImageLockModeUserInputBuf, PixelFormat32bppPARGB, &lockeddata);

1 0

Francois Gouget : kernel32/tests: Check what happens if QueryDosDeviceA() is given an insufficient buffer.
by Alexandre Julliard 03 Oct '11

03 Oct '11

Module: wine Branch: master Commit: db882bfb5d2f24b427019a11ccd463fc92f50282 URL: http://source.winehq.org/git/wine.git/?a=commit;h=db882bfb5d2f24b427019a11c… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Oct 3 23:39:10 2011 +0200 kernel32/tests: Check what happens if QueryDosDeviceA() is given an insufficient buffer. --- dlls/kernel32/tests/volume.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/volume.c b/dlls/kernel32/tests/volume.c index 6f0fd67..2755af5 100644 --- a/dlls/kernel32/tests/volume.c +++ b/dlls/kernel32/tests/volume.c @@ -44,6 +44,12 @@ static void test_query_dos_deviceA(void) DWORD ret, ret2, buflen=32768; BOOL found = FALSE; + /* callers must guess the buffer size */ + SetLastError(0xdeadbeef); + ret = QueryDosDeviceA( NULL, NULL, 0 ); + ok(!ret && GetLastError() == ERROR_INSUFFICIENT_BUFFER, + "QueryDosDeviceA(no buffer): returned %u, le=%u\n", ret, GetLastError()); + buffer = HeapAlloc( GetProcessHeap(), 0, buflen ); SetLastError(0xdeadbeef); ret = QueryDosDeviceA( NULL, buffer, buflen );

1 0

Francois Gouget : kernel32: Reset LastError if GetModuleFileName() succeeds .
by Alexandre Julliard 03 Oct '11

03 Oct '11

Module: wine Branch: master Commit: 8e67930bd7a1db8438cca50e8bd9269d80887c84 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8e67930bd7a1db8438cca50e8… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Mon Oct 3 23:38:29 2011 +0200 kernel32: Reset LastError if GetModuleFileName() succeeds. --- dlls/kernel32/module.c | 3 +++ dlls/kernel32/tests/module.c | 8 ++++++++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c index 8ee0fcd..1b0b23f 100644 --- a/dlls/kernel32/module.c +++ b/dlls/kernel32/module.c @@ -648,7 +648,10 @@ DWORD WINAPI GetModuleFileNameW( HMODULE hModule, LPWSTR lpFileName, DWORD size len = min(size, pldr->FullDllName.Length / sizeof(WCHAR)); memcpy(lpFileName, pldr->FullDllName.Buffer, len * sizeof(WCHAR)); if (len < size) + { lpFileName[len] = '\0'; + SetLastError( 0 ); + } else SetLastError( ERROR_INSUFFICIENT_BUFFER ); } diff --git a/dlls/kernel32/tests/module.c b/dlls/kernel32/tests/module.c index 01fa448..07d5892 100644 --- a/dlls/kernel32/tests/module.c +++ b/dlls/kernel32/tests/module.c @@ -44,13 +44,21 @@ static void testGetModuleFileName(const char* name) /* first test, with enough space in buffer */ memset(bufA, '-', sizeof(bufA)); + SetLastError(0xdeadbeef); len1A = GetModuleFileNameA(hMod, bufA, sizeof(bufA)); + ok(GetLastError() == ERROR_SUCCESS || + broken(GetLastError() == 0xdeadbeef), /* <= XP SP3 */ + "LastError was not reset: %u\n", GetLastError()); ok(len1A > 0, "Getting module filename for handle %p\n", hMod); if (is_unicode_enabled) { memset(bufW, '-', sizeof(bufW)); + SetLastError(0xdeadbeef); len1W = GetModuleFileNameW(hMod, bufW, sizeof(bufW) / sizeof(WCHAR)); + ok(GetLastError() == ERROR_SUCCESS || + broken(GetLastError() == 0xdeadbeef), /* <= XP SP3 */ + "LastError was not reset: %u\n", GetLastError()); ok(len1W > 0, "Getting module filename for handle %p\n", hMod); }

1 0

Alexandre Julliard : winex11: Force alpha channel to 0 when doing color conversion in PutImage.
by Alexandre Julliard 03 Oct '11

03 Oct '11

Module: wine Branch: master Commit: 8abe262fd2c18b2b15053090d4426132101cffab URL: http://source.winehq.org/git/wine.git/?a=commit;h=8abe262fd2c18b2b15053090d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Oct 3 16:47:31 2011 -0500 winex11: Force alpha channel to 0 when doing color conversion in PutImage. --- dlls/winex11.drv/xrender.c | 21 ++++++++++++++------- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c index c039468..33ad4bd 100644 --- a/dlls/winex11.drv/xrender.c +++ b/dlls/winex11.drv/xrender.c @@ -249,6 +249,11 @@ static CRITICAL_SECTION xrender_cs = { &critsect_debug, -1, 0, 0, 0, 0 }; #define NATIVE_BYTE_ORDER LSBFirst #endif +static BOOL has_alpha( enum wxr_format format ) +{ + return (format == WXR_FORMAT_A8R8G8B8 || format == WXR_FORMAT_B8G8R8A8); +} + static enum wxr_format get_format_without_alpha( enum wxr_format format ) { switch (format) @@ -2514,7 +2519,7 @@ static void xrender_stretch_blit( struct xrender_physdev *physdev_src, struct xr } -static void xrender_put_image( Pixmap src_pixmap, Picture src_pict, HRGN clip, +static void xrender_put_image( Pixmap src_pixmap, Picture src_pict, Picture mask_pict, HRGN clip, XRenderPictFormat *dst_format, struct xrender_physdev *physdev, Drawable drawable, struct bitblt_coords *src, struct bitblt_coords *dst, BOOL use_repeat ) @@ -2561,7 +2566,7 @@ static void xrender_put_image( Pixmap src_pixmap, Picture src_pict, HRGN clip, if (dst->width < 0) x_dst += dst->width + 1; if (dst->height < 0) y_dst += dst->height + 1; - xrender_blit( PictOpSrc, src_pict, 0, dst_pict, x_src, y_src, x_dst, y_dst, + xrender_blit( PictOpSrc, src_pict, mask_pict, dst_pict, x_src, y_src, x_dst, y_dst, xscale, yscale, abs( dst->width ), abs( dst->height )); if (drawable) @@ -2655,7 +2660,7 @@ static DWORD xrenderdrv_PutImage( PHYSDEV dev, HBITMAP hbitmap, HRGN clip, BITMA enum wxr_format src_format, dst_format; XRenderPictFormat *pict_format; Pixmap src_pixmap; - Picture src_pict; + Picture src_pict, mask_pict = 0; BOOL use_repeat; if (!X11DRV_XRender_Installed) goto x11drv_fallback; @@ -2686,6 +2691,8 @@ static DWORD xrenderdrv_PutImage( PHYSDEV dev, HBITMAP hbitmap, HRGN clip, BITMA if (!bits) return ERROR_SUCCESS; /* just querying the format */ + if (!has_alpha( src_format ) && has_alpha( dst_format )) mask_pict = get_no_alpha_mask(); + ret = create_image_pixmap( info, bits, src, src_format, &src_pixmap, &src_pict, &use_repeat ); if (!ret) { @@ -2698,8 +2705,8 @@ static DWORD xrenderdrv_PutImage( PHYSDEV dev, HBITMAP hbitmap, HRGN clip, BITMA X11DRV_DIB_Lock( bitmap, DIB_Status_GdiMod ); - xrender_put_image( src_pixmap, src_pict, rgn, pict_formats[dst_format], - NULL, bitmap->pixmap, src, dst, use_repeat ); + xrender_put_image( src_pixmap, src_pict, mask_pict, rgn, + pict_formats[dst_format], NULL, bitmap->pixmap, src, dst, use_repeat ); X11DRV_DIB_Unlock( bitmap, TRUE ); DeleteObject( rgn ); @@ -2728,7 +2735,7 @@ static DWORD xrenderdrv_PutImage( PHYSDEV dev, HBITMAP hbitmap, HRGN clip, BITMA tmp.visrect.bottom - tmp.visrect.top, physdev->x11dev->depth ); wine_tsx11_unlock(); - xrender_put_image( src_pixmap, src_pict, NULL, physdev->pict_format, + xrender_put_image( src_pixmap, src_pict, mask_pict, NULL, physdev->pict_format, NULL, tmp_pixmap, src, &tmp, use_repeat ); execute_rop( physdev->x11dev, tmp_pixmap, gc, &dst->visrect, rop ); @@ -2739,7 +2746,7 @@ static DWORD xrenderdrv_PutImage( PHYSDEV dev, HBITMAP hbitmap, HRGN clip, BITMA restore_clipping_region( physdev->x11dev, clip_data ); } - else xrender_put_image( src_pixmap, src_pict, clip, + else xrender_put_image( src_pixmap, src_pict, mask_pict, clip, physdev->pict_format, physdev, 0, src, dst, use_repeat ); X11DRV_UnlockDIBSection( physdev->x11dev, TRUE );

1 0

Alexandre Julliard : winex11: Remove no longer needed support for a source DIB color map in X11 StretchBlt .
by Alexandre Julliard 03 Oct '11

03 Oct '11

Module: wine Branch: master Commit: f0f1005b3750ae4977b371c3ed0e3b9eb0c29013 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f0f1005b3750ae4977b371c3e… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Oct 3 16:29:23 2011 -0500 winex11: Remove no longer needed support for a source DIB color map in X11 StretchBlt. --- dlls/winex11.drv/bitblt.c | 41 ++++++----------------------------------- 1 files changed, 6 insertions(+), 35 deletions(-) diff --git a/dlls/winex11.drv/bitblt.c b/dlls/winex11.drv/bitblt.c index 355d517..c0ff7f3 100644 --- a/dlls/winex11.drv/bitblt.c +++ b/dlls/winex11.drv/bitblt.c @@ -582,24 +582,6 @@ int main() #endif /* BITBLT_TEST */ -static void get_colors(X11DRV_PDEVICE *physDevDst, X11DRV_PDEVICE *physDevSrc, - int *fg, int *bg) -{ - RGBQUAD rgb[2]; - - *fg = physDevDst->textPixel; - *bg = physDevDst->backgroundPixel; - if(physDevSrc->depth == 1) { - if(GetDIBColorTable(physDevSrc->dev.hdc, 0, 2, rgb) == 2) { - DWORD logcolor; - logcolor = RGB(rgb[0].rgbRed, rgb[0].rgbGreen, rgb[0].rgbBlue); - *fg = X11DRV_PALETTE_ToPhysical( physDevDst, logcolor ); - logcolor = RGB(rgb[1].rgbRed, rgb[1].rgbGreen,rgb[1].rgbBlue); - *bg = X11DRV_PALETTE_ToPhysical( physDevDst, logcolor ); - } - } -} - /* return a mask for meaningful bits when doing an XGetPixel on an image */ static unsigned long image_pixel_mask( X11DRV_PDEVICE *physDev ) { @@ -629,7 +611,6 @@ static int BITBLT_GetSrcArea( X11DRV_PDEVICE *physDevSrc, X11DRV_PDEVICE *physDe int exposures = 0; INT width = visRectSrc->right - visRectSrc->left; INT height = visRectSrc->bottom - visRectSrc->top; - int fg, bg; BOOL memdc = (GetObjectType(physDevSrc->dev.hdc) == OBJ_MEMDC); if (physDevSrc->depth == physDevDst->depth) @@ -690,20 +671,16 @@ static int BITBLT_GetSrcArea( X11DRV_PDEVICE *physDevSrc, X11DRV_PDEVICE *physDe { if (physDevSrc->depth == 1) /* monochrome -> color */ { - get_colors(physDevDst, physDevSrc, &fg, &bg); - wine_tsx11_lock(); if (X11DRV_PALETTE_XPixelToPalette) { - XSetBackground( gdi_display, gc, - X11DRV_PALETTE_XPixelToPalette[fg] ); - XSetForeground( gdi_display, gc, - X11DRV_PALETTE_XPixelToPalette[bg]); + XSetBackground( gdi_display, gc, X11DRV_PALETTE_XPixelToPalette[physDevDst->textPixel] ); + XSetForeground( gdi_display, gc, X11DRV_PALETTE_XPixelToPalette[physDevDst->backgroundPixel]); } else { - XSetBackground( gdi_display, gc, fg ); - XSetForeground( gdi_display, gc, bg ); + XSetBackground( gdi_display, gc, physDevDst->textPixel ); + XSetForeground( gdi_display, gc, physDevDst->backgroundPixel ); } XCopyPlane( gdi_display, physDevSrc->drawable, pixmap, gc, physDevSrc->dc_rect.left + visRectSrc->left, @@ -1004,9 +981,6 @@ BOOL X11DRV_StretchBlt( PHYSDEV dst_dev, struct bitblt_coords *dst, { wine_tsx11_lock(); XSetFunction( gdi_display, physDevDst->gc, OP_ROP(*opcode) ); - wine_tsx11_unlock(); - - wine_tsx11_lock(); XCopyArea( gdi_display, physDevSrc->drawable, physDevDst->drawable, physDevDst->gc, physDevSrc->dc_rect.left + src->visrect.left, @@ -1020,12 +994,9 @@ BOOL X11DRV_StretchBlt( PHYSDEV dst_dev, struct bitblt_coords *dst, } if (physDevSrc->depth == 1) { - int fg, bg; - - get_colors(physDevDst, physDevSrc, &fg, &bg); wine_tsx11_lock(); - XSetBackground( gdi_display, physDevDst->gc, fg ); - XSetForeground( gdi_display, physDevDst->gc, bg ); + XSetBackground( gdi_display, physDevDst->gc, physDevDst->textPixel ); + XSetForeground( gdi_display, physDevDst->gc, physDevDst->backgroundPixel ); XSetFunction( gdi_display, physDevDst->gc, OP_ROP(*opcode) ); XCopyPlane( gdi_display, physDevSrc->drawable, physDevDst->drawable, physDevDst->gc,

1 0

Alexandre Julliard : winex11: Remove no longer needed support for a source DIB color map in XRender StretchBlt .
by Alexandre Julliard 03 Oct '11

03 Oct '11

Module: wine Branch: master Commit: e502ae4d1f6a3c46c9b41763d4fc04580a4afd39 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e502ae4d1f6a3c46c9b41763d… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Oct 3 16:24:01 2011 -0500 winex11: Remove no longer needed support for a source DIB color map in XRender StretchBlt. --- dlls/winex11.drv/xrender.c | 26 ++------------------------ 1 files changed, 2 insertions(+), 24 deletions(-) diff --git a/dlls/winex11.drv/xrender.c b/dlls/winex11.drv/xrender.c index a985898..c039468 100644 --- a/dlls/winex11.drv/xrender.c +++ b/dlls/winex11.drv/xrender.c @@ -2388,29 +2388,6 @@ static void xrender_mono_blit( Picture src_pict, Picture dst_pict, multiply_alpha( dst_pict, pict_formats[dst_format], bg->alpha, x_dst, y_dst, width, height ); } -static void get_colors( struct xrender_physdev *physdev_src, struct xrender_physdev *physdev_dst, - XRenderColor *fg, XRenderColor *bg ) -{ - if (physdev_src->format == WXR_FORMAT_MONO) - { - RGBQUAD rgb[2]; - int pixel; - - if (GetDIBColorTable( physdev_src->dev.hdc, 0, 2, rgb ) == 2) - { - pixel = X11DRV_PALETTE_ToPhysical( physdev_dst->x11dev, - RGB( rgb[0].rgbRed, rgb[0].rgbGreen, rgb[0].rgbBlue )); - get_xrender_color( physdev_dst->pict_format, pixel, fg ); - pixel = X11DRV_PALETTE_ToPhysical( physdev_dst->x11dev, - RGB( rgb[1].rgbRed, rgb[1].rgbGreen, rgb[1].rgbBlue )); - get_xrender_color( physdev_dst->pict_format, pixel, bg ); - return; - } - } - get_xrender_color( physdev_dst->pict_format, physdev_dst->x11dev->textPixel, fg ); - get_xrender_color( physdev_dst->pict_format, physdev_dst->x11dev->backgroundPixel, bg ); -} - /* create a pixmap and render picture for an image */ static DWORD create_image_pixmap( BITMAPINFO *info, const struct gdi_image_bits *bits, struct bitblt_coords *src, enum wxr_format format, @@ -2512,7 +2489,8 @@ static void xrender_stretch_blit( struct xrender_physdev *physdev_src, struct xr { XRenderColor fg, bg; - get_colors( physdev_src, physdev_dst, &fg, &bg ); + get_xrender_color( physdev_dst->pict_format, physdev_dst->x11dev->textPixel, &fg ); + get_xrender_color( physdev_dst->pict_format, physdev_dst->x11dev->backgroundPixel, &bg ); fg.alpha = bg.alpha = 0; xrender_mono_blit( src_pict, dst_pict, physdev_dst->format, &fg, &bg,

1 0

← Newer
1
...
71
72
73
74
75
76
77
78
79
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits October 2011