winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
December 2011
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
810 discussions
Start a n
N
ew thread
Dmitry Timoshkov : kernel32: Add a test for MapViewOfFile called on a not accessible mapping.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: 1026bddf53d1e6d339ff2433d7cab3b4146c609d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1026bddf53d1e6d339ff2433d…
Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Tue Dec 20 16:33:20 2011 +0800 kernel32: Add a test for MapViewOfFile called on a not accessible mapping. --- dlls/kernel32/tests/virtual.c | 25 +++++++++++++++++++------ 1 files changed, 19 insertions(+), 6 deletions(-) diff --git a/dlls/kernel32/tests/virtual.c b/dlls/kernel32/tests/virtual.c index 336fd87..203a400 100644 --- a/dlls/kernel32/tests/virtual.c +++ b/dlls/kernel32/tests/virtual.c @@ -1939,6 +1939,7 @@ static DWORD map_prot_to_access(DWORD prot) static BOOL is_compatible_access(DWORD map_prot, DWORD view_prot) { DWORD access = map_prot_to_access(map_prot); + if (!access) return FALSE; return (view_prot & access) == view_prot; } @@ -2012,16 +2013,28 @@ static void test_mapping(void) SetLastError(0xdeadbeef); hmap = CreateFileMapping(hfile, NULL, page_prot[i] | SEC_COMMIT, 0, si.dwPageSize, NULL); + if (page_prot[i] == PAGE_NOACCESS) + { + HANDLE hmap2; + + ok(!hmap, "CreateFileMapping(PAGE_NOACCESS) should fail\n"); + ok(GetLastError() == ERROR_INVALID_PARAMETER, "expected ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); + + /* A trick to create a not accessible mapping */ + SetLastError(0xdeadbeef); + hmap = CreateFileMapping(hfile, NULL, PAGE_READWRITE | SEC_COMMIT, 0, si.dwPageSize, NULL); + ok(hmap != 0, "CreateFileMapping(PAGE_READWRITE) error %d\n", GetLastError()); + SetLastError(0xdeadbeef); + ret = DuplicateHandle(GetCurrentProcess(), hmap, GetCurrentProcess(), &hmap2, 0, FALSE, 0); + ok(ret, "DuplicateHandle error %d\n", GetLastError()); + CloseHandle(hmap); + hmap = hmap2; + } + if (!hmap) { trace("%d: CreateFileMapping(%04x) failed: %d\n", i, page_prot[i], GetLastError()); - if (page_prot[i] == PAGE_NOACCESS) - { - ok(!hmap, "%d: CreateFileMapping(%04x) should fail\n", i, page_prot[i]); - ok(GetLastError() == ERROR_INVALID_PARAMETER, "%d: expected ERROR_INVALID_PARAMETER, got %d\n", i, GetLastError()); - continue; - } /* NT4 and win2k don't support EXEC on file mappings */ if (page_prot[i] == PAGE_EXECUTE_READ || page_prot[i] == PAGE_EXECUTE_READWRITE) {
1
0
0
0
Ken Thomases : user32/tests: Test that ToUnicode null-terminates the buffer if it's big enough.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: b5b9184dec8e88464375d65bf5dcdb5c1fea0011 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b5b9184dec8e88464375d65bf…
Author: Ken Thomases <ken(a)codeweavers.com> Date: Mon Dec 19 22:00:08 2011 -0600 user32/tests: Test that ToUnicode null-terminates the buffer if it's big enough. --- dlls/user32/tests/input.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index d45edf1..748ed26 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -1540,7 +1540,7 @@ static void test_key_map(void) static void test_ToUnicode(void) { - WCHAR wStr[2]; + WCHAR wStr[4]; BYTE state[256]; const BYTE SC_RETURN = 0x1c, SC_TAB = 0x0f; const BYTE HIGHEST_BIT = 0x80; @@ -1548,8 +1548,9 @@ static void test_ToUnicode(void) for(i=0; i<256; i++) state[i]=0; + wStr[1] = 0xAA; SetLastError(0xdeadbeef); - ret = ToUnicode(VK_RETURN, SC_RETURN, state, wStr, 2, 0); + ret = ToUnicode(VK_RETURN, SC_RETURN, state, wStr, 4, 0); if (!ret && GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) { win_skip("ToUnicode is not implemented\n"); @@ -1558,7 +1559,11 @@ static void test_ToUnicode(void) ok(ret == 1, "ToUnicode for Return key didn't return 1 (was %i)\n", ret); if(ret == 1) + { ok(wStr[0]=='\r', "ToUnicode for CTRL + Return was %i (expected 13)\n", wStr[0]); + ok(wStr[1]==0 || broken(wStr[1]!=0) /* nt4 */, + "ToUnicode didn't null-terminate the buffer when there was room.\n"); + } state[VK_CONTROL] |= HIGHEST_BIT; state[VK_LCONTROL] |= HIGHEST_BIT;
1
0
0
0
Ken Thomases : winex11: Have ToUnicodeEx null-terminate the output buffer, if there's room.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: 3fa4da76ea2b3f2e91a42c0345e5764202a1e992 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3fa4da76ea2b3f2e91a42c034…
Author: Ken Thomases <ken(a)codeweavers.com> Date: Mon Dec 19 21:59:56 2011 -0600 winex11: Have ToUnicodeEx null-terminate the output buffer, if there's room. --- dlls/winex11.drv/keyboard.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/dlls/winex11.drv/keyboard.c b/dlls/winex11.drv/keyboard.c index e985694..c561102 100644 --- a/dlls/winex11.drv/keyboard.c +++ b/dlls/winex11.drv/keyboard.c @@ -2680,6 +2680,12 @@ INT CDECL X11DRV_ToUnicodeEx(UINT virtKey, UINT scanCode, const BYTE *lpKeyState found: if (buf != lpChar) HeapFree(GetProcessHeap(), 0, lpChar); + + /* Null-terminate the buffer, if there's room. MSDN clearly states that the + caller must not assume this is done, but some programs (e.g. Audiosurf) do. */ + if (1 <= ret && ret < bufW_size) + bufW[ret] = 0; + TRACE_(key)("returning %d with %s\n", ret, debugstr_wn(bufW, ret)); return ret; }
1
0
0
0
Ken Thomases : comdlg32: Fix a leak.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: c2f3c1114f9e597ba6c5385a0449d1d9778add3d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c2f3c1114f9e597ba6c5385a0…
Author: Ken Thomases <ken(a)codeweavers.com> Date: Mon Dec 19 21:59:39 2011 -0600 comdlg32: Fix a leak. --- dlls/comdlg32/filedlg.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c index 9b725ba..43df312 100644 --- a/dlls/comdlg32/filedlg.c +++ b/dlls/comdlg32/filedlg.c @@ -1529,8 +1529,7 @@ static LRESULT FILEDLG95_InitControls(HWND hwnd) lstrcpyW(fodInfos->filename,nameBit); *nameBit = 0x00; - if (fodInfos->initdir == NULL) - MemFree(fodInfos->initdir); + MemFree(fodInfos->initdir); fodInfos->initdir = MemAlloc((lstrlenW(tmpBuf) + 1)*sizeof(WCHAR)); lstrcpyW(fodInfos->initdir, tmpBuf); handledPath = TRUE;
1
0
0
0
Alistair Leslie-Hughes : jscript: Don' t double free IObjectWithSite interface.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: 1a9d9e0f76007867a5df1eedea7dc6b8dcdf1353 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1a9d9e0f76007867a5df1eede…
Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Tue Dec 20 14:49:57 2011 +1100 jscript: Don't double free IObjectWithSite interface. --- dlls/jscript/activex.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dlls/jscript/activex.c b/dlls/jscript/activex.c index c1f556b..41e2065 100644 --- a/dlls/jscript/activex.c +++ b/dlls/jscript/activex.c @@ -130,7 +130,6 @@ static IUnknown *create_activex_object(script_ctx_t *ctx, const WCHAR *progid) } IObjectWithSite_Release(obj_site); if(!ax_site || FAILED(hres)) { - IObjectWithSite_Release(obj_site); IUnknown_Release(obj); return NULL; }
1
0
0
0
Andrew Eikum : winealsa.drv: Limit the data written to ALSA's buffer.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: 54b24f39260a3780bdf97d810a69647d7357cb62 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=54b24f39260a3780bdf97d810…
Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Mon Dec 19 15:24:13 2011 -0600 winealsa.drv: Limit the data written to ALSA's buffer. Based on an algorithm by Alexey Loukianov. --- dlls/winealsa.drv/mmdevdrv.c | 64 +++++++++++++++++++---------------------- 1 files changed, 30 insertions(+), 34 deletions(-) diff --git a/dlls/winealsa.drv/mmdevdrv.c b/dlls/winealsa.drv/mmdevdrv.c index 994628e..dcf7d32 100644 --- a/dlls/winealsa.drv/mmdevdrv.c +++ b/dlls/winealsa.drv/mmdevdrv.c @@ -94,7 +94,7 @@ struct ACImpl { LONG ref; snd_pcm_t *pcm_handle; - snd_pcm_uframes_t alsa_bufsize_frames; + snd_pcm_uframes_t alsa_bufsize_frames, alsa_period_frames; snd_pcm_hw_params_t *hw_params; /* does not hold state between calls */ snd_pcm_format_t alsa_format; @@ -110,7 +110,7 @@ struct ACImpl { BOOL initted, started; REFERENCE_TIME mmdev_period_rt; UINT64 written_frames, last_pos_frames; - UINT32 bufsize_frames, held_frames, tmp_buffer_frames; + UINT32 bufsize_frames, held_frames, tmp_buffer_frames, mmdev_period_frames; UINT32 lcl_offs_frames; /* offs into local_buffer where valid data starts */ HANDLE timer; @@ -808,9 +808,8 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, ACImpl *This = impl_from_IAudioClient(iface); snd_pcm_sw_params_t *sw_params = NULL; snd_pcm_format_t format; - snd_pcm_uframes_t alsa_period_frames; const WAVEFORMATEXTENSIBLE *fmtex = (const WAVEFORMATEXTENSIBLE *)fmt; - unsigned int rate, mmdev_period_frames, alsa_period_us; + unsigned int rate, alsa_period_us; int err, i; HRESULT hr = S_OK; @@ -955,19 +954,13 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, goto exit; } - if((err = snd_pcm_hw_params_current(This->pcm_handle, This->hw_params)) < 0){ - WARN("Unable to get current hw params: %d (%s)\n", err, snd_strerror(err)); - hr = E_FAIL; - goto exit; - } - if((err = snd_pcm_hw_params_get_period_size(This->hw_params, - &alsa_period_frames, NULL)) < 0){ + &This->alsa_period_frames, NULL)) < 0){ WARN("Unable to get period size: %d (%s)\n", err, snd_strerror(err)); hr = E_FAIL; goto exit; } - TRACE("alsa_period_frames: %lu\n", alsa_period_frames); + TRACE("alsa_period_frames: %lu\n", This->alsa_period_frames); if((err = snd_pcm_hw_params_get_buffer_size(This->hw_params, &This->alsa_bufsize_frames)) < 0){ @@ -1020,10 +1013,10 @@ static HRESULT WINAPI AudioClient_Initialize(IAudioClient *iface, /* Check if the ALSA buffer is so small that it will run out before * the next MMDevAPI period tick occurs. Allow a little wiggle room * with 120% of the period time. */ - mmdev_period_frames = fmt->nSamplesPerSec * (This->mmdev_period_rt / 10000000.); - if(This->alsa_bufsize_frames < 1.2 * mmdev_period_frames) + This->mmdev_period_frames = (fmt->nSamplesPerSec * This->mmdev_period_rt) / 10000000.; + if(This->alsa_bufsize_frames < 1.2 * This->mmdev_period_frames) FIXME("ALSA buffer time is smaller than our period time. Expect underruns. (%lu < %u)\n", - This->alsa_bufsize_frames, mmdev_period_frames); + This->alsa_bufsize_frames, This->mmdev_period_frames); This->bufsize_frames = ceil((duration / 10000000.) * fmt->nSamplesPerSec); This->local_buffer = HeapAlloc(GetProcessHeap(), 0, @@ -1151,23 +1144,11 @@ static HRESULT WINAPI AudioClient_GetCurrentPadding(IAudioClient *iface, return AUDCLNT_E_NOT_INITIALIZED; } - if(This->dataflow == eRender){ - snd_pcm_sframes_t avail_frames; + *out = This->held_frames; - avail_frames = snd_pcm_avail_update(This->pcm_handle); - if(This->alsa_bufsize_frames < avail_frames || - snd_pcm_state(This->pcm_handle) == SND_PCM_STATE_XRUN) - *out = This->held_frames; - else - *out = This->alsa_bufsize_frames - avail_frames + This->held_frames; - TRACE("PCM state: %u, avail: %ld, pad: %u\n", - snd_pcm_state(This->pcm_handle), avail_frames, *out); - }else if(This->dataflow == eCapture){ - *out = This->held_frames; - }else{ - LeaveCriticalSection(&This->lock); - return E_UNEXPECTED; - } + /* call required to get accurate snd_pcm_state() */ + snd_pcm_avail_update(This->pcm_handle); + TRACE("pad: %u, state: %u\n", *out, snd_pcm_state(This->pcm_handle)); LeaveCriticalSection(&This->lock); @@ -1554,7 +1535,7 @@ static snd_pcm_sframes_t alsa_write_best_effort(snd_pcm_t *handle, BYTE *buf, static void alsa_write_data(ACImpl *This) { snd_pcm_sframes_t written; - snd_pcm_uframes_t to_write, avail; + snd_pcm_uframes_t to_write, avail, write_limit, max_period, in_alsa; int err; BYTE *buf = This->local_buffer + (This->lcl_offs_frames * This->fmt->nBlockAlign); @@ -1566,6 +1547,8 @@ static void alsa_write_data(ACImpl *This) avail > This->alsa_bufsize_frames){ TRACE("XRun state, recovering\n"); + avail = This->alsa_bufsize_frames; + if((err = snd_pcm_recover(This->pcm_handle, -EPIPE, 1)) < 0) WARN("snd_pcm_recover failed: %d (%s)\n", err, snd_strerror(err)); @@ -1584,6 +1567,19 @@ static void alsa_write_data(ACImpl *This) else to_write = This->held_frames; + max_period = max(This->mmdev_period_frames, This->alsa_period_frames); + + /* try to keep 3 ALSA periods or 3 MMDevAPI periods in the ALSA buffer and + * no more */ + write_limit = 0; + in_alsa = This->alsa_bufsize_frames - avail; + while(in_alsa + write_limit < max_period * 3) + write_limit += max_period; + if(write_limit == 0) + return; + + to_write = min(to_write, write_limit); + written = alsa_write_best_effort(This->pcm_handle, buf, to_write, This); if(written < 0){ WARN("Couldn't write: %ld (%s)\n", written, snd_strerror(written)); @@ -1599,10 +1595,10 @@ static void alsa_write_data(ACImpl *This) return; } - if(This->held_frames){ + if(This->held_frames && (written < write_limit)){ /* wrapped and have some data back at the start to write */ written = alsa_write_best_effort(This->pcm_handle, This->local_buffer, - This->held_frames, This); + min(This->held_frames, write_limit - written), This); if(written < 0){ WARN("Couldn't write: %ld (%s)\n", written, snd_strerror(written)); return;
1
0
0
0
Henri Verbeet : wined3d: Get rid of the WINED3DRENDERSTATETYPE typedef.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: 3082c1a9de14e9c21c4f93331b6d595bbca00e34 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3082c1a9de14e9c21c4f93331…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Dec 19 21:00:09 2011 +0100 wined3d: Get rid of the WINED3DRENDERSTATETYPE typedef. --- dlls/d3d8/device.c | 8 +- dlls/ddraw/device.c | 6 +- dlls/ddraw/executebuffer.c | 2 +- dlls/ddraw/vertexbuffer.c | 6 +- dlls/wined3d/arb_program_shader.c | 53 ++-- dlls/wined3d/ati_fragment_shader.c | 22 +- dlls/wined3d/context.c | 40 +- dlls/wined3d/device.c | 34 +- dlls/wined3d/drawprim.c | 24 +- dlls/wined3d/nvidia_texture_shader.c | 21 +- dlls/wined3d/shader.c | 14 +- dlls/wined3d/state.c | 754 +++++++++++++++++----------------- dlls/wined3d/stateblock.c | 430 ++++++++++---------- dlls/wined3d/surface.c | 18 +- dlls/wined3d/swapchain.c | 10 +- dlls/wined3d/utils.c | 276 +++++++------- dlls/wined3d/wined3d_private.h | 2 +- include/wine/wined3d.h | 265 ++++++------ 18 files changed, 993 insertions(+), 992 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=3082c1a9de14e9c21c4f9…
1
0
0
0
Henri Verbeet : wined3d: Get rid of the WINED3DDEGREETYPE typedef.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: 5bddd4427d37256355ba0e74b5321f3de391aec0 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5bddd4427d37256355ba0e74b…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Dec 19 21:00:08 2011 +0100 wined3d: Get rid of the WINED3DDEGREETYPE typedef. --- dlls/wined3d/drawprim.c | 2 +- dlls/wined3d/state.c | 4 ++-- dlls/wined3d/stateblock.c | 4 ++-- dlls/wined3d/utils.c | 14 ++++++++------ dlls/wined3d/wined3d_private.h | 2 +- include/wine/wined3d.h | 17 ++++++++--------- 6 files changed, 22 insertions(+), 21 deletions(-) diff --git a/dlls/wined3d/drawprim.c b/dlls/wined3d/drawprim.c index 3b18c63..716119e 100644 --- a/dlls/wined3d/drawprim.c +++ b/dlls/wined3d/drawprim.c @@ -837,7 +837,7 @@ HRESULT tesselate_rectpatch(struct wined3d_device *This, struct WineD3DRectPatch } if (info->basis != WINED3DBASIS_BEZIER) FIXME("Basis is %s, how to handle this?\n", debug_d3dbasis(info->basis)); - if (info->degree != WINED3DDEGREE_CUBIC) + if (info->degree != WINED3D_DEGREE_CUBIC) FIXME("Degree is %s, how to handle this?\n", debug_d3ddegree(info->degree)); /* First, get the boundary cube of the input data */ diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index 390519f..7820048 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -1798,14 +1798,14 @@ static void state_patchsegments(struct wined3d_context *context, const struct wi static void state_positiondegree(struct wined3d_context *context, const struct wined3d_state *state, DWORD state_id) { - if (state->render_states[WINED3DRS_POSITIONDEGREE] != WINED3DDEGREE_CUBIC) + if (state->render_states[WINED3DRS_POSITIONDEGREE] != WINED3D_DEGREE_CUBIC) FIXME("WINED3DRS_POSITIONDEGREE %#x not yet implemented.\n", state->render_states[WINED3DRS_POSITIONDEGREE]); } static void state_normaldegree(struct wined3d_context *context, const struct wined3d_state *state, DWORD state_id) { - if (state->render_states[WINED3DRS_NORMALDEGREE] != WINED3DDEGREE_LINEAR) + if (state->render_states[WINED3DRS_NORMALDEGREE] != WINED3D_DEGREE_LINEAR) FIXME("WINED3DRS_NORMALDEGREE %#x not yet implemented.\n", state->render_states[WINED3DRS_NORMALDEGREE]); } diff --git a/dlls/wined3d/stateblock.c b/dlls/wined3d/stateblock.c index e4acd54..e29bbdc 100644 --- a/dlls/wined3d/stateblock.c +++ b/dlls/wined3d/stateblock.c @@ -1208,8 +1208,8 @@ void stateblock_init_default_state(struct wined3d_stateblock *stateblock) tmpfloat.f = 0.0f; state->render_states[WINED3DRS_TWEENFACTOR] = tmpfloat.d; state->render_states[WINED3DRS_BLENDOP] = WINED3D_BLEND_OP_ADD; - state->render_states[WINED3DRS_POSITIONDEGREE] = WINED3DDEGREE_CUBIC; - state->render_states[WINED3DRS_NORMALDEGREE] = WINED3DDEGREE_LINEAR; + state->render_states[WINED3DRS_POSITIONDEGREE] = WINED3D_DEGREE_CUBIC; + state->render_states[WINED3DRS_NORMALDEGREE] = WINED3D_DEGREE_LINEAR; /* states new in d3d9 */ state->render_states[WINED3DRS_SCISSORTESTENABLE] = FALSE; state->render_states[WINED3DRS_SLOPESCALEDEPTHBIAS] = 0; diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index e16aa70..b4f4ff8 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -2402,12 +2402,14 @@ const char *debug_d3dbasis(WINED3DBASISTYPE basis) { } } -const char *debug_d3ddegree(WINED3DDEGREETYPE degree) { - switch(degree) { - case WINED3DDEGREE_LINEAR: return "WINED3DDEGREE_LINEAR"; - case WINED3DDEGREE_QUADRATIC: return "WINED3DDEGREE_QUADRATIC"; - case WINED3DDEGREE_CUBIC: return "WINED3DDEGREE_CUBIC"; - case WINED3DDEGREE_QUINTIC: return "WINED3DDEGREE_QUINTIC"; +const char *debug_d3ddegree(enum wined3d_degree_type degree) +{ + switch (degree) + { + case WINED3D_DEGREE_LINEAR: return "WINED3D_DEGREE_LINEAR"; + case WINED3D_DEGREE_QUADRATIC: return "WINED3D_DEGREE_QUADRATIC"; + case WINED3D_DEGREE_CUBIC: return "WINED3D_DEGREE_CUBIC"; + case WINED3D_DEGREE_QUINTIC: return "WINED3D_DEGREE_QUINTIC"; default: return "unrecognized"; } } diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 1d83eeb..c8c7070 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2485,7 +2485,7 @@ const char *debug_d3dpool(WINED3DPOOL pool) DECLSPEC_HIDDEN; const char *debug_fbostatus(GLenum status) DECLSPEC_HIDDEN; const char *debug_glerror(GLenum error) DECLSPEC_HIDDEN; const char *debug_d3dbasis(WINED3DBASISTYPE basis) DECLSPEC_HIDDEN; -const char *debug_d3ddegree(WINED3DDEGREETYPE order) DECLSPEC_HIDDEN; +const char *debug_d3ddegree(enum wined3d_degree_type order) DECLSPEC_HIDDEN; const char *debug_d3dtop(WINED3DTEXTUREOP d3dtop) DECLSPEC_HIDDEN; void dump_color_fixup_desc(struct color_fixup_desc fixup) DECLSPEC_HIDDEN; const char *debug_surflocation(DWORD flag) DECLSPEC_HIDDEN; diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index a3e9971..ecb63a0 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -97,14 +97,13 @@ enum wined3d_device_type WINED3D_DEVICE_TYPE_NULLREF = 4, }; -typedef enum _WINED3DDEGREETYPE +enum wined3d_degree_type { - WINED3DDEGREE_LINEAR = 1, - WINED3DDEGREE_QUADRATIC = 2, - WINED3DDEGREE_CUBIC = 3, - WINED3DDEGREE_QUINTIC = 5, - WINED3DDEGREE_FORCE_DWORD = 0x7fffffff -} WINED3DDEGREETYPE; + WINED3D_DEGREE_LINEAR = 1, + WINED3D_DEGREE_QUADRATIC = 2, + WINED3D_DEGREE_CUBIC = 3, + WINED3D_DEGREE_QUINTIC = 5, +}; #define WINEMAKEFOURCC(ch0, ch1, ch2, ch3) \ ((DWORD)(BYTE)(ch0) | ((DWORD)(BYTE)(ch1) << 8) | \ @@ -1603,7 +1602,7 @@ struct wined3d_rect_patch_info UINT height; UINT stride; WINED3DBASISTYPE basis; - WINED3DDEGREETYPE degree; + enum wined3d_degree_type degree; }; struct wined3d_tri_patch_info @@ -1611,7 +1610,7 @@ struct wined3d_tri_patch_info UINT start_vertex_offset; UINT vertex_count; WINED3DBASISTYPE basis; - WINED3DDEGREETYPE degree; + enum wined3d_degree_type degree; }; struct wined3d_adapter_identifier
1
0
0
0
Henri Verbeet : ddraw/tests: Move the Direct3D7 ProcessVertices() test to ddraw7.c.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: 5c3ba123decb38a5980cfd10d8ec1f722462ec96 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5c3ba123decb38a5980cfd10d…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Dec 19 21:00:07 2011 +0100 ddraw/tests: Move the Direct3D7 ProcessVertices() test to ddraw7.c. --- dlls/ddraw/tests/Makefile.in | 1 + dlls/ddraw/tests/d3d.c | 224 ---------------------------- dlls/ddraw/tests/ddraw7.c | 329 ++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 330 insertions(+), 224 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=5c3ba123decb38a5980cf…
1
0
0
0
Henri Verbeet : ddraw/tests: Add a ProcessVertices() test for Direct3D3.
by Alexandre Julliard
20 Dec '11
20 Dec '11
Module: wine Branch: master Commit: 7cdfa40156dee8bf8e3268f5b86b4fe0c15008c8 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7cdfa40156dee8bf8e3268f5b…
Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Mon Dec 19 21:00:06 2011 +0100 ddraw/tests: Add a ProcessVertices() test for Direct3D3. --- dlls/ddraw/tests/Makefile.in | 1 + dlls/ddraw/tests/ddraw4.c | 327 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 328 insertions(+), 0 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=7cdfa40156dee8bf8e326…
1
0
0
0
← Newer
1
...
25
26
27
28
29
30
31
...
81
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
Results per page:
10
25
50
100
200