winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
December 2011
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
810 discussions
Start a n
N
ew thread
Jacek Caban : mshtml: Initialize VARIANT before passing it to variant_copy.
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: 30467685bada5ebdad6d43c48d64643dfb85c0be URL:
http://source.winehq.org/git/wine.git/?a=commit;h=30467685bada5ebdad6d43c48…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 12 14:49:33 2011 +0100 mshtml: Initialize VARIANT before passing it to variant_copy. --- dlls/mshtml/dispex.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 8a0ac44..dcbff1c 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -979,6 +979,7 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc case DISPATCH_PROPERTYGET: if(prop->flags & DYNPROP_DELETED) return DISP_E_UNKNOWNNAME; + V_VT(pvarRes) = VT_EMPTY; return variant_copy(pvarRes, &prop->var); case DISPATCH_PROPERTYPUT|DISPATCH_PROPERTYPUTREF: case DISPATCH_PROPERTYPUT:
1
0
0
0
Jacek Caban : jscript: Initialize VARIANT before passing it to disp_propget .
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: 64ef20ce5332f5601a6afe7f12f9a538e45d6475 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=64ef20ce5332f5601a6afe7f1…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 12 14:44:20 2011 +0100 jscript: Initialize VARIANT before passing it to disp_propget. --- dlls/jscript/engine.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 0bc5a5b..da02052 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -1579,6 +1579,7 @@ static HRESULT interp_member(exec_ctx_t *ctx) hres = disp_get_id(ctx->parser->script, obj, arg, 0, &id); if(SUCCEEDED(hres)) { + V_VT(&v) = VT_EMPTY; hres = disp_propget(ctx->parser->script, obj, id, &v, &ctx->ei, NULL/*FIXME*/); }else if(hres == DISP_E_UNKNOWNNAME) { V_VT(&v) = VT_EMPTY;
1
0
0
0
Jacek Caban : jscript: Properly handle NULL IDispatch in stack_pop_object.
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: 2c8e8948df50313990bfa80ba08ac91b4fbe9aec URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2c8e8948df50313990bfa80ba…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 12 14:44:09 2011 +0100 jscript: Properly handle NULL IDispatch in stack_pop_object. --- dlls/jscript/engine.c | 2 + dlls/jscript/jscript.h | 1 + dlls/jscript/jscript.rc | 1 + dlls/jscript/resource.h | 1 + dlls/jscript/tests/api.js | 3 ++ po/ar.po | 50 +++++++++++++++++++++++-------------------- po/bg.po | 50 +++++++++++++++++++++++-------------------- po/ca.po | 51 ++++++++++++++++++++++++-------------------- po/cs.po | 50 +++++++++++++++++++++++-------------------- po/da.po | 51 ++++++++++++++++++++++++-------------------- po/de.po | 51 ++++++++++++++++++++++++-------------------- po/el.po | 50 +++++++++++++++++++++++-------------------- po/en.po | 50 +++++++++++++++++++++++-------------------- po/en_US.po | 50 +++++++++++++++++++++++-------------------- po/eo.po | 50 +++++++++++++++++++++++-------------------- po/es.po | 51 ++++++++++++++++++++++++-------------------- po/fa.po | 50 +++++++++++++++++++++++-------------------- po/fi.po | 50 +++++++++++++++++++++++-------------------- po/fr.po | 51 ++++++++++++++++++++++++-------------------- po/he.po | 50 +++++++++++++++++++++++-------------------- po/hi.po | 50 +++++++++++++++++++++++-------------------- po/hu.po | 51 ++++++++++++++++++++++++-------------------- po/it.po | 51 ++++++++++++++++++++++++-------------------- po/ja.po | 51 ++++++++++++++++++++++++-------------------- po/ko.po | 51 ++++++++++++++++++++++++-------------------- po/lt.po | 51 ++++++++++++++++++++++++-------------------- po/ml.po | 50 +++++++++++++++++++++++-------------------- po/nb_NO.po | 51 ++++++++++++++++++++++++-------------------- po/nl.po | 51 ++++++++++++++++++++++++-------------------- po/or.po | 50 +++++++++++++++++++++++-------------------- po/pa.po | 50 +++++++++++++++++++++++-------------------- po/pl.po | 51 ++++++++++++++++++++++++-------------------- po/pt_BR.po | 51 ++++++++++++++++++++++++-------------------- po/pt_PT.po | 51 ++++++++++++++++++++++++-------------------- po/rm.po | 50 +++++++++++++++++++++++-------------------- po/ro.po | 51 ++++++++++++++++++++++++-------------------- po/ru.po | 51 ++++++++++++++++++++++++-------------------- po/sk.po | 50 +++++++++++++++++++++++-------------------- po/sl.po | 51 ++++++++++++++++++++++++-------------------- po/sr_RS(a)cyrillic.po | 51 ++++++++++++++++++++++++-------------------- po/sr_RS(a)latin.po | 51 ++++++++++++++++++++++++-------------------- po/sv.po | 51 ++++++++++++++++++++++++-------------------- po/te.po | 50 +++++++++++++++++++++++-------------------- po/th.po | 50 +++++++++++++++++++++++-------------------- po/tr.po | 50 +++++++++++++++++++++++-------------------- po/uk.po | 51 ++++++++++++++++++++++++-------------------- po/wa.po | 50 +++++++++++++++++++++++-------------------- po/wine.pot | 50 +++++++++++++++++++++++-------------------- po/zh_CN.po | 50 +++++++++++++++++++++++-------------------- po/zh_TW.po | 50 +++++++++++++++++++++++-------------------- 50 files changed, 1245 insertions(+), 1035 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=2c8e8948df50313990bfa…
1
0
0
0
Jacek Caban : jscript: Use bytecode for instanceof implementation.
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: 6f35c8fd5d1b42b3726e7f572758f6dc55df93d1 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6f35c8fd5d1b42b3726e7f572…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 12 14:43:54 2011 +0100 jscript: Use bytecode for instanceof implementation. --- dlls/jscript/compile.c | 2 + dlls/jscript/engine.c | 105 ++++++++++-------------------------------------- dlls/jscript/engine.h | 2 +- dlls/jscript/parser.y | 2 +- 4 files changed, 26 insertions(+), 85 deletions(-) diff --git a/dlls/jscript/compile.c b/dlls/jscript/compile.c index 1121838..0d4ce79 100644 --- a/dlls/jscript/compile.c +++ b/dlls/jscript/compile.c @@ -661,6 +661,8 @@ static HRESULT compile_expression_noret(compiler_ctx_t *ctx, expression_t *expr, return push_instr_bstr(ctx, OP_ident, ((identifier_expression_t*)expr)->identifier); case EXPR_IN: return compile_binary_expression(ctx, (binary_expression_t*)expr, OP_in); + case EXPR_INSTANCEOF: + return compile_binary_expression(ctx, (binary_expression_t*)expr, OP_instanceof); case EXPR_LESS: return compile_binary_expression(ctx, (binary_expression_t*)expr, OP_lt); case EXPR_LESSEQ: diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 7b85040..288c5d2 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -1389,57 +1389,6 @@ static HRESULT return_bool(exprval_t *ret, DWORD b) return S_OK; } -static HRESULT get_binary_expr_values(script_ctx_t *ctx, binary_expression_t *expr, jsexcept_t *ei, VARIANT *lval, VARIANT *rval) -{ - exprval_t exprval; - HRESULT hres; - - hres = expr_eval(ctx, expr->expression1, 0, ei, &exprval); - if(FAILED(hres)) - return hres; - - hres = exprval_to_value(ctx, &exprval, ei, lval); - exprval_release(&exprval); - if(FAILED(hres)) - return hres; - - hres = expr_eval(ctx, expr->expression2, 0, ei, &exprval); - if(SUCCEEDED(hres)) { - hres = exprval_to_value(ctx, &exprval, ei, rval); - exprval_release(&exprval); - } - - if(FAILED(hres)) { - VariantClear(lval); - return hres; - } - - return S_OK; -} - -typedef HRESULT (*oper_t)(script_ctx_t*,VARIANT*,VARIANT*,jsexcept_t*,VARIANT*); - -static HRESULT binary_expr_eval(script_ctx_t *ctx, binary_expression_t *expr, oper_t oper, jsexcept_t *ei, - exprval_t *ret) -{ - VARIANT lval, rval, retv; - HRESULT hres; - - hres = get_binary_expr_values(ctx, expr, ei, &lval, &rval); - if(FAILED(hres)) - return hres; - - hres = oper(ctx, &lval, &rval, ei, &retv); - VariantClear(&lval); - VariantClear(&rval); - if(FAILED(hres)) - return hres; - - ret->type = EXPRVAL_VARIANT; - ret->u.var = retv; - return S_OK; -} - /* ECMA-262 3rd Edition 13 */ HRESULT function_expression_eval(script_ctx_t *ctx, expression_t *_expr, DWORD flags, jsexcept_t *ei, exprval_t *ret) { @@ -2149,45 +2098,46 @@ static HRESULT interp_and(exec_ctx_t *ctx) } /* ECMA-262 3rd Edition 11.8.6 */ -static HRESULT instanceof_eval(script_ctx_t *ctx, VARIANT *inst, VARIANT *objv, jsexcept_t *ei, VARIANT *retv) +static HRESULT interp_instanceof(exec_ctx_t *ctx) { jsdisp_t *obj, *iter, *tmp = NULL; - VARIANT_BOOL ret = VARIANT_FALSE; - BOOL b; - VARIANT var; + VARIANT prot, *v; + BOOL ret = FALSE; HRESULT hres; static const WCHAR prototypeW[] = {'p','r','o','t','o','t', 'y', 'p','e',0}; - if(V_VT(objv) != VT_DISPATCH || !V_DISPATCH(objv)) - return throw_type_error(ctx, ei, JS_E_FUNCTION_EXPECTED, NULL); + v = stack_pop(ctx); + if(V_VT(v) != VT_DISPATCH || !V_DISPATCH(v)) { + VariantClear(v); + return throw_type_error(ctx->parser->script, &ctx->ei, JS_E_FUNCTION_EXPECTED, NULL); + } - obj = iface_to_jsdisp((IUnknown*)V_DISPATCH(objv)); + obj = iface_to_jsdisp((IUnknown*)V_DISPATCH(v)); + IDispatch_Release(V_DISPATCH(v)); if(!obj) { FIXME("non-jsdisp objects not supported\n"); return E_FAIL; } if(is_class(obj, JSCLASS_FUNCTION)) { - hres = jsdisp_propget_name(obj, prototypeW, &var, ei, NULL/*FIXME*/); + hres = jsdisp_propget_name(obj, prototypeW, &prot, &ctx->ei, NULL/*FIXME*/); }else { - hres = throw_type_error(ctx, ei, JS_E_FUNCTION_EXPECTED, NULL); + hres = throw_type_error(ctx->parser->script, &ctx->ei, JS_E_FUNCTION_EXPECTED, NULL); } jsdisp_release(obj); if(FAILED(hres)) return hres; - if(V_VT(&var) == VT_DISPATCH) { - if(V_VT(inst) == VT_DISPATCH) - tmp = iface_to_jsdisp((IUnknown*)V_DISPATCH(inst)); - for(iter = tmp; iter; iter = iter->prototype) { - hres = disp_cmp(V_DISPATCH(&var), to_disp(iter), &b); + v = stack_pop(ctx); + + if(V_VT(&prot) == VT_DISPATCH) { + if(V_VT(v) == VT_DISPATCH) + tmp = iface_to_jsdisp((IUnknown*)V_DISPATCH(v)); + for(iter = tmp; !ret && iter; iter = iter->prototype) { + hres = disp_cmp(V_DISPATCH(&prot), to_disp(iter), &ret); if(FAILED(hres)) break; - if(b) { - ret = VARIANT_TRUE; - break; - } } if(tmp) @@ -2197,23 +2147,12 @@ static HRESULT instanceof_eval(script_ctx_t *ctx, VARIANT *inst, VARIANT *objv, hres = E_FAIL; } - VariantClear(&var); + VariantClear(&prot); + VariantClear(v); if(FAILED(hres)) return hres; - V_VT(retv) = VT_BOOL; - V_BOOL(retv) = ret; - return S_OK; -} - -/* ECMA-262 3rd Edition 11.8.6 */ -HRESULT instanceof_expression_eval(script_ctx_t *ctx, expression_t *_expr, DWORD flags, jsexcept_t *ei, exprval_t *ret) -{ - binary_expression_t *expr = (binary_expression_t*)_expr; - - TRACE("\n"); - - return binary_expr_eval(ctx, expr, instanceof_eval, ei, ret); + return stack_push_bool(ctx, ret); } /* ECMA-262 3rd Edition 11.8.7 */ diff --git a/dlls/jscript/engine.h b/dlls/jscript/engine.h index e6ad0c9..b9e6441 100644 --- a/dlls/jscript/engine.h +++ b/dlls/jscript/engine.h @@ -61,6 +61,7 @@ typedef struct _func_stack { X(ident, 1, ARG_BSTR, 0) \ X(identid, 1, ARG_BSTR, ARG_INT) \ X(in, 1, 0,0) \ + X(instanceof, 1, 0,0) \ X(int, 1, ARG_INT, 0) \ X(jmp, 0, ARG_ADDR, 0) \ X(jmp_nz, 0, ARG_ADDR, 0) \ @@ -565,7 +566,6 @@ HRESULT member_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exp HRESULT identifier_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT property_value_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; -HRESULT instanceof_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT delete_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; HRESULT typeof_expression_eval(script_ctx_t*,expression_t*,DWORD,jsexcept_t*,exprval_t*) DECLSPEC_HIDDEN; diff --git a/dlls/jscript/parser.y b/dlls/jscript/parser.y index 76d1c1d..88676dd 100644 --- a/dlls/jscript/parser.y +++ b/dlls/jscript/parser.y @@ -1310,7 +1310,7 @@ static const expression_eval_t expression_eval_table[] = { compiled_expression_eval, compiled_expression_eval, compiled_expression_eval, - instanceof_expression_eval, + compiled_expression_eval, compiled_expression_eval, compiled_expression_eval, compiled_expression_eval,
1
0
0
0
Jacek Caban : jscript: Don't use EXPR_NEWREF in forin_statement_event.
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: f8e3e92be3c979c52911bea326c28be9755cdfcf URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f8e3e92be3c979c52911bea32…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 12 14:43:35 2011 +0100 jscript: Don't use EXPR_NEWREF in forin_statement_event. --- dlls/jscript/engine.c | 2 +- dlls/jscript/tests/lang.js | 5 +++++ 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 0f9263f..7b85040 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -1012,7 +1012,7 @@ HRESULT forin_statement_eval(script_ctx_t *ctx, statement_t *_stat, return_type_ return hres; } - hres = expr_eval(ctx, stat->in_expr, EXPR_NEWREF, &rt->ei, &exprval); + hres = expr_eval(ctx, stat->in_expr, 0, &rt->ei, &exprval); if(FAILED(hres)) return hres; diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js index bbd2c42..5677d32 100644 --- a/dlls/jscript/tests/lang.js +++ b/dlls/jscript/tests/lang.js @@ -803,6 +803,11 @@ obj1 = new Object(); for(obj1.nonexistent; tmp; tmp = false) ok(!("nonexistent" in obj1), "nonexistent added to obj1"); +obj1 = new Object(); +for(tmp in obj1.nonexistent) + ok(false, "for(tmp in obj1.nonexistent) called with tmp = " + tmp); +ok(!("nonexistent" in obj1), "nonexistent added to obj1 by for..in loop"); + ok((void 1) === undefined, "(void 1) !== undefined"); var inobj = new Object();
1
0
0
0
Jacek Caban : jscript: Don't use EXPR_NEWREF in for_statement_event.
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: 106fcb8e87c5c1f5ceea5d3c25785806a9d08b54 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=106fcb8e87c5c1f5ceea5d3c2…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 12 14:43:24 2011 +0100 jscript: Don't use EXPR_NEWREF in for_statement_event. --- dlls/jscript/engine.c | 2 +- dlls/jscript/tests/lang.js | 5 +++++ 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index 7886c0c..0f9263f 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -929,7 +929,7 @@ HRESULT for_statement_eval(script_ctx_t *ctx, statement_t *_stat, return_type_t if(FAILED(hres)) return hres; }else if(stat->begin_expr) { - hres = expr_eval(ctx, stat->begin_expr, EXPR_NEWREF, &rt->ei, &exprval); + hres = expr_eval(ctx, stat->begin_expr, 0, &rt->ei, &exprval); if(FAILED(hres)) return hres; diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js index 3710ae7..bbd2c42 100644 --- a/dlls/jscript/tests/lang.js +++ b/dlls/jscript/tests/lang.js @@ -798,6 +798,11 @@ for(var fi=0; fi < 4; fi++) ok(fi < 4, "fi = " + fi); ok(fi === 4, "fi !== 4"); +tmp = true; +obj1 = new Object(); +for(obj1.nonexistent; tmp; tmp = false) + ok(!("nonexistent" in obj1), "nonexistent added to obj1"); + ok((void 1) === undefined, "(void 1) !== undefined"); var inobj = new Object();
1
0
0
0
Aric Stewart : usp10: Add Khmer script.
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: f68c03c4b2b6ea60e20ea2045036d4bc355f2f23 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f68c03c4b2b6ea60e20ea2045…
Author: Aric Stewart <aric(a)codeweavers.com> Date: Mon Dec 12 07:32:15 2011 -0600 usp10: Add Khmer script. --- dlls/usp10/shape.c | 66 +++++++++++++++++++++++++++++++++++++++++++ dlls/usp10/tests/usp10.c | 9 ++++++ dlls/usp10/usp10.c | 15 +++++++++- dlls/usp10/usp10_internal.h | 2 + 4 files changed, 91 insertions(+), 1 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=f68c03c4b2b6ea60e20ea…
1
0
0
0
Aric Stewart : usp10: Add New Tai Lue script.
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: 05cd57b4f0fa799fa060739cf04be42959b0029f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=05cd57b4f0fa799fa060739cf…
Author: Aric Stewart <aric(a)codeweavers.com> Date: Mon Dec 12 07:32:10 2011 -0600 usp10: Add New Tai Lue script. --- dlls/usp10/shape.c | 2 ++ dlls/usp10/tests/usp10.c | 10 ++++++++++ dlls/usp10/usp10.c | 13 ++++++++++++- dlls/usp10/usp10_internal.h | 2 ++ 4 files changed, 26 insertions(+), 1 deletions(-) diff --git a/dlls/usp10/shape.c b/dlls/usp10/shape.c index f2b2a7b..d2926ff 100644 --- a/dlls/usp10/shape.c +++ b/dlls/usp10/shape.c @@ -607,6 +607,8 @@ static const ScriptShapeData ShapingData[] = {{ myanmar_features, 2}, NULL, "mymr", "", NULL, NULL}, {{ myanmar_features, 2}, NULL, "mymr", "", NULL, NULL}, {{ standard_features, 2}, NULL, "tale", "", NULL, NULL}, + {{ standard_features, 2}, NULL, "talu", "", NULL, NULL}, + {{ standard_features, 2}, NULL, "talu", "", NULL, NULL}, }; static INT GSUB_is_glyph_covered(LPCVOID table , UINT glyph) diff --git a/dlls/usp10/tests/usp10.c b/dlls/usp10/tests/usp10.c index 7ae232a..45661b2 100644 --- a/dlls/usp10/tests/usp10.c +++ b/dlls/usp10/tests/usp10.c @@ -151,6 +151,7 @@ static inline void _test_items_ok(LPCWSTR string, DWORD cchString, #define mlym_tag MS_MAKE_TAG('m','l','y','m') #define mymr_tag MS_MAKE_TAG('m','y','m','r') #define tale_tag MS_MAKE_TAG('t','a','l','e') +#define talu_tag MS_MAKE_TAG('t','a','l','u') static void test_ScriptItemize( void ) { @@ -310,6 +311,11 @@ static void test_ScriptItemize( void ) static const itemTest t251[2] = {{{0,0,0,0,0},0,0,0,0,tale_tag,TRUE,{-1,-1,-1,-1,latn_tag}},{{0,0,0,0,0},10,0,0,0,-1,FALSE}}; static const itemTest t252[2] = {{{0,0,0,0,0},0,0,0,2,tale_tag,TRUE,{-1,1,1,1,latn_tag}},{{0,0,0,0,0},10,0,0,0,-1,FALSE}}; + /* New Tai Lue */ + static const WCHAR test26[] = {0x1992,0x19c4}; + static const itemTest t261[2] = {{{0,0,0,0,0},0,0,0,0,talu_tag,TRUE,{-1,-1,-1,-1,latn_tag}},{{0,0,0,0,0},2,0,0,0,-1,FALSE}}; + static const itemTest t262[2] = {{{0,0,0,0,0},0,0,0,2,talu_tag,TRUE,{-1,1,1,1,latn_tag}},{{0,0,0,0,0},2,0,0,0,-1,FALSE}}; + SCRIPT_ITEM items[15]; @@ -370,6 +376,7 @@ static void test_ScriptItemize( void ) test_items_ok(test23,6,NULL,NULL,2,t231,FALSE,0); test_items_ok(test24,12,NULL,NULL,1,t241,FALSE,0); test_items_ok(test25,10,NULL,NULL,1,t251,FALSE,0); + test_items_ok(test26,2,NULL,NULL,1,t261,FALSE,0); State.uBidiLevel = 0; test_items_ok(test1,4,&Control,&State,1,t11,FALSE,0); @@ -402,6 +409,7 @@ static void test_ScriptItemize( void ) test_items_ok(test23,6,&Control,&State,2,t231,FALSE,0); test_items_ok(test24,12,&Control,&State,1,t241,FALSE,0); test_items_ok(test25,10,&Control,&State,1,t251,FALSE,0); + test_items_ok(test26,2,&Control,&State,1,t261,FALSE,0); State.uBidiLevel = 1; test_items_ok(test1,4,&Control,&State,1,t12,FALSE,0); @@ -434,6 +442,7 @@ static void test_ScriptItemize( void ) test_items_ok(test23,6,&Control,&State,2,t232,FALSE,0); test_items_ok(test24,12,&Control,&State,1,t242,FALSE,0); test_items_ok(test25,10,&Control,&State,1,t252,FALSE,0); + test_items_ok(test26,2,&Control,&State,1,t262,FALSE,0); State.uBidiLevel = 1; Control.fMergeNeutralItems = TRUE; @@ -467,6 +476,7 @@ static void test_ScriptItemize( void ) test_items_ok(test23,6,&Control,&State,2,t232,FALSE,0); test_items_ok(test24,12,&Control,&State,1,t242,FALSE,0); test_items_ok(test25,10,&Control,&State,1,t252,FALSE,0); + test_items_ok(test26,2,&Control,&State,1,t262,FALSE,0); } static inline void _test_shape_ok(int valid, HDC hdc, LPCWSTR string, diff --git a/dlls/usp10/usp10.c b/dlls/usp10/usp10.c index 5782591..846d03c 100644 --- a/dlls/usp10/usp10.c +++ b/dlls/usp10/usp10.c @@ -113,6 +113,8 @@ static const scriptRange scriptRanges[] = { { Script_Georgian, 0x10a0, 0x10ff, 0, 0}, /* Tai Le: U+1950–U+197F */ { Script_Tai_Le, 0x1950, 0x197f, 0, 0}, + /* New Tai Lue: U+1980–U+19DF */ + { Script_New_Tai_Lue,0x1980, 0x19df, Script_New_Tai_Lue_Numeric, 0}, /* Vedic Extensions: U+1CD0-U+1CFF */ { Script_Devanagari, 0x1cd0, 0x1cff, Script_Devanagari_Numeric, 0}, /* Phonetic Extensions: U+1D00–U+1DBF */ @@ -395,6 +397,14 @@ static const scriptData scriptInformation[] = { {0, 0, 1, 0, 1, DEFAULT_CHARSET, 0, 0, 0, 0, 0, 0, 0, 0, 0}, MS_MAKE_TAG('t','a','l','e'), {'M','i','c','r','o','s','o','f','t',' ','T','a','i',' ','L','e'}}, + {{Script_New_Tai_Lue, 0, 0, 0, 0, 0, 0, { 0,0,0,0,0,0,0,0,0,0,0}}, + {0, 0, 1, 0, 1, DEFAULT_CHARSET, 0, 0, 0, 0, 0, 0, 0, 0, 0}, + MS_MAKE_TAG('t','a','l','u'), + {'M','i','c','r','o','s','o','f','t',' ','N','e','w',' ','T','a','i',' ','L','u','e'}}, + {{Script_New_Tai_Lue_Numeric, 0, 0, 0, 0, 0, 0, { 0,0,0,0,0,0,0,0,0,0,0}}, + {0, 0, 1, 0, 1, DEFAULT_CHARSET, 0, 0, 0, 0, 0, 0, 0, 0, 0}, + MS_MAKE_TAG('t','a','l','u'), + {'M','i','c','r','o','s','o','f','t',' ','N','e','w',' ','T','a','i',' ','L','u','e'}}, }; static const SCRIPT_PROPERTIES *script_props[] = @@ -423,7 +433,8 @@ static const SCRIPT_PROPERTIES *script_props[] = &scriptInformation[42].props, &scriptInformation[43].props, &scriptInformation[44].props, &scriptInformation[45].props, &scriptInformation[46].props, &scriptInformation[47].props, - &scriptInformation[48].props, &scriptInformation[49].props + &scriptInformation[48].props, &scriptInformation[49].props, + &scriptInformation[50].props, &scriptInformation[51].props }; typedef struct { diff --git a/dlls/usp10/usp10_internal.h b/dlls/usp10/usp10_internal.h index 2a385d5..5bb352a 100644 --- a/dlls/usp10/usp10_internal.h +++ b/dlls/usp10/usp10_internal.h @@ -79,6 +79,8 @@ #define Script_Myanmar 47 #define Script_Myanmar_Numeric 48 #define Script_Tai_Le 49 +#define Script_New_Tai_Lue 50 +#define Script_New_Tai_Lue_Numeric 51 #define GLYPH_BLOCK_SHIFT 8 #define GLYPH_BLOCK_SIZE (1UL << GLYPH_BLOCK_SHIFT)
1
0
0
0
Aric Stewart : usp10: Add script Tai Le.
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: 51b5e6090a59744629d9d4430f0bcdc8296ab6c3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=51b5e6090a59744629d9d4430…
Author: Aric Stewart <aric(a)codeweavers.com> Date: Mon Dec 12 07:31:56 2011 -0600 usp10: Add script Tai Le. --- dlls/usp10/shape.c | 1 + dlls/usp10/tests/usp10.c | 11 +++++++++++ dlls/usp10/usp10.c | 8 +++++++- dlls/usp10/usp10_internal.h | 1 + 4 files changed, 20 insertions(+), 1 deletions(-) diff --git a/dlls/usp10/shape.c b/dlls/usp10/shape.c index 675765a..f2b2a7b 100644 --- a/dlls/usp10/shape.c +++ b/dlls/usp10/shape.c @@ -606,6 +606,7 @@ static const ScriptShapeData ShapingData[] = {{ standard_features, 2}, NULL, "" , "", NULL, NULL}, {{ myanmar_features, 2}, NULL, "mymr", "", NULL, NULL}, {{ myanmar_features, 2}, NULL, "mymr", "", NULL, NULL}, + {{ standard_features, 2}, NULL, "tale", "", NULL, NULL}, }; static INT GSUB_is_glyph_covered(LPCVOID table , UINT glyph) diff --git a/dlls/usp10/tests/usp10.c b/dlls/usp10/tests/usp10.c index 74fe334..7ae232a 100644 --- a/dlls/usp10/tests/usp10.c +++ b/dlls/usp10/tests/usp10.c @@ -150,6 +150,7 @@ static inline void _test_items_ok(LPCWSTR string, DWORD cchString, #define knda_tag MS_MAKE_TAG('k','n','d','a') #define mlym_tag MS_MAKE_TAG('m','l','y','m') #define mymr_tag MS_MAKE_TAG('m','y','m','r') +#define tale_tag MS_MAKE_TAG('t','a','l','e') static void test_ScriptItemize( void ) { @@ -304,6 +305,12 @@ static void test_ScriptItemize( void ) static const itemTest t241[2] = {{{0,0,0,0,0},0,0,0,0,mymr_tag,FALSE},{{0,0,0,0,0},12,0,0,0,-1,FALSE}}; static const itemTest t242[2] = {{{0,0,0,0,0},0,0,0,2,mymr_tag,TRUE,{-1,1,1,1,-1}},{{0,0,0,0,0},12,0,0,0,-1,FALSE}}; + /* Tai Le */ + static const WCHAR test25[] = {0x1956,0x196d,0x1970,0x1956,0x196c,0x1973,0x1951,0x1968,0x1952,0x1970}; + static const itemTest t251[2] = {{{0,0,0,0,0},0,0,0,0,tale_tag,TRUE,{-1,-1,-1,-1,latn_tag}},{{0,0,0,0,0},10,0,0,0,-1,FALSE}}; + static const itemTest t252[2] = {{{0,0,0,0,0},0,0,0,2,tale_tag,TRUE,{-1,1,1,1,latn_tag}},{{0,0,0,0,0},10,0,0,0,-1,FALSE}}; + + SCRIPT_ITEM items[15]; SCRIPT_CONTROL Control; @@ -362,6 +369,7 @@ static void test_ScriptItemize( void ) test_items_ok(test22,6,NULL,NULL,2,t221,FALSE,0); test_items_ok(test23,6,NULL,NULL,2,t231,FALSE,0); test_items_ok(test24,12,NULL,NULL,1,t241,FALSE,0); + test_items_ok(test25,10,NULL,NULL,1,t251,FALSE,0); State.uBidiLevel = 0; test_items_ok(test1,4,&Control,&State,1,t11,FALSE,0); @@ -393,6 +401,7 @@ static void test_ScriptItemize( void ) test_items_ok(test22,6,&Control,&State,2,t221,FALSE,0); test_items_ok(test23,6,&Control,&State,2,t231,FALSE,0); test_items_ok(test24,12,&Control,&State,1,t241,FALSE,0); + test_items_ok(test25,10,&Control,&State,1,t251,FALSE,0); State.uBidiLevel = 1; test_items_ok(test1,4,&Control,&State,1,t12,FALSE,0); @@ -424,6 +433,7 @@ static void test_ScriptItemize( void ) test_items_ok(test22,6,&Control,&State,2,t222,FALSE,1); test_items_ok(test23,6,&Control,&State,2,t232,FALSE,0); test_items_ok(test24,12,&Control,&State,1,t242,FALSE,0); + test_items_ok(test25,10,&Control,&State,1,t252,FALSE,0); State.uBidiLevel = 1; Control.fMergeNeutralItems = TRUE; @@ -456,6 +466,7 @@ static void test_ScriptItemize( void ) test_items_ok(test22,6,&Control,&State,1,t223,FALSE,2); test_items_ok(test23,6,&Control,&State,2,t232,FALSE,0); test_items_ok(test24,12,&Control,&State,1,t242,FALSE,0); + test_items_ok(test25,10,&Control,&State,1,t252,FALSE,0); } static inline void _test_shape_ok(int valid, HDC hdc, LPCWSTR string, diff --git a/dlls/usp10/usp10.c b/dlls/usp10/usp10.c index 1f225b0..5782591 100644 --- a/dlls/usp10/usp10.c +++ b/dlls/usp10/usp10.c @@ -111,6 +111,8 @@ static const scriptRange scriptRanges[] = { { Script_Myanmar, 0x1000, 0x109f, Script_Myanmar_Numeric, 0}, /* Georgian: U+10A0–U+10FF */ { Script_Georgian, 0x10a0, 0x10ff, 0, 0}, + /* Tai Le: U+1950–U+197F */ + { Script_Tai_Le, 0x1950, 0x197f, 0, 0}, /* Vedic Extensions: U+1CD0-U+1CFF */ { Script_Devanagari, 0x1cd0, 0x1cff, Script_Devanagari_Numeric, 0}, /* Phonetic Extensions: U+1D00–U+1DBF */ @@ -389,6 +391,10 @@ static const scriptData scriptInformation[] = { {0x55, 1, 1, 0, 0, DEFAULT_CHARSET, 0, 0, 0, 0, 0, 0, 0, 0, 0}, MS_MAKE_TAG('m','y','m','r'), {0}}, + {{Script_Tai_Le, 0, 0, 0, 0, 0, 0, { 0,0,0,0,0,0,0,0,0,0,0}}, + {0, 0, 1, 0, 1, DEFAULT_CHARSET, 0, 0, 0, 0, 0, 0, 0, 0, 0}, + MS_MAKE_TAG('t','a','l','e'), + {'M','i','c','r','o','s','o','f','t',' ','T','a','i',' ','L','e'}}, }; static const SCRIPT_PROPERTIES *script_props[] = @@ -417,7 +423,7 @@ static const SCRIPT_PROPERTIES *script_props[] = &scriptInformation[42].props, &scriptInformation[43].props, &scriptInformation[44].props, &scriptInformation[45].props, &scriptInformation[46].props, &scriptInformation[47].props, - &scriptInformation[48].props + &scriptInformation[48].props, &scriptInformation[49].props }; typedef struct { diff --git a/dlls/usp10/usp10_internal.h b/dlls/usp10/usp10_internal.h index bade039..2a385d5 100644 --- a/dlls/usp10/usp10_internal.h +++ b/dlls/usp10/usp10_internal.h @@ -78,6 +78,7 @@ /* Unicode Chapter 11 continued */ #define Script_Myanmar 47 #define Script_Myanmar_Numeric 48 +#define Script_Tai_Le 49 #define GLYPH_BLOCK_SHIFT 8 #define GLYPH_BLOCK_SIZE (1UL << GLYPH_BLOCK_SHIFT)
1
0
0
0
Aric Stewart : usp10/tests: Check broken value for script tag as well.
by Alexandre Julliard
12 Dec '11
12 Dec '11
Module: wine Branch: master Commit: 1dc4c151d7b96e04aab4ac00c3d9767dbb05b4e8 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1dc4c151d7b96e04aab4ac00c…
Author: Aric Stewart <aric(a)codeweavers.com> Date: Mon Dec 12 07:31:45 2011 -0600 usp10/tests: Check broken value for script tag as well. --- dlls/usp10/tests/usp10.c | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dlls/usp10/tests/usp10.c b/dlls/usp10/tests/usp10.c index 5f47903..74fe334 100644 --- a/dlls/usp10/tests/usp10.c +++ b/dlls/usp10/tests/usp10.c @@ -117,7 +117,9 @@ static inline void _test_items_ok(LPCWSTR string, DWORD cchString, winetest_ok(outpItems[x].a.eScript != SCRIPT_UNDEFINED, "%i: Undefined script\n",x); if (pScriptItemizeOpenType) { - if (items[x].todo_flag[4]) + if (items[x].isBroken && broken(tags[x] == items[x].broken_value[4])) + winetest_win_skip("This test broken on this platform\n"); + else if (items[x].todo_flag[4]) todo_wine winetest_ok(tags[x] == items[x].scriptTag,"%i:Incorrect Script Tag %x != %x\n",x,tags[x],items[x].scriptTag); else winetest_ok(tags[x] == items[x].scriptTag,"%i:Incorrect Script Tag %x != %x\n",x,tags[x],items[x].scriptTag);
1
0
0
0
← Newer
1
...
46
47
48
49
50
51
52
...
81
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
Results per page:
10
25
50
100
200