wine-commits February 2011

wine-commits@winehq.org

2 participants
674 discussions

Huw Davies : oleaut32: Implement proxy / stub for ITypeLib_GetDocumentation .
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: afeaaf3787647a416a9412d230bab5467e6616b8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=afeaaf3787647a416a9412d23… Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Feb 11 10:24:51 2011 +0000 oleaut32: Implement proxy / stub for ITypeLib_GetDocumentation. --- dlls/oleaut32/usrmarshal.c | 58 +++++++++++++++++++++++++++++-------------- 1 files changed, 39 insertions(+), 19 deletions(-) diff --git a/dlls/oleaut32/usrmarshal.c b/dlls/oleaut32/usrmarshal.c index 2e64395..8f9e00c 100644 --- a/dlls/oleaut32/usrmarshal.c +++ b/dlls/oleaut32/usrmarshal.c @@ -1974,29 +1974,49 @@ HRESULT __RPC_STUB ITypeLib_GetLibAttr_Stub( return hr; } -HRESULT CALLBACK ITypeLib_GetDocumentation_Proxy( - ITypeLib* This, - INT index, - BSTR* pBstrName, - BSTR* pBstrDocString, - DWORD* pdwHelpContext, - BSTR* pBstrHelpFile) +HRESULT CALLBACK ITypeLib_GetDocumentation_Proxy(ITypeLib *This, INT index, BSTR *name, + BSTR *doc_string, DWORD *help_context, + BSTR *help_file) { - FIXME("not implemented\n"); - return E_FAIL; + DWORD dummy_help_context, flags = 0; + BSTR dummy_name, dummy_doc_string, dummy_help_file; + HRESULT hr; + TRACE("(%p, %d, %p, %p, %p, %p)\n", This, index, name, doc_string, help_context, help_file); + + if(!name) name = &dummy_name; + else flags = 1; + + if(!doc_string) doc_string = &dummy_doc_string; + else flags |= 2; + + if(!help_context) help_context = &dummy_help_context; + else flags |= 4; + + if(!help_file) help_file = &dummy_help_file; + else flags |= 8; + + hr = ITypeLib_RemoteGetDocumentation_Proxy(This, index, flags, name, doc_string, help_context, help_file); + + /* We don't need to free the dummy BSTRs since the stub ensures that these will be NULLs. */ + + return hr; } -HRESULT __RPC_STUB ITypeLib_GetDocumentation_Stub( - ITypeLib* This, - INT index, - DWORD refPtrFlags, - BSTR* pBstrName, - BSTR* pBstrDocString, - DWORD* pdwHelpContext, - BSTR* pBstrHelpFile) +HRESULT __RPC_STUB ITypeLib_GetDocumentation_Stub(ITypeLib *This, INT index, DWORD flags, + BSTR *name, BSTR *doc_string, + DWORD *help_context, BSTR *help_file) { - FIXME("not implemented\n"); - return E_FAIL; + TRACE("(%p, %d, %08x, %p, %p, %p, %p)\n", This, index, flags, name, doc_string, help_context, help_file); + + *name = *doc_string = *help_file = NULL; + *help_context = 0; + + if(!(flags & 1)) name = NULL; + if(!(flags & 2)) doc_string = NULL; + if(!(flags & 4)) help_context = NULL; + if(!(flags & 8)) help_file = NULL; + + return ITypeLib_GetDocumentation(This, index, name, doc_string, help_context, help_file); } HRESULT CALLBACK ITypeLib_IsName_Proxy(

1 0

Huw Davies : oleaut32: Implement proxy / stub for ITypeInfo2_GetDocumentation2.
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: 1260bc8892db9f557d059078019cd72c4d4d0658 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1260bc8892db9f557d0590780… Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Feb 11 10:19:32 2011 +0000 oleaut32: Implement proxy / stub for ITypeInfo2_GetDocumentation2. --- dlls/oleaut32/usrmarshal.c | 55 ++++++++++++++++++++++++++++--------------- 1 files changed, 36 insertions(+), 19 deletions(-) diff --git a/dlls/oleaut32/usrmarshal.c b/dlls/oleaut32/usrmarshal.c index d6e4bdd..2e64395 100644 --- a/dlls/oleaut32/usrmarshal.c +++ b/dlls/oleaut32/usrmarshal.c @@ -1877,29 +1877,46 @@ HRESULT __RPC_STUB ITypeInfo_ReleaseVarDesc_Stub( /* ITypeInfo2 */ -HRESULT CALLBACK ITypeInfo2_GetDocumentation2_Proxy( - ITypeInfo2* This, - MEMBERID memid, - LCID lcid, - BSTR* pbstrHelpString, - DWORD* pdwHelpStringContext, - BSTR* pbstrHelpStringDll) +HRESULT CALLBACK ITypeInfo2_GetDocumentation2_Proxy(ITypeInfo2 *This, MEMBERID memid, + LCID lcid, BSTR *help_string, + DWORD *help_context, BSTR *help_dll) { - FIXME("not implemented\n"); - return E_FAIL; + DWORD dummy_help_context, flags = 0; + BSTR dummy_help_string, dummy_help_dll; + HRESULT hr; + TRACE("(%p, %08x, %08x, %p, %p, %p)\n", This, memid, lcid, help_string, help_context, help_dll); + + if(!help_string) help_string = &dummy_help_string; + else flags = 1; + + if(!help_context) help_context = &dummy_help_context; + else flags |= 2; + + if(!help_dll) help_dll = &dummy_help_dll; + else flags |= 4; + + hr = ITypeInfo2_RemoteGetDocumentation2_Proxy(This, memid, lcid, flags, help_string, help_context, help_dll); + + /* We don't need to free the dummy BSTRs since the stub ensures that these will be NULLs. */ + + return hr; } -HRESULT __RPC_STUB ITypeInfo2_GetDocumentation2_Stub( - ITypeInfo2* This, - MEMBERID memid, - LCID lcid, - DWORD refPtrFlags, - BSTR* pbstrHelpString, - DWORD* pdwHelpStringContext, - BSTR* pbstrHelpStringDll) +HRESULT __RPC_STUB ITypeInfo2_GetDocumentation2_Stub(ITypeInfo2 *This, MEMBERID memid, + LCID lcid, DWORD flags, + BSTR *help_string, DWORD *help_context, + BSTR *help_dll) { - FIXME("not implemented\n"); - return E_FAIL; + TRACE("(%p, %08x, %08x, %08x, %p, %p, %p)\n", This, memid, lcid, flags, help_string, help_context, help_dll); + + *help_string = *help_dll = NULL; + *help_context = 0; + + if(!(flags & 1)) help_string = NULL; + if(!(flags & 2)) help_context = NULL; + if(!(flags & 4)) help_dll = NULL; + + return ITypeInfo2_GetDocumentation2(This, memid, lcid, help_string, help_context, help_dll); } /* ITypeLib */

1 0

Huw Davies : oleaut32: Implement proxy / stub for ITypeInfo_GetDllEntry.
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: 7cdc8bb418b5213e9ecb5786479de49cb051febd URL: http://source.winehq.org/git/wine.git/?a=commit;h=7cdc8bb418b5213e9ecb57864… Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Feb 11 10:08:43 2011 +0000 oleaut32: Implement proxy / stub for ITypeInfo_GetDllEntry. --- dlls/oleaut32/usrmarshal.c | 56 +++++++++++++++++++++++++++++--------------- 1 files changed, 37 insertions(+), 19 deletions(-) diff --git a/dlls/oleaut32/usrmarshal.c b/dlls/oleaut32/usrmarshal.c index f83b908..d6e4bdd 100644 --- a/dlls/oleaut32/usrmarshal.c +++ b/dlls/oleaut32/usrmarshal.c @@ -1696,29 +1696,47 @@ HRESULT __RPC_STUB ITypeInfo_GetDocumentation_Stub(ITypeInfo *This, MEMBERID mem return ITypeInfo_GetDocumentation(This, memid, name, doc_string, help_context, help_file); } -HRESULT CALLBACK ITypeInfo_GetDllEntry_Proxy( - ITypeInfo* This, - MEMBERID memid, - INVOKEKIND invKind, - BSTR* pBstrDllName, - BSTR* pBstrName, - WORD* pwOrdinal) +HRESULT CALLBACK ITypeInfo_GetDllEntry_Proxy(ITypeInfo *This, MEMBERID memid, + INVOKEKIND invkind, BSTR *dll_name, + BSTR* name, WORD *ordinal) { - FIXME("not implemented\n"); - return E_FAIL; + DWORD flags = 0; + BSTR dummy_dll_name, dummy_name; + WORD dummy_ordinal; + HRESULT hr; + TRACE("(%p, %08x, %x, %p, %p, %p)\n", This, memid, invkind, dll_name, name, ordinal); + + if(!dll_name) dll_name = &dummy_dll_name; + else flags = 1; + + if(!name) name = &dummy_name; + else flags |= 2; + + if(!ordinal) ordinal = &dummy_ordinal; + else flags |= 4; + + hr = ITypeInfo_RemoteGetDllEntry_Proxy(This, memid, invkind, flags, dll_name, name, ordinal); + + /* We don't need to free the dummy BSTRs since the stub ensures that these will be NULLs. */ + + return hr; } -HRESULT __RPC_STUB ITypeInfo_GetDllEntry_Stub( - ITypeInfo* This, - MEMBERID memid, - INVOKEKIND invKind, - DWORD refPtrFlags, - BSTR* pBstrDllName, - BSTR* pBstrName, - WORD* pwOrdinal) +HRESULT __RPC_STUB ITypeInfo_GetDllEntry_Stub(ITypeInfo *This, MEMBERID memid, + INVOKEKIND invkind, DWORD flags, + BSTR *dll_name, BSTR *name, + WORD *ordinal) { - FIXME("not implemented\n"); - return E_FAIL; + TRACE("(%p, %08x, %x, %p, %p, %p)\n", This, memid, invkind, dll_name, name, ordinal); + + *dll_name = *name = NULL; + *ordinal = 0; + + if(!(flags & 1)) dll_name = NULL; + if(!(flags & 2)) name = NULL; + if(!(flags & 4)) ordinal = NULL; + + return ITypeInfo_GetDllEntry(This, memid, invkind, dll_name, name, ordinal); } HRESULT CALLBACK ITypeInfo_AddressOfMember_Proxy(

1 0

Austin English : ntdll/tests: Make sure a return value is used (LLVM/Clang) .
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: 39ef0b9d1271f0cd1bca0efb9f8a418ae7afe04e URL: http://source.winehq.org/git/wine.git/?a=commit;h=39ef0b9d1271f0cd1bca0efb9… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:27:48 2011 -0800 ntdll/tests: Make sure a return value is used (LLVM/Clang). --- dlls/ntdll/tests/env.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/tests/env.c b/dlls/ntdll/tests/env.c index 8289841..6bd1530 100644 --- a/dlls/ntdll/tests/env.c +++ b/dlls/ntdll/tests/env.c @@ -244,6 +244,7 @@ static void testExpand(void) us_dst.Buffer = NULL; nts = pRtlExpandEnvironmentStrings_U(small_env, &us_src, &us_dst, &ul); + ok(nts == STATUS_BUFFER_TOO_SMALL, "Call failed (%u)\n", nts); ok(ul == strlen(test->dst) * sizeof(WCHAR) + sizeof(WCHAR), "Wrong returned length for %s: %u\n", test->src, ul );

1 0

Austin English : shlwapi/tests: Remove useless assignments (LLVM/Clang).
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: 92f48ef6ec1ddd049d93a329fede88d5c1b03f5f URL: http://source.winehq.org/git/wine.git/?a=commit;h=92f48ef6ec1ddd049d93a329f… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:33:05 2011 -0800 shlwapi/tests: Remove useless assignments (LLVM/Clang). --- dlls/shlwapi/tests/clist.c | 16 ++++++---------- 1 files changed, 6 insertions(+), 10 deletions(-) diff --git a/dlls/shlwapi/tests/clist.c b/dlls/shlwapi/tests/clist.c index 0c1704d..65d3178 100644 --- a/dlls/shlwapi/tests/clist.c +++ b/dlls/shlwapi/tests/clist.c @@ -371,26 +371,22 @@ static void test_CList(void) inserted = (LPSHLWAPI_CLIST)buff; inserted->ulSize = sizeof(SHLWAPI_CLIST) -1; inserted->ulId = 33; - hRet = pSHLWAPI_20(&list, inserted); + /* The call succeeds but the item is not inserted, except on some early * versions which return failure. Wine behaves like later versions. */ - if (0) - { - ok(hRet == S_OK, "failed bad element size\n"); - } + pSHLWAPI_20(&list, inserted); + inserted = pSHLWAPI_22(list, 33); ok(inserted == NULL, "inserted bad element size\n"); inserted = (LPSHLWAPI_CLIST)buff; inserted->ulSize = 44; inserted->ulId = ~0U; - hRet = pSHLWAPI_20(&list, inserted); + /* See comment above, some early versions fail this call */ - if (0) - { - ok(hRet == S_OK, "failed adding a container\n"); - } + pSHLWAPI_20(&list, inserted); + item = SHLWAPI_CLIST_items; /* Look for nonexistent item in populated list */

1 0

Austin English : secur32/tests: Make sure return values are used (LLVM/ Clang).
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: 1c659a5509585c162e69b084a8bd072c58711033 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1c659a5509585c162e69b084a… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:28:45 2011 -0800 secur32/tests: Make sure return values are used (LLVM/Clang). --- dlls/secur32/tests/schannel.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/dlls/secur32/tests/schannel.c b/dlls/secur32/tests/schannel.c index 7eac489..1b6fdf8 100644 --- a/dlls/secur32/tests/schannel.c +++ b/dlls/secur32/tests/schannel.c @@ -253,7 +253,7 @@ static void testAcquireSecurityContext(void) ok(st == SEC_E_NO_CREDENTIALS, "Expected SEC_E_NO_CREDENTIALS, got %08x\n", st); /* Crashes */ - st = pAcquireCredentialsHandleA(NULL, unisp_name_a, SECPKG_CRED_OUTBOUND, + pAcquireCredentialsHandleA(NULL, unisp_name_a, SECPKG_CRED_OUTBOUND, NULL, NULL, NULL, NULL, NULL, NULL); } st = pAcquireCredentialsHandleA(NULL, unisp_name_a, SECPKG_CRED_OUTBOUND, @@ -299,7 +299,7 @@ static void testAcquireSecurityContext(void) { /* Crashes with bad paCred pointer */ schanCred.cCreds = 1; - st = pAcquireCredentialsHandleA(NULL, unisp_name_a, SECPKG_CRED_OUTBOUND, + pAcquireCredentialsHandleA(NULL, unisp_name_a, SECPKG_CRED_OUTBOUND, NULL, &schanCred, NULL, NULL, NULL, NULL); } @@ -343,6 +343,7 @@ static void testAcquireSecurityContext(void) ret = pCertSetCertificateContextProperty(certs[1], CERT_KEY_PROV_INFO_PROP_ID, 0, &keyProvInfo); schanCred.dwVersion = SCH_CRED_V3; + ok(ret, "CertSetCertificateContextProperty failed: %08x\n", GetLastError()); st = pAcquireCredentialsHandleA(NULL, unisp_name_a, SECPKG_CRED_OUTBOUND, NULL, &schanCred, NULL, NULL, &cred, NULL); ok(st == SEC_E_UNKNOWN_CREDENTIALS || st == SEC_E_INTERNAL_ERROR /* WinNT */, @@ -369,7 +370,7 @@ static void testAcquireSecurityContext(void) if (0) { /* Crashes */ - st = pAcquireCredentialsHandleA(NULL, unisp_name_a, SECPKG_CRED_INBOUND, + pAcquireCredentialsHandleA(NULL, unisp_name_a, SECPKG_CRED_INBOUND, NULL, &schanCred, NULL, NULL, NULL, NULL); /* Crashes on WinNT */

1 0

Austin English : kernel32/tests: Make sure to use return values (LLVM/Clang ).
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: 39d5a9080679ac20baad113288d221248089a789 URL: http://source.winehq.org/git/wine.git/?a=commit;h=39d5a9080679ac20baad11328… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:28:07 2011 -0800 kernel32/tests: Make sure to use return values (LLVM/Clang). --- dlls/kernel32/tests/version.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/tests/version.c b/dlls/kernel32/tests/version.c index 5151170..9f9b72e 100644 --- a/dlls/kernel32/tests/version.c +++ b/dlls/kernel32/tests/version.c @@ -52,7 +52,7 @@ static void test_GetVersionEx(void) if (0) { /* Silently crashes on XP */ - ret = GetVersionExA(NULL); + GetVersionExA(NULL); } SetLastError(0xdeadbeef); @@ -166,6 +166,7 @@ static void test_VerifyVersionInfo(void) ret = pVerifyVersionInfoA(&info, VER_MINORVERSION | VER_SERVICEPACKMAJOR | VER_SERVICEPACKMINOR, pVerSetConditionMask(pVerSetConditionMask(0, VER_MINORVERSION, VER_GREATER_EQUAL), VER_MAJORVERSION, VER_GREATER_EQUAL)); + ok(ret, "VerifyVersionInfoA failed with error %d\n", GetLastError()); info.dwOSVersionInfoSize = sizeof(OSVERSIONINFOEX); GetVersionEx((OSVERSIONINFO *)&info);

1 0

Austin English : kernel32/tests: Don't check return values inside of if(0) (LLVM/Clang).
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: e330380a6b5bb1c9829a1a17b1affb560a3e0c55 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e330380a6b5bb1c9829a1a17b… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:27:59 2011 -0800 kernel32/tests: Don't check return values inside of if(0) (LLVM/Clang). --- dlls/kernel32/tests/path.c | 23 +++++++++-------------- 1 files changed, 9 insertions(+), 14 deletions(-) diff --git a/dlls/kernel32/tests/path.c b/dlls/kernel32/tests/path.c index 1ccafb7..741f47f 100644 --- a/dlls/kernel32/tests/path.c +++ b/dlls/kernel32/tests/path.c @@ -486,10 +486,7 @@ static void test_CurrentDirectoryA(CHAR *origdir, CHAR *newdir) */ if (0) { - SetLastError( 0xdeadbeef ); - len = GetCurrentDirectoryA( 42, (LPSTR)(MAX_PATH + 42) ); - ok( len == 0 && GetLastError() == ERROR_INVALID_PARAMETER, - "GetCurrentDirectoryA failed to fail %u err %u\n", len, GetLastError() ); + GetCurrentDirectoryA( 42, (LPSTR)(MAX_PATH + 42) ); } /* SetCurrentDirectoryA shouldn't care whether the string has a @@ -1241,7 +1238,7 @@ static void test_GetLongPathNameW(void) /* NULL buffer with length crashes on Windows */ if (0) - length = pGetLongPathNameW(shortpath, NULL, 20); + pGetLongPathNameW(shortpath, NULL, 20); ok(DeleteFileW(shortpath), "Could not delete temporary file\n"); ok(RemoveDirectoryW(dirpath), "Could not delete temporary directory\n"); @@ -1302,7 +1299,8 @@ static void test_GetSystemDirectory(void) total = res; /* this crashes on XP */ - if (0) res = GetSystemDirectory(NULL, total); + if (0) + GetSystemDirectory(NULL, total); SetLastError(0xdeadbeef); res = GetSystemDirectory(NULL, total-1); @@ -1360,7 +1358,8 @@ static void test_GetWindowsDirectory(void) total = res; /* this crashes on XP */ - if (0) res = GetWindowsDirectory(NULL, total); + if (0) + GetWindowsDirectory(NULL, total); SetLastError(0xdeadbeef); res = GetWindowsDirectory(NULL, total-1); @@ -1415,7 +1414,7 @@ static void test_NeedCurrentDirectoryForExePathA(void) /* Crashes in Windows */ if (0) - ok(pNeedCurrentDirectoryForExePathA(NULL), "returned FALSE for NULL\n"); + pNeedCurrentDirectoryForExePathA(NULL); SetEnvironmentVariableA("NoDefaultCurrentDirectoryInExePath", NULL); ok(pNeedCurrentDirectoryForExePathA("."), "returned FALSE for \".\"\n"); @@ -1442,7 +1441,7 @@ static void test_NeedCurrentDirectoryForExePathW(void) /* Crashes in Windows */ if (0) - ok(pNeedCurrentDirectoryForExePathW(NULL), "returned FALSE for NULL\n"); + pNeedCurrentDirectoryForExePathW(NULL); SetEnvironmentVariableA("NoDefaultCurrentDirectoryInExePath", NULL); ok(pNeedCurrentDirectoryForExePathW(thispath), "returned FALSE for \".\"\n"); @@ -1595,11 +1594,7 @@ static void test_SearchPathW(void) if (0) { /* NULL filename, crashes on nt4 */ - SetLastError(0xdeadbeef); - ret = pSearchPathW(pathW, NULL, NULL, sizeof(buffW)/sizeof(WCHAR), buffW, &ptrW); - ok(ret == 0, "Expected failure, got %d\n", ret); - ok(GetLastError() == ERROR_INVALID_PARAMETER, - "Expected ERROR_INVALID_PARAMETER, got %x\n", GetLastError()); + pSearchPathW(pathW, NULL, NULL, sizeof(buffW)/sizeof(WCHAR), buffW, &ptrW); } /* empty filename */

1 0

Austin English : kernel32/tests: Don't check return values inside of if(0) (LLVM/Clang).
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: 8b7904d78d52e8c3367de2eeba985c7ca13ca24d URL: http://source.winehq.org/git/wine.git/?a=commit;h=8b7904d78d52e8c3367de2eeb… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:27:56 2011 -0800 kernel32/tests: Don't check return values inside of if(0) (LLVM/Clang). --- dlls/kernel32/tests/heap.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/heap.c b/dlls/kernel32/tests/heap.c index 98c99d7..f7ac478 100644 --- a/dlls/kernel32/tests/heap.c +++ b/dlls/kernel32/tests/heap.c @@ -469,11 +469,11 @@ static void test_HeapQueryInformation(void) if (0) /* crashes under XP */ { size = 0; - ret = pHeapQueryInformation(0, + pHeapQueryInformation(0, HeapCompatibilityInformation, &info, sizeof(info), &size); size = 0; - ret = pHeapQueryInformation(GetProcessHeap(), + pHeapQueryInformation(GetProcessHeap(), HeapCompatibilityInformation, NULL, sizeof(info), &size); }

1 0

Austin English : msi/tests: Make sure to use a return value (LLVM/Clang).
by Alexandre Julliard 11 Feb '11

11 Feb '11

Module: wine Branch: master Commit: 27dd864f6326e642ae36c266e3b093eb2d68c9d0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=27dd864f6326e642ae36c266e… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Feb 10 13:27:44 2011 -0800 msi/tests: Make sure to use a return value (LLVM/Clang). --- dlls/msi/tests/db.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/msi/tests/db.c b/dlls/msi/tests/db.c index 21eb2a1..de2b9f5 100644 --- a/dlls/msi/tests/db.c +++ b/dlls/msi/tests/db.c @@ -8702,6 +8702,7 @@ static void test_columnorder(void) query = "SELECT * FROM `T`"; r = do_query(hdb, query, &rec); + ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); sz = MAX_PATH; lstrcpyA(buf, "kiwi");

1 0

← Newer
1
...
38
39
40
41
42
43
44
...
68
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2011