wine-commits February 2011

wine-commits@winehq.org

2 participants
674 discussions

Austin English : winhttp/tests: Make sure a return value is used (LLVM/ Clang).
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: 3455c78042f2dc705233d3a6bbe6e541250ba7d9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3455c78042f2dc705233d3a6b… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:05:28 2011 -0800 winhttp/tests: Make sure a return value is used (LLVM/Clang). --- dlls/winhttp/tests/winhttp.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/winhttp/tests/winhttp.c b/dlls/winhttp/tests/winhttp.c index 37d71b8..def1367 100644 --- a/dlls/winhttp/tests/winhttp.c +++ b/dlls/winhttp/tests/winhttp.c @@ -871,6 +871,7 @@ static void test_secure_connection(void) { size = 0; ret = WinHttpReadData(req, buffer, sizeof(buffer), &size); + ok(ret == TRUE, "WinHttpReadData failed: %u.\n", GetLastError()); if (!size) break; }

1 0

Austin English : secur32/tests: Make sure a return value is used (LLVM/ Clang).
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: 22c1843e08dda30a4b4bad31cb2c9bf6f2ee03b5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=22c1843e08dda30a4b4bad31c… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:04:23 2011 -0800 secur32/tests: Make sure a return value is used (LLVM/Clang). --- dlls/secur32/tests/ntlm.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/secur32/tests/ntlm.c b/dlls/secur32/tests/ntlm.c index 027e094..ddc9462 100644 --- a/dlls/secur32/tests/ntlm.c +++ b/dlls/secur32/tests/ntlm.c @@ -968,6 +968,7 @@ static void testSignSeal(void) } sec_status = setupFakeServer(&server, sec_pkg_name); + ok(sec_status == SEC_E_OK, "setupFakeServer returned %s\n", getSecError(sec_status)); while(client_stat == SEC_I_CONTINUE_NEEDED && server_stat == SEC_I_CONTINUE_NEEDED) {

1 0

Austin English : shell32/tests: Don't check return values inside of if(0) ( LLVM/Clang).
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: fe067c53ddb956874b14cdfad1c293c32a7f24f8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fe067c53ddb956874b14cdfad… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:04:30 2011 -0800 shell32/tests: Don't check return values inside of if(0) (LLVM/Clang). --- dlls/shell32/tests/ebrowser.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/shell32/tests/ebrowser.c b/dlls/shell32/tests/ebrowser.c index a8da1cc..db302ad 100644 --- a/dlls/shell32/tests/ebrowser.c +++ b/dlls/shell32/tests/ebrowser.c @@ -749,8 +749,8 @@ static void test_initialization(void) if(0) { /* Crashes on Windows 7 */ - hr = IExplorerBrowser_Initialize(peb, NULL, NULL, NULL); - hr = IExplorerBrowser_Initialize(peb, hwnd, NULL, NULL); + IExplorerBrowser_Initialize(peb, NULL, NULL, NULL); + IExplorerBrowser_Initialize(peb, hwnd, NULL, NULL); } ZeroMemory(&rc, sizeof(RECT)); @@ -1227,7 +1227,7 @@ static void test_Advise(void) { /* Using unadvise with a previously unadvised cookie results * in a crash. */ - hr = IExplorerBrowser_Unadvise(peb, cookies[5]); + IExplorerBrowser_Unadvise(peb, cookies[5]); } /* Remove the rest. */ @@ -1566,7 +1566,7 @@ static void test_GetCurrentView(void) if(0) { /* Crashes under Windows 7 */ - hr = IExplorerBrowser_GetCurrentView(peb, NULL, NULL); + IExplorerBrowser_GetCurrentView(peb, NULL, NULL); } hr = IExplorerBrowser_GetCurrentView(peb, NULL, (void**)&punk); ok(hr == E_FAIL, "Got 0x%08x\n", hr);

1 0

Austin English : gdiplus/tests: Make sure to use return values (LLVM/Clang) .
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: 1a24d1c0f1cb22c076ee412c50f621de150ee910 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1a24d1c0f1cb22c076ee412c5… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:06:06 2011 -0800 gdiplus/tests: Make sure to use return values (LLVM/Clang). --- dlls/gdiplus/tests/brush.c | 14 ++++++++++++++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/tests/brush.c b/dlls/gdiplus/tests/brush.c index 655d80c..5eed607 100644 --- a/dlls/gdiplus/tests/brush.c +++ b/dlls/gdiplus/tests/brush.c @@ -311,6 +311,7 @@ static void test_gradientgetrect(void) if (status == Ok) { status = GdipGetMatrixElements(transform, elements); + expect(Ok, status); expectf(1.0, elements[0]); expectf(1.0, elements[1]); expectf(-1.0, elements[2]); @@ -319,6 +320,7 @@ static void test_gradientgetrect(void) expectf(-50.50, elements[5]); } status = GdipDeleteBrush((GpBrush*)brush); + expect(Ok, status); /* vertical gradient */ pt1.X = pt1.Y = pt2.X = 0.0; pt2.Y = 10.0; @@ -336,6 +338,7 @@ static void test_gradientgetrect(void) if (status == Ok) { status = GdipGetMatrixElements(transform, elements); + expect(Ok, status); expectf(0.0, elements[0]); expectf(1.0, elements[1]); expectf(-1.0, elements[2]); @@ -344,6 +347,7 @@ static void test_gradientgetrect(void) expectf(5.0, elements[5]); } status = GdipDeleteBrush((GpBrush*)brush); + expect(Ok, status); /* horizontal gradient */ pt1.X = pt1.Y = pt2.Y = 0.0; pt2.X = 10.0; @@ -361,6 +365,7 @@ static void test_gradientgetrect(void) if (status == Ok) { status = GdipGetMatrixElements(transform, elements); + expect(Ok, status); expectf(1.0, elements[0]); expectf(0.0, elements[1]); expectf(0.0, elements[2]); @@ -369,6 +374,7 @@ static void test_gradientgetrect(void) expectf(0.0, elements[5]); } status = GdipDeleteBrush((GpBrush*)brush); + expect(Ok, status); /* slope = -1 */ pt1.X = pt1.Y = 0.0; pt2.X = 20.0; @@ -387,6 +393,7 @@ static void test_gradientgetrect(void) if (status == Ok) { status = GdipGetMatrixElements(transform, elements); + expect(Ok, status); expectf(1.0, elements[0]); expectf(-1.0, elements[1]); expectf(1.0, elements[2]); @@ -395,6 +402,7 @@ static void test_gradientgetrect(void) expectf(10.0, elements[5]); } status = GdipDeleteBrush((GpBrush*)brush); + expect(Ok, status); /* slope = 1/100 */ pt1.X = pt1.Y = 0.0; pt2.X = 100.0; @@ -413,6 +421,7 @@ static void test_gradientgetrect(void) if (status == Ok) { status = GdipGetMatrixElements(transform, elements); + expect(Ok,status); expectf(1.0, elements[0]); expectf(0.01, elements[1]); expectf(-0.02, elements[2]); @@ -421,6 +430,7 @@ static void test_gradientgetrect(void) /* expectf(-1.0, elements[5]); */ } status = GdipDeleteBrush((GpBrush*)brush); + expect(Ok,status); /* zero height rect */ rectf.X = rectf.Y = 10.0; rectf.Width = 100.0; @@ -453,6 +463,7 @@ static void test_gradientgetrect(void) if (status == Ok) { status = GdipGetMatrixElements(transform, elements); + expect(Ok,status); expectf(1.0, elements[0]); expectf(0.0, elements[1]); expectf(0.0, elements[2]); @@ -461,6 +472,7 @@ static void test_gradientgetrect(void) expectf(0.0, elements[5]); } status = GdipDeleteBrush((GpBrush*)brush); + expect(Ok,status); /* passing negative Width/Height to LinearGradientModeHorizontal */ rectf.X = rectf.Y = 10.0; rectf.Width = rectf.Height = -100.0; @@ -479,6 +491,7 @@ static void test_gradientgetrect(void) if (status == Ok) { status = GdipGetMatrixElements(transform, elements); + expect(Ok,status); expectf(1.0, elements[0]); expectf(0.0, elements[1]); expectf(0.0, elements[2]); @@ -487,6 +500,7 @@ static void test_gradientgetrect(void) expectf(0.0, elements[5]); } status = GdipDeleteBrush((GpBrush*)brush); + expect(Ok,status); GdipDeleteMatrix(transform); }

1 0

Austin English : crypt32/tests: Make sure to use return values (LLVM/Clang) .
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: e48b34cdb3aadaaea3760857807cabab8c519c91 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e48b34cdb3aadaaea37608578… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:05:55 2011 -0800 crypt32/tests: Make sure to use return values (LLVM/Clang). --- dlls/crypt32/tests/chain.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/crypt32/tests/chain.c b/dlls/crypt32/tests/chain.c index d11dece..eeb322d 100644 --- a/dlls/crypt32/tests/chain.c +++ b/dlls/crypt32/tests/chain.c @@ -3857,9 +3857,11 @@ static void test_CERT_CHAIN_PARA_cbSize(void) ret = CertAddEncodedCertificateToStore(store, X509_ASN_ENCODING, chain0_0, sizeof(chain0_0), CERT_STORE_ADD_ALWAYS, NULL); + ok(ret, "CertAddEncodedCertificateToStore failed: %08x\n", GetLastError()); ret = CertAddEncodedCertificateToStore(store, X509_ASN_ENCODING, chain0_1, sizeof(chain0_1), CERT_STORE_ADD_ALWAYS, &cert); + ok(ret, "CertAddEncodedCertificateToStore failed: %08x\n", GetLastError()); for (i = 0; i < sizeof(CERT_CHAIN_PARA) + 2; i++) {

1 0

Austin English : advapi32/tests: Remove useless assignments (LLVM/Clang).
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: a19ce2080e1fc19c1db6c4543a9c1003a9a2ef1e URL: http://source.winehq.org/git/wine.git/?a=commit;h=a19ce2080e1fc19c1db6c4543… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:05:49 2011 -0800 advapi32/tests: Remove useless assignments (LLVM/Clang). --- dlls/advapi32/tests/security.c | 19 ++++++++++--------- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index 5db4354..e1f06c8 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -1533,7 +1533,7 @@ static void test_LookupAccountSid(void) acc_sizeA = 0; dom_sizeA = MAX_PATH; accountA[0] = 0; - ret = LookupAccountSidA(NULL, pUsersSid, accountA, &acc_sizeA, domainA, &dom_sizeA, &use); + LookupAccountSidA(NULL, pUsersSid, accountA, &acc_sizeA, domainA, &dom_sizeA, &use); /* this can fail or succeed depending on OS version but the size will always be returned */ ok(acc_sizeA == real_acc_sizeA + 1, "LookupAccountSidA() Expected acc_size = %u, got %u\n", @@ -1542,7 +1542,7 @@ static void test_LookupAccountSid(void) /* try a 0 sized account buffer */ acc_sizeA = 0; dom_sizeA = MAX_PATH; - ret = LookupAccountSidA(NULL, pUsersSid, NULL, &acc_sizeA, domainA, &dom_sizeA, &use); + LookupAccountSidA(NULL, pUsersSid, NULL, &acc_sizeA, domainA, &dom_sizeA, &use); /* this can fail or succeed depending on OS version but the size will always be returned */ ok(acc_sizeA == real_acc_sizeA + 1, "LookupAccountSid() Expected acc_size = %u, got %u\n", @@ -1561,7 +1561,7 @@ static void test_LookupAccountSid(void) dom_sizeA = 0; acc_sizeA = MAX_PATH; accountA[0] = 0; - ret = LookupAccountSidA(NULL, pUsersSid, accountA, &acc_sizeA, domainA, &dom_sizeA, &use); + LookupAccountSidA(NULL, pUsersSid, accountA, &acc_sizeA, domainA, &dom_sizeA, &use); /* this can fail or succeed depending on OS version but the size will always be returned */ ok(dom_sizeA == real_dom_sizeA + 1, "LookupAccountSidA() Expected dom_size = %u, got %u\n", @@ -1570,7 +1570,7 @@ static void test_LookupAccountSid(void) /* try a 0 sized domain buffer */ dom_sizeA = 0; acc_sizeA = MAX_PATH; - ret = LookupAccountSidA(NULL, pUsersSid, accountA, &acc_sizeA, NULL, &dom_sizeA, &use); + LookupAccountSidA(NULL, pUsersSid, accountA, &acc_sizeA, NULL, &dom_sizeA, &use); /* this can fail or succeed depending on OS version but the size will always be returned */ ok(dom_sizeA == real_dom_sizeA + 1, "LookupAccountSidA() Expected dom_size = %u, got %u\n", @@ -1604,7 +1604,7 @@ static void test_LookupAccountSid(void) acc_sizeW = 0; dom_sizeW = MAX_PATH; accountW[0] = 0; - ret = LookupAccountSidW(NULL, pUsersSid, accountW, &acc_sizeW, domainW, &dom_sizeW, &use); + LookupAccountSidW(NULL, pUsersSid, accountW, &acc_sizeW, domainW, &dom_sizeW, &use); /* this can fail or succeed depending on OS version but the size will always be returned */ ok(acc_sizeW == real_acc_sizeW + 1, "LookupAccountSidW() Expected acc_size = %u, got %u\n", @@ -1613,7 +1613,7 @@ static void test_LookupAccountSid(void) /* try a 0 sized account buffer */ acc_sizeW = 0; dom_sizeW = MAX_PATH; - ret = LookupAccountSidW(NULL, pUsersSid, NULL, &acc_sizeW, domainW, &dom_sizeW, &use); + LookupAccountSidW(NULL, pUsersSid, NULL, &acc_sizeW, domainW, &dom_sizeW, &use); /* this can fail or succeed depending on OS version but the size will always be returned */ ok(acc_sizeW == real_acc_sizeW + 1, "LookupAccountSidW() Expected acc_size = %u, got %u\n", @@ -1632,7 +1632,7 @@ static void test_LookupAccountSid(void) dom_sizeW = 0; acc_sizeW = MAX_PATH; accountW[0] = 0; - ret = LookupAccountSidW(NULL, pUsersSid, accountW, &acc_sizeW, domainW, &dom_sizeW, &use); + LookupAccountSidW(NULL, pUsersSid, accountW, &acc_sizeW, domainW, &dom_sizeW, &use); /* this can fail or succeed depending on OS version but the size will always be returned */ ok(dom_sizeW == real_dom_sizeW + 1, "LookupAccountSidW() Expected dom_size = %u, got %u\n", @@ -1641,7 +1641,7 @@ static void test_LookupAccountSid(void) /* try a 0 sized domain buffer */ dom_sizeW = 0; acc_sizeW = MAX_PATH; - ret = LookupAccountSidW(NULL, pUsersSid, accountW, &acc_sizeW, NULL, &dom_sizeW, &use); + LookupAccountSidW(NULL, pUsersSid, accountW, &acc_sizeW, NULL, &dom_sizeW, &use); /* this can fail or succeed depending on OS version but the size will always be returned */ ok(dom_sizeW == real_dom_sizeW + 1, "LookupAccountSidW() Expected dom_size = %u, got %u\n", @@ -1662,7 +1662,9 @@ static void test_LookupAccountSid(void) /* Test LookupAccountSid with Sid retrieved from token information. This assumes this process is running under the account of the current user.*/ ret = OpenProcessToken(GetCurrentProcess(), TOKEN_QUERY|TOKEN_DUPLICATE, &hToken); + ok(ret, "OpenProcessToken failed with error %d\n", GetLastError()); ret = GetTokenInformation(hToken, TokenUser, NULL, 0, &cbti); + ok(!ret, "GetTokenInformation failed with error %d\n", GetLastError()); ptiUser = HeapAlloc(GetProcessHeap(), 0, cbti); if (GetTokenInformation(hToken, TokenUser, ptiUser, cbti, &cbti)) { @@ -3089,7 +3091,6 @@ static void test_SetSecurityDescriptorControl (PSECURITY_DESCRIPTOR sec) GetSecurityDescriptorControl(sec, &test, &dwRevision); expect_eq(test, ctrl, int, "%x"); - ctrl = ref; setOrClear ^= bitOfInterest; SetLastError (0xbebecaca); pSetSecurityDescriptorControl (sec, bitOfInterest, setOrClear);

1 0

Austin English : kernel32/tests: Make sure to use return values (LLVM/Clang ).
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: 4e3c3ad593173ba0c2659c15f5bdc06479479c79 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4e3c3ad593173ba0c2659c15f… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:06:09 2011 -0800 kernel32/tests: Make sure to use return values (LLVM/Clang). --- dlls/kernel32/tests/directory.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/kernel32/tests/directory.c b/dlls/kernel32/tests/directory.c index 8d1c457..9baae47 100644 --- a/dlls/kernel32/tests/directory.c +++ b/dlls/kernel32/tests/directory.c @@ -393,6 +393,7 @@ static void test_CreateDirectoryW(void) "CreateDirectoryW with ? wildcard name should fail with error 183, ret=%s error=%d\n", ret ? " True" : "False", GetLastError()); ret = RemoveDirectoryW(tmpdir); + ok(ret == FALSE, "RemoveDirectoryW should have failed\n"); tmpdir[lstrlenW(tmpdir) - 1] = '*'; ret = CreateDirectoryW(tmpdir, NULL); @@ -400,6 +401,7 @@ static void test_CreateDirectoryW(void) "CreateDirectoryW with * wildcard name should fail with error 183, ret=%s error=%d\n", ret ? " True" : "False", GetLastError()); ret = RemoveDirectoryW(tmpdir); + ok(ret == FALSE, "RemoveDirectoryW should have failed\n"); GetTempPathW(MAX_PATH, tmpdir); lstrcatW(tmpdir, tmp_dir_name); @@ -410,6 +412,7 @@ static void test_CreateDirectoryW(void) "CreateDirectoryW with multiple nonexistent directories in path should fail ret %u err %u\n", ret, GetLastError()); ret = RemoveDirectoryW(tmpdir); + ok(ret == FALSE, "RemoveDirectoryW should have failed\n"); } static void test_RemoveDirectoryA(void)

1 0

Austin English : windowscodecs/tests: Make sure returns values are used ( LLVM/Clang).
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: 4c6edd7fe04fb77952f4b1efd657779caf21213c URL: http://source.winehq.org/git/wine.git/?a=commit;h=4c6edd7fe04fb77952f4b1efd… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:05:24 2011 -0800 windowscodecs/tests: Make sure returns values are used (LLVM/Clang). --- dlls/windowscodecs/tests/stream.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/dlls/windowscodecs/tests/stream.c b/dlls/windowscodecs/tests/stream.c index a55b898..5730995 100644 --- a/dlls/windowscodecs/tests/stream.c +++ b/dlls/windowscodecs/tests/stream.c @@ -114,6 +114,7 @@ static void test_StreamOnMemory(void) ok(hr == HRESULT_FROM_WIN32(ERROR_ARITHMETIC_OVERFLOW), "Seek returned with %#x, expected %#x\n", hr, HRESULT_FROM_WIN32(ERROR_ARITHMETIC_OVERFLOW)); ok(uNewPos.u.HighPart == 0xdeadbeef && uNewPos.u.LowPart == 0xdeadbeef, "Seek cursor initialized to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0xdeadbeef, 0xdeadbeef); hr = IWICStream_Seek(pStream, LargeNull, STREAM_SEEK_CUR, &uNewPos); + ok(hr == S_OK, "Seek returned with %#x, expected %#x\n", hr, S_OK); ok(uNewPos.u.HighPart == 0 && uNewPos.u.LowPart == 0, "Seek cursor moved to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0, 0); LargeInt.QuadPart = sizeof(Memory) + 10; @@ -123,6 +124,7 @@ static void test_StreamOnMemory(void) ok(hr == E_INVALIDARG, "Seek returned with %#x, expected %#x\n", hr, E_INVALIDARG); ok(uNewPos.u.HighPart == 0xdeadbeef && uNewPos.u.LowPart == 0xdeadbeef, "Seek cursor initialized to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0xdeadbeef, 0xdeadbeef); hr = IWICStream_Seek(pStream, LargeNull, STREAM_SEEK_CUR, &uNewPos); + ok(hr == S_OK, "Seek returned with %#x, expected %#x\n", hr, S_OK); ok(uNewPos.u.HighPart == 0 && uNewPos.u.LowPart == 0, "Seek cursor moved to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0, 0); LargeInt.QuadPart = 1; @@ -132,6 +134,7 @@ static void test_StreamOnMemory(void) ok(hr == E_INVALIDARG, "Seek returned with %#x, expected %#x\n", hr, E_INVALIDARG); ok(uNewPos.u.HighPart == 0xdeadbeef && uNewPos.u.LowPart == 0xdeadbeef, "Seek cursor initialized to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0xdeadbeef, 0xdeadbeef); hr = IWICStream_Seek(pStream, LargeNull, STREAM_SEEK_CUR, &uNewPos); + ok(hr == S_OK, "Seek returned with %#x, expected %#x\n", hr, S_OK); ok(uNewPos.u.HighPart == 0 && uNewPos.u.LowPart == 0, "Seek cursor moved to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0, 0); LargeInt.QuadPart = -1; @@ -148,6 +151,7 @@ static void test_StreamOnMemory(void) "Seek returned with %#x, expected %#x\n", hr, HRESULT_FROM_WIN32(ERROR_ARITHMETIC_OVERFLOW)); ok(uNewPos.u.HighPart == 0xdeadbeef && uNewPos.u.LowPart == 0xdeadbeef, "Seek cursor initialized to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0xdeadbeef, 0xdeadbeef); hr = IWICStream_Seek(pStream, LargeNull, STREAM_SEEK_CUR, &uNewPos); + ok(hr == S_OK, "Seek returned with %#x, expected %#x\n", hr, S_OK); ok(uNewPos.u.HighPart == 0 && uNewPos.u.LowPart == 0, "Seek cursor moved to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0, 0); /* remains unchanged */ IWICStream_Seek(pStream, LargeNull, STREAM_SEEK_SET, NULL); @@ -456,6 +460,7 @@ static void test_StreamOnStreamRange(void) ok(hr == WINCODEC_ERR_VALUEOUTOFRANGE, "Seek returned with %#x, expected %#x\n", hr, WINCODEC_ERR_VALUEOUTOFRANGE); ok(uNewPos.u.HighPart == 0xdeadbeef && uNewPos.u.LowPart == 0xdeadbeef, "Seek cursor initialized to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0xdeadbeef, 0xdeadbeef); hr = IWICStream_Seek(pStream, LargeNull, STREAM_SEEK_CUR, &uNewPos); + ok(hr == S_OK, "Seek returned with %#x, expected %#x\n", hr, S_OK); ok(uNewPos.u.HighPart == 0 && uNewPos.u.LowPart == 0, "Seek cursor moved to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0, 0); LargeInt.QuadPart = 30; @@ -465,6 +470,7 @@ static void test_StreamOnStreamRange(void) ok(hr == WINCODEC_ERR_VALUEOUTOFRANGE, "Seek returned with %#x, expected %#x\n", hr, WINCODEC_ERR_VALUEOUTOFRANGE); ok(uNewPos.u.HighPart == 0xdeadbeef && uNewPos.u.LowPart == 0xdeadbeef, "Seek cursor initialized to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0xdeadbeef, 0xdeadbeef); hr = IWICStream_Seek(pStream, LargeNull, STREAM_SEEK_CUR, &uNewPos); + ok(hr == S_OK, "Seek returned with %#x, expected %#x\n", hr, S_OK); ok(uNewPos.u.HighPart == 0 && uNewPos.u.LowPart == 0, "Seek cursor moved to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0, 0); LargeInt.QuadPart = 1; @@ -474,6 +480,7 @@ static void test_StreamOnStreamRange(void) ok(hr == WINCODEC_ERR_VALUEOUTOFRANGE, "Seek returned with %#x, expected %#x\n", hr, WINCODEC_ERR_VALUEOUTOFRANGE); ok(uNewPos.u.HighPart == 0xdeadbeef && uNewPos.u.LowPart == 0xdeadbeef, "Seek cursor initialized to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0xdeadbeef, 0xdeadbeef); hr = IWICStream_Seek(pStream, LargeNull, STREAM_SEEK_CUR, &uNewPos); + ok(hr == S_OK, "Seek returned with %#x, expected %#x\n", hr, S_OK); ok(uNewPos.u.HighPart == 0 && uNewPos.u.LowPart == 0, "Seek cursor moved to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0, 0); LargeInt.QuadPart = -1; @@ -490,6 +497,7 @@ static void test_StreamOnStreamRange(void) "Seek returned with %#x, expected %#x\n", hr, HRESULT_FROM_WIN32(ERROR_ARITHMETIC_OVERFLOW)); ok(uNewPos.u.HighPart == 0xdeadbeef && uNewPos.u.LowPart == 0xdeadbeef, "Seek cursor initialized to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0xdeadbeef, 0xdeadbeef); hr = IWICStream_Seek(pStream, LargeNull, STREAM_SEEK_CUR, &uNewPos); + ok(hr == S_OK, "Seek returned with %#x, expected %#x\n", hr, S_OK); ok(uNewPos.u.HighPart == 0 && uNewPos.u.LowPart == 0, "Seek cursor moved to position (%u;%u), expected (%u;%u)\n", uNewPos.u.HighPart, uNewPos.u.LowPart, 0, 0); /* remains unchanged */ IWICStream_Seek(pSubStream, LargeNull, STREAM_SEEK_SET, NULL);

1 0

Austin English : xmllite/tests: Don't check test results inside if(0) (LLVM /Clang).
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: ea0e7d6421c8bdecdf5f6601fde0b8cbcdc47b1f URL: http://source.winehq.org/git/wine.git/?a=commit;h=ea0e7d6421c8bdecdf5f6601f… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:05:34 2011 -0800 xmllite/tests: Don't check test results inside if(0) (LLVM/Clang). --- dlls/xmllite/tests/reader.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index bd6ac1a..de25d7e 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -354,8 +354,8 @@ static void test_reader_create(void) /* crashes native */ if (0) { - hr = pCreateXmlReader(&IID_IXmlReader, NULL, NULL); - hr = pCreateXmlReader(NULL, (LPVOID*)&reader, NULL); + pCreateXmlReader(&IID_IXmlReader, NULL, NULL); + pCreateXmlReader(NULL, (LPVOID*)&reader, NULL); } hr = pCreateXmlReader(&IID_IXmlReader, (LPVOID*)&reader, NULL);

1 0

Austin English : ws2_32/tests: Remove unneeded assignments (LLVM/Clang).
by Alexandre Julliard 09 Feb '11

09 Feb '11

Module: wine Branch: master Commit: 99012fe7932f56bc3247e8d68e6d9a3e709b739e URL: http://source.winehq.org/git/wine.git/?a=commit;h=99012fe7932f56bc3247e8d68… Author: Austin English <austinenglish(a)gmail.com> Date: Tue Feb 8 16:05:31 2011 -0800 ws2_32/tests: Remove unneeded assignments (LLVM/Clang). --- dlls/ws2_32/tests/sock.c | 14 +++----------- 1 files changed, 3 insertions(+), 11 deletions(-) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index 2a8c1d2..de647f1 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -734,7 +734,7 @@ static void WINAPI event_client ( client_params *par ) tmp = WaitForSingleObject ( event, INFINITE ); ok ( tmp == WAIT_OBJECT_0, "event_client (%x): wait for connect event failed: %d\n", id, tmp ); err = WSAEnumNetworkEvents ( mem->s, event, &wsa_events ); - wsa_ok ( err, 0 ==, "event_client (%x): WSAEnumNetworkEvents error: %d\n" ); + ok ( err == 0, "event_client (%x): WSAEnumNetworkEvents error: %d\n", id, err ); err = wsa_events.iErrorCode[ FD_CONNECT_BIT ]; ok ( err == 0, "event_client (%x): connect error: %d\n", id, err ); if ( err ) goto out; @@ -755,7 +755,7 @@ static void WINAPI event_client ( client_params *par ) ok ( err == WAIT_OBJECT_0, "event_client (%x): wait failed\n", id ); err = WSAEnumNetworkEvents ( mem->s, event, &wsa_events ); - wsa_ok ( err, 0 ==, "event_client (%x): WSAEnumNetworkEvents error: %d\n" ); + ok( err == 0, "event_client (%x): WSAEnumNetworkEvents error: %d\n", id, err ); if ( wsa_events.lNetworkEvents & FD_WRITE ) { @@ -2580,8 +2580,7 @@ static void test_gethostbyname_hack(void) } } - he = NULL; - he = gethostbyname("nonexistent.winehq.org"); + gethostbyname("nonexistent.winehq.org"); /* Don't check for the return value, as some braindead ISPs will kindly * resolve nonexistent host names to addresses of the ISP's spam pages. */ } @@ -3977,7 +3976,6 @@ static void test_ConnectEx(void) acceptor = accept(listener, NULL, NULL); if (acceptor != INVALID_SOCKET) { closesocket(acceptor); - acceptor = INVALID_SOCKET; } buffer[0] = '1'; @@ -4238,7 +4236,6 @@ static void test_AcceptEx(void) closesocket(connector); connector = INVALID_SOCKET; closesocket(acceptor); - acceptor = INVALID_SOCKET; /* Test short reads */ @@ -4276,7 +4273,6 @@ static void test_AcceptEx(void) closesocket(connector); connector = INVALID_SOCKET; closesocket(acceptor); - acceptor = INVALID_SOCKET; /* Test CF_DEFER & AcceptEx interaction */ @@ -4387,7 +4383,6 @@ static void test_AcceptEx(void) closesocket(connector); connector = INVALID_SOCKET; closesocket(acceptor); - acceptor = INVALID_SOCKET; /* clean up in case of failures */ while ((acceptor = accept(listener, NULL, NULL)) != INVALID_SOCKET) @@ -4424,7 +4419,6 @@ static void test_AcceptEx(void) ok(bytesReturned == 0, "bytesReturned isn't supposed to be %d\n", bytesReturned); closesocket(acceptor); - acceptor = INVALID_SOCKET; /* Test closing with pending requests */ @@ -4439,7 +4433,6 @@ static void test_AcceptEx(void) ok(bret == FALSE && WSAGetLastError() == ERROR_IO_PENDING, "AcceptEx returned %d + errno %d\n", bret, WSAGetLastError()); closesocket(acceptor); - acceptor = INVALID_SOCKET; dwret = WaitForSingleObject(overlapped.hEvent, 1000); todo_wine ok(dwret == WAIT_OBJECT_0 || broken(dwret == WAIT_TIMEOUT) /* NT4/2000 */, @@ -4472,7 +4465,6 @@ static void test_AcceptEx(void) ok(dwret == WAIT_TIMEOUT, "Waiting for timeout failed with %d + errno %d\n", dwret, GetLastError()); closesocket(acceptor); - acceptor = INVALID_SOCKET; acceptor = socket(AF_INET, SOCK_STREAM, 0); if (acceptor == INVALID_SOCKET) {

1 0

← Newer
1
...
44
45
46
47
48
49
50
...
68
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2011