wine-commits February 2011

wine-commits@winehq.org

2 participants
674 discussions

Kusanagi Kouichi : gdi32: Upper 24 bits of a character range must be same.
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: 2d6b748c79f51b473973ed71fe2b867ba07a6c70 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d6b748c79f51b473973ed71f… Author: Kusanagi Kouichi <slash(a)ac.auone-net.jp> Date: Wed Feb 2 01:37:09 2011 +0900 gdi32: Upper 24 bits of a character range must be same. --- dlls/gdi32/font.c | 2 + dlls/gdi32/tests/font.c | 67 +++++++++++++++++++++------------------------- 2 files changed, 33 insertions(+), 36 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 3df3d0b..6f1f867 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -1571,6 +1571,8 @@ static LPSTR FONT_GetCharsByRangeA(HDC hdc, UINT firstChar, UINT lastChar, PINT case 1361: if (lastChar > 0xffff) return NULL; + if ((firstChar ^ lastChar) > 0xff) + return NULL; break; default: if (lastChar > 0xff) diff --git a/dlls/gdi32/tests/font.c b/dlls/gdi32/tests/font.c index 538e983..01411ff 100644 --- a/dlls/gdi32/tests/font.c +++ b/dlls/gdi32/tests/font.c @@ -922,18 +922,36 @@ static void test_GetCharABCWidths(void) DWORD nb; static const struct { + UINT first; + UINT last; + } range[] = + { + {0xff, 0xff}, + {0x100, 0x100}, + {0xff, 0x100}, + {0x1ff, 0xff00}, + {0xffff, 0xffff}, + {0x10000, 0x10000}, + {0xffff, 0x10000}, + {0xffffff, 0xffffff}, + {0x1000000, 0x1000000}, + {0xffffff, 0x1000000}, + {0xffffffff, 0xffffffff} + }; + static const struct + { UINT cs; UINT a; UINT w; - BOOL r[10]; + BOOL r[sizeof range / sizeof range[0]]; } c[] = { {ANSI_CHARSET, 0x30, 0x30, {TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}}, - {SHIFTJIS_CHARSET, 0x82a0, 0x3042, {TRUE, TRUE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}}, - {HANGEUL_CHARSET, 0x8141, 0xac02, {TRUE, TRUE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}}, - {JOHAB_CHARSET, 0x8446, 0x3135, {TRUE, TRUE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}}, - {GB2312_CHARSET, 0x8141, 0x4e04, {TRUE, TRUE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}}, - {CHINESEBIG5_CHARSET, 0xa142, 0x3001, {TRUE, TRUE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}} + {SHIFTJIS_CHARSET, 0x82a0, 0x3042, {TRUE, TRUE, FALSE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}}, + {HANGEUL_CHARSET, 0x8141, 0xac02, {TRUE, TRUE, FALSE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}}, + {JOHAB_CHARSET, 0x8446, 0x3135, {TRUE, TRUE, FALSE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}}, + {GB2312_CHARSET, 0x8141, 0x4e04, {TRUE, TRUE, FALSE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}}, + {CHINESEBIG5_CHARSET, 0xa142, 0x3001, {TRUE, TRUE, FALSE, FALSE, TRUE, FALSE, FALSE, FALSE, FALSE, FALSE, FALSE}} }; UINT i; @@ -979,7 +997,7 @@ static void test_GetCharABCWidths(void) { ABC a[2], w[2]; ABC full[256]; - UINT code = 0x41; + UINT code = 0x41, j; lf.lfFaceName[0] = '\0'; lf.lfCharSet = c[i].cs; @@ -1007,35 +1025,12 @@ static void test_GetCharABCWidths(void) ok(memcmp(&a[0], &full[code], sizeof(ABC)) == 0, "GetCharABCWidthsA info should match. codepage = %u\n", c[i].cs); - ret = pGetCharABCWidthsA(hdc, 0xff, 0xff, abc); - ok(ret == c[i].r[0], "GetCharABCWidthsA should have %s\n", c[i].r[0] ? "succeeded" : "failed"); - - ret = pGetCharABCWidthsA(hdc, 0x100, 0x100, abc); - ok(ret == c[i].r[1], "GetCharABCWidthsA should have %s\n", c[i].r[1] ? "succeeded" : "failed"); - - ret = pGetCharABCWidthsA(hdc, 0xff, 0x100, a); - ok(ret == c[i].r[2], "GetCharABCWidthsA should have %s\n", c[i].r[2] ? "succeeded" : "failed"); - - ret = pGetCharABCWidthsA(hdc, 0xffff, 0xffff, abc); - ok(ret == c[i].r[3], "GetCharABCWidthsA should have %s\n", c[i].r[3] ? "succeeded" : "failed"); - - ret = pGetCharABCWidthsA(hdc, 0x10000, 0x10000, abc); - ok(ret == c[i].r[4], "GetCharABCWidthsA should have %s\n", c[i].r[4] ? "succeeded" : "failed"); - - ret = pGetCharABCWidthsA(hdc, 0xffff, 0x10000, a); - ok(ret == c[i].r[5], "GetCharABCWidthsA should have %s\n", c[i].r[5] ? "succeeded" : "failed"); - - ret = pGetCharABCWidthsA(hdc, 0xffffff, 0xffffff, abc); - ok(ret == c[i].r[6], "GetCharABCWidthsA should have %s\n", c[i].r[6] ? "succeeded" : "failed"); - - ret = pGetCharABCWidthsA(hdc, 0x1000000, 0x1000000, abc); - ok(ret == c[i].r[7], "GetCharABCWidthsA should have %s\n", c[i].r[7] ? "succeeded" : "failed"); - - ret = pGetCharABCWidthsA(hdc, 0xffffff, 0x1000000, a); - ok(ret == c[i].r[8], "GetCharABCWidthsA should have %s\n", c[i].r[8] ? "succeeded" : "failed"); - - ret = pGetCharABCWidthsA(hdc, 0xffffffff, 0xffffffff, abc); - ok(ret == c[i].r[9], "GetCharABCWidthsA should have %s\n", c[i].r[9] ? "succeeded" : "failed"); + for (j = 0; j < sizeof range / sizeof range[0]; ++j) + { + ret = pGetCharABCWidthsA(hdc, range[j].first, range[j].last, full); + ok(ret == c[i].r[j], "GetCharABCWidthsA %x - %x should have %s\n", + range[j].first, range[j].last, c[i].r[j] ? "succeeded" : "failed"); + } hfont = SelectObject(hdc, hfont); DeleteObject(hfont);

1 0

Nikolay Sivov : ntdll: Fix a compile time warning.
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: d3d06c46d2cd5dc7d214b3e7f6a978b8141c02b2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d3d06c46d2cd5dc7d214b3e7f… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sat Jan 29 00:58:18 2011 +0300 ntdll: Fix a compile time warning. --- dlls/ntdll/file.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 68bed0e..4d49956 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -1290,11 +1290,11 @@ static void ignore_server_ioctl_struct_holes (ULONG code, const void *in_buffer, #ifdef VALGRIND_MAKE_MEM_DEFINED # define IGNORE_STRUCT_HOLE(buf, size, t, f1, f2) \ do { \ - if ((size) >= FIELD_OFFSET(t, f2) && \ - FIELD_OFFSET(t, f1) + sizeof(((t *)0)->f1) < FIELD_OFFSET(t, f2)) \ - VALGRIND_MAKE_MEM_DEFINED( \ - (const char *)(buf) + FIELD_OFFSET(t, f1) + sizeof(((t *)0)->f1), \ - FIELD_OFFSET(t, f2) - FIELD_OFFSET(t, f1) + sizeof(((t *)0)->f1)); \ + if (FIELD_OFFSET(t, f1) + sizeof(((t *)0)->f1) < FIELD_OFFSET(t, f2)) \ + if ((size) >= FIELD_OFFSET(t, f2)) \ + VALGRIND_MAKE_MEM_DEFINED( \ + (const char *)(buf) + FIELD_OFFSET(t, f1) + sizeof(((t *)0)->f1), \ + FIELD_OFFSET(t, f2) - FIELD_OFFSET(t, f1) + sizeof(((t *)0)->f1)); \ } while (0) switch (code)

1 0

Paul Vriens : shdocvw: Initialize variable (Coverity).
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: b03f8771637f69f9b74aa24dd6881c2b9db20bf3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b03f8771637f69f9b74aa24dd… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Tue Feb 1 15:12:17 2011 +0100 shdocvw: Initialize variable (Coverity). --- dlls/shdocvw/iexplore.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shdocvw/iexplore.c b/dlls/shdocvw/iexplore.c index 3b652cb..f8d74ac 100644 --- a/dlls/shdocvw/iexplore.c +++ b/dlls/shdocvw/iexplore.c @@ -173,7 +173,7 @@ static void add_favs_to_menu(HMENU favmenu, HMENU menu, LPCWSTR dir) HANDLE findhandle; WIN32_FIND_DATAW finddata; IUniformResourceLocatorW* urlobj; - IPersistFile* urlfile; + IPersistFile* urlfile = NULL; HRESULT res; lstrcpyW(path, dir);

1 0

Paul Vriens : explorerframe/tests: Don' t compare potentially uninitialized variables (Coverity).
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: fd2bf1fae12f7824bd87b4b49d0f6ae1e55130c9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fd2bf1fae12f7824bd87b4b49… Author: Paul Vriens <Paul.Vriens.Wine(a)gmail.com> Date: Tue Feb 1 14:46:14 2011 +0100 explorerframe/tests: Don't compare potentially uninitialized variables (Coverity). --- dlls/explorerframe/tests/nstc.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/explorerframe/tests/nstc.c b/dlls/explorerframe/tests/nstc.c index df69a1a..047d7cd 100644 --- a/dlls/explorerframe/tests/nstc.c +++ b/dlls/explorerframe/tests/nstc.c @@ -811,7 +811,6 @@ static void test_basics(void) } ILFree(pidl_desktop); } - ok(psidesktop != psidesktop2, "psidesktop == psidesktop2\n"); IShellFolder_Release(psfdesktop); if(FAILED(hr)) @@ -820,6 +819,8 @@ static void test_basics(void) return; } + ok(psidesktop != psidesktop2, "psidesktop == psidesktop2\n"); + CreateFilesFolders(); GetCurrentDirectoryW(MAX_PATH, curdirW); ok(lstrlenW(curdirW), "Got 0 length string.\n");

1 0

Alexandre Julliard : msvcrt: Implement longjmp for x86_64.
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: 37af4c371baf62aca31d18f88f3cdd0b6783baac URL: http://source.winehq.org/git/wine.git/?a=commit;h=37af4c371baf62aca31d18f88… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 1 16:40:31 2011 +0100 msvcrt: Implement longjmp for x86_64. --- dlls/crtdll/crtdll.spec | 2 +- dlls/msvcr100/msvcr100.spec | 2 +- dlls/msvcr70/msvcr70.spec | 2 +- dlls/msvcr71/msvcr71.spec | 4 +- dlls/msvcr80/msvcr80.spec | 2 +- dlls/msvcr90/msvcr90.spec | 2 +- dlls/msvcrt/except.c | 49 +++++++++++++++++++++++++++++++++++++++++++ dlls/msvcrt/msvcrt.h | 30 ++++++++++++++++++++++++++ dlls/msvcrt/msvcrt.spec | 2 +- dlls/msvcrt20/msvcrt20.spec | 4 +- dlls/msvcrt40/msvcrt40.spec | 4 +- dlls/msvcrtd/msvcrtd.spec | 2 +- 12 files changed, 92 insertions(+), 13 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=37af4c371baf62aca31d1…

1 0

Alexandre Julliard : msvcrt: longjmp doesn't have a return value.
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: 9b76c16e7ed2999a8e5ea087b7be79308b37176e URL: http://source.winehq.org/git/wine.git/?a=commit;h=9b76c16e7ed2999a8e5ea087b… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 1 16:34:42 2011 +0100 msvcrt: longjmp doesn't have a return value. --- dlls/msvcrt/except.c | 2 +- include/msvcrt/setjmp.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msvcrt/except.c b/dlls/msvcrt/except.c index 94a4367..db36af6 100644 --- a/dlls/msvcrt/except.c +++ b/dlls/msvcrt/except.c @@ -473,7 +473,7 @@ int CDECL __regs_MSVCRT__setjmp3(struct MSVCRT___JUMP_BUFFER *jmp, int nb_args, /********************************************************************* * longjmp (MSVCRT.@) */ -int CDECL MSVCRT_longjmp(struct MSVCRT___JUMP_BUFFER *jmp, int retval) +void CDECL MSVCRT_longjmp(struct MSVCRT___JUMP_BUFFER *jmp, int retval) { unsigned long cur_frame = 0; diff --git a/include/msvcrt/setjmp.h b/include/msvcrt/setjmp.h index ded4c9a..2468373 100644 --- a/include/msvcrt/setjmp.h +++ b/include/msvcrt/setjmp.h @@ -95,7 +95,7 @@ extern "C" { #endif int __cdecl _setjmp(jmp_buf); -int __cdecl longjmp(jmp_buf,int); +void __cdecl longjmp(jmp_buf,int); #ifdef __cplusplus }

1 0

Alexandre Julliard : ntdll: Add support for longjmp in RtlUnwindEx.
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: 10dcc85de0d829eb274b22d47d1f883e3ef87b02 URL: http://source.winehq.org/git/wine.git/?a=commit;h=10dcc85de0d829eb274b22d47… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Feb 1 16:34:04 2011 +0100 ntdll: Add support for longjmp in RtlUnwindEx. --- dlls/ntdll/signal_x86_64.c | 52 ++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 52 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c index 86f5c93..0fc53c7 100644 --- a/dlls/ntdll/signal_x86_64.c +++ b/dlls/ntdll/signal_x86_64.c @@ -100,6 +100,33 @@ typedef struct _SCOPE_TABLE } SCOPE_TABLE, *PSCOPE_TABLE; +/* layering violation: the setjmp buffer is defined in msvcrt, but used by RtlUnwindEx */ +struct MSVCRT_JUMP_BUFFER +{ + ULONG64 Frame; + ULONG64 Rbx; + ULONG64 Rsp; + ULONG64 Rbp; + ULONG64 Rsi; + ULONG64 Rdi; + ULONG64 R12; + ULONG64 R13; + ULONG64 R14; + ULONG64 R15; + ULONG64 Rip; + ULONG64 Spare; + M128A Xmm6; + M128A Xmm7; + M128A Xmm8; + M128A Xmm9; + M128A Xmm10; + M128A Xmm11; + M128A Xmm12; + M128A Xmm13; + M128A Xmm14; + M128A Xmm15; +}; + /*********************************************************************** * signal context platform-specific definitions */ @@ -3008,6 +3035,31 @@ void WINAPI RtlUnwindEx( PVOID end_frame, PVOID target_ip, EXCEPTION_RECORD *rec context = new_context; } + + if (rec->ExceptionCode == STATUS_LONGJUMP && rec->NumberParameters >= 1) + { + struct MSVCRT_JUMP_BUFFER *jmp = (struct MSVCRT_JUMP_BUFFER *)rec->ExceptionInformation[0]; + context.Rbx = jmp->Rbx; + context.Rsp = jmp->Rsp; + context.Rbp = jmp->Rbp; + context.Rsi = jmp->Rsi; + context.Rdi = jmp->Rdi; + context.R12 = jmp->R12; + context.R13 = jmp->R13; + context.R14 = jmp->R14; + context.R15 = jmp->R15; + context.Rip = jmp->Rip; + context.u.s.Xmm6 = jmp->Xmm6; + context.u.s.Xmm7 = jmp->Xmm7; + context.u.s.Xmm8 = jmp->Xmm8; + context.u.s.Xmm9 = jmp->Xmm9; + context.u.s.Xmm10 = jmp->Xmm10; + context.u.s.Xmm11 = jmp->Xmm11; + context.u.s.Xmm12 = jmp->Xmm12; + context.u.s.Xmm13 = jmp->Xmm13; + context.u.s.Xmm14 = jmp->Xmm14; + context.u.s.Xmm15 = jmp->Xmm15; + } context.Rax = (ULONG64)retval; context.Rip = (ULONG64)target_ip; TRACE( "returning to %lx stack %lx\n", context.Rip, context.Rsp );

1 0

André Hentschel : kernel32: Use define instead of hardcoded value.
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: 008cf3c18cf9a73f1ec1a11582e2d5e90a1caa0b URL: http://source.winehq.org/git/wine.git/?a=commit;h=008cf3c18cf9a73f1ec1a1158… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Jan 31 19:52:54 2011 +0100 kernel32: Use define instead of hardcoded value. --- dlls/kernel32/tests/volume.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dlls/kernel32/tests/volume.c b/dlls/kernel32/tests/volume.c index f632eb0..4484a80 100644 --- a/dlls/kernel32/tests/volume.c +++ b/dlls/kernel32/tests/volume.c @@ -20,6 +20,7 @@ #include "wine/test.h" #include "winbase.h" +#include "winioctl.h" #include <stdio.h> static HINSTANCE hdll; @@ -509,7 +510,7 @@ static void test_enum_vols(void) pFindVolumeClose( hFind ); } -static void test_ioctl_560000(void) +static void test_disk_extents(void) { BOOL ret; DWORD size; @@ -523,10 +524,11 @@ static void test_ioctl_560000(void) return; } size = 0; - ret = DeviceIoControl( handle, 0x560000, &data, sizeof(data), &data, sizeof(data), &size, NULL ); + ret = DeviceIoControl( handle, IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS, &data, + sizeof(data), &data, sizeof(data), &size, NULL ); if (!ret && GetLastError() == ERROR_INVALID_FUNCTION) { - win_skip("ioctl 0x560000 not supported\n"); + win_skip("IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS not supported\n"); CloseHandle( handle ); return; } @@ -555,5 +557,5 @@ START_TEST(volume) test_GetLogicalDriveStringsW(); test_GetVolumeInformationA(); test_enum_vols(); - test_ioctl_560000(); + test_disk_extents(); }

1 0

André Hentschel : mountmgr: Use define instead of hardcoded value.
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: 5a9f3a38dc4302c826114fe40e98616f24b37e92 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5a9f3a38dc4302c826114fe40… Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon Jan 31 19:44:22 2011 +0100 mountmgr: Use define instead of hardcoded value. --- dlls/mountmgr.sys/device.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/mountmgr.sys/device.c b/dlls/mountmgr.sys/device.c index 0550a26..702f3ff 100644 --- a/dlls/mountmgr.sys/device.c +++ b/dlls/mountmgr.sys/device.c @@ -900,11 +900,11 @@ static NTSTATUS WINAPI harddisk_ioctl( DEVICE_OBJECT *device, IRP *irp ) case IOCTL_CDROM_READ_TOC: irp->IoStatus.u.Status = STATUS_INVALID_DEVICE_REQUEST; break; - case 0x560000: + case IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS: { DWORD len = min( 32, irpsp->Parameters.DeviceIoControl.OutputBufferLength ); - FIXME( "returning zero-filled buffer for ioctl 0x560000\n" ); + FIXME( "returning zero-filled buffer for IOCTL_VOLUME_GET_VOLUME_DISK_EXTENTS\n" ); memset( irp->MdlAddress->StartVa, 0, len ); irp->IoStatus.Information = len; irp->IoStatus.u.Status = STATUS_SUCCESS;

1 0

Akihiro Sagawa : wrc: Don' t match a po message if a same msgid message is defined, but its msgctxt is null.
by Alexandre Julliard 01 Feb '11

01 Feb '11

Module: wine Branch: master Commit: 96361b39518e128a8f9f25524f1cf107242cb415 URL: http://source.winehq.org/git/wine.git/?a=commit;h=96361b39518e128a8f9f25524… Author: Akihiro Sagawa <sagawa.aki(a)gmail.com> Date: Sun Jan 30 00:39:32 2011 +0900 wrc: Don't match a po message if a same msgid message is defined, but its msgctxt is null. --- tools/wrc/po.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tools/wrc/po.c b/tools/wrc/po.c index d7aabc5..ef1e9f2 100644 --- a/tools/wrc/po.c +++ b/tools/wrc/po.c @@ -364,7 +364,7 @@ static po_message_t find_message( po_file_t po, const char *msgid, const char *m { if (strcmp( po_message_msgid( msg ), msgid )) continue; if (!msgctxt) break; - if (!(context = po_message_msgctxt( msg ))) break; + if (!(context = po_message_msgctxt( msg ))) continue; if (!strcmp( context, msgctxt )) break; } return msg;

1 0

← Newer
1
...
61
62
63
64
65
66
67
68
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2011