winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
March 2011
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
849 discussions
Start a n
N
ew thread
Rico Schüller : d3dx9: Fix HeapAlloc size in D3DXCreateEffectPool.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: be43a5c41470880cb2d44a2e9c7e5b958608fc78 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=be43a5c41470880cb2d44a2e9…
Author: Rico Schüller <kgbricola(a)web.de> Date: Sun Mar 27 22:12:22 2011 +0200 d3dx9: Fix HeapAlloc size in D3DXCreateEffectPool. --- dlls/d3dx9_36/effect.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index 2697782..efb5da3 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -1084,7 +1084,7 @@ HRESULT WINAPI D3DXCreateEffectPool(LPD3DXEFFECTPOOL* pool) if (!pool) return D3DERR_INVALIDCALL; - object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(ID3DXEffectImpl)); + object = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*object)); if (!object) { ERR("Out of memory\n");
1
0
0
0
Rico Schüller : include: Add missing D3DXCreateEffect* declarations in d3dx9effect.h.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: 1c30783c927ee9cb9a3b9e53df5a001c1b86ebd8 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1c30783c927ee9cb9a3b9e53d…
Author: Rico Schüller <kgbricola(a)web.de> Date: Sun Mar 27 22:12:13 2011 +0200 include: Add missing D3DXCreateEffect* declarations in d3dx9effect.h. --- include/d3dx9effect.h | 112 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 111 insertions(+), 1 deletions(-) diff --git a/include/d3dx9effect.h b/include/d3dx9effect.h index 67d28b2..235b8e7 100644 --- a/include/d3dx9effect.h +++ b/include/d3dx9effect.h @@ -347,7 +347,7 @@ DECLARE_INTERFACE_(ID3DXEffectCompiler, ID3DXBaseEffect) STDMETHOD(GetLiteral)(THIS_ D3DXHANDLE parameter, BOOL* literal) PURE; STDMETHOD(CompileEffect)(THIS_ DWORD flags, LPD3DXBUFFER* effect, LPD3DXBUFFER* error_msgs) PURE; STDMETHOD(CompileShader)(THIS_ D3DXHANDLE function, LPCSTR target, DWORD flags, LPD3DXBUFFER* shader, - LPD3DXBUFFER* error_msgs, LPD3DXCONSTANTTABLE* constant_table) PURE; + LPD3DXBUFFER* error_msgs, LPD3DXCONSTANTTABLE* constant_table) PURE; }; #undef INTERFACE @@ -386,6 +386,116 @@ HRESULT WINAPI D3DXCreateEffectCompiler(LPCSTR srcdata, LPD3DXEFFECTCOMPILER* compiler, LPD3DXBUFFER* parse_errors); +HRESULT WINAPI D3DXCreateEffectFromFileExA(LPDIRECT3DDEVICE9 device, + LPCSTR srcfile, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + LPCSTR skipconstants, + DWORD flags, + LPD3DXEFFECTPOOL pool, + LPD3DXEFFECT *effect, + LPD3DXBUFFER *compilationerrors); +HRESULT WINAPI D3DXCreateEffectFromFileExW(LPDIRECT3DDEVICE9 device, + LPCWSTR srcfile, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + LPCSTR skipconstants, + DWORD flags, + LPD3DXEFFECTPOOL pool, + LPD3DXEFFECT *effect, + LPD3DXBUFFER *compilationerrors); +#define D3DXCreateEffectFromFileEx WINELIB_NAME_AW(D3DXCreateEffectFromFileEx) + +HRESULT WINAPI D3DXCreateEffectFromFileA(LPDIRECT3DDEVICE9 device, + LPCSTR srcfile, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + DWORD flags, + LPD3DXEFFECTPOOL pool, + LPD3DXEFFECT *effect, + LPD3DXBUFFER *compilationerrors); +HRESULT WINAPI D3DXCreateEffectFromFileW(LPDIRECT3DDEVICE9 device, + LPCWSTR srcfile, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + DWORD flags, + LPD3DXEFFECTPOOL pool, + LPD3DXEFFECT *effect, + LPD3DXBUFFER *compilationerrors); +#define D3DXCreateEffectFromFile WINELIB_NAME_AW(D3DXCreateEffectFromFile) + +HRESULT WINAPI D3DXCreateEffectFromResourceExA(LPDIRECT3DDEVICE9 device, + HMODULE srcmodule, + LPCSTR srcresource, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + LPCSTR skipconstants, + DWORD flags, + LPD3DXEFFECTPOOL pool, + LPD3DXEFFECT *effect, + LPD3DXBUFFER *compilationerrors); +HRESULT WINAPI D3DXCreateEffectFromResourceExW(LPDIRECT3DDEVICE9 device, + HMODULE srcmodule, + LPCWSTR srcresource, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + LPCSTR skipconstants, + DWORD flags, + LPD3DXEFFECTPOOL pool, + LPD3DXEFFECT *effect, + LPD3DXBUFFER *compilationerrors); +#define D3DXCreateEffectFromResourceEx WINELIB_NAME_AW(D3DXCreateEffectFromResourceEx) + +HRESULT WINAPI D3DXCreateEffectFromResourceA(LPDIRECT3DDEVICE9 device, + HMODULE srcmodule, + LPCSTR srcresource, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + DWORD flags, + LPD3DXEFFECTPOOL pool, + LPD3DXEFFECT *effect, + LPD3DXBUFFER *compilationerrors); +HRESULT WINAPI D3DXCreateEffectFromResourceW(LPDIRECT3DDEVICE9 device, + HMODULE srcmodule, + LPCWSTR srcresource, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + DWORD flags, + LPD3DXEFFECTPOOL pool, + LPD3DXEFFECT *effect, + LPD3DXBUFFER *compilationerrors); +#define D3DXCreateEffectFromResource WINELIB_NAME_AW(D3DXCreateEffectFromResource) + +HRESULT WINAPI D3DXCreateEffectCompilerFromFileA(LPCSTR srcfile, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + DWORD flags, + LPD3DXEFFECTCOMPILER *effectcompiler, + LPD3DXBUFFER *parseerrors); +HRESULT WINAPI D3DXCreateEffectCompilerFromFileW(LPCWSTR srcfile, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + DWORD flags, + LPD3DXEFFECTCOMPILER *effectcompiler, + LPD3DXBUFFER *parseerrors); +#define D3DXCreateEffectCompilerFromFile WINELIB_NAME_AW(D3DXCreateEffectCompilerFromFile) + +HRESULT WINAPI D3DXCreateEffectCompilerFromResourceA(HMODULE srcmodule, + LPCSTR srcresource, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + DWORD flags, + LPD3DXEFFECTCOMPILER *effectcompiler, + LPD3DXBUFFER *parseerrors); +HRESULT WINAPI D3DXCreateEffectCompilerFromResourceW(HMODULE srcmodule, + LPCWSTR srcresource, + const D3DXMACRO *defines, + LPD3DXINCLUDE include, + DWORD flags, + LPD3DXEFFECTCOMPILER *effectcompiler, + LPD3DXBUFFER *parseerrors); +#define D3DXCreateEffectCompilerFromResource WINELIB_NAME_AW(D3DXCreateEffectCompilerFromResource) + #ifdef __cplusplus } #endif
1
0
0
0
Hans Leidekker : wldap32: Accept a NULL value in ldap_set_option.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: 95a5e9eba1771d231142990352b60b438b5ac664 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=95a5e9eba1771d23114299035…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Mar 29 13:59:22 2011 +0200 wldap32: Accept a NULL value in ldap_set_option. --- dlls/wldap32/option.c | 4 ++-- dlls/wldap32/tests/parse.c | 19 +++++++++++++++++++ 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/dlls/wldap32/option.c b/dlls/wldap32/option.c index 801d77d..95290ce 100644 --- a/dlls/wldap32/option.c +++ b/dlls/wldap32/option.c @@ -319,7 +319,7 @@ ULONG CDECL ldap_set_optionA( WLDAP32_LDAP *ld, int option, void *value ) TRACE( "(%p, 0x%08x, %p)\n", ld, option, value ); - if (!ld || !value) return WLDAP32_LDAP_PARAM_ERROR; + if (!ld) return WLDAP32_LDAP_PARAM_ERROR; switch (option) { @@ -422,7 +422,7 @@ ULONG CDECL ldap_set_optionW( WLDAP32_LDAP *ld, int option, void *value ) TRACE( "(%p, 0x%08x, %p)\n", ld, option, value ); - if (!ld || !value) return WLDAP32_LDAP_PARAM_ERROR; + if (!ld) return WLDAP32_LDAP_PARAM_ERROR; switch (option) { diff --git a/dlls/wldap32/tests/parse.c b/dlls/wldap32/tests/parse.c index 98e6b80..4cf8564 100644 --- a/dlls/wldap32/tests/parse.c +++ b/dlls/wldap32/tests/parse.c @@ -105,6 +105,24 @@ static void test_ldap_search_extW( LDAP *ld ) ok( !ret, "ldap_search_extW failed 0x%08x\n", ret ); } +static void test_ldap_set_optionW( LDAP *ld ) +{ + ULONG ret, oldvalue; + + ret = ldap_get_optionW( ld, LDAP_OPT_REFERRALS, &oldvalue ); + if (ret == LDAP_SERVER_DOWN || ret == LDAP_UNAVAILABLE) + { + skip("test server can't be reached\n"); + return; + } + + ret = ldap_set_optionW( ld, LDAP_OPT_REFERRALS, LDAP_OPT_OFF ); + ok( !ret || broken(ret == LDAP_PARAM_ERROR) /* nt4, win2k */, "ldap_set_optionW failed 0x%08x\n", ret ); + + ret = ldap_set_optionW( ld, LDAP_OPT_REFERRALS, (void *)&oldvalue ); + ok( !ret, "ldap_set_optionW failed 0x%08x\n", ret ); +} + START_TEST (parse) { LDAP *ld; @@ -114,5 +132,6 @@ START_TEST (parse) test_ldap_parse_sort_control( ld ); test_ldap_search_extW( ld ); + test_ldap_set_optionW( ld ); ldap_unbind( ld ); }
1
0
0
0
Hans Leidekker : kernel32: Implement and test GetVolumePathNamesForVolumeName.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: 552715f0c15d9a75ca13baf0ca84ebc939a3c745 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=552715f0c15d9a75ca13baf0c…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Mar 29 13:03:42 2011 +0200 kernel32: Implement and test GetVolumePathNamesForVolumeName. --- dlls/kernel32/tests/volume.c | 169 ++++++++++++++++++++++++++++++++++++++++++ dlls/kernel32/volume.c | 159 ++++++++++++++++++++++++++++++++++++++-- 2 files changed, 322 insertions(+), 6 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=552715f0c15d9a75ca13b…
1
0
0
0
Hans Leidekker : ws2_32: Implement GetNameInfoW.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: 8f07cdf975914fb7ddf7ec15e23f1f842db441f2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8f07cdf975914fb7ddf7ec15e…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Mar 29 13:03:24 2011 +0200 ws2_32: Implement GetNameInfoW. --- dlls/ws2_32/socket.c | 25 +++++++++++++++++++++++++ dlls/ws2_32/ws2_32.spec | 1 + 2 files changed, 26 insertions(+), 0 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 9469d30..d72ed80 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -5104,6 +5104,31 @@ int WINAPI WS_getnameinfo(const SOCKADDR *sa, WS_socklen_t salen, PCHAR host, #endif } +int WINAPI GetNameInfoW(const SOCKADDR *sa, WS_socklen_t salen, PWCHAR host, + DWORD hostlen, PWCHAR serv, DWORD servlen, INT flags) +{ + int ret; + char *hostA = NULL, *servA = NULL; + + if (host && (!(hostA = HeapAlloc(GetProcessHeap(), 0, hostlen)))) return EAI_MEMORY; + if (serv && (!(servA = HeapAlloc(GetProcessHeap(), 0, servlen)))) + { + HeapFree(GetProcessHeap(), 0, hostA); + return EAI_MEMORY; + } + + ret = WS_getnameinfo(sa, salen, hostA, hostlen, servA, servlen, flags); + if (!ret) + { + if (host) MultiByteToWideChar(CP_ACP, 0, hostA, -1, host, hostlen); + if (serv) MultiByteToWideChar(CP_ACP, 0, servA, -1, serv, servlen); + } + + HeapFree(GetProcessHeap(), 0, hostA); + HeapFree(GetProcessHeap(), 0, servA); + return ret; +} + /*********************************************************************** * getservbyport (WS2_32.56) */ diff --git a/dlls/ws2_32/ws2_32.spec b/dlls/ws2_32/ws2_32.spec index 537e7f3..ccec106 100644 --- a/dlls/ws2_32/ws2_32.spec +++ b/dlls/ws2_32/ws2_32.spec @@ -52,6 +52,7 @@ @ stdcall FreeAddrInfoW(ptr) @ stdcall GetAddrInfoW(wstr wstr ptr ptr) +@ stdcall GetNameInfoW(ptr long ptr long ptr long long) @ stdcall WSApSetPostRoutine(ptr) @ stdcall WPUCompleteOverlappedRequest(long ptr long long ptr) @ stdcall WSAAccept(long ptr ptr ptr long)
1
0
0
0
Jacek Caban : mshtml: Fixed node leak in HTMLEventObj.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: 86aecc8488e818cb09c0817cbfa9c40845938fa5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=86aecc8488e818cb09c0817cb…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 29 13:37:42 2011 +0200 mshtml: Fixed node leak in HTMLEventObj. --- dlls/mshtml/htmlevent.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 8dbf554..d0e8814 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -289,6 +289,8 @@ static ULONG WINAPI HTMLEventObj_Release(IHTMLEventObj *iface) TRACE("(%p) ref=%d\n", This, ref); if(!ref) { + if(This->target) + IHTMLDOMNode_Release(&This->target->IHTMLDOMNode_iface); if(This->nsevent) nsIDOMEvent_Release(This->nsevent); release_dispex(&This->dispex);
1
0
0
0
Jacek Caban : mshtml: Fixed ref count handling in events.c.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: 1d61146cb6fc722157b9d3a20c2923fd7a04609b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1d61146cb6fc722157b9d3a20…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 29 13:37:01 2011 +0200 mshtml: Fixed ref count handling in events.c. --- dlls/mshtml/tests/events.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/tests/events.c b/dlls/mshtml/tests/events.c index 6ed9f97..32f943f 100644 --- a/dlls/mshtml/tests/events.c +++ b/dlls/mshtml/tests/events.c @@ -1037,7 +1037,6 @@ static HRESULT WINAPI iframe_onreadystatechange(IDispatchEx *iface, DISPID id, L str = NULL; hres = IHTMLFrameBase2_get_readyState(iframe, &str); - IHTMLFrameBase2_Release(iframe); ok(hres == S_OK, "get_readyState failed: %08x\n", hres); ok(str != NULL, "readyState == NULL\n"); ok(!lstrcmpW(str, V_BSTR(&v)), "ready states differ\n");
1
0
0
0
Jacek Caban : mshtml: Event handler may be already free in release_event_target.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: a96606e6adcb43ce6953b7161419013f3783168a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a96606e6adcb43ce6953b7161…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 29 13:36:46 2011 +0200 mshtml: Event handler may be already free in release_event_target. --- dlls/mshtml/htmlevent.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index d1430cd..8dbf554 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -1343,7 +1343,8 @@ void release_event_target(event_target_t *event_target) if(event_target->event_table[i]->handler_prop) IDispatch_Release(event_target->event_table[i]->handler_prop); for(j=0; j < event_target->event_table[i]->handler_cnt; j++) - IDispatch_Release(event_target->event_table[i]->handlers[j]); + if(event_target->event_table[i]->handlers[j]) + IDispatch_Release(event_target->event_table[i]->handlers[j]); } }
1
0
0
0
Jacek Caban : mshtml: Use zone mapping instead of hardcoded protocols in use_gecko_script.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: 3e422b9ed828122524214b9f3ce20f35431242dc URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3e422b9ed828122524214b9f3…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 29 12:51:21 2011 +0200 mshtml: Use zone mapping instead of hardcoded protocols in use_gecko_script. --- dlls/mshtml/persist.c | 21 ++++++++++++++------- 1 files changed, 14 insertions(+), 7 deletions(-) diff --git a/dlls/mshtml/persist.c b/dlls/mshtml/persist.c index 43d7e3c..6915e3d 100644 --- a/dlls/mshtml/persist.c +++ b/dlls/mshtml/persist.c @@ -48,15 +48,22 @@ typedef struct { LPOLESTR url; } download_proc_task_t; -static BOOL use_gecko_script(LPCWSTR url) +static BOOL use_gecko_script(HTMLWindow *window) { - static const WCHAR fileW[] = {'f','i','l','e',':'}; + DWORD zone; + HRESULT hres; + static const WCHAR aboutW[] = {'a','b','o','u','t',':'}; - static const WCHAR resW[] = {'r','e','s',':'}; - return strncmpiW(fileW, url, sizeof(fileW)/sizeof(WCHAR)) - && strncmpiW(aboutW, url, sizeof(aboutW)/sizeof(WCHAR)) - && strncmpiW(resW, url, sizeof(resW)/sizeof(WCHAR)); + hres = IInternetSecurityManager_MapUrlToZone(window->secmgr, window->url, &zone, 0); + if(FAILED(hres)) { + WARN("Could not map %s to zone: %08x\n", debugstr_w(window->url), hres); + return TRUE; + } + + TRACE("zone %d\n", zone); + return zone != URLZONE_LOCAL_MACHINE && zone != URLZONE_TRUSTED + && strncmpiW(aboutW, window->url, sizeof(aboutW)/sizeof(WCHAR)); } void set_current_mon(HTMLWindow *This, IMoniker *mon) @@ -83,7 +90,7 @@ void set_current_mon(HTMLWindow *This, IMoniker *mon) if(FAILED(hres)) WARN("GetDisplayName failed: %08x\n", hres); - set_script_mode(This, use_gecko_script(This->url) ? SCRIPTMODE_GECKO : SCRIPTMODE_ACTIVESCRIPT); + set_script_mode(This, use_gecko_script(This) ? SCRIPTMODE_GECKO : SCRIPTMODE_ACTIVESCRIPT); } static void set_progress_proc(task_t *_task)
1
0
0
0
Jacek Caban : mshtml: Store security manager in HTMLWindow instead of HTMLDocumentNode.
by Alexandre Julliard
29 Mar '11
29 Mar '11
Module: wine Branch: master Commit: 739ff1208e63ef46dcb11ec0205fc76fc80f5eb6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=739ff1208e63ef46dcb11ec02…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Mar 29 12:51:04 2011 +0200 mshtml: Store security manager in HTMLWindow instead of HTMLDocumentNode. --- dlls/mshtml/htmldoc.c | 9 --------- dlls/mshtml/htmlwindow.c | 10 ++++++++++ dlls/mshtml/mshtml_private.h | 3 ++- dlls/mshtml/secmgr.c | 6 +++--- 4 files changed, 15 insertions(+), 13 deletions(-) diff --git a/dlls/mshtml/htmldoc.c b/dlls/mshtml/htmldoc.c index f9bc469..f7a70ca 100644 --- a/dlls/mshtml/htmldoc.c +++ b/dlls/mshtml/htmldoc.c @@ -1912,8 +1912,6 @@ static void HTMLDocumentNode_destructor(HTMLDOMNode *iface) release_nsevents(This); if(This->catmgr) ICatInformation_Release(This->catmgr); - if(This->secmgr) - IInternetSecurityManager_Release(This->secmgr); detach_selection(This); detach_ranges(This); @@ -2013,7 +2011,6 @@ static HTMLDocumentNode *alloc_doc_node(HTMLDocumentObj *doc_obj, HTMLWindow *wi HRESULT create_doc_from_nsdoc(nsIDOMHTMLDocument *nsdoc, HTMLDocumentObj *doc_obj, HTMLWindow *window, HTMLDocumentNode **ret) { HTMLDocumentNode *doc; - HRESULT hres; doc = alloc_doc_node(doc_obj, window); if(!doc) @@ -2030,12 +2027,6 @@ HRESULT create_doc_from_nsdoc(nsIDOMHTMLDocument *nsdoc, HTMLDocumentObj *doc_ob doc->node.vtbl = &HTMLDocumentNodeImplVtbl; doc->node.cp_container = &doc->basedoc.cp_container; - hres = CoInternetCreateSecurityManager(NULL, &doc->secmgr, 0); - if(FAILED(hres)) { - htmldoc_release(&doc->basedoc); - return hres; - } - *ret = doc; return S_OK; } diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 695b829..e0d542b 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -236,6 +236,9 @@ static ULONG WINAPI HTMLWindow2_Release(IHTMLWindow2 *iface) window_set_docnode(This, NULL); release_children(This); + if(This->secmgr) + IInternetSecurityManager_Release(This->secmgr); + if(This->frame_element) This->frame_element->content_window = NULL; @@ -2217,6 +2220,7 @@ static dispex_static_data_t HTMLWindow_dispex = { HRESULT HTMLWindow_Create(HTMLDocumentObj *doc_obj, nsIDOMWindow *nswindow, HTMLWindow *parent, HTMLWindow **ret) { HTMLWindow *window; + HRESULT hres; window = heap_alloc_zero(sizeof(HTMLWindow)); if(!window) @@ -2251,6 +2255,12 @@ HRESULT HTMLWindow_Create(HTMLDocumentObj *doc_obj, nsIDOMWindow *nswindow, HTML window->readystate = READYSTATE_UNINITIALIZED; list_init(&window->script_hosts); + hres = CoInternetCreateSecurityManager(NULL, &window->secmgr, 0); + if(FAILED(hres)) { + IHTMLWindow2_Release(&window->IHTMLWindow2_iface); + return hres; + } + window->task_magic = get_task_target_magic(); update_window_doc(window); diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 83a76b9..a449b18 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -295,6 +295,8 @@ struct HTMLWindow { SCRIPTMODE scriptmode; struct list script_hosts; + IInternetSecurityManager *secmgr; + HTMLOptionElementFactory *option_factory; HTMLImageElementFactory *image_factory; HTMLLocation *location; @@ -611,7 +613,6 @@ struct HTMLDocumentNode { BOOL content_ready; event_target_t *body_event_target; - IInternetSecurityManager *secmgr; ICatInformation *catmgr; nsDocumentEventListener *nsevent_listener; BOOL *event_vector; diff --git a/dlls/mshtml/secmgr.c b/dlls/mshtml/secmgr.c index 8225d59..3d21475 100644 --- a/dlls/mshtml/secmgr.c +++ b/dlls/mshtml/secmgr.c @@ -83,7 +83,7 @@ static HRESULT WINAPI InternetHostSecurityManager_ProcessUrlAction(IInternetHost url = This->basedoc.window->url ? This->basedoc.window->url : about_blankW; - return IInternetSecurityManager_ProcessUrlAction(This->secmgr, url, dwAction, pPolicy, cbPolicy, + return IInternetSecurityManager_ProcessUrlAction(This->basedoc.window->secmgr, url, dwAction, pPolicy, cbPolicy, pContext, cbContext, dwFlags, dwReserved); } @@ -121,7 +121,7 @@ static HRESULT confirm_safety(HTMLDocumentNode *This, const WCHAR *url, struct C /* FIXME: Check URLACTION_ACTIVEX_OVERRIDE_SCRIPT_SAFETY */ - hres = IInternetSecurityManager_ProcessUrlAction(This->secmgr, url, URLACTION_SCRIPT_SAFE_ACTIVEX, + hres = IInternetSecurityManager_ProcessUrlAction(This->basedoc.window->secmgr, url, URLACTION_SCRIPT_SAFE_ACTIVEX, (BYTE*)&policy, sizeof(policy), NULL, 0, 0, 0); if(FAILED(hres) || policy != URLPOLICY_ALLOW) { *ret = URLPOLICY_DISALLOW; @@ -187,7 +187,7 @@ static HRESULT WINAPI InternetHostSecurityManager_QueryCustomPolicy(IInternetHos url = This->basedoc.window->url ? This->basedoc.window->url : about_blankW; - hres = IInternetSecurityManager_QueryCustomPolicy(This->secmgr, url, guidKey, ppPolicy, pcbPolicy, + hres = IInternetSecurityManager_QueryCustomPolicy(This->basedoc.window->secmgr, url, guidKey, ppPolicy, pcbPolicy, pContext, cbContext, dwReserved); if(hres != HRESULT_FROM_WIN32(ERROR_NOT_FOUND)) return hres;
1
0
0
0
← Newer
1
...
10
11
12
13
14
15
16
...
85
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
Results per page:
10
25
50
100
200