winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
March 2011
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
849 discussions
Start a n
N
ew thread
Alexandre Julliard : wininet/tests: Update test data location to test. winehq.org/tests.
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: ac6a5a6355cc5ad1c9efa393835300d224a85cb0 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ac6a5a6355cc5ad1c9efa3938…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Mar 14 16:43:19 2011 +0100 wininet/tests: Update test data location to
test.winehq.org/tests
. --- dlls/wininet/tests/http.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/wininet/tests/http.c b/dlls/wininet/tests/http.c index 95a5779..980a809 100644 --- a/dlls/wininet/tests/http.c +++ b/dlls/wininet/tests/http.c @@ -31,7 +31,7 @@ #include "wine/test.h" -#define TEST_URL "
http://test.winehq.org/hello.html
" +#define TEST_URL "
http://test.winehq.org/tests/hello.html
" static BOOL first_connection_to_test_url = TRUE; @@ -121,10 +121,10 @@ typedef struct { static const test_data_t test_data[] = { { - "
http://test.winehq.org/testredirect
", - "
http://test.winehq.org/hello.html
", + "
http://test.winehq.org/tests/redirect
", + "
http://test.winehq.org/tests/hello.html
", "
test.winehq.org
", - "/testredirect", + "/tests/redirect", "", TESTF_REDIRECT }, @@ -629,7 +629,7 @@ static void InternetReadFile_chunked_test(void) if (hic == 0x0) goto abort; trace("HttpOpenRequestA <--\n"); - hor = HttpOpenRequestA(hic, "GET", "/testchunked", NULL, NULL, types, + hor = HttpOpenRequestA(hic, "GET", "/tests/chunked", NULL, NULL, types, INTERNET_FLAG_KEEP_CONNECTION | INTERNET_FLAG_RESYNCHRONIZE, 0xdeadbead); if (hor == 0x0 && GetLastError() == ERROR_INTERNET_NAME_NOT_RESOLVED) { @@ -748,7 +748,7 @@ static void InternetReadFileExA_test(int flags) SET_EXPECT(INTERNET_STATUS_HANDLE_CREATED); trace("HttpOpenRequestA <--\n"); - hor = HttpOpenRequestA(hic, "GET", "/testredirect", NULL, NULL, types, + hor = HttpOpenRequestA(hic, "GET", "/tests/redirect", NULL, NULL, types, INTERNET_FLAG_KEEP_CONNECTION | INTERNET_FLAG_RESYNCHRONIZE, 0xdeadbead); if (hor == 0x0 && GetLastError() == ERROR_INTERNET_NAME_NOT_RESOLVED) { @@ -1150,7 +1150,7 @@ static void test_http_cache(void) INTERNET_SERVICE_HTTP, 0, 0); ok(connect != NULL, "Unable to connect to
http://test.winehq.org
with error %d\n", GetLastError()); - request = HttpOpenRequestA(connect, NULL, "/hello.html", NULL, NULL, types, INTERNET_FLAG_NEED_FILE, 0); + request = HttpOpenRequestA(connect, NULL, "/tests/hello.html", NULL, NULL, types, INTERNET_FLAG_NEED_FILE, 0); if (!request && GetLastError() == ERROR_INTERNET_NAME_NOT_RESOLVED) { skip( "Network unreachable, skipping test\n" ); @@ -1165,7 +1165,7 @@ static void test_http_cache(void) size = sizeof(url); ret = InternetQueryOptionA(request, INTERNET_OPTION_URL, url, &size); ok(ret, "InternetQueryOptionA(INTERNET_OPTION_URL) failed: %u\n", GetLastError()); - ok(!strcmp(url, "
http://test.winehq.org/hello.html
"), "Wrong URL %s\n", url); + ok(!strcmp(url, "
http://test.winehq.org/tests/hello.html
"), "Wrong URL %s\n", url); size = sizeof(file_name); ret = InternetQueryOptionA(request, INTERNET_OPTION_DATAFILE_NAME, file_name, &size); @@ -2913,7 +2913,7 @@ static void test_user_agent_header(void) con = InternetConnect(ses, "
test.winehq.org
", 80, NULL, NULL, INTERNET_SERVICE_HTTP, 0, 0); ok(con != NULL, "InternetConnect failed\n"); - req = HttpOpenRequest(con, "GET", "/hello.html", "HTTP/1.0", NULL, NULL, 0, 0); + req = HttpOpenRequest(con, "GET", "/tests/hello.html", "HTTP/1.0", NULL, NULL, 0, 0); ok(req != NULL, "HttpOpenRequest failed\n"); size = sizeof(buffer);
1
0
0
0
André Hentschel : advapi32/tests: Add some skips.
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: e2a3b4b4e59d519d07be925c057aa3e82ff1a8ea URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e2a3b4b4e59d519d07be925c0…
Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Mar 13 15:32:59 2011 +0100 advapi32/tests: Add some skips. --- dlls/advapi32/tests/registry.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index 2809559..91164bd 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -2064,8 +2064,13 @@ static void test_classesroot(void) delete_key( hkey ); RegCloseKey( hkey ); } - if (RegCreateKeyExA( HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", 0, NULL, 0, - KEY_QUERY_VALUE|KEY_SET_VALUE, NULL, &hkey, NULL )) return; + res = RegCreateKeyExA( HKEY_CURRENT_USER, "Software\\Classes\\WineTestCls", 0, NULL, 0, + KEY_QUERY_VALUE|KEY_SET_VALUE, NULL, &hkey, NULL ); + if (res == ERROR_ACCESS_DENIED) + { + skip("not enough privileges to add a user class\n"); + return; + } /* try to open that key in hkcr */ res = RegOpenKeyExA( HKEY_CLASSES_ROOT, "WineTestCls", 0, @@ -2075,7 +2080,7 @@ static void test_classesroot(void) "test key not found in hkcr: %d\n", res); if (res) { - trace( "HKCR key merging not supported\n" ); + skip("HKCR key merging not supported\n"); delete_key( hkey ); RegCloseKey( hkey ); return;
1
0
0
0
André Hentschel : ws2_32: Downgrade FIXME for WS_SIO_SET_COMPATIBILITY_MODE to a TRACE.
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: 42d3bd713d9575a393a1a7d909d72a56d1e5f10e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=42d3bd713d9575a393a1a7d90…
Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Mar 12 22:27:32 2011 +0100 ws2_32: Downgrade FIXME for WS_SIO_SET_COMPATIBILITY_MODE to a TRACE. --- dlls/ws2_32/socket.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/dlls/ws2_32/socket.c b/dlls/ws2_32/socket.c index 1993419..9469d30 100644 --- a/dlls/ws2_32/socket.c +++ b/dlls/ws2_32/socket.c @@ -3483,6 +3483,10 @@ INT WINAPI WSAIoctl(SOCKET s, HeapFree(GetProcessHeap(), 0, ipAddrTable); return 0; } + case WS_SIO_SET_COMPATIBILITY_MODE: + TRACE("WS_SIO_SET_COMPATIBILITY_MODE ignored\n"); + WSASetLastError(WSAEOPNOTSUPP); + return SOCKET_ERROR; case WS_SIO_UDP_CONNRESET: FIXME("WS_SIO_UDP_CONNRESET stub\n"); break;
1
0
0
0
André Hentschel : kernel32/tests: Fix a test for real hardware.
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: 27ae573806cc541a63288884f29483905da80c29 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=27ae573806cc541a63288884f…
Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Mar 12 13:41:47 2011 +0100 kernel32/tests: Fix a test for real hardware. --- dlls/kernel32/tests/thread.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/kernel32/tests/thread.c b/dlls/kernel32/tests/thread.c index fab01dc..25b55ac 100644 --- a/dlls/kernel32/tests/thread.c +++ b/dlls/kernel32/tests/thread.c @@ -865,7 +865,7 @@ static VOID test_thread_processor(void) } error=pSetThreadIdealProcessor(curthread,MAXIMUM_PROCESSORS); - ok(error==0, "SetThreadIdealProcessor returned an incorrect value\n"); + ok(error!=-1, "SetThreadIdealProcessor failed\n"); } }
1
0
0
0
André Hentschel : ntoskrnl.exe: Add more mutex stubs.
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: bd456a926cbfb1dbe1ff003e7f7805ab45a9a522 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bd456a926cbfb1dbe1ff003e7…
Author: André Hentschel <nerv(a)dawncrow.de> Date: Sat Mar 12 13:40:31 2011 +0100 ntoskrnl.exe: Add more mutex stubs. --- dlls/ntoskrnl.exe/ntoskrnl.c | 21 +++++++++++++++++++++ dlls/ntoskrnl.exe/ntoskrnl.exe.spec | 4 ++-- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/dlls/ntoskrnl.exe/ntoskrnl.c b/dlls/ntoskrnl.exe/ntoskrnl.c index 27c5f7a..a697751 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.c +++ b/dlls/ntoskrnl.exe/ntoskrnl.c @@ -1099,6 +1099,27 @@ void WINAPI KeInitializeMutex(PRKMUTEX Mutex, ULONG Level) } + /*********************************************************************** + * KeWaitForMutexObject (NTOSKRNL.EXE.@) + */ +NTSTATUS WINAPI KeWaitForMutexObject(PRKMUTEX Mutex, KWAIT_REASON WaitReason, KPROCESSOR_MODE WaitMode, + BOOLEAN Alertable, PLARGE_INTEGER Timeout) +{ + FIXME( "stub: %p, %d, %d, %d, %p\n", Mutex, WaitReason, WaitMode, Alertable, Timeout ); + return STATUS_NOT_IMPLEMENTED; +} + + + /*********************************************************************** + * KeReleaseMutex (NTOSKRNL.EXE.@) + */ +LONG WINAPI KeReleaseMutex(PRKMUTEX Mutex, BOOLEAN Wait) +{ + FIXME( "stub: %p, %d\n", Mutex, Wait ); + return STATUS_NOT_IMPLEMENTED; +} + + /*********************************************************************** * KeInitializeSemaphore (NTOSKRNL.EXE.@) */ diff --git a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec index 6d645ad..ed0059e 100644 --- a/dlls/ntoskrnl.exe/ntoskrnl.exe.spec +++ b/dlls/ntoskrnl.exe/ntoskrnl.exe.spec @@ -587,7 +587,7 @@ @ stub KeRegisterBugCheckReasonCallback @ stub KeReleaseInterruptSpinLock @ stub KeReleaseMutant -@ stub KeReleaseMutex +@ stdcall KeReleaseMutex(ptr long) @ stdcall KeReleaseSemaphore(ptr long long long) @ stub KeReleaseSpinLockFromDpcLevel @ stub KeRemoveByKeyDeviceQueue @@ -628,7 +628,7 @@ @ stub KeUpdateSystemTime @ stub KeUserModeCallback @ stub KeWaitForMultipleObjects -@ stub KeWaitForMutexObject +@ stdcall KeWaitForMutexObject(ptr long long long ptr) @ stdcall KeWaitForSingleObject(ptr long long long ptr) @ stub KiBugCheckData @ stub KiCoprocessorError
1
0
0
0
Marcus Meissner : quartz: Removed const from const REFIID (Coverity).
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: 82cd229cc2143b5111dc136e9e29c1e4fd84bc0a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=82cd229cc2143b5111dc136e9…
Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Mar 14 05:32:52 2011 +0100 quartz: Removed const from const REFIID (Coverity). --- dlls/quartz/dsoundrender.c | 2 +- dlls/quartz/filesource.c | 2 +- dlls/quartz/nullrenderer.c | 2 +- dlls/quartz/videorenderer.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/quartz/dsoundrender.c b/dlls/quartz/dsoundrender.c index d472145..f172d87 100644 --- a/dlls/quartz/dsoundrender.c +++ b/dlls/quartz/dsoundrender.c @@ -1534,7 +1534,7 @@ static DSoundRenderImpl *from_IAMFilterMiscFlags(IAMFilterMiscFlags *iface) { return (DSoundRenderImpl*)((char*)iface - offsetof(DSoundRenderImpl, IAMFilterMiscFlags_vtbl)); } -static HRESULT WINAPI AMFilterMiscFlags_QueryInterface(IAMFilterMiscFlags *iface, const REFIID riid, void **ppv) { +static HRESULT WINAPI AMFilterMiscFlags_QueryInterface(IAMFilterMiscFlags *iface, REFIID riid, void **ppv) { DSoundRenderImpl *This = from_IAMFilterMiscFlags(iface); return IUnknown_QueryInterface((IUnknown*)This, riid, ppv); } diff --git a/dlls/quartz/filesource.c b/dlls/quartz/filesource.c index d458144..6093713 100644 --- a/dlls/quartz/filesource.c +++ b/dlls/quartz/filesource.c @@ -1357,7 +1357,7 @@ static AsyncReader *from_IAMFilterMiscFlags(IAMFilterMiscFlags *iface) { return (AsyncReader*)((char*)iface - offsetof(AsyncReader, IAMFilterMiscFlags_vtbl)); } -static HRESULT WINAPI AMFilterMiscFlags_QueryInterface(IAMFilterMiscFlags *iface, const REFIID riid, void **ppv) { +static HRESULT WINAPI AMFilterMiscFlags_QueryInterface(IAMFilterMiscFlags *iface, REFIID riid, void **ppv) { AsyncReader *This = from_IAMFilterMiscFlags(iface); return IUnknown_QueryInterface((IUnknown*)This, riid, ppv); } diff --git a/dlls/quartz/nullrenderer.c b/dlls/quartz/nullrenderer.c index cdc7621..f4486c4 100644 --- a/dlls/quartz/nullrenderer.c +++ b/dlls/quartz/nullrenderer.c @@ -478,7 +478,7 @@ static NullRendererImpl *from_IAMFilterMiscFlags(IAMFilterMiscFlags *iface) { return (NullRendererImpl*)((char*)iface - offsetof(NullRendererImpl, IAMFilterMiscFlags_vtbl)); } -static HRESULT WINAPI AMFilterMiscFlags_QueryInterface(IAMFilterMiscFlags *iface, const REFIID riid, void **ppv) { +static HRESULT WINAPI AMFilterMiscFlags_QueryInterface(IAMFilterMiscFlags *iface, REFIID riid, void **ppv) { NullRendererImpl *This = from_IAMFilterMiscFlags(iface); return IUnknown_QueryInterface((IUnknown*)This, riid, ppv); } diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c index 86b9f2a..cf6fc2a 100644 --- a/dlls/quartz/videorenderer.c +++ b/dlls/quartz/videorenderer.c @@ -2202,7 +2202,7 @@ static VideoRendererImpl *from_IAMFilterMiscFlags(IAMFilterMiscFlags *iface) { return (VideoRendererImpl*)((char*)iface - offsetof(VideoRendererImpl, IAMFilterMiscFlags_vtbl)); } -static HRESULT WINAPI AMFilterMiscFlags_QueryInterface(IAMFilterMiscFlags *iface, const REFIID riid, void **ppv) { +static HRESULT WINAPI AMFilterMiscFlags_QueryInterface(IAMFilterMiscFlags *iface, REFIID riid, void **ppv) { VideoRendererImpl *This = from_IAMFilterMiscFlags(iface); return IUnknown_QueryInterface((IUnknown*)This, riid, ppv); }
1
0
0
0
Marcus Meissner : mshtml: Removed duplicate const (Coverity).
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: 63b05794a7c64b1f1a3db67695ecd4ab3a287880 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=63b05794a7c64b1f1a3db6769…
Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Mar 14 05:28:42 2011 +0100 mshtml: Removed duplicate const (Coverity). --- dlls/mshtml/tests/activex.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/mshtml/tests/activex.c b/dlls/mshtml/tests/activex.c index 241342b..486acce 100644 --- a/dlls/mshtml/tests/activex.c +++ b/dlls/mshtml/tests/activex.c @@ -101,7 +101,7 @@ static const char object_ax_str[] = "</object>" "</body></html>"; -static const REFIID pluginhost_iids[] = { +static REFIID pluginhost_iids[] = { &IID_IOleClientSite, &IID_IAdviseSink, &IID_IAdviseSinkEx,
1
0
0
0
Jacek Caban : mshtml: Properly handle BLOCKED:: URLs in IHTMLImgElement:: get_src.
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: 0ef8f70e114fcba6845b8b3cab25fdc405efc297 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0ef8f70e114fcba6845b8b3ca…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Mar 14 14:07:09 2011 +0100 mshtml: Properly handle BLOCKED:: URLs in IHTMLImgElement::get_src. --- dlls/mshtml/htmlimg.c | 22 ++++++++++++++++------ dlls/mshtml/tests/dom.c | 38 ++++++++++++++++++++++++++++++++------ 2 files changed, 48 insertions(+), 12 deletions(-) diff --git a/dlls/mshtml/htmlimg.c b/dlls/mshtml/htmlimg.c index 1008f87..1fb0e83 100644 --- a/dlls/mshtml/htmlimg.c +++ b/dlls/mshtml/htmlimg.c @@ -287,21 +287,31 @@ static HRESULT WINAPI HTMLImgElement_get_src(IHTMLImgElement *iface, BSTR *p) const PRUnichar *src; nsAString src_str; nsresult nsres; - HRESULT hres; + HRESULT hres = S_OK; + + static const WCHAR blockedW[] = {'B','L','O','C','K','E','D',':',':',0}; TRACE("(%p)->(%p)\n", This, p); nsAString_Init(&src_str, NULL); nsres = nsIDOMHTMLImageElement_GetSrc(This->nsimg, &src_str); - if(NS_FAILED(nsres)) { + if(NS_SUCCEEDED(nsres)) { + nsAString_GetData(&src_str, &src); + + if(!strncmpiW(src, blockedW, sizeof(blockedW)/sizeof(WCHAR)-1)) { + TRACE("returning BLOCKED::\n"); + *p = SysAllocString(blockedW); + if(!*p) + hres = E_OUTOFMEMORY; + }else { + hres = nsuri_to_url(src, TRUE, p); + } + }else { ERR("GetSrc failed: %08x\n", nsres); - return E_FAIL; + hres = E_FAIL; } - nsAString_GetData(&src_str, &src); - hres = nsuri_to_url(src, TRUE, p); nsAString_Finish(&src_str); - return hres; } diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c index ec6c7e8..64e0cf2 100644 --- a/dlls/mshtml/tests/dom.c +++ b/dlls/mshtml/tests/dom.c @@ -2161,8 +2161,8 @@ static void _elem_get_scroll_left(unsigned line, IUnknown *unk) ok(l == l2, "unexpected left %d, expected %d\n", l2, l); } -#define test_img_src(i,s) _test_img_src(__LINE__,i,s) -static void _test_img_src(unsigned line, IUnknown *unk, const char *exsrc) +#define test_img_src(a,b,c) _test_img_src(__LINE__,a,b,c) +static void _test_img_src(unsigned line, IUnknown *unk, const char *exsrc, const char *broken_src) { IHTMLImgElement *img = _get_img_iface(line, unk); BSTR src; @@ -2171,7 +2171,8 @@ static void _test_img_src(unsigned line, IUnknown *unk, const char *exsrc) hres = IHTMLImgElement_get_src(img, &src); IHTMLImgElement_Release(img); ok_(__FILE__,line) (hres == S_OK, "get_src failed: %08x\n", hres); - ok_(__FILE__,line) (!strcmp_wa(src, exsrc), "get_src returned %s expected %s\n", wine_dbgstr_w(src), exsrc); + ok_(__FILE__,line) (!strcmp_wa(src, exsrc) || (broken_src && broken(!strcmp_wa(src, broken_src))), + "get_src returned %s expected %s\n", wine_dbgstr_w(src), exsrc); SysFreeString(src); } @@ -2187,8 +2188,6 @@ static void _test_img_set_src(unsigned line, IUnknown *unk, const char *src) IHTMLImgElement_Release(img); SysFreeString(tmp); ok_(__FILE__,line) (hres == S_OK, "put_src failed: %08x\n", hres); - - _test_img_src(line, unk, src); } #define test_img_alt(u,a) _test_img_alt(__LINE__,u,a) @@ -6574,8 +6573,9 @@ static void test_elems(IHTMLDocument2 *doc) elem = get_elem_by_id(doc, "imgid", TRUE); if(elem) { - test_img_src((IUnknown*)elem, ""); + test_img_src((IUnknown*)elem, "", NULL); test_img_set_src((IUnknown*)elem, "about:blank"); + test_img_src((IUnknown*)elem, "about:blank", NULL); test_img_alt((IUnknown*)elem, NULL); test_img_set_alt((IUnknown*)elem, "alt test"); test_img_name((IUnknown*)elem, "WineImg"); @@ -6852,6 +6852,31 @@ static void test_attr(IHTMLElement *elem) IHTMLDOMAttribute_Release(attr); } +static void test_blocked(IHTMLDocument2 *doc, IHTMLElement *outer_elem) +{ + IHTMLElement *elem; + + test_elem_set_innerhtml((IUnknown*)outer_elem, + "<img id=\"imgid\" src=\"
BLOCKED::http://www.winehq.org/img.png\
" />"); + elem = get_elem_by_id(doc, "imgid", TRUE); + if(elem) { + test_img_src((IUnknown*)elem, "BLOCKED::", "
blocked::http://www.winehq.org/img.png
"); + IHTMLElement_Release(elem); + } + + test_elem_set_innerhtml((IUnknown*)outer_elem, + "<img id=\"imgid\" src=\"
BLOCKE::http://www.winehq.org/img.png\
" />"); + elem = get_elem_by_id(doc, "imgid", TRUE); + if(elem) { + test_img_src((IUnknown*)elem, "
blocke::http://www.winehq.org/img.png
", NULL); + test_img_set_src((IUnknown*)elem, "
BLOCKED:http://www.winehq.org/img.png
"); + test_img_src((IUnknown*)elem, "
blocked:http://www.winehq.org/img.png
", NULL); + test_img_set_src((IUnknown*)elem, "
blocked::http://www.winehq.org/img.png
"); + test_img_src((IUnknown*)elem, "BLOCKED::", "
blocked::http://www.winehq.org/img.png
"); + IHTMLElement_Release(elem); + } +} + static void test_elems2(IHTMLDocument2 *doc) { IHTMLElement *elem, *elem2, *div; @@ -6913,6 +6938,7 @@ static void test_elems2(IHTMLDocument2 *doc) test_attr(div); test_style_filters(div); + test_blocked(doc, div); IHTMLElement_Release(div); }
1
0
0
0
Jacek Caban : mshtml: Reimplement nsIURI::SetScheme on top of IUri.
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: cdb7bc451b942be8e783c29ca9113af774e4088b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=cdb7bc451b942be8e783c29ca…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Mar 14 14:06:37 2011 +0100 mshtml: Reimplement nsIURI::SetScheme on top of IUri. --- dlls/mshtml/nsio.c | 23 +++++++++++++++++------ 1 files changed, 17 insertions(+), 6 deletions(-) diff --git a/dlls/mshtml/nsio.c b/dlls/mshtml/nsio.c index 327b191..016356d 100644 --- a/dlls/mshtml/nsio.c +++ b/dlls/mshtml/nsio.c @@ -1725,16 +1725,27 @@ static nsresult NSAPI nsURI_GetScheme(nsIURL *iface, nsACString *aScheme) static nsresult NSAPI nsURI_SetScheme(nsIURL *iface, const nsACString *aScheme) { nsWineURI *This = impl_from_nsIURL(iface); + const char *schemea; + WCHAR *scheme; + HRESULT hres; TRACE("(%p)->(%s)\n", This, debugstr_nsacstr(aScheme)); - if(This->nsuri) { - invalidate_uri(This); - return nsIURI_SetScheme(This->nsuri, aScheme); - } + if(!ensure_uri_builder(This)) + return NS_ERROR_UNEXPECTED; - FIXME("default action not implemented\n"); - return NS_ERROR_NOT_IMPLEMENTED; + nsACString_GetData(aScheme, &schemea); + scheme = heap_strdupAtoW(schemea); + if(!scheme) + return NS_ERROR_OUT_OF_MEMORY; + + hres = IUriBuilder_SetSchemeName(This->uri_builder, scheme); + heap_free(scheme); + if(FAILED(hres)) + return NS_ERROR_UNEXPECTED; + + sync_wine_url(This); + return NS_OK; } static nsresult NSAPI nsURI_GetUserPass(nsIURL *iface, nsACString *aUserPass)
1
0
0
0
Alexandre Julliard : configure: Improve check for security framework and don' t warn about gnutls in that case.
by Alexandre Julliard
14 Mar '11
14 Mar '11
Module: wine Branch: master Commit: 45db3481f4d9ef7290eab9c2d29e5e3904cd16ef URL:
http://source.winehq.org/git/wine.git/?a=commit;h=45db3481f4d9ef7290eab9c2d…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Mar 14 14:25:45 2011 +0100 configure: Improve check for security framework and don't warn about gnutls in that case. --- configure | 12 ++++++++---- configure.ac | 6 +++++- dlls/crypt32/rootstore.c | 4 ++-- 3 files changed, 15 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 3651711..8790041 100755 --- a/configure +++ b/configure @@ -657,12 +657,12 @@ QUICKTIMELIB LIBOPENCL FRAMEWORK_OPENAL COREAUDIO +SECURITYLIB DISKARBITRATIONLIB LDEXECFLAGS APPLICATIONSERVICESLIB IOKITLIB COREFOUNDATIONLIB -SECURITYLIB DLLWRAP DLLTOOL LDD @@ -6519,9 +6519,7 @@ fi LDSHARED="\$(CC) -dynamiclib" STRIP="$STRIP -x" LDRPATH_LOCAL="&& install_name_tool -change @executable_path/\`\$(RELPATH) \$(bindir) \$(libdir)\`/libwine.1.dylib @executable_path/\$(top_builddir)/libs/wine/libwine.1.dylib \$@ || \$(RM) \$@" - SECURITYLIB="-framework Security -framework CoreFoundation" - - COREFOUNDATIONLIB="-framework CoreFoundation" + COREFOUNDATIONLIB="-framework CoreFoundation" IOKITLIB="-framework IOKit -framework CoreFoundation" @@ -6534,6 +6532,12 @@ fi DISKARBITRATIONLIB="-framework DiskArbitration -framework CoreFoundation" fi + if test "$ac_cv_header_Security_Security_h" = "yes" + then + SECURITYLIB="-framework Security -framework CoreFoundation" + + with_gnutls=${with_gnutls:-no} + fi if test "$ac_cv_header_CoreAudio_CoreAudio_h" = "yes" -a "$ac_cv_header_AudioUnit_AudioUnit_h" = "yes" then if test "$ac_cv_header_AudioUnit_AudioComponent_h" = "yes" diff --git a/configure.ac b/configure.ac index 8314579..b16b9e9 100644 --- a/configure.ac +++ b/configure.ac @@ -703,7 +703,6 @@ case $host_os in STRIP="$STRIP -x" LDRPATH_LOCAL="&& install_name_tool -change @executable_path/\`\$(RELPATH) \$(bindir) \$(libdir)\`/libwine.1.dylib @executable_path/\$(top_builddir)/libs/wine/libwine.1.dylib \$@ || \$(RM) \$@" dnl declare needed frameworks - AC_SUBST(SECURITYLIB,"-framework Security -framework CoreFoundation") AC_SUBST(COREFOUNDATIONLIB,"-framework CoreFoundation") AC_SUBST(IOKITLIB,"-framework IOKit -framework CoreFoundation") AC_SUBST(APPLICATIONSERVICESLIB,"-framework ApplicationServices") @@ -713,6 +712,11 @@ case $host_os in dnl DiskArbitration API is not public on Darwin < 8.0, use it only if header found AC_SUBST(DISKARBITRATIONLIB,"-framework DiskArbitration -framework CoreFoundation") fi + if test "$ac_cv_header_Security_Security_h" = "yes" + then + AC_SUBST(SECURITYLIB,"-framework Security -framework CoreFoundation") + with_gnutls=${with_gnutls:-no} + fi if test "$ac_cv_header_CoreAudio_CoreAudio_h" = "yes" -a "$ac_cv_header_AudioUnit_AudioUnit_h" = "yes" then if test "$ac_cv_header_AudioUnit_AudioComponent_h" = "yes" diff --git a/dlls/crypt32/rootstore.c b/dlls/crypt32/rootstore.c index 506497a..c6f106e 100644 --- a/dlls/crypt32/rootstore.c +++ b/dlls/crypt32/rootstore.c @@ -40,7 +40,7 @@ #include "winternl.h" #include "wine/debug.h" #include "crypt32_private.h" -#ifdef __APPLE__ +#ifdef HAVE_SECURITY_SECURITY_H #include <Security/Security.h> #endif @@ -746,7 +746,7 @@ static void read_trusted_roots_from_known_locations(HCERTSTORE store) DWORD i; BOOL ret = FALSE; -#ifdef __APPLE__ +#ifdef HAVE_SECURITY_SECURITY_H OSStatus status; CFArrayRef rootCerts;
1
0
0
0
← Newer
1
...
41
42
43
44
45
46
47
...
85
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
Results per page:
10
25
50
100
200