wine-commits March 2011

wine-commits@winehq.org

2 participants
849 discussions

Alexandre Julliard : gdi32: Move all the metafile DC setting functions to mfdrv/dc.c
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: 7d1dd28d25e8d7dd2494022d17434eb5a9234549 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7d1dd28d25e8d7dd2494022d1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Mar 11 12:03:41 2011 +0100 gdi32: Move all the metafile DC setting functions to mfdrv/dc.c --- dlls/gdi32/Makefile.in | 1 - dlls/gdi32/mfdrv/dc.c | 64 +++++++++++++++++++++++-- dlls/gdi32/mfdrv/graphics.c | 22 --------- dlls/gdi32/mfdrv/mapping.c | 107 ------------------------------------------- 4 files changed, 58 insertions(+), 136 deletions(-) diff --git a/dlls/gdi32/Makefile.in b/dlls/gdi32/Makefile.in index 0de8477..45740b1 100644 --- a/dlls/gdi32/Makefile.in +++ b/dlls/gdi32/Makefile.in @@ -32,7 +32,6 @@ C_SRCS = \ mfdrv/dc.c \ mfdrv/graphics.c \ mfdrv/init.c \ - mfdrv/mapping.c \ mfdrv/objects.c \ mfdrv/text.c \ opengl.c \ diff --git a/dlls/gdi32/mfdrv/dc.c b/dlls/gdi32/mfdrv/dc.c index 4929f0d..fb66d2b 100644 --- a/dlls/gdi32/mfdrv/dc.c +++ b/dlls/gdi32/mfdrv/dc.c @@ -40,6 +40,16 @@ INT CDECL MFDRV_SetBkMode( PHYSDEV dev, INT mode ) return MFDRV_MetaParam1( dev, META_SETBKMODE, (WORD)mode) ? mode : 0; } +COLORREF CDECL MFDRV_SetBkColor( PHYSDEV dev, COLORREF color ) +{ + return MFDRV_MetaParam2(dev, META_SETBKCOLOR, HIWORD(color), LOWORD(color)) ? color : CLR_INVALID; +} + +COLORREF CDECL MFDRV_SetTextColor( PHYSDEV dev, COLORREF color ) +{ + return MFDRV_MetaParam2(dev, META_SETTEXTCOLOR, HIWORD(color), LOWORD(color)) ? color : CLR_INVALID; +} + INT CDECL MFDRV_SetROP2( PHYSDEV dev, INT rop ) { return MFDRV_MetaParam1( dev, META_SETROP2, (WORD)rop) ? rop : 0; @@ -62,14 +72,12 @@ INT CDECL MFDRV_SetStretchBltMode( PHYSDEV dev, INT mode ) INT CDECL MFDRV_IntersectClipRect( PHYSDEV dev, INT left, INT top, INT right, INT bottom ) { - return MFDRV_MetaParam4( dev, META_INTERSECTCLIPRECT, left, top, right, - bottom ); + return MFDRV_MetaParam4( dev, META_INTERSECTCLIPRECT, left, top, right, bottom ); } INT CDECL MFDRV_ExcludeClipRect( PHYSDEV dev, INT left, INT top, INT right, INT bottom ) { - return MFDRV_MetaParam4( dev, META_EXCLUDECLIPRECT, left, top, right, - bottom ); + return MFDRV_MetaParam4( dev, META_EXCLUDECLIPRECT, left, top, right, bottom ); } INT CDECL MFDRV_OffsetClipRgn( PHYSDEV dev, INT x, INT y ) @@ -77,6 +85,51 @@ INT CDECL MFDRV_OffsetClipRgn( PHYSDEV dev, INT x, INT y ) return MFDRV_MetaParam2( dev, META_OFFSETCLIPRGN, x, y ); } +INT CDECL MFDRV_SetMapMode( PHYSDEV dev, INT mode ) +{ + return MFDRV_MetaParam1( dev, META_SETMAPMODE, mode ); +} + +BOOL CDECL MFDRV_SetViewportExtEx( PHYSDEV dev, INT x, INT y, SIZE *size ) +{ + return MFDRV_MetaParam2( dev, META_SETVIEWPORTEXT, x, y ); +} + +BOOL CDECL MFDRV_SetViewportOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) +{ + return MFDRV_MetaParam2( dev, META_SETVIEWPORTORG, x, y ); +} + +BOOL CDECL MFDRV_SetWindowExtEx( PHYSDEV dev, INT x, INT y, SIZE *size ) +{ + return MFDRV_MetaParam2( dev, META_SETWINDOWEXT, x, y ); +} + +BOOL CDECL MFDRV_SetWindowOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) +{ + return MFDRV_MetaParam2( dev, META_SETWINDOWORG, x, y ); +} + +BOOL CDECL MFDRV_OffsetViewportOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) +{ + return MFDRV_MetaParam2( dev, META_OFFSETVIEWPORTORG, x, y ); +} + +BOOL CDECL MFDRV_OffsetWindowOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) +{ + return MFDRV_MetaParam2( dev, META_OFFSETWINDOWORG, x, y ); +} + +BOOL CDECL MFDRV_ScaleViewportExtEx( PHYSDEV dev, INT xNum, INT xDenom, INT yNum, INT yDenom, SIZE *size ) +{ + return MFDRV_MetaParam4( dev, META_SCALEVIEWPORTEXT, xNum, xDenom, yNum, yDenom ); +} + +BOOL CDECL MFDRV_ScaleWindowExtEx( PHYSDEV dev, INT xNum, INT xDenom, INT yNum, INT yDenom, SIZE *size ) +{ + return MFDRV_MetaParam4( dev, META_SCALEWINDOWEXT, xNum, xDenom, yNum, yDenom ); +} + BOOL CDECL MFDRV_SetTextJustification( PHYSDEV dev, INT extra, INT breaks ) { return MFDRV_MetaParam2( dev, META_SETTEXTJUSTIFICATION, extra, breaks ); @@ -89,8 +142,7 @@ INT CDECL MFDRV_SetTextCharacterExtra( PHYSDEV dev, INT extra ) DWORD CDECL MFDRV_SetMapperFlags( PHYSDEV dev, DWORD flags ) { - return MFDRV_MetaParam2( dev, META_SETMAPPERFLAGS, HIWORD(flags), - LOWORD(flags) ) ? flags : GDI_ERROR; + return MFDRV_MetaParam2( dev, META_SETMAPPERFLAGS, HIWORD(flags), LOWORD(flags) ) ? flags : GDI_ERROR; } BOOL CDECL MFDRV_AbortPath( PHYSDEV dev ) diff --git a/dlls/gdi32/mfdrv/graphics.c b/dlls/gdi32/mfdrv/graphics.c index e2cc6eb..0ee1b0c 100644 --- a/dlls/gdi32/mfdrv/graphics.c +++ b/dlls/gdi32/mfdrv/graphics.c @@ -430,28 +430,6 @@ INT CDECL MFDRV_ExtSelectClipRgn( PHYSDEV dev, HRGN hrgn, INT mode ) /********************************************************************** - * MFDRV_SetBkColor - */ -COLORREF CDECL -MFDRV_SetBkColor( PHYSDEV dev, COLORREF color ) -{ - return MFDRV_MetaParam2(dev, META_SETBKCOLOR, HIWORD(color), - LOWORD(color)) ? color : CLR_INVALID; -} - - -/********************************************************************** - * MFDRV_SetTextColor - */ -COLORREF CDECL -MFDRV_SetTextColor( PHYSDEV dev, COLORREF color ) -{ - return MFDRV_MetaParam2(dev, META_SETTEXTCOLOR, HIWORD(color), - LOWORD(color)) ? color : CLR_INVALID; -} - - -/********************************************************************** * MFDRV_PolyBezier * Since MetaFiles don't record Beziers and they don't even record * approximations to them using lines, we need this stub function. diff --git a/dlls/gdi32/mfdrv/mapping.c b/dlls/gdi32/mfdrv/mapping.c deleted file mode 100644 index 0b88515..0000000 --- a/dlls/gdi32/mfdrv/mapping.c +++ /dev/null @@ -1,107 +0,0 @@ -/* - * Metafile GDI mapping mode functions - * - * Copyright 1996 Alexandre Julliard - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2.1 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - */ - -#include <stdarg.h> -#include "windef.h" -#include "winbase.h" -#include "wingdi.h" -#include "gdi_private.h" -#include "mfdrv/metafiledrv.h" - - -/*********************************************************************** - * MFDRV_SetMapMode - */ -INT CDECL MFDRV_SetMapMode( PHYSDEV dev, INT mode ) -{ - return MFDRV_MetaParam1( dev, META_SETMAPMODE, mode ); -} - - -/*********************************************************************** - * MFDRV_SetViewportExtEx - */ -BOOL CDECL MFDRV_SetViewportExtEx( PHYSDEV dev, INT x, INT y, SIZE *size ) -{ - return MFDRV_MetaParam2( dev, META_SETVIEWPORTEXT, x, y ); -} - - -/*********************************************************************** - * MFDRV_SetViewportOrgEx - */ -BOOL CDECL MFDRV_SetViewportOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) -{ - return MFDRV_MetaParam2( dev, META_SETVIEWPORTORG, x, y ); -} - - -/*********************************************************************** - * MFDRV_SetWindowExtEx - */ -BOOL CDECL MFDRV_SetWindowExtEx( PHYSDEV dev, INT x, INT y, SIZE *size ) -{ - return MFDRV_MetaParam2( dev, META_SETWINDOWEXT, x, y ); -} - - -/*********************************************************************** - * MFDRV_SetWindowOrgEx - */ -BOOL CDECL MFDRV_SetWindowOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) -{ - return MFDRV_MetaParam2( dev, META_SETWINDOWORG, x, y ); -} - - -/*********************************************************************** - * MFDRV_OffsetViewportOrgEx - */ -BOOL CDECL MFDRV_OffsetViewportOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) -{ - return MFDRV_MetaParam2( dev, META_OFFSETVIEWPORTORG, x, y ); -} - - -/*********************************************************************** - * MFDRV_OffsetWindowOrgEx - */ -BOOL CDECL MFDRV_OffsetWindowOrgEx( PHYSDEV dev, INT x, INT y, POINT *pt ) -{ - return MFDRV_MetaParam2( dev, META_OFFSETWINDOWORG, x, y ); -} - - -/*********************************************************************** - * MFDRV_ScaleViewportExtEx - */ -BOOL CDECL MFDRV_ScaleViewportExtEx( PHYSDEV dev, INT xNum, INT xDenom, INT yNum, INT yDenom, SIZE *size ) -{ - return MFDRV_MetaParam4( dev, META_SCALEVIEWPORTEXT, xNum, xDenom, yNum, yDenom ); -} - - -/*********************************************************************** - * MFDRV_ScaleWindowExtEx - */ -BOOL CDECL MFDRV_ScaleWindowExtEx( PHYSDEV dev, INT xNum, INT xDenom, INT yNum, INT yDenom, SIZE *size ) -{ - return MFDRV_MetaParam4( dev, META_SCALEWINDOWEXT, xNum, xDenom, yNum, yDenom ); -}

1 0

Huw Davies : fonts: Increase the version number so that we don' t use the Mac's version of symbol.ttf, which doesn' t contain a Microsoft Symbol charmap.
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: 47dee8bda21de80077261cc11bba53adc02a9d19 URL: http://source.winehq.org/git/wine.git/?a=commit;h=47dee8bda21de80077261cc11… Author: Huw Davies <huw(a)codeweavers.com> Date: Fri Mar 11 09:49:34 2011 +0000 fonts: Increase the version number so that we don't use the Mac's version of symbol.ttf, which doesn't contain a Microsoft Symbol charmap. --- fonts/symbol.sfd | 2 +- fonts/symbol.ttf | Bin 26040 -> 26040 bytes 2 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fonts/symbol.sfd b/fonts/symbol.sfd index bf34606..44b6302 100644 --- a/fonts/symbol.sfd +++ b/fonts/symbol.sfd @@ -4,7 +4,7 @@ FullName: Symbol FamilyName: Symbol Weight: Book Copyright: WineSymbol © (Jon Parshall for CodeWeavers). 2009. -Version: 0.001 February 3, 2009, initial release +Version: 1.1 February 3, 2009, initial release ItalicAngle: 0 UnderlinePosition: -173 UnderlineWidth: 100 diff --git a/fonts/symbol.ttf b/fonts/symbol.ttf index b0a3fc1..bb54fb8 100644 Binary files a/fonts/symbol.ttf and b/fonts/symbol.ttf differ

1 0

Michael Stefaniuc : shdocvw: COM cleanup for the ITaskbarList iface.
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: 4f382430f2176bc576c80e89c8324107278c0ed6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f382430f2176bc576c80e89c… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Mar 11 11:39:07 2011 +0100 shdocvw: COM cleanup for the ITaskbarList iface. --- dlls/shdocvw/taskbarlist.c | 15 ++++++++++----- 1 files changed, 10 insertions(+), 5 deletions(-) diff --git a/dlls/shdocvw/taskbarlist.c b/dlls/shdocvw/taskbarlist.c index 2c38080..d853506 100644 --- a/dlls/shdocvw/taskbarlist.c +++ b/dlls/shdocvw/taskbarlist.c @@ -27,10 +27,15 @@ WINE_DEFAULT_DEBUG_CHANNEL(shdocvw); struct taskbar_list { - const struct ITaskbarListVtbl *lpVtbl; + ITaskbarList ITaskbarList_iface; LONG refcount; }; +static inline struct taskbar_list *impl_from_ITaskbarList(ITaskbarList *iface) +{ + return CONTAINING_RECORD(iface, struct taskbar_list, ITaskbarList_iface); +} + /* IUnknown methods */ static HRESULT STDMETHODCALLTYPE taskbar_list_QueryInterface(ITaskbarList *iface, REFIID riid, void **object) @@ -53,7 +58,7 @@ static HRESULT STDMETHODCALLTYPE taskbar_list_QueryInterface(ITaskbarList *iface static ULONG STDMETHODCALLTYPE taskbar_list_AddRef(ITaskbarList *iface) { - struct taskbar_list *This = (struct taskbar_list *)iface; + struct taskbar_list *This = impl_from_ITaskbarList(iface); ULONG refcount = InterlockedIncrement(&This->refcount); TRACE("%p increasing refcount to %u\n", This, refcount); @@ -63,7 +68,7 @@ static ULONG STDMETHODCALLTYPE taskbar_list_AddRef(ITaskbarList *iface) static ULONG STDMETHODCALLTYPE taskbar_list_Release(ITaskbarList *iface) { - struct taskbar_list *This = (struct taskbar_list *)iface; + struct taskbar_list *This = impl_from_ITaskbarList(iface); ULONG refcount = InterlockedDecrement(&This->refcount); TRACE("%p decreasing refcount to %u\n", This, refcount); @@ -150,12 +155,12 @@ HRESULT TaskbarList_Create(IUnknown *outer, REFIID riid, void **taskbar_list) return E_OUTOFMEMORY; } - object->lpVtbl = &taskbar_list_vtbl; + object->ITaskbarList_iface.lpVtbl = &taskbar_list_vtbl; object->refcount = 0; TRACE("Created ITaskbarList %p\n", object); - hr = ITaskbarList_QueryInterface((ITaskbarList *)object, riid, taskbar_list); + hr = ITaskbarList_QueryInterface(&object->ITaskbarList_iface, riid, taskbar_list); if (FAILED(hr)) { HeapFree(GetProcessHeap(), 0, object);

1 0

Piotr Caban : mshtml: Execute IDocObject_FireDocumentComplete in handle_load function.
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: 98281236c0293c490ce7b35c747aff3e49d71318 URL: http://source.winehq.org/git/wine.git/?a=commit;h=98281236c0293c490ce7b35c7… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Mar 11 11:14:18 2011 +0100 mshtml: Execute IDocObject_FireDocumentComplete in handle_load function. --- dlls/mshtml/mshtml_private.h | 4 ++++ dlls/mshtml/nsevents.c | 4 ++++ dlls/mshtml/oleobj.c | 28 ++++++++++++++++++++++++++-- 3 files changed, 34 insertions(+), 2 deletions(-) diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 11ab878..84596fe 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -18,6 +18,7 @@ #include "wingdi.h" #include "docobj.h" +#include "docobjectservice.h" #include "comcat.h" #include "mshtml.h" #include "mshtmhst.h" @@ -424,6 +425,7 @@ struct HTMLDocumentObj { IOleInPlaceFrame *frame; IOleInPlaceUIWindow *ip_window; IAdviseSink *view_sink; + IDocObjectService *doc_object_service; DOCHOSTUIINFO hostinfo; @@ -882,6 +884,8 @@ DEFINE_GUID(CLSID_SysimageProtocol, 0x76E67A63, 0x06E9, 0x11D2, 0xA8,0x40, 0x00, DEFINE_GUID(CLSID_CMarkup,0x3050f4fb,0x98b5,0x11cf,0xbb,0x82,0x00,0xaa,0x00,0xbd,0xce,0x0b); +DEFINE_OLEGUID(CGID_DocHostCmdPriv, 0x000214D4L, 0, 0); + /* memory allocation functions */ static inline void * __WINE_ALLOC_SIZE(1) heap_alloc(size_t len) diff --git a/dlls/mshtml/nsevents.c b/dlls/mshtml/nsevents.c index f6a1ed6..957b892 100644 --- a/dlls/mshtml/nsevents.c +++ b/dlls/mshtml/nsevents.c @@ -254,6 +254,10 @@ static nsresult NSAPI handle_load(nsIDOMEventListener *iface, nsIDOMEvent *event update_title(doc_obj); } + if(doc_obj && doc_obj->doc_object_service) + IDocObjectService_FireDocumentComplete(doc_obj->doc_object_service, + &doc->basedoc.window->IHTMLWindow2_iface, 0); + if(!doc->nsdoc) { ERR("NULL nsdoc\n"); return NS_ERROR_FAILURE; diff --git a/dlls/mshtml/oleobj.c b/dlls/mshtml/oleobj.c index f8a84ac..d80db20 100644 --- a/dlls/mshtml/oleobj.c +++ b/dlls/mshtml/oleobj.c @@ -28,17 +28,16 @@ #include "winuser.h" #include "ole2.h" #include "shlguid.h" +#include "shdeprecated.h" #include "mshtmdid.h" #include "idispids.h" #include "wine/debug.h" #include "mshtml_private.h" -#include "initguid.h" WINE_DEFAULT_DEBUG_CHANNEL(mshtml); -DEFINE_OLEGUID(CGID_DocHostCmdPriv, 0x000214D4L, 0, 0); #define DOCHOST_DOCCANNAVIGATE 0 /********************************************************** @@ -99,6 +98,7 @@ static HRESULT WINAPI OleObject_SetClientSite(IOleObject *iface, IOleClientSite HTMLDocument *This = impl_from_IOleObject(iface); IOleCommandTarget *cmdtrg = NULL; IOleWindow *ole_window; + IServiceProvider *sp; BOOL hostui_setup; VARIANT silent; HWND hwnd; @@ -120,6 +120,11 @@ static HRESULT WINAPI OleObject_SetClientSite(IOleObject *iface, IOleClientSite This->doc_obj->hostui = NULL; } + if(This->doc_obj->doc_object_service) { + IDocObjectService_Release(This->doc_obj->doc_object_service); + This->doc_obj->doc_object_service = NULL; + } + memset(&This->doc_obj->hostinfo, 0, sizeof(DOCHOSTUIINFO)); if(!pClientSite) @@ -128,6 +133,25 @@ static HRESULT WINAPI OleObject_SetClientSite(IOleObject *iface, IOleClientSite IOleClientSite_AddRef(pClientSite); This->doc_obj->client = pClientSite; + hres = IOleClientSite_QueryInterface(pClientSite, &IID_IServiceProvider, (void**)&sp); + if(SUCCEEDED(hres)) { + IBrowserService *browser_service; + IDocObjectService *doc_object_service; + + hres = IServiceProvider_QueryService(sp, &IID_IShellBrowser, + &IID_IBrowserService, (void**)&browser_service); + if(SUCCEEDED(hres)) { + hres = IBrowserService_QueryInterface(browser_service, + &IID_IDocObjectService, (void**)&doc_object_service); + if(SUCCEEDED(hres)) + This->doc_obj->doc_object_service = doc_object_service; + + IBrowserService_Release(browser_service); + } + + IServiceProvider_Release(sp); + } + hostui_setup = This->doc_obj->hostui_setup; if(!This->doc_obj->hostui) {

1 0

Piotr Caban : mshtml: Added IHTMLPrivateWindow_GetAddressBarUrl implementation.
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: 12b85befc0bc211d1af51b54eea6c13d24ec6171 URL: http://source.winehq.org/git/wine.git/?a=commit;h=12b85befc0bc211d1af51b54e… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Mar 11 11:14:08 2011 +0100 mshtml: Added IHTMLPrivateWindow_GetAddressBarUrl implementation. --- dlls/mshtml/htmlwindow.c | 9 +++++++-- dlls/mshtml/tests/htmldoc.c | 14 ++++++++++++-- 2 files changed, 19 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 99d03b3..0e42021 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -1777,8 +1777,13 @@ static HRESULT WINAPI HTMLPrivateWindow_FindWindowByName(IHTMLPrivateWindow *ifa static HRESULT WINAPI HTMLPrivateWindow_GetAddressBar(IHTMLPrivateWindow *iface, BSTR *url) { HTMLWindow *This = impl_from_IHTMLPrivateWindow(iface); - FIXME("(%p)->(%p)\n", This, url); - return E_NOTIMPL; + TRACE("(%p)->(%p)\n", This, url); + + if(!url) + return E_INVALIDARG; + + *url = SysAllocString(This->url); + return S_OK; } static const IHTMLPrivateWindowVtbl HTMLPrivateWindowVtbl = { diff --git a/dlls/mshtml/tests/htmldoc.c b/dlls/mshtml/tests/htmldoc.c index ab5e17b..11b2036 100644 --- a/dlls/mshtml/tests/htmldoc.c +++ b/dlls/mshtml/tests/htmldoc.c @@ -3533,7 +3533,6 @@ static void test_put_href(IHTMLDocument2 *doc, BOOL use_replace) str2 = a2bstr(""); V_VT(&vempty) = VT_EMPTY; hres = IHTMLPrivateWindow_SuperNavigate(priv_window, str, str2, NULL, NULL, &vempty, &vempty, 0); - SysFreeString(str); SysFreeString(str2); ok(hres == S_OK, "SuperNavigate failed: %08x\n", hres); @@ -3548,9 +3547,20 @@ static void test_put_href(IHTMLDocument2 *doc, BOOL use_replace) test_GetCurMoniker(doc_unk, doc_mon, NULL); doc_mon = NULL; } - IHTMLPrivateWindow_Release(priv_window); + hres = IHTMLPrivateWindow_GetAddressBarUrl(priv_window, &str2); + ok(hres == S_OK, "GetAddressBarUrl failed: %08x\n", hres); + ok(!strcmp_wa(str2, use_replace?"about:blank":"http://www.winehq.org/"), + "unexpected address bar url: %s\n", wine_dbgstr_w(str2)); + SysFreeString(str2); test_download(DWL_VERBDONE); + + hres = IHTMLPrivateWindow_GetAddressBarUrl(priv_window, &str2); + ok(hres == S_OK, "GetAddressBarUrl failed: %08x\n", hres); + ok(!lstrcmpW(str2, str), "unexpected address bar url: %s\n", wine_dbgstr_w(str2)); + SysFreeString(str2); + SysFreeString(str); + IHTMLPrivateWindow_Release(priv_window); } static void test_open_window(IHTMLDocument2 *doc)

1 0

Piotr Caban : include: Added IDocObjectService interface definition.
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: 3660bf72a75ba614c0eddd1ec520ce98513de32d URL: http://source.winehq.org/git/wine.git/?a=commit;h=3660bf72a75ba614c0eddd1ec… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Mar 11 11:13:58 2011 +0100 include: Added IDocObjectService interface definition. --- .gitignore | 1 + dlls/uuid/uuid.c | 1 + include/Makefile.in | 1 + include/docobjectservice.idl | 67 ++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 70 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 0a6a589..84bddc8 100644 --- a/.gitignore +++ b/.gitignore @@ -167,6 +167,7 @@ include/devicetopology.h include/dimm.h include/dispex.h include/docobj.h +include/docobjectservice.h include/downloadmgr.h include/dxgi.h include/dxgitype.h diff --git a/dlls/uuid/uuid.c b/dlls/uuid/uuid.c index 8df7334..d4ad2ae 100644 --- a/dlls/uuid/uuid.c +++ b/dlls/uuid/uuid.c @@ -62,6 +62,7 @@ DEFINE_GUID(GUID_NULL,0,0,0,0,0,0,0,0,0,0,0); #include "mlang.h" #include "mshtml.h" #include "mshtmhst.h" +#include "docobjectservice.h" #include "richole.h" #include "downloadmgr.h" #include "objsel.h" diff --git a/include/Makefile.in b/include/Makefile.in index e5c2b53..e677f38 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -30,6 +30,7 @@ PUBLIC_IDL_H_SRCS = \ dimm.idl \ dispex.idl \ docobj.idl \ + docobjectservice.idl \ downloadmgr.idl \ dxgi.idl \ dxgitype.idl \ diff --git a/include/docobjectservice.idl b/include/docobjectservice.idl new file mode 100644 index 0000000..7478551 --- /dev/null +++ b/include/docobjectservice.idl @@ -0,0 +1,67 @@ +/* + * Copyright 2011 Piotr Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +import "objidl.idl"; +import "mshtml.idl"; + +[ + local, + object, + uuid(3050f801-98b5-11cf-bb82-00aa00bdce0b) +] +interface IDocObjectService : IUnknown +{ + HRESULT FireBeforeNavigate2( + [in] IDispatch *pDispatch, + [in] LPCWSTR lpszUrl, + [in] DWORD dwFlags, + [in] LPCWSTR lpszFrameName, + [in] BYTE *pPostData, + [in] DWORD cbPostData, + [in] LPCWSTR lpszHeaders, + [in] BOOL fPlayNavSound, + [out] BOOL *pfCancel); + + HRESULT FireNavigateComplete2( + [in] IHTMLWindow2 *pHTMLWindow2, + [in] DWORD dwFlags); + + HRESULT FireDownloadBegin(void); + + HRESULT FireDownloadComplete(void); + + HRESULT FireDocumentComplete( + [in] IHTMLWindow2 *pHTMLWindow, + [in] DWORD dwFlags); + + HRESULT UpdateDesktopComponent( + [in] IHTMLWindow2 *pHTMLWindow); + + HRESULT GetPendingUrl( + [out] BSTR *pbstrPendingUrl); + + HRESULT ActiveElementChanged( + [in] IHTMLElement *pHTMLElement); + + HRESULT GetUrlSearchComponent( + [out] BSTR *pbstrSearch); + + HRESULT IsErrorUrl( + [in] LPCWSTR lpszUrl, + [out] BOOL *pfIsError); +};

1 0

Piotr Caban : include: Added IBrowserService interface definition.
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: 457368897f25cef6d50e2e548643e352d63cbd04 URL: http://source.winehq.org/git/wine.git/?a=commit;h=457368897f25cef6d50e2e548… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Mar 11 11:13:39 2011 +0100 include: Added IBrowserService interface definition. --- include/shdeprecated.idl | 245 ++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 245 insertions(+), 0 deletions(-) diff --git a/include/shdeprecated.idl b/include/shdeprecated.idl index 304b087..c78e461 100644 --- a/include/shdeprecated.idl +++ b/include/shdeprecated.idl @@ -19,6 +19,251 @@ */ import "objidl.idl"; +import "ocidl.idl"; +import "shobjidl.idl"; + +cpp_quote("#define TLOG_BACK -1") +cpp_quote("#define TLOG_FORE 1") + +cpp_quote("#define TLMENUF_INCLUDECURRENT 0x00000001") +cpp_quote("#define TLMENUF_CHECKCURRENT (TLMENUF_INCLUDECURRENT | 0x00000002)") +cpp_quote("#define TLMENUF_BACK 0x00000010") +cpp_quote("#define TLMENUF_FORE 0x00000020") +cpp_quote("#define TLMENUF_BACKANDFORTH (TLMENUF_BACK | TLMENUF_FORE | TLMENUF_INCLUDECURRENT)") + +[ + hidden, + local, + object, + uuid(F46EDB3B-BC2F-11d0-9412-00AA00A3EBD3) +] +interface ITravelEntry : IUnknown +{ + HRESULT Invoke( + [in] IUnknown *punk); + + HRESULT Update( + [in] IUnknown *punk, + [in] BOOL fIsLocalAnchor); + + HRESULT GetPidl( + [out] LPITEMIDLIST *ppidl); +}; + +[ + hidden, + local, + object, + uuid(66A9CB08-4802-11d2-A561-00A0C92DBFE8) +] +interface ITravelLog : IUnknown +{ + HRESULT AddEntry( + [in] IUnknown *punk, + [in] BOOL fIsLocalAnchor); + + HRESULT UpdateEntry( + [in] IUnknown *punk, + [in] BOOL fIsLocalAnchor); + + HRESULT UpdateExternal( + [in] IUnknown *punk, + [in] IUnknown *punkHLBrowseContext); + + HRESULT Travel( + [in] IUnknown *punk, + [in] int iOffset); + + HRESULT GetTravelEntry( + [in] IUnknown *punk, + [in] int iOffset, + [optional, out] ITravelEntry **ppte); + + HRESULT FindTravelEntry( + [in] IUnknown *punk, + [in] LPCITEMIDLIST pidl, + [out] ITravelEntry **ppte); + + HRESULT GetToolTipText( + [in] IUnknown *punk, + [in] int iOffset, + [in] int idsTemplate, + [out, size_is(cchText)] LPWSTR pwzText, + [in] DWORD cchText); + + HRESULT InsertMenuEntries( + [in] IUnknown *punk, + [in] HMENU hmenu, + [in] int nPos, + [in] int idFirst, + [in] int idLast, + [in] DWORD dwFlags); + + HRESULT Clone( + [out] ITravelLog **pptl); + + DWORD CountEntries( + [in] IUnknown *punk); + + HRESULT Revert(); +}; + +typedef enum tagBNSTATE +{ + BNS_NORMAL = 0, + BNS_BEGIN_NAVIGATE = 1, + BNS_NAVIGATE = 2 + +} BNSTATE; + +enum { + SBSC_HIDE = 0, + SBSC_SHOW = 1, + SBSC_TOGGLE = 2, + SBSC_QUERY = 3 +}; + +cpp_quote("#define BSF_REGISTERASDROPTARGET 0x00000001") +cpp_quote("#define BSF_THEATERMODE 0x00000002") +cpp_quote("#define BSF_NOLOCALFILEWARNING 0x00000010") +cpp_quote("#define BSF_UISETBYAUTOMATION 0x00000100") +cpp_quote("#define BSF_RESIZABLE 0x00000200") +cpp_quote("#define BSF_CANMAXIMIZE 0x00000400") +cpp_quote("#define BSF_TOPBROWSER 0x00000800") +cpp_quote("#define BSF_NAVNOHISTORY 0x00001000") +cpp_quote("#define BSF_HTMLNAVCANCELED 0x00002000") +cpp_quote("#define BSF_DONTSHOWNAVCANCELPAGE 0x00004000") +cpp_quote("#define BSF_SETNAVIGATABLECODEPAGE 0x00008000") +cpp_quote("#define BSF_DELEGATEDNAVIGATION 0x00010000") +cpp_quote("#define BSF_TRUSTEDFORACTIVEX 0x00020000") + +cpp_quote("#define HLNF_CALLERUNTRUSTED 0x00200000") +cpp_quote("#define HLNF_TRUSTEDFORACTIVEX 0x00400000") +cpp_quote("#define HLNF_DISABLEWINDOWRESTRICTIONS 0x00800000") +cpp_quote("#define HLNF_TRUSTFIRSTDOWNLOAD 0x01000000") +cpp_quote("#define HLNF_UNTRUSTEDFORDOWNLOAD 0x02000000") +cpp_quote("#define SHHLNF_NOAUTOSELECT 0x04000000") +cpp_quote("#define SHHLNF_WRITENOHISTORY 0x08000000") +cpp_quote("#define HLNF_EXTERNALNAVIGATE 0x10000000") +cpp_quote("#define HLNF_ALLOW_AUTONAVIGATE 0x20000000") +cpp_quote("#define HLNF_NEWWINDOWSMANAGED 0x80000000") + +[ + local, + object, + uuid(02ba3b52-0547-11d1-b833-00c04fc9b31f) +] +interface IBrowserService : IUnknown +{ + HRESULT GetParentSite( + [out] IOleInPlaceSite **ppipsite); + + HRESULT SetTitle( + [in] IShellView *psv, + [in] LPCWSTR pszName); + + HRESULT GetTitle( + [in] IShellView *psv, + [out, size_is(cchName)] LPWSTR pszName, + [in] DWORD cchName); + + HRESULT GetOleObject( + [out] IOleObject **ppobjv); + + HRESULT GetTravelLog( + [out, optional] ITravelLog **pptl); + + HRESULT ShowControlWindow( + [in] UINT id, + [in] BOOL fShow); + + HRESULT IsControlWindowShown( + [in] UINT id, + [out] BOOL *pfShown); + + HRESULT IEGetDisplayName( + [in] PCIDLIST_ABSOLUTE pidl, + [out] LPWSTR pwszName, + [in] UINT uFlags); + + HRESULT IEParseDisplayName( + [in] UINT uiCP, + [in] LPCWSTR pwszPath, + [out] PIDLIST_ABSOLUTE *ppidlOut); + + HRESULT DisplayParseError( + [in] HRESULT hres, + [in] LPCWSTR pwszPath); + + HRESULT NavigateToPidl( + [in] PCIDLIST_ABSOLUTE pidl, + [in] DWORD grfHLNF); + + HRESULT SetNavigateState( + [in] BNSTATE bnstate); + + HRESULT GetNavigateState( + [out] BNSTATE *pbnstate); + + HRESULT NotifyRedirect( + [in] IShellView *psv, + [in] PCIDLIST_ABSOLUTE pidl, + [out] BOOL *pfDidBrowse); + + HRESULT UpdateWindowList(); + + HRESULT UpdateBackForwardState(); + + HRESULT SetFlags( + [in] DWORD dwFlags, + [in] DWORD dwFlagMask); + + HRESULT GetFlags( + [out] DWORD *pdwFlags); + + HRESULT CanNavigateNow(); + + HRESULT GetPidl( + [out] PIDLIST_ABSOLUTE *ppidl); + + HRESULT SetReferrer( + [in] PCIDLIST_ABSOLUTE pidl); + + DWORD GetBrowserIndex(); + + HRESULT GetBrowserByIndex( + [in] DWORD dwID, + [out] IUnknown **ppunk); + + HRESULT GetHistoryObject( + [out] IOleObject **ppole, + [out] IStream **pstm, + [out] IBindCtx **ppbc); + + HRESULT SetHistoryObject( + [in] IOleObject *pole, + [in] BOOL fIsLocalAnchor); + + HRESULT CacheOLEServer( + [in] IOleObject *pole); + + HRESULT GetSetCodePage( + [in] VARIANT *pvarIn, + [out] VARIANT *pvarOut); + + HRESULT OnHttpEquiv( + [in] IShellView *psv, + [in] BOOL fDone, + [in] VARIANT *pvarargIn, + [out] VARIANT *pvarargOut); + + HRESULT GetPalette( + [out] HPALETTE *hpal); + + HRESULT RegisterWindow( + [in] BOOL fForceRegister, + [in] int swc); +} [ object,

1 0

Nikolay Sivov : msxml3: Move string conversion helper to header.
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: fb96151b0e202a9194f9360972f69d2c7d0a482a URL: http://source.winehq.org/git/wine.git/?a=commit;h=fb96151b0e202a9194f936097… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Mar 10 22:15:09 2011 +0300 msxml3: Move string conversion helper to header. --- dlls/msxml3/domdoc.c | 7 ++-- dlls/msxml3/element.c | 12 +++--- dlls/msxml3/msxml_private.h | 85 ++++++++++++++++++++++++------------------- dlls/msxml3/node.c | 8 ++-- dlls/msxml3/nodemap.c | 20 ++-------- dlls/msxml3/schema.c | 6 ++-- dlls/msxml3/xmlelem.c | 10 +++--- 7 files changed, 73 insertions(+), 75 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=fb96151b0e202a9194f93…

1 0

Nikolay Sivov : msxml3: Fix reference counting behaviour for named map.
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: 68cc66d8000bb7b0acd13986b54a95155b434790 URL: http://source.winehq.org/git/wine.git/?a=commit;h=68cc66d8000bb7b0acd13986b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Thu Mar 10 21:56:51 2011 +0300 msxml3: Fix reference counting behaviour for named map. --- dlls/msxml3/element.c | 6 ++-- dlls/msxml3/msxml_private.h | 2 +- dlls/msxml3/nodemap.c | 46 ++++++++++-------------------------------- dlls/msxml3/tests/domdoc.c | 45 ++++++++++++++++++++++++++++++++++++++++- 4 files changed, 58 insertions(+), 41 deletions(-) diff --git a/dlls/msxml3/element.c b/dlls/msxml3/element.c index 8d81f67..4c3a9b3 100644 --- a/dlls/msxml3/element.c +++ b/dlls/msxml3/element.c @@ -314,13 +314,13 @@ static HRESULT WINAPI domelem_get_nextSibling( static HRESULT WINAPI domelem_get_attributes( IXMLDOMElement *iface, - IXMLDOMNamedNodeMap** attributeMap) + IXMLDOMNamedNodeMap** map) { domelem *This = impl_from_IXMLDOMElement( iface ); - TRACE("(%p)->(%p)\n", This, attributeMap); + TRACE("(%p)->(%p)\n", This, map); - *attributeMap = create_nodemap((IXMLDOMNode*)&This->IXMLDOMElement_iface); + *map = create_nodemap(This->node.node); return S_OK; } diff --git a/dlls/msxml3/msxml_private.h b/dlls/msxml3/msxml_private.h index 72de7ba..4e3b35b 100644 --- a/dlls/msxml3/msxml_private.h +++ b/dlls/msxml3/msxml_private.h @@ -186,7 +186,7 @@ extern IUnknown *create_pi( xmlNodePtr pi ); extern IUnknown *create_comment( xmlNodePtr comment ); extern IUnknown *create_cdata( xmlNodePtr text ); extern IXMLDOMNodeList *create_children_nodelist( xmlNodePtr ); -extern IXMLDOMNamedNodeMap *create_nodemap( IXMLDOMNode *node ); +extern IXMLDOMNamedNodeMap *create_nodemap( const xmlNodePtr ); extern IUnknown *create_doc_Implementation(void); extern IUnknown *create_doc_fragment( xmlNodePtr fragment ); extern IUnknown *create_doc_entity_ref( xmlNodePtr entity ); diff --git a/dlls/msxml3/nodemap.c b/dlls/msxml3/nodemap.c index 660eab6..20475ca 100644 --- a/dlls/msxml3/nodemap.c +++ b/dlls/msxml3/nodemap.c @@ -48,7 +48,8 @@ typedef struct _xmlnodemap IXMLDOMNamedNodeMap IXMLDOMNamedNodeMap_iface; ISupportErrorInfo ISupportErrorInfo_iface; LONG ref; - IXMLDOMNode *node; + + xmlNodePtr node; LONG iterator; } xmlnodemap; @@ -109,7 +110,7 @@ static ULONG WINAPI xmlnodemap_Release( TRACE("(%p)->(%d)\n", This, ref); if ( ref == 0 ) { - IXMLDOMNode_Release( This->node ); + xmldoc_release( This->node->doc ); heap_free( This ); } @@ -217,7 +218,6 @@ static HRESULT WINAPI xmlnodemap_setNamedItem( { xmlnodemap *This = impl_from_IXMLDOMNamedNodeMap( iface ); xmlNodePtr nodeNew; - xmlNodePtr node; xmlnode *ThisNew; TRACE("(%p)->(%p %p)\n", This, newItem, namedItem ); @@ -227,10 +227,6 @@ static HRESULT WINAPI xmlnodemap_setNamedItem( if(namedItem) *namedItem = NULL; - node = xmlNodePtr_from_domnode( This->node, 0 ); - if ( !node ) - return E_FAIL; - /* Must be an Attribute */ ThisNew = get_node_obj( newItem ); if(!ThisNew) return E_FAIL; @@ -242,7 +238,7 @@ static HRESULT WINAPI xmlnodemap_setNamedItem( if(xmldoc_remove_orphan(ThisNew->node->doc, ThisNew->node) != S_OK) WARN("%p is not an orphan of %p\n", ThisNew->node, ThisNew->node->doc); - nodeNew = xmlAddChild(node, ThisNew->node); + nodeNew = xmlAddChild(This->node, ThisNew->node); if(namedItem) *namedItem = create_node( nodeNew ); @@ -265,7 +261,6 @@ static HRESULT WINAPI xmlnodemap_get_item( IXMLDOMNode** listItem) { xmlnodemap *This = impl_from_IXMLDOMNamedNodeMap( iface ); - xmlNodePtr node; xmlAttrPtr curr; LONG attrIndex; @@ -276,8 +271,7 @@ static HRESULT WINAPI xmlnodemap_get_item( if (index < 0) return S_FALSE; - node = xmlNodePtr_from_domnode( This->node, 0 ); - curr = node->properties; + curr = This->node->properties; for (attrIndex = 0; attrIndex < index; attrIndex++) { if (curr->next == NULL) @@ -295,7 +289,6 @@ static HRESULT WINAPI xmlnodemap_get_length( IXMLDOMNamedNodeMap *iface, LONG *listLength) { - xmlNodePtr node; xmlAttrPtr first; xmlAttrPtr curr; LONG attrCount; @@ -307,11 +300,7 @@ static HRESULT WINAPI xmlnodemap_get_length( if( !listLength ) return E_INVALIDARG; - node = xmlNodePtr_from_domnode( This->node, 0 ); - if ( !node ) - return E_FAIL; - - first = node->properties; + first = This->node->properties; if (first == NULL) { *listLength = 0; return S_OK; @@ -336,7 +325,6 @@ static HRESULT WINAPI xmlnodemap_getQualifiedItem( { xmlnodemap *This = impl_from_IXMLDOMNamedNodeMap( iface ); xmlAttrPtr attr; - xmlNodePtr node; xmlChar *href; xmlChar *name; @@ -344,10 +332,6 @@ static HRESULT WINAPI xmlnodemap_getQualifiedItem( if (!baseName || !qualifiedItem) return E_INVALIDARG; - node = xmlNodePtr_from_domnode(This->node, XML_ELEMENT_NODE); - if ( !node ) - return E_FAIL; - if (namespaceURI && *namespaceURI) { href = xmlChar_from_wchar(namespaceURI); @@ -363,7 +347,7 @@ static HRESULT WINAPI xmlnodemap_getQualifiedItem( return E_OUTOFMEMORY; } - attr = xmlHasNsProp(node, name, href); + attr = xmlHasNsProp(This->node, name, href); heap_free(name); heap_free(href); @@ -387,7 +371,6 @@ static HRESULT WINAPI xmlnodemap_removeQualifiedItem( { xmlnodemap *This = impl_from_IXMLDOMNamedNodeMap( iface ); xmlAttrPtr attr; - xmlNodePtr node; xmlChar *name; xmlChar *href; @@ -395,10 +378,6 @@ static HRESULT WINAPI xmlnodemap_removeQualifiedItem( if (!baseName) return E_INVALIDARG; - node = xmlNodePtr_from_domnode( This->node, XML_ELEMENT_NODE ); - if ( !node ) - return E_FAIL; - if (namespaceURI && *namespaceURI) { href = xmlChar_from_wchar(namespaceURI); @@ -414,7 +393,7 @@ static HRESULT WINAPI xmlnodemap_removeQualifiedItem( return E_OUTOFMEMORY; } - attr = xmlHasNsProp( node, name, href ); + attr = xmlHasNsProp( This->node, name, href ); heap_free(name); heap_free(href); @@ -445,7 +424,6 @@ static HRESULT WINAPI xmlnodemap_nextNode( IXMLDOMNode** nextItem) { xmlnodemap *This = impl_from_IXMLDOMNamedNodeMap( iface ); - xmlNodePtr node; xmlAttrPtr curr; LONG attrIndex; @@ -453,8 +431,7 @@ static HRESULT WINAPI xmlnodemap_nextNode( *nextItem = NULL; - node = xmlNodePtr_from_domnode( This->node, 0 ); - curr = node->properties; + curr = This->node->properties; for (attrIndex = 0; attrIndex < This->iterator; attrIndex++) { if (curr->next == NULL) @@ -551,7 +528,7 @@ static const struct ISupportErrorInfoVtbl support_error_vtbl = support_error_InterfaceSupportsErrorInfo }; -IXMLDOMNamedNodeMap *create_nodemap( IXMLDOMNode *node ) +IXMLDOMNamedNodeMap *create_nodemap( const xmlNodePtr node ) { xmlnodemap *nodemap; @@ -565,8 +542,7 @@ IXMLDOMNamedNodeMap *create_nodemap( IXMLDOMNode *node ) nodemap->ref = 1; nodemap->iterator = 0; - IXMLDOMNode_AddRef( node ); - /* Since we AddRef a node here, we don't need to call xmldoc_add_ref() */ + xmldoc_add_ref(node->doc); return &nodemap->IXMLDOMNamedNodeMap_iface; } diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 42fd22a..370c56e 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -8329,6 +8329,7 @@ static void test_get_nodeTypeString(void) ok(!lstrcmpW(str, _bstr_(entry->string)), "got string %s, expected %s. node type %d\n", wine_dbgstr_w(str), entry->string, entry->type); SysFreeString(str); + IXMLDOMNode_Release(node); entry++; } @@ -8358,14 +8359,15 @@ static void test_get_attributes(void) const get_attributes_t *entry = get_attributes; IXMLDOMNamedNodeMap *map; IXMLDOMDocument *doc; - IXMLDOMNode *node; + IXMLDOMNode *node, *node2; VARIANT_BOOL b; HRESULT hr; BSTR str; + LONG length; doc = create_document(&IID_IXMLDOMDocument); - str = SysAllocString( szComplete3 ); + str = SysAllocString( szComplete4 ); hr = IXMLDOMDocument_loadXML(doc, str, &b); SysFreeString(str); @@ -8403,6 +8405,43 @@ static void test_get_attributes(void) IXMLDOMNode_Release(node); + /* last child is element */ + EXPECT_REF(doc, 1); + hr = IXMLDOMDocument_get_lastChild(doc, &node); + ok(hr == S_OK, "got %08x\n", hr); + EXPECT_REF(doc, 1); + + EXPECT_REF(node, 1); + hr = IXMLDOMNode_get_attributes(node, &map); + ok(hr == S_OK, "got %08x\n", hr); + EXPECT_REF(node, 1); + EXPECT_REF(doc, 1); + + EXPECT_REF(map, 1); + hr = IXMLDOMNamedNodeMap_get_item(map, 0, &node2); + ok(hr == S_OK, "got %08x\n", hr); + EXPECT_REF(node, 1); + EXPECT_REF(node2, 1); + EXPECT_REF(map, 1); + EXPECT_REF(doc, 1); + IXMLDOMNode_Release(node2); + + /* release node before map release, map still works */ + IXMLDOMNode_Release(node); + + length = 0; + hr = IXMLDOMNamedNodeMap_get_length(map, &length); + ok(hr == S_OK, "got %08x\n", hr); + ok(length == 1, "got %d\n", length); + + node2 = NULL; + hr = IXMLDOMNamedNodeMap_get_item(map, 0, &node2); + ok(hr == S_OK, "got %08x\n", hr); + EXPECT_REF(node2, 1); + IXMLDOMNode_Release(node2); + + IXMLDOMNamedNodeMap_Release(map); + while (entry->type) { VARIANT var; @@ -8423,6 +8462,8 @@ static void test_get_attributes(void) hr, entry->hr, entry->type); ok(map == NULL, "got %p\n", map); + IXMLDOMNode_Release(node); + entry++; }

1 0

Dmitry Timoshkov : winecfg: Protect from closing the root key.
by Alexandre Julliard 11 Mar '11

11 Mar '11

Module: wine Branch: master Commit: 88a4b618b1d9e0f6a9b07740a884b63f13b8edeb URL: http://source.winehq.org/git/wine.git/?a=commit;h=88a4b618b1d9e0f6a9b07740a… Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Fri Mar 11 16:04:37 2011 +0800 winecfg: Protect from closing the root key. --- programs/winecfg/winecfg.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/programs/winecfg/winecfg.c b/programs/winecfg/winecfg.c index c41d2ba..1d2ec50 100644 --- a/programs/winecfg/winecfg.c +++ b/programs/winecfg/winecfg.c @@ -113,7 +113,7 @@ static WCHAR *get_config_key (HKEY root, const WCHAR *subkey, const WCHAR *name, WINE_TRACE("subkey=%s, name=%s, def=%s\n", wine_dbgstr_w(subkey), wine_dbgstr_w(name), wine_dbgstr_w(def)); - res = RegOpenKeyW(root, subkey, &hSubKey); + res = RegOpenKeyExW(root, subkey, 0, MAXIMUM_ALLOWED, &hSubKey); if (res != ERROR_SUCCESS) { if (res == ERROR_FILE_NOT_FOUND) @@ -146,7 +146,7 @@ static WCHAR *get_config_key (HKEY root, const WCHAR *subkey, const WCHAR *name, WINE_TRACE("buffer=%s\n", wine_dbgstr_w(buffer)); end: - if (hSubKey && hSubKey != root) RegCloseKey(hSubKey); + RegCloseKey(hSubKey); return buffer; } @@ -471,7 +471,7 @@ static WCHAR **enumerate_valuesW(HKEY root, WCHAR *path) WCHAR **values = NULL; struct list *cursor; - res = RegOpenKeyW(root, path, &key); + res = RegOpenKeyExW(root, path, 0, MAXIMUM_ALLOWED, &key); if (res == ERROR_SUCCESS) { while (TRUE) @@ -641,7 +641,7 @@ static void process_setting(struct setting *s) else { WINE_TRACE("Removing %s:%s\n", wine_dbgstr_w(s->path), wine_dbgstr_w(s->name)); - if (!RegOpenKeyW( s->root, s->path, &key )) + if (!RegOpenKeyExW( s->root, s->path, 0, MAXIMUM_ALLOWED, &key )) { /* NULL name means remove that path/section entirely */ if (s->name) RegDeleteValueW( key, s->name );

1 0

← Newer
1
...
51
52
53
54
55
56
57
...
85
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2011