winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
April 2011
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
937 discussions
Start a n
N
ew thread
Andrew Eikum : winealsa.drv: Add mmdevapi driver.
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: 86e90c92af8134e1e2cd6d79aaa55e62ffe146b2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=86e90c92af8134e1e2cd6d79a…
Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Apr 22 15:25:21 2011 -0500 winealsa.drv: Add mmdevapi driver. Maarten Lankhorst also contributed to this driver. --- dlls/winealsa.drv/Makefile.in | 1 + dlls/winealsa.drv/mmdevdrv.c | 2142 +++++++++++++++++++++++++++++++++++ dlls/winealsa.drv/waveinit.c | 5 - dlls/winealsa.drv/winealsa.drv.spec | 5 + 4 files changed, 2148 insertions(+), 5 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=86e90c92af8134e1e2cd6…
1
0
0
0
Andrew Eikum : mmdevapi: Reimplement using a driver system.
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: 50140999287886e4bd441eb72741c73c8c527595 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=50140999287886e4bd441eb72…
Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Apr 22 15:25:14 2011 -0500 mmdevapi: Reimplement using a driver system. --- dlls/mmdevapi/Makefile.in | 2 - dlls/mmdevapi/alext.h | 144 ---- dlls/mmdevapi/audio.c | 1909 ------------------------------------------- dlls/mmdevapi/audiovolume.c | 11 - dlls/mmdevapi/devenum.c | 423 +++------- dlls/mmdevapi/main.c | 329 ++------ dlls/mmdevapi/mmdevapi.h | 263 +------ 7 files changed, 220 insertions(+), 2861 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=50140999287886e4bd441…
1
0
0
0
Amine Khaldi : gdi32/test: SelectObject doesn't work with palettes, use SelectPalette instead.
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: 30b8d046bab6dcc574fd68326678e7a36ade91eb URL:
http://source.winehq.org/git/wine.git/?a=commit;h=30b8d046bab6dcc574fd68326…
Author: Amine Khaldi <amine.khaldi(a)reactos.org> Date: Sun Apr 24 17:42:35 2011 +0100 gdi32/test: SelectObject doesn't work with palettes, use SelectPalette instead. --- dlls/gdi32/tests/bitmap.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c index adef035..6dd612c 100644 --- a/dlls/gdi32/tests/bitmap.c +++ b/dlls/gdi32/tests/bitmap.c @@ -792,7 +792,7 @@ static void test_dibsections(void) DeleteObject(hdib2); SelectObject(hdcmem, oldbm); - SelectObject(hdcmem, oldpal); + SelectPalette(hdcmem, oldpal, TRUE); DeleteObject(hdib); DeleteObject(hpal);
1
0
0
0
Piotr Caban : msvcrt: Removed pf_vnsprintf internal function.
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: c09f9ef498c189394e358292540277a30e0a266a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c09f9ef498c189394e3582925…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Apr 20 14:43:02 2011 +0200 msvcrt: Removed pf_vnsprintf internal function. --- dlls/msvcrt/msvcrt.h | 18 -- dlls/msvcrt/wcs.c | 677 -------------------------------------------------- 2 files changed, 0 insertions(+), 695 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=c09f9ef498c189394e358…
1
0
0
0
Piotr Caban : msvcrt: Use callback based printf in sprintf functions family .
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: bfc2f5f2a538f3d6eff7e23c129571392705c560 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bfc2f5f2a538f3d6eff7e23c1…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Apr 20 14:42:48 2011 +0200 msvcrt: Use callback based printf in sprintf functions family. --- dlls/msvcrt/printf.h | 24 ++++++++++++ dlls/msvcrt/wcs.c | 98 +++++++++++++++++++++++-------------------------- 2 files changed, 70 insertions(+), 52 deletions(-) diff --git a/dlls/msvcrt/printf.h b/dlls/msvcrt/printf.h index 90909a1..2db9b6c 100644 --- a/dlls/msvcrt/printf.h +++ b/dlls/msvcrt/printf.h @@ -35,6 +35,30 @@ typedef struct FUNC_NAME(pf_flags_t) APICHAR Format; } FUNC_NAME(pf_flags); +struct FUNC_NAME(_str_ctx) { + MSVCRT_size_t len; + APICHAR *buf; +}; + +static int FUNC_NAME(puts_clbk_str)(void *ctx, int len, const APICHAR *str) +{ + struct FUNC_NAME(_str_ctx) *out = ctx; + + if(!out->buf) + return len; + + if(out->len < len) { + memcpy(out->buf, str, out->len); + out->buf += out->len; + out->len = 0; + return -1; + } + + memcpy(out->buf, str, len*sizeof(APICHAR)); + out->buf += len; + return len; +} + static inline const APICHAR* FUNC_NAME(pf_parse_int)(const APICHAR *fmt, int *val) { *val = 0; diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c index a7cec7c..b67fba2 100644 --- a/dlls/msvcrt/wcs.c +++ b/dlls/msvcrt/wcs.c @@ -1114,40 +1114,19 @@ printf_arg arg_clbk_valist(void *ctx, int arg_pos, int type, __ms_va_list *valis } /********************************************************************* - * vsnprintf_internal (INTERNAL) - */ -static inline int vsnprintf_internal( char *str, MSVCRT_size_t len, const char *format, - MSVCRT__locale_t locale, BOOL valid, __ms_va_list valist ) -{ - DWORD sz; - LPWSTR formatW = NULL; - pf_output out; - int r; - - out.unicode = FALSE; - out.buf.A = str; - out.grow.A = NULL; - out.used = 0; - out.len = len; - - sz = MultiByteToWideChar( CP_ACP, 0, format, -1, NULL, 0 ); - formatW = HeapAlloc( GetProcessHeap(), 0, sz*sizeof(WCHAR) ); - MultiByteToWideChar( CP_ACP, 0, format, -1, formatW, sz ); - - r = pf_vsnprintf( &out, formatW, locale, valid, valist ); - - HeapFree( GetProcessHeap(), 0, formatW ); - - return r; -} - -/********************************************************************* * _vsnprintf (MSVCRT.@) */ int CDECL MSVCRT_vsnprintf( char *str, MSVCRT_size_t len, const char *format, __ms_va_list valist ) { - return vsnprintf_internal(str, len, format, NULL, FALSE, valist); + static const char nullbyte = '\0'; + struct _str_ctx_a ctx = {len, str}; + int ret; + + ret = pf_printf_a(puts_clbk_str_a, &ctx, format, NULL, FALSE, FALSE, + arg_clbk_valist, NULL, valist); + puts_clbk_str_a(&ctx, 1, &nullbyte); + return ret; } /********************************************************************* @@ -1156,7 +1135,14 @@ int CDECL MSVCRT_vsnprintf( char *str, MSVCRT_size_t len, int CDECL MSVCRT_vsnprintf_l( char *str, MSVCRT_size_t len, const char *format, MSVCRT__locale_t locale, __ms_va_list valist ) { - return vsnprintf_internal(str, len, format, locale, FALSE, valist); + static const char nullbyte = '\0'; + struct _str_ctx_a ctx = {len, str}; + int ret; + + ret = pf_printf_a(puts_clbk_str_a, &ctx, format, locale, FALSE, FALSE, + arg_clbk_valist, NULL, valist); + puts_clbk_str_a(&ctx, 1, &nullbyte); + return ret; } /********************************************************************* @@ -1166,6 +1152,8 @@ int CDECL MSVCRT_vsnprintf_s_l( char *str, MSVCRT_size_t sizeOfBuffer, MSVCRT_size_t count, const char *format, MSVCRT__locale_t locale, __ms_va_list valist ) { + static const char nullbyte = '\0'; + struct _str_ctx_a ctx; int len, ret; if(sizeOfBuffer<count+1 || count==-1) @@ -1173,7 +1161,11 @@ int CDECL MSVCRT_vsnprintf_s_l( char *str, MSVCRT_size_t sizeOfBuffer, else len = count+1; - ret = vsnprintf_internal(str, len, format, locale, TRUE, valist); + ctx.len = len; + ctx.buf = str; + ret = pf_printf_a(puts_clbk_str_a, &ctx, format, locale, FALSE, TRUE, + arg_clbk_valist, NULL, valist); + puts_clbk_str_a(&ctx, 1, &nullbyte); if(ret<0 || ret==len) { if(count!=MSVCRT__TRUNCATE && count>sizeOfBuffer) { @@ -1263,30 +1255,19 @@ int CDECL MSVCRT__scprintf(const char *format, ...) } /********************************************************************* - * vsnwprintf_internal (INTERNAL) - */ -static inline int vsnwprintf_internal(MSVCRT_wchar_t *str, MSVCRT_size_t len, - const MSVCRT_wchar_t *format, MSVCRT__locale_t locale, BOOL valid, - __ms_va_list valist) -{ - pf_output out; - - out.unicode = TRUE; - out.buf.W = str; - out.grow.W = NULL; - out.used = 0; - out.len = len; - - return pf_vsnprintf( &out, format, locale, valid, valist ); -} - -/********************************************************************* * _vsnwprintf (MSVCRT.@) */ int CDECL MSVCRT_vsnwprintf(MSVCRT_wchar_t *str, MSVCRT_size_t len, const MSVCRT_wchar_t *format, __ms_va_list valist) { - return vsnwprintf_internal(str, len, format, NULL, FALSE, valist); + static const MSVCRT_wchar_t nullbyte = '\0'; + struct _str_ctx_w ctx = {len, str}; + int ret; + + ret = pf_printf_w(puts_clbk_str_w, &ctx, format, NULL, FALSE, FALSE, + arg_clbk_valist, NULL, valist); + puts_clbk_str_w(&ctx, 1, &nullbyte); + return ret; } /********************************************************************* @@ -1296,7 +1277,14 @@ int CDECL MSVCRT_vsnwprintf_l(MSVCRT_wchar_t *str, MSVCRT_size_t len, const MSVCRT_wchar_t *format, MSVCRT__locale_t locale, __ms_va_list valist) { - return vsnwprintf_internal(str, len, format, locale, FALSE, valist); + static const MSVCRT_wchar_t nullbyte = '\0'; + struct _str_ctx_w ctx = {len, str}; + int ret; + + ret = pf_printf_w(puts_clbk_str_w, &ctx, format, locale, FALSE, FALSE, + arg_clbk_valist, NULL, valist); + puts_clbk_str_w(&ctx, 1, &nullbyte); + return ret; } /********************************************************************* @@ -1306,13 +1294,19 @@ int CDECL MSVCRT_vsnwprintf_s_l( MSVCRT_wchar_t *str, MSVCRT_size_t sizeOfBuffer MSVCRT_size_t count, const MSVCRT_wchar_t *format, MSVCRT__locale_t locale, __ms_va_list valist) { + static const MSVCRT_wchar_t nullbyte = '\0'; + struct _str_ctx_w ctx; int len, ret; len = sizeOfBuffer; if(count!=-1 && len>count+1) len = count+1; - ret = vsnwprintf_internal(str, len, format, locale, TRUE, valist); + ctx.len = len; + ctx.buf = str; + ret = pf_printf_w(puts_clbk_str_w, &ctx, format, locale, FALSE, TRUE, + arg_clbk_valist, NULL, valist); + puts_clbk_str_w(&ctx, 1, &nullbyte); if(ret<0 || ret==len) { if(count!=MSVCRT__TRUNCATE && count>sizeOfBuffer) {
1
0
0
0
Piotr Caban : msvcrt: Use callback based printf in fprintf functions family .
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: b9e456aa7976f6dde080fe8eae3435e4dcb4886b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=b9e456aa7976f6dde080fe8ea…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Apr 20 14:42:36 2011 +0200 msvcrt: Use callback based printf in fprintf functions family. --- dlls/msvcrt/file.c | 118 ++++++++++------------------------------------------ 1 files changed, 22 insertions(+), 96 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index e34c11f..30613ca 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -3379,37 +3379,22 @@ MSVCRT_FILE* CDECL MSVCRT_tmpfile(void) return file; } +static int puts_clbk_file_a(void *file, int len, const char *str) +{ + return MSVCRT_fwrite(str, sizeof(char), len, file); +} + +static int puts_clbk_file_w(void *file, int len, const MSVCRT_wchar_t *str) +{ + return MSVCRT_fwrite(str, sizeof(MSVCRT_wchar_t), len, file); +} + /********************************************************************* * vfprintf (MSVCRT.@) */ int CDECL MSVCRT_vfprintf(MSVCRT_FILE* file, const char *format, __ms_va_list valist) { - char buf[2048]; - LPWSTR formatW = NULL; - DWORD sz; - pf_output out; - int written, retval; - - out.unicode = FALSE; - out.buf.A = out.grow.A = buf; - out.used = 0; - out.len = sizeof(buf); - - sz = MultiByteToWideChar( CP_ACP, 0, format, -1, NULL, 0 ); - formatW = HeapAlloc( GetProcessHeap(), 0, sz*sizeof(WCHAR) ); - MultiByteToWideChar( CP_ACP, 0, format, -1, formatW, sz ); - - if ((written = pf_vsnprintf( &out, formatW, NULL, FALSE, valist )) >= 0) - { - retval = MSVCRT_fwrite(out.buf.A, sizeof(*out.buf.A), written, file); - } - else retval = -1; - - HeapFree( GetProcessHeap(), 0, formatW ); - - if (out.buf.A != out.grow.A) - MSVCRT_free (out.buf.A); - return retval; + return pf_printf_a(puts_clbk_file_a, file, format, NULL, FALSE, FALSE, arg_clbk_valist, NULL, valist); } /********************************************************************* @@ -3417,38 +3402,12 @@ int CDECL MSVCRT_vfprintf(MSVCRT_FILE* file, const char *format, __ms_va_list va */ int CDECL MSVCRT_vfprintf_s(MSVCRT_FILE* file, const char *format, __ms_va_list valist) { - char buf[2048]; - LPWSTR formatW = NULL; - DWORD sz; - pf_output out; - int written, retval; - - if( !MSVCRT_CHECK_PMT( file != NULL ) ) - { - *MSVCRT__errno() = MSVCRT_EINVAL; - return -1; - } - - out.unicode = FALSE; - out.buf.A = out.grow.A = buf; - out.used = 0; - out.len = sizeof(buf); - - sz = MultiByteToWideChar( CP_ACP, 0, format, -1, NULL, 0 ); - formatW = HeapAlloc( GetProcessHeap(), 0, sz*sizeof(WCHAR) ); - MultiByteToWideChar( CP_ACP, 0, format, -1, formatW, sz ); - - if ((written = pf_vsnprintf( &out, formatW, NULL, TRUE, valist )) >= 0) - { - retval = MSVCRT_fwrite(out.buf.A, sizeof(*out.buf.A), written, file); - } - else retval = -1; - - HeapFree( GetProcessHeap(), 0, formatW ); + if(!MSVCRT_CHECK_PMT(file != NULL)) { + *MSVCRT__errno() = MSVCRT_EINVAL; + return -1; + } - if (out.buf.A != out.grow.A) - MSVCRT_free (out.buf.A); - return retval; + return pf_printf_a(puts_clbk_file_a, file, format, NULL, FALSE, TRUE, arg_clbk_valist, NULL, valist); } /********************************************************************* @@ -3456,23 +3415,7 @@ int CDECL MSVCRT_vfprintf_s(MSVCRT_FILE* file, const char *format, __ms_va_list */ int CDECL MSVCRT_vfwprintf(MSVCRT_FILE* file, const MSVCRT_wchar_t *format, __ms_va_list valist) { - MSVCRT_wchar_t buf[2048]; - pf_output out; - int written, retval; - - out.unicode = TRUE; - out.buf.W = out.grow.W = buf; - out.used = 0; - out.len = sizeof(buf) / sizeof(buf[0]); - - if ((written = pf_vsnprintf( &out, format, NULL, FALSE, valist )) >= 0) - { - retval = MSVCRT_fwrite(out.buf.W, sizeof(*out.buf.W), written, file); - } - else retval = -1; - if (out.buf.W != out.grow.W) - MSVCRT_free (out.buf.W); - return retval; + return pf_printf_w(puts_clbk_file_w, file, format, NULL, FALSE, FALSE, arg_clbk_valist, NULL, valist); } /********************************************************************* @@ -3480,29 +3423,12 @@ int CDECL MSVCRT_vfwprintf(MSVCRT_FILE* file, const MSVCRT_wchar_t *format, __ms */ int CDECL MSVCRT_vfwprintf_s(MSVCRT_FILE* file, const MSVCRT_wchar_t *format, __ms_va_list valist) { - MSVCRT_wchar_t buf[2048]; - pf_output out; - int written, retval; - - if( !MSVCRT_CHECK_PMT( file != NULL ) ) - { - *MSVCRT__errno() = MSVCRT_EINVAL; - return -1; - } - - out.unicode = TRUE; - out.buf.W = out.grow.W = buf; - out.used = 0; - out.len = sizeof(buf) / sizeof(buf[0]); + if(!MSVCRT_CHECK_PMT( file != NULL)) { + *MSVCRT__errno() = MSVCRT_EINVAL; + return -1; + } - if ((written = pf_vsnprintf( &out, format, NULL, TRUE, valist )) >= 0) - { - retval = MSVCRT_fwrite(out.buf.W, sizeof(*out.buf.W), written, file); - } - else retval = -1; - if (out.buf.W != out.grow.W) - MSVCRT_free (out.buf.W); - return retval; + return pf_printf_w(puts_clbk_file_w, file, format, NULL, FALSE, TRUE, arg_clbk_valist, NULL, valist); } /*********************************************************************
1
0
0
0
Piotr Caban : msvcrt: Use callback based printf in cprintf functions family .
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: 7303b8c4dbae5dc8d0904aefc7c4ef4bd524225b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7303b8c4dbae5dc8d0904aefc…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Apr 20 14:42:26 2011 +0200 msvcrt: Use callback based printf in cprintf functions family. --- dlls/msvcrt/console.c | 62 +++++++++++++++---------------------------------- dlls/msvcrt/msvcrt.h | 3 +- dlls/msvcrt/wcs.c | 23 ++++++++++++++++++ 3 files changed, 44 insertions(+), 44 deletions(-) diff --git a/dlls/msvcrt/console.c b/dlls/msvcrt/console.c index e23ff3e..41e5e0d 100644 --- a/dlls/msvcrt/console.c +++ b/dlls/msvcrt/console.c @@ -298,37 +298,30 @@ int CDECL _kbhit(void) return retval; } +static int puts_clbk_console_a(void *ctx, int len, const char *str) +{ + LOCK_CONSOLE; + if(!WriteConsoleA(MSVCRT_console_out, str, len, NULL, NULL)) + len = -1; + UNLOCK_CONSOLE; + return len; +} + +static int puts_clbk_console_w(void *ctx, int len, const MSVCRT_wchar_t *str) +{ + LOCK_CONSOLE; + if(!WriteConsoleW(MSVCRT_console_out, str, len, NULL, NULL)) + len = -1; + UNLOCK_CONSOLE; + return len; +} /********************************************************************* * _vcprintf (MSVCRT.@) */ int CDECL _vcprintf(const char* format, __ms_va_list valist) { - char buf[2048]; - LPWSTR formatW = NULL; - DWORD sz; - pf_output out; - int retval; - - out.unicode = FALSE; - out.buf.A = out.grow.A = buf; - out.used = 0; - out.len = sizeof(buf); - - sz = MultiByteToWideChar( CP_ACP, 0, format, -1, NULL, 0 ); - formatW = HeapAlloc( GetProcessHeap(), 0, sz*sizeof(WCHAR) ); - MultiByteToWideChar( CP_ACP, 0, format, -1, formatW, sz ); - - if ((retval = pf_vsnprintf( &out, formatW, NULL, FALSE, valist )) > 0) - { - LOCK_CONSOLE; - retval = _cputs( out.buf.A ); - UNLOCK_CONSOLE; - } - HeapFree( GetProcessHeap(), 0, formatW ); - if (out.buf.A != buf) - MSVCRT_free (out.buf.A); - return retval; + return pf_printf_a(puts_clbk_console_a, NULL, format, NULL, FALSE, FALSE, arg_clbk_valist, NULL, valist); } /********************************************************************* @@ -352,24 +345,7 @@ int CDECL _cprintf(const char* format, ...) */ int CDECL _vcwprintf(const MSVCRT_wchar_t* format, __ms_va_list valist) { - MSVCRT_wchar_t buf[2048]; - pf_output out; - int retval; - - out.unicode = TRUE; - out.buf.W = out.grow.W = buf; - out.used = 0; - out.len = sizeof(buf) / sizeof(buf[0]); - - if ((retval = pf_vsnprintf( &out, format, NULL, FALSE, valist )) >= 0) - { - LOCK_CONSOLE; - retval = _cputws( out.buf.W ); - UNLOCK_CONSOLE; - } - if (out.buf.W != buf) - MSVCRT_free (out.buf.W); - return retval; + return pf_printf_w(puts_clbk_console_w, NULL, format, NULL, FALSE, FALSE, arg_clbk_valist, NULL, valist); } /********************************************************************* diff --git a/dlls/msvcrt/msvcrt.h b/dlls/msvcrt/msvcrt.h index 677bb57..979a05b 100644 --- a/dlls/msvcrt/msvcrt.h +++ b/dlls/msvcrt/msvcrt.h @@ -943,11 +943,12 @@ typedef union _printf_arg LONGLONG get_longlong; double get_double; } printf_arg; -typedef printf_arg (*args_clbk)(void*, int, size_t, __ms_va_list*); +typedef printf_arg (*args_clbk)(void*, int, int, __ms_va_list*); int pf_printf_a(puts_clbk_a, void*, const char*, MSVCRT__locale_t, BOOL, BOOL, args_clbk, void*, __ms_va_list); int pf_printf_w(puts_clbk_w, void*, const MSVCRT_wchar_t*, MSVCRT__locale_t, BOOL, BOOL, args_clbk, void*, __ms_va_list); +printf_arg arg_clbk_valist(void*, int, int, __ms_va_list*); #define MSVCRT__OVERFLOW 3 #define MSVCRT__UNDERFLOW 4 diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c index a4c817b..a7cec7c 100644 --- a/dlls/msvcrt/wcs.c +++ b/dlls/msvcrt/wcs.c @@ -1091,6 +1091,29 @@ int pf_vsnprintf( pf_output *out, const WCHAR *format, } /********************************************************************* + * arg_clbk_valist (INTERNAL) + */ +printf_arg arg_clbk_valist(void *ctx, int arg_pos, int type, __ms_va_list *valist) +{ + printf_arg ret; + + if(type == VT_I8) + ret.get_longlong = va_arg(*valist, LONGLONG); + else if(type == VT_INT) + ret.get_int = va_arg(*valist, int); + else if(type == VT_R8) + ret.get_double = va_arg(*valist, double); + else if(type == VT_PTR) + ret.get_ptr = va_arg(*valist, void*); + else { + ERR("Incorrect type\n"); + ret.get_int = 0; + } + + return ret; +} + +/********************************************************************* * vsnprintf_internal (INTERNAL) */ static inline int vsnprintf_internal( char *str, MSVCRT_size_t len, const char *format,
1
0
0
0
Piotr Caban : msvcrt: Copy and reorganize printf implementation.
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: 056dfb26cefb04805db9289dd9295b8e53f7264b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=056dfb26cefb04805db9289dd…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Apr 20 14:42:16 2011 +0200 msvcrt: Copy and reorganize printf implementation. --- dlls/msvcrt/msvcrt.h | 15 ++ dlls/msvcrt/printf.h | 534 ++++++++++++++++++++++++++++++++++++++++++++++++++ dlls/msvcrt/wcs.c | 5 + 3 files changed, 554 insertions(+), 0 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=056dfb26cefb04805db92…
1
0
0
0
Piotr Caban : msvcrt/tests: Added fprintf tests.
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: dbc8c07ba80a4226664f8f71181839b3dbf77057 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=dbc8c07ba80a4226664f8f711…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Apr 20 14:41:39 2011 +0200 msvcrt/tests: Added fprintf tests. --- dlls/msvcrt/tests/printf.c | 36 ++++++++++++++++++++++++++++++++++++ 1 files changed, 36 insertions(+), 0 deletions(-) diff --git a/dlls/msvcrt/tests/printf.c b/dlls/msvcrt/tests/printf.c index 22ad1f6..a121533 100644 --- a/dlls/msvcrt/tests/printf.c +++ b/dlls/msvcrt/tests/printf.c @@ -625,6 +625,41 @@ static void test_snprintf (void) }; } +static void test_fprintf(void) +{ + static char file_name[] = "fprintf.tst"; + FILE *fp = fopen(file_name, "wb"); + char buf[1024]; + int ret; + + ret = fprintf(fp, "simple test\n"); + ok(ret == 12, "ret = %d\n", ret); + ret = ftell(fp); + ok(ret == 12, "ftell returned %d\n", ret); + + ret = fprintf(fp, "contains%cnull\n", '\0'); + ok(ret == 14, "ret = %d\n", ret); + ret = ftell(fp); + ok(ret == 26, "ftell returned %d\n", ret); + + fclose(fp); + + fp = fopen(file_name, "rb"); + ret = fscanf(fp, "%[^\n] ", buf); + ok(ret == 1, "ret = %d\n", ret); + ret = ftell(fp); + ok(ret == 12, "ftell returned %d\n", ret); + ok(!strcmp(buf, "simple test"), "buf = %s\n", buf); + + fgets(buf, sizeof(buf), fp); + ret = ftell(fp); + ok(ret == 26, "ret = %d\n", ret); + ok(!memcmp(buf, "contains\0null\n", 14), "buf = %s\n", buf); + + fclose(fp); + unlink(file_name); +} + static void test_fcvt(void) { char *str; @@ -1036,6 +1071,7 @@ START_TEST(printf) test_sprintf(); test_swprintf(); test_snprintf(); + test_fprintf(); test_fcvt(); test_xcvt(); test_vsnwprintf();
1
0
0
0
Amine Khaldi : comctl32: Don' t draw text when the number of text lines has been set to zero.
by Alexandre Julliard
25 Apr '11
25 Apr '11
Module: wine Branch: master Commit: 942aa70a0e7b30ead40902987afc9b03f8da2360 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=942aa70a0e7b30ead40902987…
Author: Amine Khaldi <amine.khaldi(a)reactos.org> Date: Sun Apr 24 17:56:30 2011 +0100 comctl32: Don't draw text when the number of text lines has been set to zero. --- dlls/comctl32/toolbar.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/toolbar.c b/dlls/comctl32/toolbar.c index 0b9dec2..c49b842 100644 --- a/dlls/comctl32/toolbar.c +++ b/dlls/comctl32/toolbar.c @@ -574,7 +574,7 @@ TOOLBAR_DrawString (const TOOLBAR_INFO *infoPtr, RECT *rcText, LPCWSTR lpText, UINT state = tbcd->nmcd.uItemState; /* draw text */ - if (lpText) { + if (lpText && infoPtr->nMaxTextRows > 0) { TRACE("string=%s rect=(%s)\n", debugstr_w(lpText), wine_dbgstr_rect(rcText));
1
0
0
0
← Newer
1
...
14
15
16
17
18
19
20
...
94
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
Results per page:
10
25
50
100
200