wine-commits April 2011

wine-commits@winehq.org

3 participants
937 discussions

Andrew Nguyen : regedit: Convert the child window code to Unicode.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: dfc0fa86d4165159e8189311bc69623020559cda URL: http://source.winehq.org/git/wine.git/?a=commit;h=dfc0fa86d4165159e8189311b… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Sat Apr 16 03:07:08 2011 -0500 regedit: Convert the child window code to Unicode. --- programs/regedit/childwnd.c | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/programs/regedit/childwnd.c b/programs/regedit/childwnd.c index 86fa62b..1ff7a90 100644 --- a/programs/regedit/childwnd.c +++ b/programs/regedit/childwnd.c @@ -131,7 +131,7 @@ static LPWSTR GetPathRoot(HWND hwndTV, HTREEITEM hItem, BOOL bFull) { WCHAR text[260]; HKEY hRootKey = NULL; if (!hItem) - hItem = TreeView_GetSelection(hwndTV); + hItem = (HTREEITEM)SendMessageW(hwndTV, TVM_GETNEXTITEM, TVGN_CARET, 0); HeapFree(GetProcessHeap(), 0, GetItemPath(hwndTV, hItem, &hRootKey)); if (!bFull && !hRootKey) return NULL; @@ -262,7 +262,9 @@ static void set_last_key(HWND hwndTV) if (RegCreateKeyExW(HKEY_CURRENT_USER, wszKeyName, 0, NULL, 0, KEY_WRITE, NULL, &hkey, NULL) == ERROR_SUCCESS) { - wszVal = GetItemFullPath(g_pChildWnd->hTreeWnd, TreeView_GetSelection(g_pChildWnd->hTreeWnd), FALSE); + HTREEITEM selection = (HTREEITEM)SendMessageW(g_pChildWnd->hTreeWnd, TVM_GETNEXTITEM, TVGN_CARET, 0); + + wszVal = GetItemFullPath(g_pChildWnd->hTreeWnd, selection, FALSE); RegSetValueExW(hkey, wszLastKey, 0, REG_SZ, (LPBYTE)wszVal, (lstrlenW(wszVal) + 1) * sizeof(WCHAR)); HeapFree(GetProcessHeap(), 0, wszVal); RegCloseKey(hkey); @@ -309,7 +311,7 @@ LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa GetCursorPos(&pt); ScreenToClient(hWnd, &pt); if (pt.x>=g_pChildWnd->nSplitPos-SPLIT_WIDTH/2 && pt.x<g_pChildWnd->nSplitPos+SPLIT_WIDTH/2+1) { - SetCursor(LoadCursor(0, IDC_SIZEWE)); + SetCursor(LoadCursorW(0, (LPCWSTR)IDC_SIZEWE)); return TRUE; } } @@ -354,7 +356,7 @@ LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa ResizeWnd(rt.right, rt.bottom); last_split = -1; ReleaseCapture(); - SetCursor(LoadCursor(0, IDC_ARROW)); + SetCursor(LoadCursorW(0, (LPCWSTR)IDC_ARROW)); } break; @@ -413,7 +415,7 @@ LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa LPWSTR fullPath = GetPathFullPath(g_pChildWnd->hTreeWnd, dispInfo->item.pszText); item.mask = TVIF_HANDLE | TVIF_TEXT; - item.hItem = TreeView_GetSelection(g_pChildWnd->hTreeWnd); + item.hItem = (HTREEITEM)SendMessageW(g_pChildWnd->hTreeWnd, TVM_GETNEXTITEM, TVGN_CARET, 0); item.pszText = dispInfo->item.pszText; SendMessageW( g_pChildWnd->hTreeWnd, TVM_SETITEMW, 0, (LPARAM)&item ); SendMessageW(hStatusBar, SB_SETTEXTW, 0, (LPARAM)fullPath);

1 0

Andrew Nguyen : regedit: Remove all Unicode macros in main.h.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: 82796c565ed14a416e3101523c223d01c09d46a4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=82796c565ed14a416e3101523… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Sat Apr 16 03:07:03 2011 -0500 regedit: Remove all Unicode macros in main.h. --- programs/regedit/childwnd.c | 2 +- programs/regedit/hexedit.c | 34 ++++++++++++++++++---------------- programs/regedit/main.h | 4 ++-- programs/regedit/treeview.c | 2 +- 4 files changed, 22 insertions(+), 20 deletions(-) diff --git a/programs/regedit/childwnd.c b/programs/regedit/childwnd.c index 769886c..86fa62b 100644 --- a/programs/regedit/childwnd.c +++ b/programs/regedit/childwnd.c @@ -388,7 +388,7 @@ LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa if (((int)wParam == TREE_WINDOW) && (g_pChildWnd != NULL)) { switch (((LPNMHDR)lParam)->code) { case TVN_ITEMEXPANDINGW: - return !OnTreeExpanding(g_pChildWnd->hTreeWnd, (NMTREEVIEW*)lParam); + return !OnTreeExpanding(g_pChildWnd->hTreeWnd, (NMTREEVIEWW*)lParam); case TVN_SELCHANGEDW: OnTreeSelectionChanged(g_pChildWnd->hTreeWnd, g_pChildWnd->hListWnd, ((NMTREEVIEWW *)lParam)->itemNew.hItem, TRUE); diff --git a/programs/regedit/hexedit.c b/programs/regedit/hexedit.c index 5e770c9..ddf6b09 100644 --- a/programs/regedit/hexedit.c +++ b/programs/regedit/hexedit.c @@ -54,6 +54,8 @@ typedef struct tagHEXEDIT_INFO INT nScrollPos; /* first visible line */ } HEXEDIT_INFO; +const WCHAR szHexEditClass[] = {'H','e','x','E','d','i','t',0}; + static inline LRESULT HexEdit_SetFont (HEXEDIT_INFO *infoPtr, HFONT hFont, BOOL redraw); static inline BYTE hexchar_to_byte(TCHAR ch) @@ -331,7 +333,7 @@ HexEdit_Char (HEXEDIT_INFO *infoPtr, TCHAR ch) } static inline LRESULT -HexEdit_Create (HEXEDIT_INFO *infoPtr, LPCREATESTRUCT lpcs) +HexEdit_Create (HEXEDIT_INFO *infoPtr, LPCREATESTRUCTW lpcs) { HexEdit_SetFont(infoPtr, GetStockObject(SYSTEM_FONT), FALSE); HexEdit_UpdateScrollbars(infoPtr); @@ -467,15 +469,15 @@ HexEdit_LButtonDown (HEXEDIT_INFO *infoPtr) } -static inline LRESULT HexEdit_NCCreate (HWND hwnd, LPCREATESTRUCT lpcs) +static inline LRESULT HexEdit_NCCreate (HWND hwnd, LPCREATESTRUCTW lpcs) { HEXEDIT_INFO *infoPtr; - SetWindowLong(hwnd, GWL_EXSTYLE, - lpcs->dwExStyle | WS_EX_CLIENTEDGE); + SetWindowLongW(hwnd, GWL_EXSTYLE, + lpcs->dwExStyle | WS_EX_CLIENTEDGE); /* allocate memory for info structure */ infoPtr = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(HEXEDIT_INFO)); - SetWindowLongPtr(hwnd, 0, (DWORD_PTR)infoPtr); + SetWindowLongPtrW(hwnd, 0, (DWORD_PTR)infoPtr); /* initialize info structure */ infoPtr->nCaretPos = 0; @@ -484,7 +486,7 @@ static inline LRESULT HexEdit_NCCreate (HWND hwnd, LPCREATESTRUCT lpcs) infoPtr->bFocusHex = TRUE; infoPtr->bInsert = TRUE; - return DefWindowProc(infoPtr->hwndSelf, WM_NCCREATE, 0, (LPARAM)lpcs); + return DefWindowProcW(infoPtr->hwndSelf, WM_NCCREATE, 0, (LPARAM)lpcs); } static inline LRESULT @@ -611,10 +613,10 @@ HexEdit_VScroll (HEXEDIT_INFO *infoPtr, INT action) static LRESULT WINAPI HexEdit_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) { - HEXEDIT_INFO *infoPtr = (HEXEDIT_INFO *)GetWindowLongPtr (hwnd, 0); + HEXEDIT_INFO *infoPtr = (HEXEDIT_INFO *)GetWindowLongPtrW(hwnd, 0); if (!infoPtr && (uMsg != WM_NCCREATE)) - return DefWindowProc(hwnd, uMsg, wParam, lParam); + return DefWindowProcW(hwnd, uMsg, wParam, lParam); switch (uMsg) { @@ -625,10 +627,10 @@ HexEdit_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) return HexEdit_GetData (infoPtr, (INT)wParam, (BYTE *)lParam); case WM_CHAR: - return HexEdit_Char (infoPtr, (TCHAR)wParam); + return HexEdit_Char (infoPtr, (WCHAR)wParam); case WM_CREATE: - return HexEdit_Create (infoPtr, (LPCREATESTRUCT)lParam); + return HexEdit_Create (infoPtr, (LPCREATESTRUCTW)lParam); case WM_DESTROY: return HexEdit_Destroy (infoPtr); @@ -652,7 +654,7 @@ HexEdit_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) return HexEdit_LButtonDown (infoPtr); case WM_NCCREATE: - return HexEdit_NCCreate (hwnd, (LPCREATESTRUCT)lParam); + return HexEdit_NCCreate (hwnd, (LPCREATESTRUCTW)lParam); case WM_PAINT: HexEdit_Paint(infoPtr); @@ -668,23 +670,23 @@ HexEdit_WindowProc (HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM lParam) return HexEdit_VScroll (infoPtr, (INT)wParam); default: - return DefWindowProc(hwnd, uMsg, wParam, lParam); + return DefWindowProcW(hwnd, uMsg, wParam, lParam); } return 0; } void HexEdit_Register(void) { - WNDCLASS wndClass; + WNDCLASSW wndClass; - ZeroMemory(&wndClass, sizeof(WNDCLASS)); + ZeroMemory(&wndClass, sizeof(WNDCLASSW)); wndClass.style = 0; wndClass.lpfnWndProc = HexEdit_WindowProc; wndClass.cbClsExtra = 0; wndClass.cbWndExtra = sizeof(HEXEDIT_INFO *); wndClass.hCursor = NULL; wndClass.hbrBackground = NULL; - wndClass.lpszClassName = HEXEDIT_CLASS; + wndClass.lpszClassName = szHexEditClass; - RegisterClass(&wndClass); + RegisterClassW(&wndClass); } diff --git a/programs/regedit/main.h b/programs/regedit/main.h index d399d81..8b6eede 100644 --- a/programs/regedit/main.h +++ b/programs/regedit/main.h @@ -40,7 +40,6 @@ #define WM_NOTIFY_REFLECT (WM_USER+1024) /* HexEdit Class */ -#define HEXEDIT_CLASS TEXT("HexEdit") #define HEM_SETDATA (WM_USER+0) #define HEM_GETDATA (WM_USER+1) @@ -90,6 +89,7 @@ extern enum OPTION_FLAGS Options; extern WCHAR szTitle[]; extern const WCHAR szFrameClass[]; extern const WCHAR szChildClass[]; +extern const WCHAR szHexEditClass[]; extern WCHAR g_pszDefaultValueName[]; /* Registry class names and their indexes */ @@ -127,7 +127,7 @@ extern BOOL IsDefaultValue(HWND hwndLV, int i); /* treeview.c */ extern HWND CreateTreeView(HWND hwndParent, LPWSTR pHostName, UINT id); extern BOOL RefreshTreeView(HWND hWndTV); -extern BOOL OnTreeExpanding(HWND hWnd, NMTREEVIEW* pnmtv); +extern BOOL OnTreeExpanding(HWND hWnd, NMTREEVIEWW* pnmtv); extern LPWSTR GetItemPath(HWND hwndTV, HTREEITEM hItem, HKEY* phRootKey); extern BOOL DeleteNode(HWND hwndTV, HTREEITEM hItem); extern HTREEITEM InsertNode(HWND hwndTV, HTREEITEM hItem, LPWSTR name); diff --git a/programs/regedit/treeview.c b/programs/regedit/treeview.c index e48eb5b..18e41bc 100644 --- a/programs/regedit/treeview.c +++ b/programs/regedit/treeview.c @@ -650,7 +650,7 @@ done: return TRUE; } -BOOL OnTreeExpanding(HWND hwndTV, NMTREEVIEW* pnmtv) +BOOL OnTreeExpanding(HWND hwndTV, NMTREEVIEWW* pnmtv) { return UpdateExpandingTree(hwndTV, pnmtv->itemNew.hItem, pnmtv->itemNew.state); }

1 0

Andrew Nguyen : regedit: Convert regedit main code to Unicode.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: 182763f632fd482d055057631a5d700981aa0639 URL: http://source.winehq.org/git/wine.git/?a=commit;h=182763f632fd482d055057631… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Sat Apr 16 03:06:48 2011 -0500 regedit: Convert regedit main code to Unicode. --- programs/regedit/childwnd.c | 2 +- programs/regedit/framewnd.c | 12 ++++++---- programs/regedit/main.c | 48 +++++++++++++++++++++--------------------- programs/regedit/main.h | 6 ++-- 4 files changed, 35 insertions(+), 33 deletions(-) diff --git a/programs/regedit/childwnd.c b/programs/regedit/childwnd.c index bb56cb2..769886c 100644 --- a/programs/regedit/childwnd.c +++ b/programs/regedit/childwnd.c @@ -441,7 +441,7 @@ LRESULT CALLBACK ChildWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa } /* fall through */ default: def: - return DefWindowProc(hWnd, message, wParam, lParam); + return DefWindowProcW(hWnd, message, wParam, lParam); } return 0; } diff --git a/programs/regedit/framewnd.c b/programs/regedit/framewnd.c index c118b59..c4f4f92 100644 --- a/programs/regedit/framewnd.c +++ b/programs/regedit/framewnd.c @@ -921,15 +921,17 @@ static BOOL _CmdWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) LRESULT CALLBACK FrameWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam) { + static const WCHAR captionW[] = {'r','e','g','e','d','i','t',' ','c','h','i','l','d',' ','w','i','n','d','o','w',0}; + switch (message) { case WM_CREATE: - CreateWindowEx(0, szChildClass, _T("regedit child window"), WS_CHILD | WS_VISIBLE, - CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, - hWnd, NULL, hInst, 0); + CreateWindowExW(0, szChildClass, captionW, WS_CHILD | WS_VISIBLE, + CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, + hWnd, NULL, hInst, 0); break; case WM_COMMAND: if (!_CmdWndProc(hWnd, message, wParam, lParam)) - return DefWindowProc(hWnd, message, wParam, lParam); + return DefWindowProcW(hWnd, message, wParam, lParam); break; case WM_ACTIVATE: if (LOWORD(hWnd)) @@ -960,7 +962,7 @@ LRESULT CALLBACK FrameWndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lPa PostQuitMessage(0); } default: - return DefWindowProc(hWnd, message, wParam, lParam); + return DefWindowProcW(hWnd, message, wParam, lParam); } return 0; } diff --git a/programs/regedit/main.c b/programs/regedit/main.c index 0bc43e0..b055d7b 100644 --- a/programs/regedit/main.c +++ b/programs/regedit/main.c @@ -55,30 +55,30 @@ HWND hStatusBar; HMENU hMenuFrame; HMENU hPopupMenus = 0; UINT nClipboardFormat; -LPCTSTR strClipboardFormat = _T("TODO: SET CORRECT FORMAT"); +const WCHAR strClipboardFormat[] = {'T','O','D','O',':',' ','S','E','T',' ','C','O','R','R','E','C','T',' ','F','O','R','M','A','T',0}; #define MAX_LOADSTRING 100 -TCHAR szTitle[MAX_LOADSTRING]; -const TCHAR szFrameClass[] = {'R','E','G','E','D','I','T','_','F','R','A','M','E',0}; -const TCHAR szChildClass[] = {'R','E','G','E','D','I','T',0}; +WCHAR szTitle[MAX_LOADSTRING]; +const WCHAR szFrameClass[] = {'R','E','G','E','D','I','T','_','F','R','A','M','E',0}; +const WCHAR szChildClass[] = {'R','E','G','E','D','I','T',0}; static BOOL RegisterWindowClasses(HINSTANCE hInstance, ATOM *hFrameWndClass, ATOM *hChildWndClass) { - WNDCLASSEX wndclass = {0}; + WNDCLASSEXW wndclass = {0}; /* Frame class */ - wndclass.cbSize = sizeof(WNDCLASSEX); + wndclass.cbSize = sizeof(WNDCLASSEXW); wndclass.style = CS_HREDRAW | CS_VREDRAW; wndclass.lpfnWndProc = FrameWndProc; wndclass.hInstance = hInstance; - wndclass.hIcon = LoadIcon(hInstance, MAKEINTRESOURCE(IDI_REGEDIT)); - wndclass.hCursor = LoadCursor(0, IDC_ARROW); + wndclass.hIcon = LoadIconW(hInstance, MAKEINTRESOURCEW(IDI_REGEDIT)); + wndclass.hCursor = LoadCursorW(0, (LPCWSTR)IDC_ARROW); wndclass.lpszClassName = szFrameClass; - wndclass.hIconSm = LoadImage(hInstance, MAKEINTRESOURCE(IDI_REGEDIT), IMAGE_ICON, GetSystemMetrics(SM_CXSMICON), - GetSystemMetrics(SM_CYSMICON), LR_SHARED); + wndclass.hIconSm = LoadImageW(hInstance, MAKEINTRESOURCEW(IDI_REGEDIT), IMAGE_ICON, GetSystemMetrics(SM_CXSMICON), + GetSystemMetrics(SM_CYSMICON), LR_SHARED); - if (!(*hFrameWndClass = RegisterClassEx(&wndclass))) + if (!(*hFrameWndClass = RegisterClassExW(&wndclass))) return FALSE; /* Child class */ @@ -86,9 +86,9 @@ static BOOL RegisterWindowClasses(HINSTANCE hInstance, ATOM *hFrameWndClass, ATO wndclass.cbWndExtra = sizeof(HANDLE); wndclass.lpszClassName = szChildClass; - if (!(*hChildWndClass = RegisterClassEx(&wndclass))) + if (!(*hChildWndClass = RegisterClassExW(&wndclass))) { - UnregisterClass(szFrameClass, hInstance); + UnregisterClassW(szFrameClass, hInstance); return FALSE; } @@ -112,12 +112,12 @@ static BOOL InitInstance(HINSTANCE hInstance, int nCmdShow) /* register our hex editor control */ HexEdit_Register(); - nClipboardFormat = RegisterClipboardFormat(strClipboardFormat); + nClipboardFormat = RegisterClipboardFormatW(strClipboardFormat); - hFrameWnd = CreateWindowEx(0, MAKEINTRESOURCE(hFrameWndClass), szTitle, - WS_OVERLAPPEDWINDOW | WS_EX_CLIENTEDGE, - CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, - NULL, hMenuFrame, hInstance, NULL/*lpParam*/); + hFrameWnd = CreateWindowExW(0, MAKEINTRESOURCEW(hFrameWndClass), szTitle, + WS_OVERLAPPEDWINDOW | WS_EX_CLIENTEDGE, + CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, CW_USEDEFAULT, + NULL, hMenuFrame, hInstance, NULL/*lpParam*/); if (!hFrameWnd) { return FALSE; @@ -148,7 +148,7 @@ static BOOL TranslateChildTabMessage(MSG *msg) if (msg->message != WM_KEYDOWN) return FALSE; if (msg->wParam != VK_TAB) return FALSE; if (GetParent(msg->hwnd) != g_pChildWnd->hWnd) return FALSE; - PostMessage(g_pChildWnd->hWnd, WM_COMMAND, ID_SWITCH_PANELS, 0); + PostMessageW(g_pChildWnd->hWnd, WM_COMMAND, ID_SWITCH_PANELS, 0); return TRUE; } @@ -165,7 +165,7 @@ int APIENTRY WinMain(HINSTANCE hInstance, } /* Initialize global strings */ - LoadString(hInstance, IDS_APP_TITLE, szTitle, COUNT_OF(szTitle)); + LoadStringW(hInstance, IDS_APP_TITLE, szTitle, COUNT_OF(szTitle)); LoadStringW(hInstance, IDS_REGISTRY_DEFAULT_VALUE, g_pszDefaultValueName, COUNT_OF(g_pszDefaultValueName)); /* Store instance handle in our global variable */ @@ -175,14 +175,14 @@ int APIENTRY WinMain(HINSTANCE hInstance, if (!InitInstance(hInstance, nCmdShow)) { return FALSE; } - hAccel = LoadAccelerators(hInstance, (LPCTSTR)IDC_REGEDIT); + hAccel = LoadAcceleratorsW(hInstance, MAKEINTRESOURCEW(IDC_REGEDIT)); /* Main message loop */ - while (GetMessage(&msg, NULL, 0, 0)) { - if (!TranslateAccelerator(hFrameWnd, hAccel, &msg) + while (GetMessageW(&msg, NULL, 0, 0)) { + if (!TranslateAcceleratorW(hFrameWnd, hAccel, &msg) && !TranslateChildTabMessage(&msg)) { TranslateMessage(&msg); - DispatchMessage(&msg); + DispatchMessageW(&msg); } } ExitInstance(); diff --git a/programs/regedit/main.h b/programs/regedit/main.h index 6ecaf6c..d399d81 100644 --- a/programs/regedit/main.h +++ b/programs/regedit/main.h @@ -87,9 +87,9 @@ extern HMENU hPopupMenus; extern HFONT hFont; extern enum OPTION_FLAGS Options; -extern TCHAR szTitle[]; -extern const TCHAR szFrameClass[]; -extern const TCHAR szChildClass[]; +extern WCHAR szTitle[]; +extern const WCHAR szFrameClass[]; +extern const WCHAR szChildClass[]; extern WCHAR g_pszDefaultValueName[]; /* Registry class names and their indexes */

1 0

Andrew Nguyen : regedit: Remove obsolete comments in InitInstance.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: 3571ae27a240472a208d744a5853642eaebf169d URL: http://source.winehq.org/git/wine.git/?a=commit;h=3571ae27a240472a208d744a5… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Sat Apr 16 03:06:38 2011 -0500 regedit: Remove obsolete comments in InitInstance. --- programs/regedit/main.c | 15 --------------- 1 files changed, 0 insertions(+), 15 deletions(-) diff --git a/programs/regedit/main.c b/programs/regedit/main.c index f10741b..0bc43e0 100644 --- a/programs/regedit/main.c +++ b/programs/regedit/main.c @@ -94,18 +94,6 @@ static BOOL RegisterWindowClasses(HINSTANCE hInstance, ATOM *hFrameWndClass, ATO return TRUE; } -/******************************************************************************* - * - * - * FUNCTION: InitInstance(HANDLE, int) - * - * PURPOSE: Saves instance handle and creates main window - * - * COMMENTS: - * - * In this function, we save the instance handle in a global variable and - * create and display the main program window. - */ static BOOL InitInstance(HINSTANCE hInstance, int nCmdShow) { @@ -125,9 +113,6 @@ static BOOL InitInstance(HINSTANCE hInstance, int nCmdShow) HexEdit_Register(); nClipboardFormat = RegisterClipboardFormat(strClipboardFormat); - /* if (nClipboardFormat == 0) { - DWORD dwError = GetLastError(); - } */ hFrameWnd = CreateWindowEx(0, MAKEINTRESOURCE(hFrameWndClass), szTitle, WS_OVERLAPPEDWINDOW | WS_EX_CLIENTEDGE,

1 0

Andrew Nguyen : regedit: Refactor window class initialization to a separate function.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: 7369b6cf4174469a43ee2828d8482c8511817836 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7369b6cf4174469a43ee2828d… Author: Andrew Nguyen <anguyen(a)codeweavers.com> Date: Sat Apr 16 03:05:55 2011 -0500 regedit: Refactor window class initialization to a separate function. --- programs/regedit/main.c | 71 +++++++++++++++++++++++------------------------ 1 files changed, 35 insertions(+), 36 deletions(-) diff --git a/programs/regedit/main.c b/programs/regedit/main.c index 27bc26f..f10741b 100644 --- a/programs/regedit/main.c +++ b/programs/regedit/main.c @@ -63,7 +63,37 @@ TCHAR szTitle[MAX_LOADSTRING]; const TCHAR szFrameClass[] = {'R','E','G','E','D','I','T','_','F','R','A','M','E',0}; const TCHAR szChildClass[] = {'R','E','G','E','D','I','T',0}; +static BOOL RegisterWindowClasses(HINSTANCE hInstance, ATOM *hFrameWndClass, ATOM *hChildWndClass) +{ + WNDCLASSEX wndclass = {0}; + + /* Frame class */ + wndclass.cbSize = sizeof(WNDCLASSEX); + wndclass.style = CS_HREDRAW | CS_VREDRAW; + wndclass.lpfnWndProc = FrameWndProc; + wndclass.hInstance = hInstance; + wndclass.hIcon = LoadIcon(hInstance, MAKEINTRESOURCE(IDI_REGEDIT)); + wndclass.hCursor = LoadCursor(0, IDC_ARROW); + wndclass.lpszClassName = szFrameClass; + wndclass.hIconSm = LoadImage(hInstance, MAKEINTRESOURCE(IDI_REGEDIT), IMAGE_ICON, GetSystemMetrics(SM_CXSMICON), + GetSystemMetrics(SM_CYSMICON), LR_SHARED); + + if (!(*hFrameWndClass = RegisterClassEx(&wndclass))) + return FALSE; + + /* Child class */ + wndclass.lpfnWndProc = ChildWndProc; + wndclass.cbWndExtra = sizeof(HANDLE); + wndclass.lpszClassName = szChildClass; + + if (!(*hChildWndClass = RegisterClassEx(&wndclass))) + { + UnregisterClass(szFrameClass, hInstance); + return FALSE; + } + return TRUE; +} /******************************************************************************* * * @@ -80,41 +110,10 @@ const TCHAR szChildClass[] = {'R','E','G','E','D','I','T',0}; static BOOL InitInstance(HINSTANCE hInstance, int nCmdShow) { WCHAR empty = 0; - WNDCLASSEX wcFrame = { - sizeof(WNDCLASSEX), - CS_HREDRAW | CS_VREDRAW/*style*/, - FrameWndProc, - 0/*cbClsExtra*/, - 0/*cbWndExtra*/, - hInstance, - LoadIcon(hInstance, MAKEINTRESOURCE(IDI_REGEDIT)), - LoadCursor(0, IDC_ARROW), - 0/*hbrBackground*/, - 0/*lpszMenuName*/, - szFrameClass, - LoadImage(hInstance, MAKEINTRESOURCE(IDI_REGEDIT), IMAGE_ICON, - GetSystemMetrics(SM_CXSMICON), GetSystemMetrics(SM_CYSMICON), LR_SHARED) - }; - ATOM hFrameWndClass = RegisterClassEx(&wcFrame); /* register frame window class */ - - WNDCLASSEX wcChild = { - sizeof(WNDCLASSEX), - CS_HREDRAW | CS_VREDRAW/*style*/, - ChildWndProc, - 0/*cbClsExtra*/, - sizeof(HANDLE)/*cbWndExtra*/, - hInstance, - LoadIcon(hInstance, MAKEINTRESOURCE(IDI_REGEDIT)), - LoadCursor(0, IDC_ARROW), - 0/*hbrBackground*/, - 0/*lpszMenuName*/, - szChildClass, - LoadImage(hInstance, MAKEINTRESOURCE(IDI_REGEDIT), IMAGE_ICON, - GetSystemMetrics(SM_CXSMICON), GetSystemMetrics(SM_CYSMICON), LR_SHARED) - - }; - ATOM hChildWndClass = RegisterClassEx(&wcChild); /* register child windows class */ - hChildWndClass = hChildWndClass; /* warning eater */ + ATOM hFrameWndClass, hChildWndClass; + + if (!RegisterWindowClasses(hInstance, &hFrameWndClass, &hChildWndClass)) + return FALSE; hMenuFrame = LoadMenuW(hInstance, MAKEINTRESOURCEW(IDR_REGEDIT_MENU)); hPopupMenus = LoadMenuW(hInstance, MAKEINTRESOURCEW(IDR_POPUP_MENUS));

1 0

Jacek Caban : mshtml: Don't include null-byte in post data.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: 1054b9558849e46ecdf5ae5e99a56ca87fc9304d URL: http://source.winehq.org/git/wine.git/?a=commit;h=1054b9558849e46ecdf5ae5e9… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Apr 15 19:36:49 2011 +0200 mshtml: Don't include null-byte in post data. --- dlls/mshtml/navigate.c | 21 +++++++++++---------- 1 files changed, 11 insertions(+), 10 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index 35f87dd..990401a 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -886,7 +886,7 @@ static HRESULT read_post_data_stream(nsChannelBSC *This, nsChannel *nschannel) if(NS_FAILED(nsres)) return E_FAIL; - post_data = data = GlobalAlloc(0, available+1); + post_data = data = GlobalAlloc(0, available); if(!data) return E_OUTOFMEMORY; @@ -896,21 +896,22 @@ static HRESULT read_post_data_stream(nsChannelBSC *This, nsChannel *nschannel) return E_FAIL; } - data[data_len++] = 0; - if(nschannel->post_data_contains_headers) { - if(data[0] == '\r' && data[1] == '\n') { + if(data_len >= 2 && data[0] == '\r' && data[1] == '\n') { post_data = data+2; data_len -= 2; }else { WCHAR *headers; DWORD size; - - post_data = strstr(data, "\r\n\r\n"); - if(post_data) - post_data += 4; - else - post_data = data+data_len; + char *ptr; + + post_data += data_len; + for(ptr = data; ptr+4 < data+data_len; ptr++) { + if(!memcmp(ptr, "\r\n\r\n", 4)) { + post_data = ptr+4; + break; + } + } data_len -= post_data-data;

1 0

Jacek Caban : mshtml: Better support for HTTP redirection.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: 0613a826713091cc7f486bcd9774e8bc90f867eb URL: http://source.winehq.org/git/wine.git/?a=commit;h=0613a826713091cc7f486bcd9… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Apr 15 19:36:36 2011 +0200 mshtml: Better support for HTTP redirection. --- dlls/mshtml/mshtml_private.h | 2 +- dlls/mshtml/navigate.c | 157 ++++++++++++++++++++++++++++++++++++++++-- dlls/mshtml/nsiface.idl | 30 ++++++++- dlls/mshtml/nsio.c | 55 ++++++++++++++- 4 files changed, 235 insertions(+), 9 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=0613a826713091cc7f486…

1 0

Jacek Caban : mshtml: Moved nsChannel initialization to separated function.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: f24be9fa541cafc043eec884950b6c80fc0ad5fa URL: http://source.winehq.org/git/wine.git/?a=commit;h=f24be9fa541cafc043eec8849… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Fri Apr 15 19:36:24 2011 +0200 mshtml: Moved nsChannel initialization to separated function. --- dlls/mshtml/nsio.c | 57 ++++++++++++++++++++++++++++++++------------------- 1 files changed, 36 insertions(+), 21 deletions(-) diff --git a/dlls/mshtml/nsio.c b/dlls/mshtml/nsio.c index bd6a411..29825fe 100644 --- a/dlls/mshtml/nsio.c +++ b/dlls/mshtml/nsio.c @@ -2532,6 +2532,37 @@ HRESULT create_doc_uri(HTMLWindow *window, WCHAR *url, nsWineURI **ret) return S_OK; } +static nsresult create_nschannel(nsWineURI *uri, nsChannel **ret) +{ + nsChannel *channel; + HRESULT hres; + + if(!ensure_uri(uri)) + return NS_ERROR_UNEXPECTED; + + channel = heap_alloc_zero(sizeof(nsChannel)); + if(!channel) + return NS_ERROR_OUT_OF_MEMORY; + + channel->nsIHttpChannel_iface.lpVtbl = &nsChannelVtbl; + channel->nsIUploadChannel_iface.lpVtbl = &nsUploadChannelVtbl; + channel->nsIHttpChannelInternal_iface.lpVtbl = &nsHttpChannelInternalVtbl; + channel->ref = 1; + channel->request_method = METHOD_GET; + list_init(&channel->response_headers); + list_init(&channel->request_headers); + + nsIURL_AddRef(&uri->nsIURL_iface); + channel->uri = uri; + + hres = IUri_GetScheme(uri->uri, &channel->url_scheme); + if(FAILED(hres)) + channel->url_scheme = URL_SCHEME_UNKNOWN; + + *ret = channel; + return NS_OK; +} + typedef struct { nsIProtocolHandler nsIProtocolHandler_iface; @@ -2839,10 +2870,9 @@ static nsresult NSAPI nsIOService_NewFileURI(nsIIOService *iface, nsIFile *aFile static nsresult NSAPI nsIOService_NewChannelFromURI(nsIIOService *iface, nsIURI *aURI, nsIChannel **_retval) { - nsChannel *ret; nsWineURI *wine_uri; + nsChannel *ret; nsresult nsres; - HRESULT hres; TRACE("(%p %p)\n", aURI, _retval); @@ -2852,29 +2882,14 @@ static nsresult NSAPI nsIOService_NewChannelFromURI(nsIIOService *iface, nsIURI return nsIIOService_NewChannelFromURI(nsio, aURI, _retval); } - if(!ensure_uri(wine_uri)) { - nsIURI_Release(&wine_uri->nsIURL_iface); - return NS_ERROR_UNEXPECTED; - } - - ret = heap_alloc_zero(sizeof(nsChannel)); - - ret->nsIHttpChannel_iface.lpVtbl = &nsChannelVtbl; - ret->nsIUploadChannel_iface.lpVtbl = &nsUploadChannelVtbl; - ret->nsIHttpChannelInternal_iface.lpVtbl = &nsHttpChannelInternalVtbl; - ret->ref = 1; - ret->uri = wine_uri; - ret->request_method = METHOD_GET; - list_init(&ret->response_headers); - list_init(&ret->request_headers); + nsres = create_nschannel(wine_uri, &ret); + nsIURL_Release(&wine_uri->nsIURL_iface); + if(NS_FAILED(nsres)) + return nsres; nsIURI_AddRef(aURI); ret->original_uri = aURI; - hres = IUri_GetScheme(wine_uri->uri, &ret->url_scheme); - if(FAILED(hres)) - ret->url_scheme = URL_SCHEME_UNKNOWN; - *_retval = (nsIChannel*)&ret->nsIHttpChannel_iface; return NS_OK; }

1 0

Henri Verbeet : wined3d: Remove IWineD3DSurface::GetImplType() from the public interface.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: 84d50f735327d39bcc65f7f006706a5a6ec90fb0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=84d50f735327d39bcc65f7f00… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Apr 15 18:33:40 2011 +0200 wined3d: Remove IWineD3DSurface::GetImplType() from the public interface. --- dlls/wined3d/surface.c | 13 ++----------- dlls/wined3d/surface_base.c | 3 +-- dlls/wined3d/wined3d_private.h | 1 + include/wine/wined3d.idl | 2 -- 4 files changed, 4 insertions(+), 15 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 1aeea95..bf379ca 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -4891,10 +4891,6 @@ HRESULT surface_load_location(IWineD3DSurfaceImpl *surface, DWORD flag, const RE return WINED3D_OK; } -static WINED3DSURFTYPE WINAPI IWineD3DSurfaceImpl_GetImplType(IWineD3DSurface *iface) { - return SURFACE_OPENGL; -} - BOOL surface_is_offscreen(IWineD3DSurfaceImpl *surface) { struct wined3d_swapchain *swapchain = surface->container.u.swapchain; @@ -4952,7 +4948,6 @@ const IWineD3DSurfaceVtbl IWineD3DSurface_Vtbl = /* Internal use: */ IWineD3DSurfaceImpl_SetFormat, IWineD3DSurfaceImpl_PrivateSetup, - IWineD3DSurfaceImpl_GetImplType, }; static HRESULT ffp_blit_alloc(IWineD3DDeviceImpl *device) { return WINED3D_OK; } @@ -5539,11 +5534,6 @@ static HRESULT WINAPI IWineGDISurfaceImpl_SetMem(IWineD3DSurface *iface, void *m return WINED3D_OK; } -static WINED3DSURFTYPE WINAPI IWineGDISurfaceImpl_GetImplType(IWineD3DSurface *iface) -{ - return SURFACE_GDI; -} - static const IWineD3DSurfaceVtbl IWineGDISurface_Vtbl = { /* IUnknown */ @@ -5586,7 +5576,6 @@ static const IWineD3DSurfaceVtbl IWineGDISurface_Vtbl = /* Internal use: */ IWineD3DBaseSurfaceImpl_SetFormat, IWineGDISurfaceImpl_PrivateSetup, - IWineGDISurfaceImpl_GetImplType, }; HRESULT surface_init(IWineD3DSurfaceImpl *surface, WINED3DSURFTYPE surface_type, UINT alignment, @@ -5650,6 +5639,8 @@ HRESULT surface_init(IWineD3DSurfaceImpl *surface, WINED3DSURFTYPE surface_type, if (!resource_size) return WINED3DERR_INVALIDCALL; + surface->surface_type = surface_type; + /* Look at the implementation and set the correct Vtable. */ switch (surface_type) { diff --git a/dlls/wined3d/surface_base.c b/dlls/wined3d/surface_base.c index 0705719..6bd073d 100644 --- a/dlls/wined3d/surface_base.c +++ b/dlls/wined3d/surface_base.c @@ -899,8 +899,7 @@ static IWineD3DSurfaceImpl *surface_convert_format(IWineD3DSurfaceImpl *source, IWineD3DDevice_CreateSurface((IWineD3DDevice *)source->resource.device, source->resource.width, source->resource.height, to_fmt, TRUE /* lockable */, TRUE /* discard */, 0 /* level */, 0 /* usage */, WINED3DPOOL_SCRATCH, WINED3DMULTISAMPLE_NONE /* TODO: Multisampled conversion */, - 0 /* MultiSampleQuality */, IWineD3DSurface_GetImplType((IWineD3DSurface *) source), - NULL /* parent */, &wined3d_null_parent_ops, &ret); + 0 /* MultiSampleQuality */, source->surface_type, NULL /* parent */, &wined3d_null_parent_ops, &ret); if(!ret) { ERR("Failed to create a destination surface for conversion\n"); return NULL; diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index 416082c..8c90464 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2041,6 +2041,7 @@ struct IWineD3DSurfaceImpl DWORD flags; + WINED3DSURFTYPE surface_type; UINT pow2Width; UINT pow2Height; diff --git a/include/wine/wined3d.idl b/include/wine/wined3d.idl index 82f5f76..422551d 100644 --- a/include/wine/wined3d.idl +++ b/include/wine/wined3d.idl @@ -2285,8 +2285,6 @@ interface IWineD3DSurface : IUnknown ); HRESULT PrivateSetup( ); - WINED3DSURFTYPE GetImplType( - ); } [

1 0

Henri Verbeet : wined3d: Merge surface_gdi.c into surface.c.
by Alexandre Julliard 18 Apr '11

18 Apr '11

Module: wine Branch: master Commit: 52edf556f61ebae8e8163b0d9d6073394f3d9005 URL: http://source.winehq.org/git/wine.git/?a=commit;h=52edf556f61ebae8e8163b0d9… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Fri Apr 15 18:33:39 2011 +0200 wined3d: Merge surface_gdi.c into surface.c. --- dlls/wined3d/Makefile.in | 1 - dlls/wined3d/surface.c | 663 ++++++++++++++++++++++++++++++++++------ dlls/wined3d/surface_gdi.c | 501 ------------------------------ dlls/wined3d/wined3d_private.h | 2 - 4 files changed, 565 insertions(+), 602 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=52edf556f61ebae8e8163…

1 0

← Newer
1
...
34
35
36
37
38
39
40
...
94
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits April 2011