winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
May 2011
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
945 discussions
Start a n
N
ew thread
André Hentschel : mscoree/tests: Add tests for CreateConfigStream.
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: 1aacc5fc40291ec83364512cc47afb9cfe8b4a04 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1aacc5fc40291ec83364512cc…
Author: André Hentschel <nerv(a)dawncrow.de> Date: Mon May 16 23:26:12 2011 +0200 mscoree/tests: Add tests for CreateConfigStream. --- dlls/mscoree/tests/mscoree.c | 75 ++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 75 insertions(+), 0 deletions(-) diff --git a/dlls/mscoree/tests/mscoree.c b/dlls/mscoree/tests/mscoree.c index 4226493..f80dbb4 100644 --- a/dlls/mscoree/tests/mscoree.c +++ b/dlls/mscoree/tests/mscoree.c @@ -1,5 +1,6 @@ /* * Copyright 2010 Louis Lenders + * Copyright 2011 André Hentschel * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public @@ -16,6 +17,8 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#define COBJMACROS + #include "corerror.h" #include "mscoree.h" #include "shlwapi.h" @@ -27,6 +30,7 @@ static HRESULT (WINAPI *pGetCORVersion)(LPWSTR, DWORD, DWORD*); static HRESULT (WINAPI *pGetCORSystemDirectory)(LPWSTR, DWORD, DWORD*); static HRESULT (WINAPI *pGetRequestedRuntimeInfo)(LPCWSTR, LPCWSTR, LPCWSTR, DWORD, DWORD, LPWSTR, DWORD, DWORD*, LPWSTR, DWORD, DWORD*); static HRESULT (WINAPI *pLoadLibraryShim)(LPCWSTR, LPCWSTR, LPVOID, HMODULE*); +static HRESULT (WINAPI *pCreateConfigStream)(LPCWSTR, IStream**); static BOOL init_functionpointers(void) { @@ -42,6 +46,7 @@ static BOOL init_functionpointers(void) pGetCORSystemDirectory = (void *)GetProcAddress(hmscoree, "GetCORSystemDirectory"); pGetRequestedRuntimeInfo = (void *)GetProcAddress(hmscoree, "GetRequestedRuntimeInfo"); pLoadLibraryShim = (void *)GetProcAddress(hmscoree, "LoadLibraryShim"); + pCreateConfigStream = (void *)GetProcAddress(hmscoree, "CreateConfigStream"); if (!pGetCORVersion || !pGetCORSystemDirectory || !pGetRequestedRuntimeInfo || !pLoadLibraryShim) { @@ -244,6 +249,75 @@ static void test_loadlibraryshim(void) FreeLibrary(hdll); } +static const char xmldata[] = + "<?xml version=\"1.0\" ?>\n" + "<!DOCTYPE Config>\n" + "<Configuration>\n" + " <Name>Test</Name>\n" + " <Value>1234</Value>\n" + "</Configuration>"; + +static void create_xml_file(LPCWSTR filename) +{ + DWORD dwNumberOfBytesWritten; + HANDLE hfile = CreateFileW(filename, GENERIC_WRITE, 0, NULL, + CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); + ok(hfile != INVALID_HANDLE_VALUE, "File creation failed\n"); + WriteFile(hfile, xmldata, sizeof(xmldata) - 1, &dwNumberOfBytesWritten, NULL); + CloseHandle(hfile); +} + +static void test_createconfigstream(void) +{ + IStream *stream = NULL; + WCHAR file[] = {'c', 'o', 'n', 'f', '.', 'x', 'm', 'l', 0}; + WCHAR nonexistent[] = {'n', 'o', 'n', 'e', 'x', 'i', 's', 't', '.', 'x', 'm', 'l', 0}; + WCHAR path[MAX_PATH]; + HRESULT hr; + ULONG ret; + char buffer[256] = {0}; + + if (!pCreateConfigStream) + { + win_skip("CreateConfigStream not available\n"); + return; + } + + create_xml_file(file); + GetFullPathNameW(file, MAX_PATH, path, NULL); + + hr = pCreateConfigStream(NULL, &stream); + todo_wine ok(hr == E_FAIL, "CreateConfigStream returned %x\n", hr); + + hr = pCreateConfigStream(path, NULL); + todo_wine ok(hr == E_POINTER, "CreateConfigStream returned %x\n", hr); + + hr = pCreateConfigStream(NULL, NULL); + todo_wine ok(hr == E_POINTER, "CreateConfigStream returned %x\n", hr); + + hr = pCreateConfigStream(nonexistent, &stream); + todo_wine ok(hr == COR_E_FILENOTFOUND, "CreateConfigStream returned %x\n", hr); + ok(stream == NULL, "Expected stream to be NULL\n"); + + hr = pCreateConfigStream(path, &stream); + todo_wine ok(hr == S_OK, "CreateConfigStream failed, hr=%x\n", hr); + todo_wine ok(stream != NULL, "Expected non-NULL stream\n"); + + if (stream) + { + DWORD count; + + hr = IStream_Read(stream, &buffer, strlen(xmldata), &count); + ok(hr == S_OK, "IStream_Read failed, hr=%x\n", hr); + ok(count == strlen(xmldata), "wrong count: %u\n", count); + ok(!strcmp(buffer, xmldata), "Strings do not match\n"); + + ret = IStream_Release(stream); + ok(!ret, "ret=%d\n", ret); + } + DeleteFileW(file); +} + START_TEST(mscoree) { if (!init_functionpointers()) @@ -251,6 +325,7 @@ START_TEST(mscoree) test_versioninfo(); test_loadlibraryshim(); + test_createconfigstream(); FreeLibrary(hmscoree); }
1
0
0
0
Sergey Khodych : shdocvw: Handle local paths in navigate_url.
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: f3b10bc8fdfe5511db3525dcb3e8969646eebf3f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f3b10bc8fdfe5511db3525dcb…
Author: Sergey Khodych <khodych(a)gmail.com> Date: Sun May 15 01:38:36 2011 +0300 shdocvw: Handle local paths in navigate_url. --- dlls/shdocvw/navigate.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shdocvw/navigate.c b/dlls/shdocvw/navigate.c index 211aee5..6b78870 100644 --- a/dlls/shdocvw/navigate.c +++ b/dlls/shdocvw/navigate.c @@ -854,7 +854,7 @@ HRESULT navigate_url(DocHost *This, LPCWSTR url, const VARIANT *Flags, size = sizeof(new_url)/sizeof(WCHAR); hres = UrlApplySchemeW(url, new_url, &size, - URL_APPLY_GUESSSCHEME | URL_APPLY_DEFAULT); + URL_APPLY_GUESSSCHEME | URL_APPLY_GUESSFILE | URL_APPLY_DEFAULT); if(FAILED(hres)) { WARN("UrlApplyScheme failed: %08x\n", hres); new_url[0] = 0;
1
0
0
0
Sergey Khodych : shdocvw: Use UrlApplyScheme with URL_APPLY_GUESSFILE for local paths in create_moniker .
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: 1c6af1f337ebc4dd8ed5419fcb2e439a1a6266b0 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1c6af1f337ebc4dd8ed5419fc…
Author: Sergey Khodych <khodych(a)gmail.com> Date: Sun May 15 01:34:03 2011 +0300 shdocvw: Use UrlApplyScheme with URL_APPLY_GUESSFILE for local paths in create_moniker. --- dlls/shdocvw/navigate.c | 21 ++++++--------------- 1 files changed, 6 insertions(+), 15 deletions(-) diff --git a/dlls/shdocvw/navigate.c b/dlls/shdocvw/navigate.c index 09135a8..211aee5 100644 --- a/dlls/shdocvw/navigate.c +++ b/dlls/shdocvw/navigate.c @@ -578,21 +578,12 @@ static HRESULT create_moniker(LPCWSTR url, IMoniker **mon) if(PathIsURLW(url)) return CreateURLMoniker(NULL, url, mon); - if(url[1] == ':') { - size = sizeof(new_url); - hres = UrlCreateFromPathW(url, new_url, &size, 0); - if(FAILED(hres)) { - WARN("UrlCreateFromPathW failed: %08x\n", hres); - return hres; - } - }else { - size = sizeof(new_url)/sizeof(WCHAR); - hres = UrlApplySchemeW(url, new_url, &size, URL_APPLY_GUESSSCHEME); - TRACE("got %s\n", debugstr_w(new_url)); - if(FAILED(hres)) { - WARN("UrlApplyScheme failed: %08x\n", hres); - return hres; - } + size = sizeof(new_url)/sizeof(WCHAR); + hres = UrlApplySchemeW(url, new_url, &size, URL_APPLY_GUESSSCHEME | URL_APPLY_GUESSFILE); + TRACE("was %s got %s\n", debugstr_w(url), debugstr_w(new_url)); + if(FAILED(hres)) { + WARN("UrlApplyScheme failed: %08x\n", hres); + return hres; } return CreateURLMoniker(NULL, new_url, mon);
1
0
0
0
Sergey Khodych : shlwapi: Implement URL_APPLY_GUESSFILE in UrlApplyScheme.
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: 26541471ab5f3fa1cfa2a1e2e25b3a4bcb0c8895 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=26541471ab5f3fa1cfa2a1e2e…
Author: Sergey Khodych <khodych(a)gmail.com> Date: Sun May 15 01:30:09 2011 +0300 shlwapi: Implement URL_APPLY_GUESSFILE in UrlApplyScheme. --- dlls/shlwapi/tests/url.c | 8 ++++- dlls/shlwapi/url.c | 80 +++++++++++++++++++++++++++------------------ 2 files changed, 55 insertions(+), 33 deletions(-) diff --git a/dlls/shlwapi/tests/url.c b/dlls/shlwapi/tests/url.c index d116c16..1ef2aab 100644 --- a/dlls/shlwapi/tests/url.c +++ b/dlls/shlwapi/tests/url.c @@ -91,7 +91,12 @@ static const TEST_URL_APPLY TEST_APPLY[] = { {"
http://www.winehq.org
", URL_APPLY_GUESSSCHEME | URL_APPLY_DEFAULT, S_FALSE, TEST_APPLY_MAX_LENGTH, untouchedA}, {"", URL_APPLY_GUESSSCHEME | URL_APPLY_DEFAULT, S_OK, 7, "http://"}, {"", URL_APPLY_GUESSSCHEME, S_FALSE, TEST_APPLY_MAX_LENGTH, untouchedA}, - {"", URL_APPLY_DEFAULT, S_OK, 7, "http://"} + {"", URL_APPLY_DEFAULT, S_OK, 7, "http://"}, + {"u:\\windows", URL_APPLY_GUESSFILE | URL_APPLY_DEFAULT, S_OK, 18, "file:///u:/windows"}, + {"u:\\windows", URL_APPLY_GUESSFILE, S_OK, 18, "file:///u:/windows"}, + {"u:\\windows", URL_APPLY_DEFAULT, S_OK, 17, "
http://u:\\windows
"}, + {"file:///c:/windows", URL_APPLY_GUESSFILE , S_FALSE, TEST_APPLY_MAX_LENGTH, untouchedA}, + {"aa:\\windows", URL_APPLY_GUESSFILE , S_FALSE, TEST_APPLY_MAX_LENGTH, untouchedA}, }; /* ################ */ @@ -379,6 +384,7 @@ static const struct { {"c:foo\\bar", "file:///c:foo/bar", S_OK}, {"c:\\foo/b a%r", "file:///c:/foo/b%20a%25r", S_OK}, {"c:\\foo\\foo bar", "file:///c:/foo/foo%20bar", S_OK}, + {"file:///c:/foo/bar", "file:///c:/foo/bar", S_FALSE}, #if 0 /* The following test fails on native shlwapi as distributed with Win95/98. * Wine matches the behaviour of later versions. diff --git a/dlls/shlwapi/url.c b/dlls/shlwapi/url.c index 7fc37a9..0c68529 100644 --- a/dlls/shlwapi/url.c +++ b/dlls/shlwapi/url.c @@ -1700,6 +1700,39 @@ static HRESULT URL_GuessScheme(LPCWSTR pszIn, LPWSTR pszOut, LPDWORD pcchOut) return E_FAIL; } +static HRESULT URL_CreateFromPath(LPCWSTR pszPath, LPWSTR pszUrl, LPDWORD pcchUrl) +{ + DWORD needed; + HRESULT ret = S_OK; + WCHAR *pszNewUrl; + WCHAR file_colonW[] = {'f','i','l','e',':',0}; + WCHAR three_slashesW[] = {'/','/','/',0}; + PARSEDURLW parsed_url; + + parsed_url.cbSize = sizeof(parsed_url); + if(ParseURLW(pszPath, &parsed_url) == S_OK) { + if(parsed_url.nScheme != URL_SCHEME_INVALID && parsed_url.cchProtocol > 1) { + needed = strlenW(pszPath); + if (needed >= *pcchUrl) { + *pcchUrl = needed + 1; + return E_POINTER; + } else { + *pcchUrl = needed; + return S_FALSE; + } + } + } + + pszNewUrl = HeapAlloc(GetProcessHeap(), 0, (strlenW(pszPath) + 9) * sizeof(WCHAR)); /* "file:///" + pszPath_len + 1 */ + strcpyW(pszNewUrl, file_colonW); + if(isalphaW(pszPath[0]) && pszPath[1] == ':') + strcatW(pszNewUrl, three_slashesW); + strcatW(pszNewUrl, pszPath); + ret = UrlEscapeW(pszNewUrl, pszUrl, pcchUrl, URL_ESCAPE_PERCENT); + HeapFree(GetProcessHeap(), 0, pszNewUrl); + return ret; +} + static HRESULT URL_ApplyDefault(LPCWSTR pszIn, LPWSTR pszOut, LPDWORD pcchOut) { HKEY newkey; @@ -1747,11 +1780,18 @@ HRESULT WINAPI UrlApplySchemeW(LPCWSTR pszIn, LPWSTR pszOut, LPDWORD pcchOut, DW if (!pszIn || !pszOut || !pcchOut) return E_INVALIDARG; if (dwFlags & URL_APPLY_GUESSFILE) { - FIXME("(%s %p %p(%d) 0x%08x): stub URL_APPLY_GUESSFILE not implemented\n", - debugstr_w(pszIn), pszOut, pcchOut, *pcchOut, dwFlags); - strcpyW(pszOut, pszIn); - *pcchOut = strlenW(pszOut); - return S_FALSE; + if (*pcchOut > 1 && ':' == pszIn[1]) { + res1 = *pcchOut; + ret = URL_CreateFromPath(pszIn, pszOut, &res1); + if (ret == S_OK || ret == E_POINTER){ + *pcchOut = res1; + return ret; + } + else if (ret == S_FALSE) + { + return ret; + } + } } in_scheme.cbSize = sizeof(in_scheme); @@ -2408,12 +2448,7 @@ HRESULT WINAPI UrlCreateFromPathA(LPCSTR pszPath, LPSTR pszUrl, LPDWORD pcchUrl, */ HRESULT WINAPI UrlCreateFromPathW(LPCWSTR pszPath, LPWSTR pszUrl, LPDWORD pcchUrl, DWORD dwReserved) { - DWORD needed; HRESULT ret; - WCHAR *pszNewUrl; - WCHAR file_colonW[] = {'f','i','l','e',':',0}; - WCHAR three_slashesW[] = {'/','/','/',0}; - PARSEDURLW parsed_url; TRACE("(%s, %p, %p, 0x%08x)\n", debugstr_w(pszPath), pszUrl, pcchUrl, dwReserved); @@ -2423,30 +2458,11 @@ HRESULT WINAPI UrlCreateFromPathW(LPCWSTR pszPath, LPWSTR pszUrl, LPDWORD pcchUr if (!pszUrl || !pcchUrl) return E_INVALIDARG; + ret = URL_CreateFromPath(pszPath, pszUrl, pcchUrl); - parsed_url.cbSize = sizeof(parsed_url); - if(ParseURLW(pszPath, &parsed_url) == S_OK) { - if(parsed_url.nScheme != URL_SCHEME_INVALID && parsed_url.cchProtocol > 1) { - needed = strlenW(pszPath); - if (needed >= *pcchUrl) { - *pcchUrl = needed + 1; - return E_POINTER; - } else { - *pcchUrl = needed; - strcpyW(pszUrl, pszPath); - return S_FALSE; - } - } - } - - pszNewUrl = HeapAlloc(GetProcessHeap(), 0, (strlenW(pszPath) + 9) * sizeof(WCHAR)); /* "file:///" + pszPath_len + 1 */ - strcpyW(pszNewUrl, file_colonW); - if(isalphaW(pszPath[0]) && pszPath[1] == ':') - strcatW(pszNewUrl, three_slashesW); - strcatW(pszNewUrl, pszPath); - ret = UrlEscapeW(pszNewUrl, pszUrl, pcchUrl, URL_ESCAPE_PERCENT); + if (S_FALSE == ret) + strcpyW(pszUrl, pszPath); - HeapFree(GetProcessHeap(), 0, pszNewUrl); return ret; }
1
0
0
0
Sergey Khodych : shlwapi: Don't copy valid scheme in UrlApplySchemeW.
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: 2e1bec528f983a8ec9cd1d4df79bc2aa0866f856 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2e1bec528f983a8ec9cd1d4df…
Author: Sergey Khodych <khodych(a)gmail.com> Date: Sun May 15 00:48:57 2011 +0300 shlwapi: Don't copy valid scheme in UrlApplySchemeW. --- dlls/shlwapi/tests/url.c | 4 ++++ dlls/shlwapi/url.c | 14 -------------- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/dlls/shlwapi/tests/url.c b/dlls/shlwapi/tests/url.c index 5a035ac..d116c16 100644 --- a/dlls/shlwapi/tests/url.c +++ b/dlls/shlwapi/tests/url.c @@ -85,6 +85,10 @@ static const TEST_URL_APPLY TEST_APPLY[] = { {"
winehq.org
", URL_APPLY_GUESSSCHEME | URL_APPLY_DEFAULT, S_OK, 17, "
http://winehq.org
"}, {"
winehq.org
", URL_APPLY_GUESSSCHEME, S_FALSE, TEST_APPLY_MAX_LENGTH, untouchedA}, {"
winehq.org
", URL_APPLY_DEFAULT, S_OK, 17, "
http://winehq.org
"}, + {"
http://www.winehq.org
", URL_APPLY_GUESSSCHEME , S_FALSE, TEST_APPLY_MAX_LENGTH, untouchedA}, + {"
http://www.winehq.org
", URL_APPLY_GUESSSCHEME | URL_APPLY_FORCEAPPLY, S_FALSE, TEST_APPLY_MAX_LENGTH, untouchedA}, + {"
http://www.winehq.org
", URL_APPLY_GUESSSCHEME | URL_APPLY_FORCEAPPLY | URL_APPLY_DEFAULT, S_OK, 28, "
http://http://www.winehq.org
"}, + {"
http://www.winehq.org
", URL_APPLY_GUESSSCHEME | URL_APPLY_DEFAULT, S_FALSE, TEST_APPLY_MAX_LENGTH, untouchedA}, {"", URL_APPLY_GUESSSCHEME | URL_APPLY_DEFAULT, S_OK, 7, "http://"}, {"", URL_APPLY_GUESSSCHEME, S_FALSE, TEST_APPLY_MAX_LENGTH, untouchedA}, {"", URL_APPLY_DEFAULT, S_OK, 7, "http://"} diff --git a/dlls/shlwapi/url.c b/dlls/shlwapi/url.c index b8c51a4..7fc37a9 100644 --- a/dlls/shlwapi/url.c +++ b/dlls/shlwapi/url.c @@ -1764,20 +1764,6 @@ HRESULT WINAPI UrlApplySchemeW(LPCWSTR pszIn, LPWSTR pszOut, LPDWORD pcchOut, DW return ret; } } - else { - /* we have a scheme, see if valid (known scheme) */ - if (in_scheme.nScheme) { - /* have valid scheme, so just copy and exit */ - if (strlenW(pszIn) + 1 > *pcchOut) { - *pcchOut = strlenW(pszIn) + 1; - return E_POINTER; - } - strcpyW(pszOut, pszIn); - *pcchOut = strlenW(pszOut); - TRACE("valid scheme, returning copy\n"); - return S_OK; - } - } /* If we are here, then either invalid scheme, * or no scheme and can't/failed guess.
1
0
0
0
Sergey Khodych : shdocvw: Don' t use separate call of UrlApplySchemeW for default scheme.
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: 2034439d664d1bdfa032c3bd6daf8e43f5740c9c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2034439d664d1bdfa032c3bd6…
Author: Sergey Khodych <khodych(a)gmail.com> Date: Sun May 15 00:18:10 2011 +0300 shdocvw: Don't use separate call of UrlApplySchemeW for default scheme. --- dlls/shdocvw/shdocvw_main.c | 8 +------- 1 files changed, 1 insertions(+), 7 deletions(-) diff --git a/dlls/shdocvw/shdocvw_main.c b/dlls/shdocvw/shdocvw_main.c index a0070b4..4386ddc 100644 --- a/dlls/shdocvw/shdocvw_main.c +++ b/dlls/shdocvw/shdocvw_main.c @@ -333,14 +333,8 @@ DWORD WINAPI ParseURLFromOutsideSourceW(LPCWSTR url, LPWSTR out, LPDWORD plen, L if (!PathIsURLW(ptr)) { len = sizeof(buffer_in) / sizeof(buffer_in[0]); buffer_in[0] = 0; - hr = UrlApplySchemeW(ptr, buffer_in, &len, URL_APPLY_GUESSSCHEME); + hr = UrlApplySchemeW(ptr, buffer_in, &len, URL_APPLY_GUESSSCHEME | URL_APPLY_DEFAULT); TRACE("got 0x%x with %s\n", hr, debugstr_w(buffer_in)); - if (hr != S_OK) { - /* when we can't guess the scheme, use the default scheme */ - len = sizeof(buffer_in) / sizeof(buffer_in[0]); - hr = UrlApplySchemeW(ptr, buffer_in, &len, URL_APPLY_DEFAULT); - } - if (hr == S_OK) { /* we parsed the url to buffer_in */ ptr = buffer_in;
1
0
0
0
Owen Rudge : user32: Add separate sysmenu for MDI child windows.
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: c55ff281c7d8e0dad295dc2104dba7b9316e09f3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c55ff281c7d8e0dad295dc210…
Author: Owen Rudge <orudge(a)codeweavers.com> Date: Mon May 16 17:15:02 2011 +0100 user32: Add separate sysmenu for MDI child windows. --- dlls/user32/menu.c | 14 ++++++++++---- dlls/user32/user32.rc | 13 +++++++++++++ po/ar.po | 35 ++++++++++++++++++++++------------- po/bg.po | 35 ++++++++++++++++++++++------------- po/ca.po | 35 ++++++++++++++++++++++------------- po/cs.po | 35 ++++++++++++++++++++++------------- po/da.po | 35 ++++++++++++++++++++++------------- po/de.po | 35 ++++++++++++++++++++++------------- po/el.po | 34 +++++++++++++++++++++------------- po/en.po | 34 +++++++++++++++++++++------------- po/en_US.po | 34 +++++++++++++++++++++------------- po/eo.po | 35 ++++++++++++++++++++++------------- po/es.po | 35 ++++++++++++++++++++++------------- po/fa.po | 35 ++++++++++++++++++++++------------- po/fi.po | 35 ++++++++++++++++++++++------------- po/fr.po | 35 ++++++++++++++++++++++------------- po/he.po | 35 ++++++++++++++++++++++------------- po/hi.po | 34 +++++++++++++++++++++------------- po/hu.po | 35 ++++++++++++++++++++++------------- po/it.po | 35 ++++++++++++++++++++++------------- po/ja.po | 35 ++++++++++++++++++++++------------- po/ko.po | 35 ++++++++++++++++++++++------------- po/lt.po | 35 ++++++++++++++++++++++------------- po/ml.po | 34 +++++++++++++++++++++------------- po/nb_NO.po | 35 ++++++++++++++++++++++------------- po/nl.po | 35 ++++++++++++++++++++++------------- po/or.po | 34 +++++++++++++++++++++------------- po/pa.po | 34 +++++++++++++++++++++------------- po/pl.po | 35 ++++++++++++++++++++++------------- po/pt_BR.po | 35 ++++++++++++++++++++++------------- po/pt_PT.po | 35 ++++++++++++++++++++++------------- po/rm.po | 34 +++++++++++++++++++++------------- po/ro.po | 35 ++++++++++++++++++++++------------- po/ru.po | 35 ++++++++++++++++++++++------------- po/sk.po | 35 ++++++++++++++++++++++------------- po/sl.po | 35 ++++++++++++++++++++++------------- po/sr_RS(a)cyrillic.po | 35 ++++++++++++++++++++++------------- po/sr_RS(a)latin.po | 35 ++++++++++++++++++++++------------- po/sv.po | 35 ++++++++++++++++++++++------------- po/te.po | 34 +++++++++++++++++++++------------- po/th.po | 35 ++++++++++++++++++++++------------- po/tr.po | 35 ++++++++++++++++++++++------------- po/uk.po | 35 ++++++++++++++++++++++------------- po/wa.po | 35 ++++++++++++++++++++++------------- po/wine.pot | 34 +++++++++++++++++++++------------- po/zh_CN.po | 35 ++++++++++++++++++++++------------- po/zh_TW.po | 35 ++++++++++++++++++++++------------- 47 files changed, 1003 insertions(+), 589 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=c55ff281c7d8e0dad295d…
1
0
0
0
Ken Thomases : gdi32: Fix leak of FullName of replaced font face.
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: e6d6fbf6e94282f7063ab3d50bdc8b90a4b88a0f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e6d6fbf6e94282f7063ab3d50…
Author: Ken Thomases <ken(a)codeweavers.com> Date: Mon May 16 18:20:09 2011 -0500 gdi32: Fix leak of FullName of replaced font face. --- dlls/gdi32/freetype.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index d6271db..3b12422 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -262,7 +262,7 @@ struct enum_data typedef struct tagFace { struct list entry; WCHAR *StyleName; - const WCHAR *FullName; + WCHAR *FullName; char *file; void *font_data_ptr; DWORD font_data_size; @@ -1454,6 +1454,7 @@ static INT AddFontToList(const char *file, void *font_data_ptr, DWORD font_data_ list_remove(&face->entry); HeapFree(GetProcessHeap(), 0, face->file); HeapFree(GetProcessHeap(), 0, face->StyleName); + HeapFree(GetProcessHeap(), 0, face->FullName); HeapFree(GetProcessHeap(), 0, face); break; }
1
0
0
0
Marcus Meissner : dmstyle: Mark internal symbols with hidden visibility.
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: 10371fcc501e390746d329454ae4089a7d63ebfd URL:
http://source.winehq.org/git/wine.git/?a=commit;h=10371fcc501e390746d329454…
Author: Marcus Meissner <meissner(a)suse.de> Date: Fri May 13 16:59:26 2011 +0200 dmstyle: Mark internal symbols with hidden visibility. --- dlls/dmstyle/dmstyle_private.h | 26 +++++++++++++------------- dlls/dmstyle/dmutils.h | 12 ++++++------ 2 files changed, 19 insertions(+), 19 deletions(-) diff --git a/dlls/dmstyle/dmstyle_private.h b/dlls/dmstyle/dmstyle_private.h index cfbe7b5..4b450db 100644 --- a/dlls/dmstyle/dmstyle_private.h +++ b/dlls/dmstyle/dmstyle_private.h @@ -58,7 +58,7 @@ typedef struct IDirectMusicStyleTrack IDirectMusicStyleTrack; /***************************************************************************** * ClassFactory */ -extern HRESULT WINAPI DMUSIC_CreateDirectMusicStyleImpl (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); +extern HRESULT WINAPI DMUSIC_CreateDirectMusicStyleImpl (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; /***************************************************************************** * Auxiliary definitions @@ -92,13 +92,13 @@ typedef struct _DMUS_PRIVATE_STYLE_ITEM { IDirectMusicStyle8* pObject; } DMUS_PRIVATE_STYLE_ITEM, *LPDMUS_PRIVATE_STYLE_ITEM; -extern HRESULT WINAPI DMUSIC_CreateDirectMusicAuditionTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); -extern HRESULT WINAPI DMUSIC_CreateDirectMusicChordTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); -extern HRESULT WINAPI DMUSIC_CreateDirectMusicCommandTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); -extern HRESULT WINAPI DMUSIC_CreateDirectMusicMelodyFormulationTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); -extern HRESULT WINAPI DMUSIC_CreateDirectMusicMotifTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); -extern HRESULT WINAPI DMUSIC_CreateDirectMusicMuteTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); -extern HRESULT WINAPI DMUSIC_CreateDirectMusicStyleTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); +extern HRESULT WINAPI DMUSIC_CreateDirectMusicAuditionTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; +extern HRESULT WINAPI DMUSIC_CreateDirectMusicChordTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; +extern HRESULT WINAPI DMUSIC_CreateDirectMusicCommandTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; +extern HRESULT WINAPI DMUSIC_CreateDirectMusicMelodyFormulationTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; +extern HRESULT WINAPI DMUSIC_CreateDirectMusicMotifTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; +extern HRESULT WINAPI DMUSIC_CreateDirectMusicMuteTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; +extern HRESULT WINAPI DMUSIC_CreateDirectMusicStyleTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; /***************************************************************************** * IDirectMusicStyle8Impl implementation structure @@ -186,12 +186,12 @@ struct IDirectMusicMelodyFormulationTrack { }; /* IUnknown: */ -extern HRESULT WINAPI IDirectMusicMelodyFormulationTrack_IUnknown_QueryInterface (LPUNKNOWN iface, REFIID riid, LPVOID *ppobj); -extern ULONG WINAPI IDirectMusicMelodyFormulationTrack_IUnknown_AddRef (LPUNKNOWN iface); +extern HRESULT WINAPI IDirectMusicMelodyFormulationTrack_IUnknown_QueryInterface (LPUNKNOWN iface, REFIID riid, LPVOID *ppobj) DECLSPEC_HIDDEN; +extern ULONG WINAPI IDirectMusicMelodyFormulationTrack_IUnknown_AddRef (LPUNKNOWN iface) DECLSPEC_HIDDEN; /* IDirectMusicTrack(8): */ -extern ULONG WINAPI IDirectMusicMelodyFormulationTrack_IDirectMusicTrack_AddRef (LPDIRECTMUSICTRACK8 iface); +extern ULONG WINAPI IDirectMusicMelodyFormulationTrack_IDirectMusicTrack_AddRef (LPDIRECTMUSICTRACK8 iface) DECLSPEC_HIDDEN; /* IPersistStream: */ -extern ULONG WINAPI IDirectMusicMelodyFormulationTrack_IPersistStream_AddRef (LPPERSISTSTREAM iface); +extern ULONG WINAPI IDirectMusicMelodyFormulationTrack_IPersistStream_AddRef (LPPERSISTSTREAM iface) DECLSPEC_HIDDEN; /***************************************************************************** * IDirectMusicMotifTrack implementation structure @@ -240,7 +240,7 @@ struct IDirectMusicStyleTrack { /********************************************************************** * Dll lifetime tracking declaration for dmstyle.dll */ -extern LONG DMSTYLE_refCount; +extern LONG DMSTYLE_refCount DECLSPEC_HIDDEN; static inline void DMSTYLE_LockModule(void) { InterlockedIncrement( &DMSTYLE_refCount ); } static inline void DMSTYLE_UnlockModule(void) { InterlockedDecrement( &DMSTYLE_refCount ); } diff --git a/dlls/dmstyle/dmutils.h b/dlls/dmstyle/dmutils.h index 8a2b6e6..9f2f98e 100644 --- a/dlls/dmstyle/dmutils.h +++ b/dlls/dmstyle/dmutils.h @@ -32,9 +32,9 @@ typedef struct _DMUS_PRIVATE_CHUNK { /** * Parsing utilities */ -extern HRESULT IDirectMusicUtils_IPersistStream_ParseDescGeneric (DMUS_PRIVATE_CHUNK* pChunk, IStream* pStm, LPDMUS_OBJECTDESC pDesc); -extern HRESULT IDirectMusicUtils_IPersistStream_ParseUNFOGeneric (DMUS_PRIVATE_CHUNK* pChunk, IStream* pStm, LPDMUS_OBJECTDESC pDesc); -extern HRESULT IDirectMusicUtils_IPersistStream_ParseReference (LPPERSISTSTREAM iface, DMUS_PRIVATE_CHUNK* pChunk, IStream* pStm, IDirectMusicObject** ppObject); +extern HRESULT IDirectMusicUtils_IPersistStream_ParseDescGeneric (DMUS_PRIVATE_CHUNK* pChunk, IStream* pStm, LPDMUS_OBJECTDESC pDesc) DECLSPEC_HIDDEN; +extern HRESULT IDirectMusicUtils_IPersistStream_ParseUNFOGeneric (DMUS_PRIVATE_CHUNK* pChunk, IStream* pStm, LPDMUS_OBJECTDESC pDesc) DECLSPEC_HIDDEN; +extern HRESULT IDirectMusicUtils_IPersistStream_ParseReference (LPPERSISTSTREAM iface, DMUS_PRIVATE_CHUNK* pChunk, IStream* pStm, IDirectMusicObject** ppObject) DECLSPEC_HIDDEN; /** * Debug utilities @@ -61,11 +61,11 @@ typedef struct { #define GE(x) { &x, #x } /* FOURCC to string conversion for debug messages */ -extern const char *debugstr_fourcc (DWORD fourcc); +extern const char *debugstr_fourcc (DWORD fourcc) DECLSPEC_HIDDEN; /* returns name of given GUID */ -extern const char *debugstr_dmguid (const GUID *id); +extern const char *debugstr_dmguid (const GUID *id) DECLSPEC_HIDDEN; /* dump whole DMUS_OBJECTDESC struct */ -extern const char *debugstr_DMUS_OBJECTDESC (LPDMUS_OBJECTDESC pDesc); +extern const char *debugstr_DMUS_OBJECTDESC (LPDMUS_OBJECTDESC pDesc) DECLSPEC_HIDDEN; #endif /* __WINE_DMUTILS_H */
1
0
0
0
Marcus Meissner : dmscript: Mark internal symbols with hidden visibility.
by Alexandre Julliard
17 May '11
17 May '11
Module: wine Branch: master Commit: f301596ce357287b178ffbf88534d795adc330f0 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f301596ce357287b178ffbf88…
Author: Marcus Meissner <meissner(a)suse.de> Date: Fri May 13 16:58:10 2011 +0200 dmscript: Mark internal symbols with hidden visibility. --- dlls/dmscript/dmscript_private.h | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/dmscript/dmscript_private.h b/dlls/dmscript/dmscript_private.h index c152ecc..c31164f 100644 --- a/dlls/dmscript/dmscript_private.h +++ b/dlls/dmscript/dmscript_private.h @@ -52,9 +52,9 @@ typedef struct IDirectMusicScriptTrack IDirectMusicScriptTrack; /***************************************************************************** * ClassFactory */ -extern HRESULT WINAPI DMUSIC_CreateDirectMusicScriptImpl (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); +extern HRESULT WINAPI DMUSIC_CreateDirectMusicScriptImpl (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; -extern HRESULT WINAPI DMUSIC_CreateDirectMusicScriptTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter); +extern HRESULT WINAPI DMUSIC_CreateDirectMusicScriptTrack (LPCGUID lpcGUID, LPVOID* ppobj, LPUNKNOWN pUnkOuter) DECLSPEC_HIDDEN; /***************************************************************************** * IDirectMusicScriptImpl implementation structure @@ -93,7 +93,7 @@ struct IDirectMusicScriptTrack { /********************************************************************** * Dll lifetime tracking declaration for dmscript.dll */ -extern LONG DMSCRIPT_refCount; +extern LONG DMSCRIPT_refCount DECLSPEC_HIDDEN; static inline void DMSCRIPT_LockModule(void) { InterlockedIncrement( &DMSCRIPT_refCount ); } static inline void DMSCRIPT_UnlockModule(void) { InterlockedDecrement( &DMSCRIPT_refCount ); } @@ -130,10 +130,10 @@ typedef struct { #define ICOM_THIS_MULTI(impl,field,iface) impl* const This=(impl*)((char*)(iface) - offsetof(impl,field)) /* FOURCC to string conversion for debug messages */ -extern const char *debugstr_fourcc (DWORD fourcc); +extern const char *debugstr_fourcc (DWORD fourcc) DECLSPEC_HIDDEN; /* returns name of given GUID */ -extern const char *debugstr_dmguid (const GUID *id); +extern const char *debugstr_dmguid (const GUID *id) DECLSPEC_HIDDEN; /* dump whole DMUS_OBJECTDESC struct */ -extern const char *debugstr_DMUS_OBJECTDESC (LPDMUS_OBJECTDESC pDesc); +extern const char *debugstr_DMUS_OBJECTDESC (LPDMUS_OBJECTDESC pDesc) DECLSPEC_HIDDEN; #endif /* __WINE_DMSCRIPT_PRIVATE_H */
1
0
0
0
← Newer
1
...
46
47
48
49
50
51
52
...
95
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
Results per page:
10
25
50
100
200