wine-commits June 2011

wine-commits@winehq.org

2 participants
809 discussions

Henri Verbeet : wined3d: Use surface_load_location() instead of surface_internal_preload() in wined3d_device_update_surface().
by Alexandre Julliard 17 Jun '11

17 Jun '11

Module: wine Branch: master Commit: 3a1d151561dc48243009d105a5f3adb6221515c4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3a1d151561dc48243009d105a… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Thu Jun 16 22:38:24 2011 +0200 wined3d: Use surface_load_location() instead of surface_internal_preload() in wined3d_device_update_surface(). --- dlls/wined3d/device.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index ed52831..67c38aa 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -4834,7 +4834,7 @@ HRESULT CDECL wined3d_device_update_surface(struct wined3d_device *device, LEAVE_GL(); /* Make sure the surface is loaded and up to date */ - surface_internal_preload(dst_surface, SRGB_RGB); + surface_load_location(dst_surface, SFLAG_INTEXTURE, NULL); surface_bind(dst_surface, gl_info, FALSE); data.buffer_object = 0;

1 0

André Hentschel : winebuild: get_asm_ptr_keyword is not needed for ARM.
by Alexandre Julliard 17 Jun '11

17 Jun '11

Module: wine Branch: master Commit: cd9ff09d8e3b147c376e68b92560de1c1a522fe1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=cd9ff09d8e3b147c376e68b92… Author: André Hentschel <nerv(a)dawncrow.de> Date: Thu Jun 16 22:06:33 2011 +0200 winebuild: get_asm_ptr_keyword is not needed for ARM. --- tools/winebuild/import.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/winebuild/import.c b/tools/winebuild/import.c index a2c51ea..b0901a6 100644 --- a/tools/winebuild/import.c +++ b/tools/winebuild/import.c @@ -673,7 +673,7 @@ static void output_import_thunk( const char *name, const char *table, int pos ) case CPU_ARM: output( "\tldr IP,[PC,#0]\n"); output( "\tmov PC,PC\n"); - output( "\t%s %s\n", get_asm_ptr_keyword(), table ); + output( "\t.long %s\n", table ); output( "\tldr PC,[IP,#%d]\n", pos); break; case CPU_POWERPC: @@ -989,7 +989,7 @@ static void output_delayed_import_thunks( const DLLSPEC *spec ) output( "\tmov LR,PC\n"); output( "\tadd LR,LR,#8\n"); output( "\tldr PC,[PC,#-4]\n"); - output( "\t%s %s\n", get_asm_ptr_keyword(), asm_name("__wine_spec_delay_load") ); + output( "\t.long %s\n", asm_name("__wine_spec_delay_load") ); output( "\tmov IP,r0\n"); output( "\tldmfd SP!, {r4-r10,FP,LR}\n" ); output( "\tldmfd SP!, {r0-r3}\n" ); @@ -1084,7 +1084,7 @@ static void output_delayed_import_thunks( const DLLSPEC *spec ) output( "\tmov r0, r1\n" ); output( "\tadd r0, #%d\n", j ); output( "\tldr PC,[PC,#-4]\n"); - output( "\t%s %s\n", get_asm_ptr_keyword(), asm_name("__wine_delay_load_asm") ); + output( "\t.long %s\n", asm_name("__wine_delay_load_asm") ); break; case CPU_POWERPC: switch(target_platform)

1 0

Austin English : netapi32: Add a stub for DsGetSiteNameA.
by Alexandre Julliard 17 Jun '11

17 Jun '11

Module: wine Branch: master Commit: 94ae7ebdaada5e590db0402946d8b76056417e9f URL: http://source.winehq.org/git/wine.git/?a=commit;h=94ae7ebdaada5e590db040294… Author: Austin English <austinenglish(a)gmail.com> Date: Thu Jun 16 12:48:59 2011 -0700 netapi32: Add a stub for DsGetSiteNameA. --- dlls/netapi32/ds.c | 6 ++++++ dlls/netapi32/netapi32.spec | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/dlls/netapi32/ds.c b/dlls/netapi32/ds.c index 386e222..e7bbe9c 100644 --- a/dlls/netapi32/ds.c +++ b/dlls/netapi32/ds.c @@ -58,6 +58,12 @@ DWORD WINAPI DsGetSiteNameW(LPCWSTR ComputerName, LPWSTR *SiteName) return ERROR_CALL_NOT_IMPLEMENTED; } +DWORD WINAPI DsGetSiteNameA(LPCSTR ComputerName, LPSTR *SiteName) +{ + FIXME("(%s, %p): stub\n", debugstr_a(ComputerName), SiteName); + return ERROR_CALL_NOT_IMPLEMENTED; +} + /************************************************************ * DsRoleFreeMemory (NETAPI32.@) * diff --git a/dlls/netapi32/netapi32.spec b/dlls/netapi32/netapi32.spec index 7905504..28d6427 100644 --- a/dlls/netapi32/netapi32.spec +++ b/dlls/netapi32/netapi32.spec @@ -9,8 +9,8 @@ @ stub DsGetDcOpen @ stub DsGetDcSiteCoverage @ stub DsGetForestTrustInformationW -@ stub DsGetSiteNameA # (str str) -@ stdcall DsGetSiteNameW(wstr wstr) +@ stdcall DsGetSiteNameA(str ptr) +@ stdcall DsGetSiteNameW(wstr ptr) @ stub DsMergeForestTrustInformationW @ stdcall DsRoleFreeMemory(ptr) @ stdcall DsRoleGetPrimaryDomainInformation(wstr long ptr)

1 0

Aric Stewart : po: Add a number of missing '\n' characters in translations.
by Alexandre Julliard 17 Jun '11

17 Jun '11

Module: wine Branch: master Commit: 0d8e1951d4d8b0987a5766c68846b273a2208256 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0d8e1951d4d8b0987a5766c68… Author: Aric Stewart <aric(a)codeweavers.com> Date: Thu Jun 16 13:56:05 2011 -0500 po: Add a number of missing '\n' characters in translations. --- po/pl.po | 14 +++++++------- po/sv.po | 4 ++-- po/zh_CN.po | 4 ++-- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/po/pl.po b/po/pl.po index 4757f34..c89a475 100644 --- a/po/pl.po +++ b/po/pl.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: http://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2011-04-28 19:00+0100\n" +"PO-Revision-Date: 2011-06-16 13:50-0500\n" "Last-Translator: Łukasz Wojniłowicz\n" "Language-Team: none\n" "Language: Polish\n" @@ -3314,7 +3314,7 @@ msgstr "Różne konto usługi\n" #: winerror.mc:1276 msgid "Driver failure cannot be detected\n" -msgstr "Nie można wykryć niepowodzenia sterownika" +msgstr "Nie można wykryć niepowodzenia sterownikai\n" #: winerror.mc:1281 msgid "Process abort cannot be detected\n" @@ -3806,7 +3806,7 @@ msgstr "Wykonaj operację nawet gdy nic się nie zmieniło\n" #: winerror.mc:1896 msgid "The user profile is invalid\n" -msgstr "Profil użytkownika jest niepoprawny." +msgstr "Profil użytkownika jest niepoprawny.\n" #: winerror.mc:1901 msgid "Not supported on Small Business Server\n" @@ -4538,7 +4538,7 @@ msgstr "Instalacja już jest uruchomiona\n" #: winerror.mc:2816 msgid "Installation package failed to open\n" -msgstr "Niepowodzenie przy otwieraniu paczki instalacyjnej" +msgstr "Niepowodzenie przy otwieraniu paczki instalacyjnej\n" #: winerror.mc:2821 msgid "Installation package is invalid\n" @@ -4558,7 +4558,7 @@ msgstr "Język instalacji niewspierany\n" #: winerror.mc:2841 msgid "Installation transform failed to apply\n" -msgstr "Nieudane zastosowanie transformacji instalacji" +msgstr "Nieudane zastosowanie transformacji instalacji\n" #: winerror.mc:2846 msgid "Installation package rejected\n" @@ -4570,7 +4570,7 @@ msgstr "Funkcja nie mogła być wywołana\n" #: winerror.mc:2856 msgid "Function failed\n" -msgstr "Funkcja zakończyła niepowodzeniem" +msgstr "Funkcja zakończyła niepowodzeniem\n" #: winerror.mc:2861 msgid "Invalid table\n" @@ -5218,7 +5218,7 @@ msgstr "Symbol potoku RPC zamknięty\n" #: winerror.mc:3671 msgid "Discipline error on RPC pipe\n" -msgstr "Błąd dyscypliny na symbolu potoku RPC" +msgstr "Błąd dyscypliny na symbolu potoku RPC\n" #: winerror.mc:3676 msgid "No data on RPC pipe\n" diff --git a/po/sv.po b/po/sv.po index 280730a..5e7172b 100644 --- a/po/sv.po +++ b/po/sv.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: http://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2011-04-18 22:15+02:00\n" +"PO-Revision-Date: 2011-06-16 13:51-0500\n" "Last-Translator: Anders Jonsson <anders.jonsson(a)norsjonet.se>\n" "Language-Team: none\n" "Language: Swedish\n" @@ -4548,7 +4548,7 @@ msgstr "Installationspaketet är ogiltigt\n" #: winerror.mc:2826 msgid "Installer user interface failed\n" -msgstr "Användargränssnittet för installationsprogrammet misslyckades" +msgstr "Användargränssnittet för installationsprogrammet misslyckades\n" #: winerror.mc:2831 msgid "Failed to open installation log file\n" diff --git a/po/zh_CN.po b/po/zh_CN.po index 5523807..fd0765f 100644 --- a/po/zh_CN.po +++ b/po/zh_CN.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: http://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: N/A\n" +"PO-Revision-Date: 2011-06-16 13:52-0500\n" "Last-Translator: Automatically generated\n" "Language-Team: none\n" "Language: Chinese (PRC)\n" @@ -8273,7 +8273,7 @@ msgstr "" #: cmd.rc:266 msgid "%s: File Not Found\n" -msgstr "找不到文件" +msgstr "找不到文件\n" #: cmd.rc:267 msgid "No help available for %s\n"

1 0

Alexandre Julliard : kernel32: Create an orphaned process in exec_process so that all initialization is done anew in the child process .
by Alexandre Julliard 17 Jun '11

17 Jun '11

Module: wine Branch: master Commit: 1b0d2330c939807121ef4d68627e438da55d1921 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1b0d2330c939807121ef4d686… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jun 16 22:46:25 2011 +0200 kernel32: Create an orphaned process in exec_process so that all initialization is done anew in the child process. --- dlls/kernel32/process.c | 189 +++++++++++++++++++++++++++------------------- 1 files changed, 111 insertions(+), 78 deletions(-) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index 6b8ff99..f3504af 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -1786,6 +1786,85 @@ static BOOL terminate_main_thread(void) #endif /*********************************************************************** + * exec_loader + */ +static pid_t exec_loader( LPCWSTR cmd_line, unsigned int flags, int socketfd, + int stdin_fd, int stdout_fd, const char *unixdir, char *winedebug, + const struct binary_info *binary_info, int exec_only ) +{ + pid_t pid; + char *wineloader = NULL; + const char *loader = NULL; + char **argv; + + argv = build_argv( cmd_line, 1 ); + + if (!is_win64 ^ !(binary_info->flags & BINARY_FLAG_64BIT)) + loader = get_alternate_loader( &wineloader ); + + if (exec_only || !(pid = fork())) /* child */ + { + char preloader_reserve[64], socket_env[64]; + + if (flags & (CREATE_NEW_PROCESS_GROUP | CREATE_NEW_CONSOLE | DETACHED_PROCESS)) + { + if (!(pid = fork())) + { + int fd = open( "/dev/null", O_RDWR ); + setsid(); + /* close stdin and stdout */ + if (fd != -1) + { + dup2( fd, 0 ); + dup2( fd, 1 ); + close( fd ); + } + } + else if (pid != -1) _exit(0); /* parent */ + } + else + { + if (stdin_fd != -1) dup2( stdin_fd, 0 ); + if (stdout_fd != -1) dup2( stdout_fd, 1 ); + } + + if (stdin_fd != -1) close( stdin_fd ); + if (stdout_fd != -1) close( stdout_fd ); + + /* Reset signals that we previously set to SIG_IGN */ + signal( SIGPIPE, SIG_DFL ); + signal( SIGCHLD, SIG_DFL ); + + sprintf( socket_env, "WINESERVERSOCKET=%u", socketfd ); + sprintf( preloader_reserve, "WINEPRELOADRESERVE=%lx-%lx", + (unsigned long)binary_info->res_start, (unsigned long)binary_info->res_end ); + + putenv( preloader_reserve ); + putenv( socket_env ); + if (winedebug) putenv( winedebug ); + if (wineloader) putenv( wineloader ); + if (unixdir) chdir(unixdir); + + if (argv) + { + do + { + wine_exec_wine_binary( loader, argv, getenv("WINELOADER") ); + } +#ifdef __APPLE__ + while (errno == ENOTSUP && exec_only && terminate_main_thread()); +#else + while (0); +#endif + } + _exit(1); + } + HeapFree( GetProcessHeap(), 0, wineloader ); + HeapFree( GetProcessHeap(), 0, argv ); + return pid; +} + +/*********************************************************************** * create_process * * Create a new process. If hFile is a valid handle we have an exe @@ -1801,9 +1880,6 @@ static BOOL create_process( HANDLE hFile, LPCWSTR filename, LPWSTR cmd_line, LPW HANDLE process_info; WCHAR *env_end; char *winedebug = NULL; - char *wineloader = NULL; - const char *loader = NULL; - char **argv; startup_info_t *startup_info; DWORD startup_info_size; int socketfd[2], stdin_fd = -1, stdout_fd = -1; @@ -1817,12 +1893,42 @@ static BOOL create_process( HANDLE hFile, LPCWSTR filename, LPWSTR cmd_line, LPW return FALSE; } + /* create the socket for the new process */ + + if (socketpair( PF_UNIX, SOCK_STREAM, 0, socketfd ) == -1) + { + SetLastError( ERROR_TOO_MANY_OPEN_FILES ); + return FALSE; + } + + if (exec_only) /* things are much simpler in this case */ + { + wine_server_send_fd( socketfd[1] ); + close( socketfd[1] ); + SERVER_START_REQ( new_process ) + { + req->create_flags = flags; + req->socket_fd = socketfd[1]; + req->exe_file = wine_server_obj_handle( hFile ); + ret = !wine_server_call_err( req ); + } + SERVER_END_REQ; + + if (ret) exec_loader( cmd_line, flags, socketfd[0], stdin_fd, stdout_fd, unixdir, + winedebug, binary_info, TRUE ); + + close( socketfd[0] ); + return FALSE; + } + RtlAcquirePebLock(); if (!(startup_info = create_startup_info( filename, cmd_line, cur_dir, env, flags, startup, &startup_info_size ))) { RtlReleasePebLock(); + close( socketfd[0] ); + close( socketfd[1] ); return FALSE; } if (!env) env = NtCurrentTeb()->Peb->ProcessParameters->Environment; @@ -1840,16 +1946,6 @@ static BOOL create_process( HANDLE hFile, LPCWSTR filename, LPWSTR cmd_line, LPW } env_end++; - /* create the socket for the new process */ - - if (socketpair( PF_UNIX, SOCK_STREAM, 0, socketfd ) == -1) - { - RtlReleasePebLock(); - HeapFree( GetProcessHeap(), 0, winedebug ); - HeapFree( GetProcessHeap(), 0, startup_info ); - SetLastError( ERROR_TOO_MANY_OPEN_FILES ); - return FALSE; - } wine_server_send_fd( socketfd[1] ); close( socketfd[1] ); @@ -1901,77 +1997,14 @@ static BOOL create_process( HANDLE hFile, LPCWSTR filename, LPWSTR cmd_line, LPW HeapFree( GetProcessHeap(), 0, startup_info ); /* create the child process */ - argv = build_argv( cmd_line, 1 ); - - if (!is_win64 ^ !(binary_info->flags & BINARY_FLAG_64BIT)) - loader = get_alternate_loader( &wineloader ); - - if (exec_only || !(pid = fork())) /* child */ - { - char preloader_reserve[64], socket_env[64]; - - if (flags & (CREATE_NEW_PROCESS_GROUP | CREATE_NEW_CONSOLE | DETACHED_PROCESS)) - { - if (!(pid = fork())) - { - int fd = open( "/dev/null", O_RDWR ); - setsid(); - /* close stdin and stdout */ - if (fd != -1) - { - dup2( fd, 0 ); - dup2( fd, 1 ); - close( fd ); - } - } - else if (pid != -1) _exit(0); /* parent */ - } - else - { - if (stdin_fd != -1) dup2( stdin_fd, 0 ); - if (stdout_fd != -1) dup2( stdout_fd, 1 ); - } - - if (stdin_fd != -1) close( stdin_fd ); - if (stdout_fd != -1) close( stdout_fd ); - - /* Reset signals that we previously set to SIG_IGN */ - signal( SIGPIPE, SIG_DFL ); - signal( SIGCHLD, SIG_DFL ); - - sprintf( socket_env, "WINESERVERSOCKET=%u", socketfd[0] ); - sprintf( preloader_reserve, "WINEPRELOADRESERVE=%lx-%lx", - (unsigned long)binary_info->res_start, (unsigned long)binary_info->res_end ); - - putenv( preloader_reserve ); - putenv( socket_env ); - if (winedebug) putenv( winedebug ); - if (wineloader) putenv( wineloader ); - if (unixdir) chdir(unixdir); - if (argv) - { - do - { - wine_exec_wine_binary( loader, argv, getenv("WINELOADER") ); - } -#ifdef __APPLE__ - while (errno == ENOTSUP && exec_only && terminate_main_thread()); -#else - while (0); -#endif - } - _exit(1); - } - - /* this is the parent */ + pid = exec_loader( cmd_line, flags, socketfd[0], stdin_fd, stdout_fd, unixdir, + winedebug, binary_info, FALSE ); if (stdin_fd != -1) close( stdin_fd ); if (stdout_fd != -1) close( stdout_fd ); close( socketfd[0] ); - HeapFree( GetProcessHeap(), 0, argv ); HeapFree( GetProcessHeap(), 0, winedebug ); - HeapFree( GetProcessHeap(), 0, wineloader ); if (pid == -1) { FILE_SetDosError();

1 0

Alexandre Julliard : server: Allow creating a process without any parent or startup info.
by Alexandre Julliard 17 Jun '11

17 Jun '11

Module: wine Branch: master Commit: a0c0878805a14f985682626c1379941d99b75159 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a0c0878805a14f985682626c1… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jun 16 22:45:45 2011 +0200 server: Allow creating a process without any parent or startup info. --- server/process.c | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/server/process.c b/server/process.c index f5430c8..c88c89b 100644 --- a/server/process.c +++ b/server/process.c @@ -886,6 +886,12 @@ DECL_HANDLER(new_process) return; } + if (!req->info_size) /* create an orphaned process */ + { + create_process( socket_fd, NULL, 0 ); + return; + } + /* build the startup info for a new process */ if (!(info = alloc_object( &startup_info_ops ))) return; info->exe_file = NULL;

1 0

Jacek Caban : mshtml: Call on_start_nsrequest synchronously in async_stop_request is no data was read before .
by Alexandre Julliard 16 Jun '11

16 Jun '11

Module: wine Branch: master Commit: 17e6d75ed41bf2207c4206adf63ba835d1e06609 URL: http://source.winehq.org/git/wine.git/?a=commit;h=17e6d75ed41bf2207c4206adf… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Thu Jun 16 16:42:12 2011 +0200 mshtml: Call on_start_nsrequest synchronously in async_stop_request is no data was read before. --- dlls/mshtml/navigate.c | 12 +++++++----- 1 files changed, 7 insertions(+), 5 deletions(-) diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c index 2d45f09..6d84d3f 100644 --- a/dlls/mshtml/navigate.c +++ b/dlls/mshtml/navigate.c @@ -689,6 +689,8 @@ HRESULT start_binding(HTMLWindow *window, HTMLDocumentNode *doc, BSCallback *bsc IStream *str = NULL; HRESULT hres; + TRACE("(%p %p %p %p)\n", window, doc, bscallback, bctx); + bscallback->doc = doc; /* NOTE: IE7 calls IsSystemMoniker here*/ @@ -1001,11 +1003,6 @@ static void on_stop_nsrequest(nsChannelBSC *This, HRESULT result) request_result = NS_ERROR_FAILURE; } - if(!This->bsc.readed && SUCCEEDED(result)) { - TRACE("No data read! Calling OnStartRequest\n"); - on_start_nsrequest(This); - } - if(This->nslistener) { nsres = nsIStreamListener_OnStopRequest(This->nslistener, (nsIRequest*)&This->nschannel->nsIHttpChannel_iface, This->nscontext, @@ -1270,6 +1267,11 @@ static HRESULT async_stop_request(nsChannelBSC *This) { stop_request_task_t *task; + if(!This->bsc.readed) { + TRACE("No data read, calling OnStartRequest\n"); + on_start_nsrequest(This); + } + task = heap_alloc(sizeof(*task)); if(!task) return E_OUTOFMEMORY;

1 0

Marcus Meissner : d3dxof: Check returns of read_bytes (Coverity).
by Alexandre Julliard 16 Jun '11

16 Jun '11

Module: wine Branch: master Commit: 5ba1f867a1f838e9b88b4247e8fc4839a929aaa2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5ba1f867a1f838e9b88b4247e… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jun 16 17:47:52 2011 +0200 d3dxof: Check returns of read_bytes (Coverity). --- dlls/d3dxof/parsing.c | 9 ++++++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c index cbf1761..4acaaba 100644 --- a/dlls/d3dxof/parsing.c +++ b/dlls/d3dxof/parsing.c @@ -233,8 +233,10 @@ HRESULT parse_header(parse_buffer * buf, BYTE ** decomp_buffer_ptr) buf->rem_bytes -= sizeof(WORD) * 2; buf->buffer += sizeof(WORD) * 2; - read_bytes(buf, &decomp_size, sizeof(decomp_size)); - read_bytes(buf, &comp_size, sizeof(comp_size)); + if (!read_bytes(buf, &decomp_size, sizeof(decomp_size))) + return DXFILEERR_BADFILETYPE; + if (!read_bytes(buf, &comp_size, sizeof(comp_size))) + return DXFILEERR_BADFILETYPE; TRACE("Compressed format %s detected: compressed_size = %x, decompressed_size = %x\n", debugstr_fourcc(header[2]), comp_size, decomp_size); @@ -1049,7 +1051,8 @@ static void go_to_next_definition(parse_buffer * buf) char c; while (buf->rem_bytes) { - read_bytes(buf, &c, 1); + if (!read_bytes(buf, &c, 1)) + return; if ((c == '#') || (c == '/')) { /* Handle comment (# or //) */

1 0

Marcus Meissner : usp10: Removed 2 superflous lines of code (Coverity).
by Alexandre Julliard 16 Jun '11

16 Jun '11

Module: wine Branch: master Commit: c2748cfba56866557e3a7d8999c85108cac04732 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c2748cfba56866557e3a7d899… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jun 16 16:58:45 2011 +0200 usp10: Removed 2 superflous lines of code (Coverity). --- dlls/usp10/shape.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/dlls/usp10/shape.c b/dlls/usp10/shape.c index c1bc18f..cbe186a 100644 --- a/dlls/usp10/shape.c +++ b/dlls/usp10/shape.c @@ -2597,8 +2597,6 @@ static int oriya_lex(WCHAR c) if (c>=0x0B01 && c<=0x0B03) return lex_Modifier; else if (c>=0x0B05 && c<=0x0B14) return lex_Vowel; else if (c>=0x0B15 && c<=0x0B39) return lex_Consonant; - else if (c>=0x0B2C && c<=0x0B2E) return lex_Consonant; - else if (c>=0x0B32 && c<=0x0B33) return lex_Consonant; else if (c>=0x0B41 && c<=0x0B44) return lex_Matra_below; else if (c>=0x0B48 && c<=0x0B4C) return lex_Composed_Vowel; else if (c>=0x0B5C && c<=0x0B5D) return lex_Consonant;

1 0

Marcus Meissner : sane.ds: Removed 3 array != NULL checks (Coverity).
by Alexandre Julliard 16 Jun '11

16 Jun '11

Module: wine Branch: master Commit: c4703a4aacc985409b7a74b9c37ee73c606030dc URL: http://source.winehq.org/git/wine.git/?a=commit;h=c4703a4aacc985409b7a74b9c… Author: Marcus Meissner <marcus(a)jet.franken.de> Date: Thu Jun 16 18:40:39 2011 +0200 sane.ds: Removed 3 array != NULL checks (Coverity). --- dlls/sane.ds/sane_main.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/sane.ds/sane_main.c b/dlls/sane.ds/sane_main.c index 13422bb..f482098 100644 --- a/dlls/sane.ds/sane_main.c +++ b/dlls/sane.ds/sane_main.c @@ -473,13 +473,13 @@ static TW_UINT16 SANE_OpenDS( pTW_IDENTITY pOrigin, pTW_IDENTITY self) { /* To make string as short as above */ lstrcpynA(name, sane_devlist[i]->vendor, sizeof(name)-1); - if (self->Manufacturer && *self->Manufacturer && strcmp(name, self->Manufacturer)) + if (*self->Manufacturer && strcmp(name, self->Manufacturer)) continue; lstrcpynA(name, sane_devlist[i]->model, sizeof(name)-1); - if (self->ProductFamily && *self->ProductFamily && strcmp(name, self->ProductFamily)) + if (*self->ProductFamily && strcmp(name, self->ProductFamily)) continue; copy_sane_short_name(sane_devlist[i]->name, name, sizeof(name) - 1); - if (self->ProductName && *self->ProductName && strcmp(name, self->ProductName)) + if (*self->ProductName && strcmp(name, self->ProductName)) continue; break; }

1 0

← Newer
1
...
32
33
34
35
36
37
38
...
81
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits June 2011