winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
July 2011
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
838 discussions
Start a n
N
ew thread
Frédéric Delanoy : cmd/tests: Add tests for || on failure conditional execution.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: 3d9245830f1739781797cd07bb52dc159715897a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3d9245830f1739781797cd07b…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Sat Jul 23 15:34:22 2011 +0200 cmd/tests: Add tests for || on failure conditional execution. --- programs/cmd/tests/test_builtins.cmd | 7 +++++++ programs/cmd/tests/test_builtins.cmd.exp | 3 +++ 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd index a4b4594..d94c3e7 100644 --- a/programs/cmd/tests/test_builtins.cmd +++ b/programs/cmd/tests/test_builtins.cmd @@ -113,6 +113,13 @@ if exist foo3 ( del foo3 ) else echo foo3 not created echo bar4 && echo foo4 +echo ...on failure conditional ^|^| +call :setError 789 || echo foo5 +echo foo6 || echo bar6 > bar6 +if exist bar6 ( + echo bar6 created + del bar6 +) echo ------------ Testing type ------------ echo bar> foobaz diff --git a/programs/cmd/tests/test_builtins.cmd.exp b/programs/cmd/tests/test_builtins.cmd.exp index de98364..6e842b8 100644 --- a/programs/cmd/tests/test_builtins.cmd.exp +++ b/programs/cmd/tests/test_builtins.cmd.exp @@ -100,6 +100,9 @@ foo2 @todo_wine@foo3 not created bar4@space@ foo4 +@todo_wine@...on failure conditional || +@todo_wine@foo5 +@todo_wine@foo6@space@ ------------ Testing type ------------ @pwd@>type foobaz@space@
1
0
0
0
Frédéric Delanoy : cmd/tests: Add tests for && on success conditional execution.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: 73413693d6e964f33b4fdf4dbfb1686e969ea39a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=73413693d6e964f33b4fdf4db…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Sat Jul 23 15:34:21 2011 +0200 cmd/tests: Add tests for && on success conditional execution. --- programs/cmd/tests/test_builtins.cmd | 7 +++++++ programs/cmd/tests/test_builtins.cmd.exp | 4 ++++ 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd index 88c7c75..a4b4594 100644 --- a/programs/cmd/tests/test_builtins.cmd +++ b/programs/cmd/tests/test_builtins.cmd @@ -106,6 +106,13 @@ if exist foobazbar ( cd .. rd /s/q foobar ) else echo foobar deleted +echo ...on success conditional ^&^& +call :setError 456 && echo foo3 > foo3 +if exist foo3 ( + echo foo3 created + del foo3 +) else echo foo3 not created +echo bar4 && echo foo4 echo ------------ Testing type ------------ echo bar> foobaz diff --git a/programs/cmd/tests/test_builtins.cmd.exp b/programs/cmd/tests/test_builtins.cmd.exp index 1c56629..de98364 100644 --- a/programs/cmd/tests/test_builtins.cmd.exp +++ b/programs/cmd/tests/test_builtins.cmd.exp @@ -96,6 +96,10 @@ foo1 bar2@space@ foo2 @todo_wine@foobar deleted +@todo_wine@...on success conditional && +@todo_wine@foo3 not created +bar4@space@ +foo4 ------------ Testing type ------------ @pwd@>type foobaz@space@
1
0
0
0
Frédéric Delanoy : cmd/tests: Add tests for & (un )conditional execution.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: 8b1d8e9e82be5ac4c8ec379c533e3b57390c4014 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8b1d8e9e82be5ac4c8ec379c5…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Sat Jul 23 15:34:20 2011 +0200 cmd/tests: Add tests for & (un)conditional execution. --- programs/cmd/tests/test_builtins.cmd | 19 ++++++++++++++++--- programs/cmd/tests/test_builtins.cmd.exp | 6 ++++++ 2 files changed, 22 insertions(+), 3 deletions(-) diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd index 81a326a..88c7c75 100644 --- a/programs/cmd/tests/test_builtins.cmd +++ b/programs/cmd/tests/test_builtins.cmd @@ -94,6 +94,19 @@ echo P%ERRORLEVEL% echo %ERRORLEVEL%S echo P%ERRORLEVEL%S +echo ------------ Testing conditional execution -------------- +echo ...unconditional ^& +call :setError 123 & echo foo1 +echo bar2 & echo foo2 +mkdir foobar & cd foobar +echo > foobazbar +cd .. & rd /s/q foobar +if exist foobazbar ( + echo foobar not deleted! + cd .. + rd /s/q foobar +) else echo foobar deleted + echo ------------ Testing type ------------ echo bar> foobaz @echo on @@ -105,7 +118,7 @@ echo *** del foobaz echo ------------ Testing NUL ------------ -md foobar && cd foobar +md foobar & cd foobar rem NUL file (non) creation + case insensitivity rem Note: "if exist" does not work with NUL, so to check for file existence we use a kludgy workaround echo > bar @@ -277,7 +290,7 @@ echo %ErrorLevel% rem Trailing backslashes mkdir foo\\\\ echo %ErrorLevel% -if exist foo (rmdir foo && echo dir created +if exist foo (rmdir foo & echo dir created ) else ( echo dir not created ) echo %ErrorLevel% rem Invalid chars @@ -289,7 +302,7 @@ echo %ErrorLevel% call :setError 0 mkdir foo\? echo %ErrorLevel% -if exist foo (rmdir foo && echo ok, foo created +if exist foo (rmdir foo & echo ok, foo created ) else ( echo foo not created ) call :setError 0 mkdir foo\bar\? diff --git a/programs/cmd/tests/test_builtins.cmd.exp b/programs/cmd/tests/test_builtins.cmd.exp index c3fee1a..1c56629 100644 --- a/programs/cmd/tests/test_builtins.cmd.exp +++ b/programs/cmd/tests/test_builtins.cmd.exp @@ -90,6 +90,12 @@ ERRORLEVEL P0 0S P0S +------------ Testing conditional execution -------------- +@todo_wine@...unconditional & +foo1 +bar2@space@ +foo2 +@todo_wine@foobar deleted ------------ Testing type ------------ @pwd@>type foobaz@space@
1
0
0
0
Frédéric Delanoy : urlmon: Fix various typos/ misspellings.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: d1e15baca7133e3b672443f3b2ff7b209d939f0e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d1e15baca7133e3b672443f3b…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Sat Jul 23 09:14:25 2011 +0200 urlmon: Fix various typos/misspellings. --- dlls/urlmon/uri.c | 120 ++++++++++++++++++++++++++-------------------------- 1 files changed, 60 insertions(+), 60 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=d1e15baca7133e3b67244…
1
0
0
0
Nikolay Sivov : shell32/autocomplete: Really append suggested part instead of replacing whole string.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: 5354b974a1a6ce503faf6c25a0f415b21f8a0a79 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5354b974a1a6ce503faf6c25a…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Jul 24 22:42:25 2011 +0400 shell32/autocomplete: Really append suggested part instead of replacing whole string. --- dlls/shell32/autocomplete.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c index fa80713..2c59207 100644 --- a/dlls/shell32/autocomplete.c +++ b/dlls/shell32/autocomplete.c @@ -486,7 +486,7 @@ static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, } return CallWindowProcW(This->wpOrigEditProc, hwnd, uMsg, wParam, lParam); case WM_KEYUP: - GetWindowTextW( hwnd, hwndText, 255); + GetWindowTextW( hwnd, hwndText, sizeof(hwndText)/sizeof(WCHAR)); switch(wParam) { case VK_RETURN: @@ -591,11 +591,16 @@ static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, if (StrStrIW(strs, hwndText) == strs) { if (!filled && (This->options & ACO_AUTOAPPEND)) { - SetWindowTextW(hwnd, strs); - SendMessageW(hwnd, EM_SETSEL, lstrlenW(hwndText), lstrlenW(strs)); + INT typed_length = strlenW(hwndText); + WCHAR buffW[255]; + + strcpyW(buffW, hwndText); + strcatW(buffW, &strs[typed_length]); + SetWindowTextW(hwnd, buffW); + SendMessageW(hwnd, EM_SETSEL, typed_length, strlenW(strs)); if (!(This->options & ACO_AUTOSUGGEST)) break; - } + } if (This->options & ACO_AUTOSUGGEST) { SendMessageW(This->hwndListBox, LB_ADDSTRING, 0, (LPARAM)strs);
1
0
0
0
Nikolay Sivov : shell32/autocomplete: Remove redundant memory initialization.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: 46a2ec0209e4dbc47e79d35f5db1ad04a84c7b19 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=46a2ec0209e4dbc47e79d35f5…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Jul 24 23:18:51 2011 +0400 shell32/autocomplete: Remove redundant memory initialization. --- dlls/shell32/autocomplete.c | 15 +++++++-------- 1 files changed, 7 insertions(+), 8 deletions(-) diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c index 2c59207..684e990 100644 --- a/dlls/shell32/autocomplete.c +++ b/dlls/shell32/autocomplete.c @@ -287,7 +287,7 @@ static HRESULT WINAPI IAutoComplete2_fnInit( LONG len; /* pwszRegKeyPath contains the key as well as the value, so we split */ - key = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (lstrlenW(pwzsRegKeyPath)+1)*sizeof(WCHAR)); + key = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(pwzsRegKeyPath)+1)*sizeof(WCHAR)); strcpyW(key, pwzsRegKeyPath); value = strrchrW(key, '\\'); *value = 0; @@ -301,7 +301,7 @@ static HRESULT WINAPI IAutoComplete2_fnInit( if (res == ERROR_SUCCESS) { res = RegQueryValueW(hKey, value, result, &len); if (res == ERROR_SUCCESS) { - This->quickComplete = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len*sizeof(WCHAR)); + This->quickComplete = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR)); strcpyW(This->quickComplete, result); } RegCloseKey(hKey); @@ -310,7 +310,7 @@ static HRESULT WINAPI IAutoComplete2_fnInit( } if ((pwszQuickComplete) && (!This->quickComplete)) { - This->quickComplete = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (lstrlenW(pwszQuickComplete)+1)*sizeof(WCHAR)); + This->quickComplete = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(pwszQuickComplete)+1)*sizeof(WCHAR)); lstrcpyW(This->quickComplete, pwszQuickComplete); } @@ -493,7 +493,7 @@ static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, /* If quickComplete is set and control is pressed, replace the string */ control = GetKeyState(VK_CONTROL) & 0x8000; if (control && This->quickComplete) { - hwndQCText = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, + hwndQCText = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(This->quickComplete)+lstrlenW(hwndText))*sizeof(WCHAR)); sel = sprintfW(hwndQCText, This->quickComplete, hwndText); SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)hwndQCText); @@ -536,7 +536,7 @@ static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, int len; len = SendMessageW(This->hwndListBox, LB_GETTEXTLEN, sel, 0); - msg = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (len+1)*sizeof(WCHAR)); + msg = HeapAlloc(GetProcessHeap(), 0, (len+1)*sizeof(WCHAR)); SendMessageW(This->hwndListBox, LB_GETTEXT, sel, (LPARAM)msg); SendMessageW(hwnd, WM_SETTEXT, 0, (LPARAM)msg); SendMessageW(hwnd, EM_SETSEL, lstrlenW(msg), lstrlenW(msg)); @@ -573,8 +573,7 @@ static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, SendMessageW(This->hwndListBox, LB_RESETCONTENT, 0, 0); HeapFree(GetProcessHeap(), 0, This->txtbackup); - This->txtbackup = HeapAlloc(GetProcessHeap(), - HEAP_ZERO_MEMORY, (lstrlenW(hwndText)+1)*sizeof(WCHAR)); + This->txtbackup = HeapAlloc(GetProcessHeap(), 0, (lstrlenW(hwndText)+1)*sizeof(WCHAR)); lstrcpyW(This->txtbackup, hwndText); /* Returns if there is no text to search and we doesn't want to display all the entries */ @@ -664,7 +663,7 @@ static LRESULT APIENTRY ACLBoxSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, if (sel < 0) break; len = SendMessageW(This->hwndListBox, LB_GETTEXTLEN, sel, 0); - msg = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, (len+1)*sizeof(WCHAR)); + msg = HeapAlloc(GetProcessHeap(), 0, (len+1)*sizeof(WCHAR)); SendMessageW(hwnd, LB_GETTEXT, sel, (LPARAM)msg); SendMessageW(This->hwndEdit, WM_SETTEXT, 0, (LPARAM)msg); SendMessageW(This->hwndEdit, EM_SETSEL, 0, lstrlenW(msg));
1
0
0
0
Nikolay Sivov : shell32/autocomplete: Autocompletion should be case insensitive for string comparison.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: 2210e9bbf01a0d7758e2afa17dbf4338e1407e4a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2210e9bbf01a0d7758e2afa17…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sat Jul 23 12:40:56 2011 +0400 shell32/autocomplete: Autocompletion should be case insensitive for string comparison. --- dlls/shell32/autocomplete.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/autocomplete.c b/dlls/shell32/autocomplete.c index af450ba..fa80713 100644 --- a/dlls/shell32/autocomplete.c +++ b/dlls/shell32/autocomplete.c @@ -589,7 +589,7 @@ static LRESULT APIENTRY ACEditSubclassProc(HWND hwnd, UINT uMsg, WPARAM wParam, if (hr != S_OK) break; - if (strstrW(strs, hwndText) == strs) { + if (StrStrIW(strs, hwndText) == strs) { if (!filled && (This->options & ACO_AUTOAPPEND)) { SetWindowTextW(hwnd, strs); SendMessageW(hwnd, EM_SETSEL, lstrlenW(hwndText), lstrlenW(strs));
1
0
0
0
Huw Davies : gdi32/tests: Add some SetDIBits tests.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: 046ec2d13238c0420411bf716a162fe9b93dbb15 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=046ec2d13238c0420411bf716…
Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Jul 25 10:56:31 2011 +0100 gdi32/tests: Add some SetDIBits tests. --- dlls/gdi32/tests/bitmap.c | 375 +++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 375 insertions(+), 0 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=046ec2d13238c0420411b…
1
0
0
0
Huw Davies : gdi32: Rewrite SetDIBits to use the PutImage gdi driver function.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: 3cb26488bdee73c39c04f8644d83bddca1bea141 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3cb26488bdee73c39c04f8644…
Author: Huw Davies <huw(a)codeweavers.com> Date: Mon Jul 25 10:56:30 2011 +0100 gdi32: Rewrite SetDIBits to use the PutImage gdi driver function. --- dlls/gdi32/bitblt.c | 2 +- dlls/gdi32/dib.c | 252 +++++++++++++++++++++++++++++++++++++++++++++- dlls/gdi32/gdi_private.h | 2 + 3 files changed, 253 insertions(+), 3 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=3cb26488bdee73c39c04f…
1
0
0
0
Alexandre Julliard : shlwapi: Add support for 64-bit formats in wsprintf.
by Alexandre Julliard
25 Jul '11
25 Jul '11
Module: wine Branch: master Commit: 2bf9c26df630525024e6b3ed0c1ce73f52b80cce URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2bf9c26df630525024e6b3ed0…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jul 25 13:38:04 2011 +0200 shlwapi: Add support for 64-bit formats in wsprintf. --- dlls/shlwapi/wsprintf.c | 72 +++++++++++++++++++++++++++++++++++++---------- 1 files changed, 57 insertions(+), 15 deletions(-) diff --git a/dlls/shlwapi/wsprintf.c b/dlls/shlwapi/wsprintf.c index 26bca5d..1093393 100644 --- a/dlls/shlwapi/wsprintf.c +++ b/dlls/shlwapi/wsprintf.c @@ -43,6 +43,8 @@ WINE_DEFAULT_DEBUG_CHANNEL(string); #define WPRINTF_SHORT 0x0010 /* Short arg ('h' prefix) */ #define WPRINTF_UPPER_HEX 0x0020 /* Upper-case hex ('X' specifier) */ #define WPRINTF_WIDE 0x0040 /* Wide arg ('w' prefix) */ +#define WPRINTF_INTPTR 0x0080 /* Pointer-size arg ('I' prefix) */ +#define WPRINTF_I64 0x0100 /* 64-bit arg ('I64' prefix) */ typedef enum { @@ -65,11 +67,11 @@ typedef struct } WPRINTF_FORMAT; typedef union { - WCHAR wchar_view; - CHAR char_view; - LPCSTR lpcstr_view; - LPCWSTR lpcwstr_view; - INT int_view; + WCHAR wchar_view; + CHAR char_view; + LPCSTR lpcstr_view; + LPCWSTR lpcwstr_view; + LONGLONG int_view; } WPRINTF_DATA; static const CHAR null_stringA[] = "(null)"; @@ -111,6 +113,12 @@ static INT WPRINTF_ParseFormatA( LPCSTR format, WPRINTF_FORMAT *res ) if (*p == 'l') { res->flags |= WPRINTF_LONG; p++; } else if (*p == 'h') { res->flags |= WPRINTF_SHORT; p++; } else if (*p == 'w') { res->flags |= WPRINTF_WIDE; p++; } + else if (*p == 'I') + { + if (p[1] == '6' && p[2] == '4') { res->flags |= WPRINTF_I64; p += 3; } + else if (p[1] == '3' && p[2] == '2') p += 3; + else { res->flags |= WPRINTF_INTPTR; p++; } + } switch(*p) { case 'c': @@ -132,6 +140,10 @@ static INT WPRINTF_ParseFormatA( LPCSTR format, WPRINTF_FORMAT *res ) case 'u': res->type = WPR_UNSIGNED; break; + case 'p': + res->width = 2 * sizeof(void *); + res->flags |= WPRINTF_ZEROPAD | WPRINTF_INTPTR; + /* fall through */ case 'X': res->flags |= WPRINTF_UPPER_HEX; /* fall through */ @@ -183,7 +195,13 @@ static INT WPRINTF_ParseFormatW( LPCWSTR format, WPRINTF_FORMAT *res ) if (*p == 'l') { res->flags |= WPRINTF_LONG; p++; } else if (*p == 'h') { res->flags |= WPRINTF_SHORT; p++; } else if (*p == 'w') { res->flags |= WPRINTF_WIDE; p++; } - switch((CHAR)*p) + else if (*p == 'I') + { + if (p[1] == '6' && p[2] == '4') { res->flags |= WPRINTF_I64; p += 3; } + else if (p[1] == '3' && p[2] == '2') p += 3; + else { res->flags |= WPRINTF_INTPTR; p++; } + } + switch(*p) { case 'c': res->type = (res->flags & WPRINTF_SHORT) ? WPR_CHAR : WPR_WCHAR; @@ -204,6 +222,10 @@ static INT WPRINTF_ParseFormatW( LPCWSTR format, WPRINTF_FORMAT *res ) case 'u': res->type = WPR_UNSIGNED; break; + case 'p': + res->width = 2 * sizeof(void *); + res->flags |= WPRINTF_ZEROPAD | WPRINTF_INTPTR; + /* fall through */ case 'X': res->flags |= WPRINTF_UPPER_HEX; /* fall through */ @@ -247,16 +269,32 @@ static UINT WPRINTF_GetLen( WPRINTF_FORMAT *format, WPRINTF_DATA *arg, if (len > maxlen) len = maxlen; return (format->precision = len); case WPR_SIGNED: - len = sprintf( number, "%d", arg->int_view ); - break; case WPR_UNSIGNED: - len = sprintf( number, "%u", (UINT)arg->int_view ); - break; case WPR_HEXA: - len = sprintf( number, - (format->flags & WPRINTF_UPPER_HEX) ? "%X" : "%x", - (UINT)arg->int_view); + { + const char *digits = (format->flags & WPRINTF_UPPER_HEX) ? "0123456789ABCDEF" : "0123456789abcdef"; + ULONGLONG num = arg->int_view; + int base = format->type == WPR_HEXA ? 16 : 10; + char buffer[20], *p = buffer, *dst = number; + + if (format->type == WPR_SIGNED && arg->int_view < 0) + { + *dst++ = '-'; + num = -arg->int_view; + } + if (format->flags & WPRINTF_INTPTR) num = (UINT_PTR)num; + else if (!(format->flags & WPRINTF_I64)) num = (UINT)num; + + do + { + *p++ = digits[num % base]; + num /= base; + } while (num); + while (p > buffer) *dst++ = *(--p); + *dst = 0; + len = dst - number; break; + } default: return 0; } @@ -318,7 +356,9 @@ INT WINAPI wvnsprintfA( LPSTR buffer, INT maxlen, LPCSTR spec, __ms_va_list args case WPR_HEXA: case WPR_SIGNED: case WPR_UNSIGNED: - argData.int_view = va_arg( args, INT ); + if (format.flags & WPRINTF_INTPTR) argData.int_view = va_arg(args, INT_PTR); + else if (format.flags & WPRINTF_I64) argData.int_view = va_arg(args, LONGLONG); + else argData.int_view = va_arg(args, INT); break; default: argData.wchar_view = 0; @@ -423,7 +463,9 @@ INT WINAPI wvnsprintfW( LPWSTR buffer, INT maxlen, LPCWSTR spec, __ms_va_list ar case WPR_HEXA: case WPR_SIGNED: case WPR_UNSIGNED: - argData.int_view = va_arg( args, INT ); + if (format.flags & WPRINTF_INTPTR) argData.int_view = va_arg(args, INT_PTR); + else if (format.flags & WPRINTF_I64) argData.int_view = va_arg(args, LONGLONG); + else argData.int_view = va_arg(args, INT); break; default: argData.wchar_view = 0;
1
0
0
0
← Newer
1
...
18
19
20
21
22
23
24
...
84
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
Results per page:
10
25
50
100
200