wine-commits July 2011

wine-commits@winehq.org

2 participants
838 discussions

Michael Stefaniuc : d3d8: Use unsafe_impl_from_IDirect3DVertexBuffer8 for app provided ifaces.
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: aa8e4dd81bec802fb28b4d59f770773108ca449b URL: http://source.winehq.org/git/wine.git/?a=commit;h=aa8e4dd81bec802fb28b4d59f… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Fri Jul 8 12:22:14 2011 +0200 d3d8: Use unsafe_impl_from_IDirect3DVertexBuffer8 for app provided ifaces. --- dlls/d3d8/buffer.c | 9 +++++++++ dlls/d3d8/d3d8_private.h | 1 + dlls/d3d8/device.c | 6 +++--- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/dlls/d3d8/buffer.c b/dlls/d3d8/buffer.c index f10ec68..19ce7e4 100644 --- a/dlls/d3d8/buffer.c +++ b/dlls/d3d8/buffer.c @@ -298,6 +298,15 @@ HRESULT vertexbuffer_init(IDirect3DVertexBuffer8Impl *buffer, IDirect3DDevice8Im return D3D_OK; } +IDirect3DVertexBuffer8Impl *unsafe_impl_from_IDirect3DVertexBuffer8(IDirect3DVertexBuffer8 *iface) +{ + if (!iface) + return NULL; + assert(iface->lpVtbl == &Direct3DVertexBuffer8_Vtbl); + + return impl_from_IDirect3DVertexBuffer8(iface); +} + static inline IDirect3DIndexBuffer8Impl *impl_from_IDirect3DIndexBuffer8(IDirect3DIndexBuffer8 *iface) { return CONTAINING_RECORD(iface, IDirect3DIndexBuffer8Impl, IDirect3DIndexBuffer8_iface); diff --git a/dlls/d3d8/d3d8_private.h b/dlls/d3d8/d3d8_private.h index 6ec6712..cbc0186 100644 --- a/dlls/d3d8/d3d8_private.h +++ b/dlls/d3d8/d3d8_private.h @@ -277,6 +277,7 @@ struct IDirect3DVertexBuffer8Impl HRESULT vertexbuffer_init(IDirect3DVertexBuffer8Impl *buffer, IDirect3DDevice8Impl *device, UINT size, DWORD usage, DWORD fvf, D3DPOOL pool) DECLSPEC_HIDDEN; +IDirect3DVertexBuffer8Impl *unsafe_impl_from_IDirect3DVertexBuffer8(IDirect3DVertexBuffer8 *iface) DECLSPEC_HIDDEN; /* --------------------- */ /* IDirect3DIndexBuffer8 */ diff --git a/dlls/d3d8/device.c b/dlls/d3d8/device.c index 3537cb7..cd3c16d 100644 --- a/dlls/d3d8/device.c +++ b/dlls/d3d8/device.c @@ -2005,8 +2005,8 @@ static HRESULT WINAPI IDirect3DDevice8Impl_ProcessVertices(IDirect3DDevice8 *ifa DWORD Flags) { IDirect3DDevice8Impl *This = impl_from_IDirect3DDevice8(iface); + IDirect3DVertexBuffer8Impl *dest = unsafe_impl_from_IDirect3DVertexBuffer8(pDestBuffer); HRESULT hr; - IDirect3DVertexBuffer8Impl *dest = (IDirect3DVertexBuffer8Impl *) pDestBuffer; TRACE("iface %p, src_start_idx %u, dst_idx %u, vertex_count %u, dst_buffer %p, flags %#x.\n", iface, SrcStartIndex, DestIndex, VertexCount, pDestBuffer, Flags); @@ -2683,6 +2683,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetStreamSource(IDirect3DDevice8 *ifa UINT StreamNumber, IDirect3DVertexBuffer8 *pStreamData, UINT Stride) { IDirect3DDevice8Impl *This = impl_from_IDirect3DDevice8(iface); + IDirect3DVertexBuffer8Impl *streamdata = unsafe_impl_from_IDirect3DVertexBuffer8(pStreamData); HRESULT hr; TRACE("iface %p, stream_idx %u, buffer %p, stride %u.\n", @@ -2690,8 +2691,7 @@ static HRESULT WINAPI IDirect3DDevice8Impl_SetStreamSource(IDirect3DDevice8 *ifa wined3d_mutex_lock(); hr = wined3d_device_set_stream_source(This->wined3d_device, StreamNumber, - pStreamData ? ((IDirect3DVertexBuffer8Impl *)pStreamData)->wineD3DVertexBuffer : NULL, - 0/* Offset in bytes */, Stride); + streamdata ? streamdata->wineD3DVertexBuffer : NULL, 0/* Offset in bytes */, Stride); wined3d_mutex_unlock(); return hr;

1 0

Alexandre Julliard : msvcp90/tests: Fix the calling convention of some function pointers.
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: 23dd500a64ebc160fdea787e983b8bbebc1917d8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=23dd500a64ebc160fdea787e9… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 8 14:40:10 2011 +0200 msvcp90/tests: Fix the calling convention of some function pointers. --- dlls/msvcp90/tests/misc.c | 21 ++++------ dlls/msvcp90/tests/string.c | 91 +++++++++++++++--------------------------- 2 files changed, 42 insertions(+), 70 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=23dd500a64ebc160fdea7…

1 0

Alexandre Julliard : include: Remove duplicate device caps definitions.
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: c73d89e7f5b4f875695dafad82df413cd338a436 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c73d89e7f5b4f875695dafad8… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Jul 8 11:33:14 2011 +0200 include: Remove duplicate device caps definitions. --- include/wingdi.h | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/include/wingdi.h b/include/wingdi.h index ca6df30..fcecb2c 100644 --- a/include/wingdi.h +++ b/include/wingdi.h @@ -315,9 +315,6 @@ DECL_WINELIB_TYPE_AW(LOGCOLORSPACE) #define MOUSETRAILS 39 #define GETDEVICEUNITS 42 -#define DESKTOPVERTRES 117 -#define DESKTOPHORZRES 118 - #define GETEXTENDEDTEXTMETRICS 256 #define GETEXTENTTABLE 257 #define GETPAIRKERNTABLE 258

1 0

Frédéric Delanoy : shell32: Remove dead assignment (Clang).
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: 78b66ba0206583f8064329bbc0d7d6b2fe2c9419 URL: http://source.winehq.org/git/wine.git/?a=commit;h=78b66ba0206583f8064329bbc… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Thu Jul 7 18:42:35 2011 +0200 shell32: Remove dead assignment (Clang). --- dlls/shell32/shlfileop.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c index f022faf..7ae20c1 100644 --- a/dlls/shell32/shlfileop.c +++ b/dlls/shell32/shlfileop.c @@ -1348,7 +1348,6 @@ static HRESULT delete_files(LPSHFILEOPSTRUCTW lpFileOp, const FILE_LIST *flFrom) for (i = 0; i < flFrom->dwNumFiles; i++) { - bPathExists = TRUE; fileEntry = &flFrom->feFiles[i]; if (!IsAttribFile(fileEntry->attributes) &&

1 0

André Hentschel : shell32: Make sure that a structure is initialized (clang).
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: 58a31ebea92086fa6370d6bf0a4edb45ba696098 URL: http://source.winehq.org/git/wine.git/?a=commit;h=58a31ebea92086fa6370d6bf0… Author: André Hentschel <nerv(a)dawncrow.de> Date: Thu Jul 7 23:40:34 2011 +0200 shell32: Make sure that a structure is initialized (clang). --- dlls/shell32/brsfolder.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/shell32/brsfolder.c b/dlls/shell32/brsfolder.c index 80b8ecd..0a780b9 100644 --- a/dlls/shell32/brsfolder.c +++ b/dlls/shell32/brsfolder.c @@ -852,7 +852,9 @@ static BOOL BrsFolder_OnSetExpanded(browse_info *info, LPVOID selection, LPCITEMIDLIST pidlCurrent, pidlRoot; TVITEMEXW item; BOOL bResult = FALSE; - + + memset(&item, 0, sizeof(item)); + /* If 'selection' is a string, convert to a Shell ID List. */ if (is_str) { IShellFolder *psfDesktop; @@ -883,7 +885,6 @@ static BOOL BrsFolder_OnSetExpanded(browse_info *info, LPVOID selection, goto done; /* Initialize item to point to the first child of the root folder. */ - memset(&item, 0, sizeof(item)); item.mask = TVIF_PARAM; item.hItem = (HTREEITEM)SendMessageW(info->hwndTreeView, TVM_GETNEXTITEM, TVGN_ROOT, 0);

1 0

Vincent Povirk : gdiplus: Implement GdipPlayMetafileRecord for EMF records.
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: fda2fc7684bc73a1dc89cad53e0a05bfee5c2826 URL: http://source.winehq.org/git/wine.git/?a=commit;h=fda2fc7684bc73a1dc89cad53… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Jul 7 16:25:25 2011 -0500 gdiplus: Implement GdipPlayMetafileRecord for EMF records. --- dlls/gdiplus/gdiplus_private.h | 11 ++++- dlls/gdiplus/metafile.c | 113 ++++++++++++++++++++++++++++++++++++++-- dlls/gdiplus/tests/metafile.c | 44 ++++++++-------- 3 files changed, 141 insertions(+), 27 deletions(-) diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h index d6888d9..9afe15b 100644 --- a/dlls/gdiplus/gdiplus_private.h +++ b/dlls/gdiplus/gdiplus_private.h @@ -274,12 +274,21 @@ struct GpMetafile{ GpRectF bounds; GpUnit unit; MetafileType metafile_type; + HENHMETAFILE hemf; + + /* recording */ HDC record_dc; GpGraphics *record_graphics; BYTE *comment_data; DWORD comment_data_size; DWORD comment_data_length; - HENHMETAFILE hemf; + + /* playback */ + GpGraphics *playback_graphics; + HDC playback_dc; + GpPointF playback_points[3]; + HANDLETABLE *handle_table; + int handle_count; }; struct GpBitmap{ diff --git a/dlls/gdiplus/metafile.c b/dlls/gdiplus/metafile.c index 3e79eb7..38923a0 100644 --- a/dlls/gdiplus/metafile.c +++ b/dlls/gdiplus/metafile.c @@ -357,18 +357,100 @@ GpStatus WINGDIPAPI GdipGetHemfFromMetafile(GpMetafile *metafile, HENHMETAFILE * return Ok; } +static GpStatus METAFILE_PlaybackGetDC(GpMetafile *metafile) +{ + GpStatus stat = Ok; + + stat = GdipGetDC(metafile->playback_graphics, &metafile->playback_dc); + + if (stat == Ok) + { + /* The result of GdipGetDC always expects device co-ordinates, but the + * device co-ordinates of the source metafile do not correspond to + * device co-ordinates of the destination. Therefore, we set up the DC + * so that the metafile's bounds map to the destination points where we + * are drawing this metafile. */ + SetMapMode(metafile->playback_dc, MM_ANISOTROPIC); + + SetWindowOrgEx(metafile->playback_dc, metafile->bounds.X, metafile->bounds.Y, NULL); + SetWindowExtEx(metafile->playback_dc, metafile->bounds.Width, metafile->bounds.Height, NULL); + + SetViewportOrgEx(metafile->playback_dc, metafile->playback_points[0].X, metafile->playback_points[0].Y, NULL); + SetViewportExtEx(metafile->playback_dc, + metafile->playback_points[1].X - metafile->playback_points[0].X, + metafile->playback_points[2].Y - metafile->playback_points[0].Y, NULL); + } + + return stat; +} + +static void METAFILE_PlaybackReleaseDC(GpMetafile *metafile) +{ + if (metafile->playback_dc) + { + GdipReleaseDC(metafile->playback_graphics, metafile->playback_dc); + metafile->playback_dc = NULL; + } +} + GpStatus WINGDIPAPI GdipPlayMetafileRecord(GDIPCONST GpMetafile *metafile, EmfPlusRecordType recordType, UINT flags, UINT dataSize, GDIPCONST BYTE *data) { - FIXME("(%p,%x,%x,%d,%p)\n", metafile, recordType, flags, dataSize, data); + TRACE("(%p,%x,%x,%d,%p)\n", metafile, recordType, flags, dataSize, data); + + if (!metafile || (dataSize && !data) || !metafile->playback_graphics) + return InvalidParameter; + + if (recordType >= 1 && recordType <= 0x7a) + { + /* regular EMF record */ + if (metafile->playback_dc) + { + ENHMETARECORD *record; + + record = GdipAlloc(dataSize + 8); + + if (record) + { + record->iType = recordType; + record->nSize = dataSize; + memcpy(record->dParm, data, dataSize); - return NotImplemented; + PlayEnhMetaFileRecord(metafile->playback_dc, metafile->handle_table, + record, metafile->handle_count); + + GdipFree(record); + } + else + return OutOfMemory; + } + } + else + { + METAFILE_PlaybackReleaseDC((GpMetafile*)metafile); + + switch(recordType) + { + case EmfPlusRecordTypeHeader: + case EmfPlusRecordTypeEndOfFile: + break; + case EmfPlusRecordTypeGetDC: + METAFILE_PlaybackGetDC((GpMetafile*)metafile); + break; + default: + FIXME("Not implemented for record type %x\n", recordType); + return NotImplemented; + } + } + + return Ok; } struct enum_metafile_data { EnumerateMetafileProc callback; void *callback_data; + GpMetafile *metafile; }; static int CALLBACK enum_metafile_proc(HDC hDC, HANDLETABLE *lpHTable, const ENHMETARECORD *lpEMFR, @@ -378,6 +460,9 @@ static int CALLBACK enum_metafile_proc(HDC hDC, HANDLETABLE *lpHTable, const ENH struct enum_metafile_data *data = (struct enum_metafile_data*)lpData; const BYTE* pStr; + data->metafile->handle_table = lpHTable; + data->metafile->handle_count = nObj; + /* First check for an EMF+ record. */ if (lpEMFR->iType == EMR_GDICOMMENT) { @@ -424,6 +509,8 @@ GpStatus WINGDIPAPI GdipEnumerateMetafileSrcRectDestPoints(GpGraphics *graphics, VOID *callbackData, GDIPCONST GpImageAttributes *imageAttributes) { struct enum_metafile_data data; + GpStatus stat; + GpMetafile *real_metafile = (GpMetafile*)metafile; /* whoever made this const was joking */ TRACE("(%p,%p,%p,%i,%p,%i,%p,%p,%p)\n", graphics, metafile, destPoints, count, srcRect, srcUnit, callback, callbackData, @@ -435,14 +522,32 @@ GpStatus WINGDIPAPI GdipEnumerateMetafileSrcRectDestPoints(GpGraphics *graphics, if (!metafile->hemf) return InvalidParameter; + if (metafile->playback_graphics) + return ObjectBusy; + TRACE("%s %i -> %s %s %s\n", debugstr_rectf(srcRect), srcUnit, debugstr_pointf(&destPoints[0]), debugstr_pointf(&destPoints[1]), debugstr_pointf(&destPoints[2])); data.callback = callback; data.callback_data = callbackData; + data.metafile = real_metafile; - EnumEnhMetaFile(0, metafile->hemf, enum_metafile_proc, &data, NULL); + real_metafile->playback_graphics = graphics; + real_metafile->playback_dc = NULL; - return Ok; + memcpy(real_metafile->playback_points, destPoints, sizeof(PointF) * 3); + stat = GdipTransformPoints(graphics, CoordinateSpaceDevice, CoordinateSpaceWorld, real_metafile->playback_points, 3); + + if (stat == Ok && metafile->metafile_type == MetafileTypeEmf) + stat = METAFILE_PlaybackGetDC((GpMetafile*)metafile); + + if (stat == Ok) + EnumEnhMetaFile(0, metafile->hemf, enum_metafile_proc, &data, NULL); + + METAFILE_PlaybackReleaseDC((GpMetafile*)metafile); + + real_metafile->playback_graphics = NULL; + + return stat; } diff --git a/dlls/gdiplus/tests/metafile.c b/dlls/gdiplus/tests/metafile.c index 5323751..9530b0c 100644 --- a/dlls/gdiplus/tests/metafile.c +++ b/dlls/gdiplus/tests/metafile.c @@ -212,9 +212,9 @@ static BOOL CALLBACK play_metafile_proc(EmfPlusRecordType record_type, unsigned if (state->expected[state->count].record_type) { if (state->expected[state->count].playback_todo) - todo_wine ok(stat == Ok, "%s: GdipPlayMetafileRecord failed with stat %i\n", state->desc, stat); + todo_wine ok(stat == Ok, "%s.%i: GdipPlayMetafileRecord failed with stat %i\n", state->desc, state->count, stat); else - ok(stat == Ok, "%s: GdipPlayMetafileRecord failed with stat %i\n", state->desc, stat); + ok(stat == Ok, "%s.%i: GdipPlayMetafileRecord failed with stat %i\n", state->desc, state->count, stat); state->count++; } else @@ -324,16 +324,16 @@ static void test_empty(void) } static const emfplus_record getdc_records[] = { - {0, EMR_HEADER, 1}, - {0, EmfPlusRecordTypeHeader, 1}, - {0, EmfPlusRecordTypeGetDC, 1}, - {0, EMR_CREATEBRUSHINDIRECT, 1}, - {0, EMR_SELECTOBJECT, 1}, - {0, EMR_RECTANGLE, 1}, - {0, EMR_SELECTOBJECT, 1}, - {0, EMR_DELETEOBJECT, 1}, - {0, EmfPlusRecordTypeEndOfFile, 1}, - {0, EMR_EOF, 1}, + {0, EMR_HEADER}, + {0, EmfPlusRecordTypeHeader}, + {0, EmfPlusRecordTypeGetDC}, + {0, EMR_CREATEBRUSHINDIRECT}, + {0, EMR_SELECTOBJECT}, + {0, EMR_RECTANGLE}, + {0, EMR_SELECTOBJECT}, + {0, EMR_DELETEOBJECT}, + {0, EmfPlusRecordTypeEndOfFile}, + {0, EMR_EOF}, {0} }; @@ -411,7 +411,7 @@ static void test_getdc(void) stat = GdipBitmapGetPixel(bitmap, 50, 50, &color); expect(Ok, stat); - todo_wine expect(0xff0000ff, color); + expect(0xff0000ff, color); stat = GdipBitmapSetPixel(bitmap, 50, 50, 0); expect(Ok, stat); @@ -420,7 +420,7 @@ static void test_getdc(void) stat = GdipBitmapGetPixel(bitmap, 15, 15, &color); expect(Ok, stat); - todo_wine expect(0xff0000ff, color); + expect(0xff0000ff, color); stat = GdipBitmapGetPixel(bitmap, 50, 50, &color); expect(Ok, stat); @@ -445,13 +445,13 @@ static void test_getdc(void) } static const emfplus_record emfonly_records[] = { - {0, EMR_HEADER, 1}, - {0, EMR_CREATEBRUSHINDIRECT, 1}, - {0, EMR_SELECTOBJECT, 1}, - {0, EMR_RECTANGLE, 1}, - {0, EMR_SELECTOBJECT, 1}, - {0, EMR_DELETEOBJECT, 1}, - {0, EMR_EOF, 1}, + {0, EMR_HEADER}, + {0, EMR_CREATEBRUSHINDIRECT}, + {0, EMR_SELECTOBJECT}, + {0, EMR_RECTANGLE}, + {0, EMR_SELECTOBJECT}, + {0, EMR_DELETEOBJECT}, + {0, EMR_EOF}, {0} }; @@ -528,7 +528,7 @@ static void test_emfonly(void) stat = GdipBitmapGetPixel(bitmap, 50, 50, &color); expect(Ok, stat); - todo_wine expect(0xff0000ff, color); + expect(0xff0000ff, color); stat = GdipDeleteGraphics(graphics); expect(Ok, stat);

1 0

Vincent Povirk : gdiplus: Add test showing scaling does not affect returned HDC objects.
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: 3a6ba940115519472dda94aae19f71e9361617d5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3a6ba940115519472dda94aae… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Jul 7 14:51:35 2011 -0500 gdiplus: Add test showing scaling does not affect returned HDC objects. --- dlls/gdiplus/tests/graphics.c | 49 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 49 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/tests/graphics.c b/dlls/gdiplus/tests/graphics.c index bbca69f..3df57f1 100644 --- a/dlls/gdiplus/tests/graphics.c +++ b/dlls/gdiplus/tests/graphics.c @@ -3251,6 +3251,54 @@ static void test_get_set_textrenderinghint(void) ReleaseDC(hwnd, hdc); } +static void test_getdc_scaled(void) +{ + GpStatus status; + GpGraphics *graphics = NULL; + GpBitmap *bitmap = NULL; + HDC hdc=NULL; + HBRUSH hbrush, holdbrush; + ARGB color; + + status = GdipCreateBitmapFromScan0(10, 10, 12, PixelFormat24bppRGB, NULL, &bitmap); + expect(Ok, status); + + status = GdipGetImageGraphicsContext((GpImage*)bitmap, &graphics); + expect(Ok, status); + + status = GdipScaleWorldTransform(graphics, 2.0, 2.0, MatrixOrderPrepend); + expect(Ok, status); + + status = GdipGetDC(graphics, &hdc); + expect(Ok, status); + ok(hdc != NULL, "got NULL hdc\n"); + + hbrush = CreateSolidBrush(RGB(255, 0, 0)); + + holdbrush = SelectObject(hdc, hbrush); + + Rectangle(hdc, 2, 2, 6, 6); + + SelectObject(hdc, holdbrush); + + DeleteObject(hbrush); + + status = GdipReleaseDC(graphics, hdc); + expect(Ok, status); + + GdipDeleteGraphics(graphics); + + status = GdipBitmapGetPixel(bitmap, 3, 3, &color); + expect(Ok, status); + expect(0xffff0000, color); + + status = GdipBitmapGetPixel(bitmap, 8, 8, &color); + expect(Ok, status); + expect(0xff000000, color); + + GdipDisposeImage((GpImage*)bitmap); +} + START_TEST(graphics) { struct GdiplusStartupInput gdiplusStartupInput; @@ -3311,6 +3359,7 @@ START_TEST(graphics) test_string_functions(); test_get_set_interpolation(); test_get_set_textrenderinghint(); + test_getdc_scaled(); GdiplusShutdown(gdiplusToken); DestroyWindow( hwnd );

1 0

Vincent Povirk : gdiplus: Add tests for GdipPlayMetafileRecord.
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: 71325800dc0d26c70229858e70a11d689972869a URL: http://source.winehq.org/git/wine.git/?a=commit;h=71325800dc0d26c70229858e7… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Jul 7 13:31:55 2011 -0500 gdiplus: Add tests for GdipPlayMetafileRecord. --- dlls/gdiplus/tests/metafile.c | 144 ++++++++++++++++++++++++++++++++++++----- 1 files changed, 127 insertions(+), 17 deletions(-) diff --git a/dlls/gdiplus/tests/metafile.c b/dlls/gdiplus/tests/metafile.c index 66e504f..5323751 100644 --- a/dlls/gdiplus/tests/metafile.c +++ b/dlls/gdiplus/tests/metafile.c @@ -29,6 +29,7 @@ typedef struct emfplus_record { ULONG todo; ULONG record_type; + ULONG playback_todo; } emfplus_record; typedef struct emfplus_check_state @@ -36,6 +37,7 @@ typedef struct emfplus_check_state const char *desc; int count; const struct emfplus_record *expected; + GpMetafile *metafile; } emfplus_check_state; static void check_record(int count, const char *desc, const struct emfplus_record *expected, const struct emfplus_record *actual) @@ -178,6 +180,7 @@ static void check_metafile(GpMetafile *metafile, const emfplus_record *expected, state.desc = desc; state.count = 0; state.expected = expected; + state.metafile = metafile; hdc = CreateCompatibleDC(0); @@ -198,6 +201,51 @@ static void check_metafile(GpMetafile *metafile, const emfplus_record *expected, DeleteDC(hdc); } +static BOOL CALLBACK play_metafile_proc(EmfPlusRecordType record_type, unsigned int flags, + unsigned int dataSize, const unsigned char *pStr, void *userdata) +{ + emfplus_check_state *state = (emfplus_check_state*)userdata; + GpStatus stat; + + stat = GdipPlayMetafileRecord(state->metafile, record_type, flags, dataSize, pStr); + + if (state->expected[state->count].record_type) + { + if (state->expected[state->count].playback_todo) + todo_wine ok(stat == Ok, "%s: GdipPlayMetafileRecord failed with stat %i\n", state->desc, stat); + else + ok(stat == Ok, "%s: GdipPlayMetafileRecord failed with stat %i\n", state->desc, stat); + state->count++; + } + else + { + if (state->expected[state->count].playback_todo) + todo_wine ok(0, "%s: too many records\n", state->desc); + else + ok(0, "%s: too many records\n", state->desc); + + return FALSE; + } + + return TRUE; +} + +static void play_metafile(GpMetafile *metafile, GpGraphics *graphics, const emfplus_record *expected, + const char *desc, const GpPointF *dst_points, const GpRectF *src_rect, Unit src_unit) +{ + GpStatus stat; + emfplus_check_state state; + + state.desc = desc; + state.count = 0; + state.expected = expected; + state.metafile = metafile; + + stat = GdipEnumerateMetafileSrcRectDestPoints(graphics, metafile, dst_points, + 3, src_rect, src_unit, play_metafile_proc, &state, NULL); + expect(Ok, stat); +} + static const emfplus_record empty_records[] = { {0, EMR_HEADER}, {0, EmfPlusRecordTypeHeader}, @@ -276,16 +324,16 @@ static void test_empty(void) } static const emfplus_record getdc_records[] = { - {0, EMR_HEADER}, - {0, EmfPlusRecordTypeHeader}, - {0, EmfPlusRecordTypeGetDC}, - {0, EMR_CREATEBRUSHINDIRECT}, - {0, EMR_SELECTOBJECT}, - {0, EMR_RECTANGLE}, - {0, EMR_SELECTOBJECT}, - {0, EMR_DELETEOBJECT}, - {0, EmfPlusRecordTypeEndOfFile}, - {0, EMR_EOF}, + {0, EMR_HEADER, 1}, + {0, EmfPlusRecordTypeHeader, 1}, + {0, EmfPlusRecordTypeGetDC, 1}, + {0, EMR_CREATEBRUSHINDIRECT, 1}, + {0, EMR_SELECTOBJECT, 1}, + {0, EMR_RECTANGLE, 1}, + {0, EMR_SELECTOBJECT, 1}, + {0, EMR_DELETEOBJECT, 1}, + {0, EmfPlusRecordTypeEndOfFile, 1}, + {0, EMR_EOF, 1}, {0} }; @@ -299,8 +347,11 @@ static void test_getdc(void) BOOL ret; static const GpRectF frame = {0.0, 0.0, 100.0, 100.0}; static const GpPointF dst_points[3] = {{0.0,0.0},{100.0,0.0},{0.0,100.0}}; + static const GpPointF dst_points_half[3] = {{0.0,0.0},{50.0,0.0},{0.0,50.0}}; static const WCHAR description[] = {'w','i','n','e','t','e','s','t',0}; HBRUSH hbrush, holdbrush; + GpBitmap *bitmap; + ARGB color; hdc = CreateCompatibleDC(0); @@ -346,6 +397,41 @@ static void test_getdc(void) check_metafile(metafile, getdc_records, "getdc metafile", dst_points, &frame, UnitPixel); + stat = GdipCreateBitmapFromScan0(100, 100, 0, PixelFormat32bppARGB, NULL, &bitmap); + expect(Ok, stat); + + stat = GdipGetImageGraphicsContext((GpImage*)bitmap, &graphics); + expect(Ok, stat); + + play_metafile(metafile, graphics, getdc_records, "getdc playback", dst_points, &frame, UnitPixel); + + stat = GdipBitmapGetPixel(bitmap, 15, 15, &color); + expect(Ok, stat); + expect(0, color); + + stat = GdipBitmapGetPixel(bitmap, 50, 50, &color); + expect(Ok, stat); + todo_wine expect(0xff0000ff, color); + + stat = GdipBitmapSetPixel(bitmap, 50, 50, 0); + expect(Ok, stat); + + play_metafile(metafile, graphics, getdc_records, "getdc playback", dst_points_half, &frame, UnitPixel); + + stat = GdipBitmapGetPixel(bitmap, 15, 15, &color); + expect(Ok, stat); + todo_wine expect(0xff0000ff, color); + + stat = GdipBitmapGetPixel(bitmap, 50, 50, &color); + expect(Ok, stat); + expect(0, color); + + stat = GdipDeleteGraphics(graphics); + expect(Ok, stat); + + stat = GdipDisposeImage((GpImage*)bitmap); + expect(Ok, stat); + stat = GdipGetHemfFromMetafile(metafile, &hemf); expect(Ok, stat); @@ -359,13 +445,13 @@ static void test_getdc(void) } static const emfplus_record emfonly_records[] = { - {0, EMR_HEADER}, - {0, EMR_CREATEBRUSHINDIRECT}, - {0, EMR_SELECTOBJECT}, - {0, EMR_RECTANGLE}, - {0, EMR_SELECTOBJECT}, - {0, EMR_DELETEOBJECT}, - {0, EMR_EOF}, + {0, EMR_HEADER, 1}, + {0, EMR_CREATEBRUSHINDIRECT, 1}, + {0, EMR_SELECTOBJECT, 1}, + {0, EMR_RECTANGLE, 1}, + {0, EMR_SELECTOBJECT, 1}, + {0, EMR_DELETEOBJECT, 1}, + {0, EMR_EOF, 1}, {0} }; @@ -381,6 +467,8 @@ static void test_emfonly(void) static const GpPointF dst_points[3] = {{0.0,0.0},{100.0,0.0},{0.0,100.0}}; static const WCHAR description[] = {'w','i','n','e','t','e','s','t',0}; HBRUSH hbrush, holdbrush; + GpBitmap *bitmap; + ARGB color; hdc = CreateCompatibleDC(0); @@ -426,6 +514,28 @@ static void test_emfonly(void) check_metafile(metafile, emfonly_records, "emfonly metafile", dst_points, &frame, UnitPixel); + stat = GdipCreateBitmapFromScan0(100, 100, 0, PixelFormat32bppARGB, NULL, &bitmap); + expect(Ok, stat); + + stat = GdipGetImageGraphicsContext((GpImage*)bitmap, &graphics); + expect(Ok, stat); + + play_metafile(metafile, graphics, emfonly_records, "emfonly playback", dst_points, &frame, UnitPixel); + + stat = GdipBitmapGetPixel(bitmap, 15, 15, &color); + expect(Ok, stat); + expect(0, color); + + stat = GdipBitmapGetPixel(bitmap, 50, 50, &color); + expect(Ok, stat); + todo_wine expect(0xff0000ff, color); + + stat = GdipDeleteGraphics(graphics); + expect(Ok, stat); + + stat = GdipDisposeImage((GpImage*)bitmap); + expect(Ok, stat); + stat = GdipGetHemfFromMetafile(metafile, &hemf); expect(Ok, stat);

1 0

Vincent Povirk : gdiplus: Add test for recording emf-only metafiles.
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: 351a78bb4a85ceff41f4577e901dfe67faeb9669 URL: http://source.winehq.org/git/wine.git/?a=commit;h=351a78bb4a85ceff41f4577e9… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Jul 7 11:37:07 2011 -0500 gdiplus: Add test for recording emf-only metafiles. --- dlls/gdiplus/tests/metafile.c | 81 +++++++++++++++++++++++++++++++++++++++++ 1 files changed, 81 insertions(+), 0 deletions(-) diff --git a/dlls/gdiplus/tests/metafile.c b/dlls/gdiplus/tests/metafile.c index 1a0da15..66e504f 100644 --- a/dlls/gdiplus/tests/metafile.c +++ b/dlls/gdiplus/tests/metafile.c @@ -358,6 +358,86 @@ static void test_getdc(void) ok(ret != 0, "Failed to delete enhmetafile %p\n", hemf); } +static const emfplus_record emfonly_records[] = { + {0, EMR_HEADER}, + {0, EMR_CREATEBRUSHINDIRECT}, + {0, EMR_SELECTOBJECT}, + {0, EMR_RECTANGLE}, + {0, EMR_SELECTOBJECT}, + {0, EMR_DELETEOBJECT}, + {0, EMR_EOF}, + {0} +}; + +static void test_emfonly(void) +{ + GpStatus stat; + GpMetafile *metafile; + GpGraphics *graphics; + HDC hdc, metafile_dc; + HENHMETAFILE hemf; + BOOL ret; + static const GpRectF frame = {0.0, 0.0, 100.0, 100.0}; + static const GpPointF dst_points[3] = {{0.0,0.0},{100.0,0.0},{0.0,100.0}}; + static const WCHAR description[] = {'w','i','n','e','t','e','s','t',0}; + HBRUSH hbrush, holdbrush; + + hdc = CreateCompatibleDC(0); + + stat = GdipRecordMetafile(hdc, EmfTypeEmfOnly, &frame, MetafileFrameUnitPixel, description, &metafile); + expect(Ok, stat); + + DeleteDC(hdc); + + if (stat != Ok) + return; + + stat = GdipGetHemfFromMetafile(metafile, &hemf); + expect(InvalidParameter, stat); + + stat = GdipGetImageGraphicsContext((GpImage*)metafile, &graphics); + expect(Ok, stat); + + stat = GdipGetDC(graphics, &metafile_dc); + expect(Ok, stat); + + if (stat != Ok) + { + GdipDeleteGraphics(graphics); + GdipDisposeImage((GpImage*)metafile); + return; + } + + hbrush = CreateSolidBrush(0xff0000); + + holdbrush = SelectObject(metafile_dc, hbrush); + + Rectangle(metafile_dc, 25, 25, 75, 75); + + SelectObject(metafile_dc, holdbrush); + + DeleteObject(hbrush); + + stat = GdipReleaseDC(graphics, metafile_dc); + expect(Ok, stat); + + stat = GdipDeleteGraphics(graphics); + expect(Ok, stat); + + check_metafile(metafile, emfonly_records, "emfonly metafile", dst_points, &frame, UnitPixel); + + stat = GdipGetHemfFromMetafile(metafile, &hemf); + expect(Ok, stat); + + stat = GdipDisposeImage((GpImage*)metafile); + expect(Ok, stat); + + check_emfplus(hemf, emfonly_records, "emfonly emf"); + + ret = DeleteEnhMetaFile(hemf); + ok(ret != 0, "Failed to delete enhmetafile %p\n", hemf); +} + START_TEST(metafile) { struct GdiplusStartupInput gdiplusStartupInput; @@ -372,6 +452,7 @@ START_TEST(metafile) test_empty(); test_getdc(); + test_emfonly(); GdiplusShutdown(gdiplusToken); }

1 0

Vincent Povirk : gdiplus: Implement GetDC for metafiles.
by Alexandre Julliard 08 Jul '11

08 Jul '11

Module: wine Branch: master Commit: 44c57121ea017adfc16def03ca8f3799bebc040f URL: http://source.winehq.org/git/wine.git/?a=commit;h=44c57121ea017adfc16def03c… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Jul 7 11:30:06 2011 -0500 gdiplus: Implement GetDC for metafiles. --- dlls/gdiplus/gdiplus_private.h | 2 ++ dlls/gdiplus/graphics.c | 36 +++++++++++++++++++++++++----------- dlls/gdiplus/metafile.c | 30 ++++++++++++++++++++++++++++++ dlls/gdiplus/tests/metafile.c | 6 +++--- 4 files changed, 60 insertions(+), 14 deletions(-) diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h index 9cae489..d6888d9 100644 --- a/dlls/gdiplus/gdiplus_private.h +++ b/dlls/gdiplus/gdiplus_private.h @@ -52,6 +52,8 @@ extern REAL convert_unit(REAL logpixels, GpUnit unit) DECLSPEC_HIDDEN; extern GpStatus graphics_from_image(GpImage *image, GpGraphics **graphics) DECLSPEC_HIDDEN; extern GpStatus METAFILE_GetGraphicsContext(GpMetafile* metafile, GpGraphics **result) DECLSPEC_HIDDEN; +extern GpStatus METAFILE_GetDC(GpMetafile* metafile, HDC *hdc) DECLSPEC_HIDDEN; +extern GpStatus METAFILE_ReleaseDC(GpMetafile* metafile, HDC hdc) DECLSPEC_HIDDEN; extern GpStatus METAFILE_GraphicsDeleted(GpMetafile* metafile) DECLSPEC_HIDDEN; extern void calc_curve_bezier(CONST GpPointF *pts, REAL tension, REAL *x1, diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index be25653..1e3f946 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -5311,6 +5311,8 @@ static const COLORREF DC_BACKGROUND_KEY = 0x0c0b0d; GpStatus WINGDIPAPI GdipGetDC(GpGraphics *graphics, HDC *hdc) { + GpStatus stat=Ok; + TRACE("(%p, %p)\n", graphics, hdc); if(!graphics || !hdc) @@ -5319,13 +5321,16 @@ GpStatus WINGDIPAPI GdipGetDC(GpGraphics *graphics, HDC *hdc) if(graphics->busy) return ObjectBusy; - if (!graphics->hdc || + if (graphics->image && graphics->image->type == ImageTypeMetafile) + { + stat = METAFILE_GetDC((GpMetafile*)graphics->image, hdc); + } + else if (!graphics->hdc || (graphics->image && graphics->image->type == ImageTypeBitmap && ((GpBitmap*)graphics->image)->format & PixelFormatAlpha)) { /* Create a fake HDC and fill it with a constant color. */ HDC temp_hdc; HBITMAP hbitmap; - GpStatus stat; GpRectF bounds; BITMAPINFOHEADER bmih; int i; @@ -5374,22 +5379,26 @@ GpStatus WINGDIPAPI GdipGetDC(GpGraphics *graphics, HDC *hdc) *hdc = graphics->hdc; } - graphics->busy = TRUE; + if (stat == Ok) + graphics->busy = TRUE; - return Ok; + return stat; } GpStatus WINGDIPAPI GdipReleaseDC(GpGraphics *graphics, HDC hdc) { - TRACE("(%p, %p)\n", graphics, hdc); + GpStatus stat=Ok; - if(!graphics || !hdc) - return InvalidParameter; + TRACE("(%p, %p)\n", graphics, hdc); - if((graphics->hdc != hdc && graphics->temp_hdc != hdc) || !(graphics->busy)) + if(!graphics || !hdc || !graphics->busy) return InvalidParameter; - if (graphics->temp_hdc == hdc) + if (graphics->image && graphics->image->type == ImageTypeMetafile) + { + stat = METAFILE_ReleaseDC((GpMetafile*)graphics->image, hdc); + } + else if (graphics->temp_hdc == hdc) { DWORD* pos; int i; @@ -5416,10 +5425,15 @@ GpStatus WINGDIPAPI GdipReleaseDC(GpGraphics *graphics, HDC hdc) graphics->temp_hdc = NULL; graphics->temp_hbitmap = NULL; } + else if (hdc != graphics->hdc) + { + stat = InvalidParameter; + } - graphics->busy = FALSE; + if (stat == Ok) + graphics->busy = FALSE; - return Ok; + return stat; } GpStatus WINGDIPAPI GdipGetClip(GpGraphics *graphics, GpRegion *region) diff --git a/dlls/gdiplus/metafile.c b/dlls/gdiplus/metafile.c index 3d26b5c..3e79eb7 100644 --- a/dlls/gdiplus/metafile.c +++ b/dlls/gdiplus/metafile.c @@ -297,6 +297,36 @@ GpStatus METAFILE_GetGraphicsContext(GpMetafile* metafile, GpGraphics **result) return stat; } +GpStatus METAFILE_GetDC(GpMetafile* metafile, HDC *hdc) +{ + if (metafile->metafile_type == MetafileTypeEmfPlusOnly || metafile->metafile_type == MetafileTypeEmfPlusDual) + { + EmfPlusRecordHeader *record; + GpStatus stat; + + stat = METAFILE_AllocateRecord(metafile, sizeof(EmfPlusRecordHeader), (void**)&record); + if (stat != Ok) + return stat; + + record->Type = EmfPlusRecordTypeGetDC; + record->Flags = 0; + + METAFILE_WriteRecords(metafile); + } + + *hdc = metafile->record_dc; + + return Ok; +} + +GpStatus METAFILE_ReleaseDC(GpMetafile* metafile, HDC hdc) +{ + if (hdc != metafile->record_dc) + return InvalidParameter; + + return Ok; +} + GpStatus METAFILE_GraphicsDeleted(GpMetafile* metafile) { GpStatus stat; diff --git a/dlls/gdiplus/tests/metafile.c b/dlls/gdiplus/tests/metafile.c index c85de00..1a0da15 100644 --- a/dlls/gdiplus/tests/metafile.c +++ b/dlls/gdiplus/tests/metafile.c @@ -278,9 +278,9 @@ static void test_empty(void) static const emfplus_record getdc_records[] = { {0, EMR_HEADER}, {0, EmfPlusRecordTypeHeader}, - {1, EmfPlusRecordTypeGetDC}, - {1, EMR_CREATEBRUSHINDIRECT}, - {1, EMR_SELECTOBJECT}, + {0, EmfPlusRecordTypeGetDC}, + {0, EMR_CREATEBRUSHINDIRECT}, + {0, EMR_SELECTOBJECT}, {0, EMR_RECTANGLE}, {0, EMR_SELECTOBJECT}, {0, EMR_DELETEOBJECT},

1 0

← Newer
1
...
59
60
61
62
63
64
65
...
84
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits July 2011