wine-commits January 2012

wine-commits@winehq.org

2 participants
972 discussions

Rico Schüller : d3dx9/tests: Add effect parameter value SetFloatArray() test.
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: 483ae58ef2a01b7c771fee57049506dd8ea2fff3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=483ae58ef2a01b7c771fee570… Author: Rico Schüller <kgbricola(a)web.de> Date: Tue Jan 24 09:48:56 2012 +0100 d3dx9/tests: Add effect parameter value SetFloatArray() test. --- dlls/d3dx9_36/tests/effect.c | 27 +++++++++++++++++++++++++++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c index 4788517..cd0423d 100644 --- a/dlls/d3dx9_36/tests/effect.c +++ b/dlls/d3dx9_36/tests/effect.c @@ -1800,6 +1800,33 @@ static void test_effect_parameter_value(IDirect3DDevice9 *device) } test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); + + /* SetFloatArray */ + fvalue = 1.33; + for (l = 0; l < res_desc->Bytes / sizeof(fvalue); ++l) + { + *(input_value + l) = *(DWORD *)&fvalue; + fvalue += 1.12; + } + memcpy(expected_value, &blob[res_value_offset], res_desc->Bytes); + hr = effect->lpVtbl->SetFloatArray(effect, parameter, (FLOAT *)input_value, res_desc->Bytes / sizeof(*input_value)); + if (res_desc->Class == D3DXPC_SCALAR + || res_desc->Class == D3DXPC_VECTOR + || res_desc->Class == D3DXPC_MATRIX_ROWS) + { + for (l = 0; l < res_desc->Bytes / sizeof(*input_value); ++l) + { + set_number(expected_value + l, res_desc->Type, input_value + l, D3DXPT_FLOAT); + } + ok(hr == D3D_OK, "%u - %s: SetFloatArray failed, got %#x, expected %#x\n", i, res_full_name, hr, D3D_OK); + } + else + { + ok(hr == D3DERR_INVALIDCALL, "%u - %s: SetFloatArray failed, got %#x, expected %#x\n", + i, res_full_name, hr, D3DERR_INVALIDCALL); + } + test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); + test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); } count = effect->lpVtbl->Release(effect);

1 0

Rico Schüller : d3dx9/tests: Add effect parameter value SetFloat() test.
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: 88c996b3c3cc696afa5b3c12998348c90bfa20a7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=88c996b3c3cc696afa5b3c129… Author: Rico Schüller <kgbricola(a)web.de> Date: Tue Jan 24 09:48:49 2012 +0100 d3dx9/tests: Add effect parameter value SetFloat() test. --- dlls/d3dx9_36/tests/effect.c | 18 ++++++++++++++++++ 1 files changed, 18 insertions(+), 0 deletions(-) diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c index 8035735..4788517 100644 --- a/dlls/d3dx9_36/tests/effect.c +++ b/dlls/d3dx9_36/tests/effect.c @@ -1637,6 +1637,7 @@ static void test_effect_parameter_value(IDirect3DDevice9 *device) D3DXPARAMETER_DESC pdesc; BOOL bvalue; INT ivalue; + FLOAT fvalue; DWORD input_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; DWORD expected_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; UINT l; @@ -1782,6 +1783,23 @@ static void test_effect_parameter_value(IDirect3DDevice9 *device) } test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); + + /* SetFloat */ + fvalue = 1.33; + memcpy(expected_value, &blob[res_value_offset], res_desc->Bytes); + hr = effect->lpVtbl->SetFloat(effect, parameter, fvalue); + if (!res_desc->Elements && res_desc->Rows == 1 && res_desc->Columns == 1) + { + set_number(expected_value, res_desc->Type, &fvalue, D3DXPT_FLOAT); + ok(hr == D3D_OK, "%u - %s: SetFloat failed, got %#x, expected %#x\n", i, res_full_name, hr, D3D_OK); + } + else + { + ok(hr == D3DERR_INVALIDCALL, "%u - %s: SetFloat failed, got %#x, expected %#x\n", + i, res_full_name, hr, D3DERR_INVALIDCALL); + } + test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); + test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); } count = effect->lpVtbl->Release(effect);

1 0

Rico Schüller : d3dx9/tests: Add effect parameter value SetIntArray() test.
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: e892f061751d0178f840f4db787c3b689186c099 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e892f061751d0178f840f4db7… Author: Rico Schüller <kgbricola(a)web.de> Date: Tue Jan 24 09:48:45 2012 +0100 d3dx9/tests: Add effect parameter value SetIntArray() test. --- dlls/d3dx9_36/tests/effect.c | 26 ++++++++++++++++++++++++++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c index 3af1d14..8035735 100644 --- a/dlls/d3dx9_36/tests/effect.c +++ b/dlls/d3dx9_36/tests/effect.c @@ -1756,6 +1756,32 @@ static void test_effect_parameter_value(IDirect3DDevice9 *device) } test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); + + /* SetIntArray */ + *input_value = 123456; + for (l = 0; l < res_desc->Bytes / sizeof(*input_value); ++l) + { + *(input_value + l) = *(input_value + l - 1) + 23; + } + memcpy(expected_value, &blob[res_value_offset], res_desc->Bytes); + hr = effect->lpVtbl->SetIntArray(effect, parameter, (INT *)input_value, res_desc->Bytes / sizeof(*input_value)); + if (res_desc->Class == D3DXPC_SCALAR + || res_desc->Class == D3DXPC_VECTOR + || res_desc->Class == D3DXPC_MATRIX_ROWS) + { + for (l = 0; l < res_desc->Bytes / sizeof(*input_value); ++l) + { + set_number(expected_value + l, res_desc->Type, input_value + l, D3DXPT_INT); + } + ok(hr == D3D_OK, "%u - %s: SetIntArray failed, got %#x, expected %#x\n", i, res_full_name, hr, D3D_OK); + } + else + { + ok(hr == D3DERR_INVALIDCALL, "%u - %s: SetIntArray failed, got %#x, expected %#x\n", + i, res_full_name, hr, D3DERR_INVALIDCALL); + } + test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); + test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); } count = effect->lpVtbl->Release(effect);

1 0

Rico Schüller : d3dx9/tests: Add effect parameter value SetInt() test.
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: 51b96991348018cfd4df774a0b45c7e9820019db URL: http://source.winehq.org/git/wine.git/?a=commit;h=51b96991348018cfd4df774a0… Author: Rico Schüller <kgbricola(a)web.de> Date: Tue Jan 24 09:48:41 2012 +0100 d3dx9/tests: Add effect parameter value SetInt() test. --- dlls/d3dx9_36/tests/effect.c | 35 +++++++++++++++++++++++++++++++++++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c index ed08485..3af1d14 100644 --- a/dlls/d3dx9_36/tests/effect.c +++ b/dlls/d3dx9_36/tests/effect.c @@ -888,6 +888,7 @@ test_effect_parameter_value_data[] = #define EFFECT_PARAMETER_VALUE_ARRAY_SIZE 48 /* Constants for special INT/FLOAT conversation */ #define INT_FLOAT_MULTI 255.0f +#define INT_FLOAT_MULTI_INVERSE (1/INT_FLOAT_MULTI) static void test_effect_parameter_value_GetValue(const struct test_effect_parameter_value_result *res, ID3DXEffect *effect, const DWORD *res_value, D3DXHANDLE parameter, UINT i) @@ -1635,6 +1636,7 @@ static void test_effect_parameter_value(IDirect3DDevice9 *device) D3DXHANDLE parameter; D3DXPARAMETER_DESC pdesc; BOOL bvalue; + INT ivalue; DWORD input_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; DWORD expected_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; UINT l; @@ -1721,6 +1723,39 @@ static void test_effect_parameter_value(IDirect3DDevice9 *device) } test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); + + /* SetInt */ + ivalue = 0x1fbf02ff; + memcpy(expected_value, &blob[res_value_offset], res_desc->Bytes); + hr = effect->lpVtbl->SetInt(effect, parameter, ivalue); + if (!res_desc->Elements && res_desc->Rows == 1 && res_desc->Columns == 1) + { + set_number(expected_value, res_desc->Type, &ivalue, D3DXPT_INT); + ok(hr == D3D_OK, "%u - %s: SetInt failed, got %#x, expected %#x\n", i, res_full_name, hr, D3D_OK); + } + else if(!res_desc->Elements && res_desc->Type == D3DXPT_FLOAT && + ((res_desc->Class == D3DXPC_VECTOR && res_desc->Columns != 2) || + (res_desc->Class == D3DXPC_MATRIX_ROWS && res_desc->Rows != 2 && res_desc->Columns == 1))) + { + FLOAT tmp = ((ivalue & 0xff0000) >> 16) * INT_FLOAT_MULTI_INVERSE; + set_number(expected_value, res_desc->Type, &tmp, D3DXPT_FLOAT); + tmp = ((ivalue & 0xff00) >> 8) * INT_FLOAT_MULTI_INVERSE; + set_number(expected_value + 1, res_desc->Type, &tmp, D3DXPT_FLOAT); + tmp = (ivalue & 0xff) * INT_FLOAT_MULTI_INVERSE; + set_number(expected_value + 2, res_desc->Type, &tmp, D3DXPT_FLOAT); + tmp = ((ivalue & 0xff000000) >> 24) * INT_FLOAT_MULTI_INVERSE; + set_number(expected_value + 3, res_desc->Type, &tmp, D3DXPT_FLOAT); + + ok(hr == D3D_OK, "%u - %s: SetInt failed, got %#x, expected %#x\n", + i, res_full_name, hr, D3D_OK); + } + else + { + ok(hr == D3DERR_INVALIDCALL, "%u - %s: SetInt failed, got %#x, expected %#x\n", + i, res_full_name, hr, D3DERR_INVALIDCALL); + } + test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); + test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); } count = effect->lpVtbl->Release(effect);

1 0

Rico Schüller : d3dx9/tests: Add effect parameter value SetBoolArray() test.
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: a90eacab1ab21fefc17aa213dd90b40d3b4eb95f URL: http://source.winehq.org/git/wine.git/?a=commit;h=a90eacab1ab21fefc17aa213d… Author: Rico Schüller <kgbricola(a)web.de> Date: Tue Jan 24 09:48:32 2012 +0100 d3dx9/tests: Add effect parameter value SetBoolArray() test. --- dlls/d3dx9_36/tests/effect.c | 28 ++++++++++++++++++++++++++++ 1 files changed, 28 insertions(+), 0 deletions(-) diff --git a/dlls/d3dx9_36/tests/effect.c b/dlls/d3dx9_36/tests/effect.c index 6e60e2e..ed08485 100644 --- a/dlls/d3dx9_36/tests/effect.c +++ b/dlls/d3dx9_36/tests/effect.c @@ -1635,7 +1635,9 @@ static void test_effect_parameter_value(IDirect3DDevice9 *device) D3DXHANDLE parameter; D3DXPARAMETER_DESC pdesc; BOOL bvalue; + DWORD input_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; DWORD expected_value[EFFECT_PARAMETER_VALUE_ARRAY_SIZE]; + UINT l; parameter = effect->lpVtbl->GetParameterByName(effect, NULL, res_full_name); ok(parameter != NULL, "%u - %s: GetParameterByName failed\n", i, res_full_name); @@ -1693,6 +1695,32 @@ static void test_effect_parameter_value(IDirect3DDevice9 *device) } test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); + + /* SetBoolArray */ + *input_value = 1; + for (l = 1; l < res_desc->Bytes / sizeof(*input_value); ++l) + { + *(input_value + l) = *(input_value + l - 1) + 1; + } + memcpy(expected_value, &blob[res_value_offset], res_desc->Bytes); + hr = effect->lpVtbl->SetBoolArray(effect, parameter, (BOOL *)input_value, res_desc->Bytes / sizeof(*input_value)); + if (res_desc->Class == D3DXPC_SCALAR + || res_desc->Class == D3DXPC_VECTOR + || res_desc->Class == D3DXPC_MATRIX_ROWS) + { + for (l = 0; l < res_desc->Bytes / sizeof(*input_value); ++l) + { + set_number(expected_value + l, res_desc->Type, input_value + l, D3DXPT_BOOL); + } + ok(hr == D3D_OK, "%u - %s: SetBoolArray failed, got %#x, expected %#x\n", i, res_full_name, hr, D3D_OK); + } + else + { + ok(hr == D3DERR_INVALIDCALL, "%u - %s: SetBoolArray failed, got %#x, expected %#x\n", + i, res_full_name, hr, D3DERR_INVALIDCALL); + } + test_effect_parameter_value_GetTestGroup(&res[k], effect, expected_value, parameter, i); + test_effect_parameter_value_ResetValue(&res[k], effect, &blob[res_value_offset], parameter, i); } count = effect->lpVtbl->Release(effect);

1 0

Nikolay Sivov : msxml3: Internally call methods with interface macros.
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: e983db851888b900873153ce42921aee85b40b32 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e983db851888b900873153ce4… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 24 11:02:35 2012 +0300 msxml3: Internally call methods with interface macros. --- dlls/msxml3/domdoc.c | 40 ++++++++++++++++++++-------------------- dlls/msxml3/pi.c | 22 +++++++++++----------- dlls/msxml3/text.c | 8 ++++---- 3 files changed, 35 insertions(+), 35 deletions(-) diff --git a/dlls/msxml3/domdoc.c b/dlls/msxml3/domdoc.c index 8aa1a21..1ae0d56 100644 --- a/dlls/msxml3/domdoc.c +++ b/dlls/msxml3/domdoc.c @@ -672,28 +672,28 @@ static inline domdoc *impl_from_IConnectionPointContainer(IConnectionPointContai /************************************************************************ * domdoc implementation of IPersistStream. */ -static HRESULT WINAPI domdoc_IPersistStreamInit_QueryInterface( +static HRESULT WINAPI PersistStreamInit_QueryInterface( IPersistStreamInit *iface, REFIID riid, void **ppvObj) { domdoc* This = impl_from_IPersistStreamInit(iface); return IXMLDOMDocument3_QueryInterface(&This->IXMLDOMDocument3_iface, riid, ppvObj); } -static ULONG WINAPI domdoc_IPersistStreamInit_AddRef( +static ULONG WINAPI PersistStreamInit_AddRef( IPersistStreamInit *iface) { domdoc* This = impl_from_IPersistStreamInit(iface); return IXMLDOMDocument3_AddRef(&This->IXMLDOMDocument3_iface); } -static ULONG WINAPI domdoc_IPersistStreamInit_Release( +static ULONG WINAPI PersistStreamInit_Release( IPersistStreamInit *iface) { domdoc* This = impl_from_IPersistStreamInit(iface); return IXMLDOMDocument3_Release(&This->IXMLDOMDocument3_iface); } -static HRESULT WINAPI domdoc_IPersistStreamInit_GetClassID( +static HRESULT WINAPI PersistStreamInit_GetClassID( IPersistStreamInit *iface, CLSID *classid) { domdoc* This = impl_from_IPersistStreamInit(iface); @@ -707,7 +707,7 @@ static HRESULT WINAPI domdoc_IPersistStreamInit_GetClassID( return S_OK; } -static HRESULT WINAPI domdoc_IPersistStreamInit_IsDirty( +static HRESULT WINAPI PersistStreamInit_IsDirty( IPersistStreamInit *iface) { domdoc *This = impl_from_IPersistStreamInit(iface); @@ -715,7 +715,7 @@ static HRESULT WINAPI domdoc_IPersistStreamInit_IsDirty( return S_FALSE; } -static HRESULT WINAPI domdoc_IPersistStreamInit_Load( +static HRESULT WINAPI PersistStreamInit_Load( IPersistStreamInit *iface, LPSTREAM pStm) { domdoc *This = impl_from_IPersistStreamInit(iface); @@ -768,7 +768,7 @@ static HRESULT WINAPI domdoc_IPersistStreamInit_Load( return attach_xmldoc(This, xmldoc); } -static HRESULT WINAPI domdoc_IPersistStreamInit_Save( +static HRESULT WINAPI PersistStreamInit_Save( IPersistStreamInit *iface, IStream *stream, BOOL clr_dirty) { domdoc *This = impl_from_IPersistStreamInit(iface); @@ -791,7 +791,7 @@ static HRESULT WINAPI domdoc_IPersistStreamInit_Save( return hr; } -static HRESULT WINAPI domdoc_IPersistStreamInit_GetSizeMax( +static HRESULT WINAPI PersistStreamInit_GetSizeMax( IPersistStreamInit *iface, ULARGE_INTEGER *pcbSize) { domdoc *This = impl_from_IPersistStreamInit(iface); @@ -799,7 +799,7 @@ static HRESULT WINAPI domdoc_IPersistStreamInit_GetSizeMax( return E_NOTIMPL; } -static HRESULT WINAPI domdoc_IPersistStreamInit_InitNew( +static HRESULT WINAPI PersistStreamInit_InitNew( IPersistStreamInit *iface) { domdoc *This = impl_from_IPersistStreamInit(iface); @@ -809,15 +809,15 @@ static HRESULT WINAPI domdoc_IPersistStreamInit_InitNew( static const IPersistStreamInitVtbl xmldoc_IPersistStreamInit_VTable = { - domdoc_IPersistStreamInit_QueryInterface, - domdoc_IPersistStreamInit_AddRef, - domdoc_IPersistStreamInit_Release, - domdoc_IPersistStreamInit_GetClassID, - domdoc_IPersistStreamInit_IsDirty, - domdoc_IPersistStreamInit_Load, - domdoc_IPersistStreamInit_Save, - domdoc_IPersistStreamInit_GetSizeMax, - domdoc_IPersistStreamInit_InitNew + PersistStreamInit_QueryInterface, + PersistStreamInit_AddRef, + PersistStreamInit_Release, + PersistStreamInit_GetClassID, + PersistStreamInit_IsDirty, + PersistStreamInit_Load, + PersistStreamInit_Save, + PersistStreamInit_GetSizeMax, + PersistStreamInit_InitNew }; /* IXMLDOMDocument3 interface */ @@ -2665,7 +2665,7 @@ static HRESULT WINAPI domdoc_validateNode( int validated = 0; TRACE("(%p)->(%p, %p)\n", This, node, err); - domdoc_get_readyState(iface, &state); + IXMLDOMDocument3_get_readyState(iface, &state); if (state != READYSTATE_COMPLETE) { if (err) @@ -2760,7 +2760,7 @@ static HRESULT WINAPI domdoc_validate( { domdoc *This = impl_from_IXMLDOMDocument3( iface ); TRACE("(%p)->(%p)\n", This, err); - return domdoc_validateNode(iface, (IXMLDOMNode*)iface, err); + return IXMLDOMDocument3_validateNode(iface, (IXMLDOMNode*)iface, err); } static HRESULT WINAPI domdoc_setProperty( diff --git a/dlls/msxml3/pi.c b/dlls/msxml3/pi.c index 332d97c..36ff563 100644 --- a/dlls/msxml3/pi.c +++ b/dlls/msxml3/pi.c @@ -222,23 +222,23 @@ static HRESULT WINAPI dom_pi_put_nodeValue( VARIANT value) { dom_pi *This = impl_from_IXMLDOMProcessingInstruction( iface ); - BSTR sTarget; + BSTR target; HRESULT hr; TRACE("(%p)->(%s)\n", This, debugstr_variant(&value)); /* Cannot set data to a PI node whose target is 'xml' */ - hr = dom_pi_get_nodeName(iface, &sTarget); + hr = IXMLDOMProcessingInstruction_get_nodeName(iface, &target); if(hr == S_OK) { static const WCHAR xmlW[] = {'x','m','l',0}; - if(lstrcmpW( sTarget, xmlW) == 0) + if(!strcmpW(target, xmlW)) { - SysFreeString(sTarget); + SysFreeString(target); return E_FAIL; } - SysFreeString(sTarget); + SysFreeString(target); } return node_put_value(&This->node, &value); @@ -637,24 +637,24 @@ static HRESULT WINAPI dom_pi_put_data( BSTR data) { dom_pi *This = impl_from_IXMLDOMProcessingInstruction( iface ); - HRESULT hr; VARIANT val; - BSTR sTarget; + BSTR target; + HRESULT hr; TRACE("(%p)->(%s)\n", This, debugstr_w(data) ); /* Cannot set data to a PI node whose target is 'xml' */ - hr = dom_pi_get_nodeName(iface, &sTarget); + hr = IXMLDOMProcessingInstruction_get_nodeName(iface, &target); if(hr == S_OK) { static const WCHAR xmlW[] = {'x','m','l',0}; - if(lstrcmpW( sTarget, xmlW) == 0) + if(!strcmpW(target, xmlW)) { - SysFreeString(sTarget); + SysFreeString(target); return E_FAIL; } - SysFreeString(sTarget); + SysFreeString(target); } V_VT(&val) = VT_BSTR; diff --git a/dlls/msxml3/text.c b/dlls/msxml3/text.c index abf11b3..74de8e5 100644 --- a/dlls/msxml3/text.c +++ b/dlls/msxml3/text.c @@ -406,7 +406,7 @@ static HRESULT WINAPI domtext_get_nodeTypedValue( if (!var1) return E_INVALIDARG; - hr = domtext_get_parentNode(iface, &parent); + hr = IXMLDOMText_get_parentNode(iface, &parent); if (hr == S_OK) { @@ -433,7 +433,7 @@ static HRESULT WINAPI domtext_put_nodeTypedValue( TRACE("(%p)->(%s)\n", This, debugstr_variant(&value)); - hr = domtext_get_parentNode(iface, &parent); + hr = IXMLDOMText_get_parentNode(iface, &parent); if (hr == S_OK) { @@ -461,7 +461,7 @@ static HRESULT WINAPI domtext_get_dataType( if (!dtName) return E_INVALIDARG; - hr = domtext_get_parentNode(iface, &parent); + hr = IXMLDOMText_get_parentNode(iface, &parent); if (hr == S_OK) { @@ -491,7 +491,7 @@ static HRESULT WINAPI domtext_put_dataType( if (!dtName) return E_INVALIDARG; - hr = domtext_get_parentNode(iface, &parent); + hr = IXMLDOMText_get_parentNode(iface, &parent); if (hr == S_OK) {

1 0

Nikolay Sivov : msxml3: Block ::add() if collection is read-only.
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: 85cf92aed04a00db017330ff1ba7b7e38ab588a2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=85cf92aed04a00db017330ff1… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 24 10:44:19 2012 +0300 msxml3: Block ::add() if collection is read-only. --- dlls/msxml3/schema.c | 8 +++++++- dlls/msxml3/tests/domdoc.c | 9 +-------- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/dlls/msxml3/schema.c b/dlls/msxml3/schema.c index c614d39..253f901 100644 --- a/dlls/msxml3/schema.c +++ b/dlls/msxml3/schema.c @@ -102,6 +102,7 @@ typedef struct xmlHashTablePtr cache; VARIANT_BOOL validateOnLoad; + int read_only; } schema_cache; typedef struct @@ -966,11 +967,13 @@ static void cache_free(void* data, xmlChar* name /* ignored */) queried at libxml2 level here. */ HRESULT cache_from_doc_ns(IXMLDOMSchemaCollection2 *iface, xmlnode *node) { - static const xmlChar query[] = "//*/namespace::*"; schema_cache* This = impl_from_IXMLDOMSchemaCollection2(iface); + static const xmlChar query[] = "//*/namespace::*"; xmlXPathObjectPtr nodeset; xmlXPathContextPtr ctxt; + This->read_only = 1; + ctxt = xmlXPathNewContext(node->node->doc); nodeset = xmlXPathEvalExpression(query, ctxt); @@ -1111,6 +1114,8 @@ static HRESULT WINAPI schema_cache_add(IXMLDOMSchemaCollection2* iface, BSTR uri xmlChar* name = uri ? xmlchar_from_wchar(uri) : xmlchar_from_wchar(emptyW); TRACE("(%p)->(%s %s)\n", This, debugstr_w(uri), debugstr_variant(&var)); + if (This->read_only) return E_FAIL; + switch (V_VT(&var)) { case VT_NULL: @@ -1498,6 +1503,7 @@ HRESULT SchemaCache_create(MSXML_VERSION version, IUnknown* outer, void** obj) This->ref = 1; This->version = version; This->validateOnLoad = VARIANT_TRUE; + This->read_only = 0; init_dispex(&This->dispex, (IUnknown*)&This->IXMLDOMSchemaCollection2_iface, &schemacache_dispex); *obj = &This->IXMLDOMSchemaCollection2_iface; diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index df8e1cb..fb3eab4 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -11400,7 +11400,6 @@ static void test_get_namespaces(void) V_VT(&v) = VT_DISPATCH; V_DISPATCH(&v) = (IDispatch*)doc2; hr = IXMLDOMSchemaCollection_add(collection, _bstr_(xsd_schema1_uri), v); -todo_wine EXPECT_HR(hr, E_FAIL); hr = IXMLDOMSchemaCollection_get_namespaceURI(collection, 0, &s); @@ -11410,16 +11409,13 @@ todo_wine hr = IXMLDOMSchemaCollection_get_namespaceURI(collection, 1, &s); EXPECT_HR(hr, S_OK); -todo_wine ok(!lstrcmpW(s, _bstr_("http://blahblah.org")), "got %s\n", wine_dbgstr_w(s)); SysFreeString(s); s = (void*)0xdeadbeef; hr = IXMLDOMSchemaCollection_get_namespaceURI(collection, 2, &s); -todo_wine { EXPECT_HR(hr, E_FAIL); ok(s == (void*)0xdeadbeef, "got %p\n", s); -} /* enumerate */ enumv = (void*)0xdeadbeef; @@ -11513,7 +11509,6 @@ todo_wine V_VT(&v) = VT_DISPATCH; V_DISPATCH(&v) = (IDispatch*)doc2; hr = IXMLDOMSchemaCollection_add(collection, _bstr_(xsd_schema1_uri), v); -todo_wine EXPECT_HR(hr, E_FAIL); IXMLDOMSchemaCollection_Release(doc2); @@ -11524,16 +11519,14 @@ todo_wine hr = IXMLDOMSchemaCollection_get_namespaceURI(collection, 1, &s); EXPECT_HR(hr, S_OK); -todo_wine ok(!lstrcmpW(s, _bstr_("http://blahblah.org")), "got %s\n", wine_dbgstr_w(s)); SysFreeString(s); s = (void*)0xdeadbeef; hr = IXMLDOMSchemaCollection_get_namespaceURI(collection, 2, &s); -todo_wine { EXPECT_HR(hr, E_FAIL); ok(s == (void*)0xdeadbeef, "got %p\n", s); -} + /* enumerate */ enumv = (void*)0xdeadbeef; hr = IXMLDOMSchemaCollection_get__newEnum(collection, (IUnknown**)&enumv);

1 0

Nikolay Sivov : msxml3: Put all defined document namespaces in collection.
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: 95b9b8218188adc0af5099cb52910f92f1b74704 URL: http://source.winehq.org/git/wine.git/?a=commit;h=95b9b8218188adc0af5099cb5… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 24 10:40:56 2012 +0300 msxml3: Put all defined document namespaces in collection. --- dlls/msxml3/domdoc.c | 38 +++++++++++- dlls/msxml3/msxml_private.h | 5 +- dlls/msxml3/schema.c | 131 ++++++++++++++++++++++++++++++++----------- dlls/msxml3/tests/domdoc.c | 117 +++++++++++++++++++++++++------------- 4 files changed, 211 insertions(+), 80 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=95b9b8218188adc0af509…

1 0

Matteo Bruni : ddraw: Accept pointers to wrong IDirectDrawSurface versions.
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: e51d3f6de60716391181f91fc73f3fbee45f4e9c URL: http://source.winehq.org/git/wine.git/?a=commit;h=e51d3f6de60716391181f91fc… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Mon Jan 23 22:34:48 2012 +0100 ddraw: Accept pointers to wrong IDirectDrawSurface versions. --- dlls/ddraw/surface.c | 57 ++++++++++++++++-- dlls/ddraw/tests/ddraw1.c | 143 +++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw2.c | 143 +++++++++++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw4.c | 120 +++++++++++++++++++++++++++++++++++++ dlls/ddraw/tests/ddraw7.c | 93 +++++++++++++++++++++++++++++ 5 files changed, 551 insertions(+), 5 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=e51d3f6de60716391181f…

1 0

Matteo Bruni : wined3d: SM1 texture projection always divides by w when there is a vertex shader set .
by Alexandre Julliard 24 Jan '12

24 Jan '12

Module: wine Branch: master Commit: f69f2aa3478b860096b846d7a57794d2a7cabe78 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f69f2aa3478b860096b846d7a… Author: Matteo Bruni <mbruni(a)codeweavers.com> Date: Mon Jan 23 22:34:47 2012 +0100 wined3d: SM1 texture projection always divides by w when there is a vertex shader set. --- dlls/d3d9/tests/visual.c | 18 +++++++++--------- dlls/wined3d/shader.c | 35 ++++++++++++++++++++--------------- 2 files changed, 29 insertions(+), 24 deletions(-) diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c index c3c4ad6..4f0f204 100644 --- a/dlls/d3d9/tests/visual.c +++ b/dlls/d3d9/tests/visual.c @@ -4237,25 +4237,25 @@ static void texture_transform_flags_test(IDirect3DDevice9 *device) struct projected_textures_test_run projected_tests_3[4] = { { - "D3DTTFF_PROJECTED (like COUNT4 | PROJECTED) - bottom left", + "D3DTTFF_COUNT3 | D3DTTFF_PROJECTED (like COUNT4 | PROJECTED) - bottom left", D3DTTFF_PROJECTED, decl3, - TRUE, TRUE, + TRUE, FALSE, {120, 300, 240, 390}, }, { - "D3DTTFF_PROJECTED (like COUNT4 | PROJECTED, the w component has the default value 1.0) - bottom right", - D3DTTFF_PROJECTED, - decl, + "D3DTTFF_COUNT3 | D3DTTFF_PROJECTED (like COUNT4 | PROJECTED) - bottom right", + D3DTTFF_COUNT3 | D3DTTFF_PROJECTED, + decl3, TRUE, TRUE, - {340, 450, 360, 465}, + {440, 300, 560, 390}, }, { - "0xffffffff (like COUNT4 | PROJECTED, the w component has the default value 1.0) - top left", + "0xffffffff (like COUNT4 | PROJECTED) - top left", 0xffffffff, - decl, + decl3, TRUE, TRUE, - {20, 210, 40, 225}, + {120, 60, 240, 150}, }, { "D3DTTFF_PROJECTED (like COUNT4 | PROJECTED) - top right", diff --git a/dlls/wined3d/shader.c b/dlls/wined3d/shader.c index 1ca4351..d047269 100644 --- a/dlls/wined3d/shader.c +++ b/dlls/wined3d/shader.c @@ -1919,14 +1919,15 @@ void find_ps_compile_args(const struct wined3d_state *state, if (flags & WINED3D_TTFF_PROJECTED) { - enum wined3d_sampler_texture_type sampler_type = shader->reg_maps.sampler_type[i]; DWORD tex_transform = flags & ~WINED3D_TTFF_PROJECTED; - DWORD max_valid = WINED3D_TTFF_COUNT4; if (!state->vertex_shader) { unsigned int j; unsigned int index = state->texture_states[i][WINED3D_TSS_TEXCOORD_INDEX]; + DWORD max_valid = WINED3D_TTFF_COUNT4; + enum wined3d_sampler_texture_type sampler_type = shader->reg_maps.sampler_type[i]; + for (j = 0; j < state->vertex_declaration->element_count; ++j) { struct wined3d_vertex_declaration_element *element = @@ -1939,21 +1940,25 @@ void find_ps_compile_args(const struct wined3d_state *state, break; } } + if (!tex_transform || tex_transform > max_valid) + { + WARN("Fixing up projected texture transform flags from %#x to %#x.\n", + tex_transform, max_valid); + tex_transform = max_valid; + } + if ((sampler_type == WINED3DSTT_1D && tex_transform > WINED3D_TTFF_COUNT1) + || (sampler_type == WINED3DSTT_2D && tex_transform > WINED3D_TTFF_COUNT2) + || (sampler_type == WINED3DSTT_VOLUME && tex_transform > WINED3D_TTFF_COUNT3)) + tex_transform |= WINED3D_PSARGS_PROJECTED; + else + { + WARN("Application requested projected texture with unsuitable texture coordinates.\n"); + WARN("(texture unit %u, transform flags %#x, sampler type %u).\n", + i, tex_transform, sampler_type); + } } - - if (!tex_transform || tex_transform > max_valid) - { - WARN("Fixing up projected texture transform flags from %#x to %#x.\n", - tex_transform, max_valid); - tex_transform = max_valid; - } - - if ((sampler_type == WINED3DSTT_1D && tex_transform > WINED3D_TTFF_COUNT1) - || (sampler_type == WINED3DSTT_2D && tex_transform > WINED3D_TTFF_COUNT2) - || (sampler_type == WINED3DSTT_VOLUME && tex_transform > WINED3D_TTFF_COUNT3)) - tex_transform |= WINED3D_PSARGS_PROJECTED; else - WARN("Application requested projected texture with unsuitable texture coordinates.\n"); + tex_transform = WINED3D_TTFF_COUNT4 | WINED3D_PSARGS_PROJECTED; args->tex_transform |= tex_transform << i * WINED3D_PSARGS_TEXTRANSFORM_SHIFT; }

1 0

← Newer
1
...
19
20
21
22
23
24
25
...
98
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits January 2012