wine-commits October 2012

wine-commits@winehq.org

2 participants
960 discussions

Hans Leidekker : wbemprox: Implement Win32_Service.StartService.
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: 60cab77b375e7cf3113fdb828c09ffa81eb302b9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=60cab77b375e7cf3113fdb828… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Oct 17 11:07:57 2012 +0200 wbemprox: Implement Win32_Service.StartService. --- dlls/wbemprox/builtin.c | 6 +++- dlls/wbemprox/service.c | 59 ++++++++++++++++++++++++++++++++++++++ dlls/wbemprox/wbemprox_private.h | 2 + 3 files changed, 66 insertions(+), 1 deletions(-) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 5ed2742..69fbc18 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -294,7 +294,8 @@ static const struct column col_service[] = { prop_systemnameW, CIM_STRING|COL_FLAG_DYNAMIC }, /* methods */ { method_pauseserviceW, CIM_FLAG_ARRAY|COL_FLAG_METHOD }, - { method_resumeserviceW, CIM_FLAG_ARRAY|COL_FLAG_METHOD } + { method_resumeserviceW, CIM_FLAG_ARRAY|COL_FLAG_METHOD }, + { method_startserviceW, CIM_FLAG_ARRAY|COL_FLAG_METHOD } }; static const struct column col_sounddevice[] = { @@ -475,6 +476,7 @@ struct record_service /* methods */ class_method *pause_service; class_method *resume_service; + class_method *start_service; }; struct record_sounddevice { @@ -518,6 +520,7 @@ static const struct record_params data_params[] = { { class_serviceW, method_pauseserviceW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, { class_serviceW, method_resumeserviceW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, + { class_serviceW, method_startserviceW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, { class_stdregprovW, method_enumkeyW, 1, param_defkeyW, CIM_SINT32, 0, 0x80000002 }, { class_stdregprovW, method_enumkeyW, 1, param_subkeynameW, CIM_STRING }, { class_stdregprovW, method_enumkeyW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, @@ -1118,6 +1121,7 @@ static void fill_service( struct table *table ) rec->systemname = heap_strdupW( sysnameW ); rec->pause_service = service_pause_service; rec->resume_service = service_resume_service; + rec->start_service = service_start_service; heap_free( config ); offset += sizeof(*rec); num_rows++; diff --git a/dlls/wbemprox/service.c b/dlls/wbemprox/service.c index f381a4b..cd377b9 100644 --- a/dlls/wbemprox/service.c +++ b/dlls/wbemprox/service.c @@ -146,3 +146,62 @@ done: if (hr != S_OK) IWbemClassObject_Release( *out ); return hr; } + +static HRESULT start_service( const WCHAR *name, VARIANT *retval ) +{ + SC_HANDLE manager, service = NULL; + UINT error = 0; + + if (!(manager = OpenSCManagerW( NULL, NULL, SC_MANAGER_ENUMERATE_SERVICE ))) + { + error = map_error( GetLastError() ); + goto done; + } + if (!(service = OpenServiceW( manager, name, SERVICE_START ))) + { + error = map_error( GetLastError() ); + goto done; + } + if (!StartServiceW( service, 0, NULL )) error = map_error( GetLastError() ); + +done: + set_variant( VT_UI4, error, NULL, retval ); + CloseServiceHandle( service ); + CloseServiceHandle( manager ); + return S_OK; +} + +HRESULT service_start_service( IWbemClassObject *obj, IWbemClassObject *in, IWbemClassObject **out ) +{ + VARIANT name, retval; + IWbemClassObject *sig; + HRESULT hr; + + TRACE("%p, %p, %p\n", obj, in, out); + + hr = IWbemClassObject_Get( obj, prop_nameW, 0, &name, NULL, NULL ); + if (hr != S_OK) return hr; + + hr = create_signature( class_serviceW, method_startserviceW, PARAM_OUT, &sig ); + if (hr != S_OK) + { + VariantClear( &name ); + return hr; + } + hr = IWbemClassObject_SpawnInstance( sig, 0, out ); + if (hr != S_OK) + { + VariantClear( &name ); + IWbemClassObject_Release( sig ); + return hr; + } + hr = start_service( V_BSTR(&name), &retval ); + if (hr != S_OK) goto done; + hr = IWbemClassObject_Put( *out, param_returnvalueW, 0, &retval, CIM_UINT32 ); + +done: + VariantClear( &name ); + IWbemClassObject_Release( sig ); + if (hr != S_OK) IWbemClassObject_Release( *out ); + return hr; +} diff --git a/dlls/wbemprox/wbemprox_private.h b/dlls/wbemprox/wbemprox_private.h index 7f5bc6a..39870bf 100644 --- a/dlls/wbemprox/wbemprox_private.h +++ b/dlls/wbemprox/wbemprox_private.h @@ -203,6 +203,7 @@ HRESULT reg_enum_values(IWbemClassObject *, IWbemClassObject *, IWbemClassObject HRESULT reg_get_stringvalue(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; HRESULT service_pause_service(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; HRESULT service_resume_service(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; +HRESULT service_start_service(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; static void *heap_alloc( size_t len ) __WINE_ALLOC_SIZE(1); static inline void *heap_alloc( size_t len ) @@ -245,6 +246,7 @@ static const WCHAR method_enumvaluesW[] = {'E','n','u','m','V','a','l','u','e',' static const WCHAR method_getstringvalueW[] = {'G','e','t','S','t','r','i','n','g','V','a','l','u','e',0}; static const WCHAR method_pauseserviceW[] = {'P','a','u','s','e','S','e','r','v','i','c','e',0}; static const WCHAR method_resumeserviceW[] = {'R','e','s','u','m','e','S','e','r','v','i','c','e',0}; +static const WCHAR method_startserviceW[] = {'S','t','a','r','t','S','e','r','v','i','c','e',0}; static const WCHAR param_defkeyW[] = {'h','D','e','f','K','e','y',0}; static const WCHAR param_namesW[] = {'s','N','a','m','e','s',0};

1 0

Hans Leidekker : wbemprox: Implement Win32_Service.ResumeService.
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: 139c9f02765134bf93919d45555ab7adf5c0b2a5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=139c9f02765134bf93919d455… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Oct 17 11:07:38 2012 +0200 wbemprox: Implement Win32_Service.ResumeService. --- dlls/wbemprox/builtin.c | 6 +++++- dlls/wbemprox/service.c | 35 +++++++++++++++++++++++++++++++++++ dlls/wbemprox/wbemprox_private.h | 2 ++ 3 files changed, 42 insertions(+), 1 deletions(-) diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 5138fde..5ed2742 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -293,7 +293,8 @@ static const struct column col_service[] = { prop_stateW, CIM_STRING }, { prop_systemnameW, CIM_STRING|COL_FLAG_DYNAMIC }, /* methods */ - { method_pauseserviceW, CIM_FLAG_ARRAY|COL_FLAG_METHOD } + { method_pauseserviceW, CIM_FLAG_ARRAY|COL_FLAG_METHOD }, + { method_resumeserviceW, CIM_FLAG_ARRAY|COL_FLAG_METHOD } }; static const struct column col_sounddevice[] = { @@ -473,6 +474,7 @@ struct record_service const WCHAR *systemname; /* methods */ class_method *pause_service; + class_method *resume_service; }; struct record_sounddevice { @@ -515,6 +517,7 @@ static const struct record_diskdrive data_diskdrive[] = static const struct record_params data_params[] = { { class_serviceW, method_pauseserviceW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, + { class_serviceW, method_resumeserviceW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, { class_stdregprovW, method_enumkeyW, 1, param_defkeyW, CIM_SINT32, 0, 0x80000002 }, { class_stdregprovW, method_enumkeyW, 1, param_subkeynameW, CIM_STRING }, { class_stdregprovW, method_enumkeyW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, @@ -1114,6 +1117,7 @@ static void fill_service( struct table *table ) rec->state = get_service_state( status->dwCurrentState ); rec->systemname = heap_strdupW( sysnameW ); rec->pause_service = service_pause_service; + rec->resume_service = service_resume_service; heap_free( config ); offset += sizeof(*rec); num_rows++; diff --git a/dlls/wbemprox/service.c b/dlls/wbemprox/service.c index 7c6aabf..f381a4b 100644 --- a/dlls/wbemprox/service.c +++ b/dlls/wbemprox/service.c @@ -111,3 +111,38 @@ done: if (hr != S_OK) IWbemClassObject_Release( *out ); return hr; } + +HRESULT service_resume_service( IWbemClassObject *obj, IWbemClassObject *in, IWbemClassObject **out ) +{ + VARIANT name, retval; + IWbemClassObject *sig; + HRESULT hr; + + TRACE("%p, %p, %p\n", obj, in, out); + + hr = IWbemClassObject_Get( obj, prop_nameW, 0, &name, NULL, NULL ); + if (hr != S_OK) return hr; + + hr = create_signature( class_serviceW, method_resumeserviceW, PARAM_OUT, &sig ); + if (hr != S_OK) + { + VariantClear( &name ); + return hr; + } + hr = IWbemClassObject_SpawnInstance( sig, 0, out ); + if (hr != S_OK) + { + VariantClear( &name ); + IWbemClassObject_Release( sig ); + return hr; + } + hr = control_service( V_BSTR(&name), SERVICE_CONTROL_CONTINUE, &retval ); + if (hr != S_OK) goto done; + hr = IWbemClassObject_Put( *out, param_returnvalueW, 0, &retval, CIM_UINT32 ); + +done: + VariantClear( &name ); + IWbemClassObject_Release( sig ); + if (hr != S_OK) IWbemClassObject_Release( *out ); + return hr; +} diff --git a/dlls/wbemprox/wbemprox_private.h b/dlls/wbemprox/wbemprox_private.h index c2181c0..7f5bc6a 100644 --- a/dlls/wbemprox/wbemprox_private.h +++ b/dlls/wbemprox/wbemprox_private.h @@ -202,6 +202,7 @@ HRESULT reg_enum_key(IWbemClassObject *, IWbemClassObject *, IWbemClassObject ** HRESULT reg_enum_values(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; HRESULT reg_get_stringvalue(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; HRESULT service_pause_service(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; +HRESULT service_resume_service(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; static void *heap_alloc( size_t len ) __WINE_ALLOC_SIZE(1); static inline void *heap_alloc( size_t len ) @@ -243,6 +244,7 @@ static const WCHAR method_enumkeyW[] = {'E','n','u','m','K','e','y',0}; static const WCHAR method_enumvaluesW[] = {'E','n','u','m','V','a','l','u','e','s',0}; static const WCHAR method_getstringvalueW[] = {'G','e','t','S','t','r','i','n','g','V','a','l','u','e',0}; static const WCHAR method_pauseserviceW[] = {'P','a','u','s','e','S','e','r','v','i','c','e',0}; +static const WCHAR method_resumeserviceW[] = {'R','e','s','u','m','e','S','e','r','v','i','c','e',0}; static const WCHAR param_defkeyW[] = {'h','D','e','f','K','e','y',0}; static const WCHAR param_namesW[] = {'s','N','a','m','e','s',0};

1 0

Hans Leidekker : wbemprox: Implement Win32_Service.PauseService.
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: 8fe25b2b89b4b2e2ae23b079671426ae67fd70d7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8fe25b2b89b4b2e2ae23b0796… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Oct 17 11:07:17 2012 +0200 wbemprox: Implement Win32_Service.PauseService. --- dlls/wbemprox/Makefile.in | 1 + dlls/wbemprox/builtin.c | 30 +++++----- dlls/wbemprox/service.c | 113 ++++++++++++++++++++++++++++++++++++++ dlls/wbemprox/wbemprox_private.h | 5 ++ 4 files changed, 135 insertions(+), 14 deletions(-) diff --git a/dlls/wbemprox/Makefile.in b/dlls/wbemprox/Makefile.in index b04bb64..bd96a99 100644 --- a/dlls/wbemprox/Makefile.in +++ b/dlls/wbemprox/Makefile.in @@ -7,6 +7,7 @@ C_SRCS = \ main.c \ query.c \ reg.c \ + service.c \ services.c \ table.c \ wbemlocator.c diff --git a/dlls/wbemprox/builtin.c b/dlls/wbemprox/builtin.c index 9e515ef..5138fde 100644 --- a/dlls/wbemprox/builtin.c +++ b/dlls/wbemprox/builtin.c @@ -65,8 +65,6 @@ static const WCHAR class_processW[] = {'W','i','n','3','2','_','P','r','o','c','e','s','s',0}; static const WCHAR class_processorW[] = {'W','i','n','3','2','_','P','r','o','c','e','s','s','o','r',0}; -static const WCHAR class_serviceW[] = - {'W','i','n','3','2','_','S','e','r','v','i','c','e',0}; static const WCHAR class_sounddeviceW[] = {'W','i','n','3','2','_','S','o','u','n','d','D','e','v','i','c','e',0}; static const WCHAR class_videocontrollerW[] = @@ -132,8 +130,6 @@ static const WCHAR prop_methodW[] = {'M','e','t','h','o','d',0}; static const WCHAR prop_modelW[] = {'M','o','d','e','l',0}; -static const WCHAR prop_nameW[] = - {'N','a','m','e',0}; static const WCHAR prop_netconnectionstatusW[] = {'N','e','t','C','o','n','n','e','c','t','i','o','n','S','t','a','t','u','s',0}; static const WCHAR prop_numlogicalprocessorsW[] = @@ -295,7 +291,9 @@ static const struct column col_service[] = { prop_servicetypeW, CIM_STRING }, { prop_startmodeW, CIM_STRING }, { prop_stateW, CIM_STRING }, - { prop_systemnameW, CIM_STRING|COL_FLAG_DYNAMIC } + { prop_systemnameW, CIM_STRING|COL_FLAG_DYNAMIC }, + /* methods */ + { method_pauseserviceW, CIM_FLAG_ARRAY|COL_FLAG_METHOD } }; static const struct column col_sounddevice[] = { @@ -473,6 +471,8 @@ struct record_service const WCHAR *startmode; const WCHAR *state; const WCHAR *systemname; + /* methods */ + class_method *pause_service; }; struct record_sounddevice { @@ -514,6 +514,7 @@ static const struct record_diskdrive data_diskdrive[] = }; static const struct record_params data_params[] = { + { class_serviceW, method_pauseserviceW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, { class_stdregprovW, method_enumkeyW, 1, param_defkeyW, CIM_SINT32, 0, 0x80000002 }, { class_stdregprovW, method_enumkeyW, 1, param_subkeynameW, CIM_STRING }, { class_stdregprovW, method_enumkeyW, -1, param_returnvalueW, CIM_UINT32, VT_I4 }, @@ -1103,15 +1104,16 @@ static void fill_service( struct table *table ) status = &services[i].ServiceStatusProcess; rec = (struct record_service *)(table->data + offset); - rec->accept_pause = (status->dwControlsAccepted & SERVICE_ACCEPT_PAUSE_CONTINUE) ? -1 : 0; - rec->accept_stop = (status->dwControlsAccepted & SERVICE_ACCEPT_STOP) ? -1 : 0; - rec->displayname = heap_strdupW( services[i].lpDisplayName ); - rec->name = heap_strdupW( services[i].lpServiceName ); - rec->process_id = status->dwProcessId; - rec->servicetype = get_service_type( status->dwServiceType ); - rec->startmode = get_service_startmode( config->dwStartType ); - rec->state = get_service_state( status->dwCurrentState ); - rec->systemname = heap_strdupW( sysnameW ); + rec->accept_pause = (status->dwControlsAccepted & SERVICE_ACCEPT_PAUSE_CONTINUE) ? -1 : 0; + rec->accept_stop = (status->dwControlsAccepted & SERVICE_ACCEPT_STOP) ? -1 : 0; + rec->displayname = heap_strdupW( services[i].lpDisplayName ); + rec->name = heap_strdupW( services[i].lpServiceName ); + rec->process_id = status->dwProcessId; + rec->servicetype = get_service_type( status->dwServiceType ); + rec->startmode = get_service_startmode( config->dwStartType ); + rec->state = get_service_state( status->dwCurrentState ); + rec->systemname = heap_strdupW( sysnameW ); + rec->pause_service = service_pause_service; heap_free( config ); offset += sizeof(*rec); num_rows++; diff --git a/dlls/wbemprox/service.c b/dlls/wbemprox/service.c new file mode 100644 index 0000000..7c6aabf --- /dev/null +++ b/dlls/wbemprox/service.c @@ -0,0 +1,113 @@ +/* + * Win32_Service methods implementation + * + * Copyright 2012 Hans Leidekker for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#define COBJMACROS + +#include "config.h" +#include <stdarg.h> + +#include "windef.h" +#include "winbase.h" +#include "wbemcli.h" +#include "winsvc.h" + +#include "wine/debug.h" +#include "wbemprox_private.h" + +WINE_DEFAULT_DEBUG_CHANNEL(wbemprox); + +static UINT map_error( DWORD error ) +{ + switch (error) + { + case ERROR_SUCCESS: return 0; + case ERROR_ACCESS_DENIED: return 2; + case ERROR_DEPENDENT_SERVICES_RUNNING: return 3; + case ERROR_INVALID_SERVICE_CONTROL: return 4; + case ERROR_SERVICE_CANNOT_ACCEPT_CTRL: return 5; + case ERROR_SERVICE_NOT_ACTIVE: return 6; + case ERROR_SERVICE_REQUEST_TIMEOUT: return 7; + case ERROR_SERVICE_ALREADY_RUNNING: return 10; + default: + WARN("unknown error %u\n", error); + break; + } + return 8; +} + +static HRESULT control_service( const WCHAR *name, DWORD control, VARIANT *retval ) +{ + SC_HANDLE manager, service = NULL; + SERVICE_STATUS status; + UINT error = 0; + + if (!(manager = OpenSCManagerW( NULL, NULL, SC_MANAGER_ENUMERATE_SERVICE ))) + { + error = map_error( GetLastError() ); + goto done; + } + if (!(service = OpenServiceW( manager, name, SERVICE_STOP|SERVICE_START|SERVICE_PAUSE_CONTINUE ))) + { + error = map_error( GetLastError() ); + goto done; + } + if (!ControlService( service, control, &status )) error = map_error( GetLastError() ); + +done: + set_variant( VT_UI4, error, NULL, retval ); + CloseServiceHandle( service ); + CloseServiceHandle( manager ); + return S_OK; +} + +HRESULT service_pause_service( IWbemClassObject *obj, IWbemClassObject *in, IWbemClassObject **out ) +{ + VARIANT name, retval; + IWbemClassObject *sig; + HRESULT hr; + + TRACE("%p, %p, %p\n", obj, in, out); + + hr = IWbemClassObject_Get( obj, prop_nameW, 0, &name, NULL, NULL ); + if (hr != S_OK) return hr; + + hr = create_signature( class_serviceW, method_pauseserviceW, PARAM_OUT, &sig ); + if (hr != S_OK) + { + VariantClear( &name ); + return hr; + } + hr = IWbemClassObject_SpawnInstance( sig, 0, out ); + if (hr != S_OK) + { + VariantClear( &name ); + IWbemClassObject_Release( sig ); + return hr; + } + hr = control_service( V_BSTR(&name), SERVICE_CONTROL_PAUSE, &retval ); + if (hr != S_OK) goto done; + hr = IWbemClassObject_Put( *out, param_returnvalueW, 0, &retval, CIM_UINT32 ); + +done: + VariantClear( &name ); + IWbemClassObject_Release( sig ); + if (hr != S_OK) IWbemClassObject_Release( *out ); + return hr; +} diff --git a/dlls/wbemprox/wbemprox_private.h b/dlls/wbemprox/wbemprox_private.h index 05da3c6..c2181c0 100644 --- a/dlls/wbemprox/wbemprox_private.h +++ b/dlls/wbemprox/wbemprox_private.h @@ -201,6 +201,7 @@ HRESULT EnumWbemClassObject_create(IUnknown *, struct query *, LPVOID *) DECLSPE HRESULT reg_enum_key(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; HRESULT reg_enum_values(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; HRESULT reg_get_stringvalue(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; +HRESULT service_pause_service(IWbemClassObject *, IWbemClassObject *, IWbemClassObject **) DECLSPEC_HIDDEN; static void *heap_alloc( size_t len ) __WINE_ALLOC_SIZE(1); static inline void *heap_alloc( size_t len ) @@ -233,11 +234,15 @@ static inline WCHAR *heap_strdupW( const WCHAR *src ) return dst; } +static const WCHAR class_serviceW[] = {'W','i','n','3','2','_','S','e','r','v','i','c','e',0}; static const WCHAR class_stdregprovW[] = {'S','t','d','R','e','g','P','r','o','v',0}; +static const WCHAR prop_nameW[] = {'N','a','m','e',0}; + static const WCHAR method_enumkeyW[] = {'E','n','u','m','K','e','y',0}; static const WCHAR method_enumvaluesW[] = {'E','n','u','m','V','a','l','u','e','s',0}; static const WCHAR method_getstringvalueW[] = {'G','e','t','S','t','r','i','n','g','V','a','l','u','e',0}; +static const WCHAR method_pauseserviceW[] = {'P','a','u','s','e','S','e','r','v','i','c','e',0}; static const WCHAR param_defkeyW[] = {'h','D','e','f','K','e','y',0}; static const WCHAR param_namesW[] = {'s','N','a','m','e','s',0};

1 0

Hans Leidekker : wbemprox: The last parameter to IWbemClassObject:: GetMethod is optional.
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: 64a7f2ea7fddb3934e13818cc24aad650358235b URL: http://source.winehq.org/git/wine.git/?a=commit;h=64a7f2ea7fddb3934e13818cc… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Oct 17 11:06:59 2012 +0200 wbemprox: The last parameter to IWbemClassObject::GetMethod is optional. --- dlls/wbemprox/class.c | 2 +- dlls/wbemprox/tests/query.c | 11 ++++------- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/dlls/wbemprox/class.c b/dlls/wbemprox/class.c index a3a06e1..75bd612 100644 --- a/dlls/wbemprox/class.c +++ b/dlls/wbemprox/class.c @@ -848,7 +848,7 @@ static HRESULT WINAPI class_object_GetMethod( TRACE("%p, %s, %08x, %p, %p\n", iface, debugstr_w(wszName), lFlags, ppInSignature, ppOutSignature); hr = create_signature( co->name, wszName, PARAM_IN, ppInSignature ); - if (hr != S_OK) return hr; + if (hr != S_OK || !ppOutSignature) return hr; hr = create_signature( co->name, wszName, PARAM_OUT, ppOutSignature ); if (hr != S_OK) IWbemClassObject_Release( *ppInSignature ); diff --git a/dlls/wbemprox/tests/query.c b/dlls/wbemprox/tests/query.c index 15fad8c..e531b3c 100644 --- a/dlls/wbemprox/tests/query.c +++ b/dlls/wbemprox/tests/query.c @@ -143,7 +143,7 @@ static void test_StdRegProv( IWbemServices *services ) {'S','o','f','t','w','a','r','e','\\','M','i','c','r','o','s','o','f','t','\\', 'W','i','n','d','o','w','s','\\','C','u','r','r','e','n','t','V','e','r','s','i','o','n',0}; BSTR class = SysAllocString( stdregprovW ), method; - IWbemClassObject *reg, *sig_in, *sig_out, *in, *out; + IWbemClassObject *reg, *sig_in, *in, *out; VARIANT defkey, subkey, retval, names, types, value, valuename; CIMTYPE type; HRESULT hr; @@ -154,7 +154,7 @@ static void test_StdRegProv( IWbemServices *services ) win_skip( "StdRegProv not available\n" ); return; } - hr = IWbemClassObject_GetMethod( reg, enumkeyW, 0, &sig_in, &sig_out ); + hr = IWbemClassObject_GetMethod( reg, enumkeyW, 0, &sig_in, NULL ); ok( hr == S_OK, "failed to get EnumKey method %08x\n", hr ); hr = IWbemClassObject_SpawnInstance( sig_in, 0, &in ); @@ -196,9 +196,8 @@ static void test_StdRegProv( IWbemServices *services ) IWbemClassObject_Release( in ); IWbemClassObject_Release( out ); IWbemClassObject_Release( sig_in ); - IWbemClassObject_Release( sig_out ); - hr = IWbemClassObject_GetMethod( reg, enumvaluesW, 0, &sig_in, &sig_out ); + hr = IWbemClassObject_GetMethod( reg, enumvaluesW, 0, &sig_in, NULL ); ok( hr == S_OK, "failed to get EnumValues method %08x\n", hr ); hr = IWbemClassObject_SpawnInstance( sig_in, 0, &in ); @@ -248,9 +247,8 @@ static void test_StdRegProv( IWbemServices *services ) IWbemClassObject_Release( in ); IWbemClassObject_Release( out ); IWbemClassObject_Release( sig_in ); - IWbemClassObject_Release( sig_out ); - hr = IWbemClassObject_GetMethod( reg, getstringvalueW, 0, &sig_in, &sig_out ); + hr = IWbemClassObject_GetMethod( reg, getstringvalueW, 0, &sig_in, NULL ); ok( hr == S_OK, "failed to get GetStringValue method %08x\n", hr ); hr = IWbemClassObject_SpawnInstance( sig_in, 0, &in ); @@ -298,7 +296,6 @@ static void test_StdRegProv( IWbemServices *services ) IWbemClassObject_Release( in ); IWbemClassObject_Release( out ); IWbemClassObject_Release( sig_in ); - IWbemClassObject_Release( sig_out ); IWbemClassObject_Release( reg ); SysFreeString( class );

1 0

Hans Leidekker : wbemprox: Keep a reference to the table from uncommitted instances.
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: 2eb666d624d3729f25b8bc9a5f51be7e95d71829 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2eb666d624d3729f25b8bc9a5… Author: Hans Leidekker <hans(a)codeweavers.com> Date: Wed Oct 17 11:06:41 2012 +0200 wbemprox: Keep a reference to the table from uncommitted instances. --- dlls/wbemprox/class.c | 32 ++++++++++++-------------------- dlls/wbemprox/query.c | 3 ++- dlls/wbemprox/table.c | 9 +++++++-- dlls/wbemprox/wbemprox_private.h | 4 +++- 4 files changed, 24 insertions(+), 24 deletions(-) diff --git a/dlls/wbemprox/class.c b/dlls/wbemprox/class.c index dc03371..a3a06e1 100644 --- a/dlls/wbemprox/class.c +++ b/dlls/wbemprox/class.c @@ -202,8 +202,7 @@ HRESULT EnumWbemClassObject_create( ec->IEnumWbemClassObject_iface.lpVtbl = &enum_class_object_vtbl; ec->refs = 1; - ec->query = query; - addref_query( query ); + ec->query = addref_query( query ); ec->index = 0; *ppObj = &ec->IEnumWbemClassObject_iface; @@ -212,24 +211,25 @@ HRESULT EnumWbemClassObject_create( return S_OK; } -static struct record *create_record( const struct column *columns, UINT num_cols ) +static struct record *create_record( struct table *table ) { UINT i; struct record *record; if (!(record = heap_alloc( sizeof(struct record) ))) return NULL; - if (!(record->fields = heap_alloc( num_cols * sizeof(struct field) ))) + if (!(record->fields = heap_alloc( table->num_cols * sizeof(struct field) ))) { heap_free( record ); return NULL; } - for (i = 0; i < num_cols; i++) + for (i = 0; i < table->num_cols; i++) { - record->fields[i].type = columns[i].type; - record->fields[i].vartype = columns[i].vartype; + record->fields[i].type = table->columns[i].type; + record->fields[i].vartype = table->columns[i].vartype; record->fields[i].u.ival = 0; } - record->count = num_cols; + record->count = table->num_cols; + record->table = addref_table( table ); return record; } @@ -252,6 +252,7 @@ static void destroy_record( struct record *record ) UINT i; if (!record) return; + release_table( record->table ); for (i = 0; i < record->count; i++) { if (record->fields[i].type == CIM_STRING || record->fields[i].type == CIM_DATETIME) @@ -390,14 +391,10 @@ static HRESULT WINAPI class_object_Get( if (co->record) { - struct table *table = grab_table( co->name ); UINT index; HRESULT hr; - if (!table) return WBEM_E_FAILED; - hr = get_column_index( table, wszName, &index ); - release_table( table ); - if (hr != S_OK) return hr; + if ((hr = get_column_index( co->record->table, wszName, &index )) != S_OK) return hr; return record_get_value( co->record, index, pVal, pType ); } return get_propval( ec->query->view, co->index, wszName, pVal, pType, plFlavor ); @@ -450,14 +447,10 @@ static HRESULT WINAPI class_object_Put( if (co->record) { - struct table *table = grab_table( co->name ); UINT index; HRESULT hr; - if (!table) return WBEM_E_FAILED; - hr = get_column_index( table, wszName, &index ); - release_table( table ); - if (hr != S_OK) return hr; + if ((hr = get_column_index( co->record->table, wszName, &index )) != S_OK) return hr; return record_set_value( co->record, index, pVal ); } return put_propval( ec->query->view, co->index, wszName, pVal, Type ); @@ -650,8 +643,7 @@ static HRESULT WINAPI class_object_SpawnInstance( TRACE("%p, %08x, %p\n", iface, lFlags, ppNewInstance); - if (!(record = create_record( view->table->columns, view->table->num_cols ))) - return E_OUTOFMEMORY; + if (!(record = create_record( view->table ))) return E_OUTOFMEMORY; return create_class_object( co->name, NULL, 0, record, ppNewInstance ); } diff --git a/dlls/wbemprox/query.c b/dlls/wbemprox/query.c index 29026c9..3fdee00 100644 --- a/dlls/wbemprox/query.c +++ b/dlls/wbemprox/query.c @@ -290,9 +290,10 @@ static void free_query( struct query *query ) heap_free( query ); } -void addref_query( struct query *query ) +struct query *addref_query( struct query *query ) { InterlockedIncrement( &query->refs ); + return query; } void release_query( struct query *query ) diff --git a/dlls/wbemprox/table.c b/dlls/wbemprox/table.c index 277998b..43ab91d 100644 --- a/dlls/wbemprox/table.c +++ b/dlls/wbemprox/table.c @@ -321,6 +321,12 @@ void release_table( struct table *table ) if (!InterlockedDecrement( &table->refs )) free_table( table ); } +struct table *addref_table( struct table *table ) +{ + InterlockedIncrement( &table->refs ); + return table; +} + struct table *grab_table( const WCHAR *name ) { struct table *table; @@ -330,9 +336,8 @@ struct table *grab_table( const WCHAR *name ) if (!strcmpiW( table->name, name )) { if (table->fill && !table->data) table->fill( table ); - InterlockedIncrement( &table->refs ); TRACE("returning %p\n", table); - return table; + return addref_table( table ); } } return NULL; diff --git a/dlls/wbemprox/wbemprox_private.h b/dlls/wbemprox/wbemprox_private.h index 02fc919..05da3c6 100644 --- a/dlls/wbemprox/wbemprox_private.h +++ b/dlls/wbemprox/wbemprox_private.h @@ -91,6 +91,7 @@ struct record { UINT count; struct field *fields; + struct table *table; }; enum operator @@ -154,7 +155,7 @@ struct query struct list mem; }; -void addref_query( struct query * ) DECLSPEC_HIDDEN; +struct query *addref_query( struct query * ) DECLSPEC_HIDDEN; void release_query( struct query *query ) DECLSPEC_HIDDEN; HRESULT exec_query( const WCHAR *, IEnumWbemClassObject ** ) DECLSPEC_HIDDEN; HRESULT parse_query( const WCHAR *, struct view **, struct list * ) DECLSPEC_HIDDEN; @@ -163,6 +164,7 @@ HRESULT create_view( const struct property *, const WCHAR *, const struct expr * void destroy_view( struct view * ) DECLSPEC_HIDDEN; void init_table_list( void ) DECLSPEC_HIDDEN; struct table *grab_table( const WCHAR * ) DECLSPEC_HIDDEN; +struct table *addref_table( struct table * ) DECLSPEC_HIDDEN; void release_table( struct table * ) DECLSPEC_HIDDEN; struct table *create_table( const WCHAR *, UINT, const struct column *, UINT, BYTE *, void (*)(struct table *)) DECLSPEC_HIDDEN;

1 0

Jacek Caban : vbscript: Use simplified builtin constants for more constants .
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: 1d8763bbf9ba61763ecde7b1e30df5cf67d574ef URL: http://source.winehq.org/git/wine.git/?a=commit;h=1d8763bbf9ba61763ecde7b1e… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 17 09:54:45 2012 +0200 vbscript: Use simplified builtin constants for more constants. --- dlls/vbscript/global.c | 48 ++++++------------------------------------------ 1 files changed, 6 insertions(+), 42 deletions(-) diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c index 87d2736..fa2d64f 100644 --- a/dlls/vbscript/global.c +++ b/dlls/vbscript/global.c @@ -1578,42 +1578,6 @@ static HRESULT Global_vbFirstFullWeek(vbdisp_t *This, VARIANT *arg, unsigned arg return E_NOTIMPL; } -static HRESULT Global_vbOKOnly(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, MB_OK); -} - -static HRESULT Global_vbOKCancel(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, MB_OKCANCEL); -} - -static HRESULT Global_vbAbortRetryIgnore(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, MB_ABORTRETRYIGNORE); -} - -static HRESULT Global_vbYesNoCancel(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, MB_YESNOCANCEL); -} - -static HRESULT Global_vbYesNo(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, MB_YESNO); -} - -static HRESULT Global_vbRetryCancel(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, MB_RETRYCANCEL); -} - static HRESULT Global_vbCritical(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) { FIXME("\n"); @@ -2029,12 +1993,12 @@ static const builtin_prop_t global_props[] = { {DISPID_GLOBAL_VBFIRSTJAN1, Global_vbFirstJan1, BP_GET}, {DISPID_GLOBAL_VBFIRSTFOURDAYS, Global_vbFirstFourDays, BP_GET}, {DISPID_GLOBAL_VBFIRSTFULLWEEK, Global_vbFirstFullWeek, BP_GET}, - {DISPID_GLOBAL_VBOKONLY, Global_vbOKOnly, BP_GET}, - {DISPID_GLOBAL_VBOKCANCEL, Global_vbOKCancel, BP_GET}, - {DISPID_GLOBAL_VBABORTRETRYIGNORE, Global_vbAbortRetryIgnore, BP_GET}, - {DISPID_GLOBAL_VBYESNOCANCEL, Global_vbYesNoCancel, BP_GET}, - {DISPID_GLOBAL_VBYESNO, Global_vbYesNo, BP_GET}, - {DISPID_GLOBAL_VBRETRYCANCEL, Global_vbRetryCancel, BP_GET}, + {DISPID_GLOBAL_VBOKONLY, NULL, BP_GET, MB_OK}, + {DISPID_GLOBAL_VBOKCANCEL, NULL, BP_GET, MB_OKCANCEL}, + {DISPID_GLOBAL_VBABORTRETRYIGNORE, NULL, BP_GET, MB_ABORTRETRYIGNORE}, + {DISPID_GLOBAL_VBYESNOCANCEL, NULL, BP_GET, MB_YESNOCANCEL}, + {DISPID_GLOBAL_VBYESNO, NULL, BP_GET, MB_YESNO}, + {DISPID_GLOBAL_VBRETRYCANCEL, NULL, BP_GET, MB_RETRYCANCEL}, {DISPID_GLOBAL_VBCRITICAL, Global_vbCritical, BP_GET}, {DISPID_GLOBAL_VBQUESTION, Global_vbQuestion, BP_GET}, {DISPID_GLOBAL_VBEXCLAMATION, Global_vbExclamation, BP_GET},

1 0

Jacek Caban : vbscript: Allow specifying simple builtin constants without proper getter.
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: 789f295efbb1c91e58103b1c67a2c02fc788a848 URL: http://source.winehq.org/git/wine.git/?a=commit;h=789f295efbb1c91e58103b1c6… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 17 09:54:27 2012 +0200 vbscript: Allow specifying simple builtin constants without proper getter. --- dlls/vbscript/global.c | 56 ++++++------------------------------------------ dlls/vbscript/vbdisp.c | 6 +++++ 2 files changed, 13 insertions(+), 49 deletions(-) diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c index 69686f5..87d2736 100644 --- a/dlls/vbscript/global.c +++ b/dlls/vbscript/global.c @@ -1560,48 +1560,6 @@ static HRESULT Global_vbUseSystemDayOfWeek(vbdisp_t *This, VARIANT *arg, unsigne return E_NOTIMPL; } -static HRESULT Global_vbSunday(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, 1); -} - -static HRESULT Global_vbMonday(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, 2); -} - -static HRESULT Global_vbTuesday(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, 3); -} - -static HRESULT Global_vbWednesday(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, 4); -} - -static HRESULT Global_vbThursday(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, 5); -} - -static HRESULT Global_vbFriday(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, 6); -} - -static HRESULT Global_vbSaturday(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) -{ - TRACE("\n"); - return return_short(res, 7); -} - static HRESULT Global_vbFirstJan1(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) { FIXME("\n"); @@ -2061,13 +2019,13 @@ static HRESULT Global_vbMsgBoxRtlReading(vbdisp_t *This, VARIANT *arg, unsigned static const builtin_prop_t global_props[] = { {DISPID_GLOBAL_VBUSESYSTEM, Global_vbUseSystem, BP_GET}, {DISPID_GLOBAL_USESYSTEMDAYOFWEEK, Global_vbUseSystemDayOfWeek, BP_GET}, - {DISPID_GLOBAL_VBSUNDAY, Global_vbSunday, BP_GET}, - {DISPID_GLOBAL_VBMONDAY, Global_vbMonday, BP_GET}, - {DISPID_GLOBAL_VBTUESDAY, Global_vbTuesday, BP_GET}, - {DISPID_GLOBAL_VBWEDNESDAY, Global_vbWednesday, BP_GET}, - {DISPID_GLOBAL_VBTHURSDAY, Global_vbThursday, BP_GET}, - {DISPID_GLOBAL_VBFRIDAY, Global_vbFriday, BP_GET}, - {DISPID_GLOBAL_VBSATURDAY, Global_vbSaturday, BP_GET}, + {DISPID_GLOBAL_VBSUNDAY, NULL, BP_GET, 1}, + {DISPID_GLOBAL_VBMONDAY, NULL, BP_GET, 2}, + {DISPID_GLOBAL_VBTUESDAY, NULL, BP_GET, 3}, + {DISPID_GLOBAL_VBWEDNESDAY, NULL, BP_GET, 4}, + {DISPID_GLOBAL_VBTHURSDAY, NULL, BP_GET, 5}, + {DISPID_GLOBAL_VBFRIDAY, NULL, BP_GET, 6}, + {DISPID_GLOBAL_VBSATURDAY, NULL, BP_GET, 7}, {DISPID_GLOBAL_VBFIRSTJAN1, Global_vbFirstJan1, BP_GET}, {DISPID_GLOBAL_VBFIRSTFOURDAYS, Global_vbFirstFourDays, BP_GET}, {DISPID_GLOBAL_VBFIRSTFULLWEEK, Global_vbFirstFullWeek, BP_GET}, diff --git a/dlls/vbscript/vbdisp.c b/dlls/vbscript/vbdisp.c index aff9361..b37caf6 100644 --- a/dlls/vbscript/vbdisp.c +++ b/dlls/vbscript/vbdisp.c @@ -149,6 +149,12 @@ static HRESULT invoke_builtin(vbdisp_t *This, const builtin_prop_t *prop, WORD f } break; case DISPATCH_PROPERTYGET|DISPATCH_METHOD: + if(!prop->proc && prop->flags == BP_GET) { + assert((INT16)prop->min_args == prop->min_args); + V_VT(res) = VT_I2; + V_I2(res) = prop->min_args; + return S_OK; + } break; case DISPATCH_METHOD: if(prop->flags & (BP_GET|BP_GETPUT)) {

1 0

Jacek Caban : vbscript: Pass arguments to builtin functions in natural order.
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: d6d187c2b31b89f696a2e849cec461e7ee3250cc URL: http://source.winehq.org/git/wine.git/?a=commit;h=d6d187c2b31b89f696a2e849c… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Oct 17 09:54:12 2012 +0200 vbscript: Pass arguments to builtin functions in natural order. --- dlls/vbscript/global.c | 79 +++++++++++++++++++++++------------------------ dlls/vbscript/vbdisp.c | 33 +++++-------------- 2 files changed, 48 insertions(+), 64 deletions(-) diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c index 4a4dd8e..69686f5 100644 --- a/dlls/vbscript/global.c +++ b/dlls/vbscript/global.c @@ -648,16 +648,16 @@ static HRESULT Global_Left(vbdisp_t *This, VARIANT *args, unsigned args_cnt, VAR TRACE("(%s %s)\n", debugstr_variant(args+1), debugstr_variant(args)); - if(V_VT(args+1) == VT_BSTR) { - str = V_BSTR(args+1); + if(V_VT(args) == VT_BSTR) { + str = V_BSTR(args); }else { - hres = to_string(args+1, &conv_str); + hres = to_string(args, &conv_str); if(FAILED(hres)) return hres; str = conv_str; } - hres = to_int(args, &len); + hres = to_int(args+1, &len); if(FAILED(hres)) return hres; @@ -690,18 +690,18 @@ static HRESULT Global_Right(vbdisp_t *This, VARIANT *args, unsigned args_cnt, VA int len, str_len; HRESULT hres; - TRACE("(%s %s)\n", debugstr_variant(args+1), debugstr_variant(args)); + TRACE("(%s %s)\n", debugstr_variant(args), debugstr_variant(args+1)); if(V_VT(args+1) == VT_BSTR) { - str = V_BSTR(args+1); + str = V_BSTR(args); }else { - hres = to_string(args+1, &conv_str); + hres = to_string(args, &conv_str); if(FAILED(hres)) return hres; str = conv_str; } - hres = to_int(args, &len); + hres = to_int(args+1, &len); if(FAILED(hres)) return hres; @@ -734,11 +734,23 @@ static HRESULT Global_Mid(vbdisp_t *This, VARIANT *args, unsigned args_cnt, VARI BSTR str; HRESULT hres; - TRACE("\n"); + TRACE("(%s %s ...)\n", debugstr_variant(args), debugstr_variant(args+1)); - switch(args_cnt) { - case 3: - hres = to_int(args, &len); + assert(args_cnt == 2 || args_cnt == 3); + + if(V_VT(args) != VT_BSTR) { + FIXME("args[0] = %s\n", debugstr_variant(args)); + return E_NOTIMPL; + } + + str = V_BSTR(args); + + hres = to_int(args+1, &start); + if(FAILED(hres)) + return hres; + + if(args_cnt == 3) { + hres = to_int(args+2, &len); if(FAILED(hres)) return hres; @@ -746,21 +758,6 @@ static HRESULT Global_Mid(vbdisp_t *This, VARIANT *args, unsigned args_cnt, VARI FIXME("len = %d\n", len); return E_FAIL; } - /* fallthrough */ - case 2: - hres = to_int(args+args_cnt-2, &start); - if(FAILED(hres)) - return hres; - - if(V_VT(args+args_cnt-1) != VT_BSTR) { - FIXME("args[0] = %s\n", debugstr_variant(args+args_cnt-1)); - return E_NOTIMPL; - } - - str = V_BSTR(args+args_cnt-1); - break; - default: - assert(0); } @@ -987,16 +984,18 @@ static HRESULT Global_InStr(vbdisp_t *This, VARIANT *args, unsigned args_cnt, VA TRACE("\n"); + assert(2 <= args_cnt && args_cnt <= 4); + switch(args_cnt) { case 2: startv = NULL; - str1v = args+1; - str2v = args; + str1v = args; + str2v = args+1; break; case 3: - startv = args+2; + startv = args; str1v = args+1; - str2v = args; + str2v = args+2; break; case 4: FIXME("unsupported compare argument %s\n", debugstr_variant(args)); @@ -1227,7 +1226,7 @@ static HRESULT Global_InputBox(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, return E_NOTIMPL; } -static HRESULT Global_MsgBox(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) +static HRESULT Global_MsgBox(vbdisp_t *This, VARIANT *args, unsigned args_cnt, VARIANT *res) { BSTR prompt; HRESULT hres; @@ -1239,7 +1238,7 @@ static HRESULT Global_MsgBox(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VA return E_NOTIMPL; } - hres = to_string(arg, &prompt); + hres = to_string(args, &prompt); if(FAILED(hres)) return hres; @@ -1425,7 +1424,7 @@ static HRESULT Global_FormatDateTime(vbdisp_t *This, VARIANT *arg, unsigned args return E_NOTIMPL; } -static HRESULT Global_WeekdayName(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) +static HRESULT Global_WeekdayName(vbdisp_t *This, VARIANT *args, unsigned args_cnt, VARIANT *res) { int weekday, first_day = 0, abbrev = 0; BSTR ret; @@ -1435,17 +1434,17 @@ static HRESULT Global_WeekdayName(vbdisp_t *This, VARIANT *arg, unsigned args_cn assert(1 <= args_cnt && args_cnt <= 3); - hres = to_int(arg+args_cnt-1, &weekday); + hres = to_int(args, &weekday); if(FAILED(hres)) return hres; if(args_cnt > 1) { - hres = to_int(arg+args_cnt-2, &abbrev); + hres = to_int(args+1, &abbrev); if(FAILED(hres)) return hres; if(args_cnt == 3) { - hres = to_int(arg, &first_day); + hres = to_int(args+2, &first_day); if(FAILED(hres)) return hres; } @@ -1458,7 +1457,7 @@ static HRESULT Global_WeekdayName(vbdisp_t *This, VARIANT *arg, unsigned args_cn return return_bstr(res, ret); } -static HRESULT Global_MonthName(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, VARIANT *res) +static HRESULT Global_MonthName(vbdisp_t *This, VARIANT *args, unsigned args_cnt, VARIANT *res) { int month, abbrev = 0; BSTR ret; @@ -1468,12 +1467,12 @@ static HRESULT Global_MonthName(vbdisp_t *This, VARIANT *arg, unsigned args_cnt, assert(args_cnt == 1 || args_cnt == 2); - hres = to_int(arg+args_cnt-1, &month); + hres = to_int(args, &month); if(FAILED(hres)) return hres; if(args_cnt == 2) { - hres = to_int(arg, &abbrev); + hres = to_int(args+1, &abbrev); if(FAILED(hres)) return hres; } diff --git a/dlls/vbscript/vbdisp.c b/dlls/vbscript/vbdisp.c index 27c4aa3..aff9361 100644 --- a/dlls/vbscript/vbdisp.c +++ b/dlls/vbscript/vbdisp.c @@ -138,8 +138,8 @@ static HRESULT invoke_variant_prop(VARIANT *v, WORD flags, DISPPARAMS *dp, VARIA static HRESULT invoke_builtin(vbdisp_t *This, const builtin_prop_t *prop, WORD flags, DISPPARAMS *dp, VARIANT *res) { - VARIANT *args, arg_buf[8]; - unsigned argn; + VARIANT args[8]; + unsigned argn, i; switch(flags) { case DISPATCH_PROPERTYGET: @@ -176,28 +176,13 @@ static HRESULT invoke_builtin(vbdisp_t *This, const builtin_prop_t *prop, WORD f return E_FAIL; } - args = dp->rgvarg; + assert(argn < sizeof(args)/sizeof(*args)); - if(argn == 1) { - if(V_VT(dp->rgvarg) == (VT_BYREF|VT_VARIANT)) - args = V_VARIANTREF(dp->rgvarg); - }else { - unsigned i; - - assert(argn < sizeof(arg_buf)/sizeof(*arg_buf)); - - for(i=0; i < argn; i++) { - if(V_VT(dp->rgvarg+i) == (VT_BYREF|VT_VARIANT)) { - for(i=0; i < argn; i++) { - if(V_VT(dp->rgvarg+i) == (VT_BYREF|VT_VARIANT)) - arg_buf[i] = *V_VARIANTREF(dp->rgvarg+i); - else - arg_buf[i] = dp->rgvarg[i]; - } - args = arg_buf; - break; - } - } + for(i=0; i < argn; i++) { + if(V_VT(dp->rgvarg+dp->cArgs-i-1) == (VT_BYREF|VT_VARIANT)) + args[i] = *V_VARIANTREF(dp->rgvarg+dp->cArgs-i-1); + else + args[i] = dp->rgvarg[dp->cArgs-i-1]; } return prop->proc(This, args, dp->cArgs, res);

1 0

Henri Verbeet : ddraw: When restoring the display mode, use the mode set before the first mode change on any ddraw object.
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: 698ff9ba4e9eabc9792a18a2cb8835176c0b66e3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=698ff9ba4e9eabc9792a18a2c… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Oct 16 22:43:12 2012 +0200 ddraw: When restoring the display mode, use the mode set before the first mode change on any ddraw object. --- dlls/ddraw/ddraw.c | 25 +++++++++++-------------- dlls/ddraw/ddraw_private.h | 1 - 2 files changed, 11 insertions(+), 15 deletions(-) diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index 003306c..2998742 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -27,7 +27,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(ddraw); +static struct wined3d_display_mode original_mode; static const struct ddraw *exclusive_ddraw; +static BOOL restore_mode; /* Device identifier. Don't relay it to WineD3D */ static const DDDEVICEIDENTIFIER2 deviceidentifier = @@ -1064,8 +1066,8 @@ static HRESULT WINAPI ddraw7_SetDisplayMode(IDirectDraw7 *iface, DWORD width, DW return DD_OK; } - if (!ddraw->restore_mode && FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, - WINED3DADAPTER_DEFAULT, &ddraw->original_mode, NULL))) + if (!restore_mode && FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, + WINED3DADAPTER_DEFAULT, &original_mode, NULL))) ERR("Failed to get current display mode, hr %#x.\n", hr); switch (bpp) @@ -1088,7 +1090,10 @@ static HRESULT WINAPI ddraw7_SetDisplayMode(IDirectDraw7 *iface, DWORD width, DW * can't be changed if a surface is locked or some drawing is in progress. */ /* TODO: Lose the primary surface. */ if (SUCCEEDED(hr = wined3d_set_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &mode))) + { ddraw->restore_mode = TRUE; + restore_mode = TRUE; + } wined3d_mutex_unlock(); @@ -1135,17 +1140,6 @@ static HRESULT WINAPI ddraw1_SetDisplayMode(IDirectDraw *iface, DWORD width, DWO * * Restores the display mode to what it was at creation time. Basically. * - * A problem arises when there are 2 DirectDraw objects using the same hwnd: - * -> DD_1 finds the screen at 1400x1050x32 when created, sets it to 640x480x16 - * -> DD_2 is created, finds the screen at 640x480x16, sets it to 1024x768x32 - * -> DD_1 is released. The screen should be left at 1024x768x32. - * -> DD_2 is released. The screen should be set to 1400x1050x32 - * This case is unhandled right now, but Empire Earth does it this way. - * (But perhaps there is something in SetCooperativeLevel to prevent this) - * - * The msdn says that this method resets the display mode to what it was before - * SetDisplayMode was called. What if SetDisplayModes is called 2 times?? - * * Returns * DD_OK on success * DDERR_NOEXCLUSIVE mode if the device isn't in fullscreen mode @@ -1172,8 +1166,11 @@ static HRESULT WINAPI ddraw7_RestoreDisplayMode(IDirectDraw7 *iface) return DDERR_NOEXCLUSIVEMODE; } - if (SUCCEEDED(hr = wined3d_set_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &ddraw->original_mode))) + if (SUCCEEDED(hr = wined3d_set_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &original_mode))) + { ddraw->restore_mode = FALSE; + restore_mode = FALSE; + } wined3d_mutex_unlock(); diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h index b092428..f1a2a2a 100644 --- a/dlls/ddraw/ddraw_private.h +++ b/dlls/ddraw/ddraw_private.h @@ -79,7 +79,6 @@ struct ddraw /* DirectDraw things, which are not handled by WineD3D */ DWORD cooperative_level; - struct wined3d_display_mode original_mode; /* D3D things */ HWND d3d_window;

1 0

Henri Verbeet : ddraw: Only restore the display mode if we changed it.
by Alexandre Julliard 17 Oct '12

17 Oct '12

Module: wine Branch: master Commit: bc3d767fda4f1cfa2763556f106915fd39858329 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bc3d767fda4f1cfa2763556f1… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Oct 16 22:43:11 2012 +0200 ddraw: Only restore the display mode if we changed it. --- dlls/ddraw/ddraw.c | 24 ++++++++++++++---------- dlls/ddraw/ddraw_private.h | 3 ++- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index 8a554f3..003306c 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -1064,6 +1064,10 @@ static HRESULT WINAPI ddraw7_SetDisplayMode(IDirectDraw7 *iface, DWORD width, DW return DD_OK; } + if (!ddraw->restore_mode && FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, + WINED3DADAPTER_DEFAULT, &ddraw->original_mode, NULL))) + ERR("Failed to get current display mode, hr %#x.\n", hr); + switch (bpp) { case 8: format = WINED3DFMT_P8_UINT; break; @@ -1083,7 +1087,8 @@ static HRESULT WINAPI ddraw7_SetDisplayMode(IDirectDraw7 *iface, DWORD width, DW /* TODO: The possible return values from msdn suggest that the screen mode * can't be changed if a surface is locked or some drawing is in progress. */ /* TODO: Lose the primary surface. */ - hr = wined3d_set_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &mode); + if (SUCCEEDED(hr = wined3d_set_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &mode))) + ddraw->restore_mode = TRUE; wined3d_mutex_unlock(); @@ -1155,13 +1160,20 @@ static HRESULT WINAPI ddraw7_RestoreDisplayMode(IDirectDraw7 *iface) wined3d_mutex_lock(); + if (!ddraw->restore_mode) + { + wined3d_mutex_unlock(); + return DD_OK; + } + if (exclusive_ddraw && exclusive_ddraw != ddraw) { wined3d_mutex_unlock(); return DDERR_NOEXCLUSIVEMODE; } - hr = wined3d_set_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &ddraw->original_mode); + if (SUCCEEDED(hr = wined3d_set_adapter_display_mode(ddraw->wined3d, WINED3DADAPTER_DEFAULT, &ddraw->original_mode))) + ddraw->restore_mode = FALSE; wined3d_mutex_unlock(); @@ -5371,14 +5383,6 @@ HRESULT ddraw_init(struct ddraw *ddraw, enum wined3d_device_type device_type) return E_OUTOFMEMORY; } - if (FAILED(hr = wined3d_get_adapter_display_mode(ddraw->wined3d, - WINED3DADAPTER_DEFAULT, &ddraw->original_mode, NULL))) - { - ERR("Failed to get display mode, hr %#x.\n", hr); - wined3d_decref(ddraw->wined3d); - return hr; - } - hr = wined3d_device_create(ddraw->wined3d, WINED3DADAPTER_DEFAULT, device_type, NULL, 0, 8, &ddraw->device_parent, &ddraw->wined3d_device); if (FAILED(hr)) diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h index 0d15727..b092428 100644 --- a/dlls/ddraw/ddraw_private.h +++ b/dlls/ddraw/ddraw_private.h @@ -68,7 +68,8 @@ struct ddraw struct wined3d *wined3d; struct wined3d_device *wined3d_device; - BOOL d3d_initialized; + BOOL d3d_initialized; + BOOL restore_mode; struct ddraw_surface *primary; RECT primary_lock;

1 0

← Newer
1
...
42
43
44
45
46
47
48
...
96
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits October 2012