wine-commits November 2012

wine-commits@winehq.org

2 participants
708 discussions

Henri Verbeet : d3d10core/tests: Don't reuse the device.
by Alexandre Julliard 28 Nov '12

28 Nov '12

Module: wine Branch: master Commit: be65d6ab3cc6e02a338282a9f548c20e88db432a URL: http://source.winehq.org/git/wine.git/?a=commit;h=be65d6ab3cc6e02a338282a9f… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Nov 27 22:10:59 2012 +0100 d3d10core/tests: Don't reuse the device. --- dlls/d3d10core/tests/device.c | 118 +++++++++++++++++++++++++++++++--------- 1 files changed, 91 insertions(+), 27 deletions(-) diff --git a/dlls/d3d10core/tests/device.c b/dlls/d3d10core/tests/device.c index 865dde6..0dd96f1 100644 --- a/dlls/d3d10core/tests/device.c +++ b/dlls/d3d10core/tests/device.c @@ -74,11 +74,19 @@ cleanup: return device; } -static void test_device_interfaces(ID3D10Device *device) +static void test_device_interfaces(void) { + ID3D10Device *device; + ULONG refcount; IUnknown *obj; HRESULT hr; + if (!(device = create_device())) + { + skip("Failed to create device, skipping tests.\n"); + return; + } + if (SUCCEEDED(hr = ID3D10Device_QueryInterface(device, &IID_IUnknown, (void **)&obj))) IUnknown_Release(obj); ok(SUCCEEDED(hr), "ID3D10Device does not implement IUnknown\n"); @@ -94,15 +102,26 @@ static void test_device_interfaces(ID3D10Device *device) if (SUCCEEDED(hr = ID3D10Device_QueryInterface(device, &IID_ID3D10Device, (void **)&obj))) IUnknown_Release(obj); ok(SUCCEEDED(hr), "ID3D10Device does not implement ID3D10Device\n"); + + refcount = ID3D10Device_Release(device); + ok(!refcount, "Device has %u references left\n", refcount); } -static void test_create_texture2d(ID3D10Device *device) +static void test_create_texture2d(void) { D3D10_TEXTURE2D_DESC desc; ID3D10Texture2D *texture; IDXGISurface *surface; + ID3D10Device *device; + ULONG refcount; HRESULT hr; + if (!(device = create_device())) + { + skip("Failed to create device, skipping tests.\n"); + return; + } + desc.Width = 512; desc.Height = 512; desc.MipLevels = 1; @@ -154,15 +173,26 @@ static void test_create_texture2d(ID3D10Device *device) ok(FAILED(hr), "Texture should not implement IDXGISurface\n"); if (SUCCEEDED(hr)) IDXGISurface_Release(surface); ID3D10Texture2D_Release(texture); + + refcount = ID3D10Device_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); } -static void test_create_texture3d(ID3D10Device *device) +static void test_create_texture3d(void) { D3D10_TEXTURE3D_DESC desc; ID3D10Texture3D *texture; IDXGISurface *surface; + ID3D10Device *device; + ULONG refcount; HRESULT hr; + if (!(device = create_device())) + { + skip("Failed to create device, skipping tests.\n"); + return; + } + desc.Width = 64; desc.Height = 64; desc.Depth = 64; @@ -200,16 +230,27 @@ static void test_create_texture3d(ID3D10Device *device) ok(FAILED(hr), "Texture should not implement IDXGISurface.\n"); if (SUCCEEDED(hr)) IDXGISurface_Release(surface); ID3D10Texture3D_Release(texture); + + refcount = ID3D10Device_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); } -static void test_create_depthstencil_view(ID3D10Device *device) +static void test_create_depthstencil_view(void) { D3D10_DEPTH_STENCIL_VIEW_DESC dsv_desc; D3D10_TEXTURE2D_DESC texture_desc; ID3D10DepthStencilView *dsview; ID3D10Texture2D *texture; + ID3D10Device *device; + ULONG refcount; HRESULT hr; + if (!(device = create_device())) + { + skip("Failed to create device, skipping tests.\n"); + return; + } + texture_desc.Width = 512; texture_desc.Height = 512; texture_desc.MipLevels = 1; @@ -236,9 +277,12 @@ static void test_create_depthstencil_view(ID3D10Device *device) ID3D10DepthStencilView_Release(dsview); ID3D10Texture2D_Release(texture); + + refcount = ID3D10Device_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); } -static void test_create_rendertarget_view(ID3D10Device *device) +static void test_create_rendertarget_view(void) { D3D10_RENDER_TARGET_VIEW_DESC rtv_desc; D3D10_TEXTURE2D_DESC texture_desc; @@ -246,8 +290,16 @@ static void test_create_rendertarget_view(ID3D10Device *device) ID3D10RenderTargetView *rtview; ID3D10Texture2D *texture; ID3D10Buffer *buffer; + ID3D10Device *device; + ULONG refcount; HRESULT hr; + if (!(device = create_device())) + { + skip("Failed to create device, skipping tests.\n"); + return; + } + buffer_desc.ByteWidth = 1024; buffer_desc.Usage = D3D10_USAGE_DEFAULT; buffer_desc.BindFlags = D3D10_BIND_RENDER_TARGET; @@ -295,9 +347,12 @@ static void test_create_rendertarget_view(ID3D10Device *device) ID3D10RenderTargetView_Release(rtview); ID3D10Texture2D_Release(texture); + + refcount = ID3D10Device_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); } -static void test_create_shader_resource_view(ID3D10Device *device) +static void test_create_shader_resource_view(void) { D3D10_SHADER_RESOURCE_VIEW_DESC srv_desc; D3D10_TEXTURE2D_DESC texture_desc; @@ -305,8 +360,16 @@ static void test_create_shader_resource_view(ID3D10Device *device) D3D10_BUFFER_DESC buffer_desc; ID3D10Texture2D *texture; ID3D10Buffer *buffer; + ID3D10Device *device; + ULONG refcount; HRESULT hr; + if (!(device = create_device())) + { + skip("Failed to create device, skipping tests.\n"); + return; + } + buffer_desc.ByteWidth = 1024; buffer_desc.Usage = D3D10_USAGE_DEFAULT; buffer_desc.BindFlags = D3D10_BIND_SHADER_RESOURCE; @@ -358,9 +421,12 @@ static void test_create_shader_resource_view(ID3D10Device *device) ID3D10ShaderResourceView_Release(srview); ID3D10Texture2D_Release(texture); + + refcount = ID3D10Device_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); } -static void test_create_shader(ID3D10Device *device) +static void test_create_shader(void) { #if 0 float4 light; @@ -471,8 +537,16 @@ float4 main(const float4 color : COLOR) : SV_TARGET ID3D10VertexShader *vs = NULL; ID3D10PixelShader *ps = NULL; + ID3D10Device *device; + ULONG refcount; HRESULT hr; + if (!(device = create_device())) + { + skip("Failed to create device, skipping tests.\n"); + return; + } + hr = ID3D10Device_CreateVertexShader(device, vs_4_0, sizeof(vs_4_0), &vs); ok(SUCCEEDED(hr), "Failed to create SM4 vertex shader, hr %#x\n", hr); if (vs) @@ -491,28 +565,18 @@ float4 main(const float4 color : COLOR) : SV_TARGET ok(SUCCEEDED(hr), "Failed to create SM4 vertex shader, hr %#x\n", hr); if (ps) ID3D10PixelShader_Release(ps); + + refcount = ID3D10Device_Release(device); + ok(!refcount, "Device has %u references left.\n", refcount); } START_TEST(device) { - ID3D10Device *device; - ULONG refcount; - - device = create_device(); - if (!device) - { - skip("Failed to create device, skipping tests\n"); - return; - } - - test_device_interfaces(device); - test_create_texture2d(device); - test_create_texture3d(device); - test_create_depthstencil_view(device); - test_create_rendertarget_view(device); - test_create_shader_resource_view(device); - test_create_shader(device); - - refcount = ID3D10Device_Release(device); - ok(!refcount, "Device has %u references left\n", refcount); + test_device_interfaces(); + test_create_texture2d(); + test_create_texture3d(); + test_create_depthstencil_view(); + test_create_rendertarget_view(); + test_create_shader_resource_view(); + test_create_shader(); }

1 0

Henri Verbeet : d3dx9: Avoid LPD3DXPMESH.
by Alexandre Julliard 28 Nov '12

28 Nov '12

Module: wine Branch: master Commit: 35a88f5ea291fa17d69f52c50fb9d32c0fb1e148 URL: http://source.winehq.org/git/wine.git/?a=commit;h=35a88f5ea291fa17d69f52c50… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Nov 27 22:10:58 2012 +0100 d3dx9: Avoid LPD3DXPMESH. --- include/d3dx9anim.h | 2 +- include/d3dx9mesh.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/d3dx9anim.h b/include/d3dx9anim.h index 71a18f0..40bf47d 100644 --- a/include/d3dx9anim.h +++ b/include/d3dx9anim.h @@ -85,7 +85,7 @@ typedef struct _D3DXMESHDATA union { LPD3DXMESH pMesh; - LPD3DXPMESH pPMesh; + ID3DXPMesh *pPMesh; ID3DXPatchMesh *pPatchMesh; } DUMMYUNIONNAME; } D3DXMESHDATA, *LPD3DXMESHDATA; diff --git a/include/d3dx9mesh.h b/include/d3dx9mesh.h index 9b68a94..f5bbd7f 100644 --- a/include/d3dx9mesh.h +++ b/include/d3dx9mesh.h @@ -783,7 +783,9 @@ HRESULT WINAPI D3DXConvertMeshSubsetToStrips(struct ID3DXBaseMesh *mesh_in, DWOR HRESULT WINAPI D3DXDeclaratorFromFVF(DWORD, D3DVERTEXELEMENT9[MAX_FVF_DECL_SIZE]); HRESULT WINAPI D3DXFVFFromDeclarator(const D3DVERTEXELEMENT9 *decl, DWORD *fvf); HRESULT WINAPI D3DXGenerateOutputDecl(D3DVERTEXELEMENT9 *, CONST D3DVERTEXELEMENT9 *); -HRESULT WINAPI D3DXGeneratePMesh(LPD3DXMESH, CONST DWORD *, CONST D3DXATTRIBUTEWEIGHTS *, CONST FLOAT *, DWORD, DWORD, LPD3DXPMESH *); +HRESULT WINAPI D3DXGeneratePMesh(ID3DXMesh *mesh, const DWORD *adjacency, + const D3DXATTRIBUTEWEIGHTS *attribute_weights, const float *vertex_weights, + DWORD min_value, DWORD flags, ID3DXPMesh **pmesh); HRESULT WINAPI D3DXIntersect(LPD3DXBASEMESH, CONST D3DXVECTOR3 *, CONST D3DXVECTOR3 *, BOOL *, DWORD *, FLOAT *, FLOAT *, FLOAT *, LPD3DXBUFFER *, DWORD *); HRESULT WINAPI D3DXIntersectSubset(LPD3DXBASEMESH, DWORD, CONST D3DXVECTOR3 *, CONST D3DXVECTOR3 *, BOOL *, DWORD *, FLOAT *, FLOAT *, FLOAT *, LPD3DXBUFFER *, DWORD *); BOOL WINAPI D3DXIntersectTri(CONST D3DXVECTOR3 *, CONST D3DXVECTOR3 *, CONST D3DXVECTOR3 *, CONST D3DXVECTOR3 *, CONST D3DXVECTOR3*, FLOAT *, FLOAT *, FLOAT *);

1 0

Henri Verbeet : d3dx9: Avoid LPD3DXSPMESH.
by Alexandre Julliard 28 Nov '12

28 Nov '12

Module: wine Branch: master Commit: 181d4a229696d751aada1ec499243f819930505d URL: http://source.winehq.org/git/wine.git/?a=commit;h=181d4a229696d751aada1ec49… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Nov 27 22:10:57 2012 +0100 d3dx9: Avoid LPD3DXSPMESH. --- include/d3dx9mesh.h | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/d3dx9mesh.h b/include/d3dx9mesh.h index 5545568..9b68a94 100644 --- a/include/d3dx9mesh.h +++ b/include/d3dx9mesh.h @@ -696,7 +696,8 @@ HRESULT WINAPI D3DXCreateMesh(DWORD face_count, DWORD vertex_count, DWORD flags, HRESULT WINAPI D3DXCreateMeshFVF(DWORD face_count, DWORD vertex_count, DWORD flags, DWORD fvf, struct IDirect3DDevice9 *device, struct ID3DXMesh **mesh); HRESULT WINAPI D3DXCreateBuffer(DWORD, LPD3DXBUFFER*); -HRESULT WINAPI D3DXCreateSPMesh(LPD3DXMESH, CONST DWORD *, CONST D3DXATTRIBUTEWEIGHTS, CONST FLOAT *, LPD3DXSPMESH *); +HRESULT WINAPI D3DXCreateSPMesh(ID3DXMesh *mesh, const DWORD *adjacency, + const D3DXATTRIBUTEWEIGHTS *attribute_weights, const float *vertex_weights, ID3DXSPMesh **spmesh); HRESULT WINAPI D3DXCreatePMeshFromStream(struct IStream *stream, DWORD flags, struct IDirect3DDevice9 *device, struct ID3DXBuffer **materials, struct ID3DXBuffer **effect_instances, DWORD *material_count, struct ID3DXPMesh **mesh);

1 0

Henri Verbeet : d3dx9: Avoid LPD3DXSKININFO.
by Alexandre Julliard 28 Nov '12

28 Nov '12

Module: wine Branch: master Commit: 361cf636cc6d2a4cb7c382f70887ff62aa9337b2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=361cf636cc6d2a4cb7c382f70… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Nov 27 22:10:56 2012 +0100 d3dx9: Avoid LPD3DXSKININFO. --- dlls/d3dx9_36/skin.c | 8 ++++---- dlls/d3dx9_36/tests/mesh.c | 6 +++--- include/d3dx9anim.h | 10 +++++----- include/d3dx9mesh.h | 10 ++++++---- 4 files changed, 18 insertions(+), 16 deletions(-) diff --git a/dlls/d3dx9_36/skin.c b/dlls/d3dx9_36/skin.c index 8ef7fbe..2c4ab60 100644 --- a/dlls/d3dx9_36/skin.c +++ b/dlls/d3dx9_36/skin.c @@ -297,7 +297,7 @@ static LPD3DXMATRIX WINAPI ID3DXSkinInfoImpl_GetBoneOffsetMatrix(ID3DXSkinInfo * return &This->bones[bone_num].transform; } -static HRESULT WINAPI ID3DXSkinInfoImpl_Clone(ID3DXSkinInfo *iface, LPD3DXSKININFO *skin_info) +static HRESULT WINAPI ID3DXSkinInfoImpl_Clone(ID3DXSkinInfo *iface, ID3DXSkinInfo **skin_info) { ID3DXSkinInfoImpl *This = impl_from_ID3DXSkinInfo(iface); @@ -449,8 +449,8 @@ static const struct ID3DXSkinInfoVtbl ID3DXSkinInfoImpl_Vtbl = ID3DXSkinInfoImpl_ConvertToIndexedBlendedMesh }; -HRESULT WINAPI D3DXCreateSkinInfo(DWORD num_vertices, CONST D3DVERTEXELEMENT9 *declaration, - DWORD num_bones, LPD3DXSKININFO *skin_info) +HRESULT WINAPI D3DXCreateSkinInfo(DWORD num_vertices, const D3DVERTEXELEMENT9 *declaration, + DWORD num_bones, ID3DXSkinInfo **skin_info) { HRESULT hr; ID3DXSkinInfoImpl *object = NULL; @@ -490,7 +490,7 @@ error: return hr; } -HRESULT WINAPI D3DXCreateSkinInfoFVF(DWORD num_vertices, DWORD fvf, DWORD num_bones, LPD3DXSKININFO *skin_info) +HRESULT WINAPI D3DXCreateSkinInfoFVF(DWORD num_vertices, DWORD fvf, DWORD num_bones, ID3DXSkinInfo **skin_info) { HRESULT hr; D3DVERTEXELEMENT9 declaration[MAX_FVF_DECL_SIZE]; diff --git a/dlls/d3dx9_36/tests/mesh.c b/dlls/d3dx9_36/tests/mesh.c index 97d7e2d..35e38e4 100644 --- a/dlls/d3dx9_36/tests/mesh.c +++ b/dlls/d3dx9_36/tests/mesh.c @@ -1859,9 +1859,9 @@ static CALLBACK HRESULT ID3DXAllocateHierarchyImpl_DestroyMeshContainer(ID3DXAll } static CALLBACK HRESULT ID3DXAllocateHierarchyImpl_CreateMeshContainer(ID3DXAllocateHierarchy *iface, - LPCSTR name, CONST D3DXMESHDATA *mesh_data, CONST D3DXMATERIAL *materials, - CONST D3DXEFFECTINSTANCE *effects, DWORD num_materials, CONST DWORD *adjacency, - LPD3DXSKININFO skin_info, LPD3DXMESHCONTAINER *new_mesh_container) + const char *name, const D3DXMESHDATA *mesh_data, const D3DXMATERIAL *materials, + const D3DXEFFECTINSTANCE *effects, DWORD num_materials, const DWORD *adjacency, + ID3DXSkinInfo *skin_info, D3DXMESHCONTAINER **new_mesh_container) { LPD3DXMESHCONTAINER mesh_container = NULL; int i; diff --git a/include/d3dx9anim.h b/include/d3dx9anim.h index 62fa6c0..71a18f0 100644 --- a/include/d3dx9anim.h +++ b/include/d3dx9anim.h @@ -98,7 +98,7 @@ typedef struct _D3DXMESHCONTAINER LPD3DXEFFECTINSTANCE pEffects; DWORD NumMaterials; DWORD *pAdjacency; - LPD3DXSKININFO pSkinInfo; + ID3DXSkinInfo *pSkinInfo; struct _D3DXMESHCONTAINER *pNextMeshContainer; } D3DXMESHCONTAINER, *LPD3DXMESHCONTAINER; @@ -171,10 +171,10 @@ typedef interface ID3DXAnimationController *LPD3DXANIMATIONCONTROLLER; DECLARE_INTERFACE(ID3DXAllocateHierarchy) { STDMETHOD(CreateFrame)(THIS_ LPCSTR Name, LPD3DXFRAME *new_frame) PURE; - STDMETHOD(CreateMeshContainer)(THIS_ LPCSTR Name, CONST D3DXMESHDATA *mesh_data, - CONST D3DXMATERIAL *materials, CONST D3DXEFFECTINSTANCE *effect_instances, - DWORD num_materials, CONST DWORD *adjacency, LPD3DXSKININFO skin_info, - LPD3DXMESHCONTAINER *new_mesh_container) PURE; + STDMETHOD(CreateMeshContainer)(THIS_ const char *name, const D3DXMESHDATA *mesh_data, + const D3DXMATERIAL *materials, const D3DXEFFECTINSTANCE *effect_instances, + DWORD num_materials, const DWORD *adjacency, ID3DXSkinInfo *skin_info, + D3DXMESHCONTAINER **new_mesh_container) PURE; STDMETHOD(DestroyFrame)(THIS_ LPD3DXFRAME frame) PURE; STDMETHOD(DestroyMeshContainer)(THIS_ LPD3DXMESHCONTAINER mesh_container) PURE; }; diff --git a/include/d3dx9mesh.h b/include/d3dx9mesh.h index 3a26b54..5545568 100644 --- a/include/d3dx9mesh.h +++ b/include/d3dx9mesh.h @@ -529,7 +529,7 @@ DECLARE_INTERFACE_(ID3DXSkinInfo, IUnknown) STDMETHOD_(LPCSTR, GetBoneName)(THIS_ DWORD bone) PURE; STDMETHOD(SetBoneOffsetMatrix)(THIS_ DWORD bone, CONST D3DXMATRIX* bone_transform) PURE; STDMETHOD_(LPD3DXMATRIX, GetBoneOffsetMatrix)(THIS_ DWORD bone) PURE; - STDMETHOD(Clone)(THIS_ LPD3DXSKININFO* skin_info) PURE; + STDMETHOD(Clone)(THIS_ ID3DXSkinInfo **skin_info) PURE; STDMETHOD(Remap)(THIS_ DWORD num_vertices, DWORD* vertex_remap) PURE; STDMETHOD(SetFVF)(THIS_ DWORD FVF) PURE; STDMETHOD(SetDeclaration)(THIS_ CONST D3DVERTEXELEMENT9* declaration) PURE; @@ -700,9 +700,11 @@ HRESULT WINAPI D3DXCreateSPMesh(LPD3DXMESH, CONST DWORD *, CONST D3DXATTRIBUTEWE HRESULT WINAPI D3DXCreatePMeshFromStream(struct IStream *stream, DWORD flags, struct IDirect3DDevice9 *device, struct ID3DXBuffer **materials, struct ID3DXBuffer **effect_instances, DWORD *material_count, struct ID3DXPMesh **mesh); -HRESULT WINAPI D3DXCreateSkinInfo(DWORD, CONST D3DVERTEXELEMENT9 *, DWORD, LPD3DXSKININFO *); -HRESULT WINAPI D3DXCreateSkinInfoFVF(DWORD, DWORD, DWORD, LPD3DXSKININFO *); -HRESULT WINAPI D3DXCreateSkinInfoFromBlendedMesh(LPD3DXBASEMESH, DWORD, CONST D3DXBONECOMBINATION *, LPD3DXSKININFO *); +HRESULT WINAPI D3DXCreateSkinInfo(DWORD vertex_count, const D3DVERTEXELEMENT9 *declaration, + DWORD bone_count, ID3DXSkinInfo **skin_info); +HRESULT WINAPI D3DXCreateSkinInfoFVF(DWORD vertex_count, DWORD fvf, DWORD bone_count, ID3DXSkinInfo **skin_info); +HRESULT WINAPI D3DXCreateSkinInfoFromBlendedMesh(ID3DXBaseMesh *mesh, DWORD bone_count, + const D3DXBONECOMBINATION *bone_combination_table, ID3DXSkinInfo **skin_info); HRESULT WINAPI D3DXCreatePatchMesh(const D3DXPATCHINFO *patch_info, DWORD patch_count, DWORD vertex_count, DWORD flags, const D3DVERTEXELEMENT9 *declaration, struct IDirect3DDevice9 *device, struct ID3DXPatchMesh **mesh);

1 0

Aric Stewart : user32: More instances where early versions of usp10 are not well behaved with ScriptString_pSize being NULL .
by Alexandre Julliard 28 Nov '12

28 Nov '12

Module: wine Branch: master Commit: bd7e8df6ba2d7984043ad9aaf50e966d05395ff2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bd7e8df6ba2d7984043ad9aaf… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Nov 27 14:31:46 2012 -0600 user32: More instances where early versions of usp10 are not well behaved with ScriptString_pSize being NULL. Issue discovered by Qian Hong. --- dlls/user32/edit.c | 13 ++++++++++--- 1 files changed, 10 insertions(+), 3 deletions(-) diff --git a/dlls/user32/edit.c b/dlls/user32/edit.c index f5d4e65..c143aa6 100644 --- a/dlls/user32/edit.c +++ b/dlls/user32/edit.c @@ -640,7 +640,9 @@ static void EDIT_BuildLineDefs_ML(EDITSTATE *es, INT istart, INT iend, INT delta current_line->net_length = prev; EDIT_InvalidateUniscribeData_linedef(current_line); EDIT_UpdateUniscribeData_linedef(es, NULL, current_line); - sz = ScriptString_pSize(current_line->ssa); + if (current_line->ssa) + sz = ScriptString_pSize(current_line->ssa); + else sz = 0; if (sz) current_line->width = sz->cx; else @@ -697,8 +699,13 @@ static void EDIT_BuildLineDefs_ML(EDITSTATE *es, INT istart, INT iend, INT delta if (current_line->net_length > 0) { EDIT_UpdateUniscribeData_linedef(es, NULL, current_line); - sz = ScriptString_pSize(current_line->ssa); - current_line->width = sz->cx; + if (current_line->ssa) + { + sz = ScriptString_pSize(current_line->ssa); + current_line->width = sz->cx; + } + else + current_line->width = 0; } else current_line->width = 0; }

1 0

Vincent Povirk : gdiplus: Use clipping region in alpha_blend_pixels.
by Alexandre Julliard 28 Nov '12

28 Nov '12

Module: wine Branch: master Commit: 423d50eb3b4edd3140880ed2ccbe9d6ca665dcb5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=423d50eb3b4edd3140880ed2c… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Nov 27 13:42:07 2012 -0600 gdiplus: Use clipping region in alpha_blend_pixels. --- dlls/gdiplus/graphics.c | 163 +++++++++++++++++++++++++++++----------------- 1 files changed, 103 insertions(+), 60 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index f56682b..247b17d 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -359,68 +359,67 @@ static void gdi_alpha_blend(GpGraphics *graphics, INT dst_x, INT dst_y, INT dst_ } } +static GpStatus get_clip_hrgn(GpGraphics *graphics, HRGN *hrgn) +{ + return GdipGetRegionHRgn(graphics->clip, graphics, hrgn); +} + /* Draw non-premultiplied ARGB data to the given graphics object */ -static GpStatus alpha_blend_pixels(GpGraphics *graphics, INT dst_x, INT dst_y, +static GpStatus alpha_blend_bmp_pixels(GpGraphics *graphics, INT dst_x, INT dst_y, const BYTE *src, INT src_width, INT src_height, INT src_stride) { - if (graphics->image && graphics->image->type == ImageTypeBitmap) - { - GpBitmap *dst_bitmap = (GpBitmap*)graphics->image; - INT x, y; + GpBitmap *dst_bitmap = (GpBitmap*)graphics->image; + INT x, y; - for (x=0; x<src_width; x++) + for (x=0; x<src_width; x++) + { + for (y=0; y<src_height; y++) { - for (y=0; y<src_height; y++) - { - ARGB dst_color, src_color; - GdipBitmapGetPixel(dst_bitmap, x+dst_x, y+dst_y, &dst_color); - src_color = ((ARGB*)(src + src_stride * y))[x]; - GdipBitmapSetPixel(dst_bitmap, x+dst_x, y+dst_y, color_over(dst_color, src_color)); - } + ARGB dst_color, src_color; + GdipBitmapGetPixel(dst_bitmap, x+dst_x, y+dst_y, &dst_color); + src_color = ((ARGB*)(src + src_stride * y))[x]; + GdipBitmapSetPixel(dst_bitmap, x+dst_x, y+dst_y, color_over(dst_color, src_color)); } - - return Ok; - } - else if (graphics->image && graphics->image->type == ImageTypeMetafile) - { - ERR("This should not be used for metafiles; fix caller\n"); - return NotImplemented; } - else - { - HDC hdc; - HBITMAP hbitmap; - BITMAPINFOHEADER bih; - BYTE *temp_bits; - - hdc = CreateCompatibleDC(0); - - bih.biSize = sizeof(BITMAPINFOHEADER); - bih.biWidth = src_width; - bih.biHeight = -src_height; - bih.biPlanes = 1; - bih.biBitCount = 32; - bih.biCompression = BI_RGB; - bih.biSizeImage = 0; - bih.biXPelsPerMeter = 0; - bih.biYPelsPerMeter = 0; - bih.biClrUsed = 0; - bih.biClrImportant = 0; - - hbitmap = CreateDIBSection(hdc, (BITMAPINFO*)&bih, DIB_RGB_COLORS, - (void**)&temp_bits, NULL, 0); - - convert_32bppARGB_to_32bppPARGB(src_width, src_height, temp_bits, - 4 * src_width, src, src_stride); - - SelectObject(hdc, hbitmap); - gdi_alpha_blend(graphics, dst_x, dst_y, src_width, src_height, - hdc, 0, 0, src_width, src_height); - DeleteDC(hdc); - DeleteObject(hbitmap); - return Ok; - } + return Ok; +} + +static GpStatus alpha_blend_hdc_pixels(GpGraphics *graphics, INT dst_x, INT dst_y, + const BYTE *src, INT src_width, INT src_height, INT src_stride) +{ + HDC hdc; + HBITMAP hbitmap; + BITMAPINFOHEADER bih; + BYTE *temp_bits; + + hdc = CreateCompatibleDC(0); + + bih.biSize = sizeof(BITMAPINFOHEADER); + bih.biWidth = src_width; + bih.biHeight = -src_height; + bih.biPlanes = 1; + bih.biBitCount = 32; + bih.biCompression = BI_RGB; + bih.biSizeImage = 0; + bih.biXPelsPerMeter = 0; + bih.biYPelsPerMeter = 0; + bih.biClrUsed = 0; + bih.biClrImportant = 0; + + hbitmap = CreateDIBSection(hdc, (BITMAPINFO*)&bih, DIB_RGB_COLORS, + (void**)&temp_bits, NULL, 0); + + convert_32bppARGB_to_32bppPARGB(src_width, src_height, temp_bits, + 4 * src_width, src, src_stride); + + SelectObject(hdc, hbitmap); + gdi_alpha_blend(graphics, dst_x, dst_y, src_width, src_height, + hdc, 0, 0, src_width, src_height); + DeleteDC(hdc); + DeleteObject(hbitmap); + + return Ok; } static GpStatus alpha_blend_pixels_hrgn(GpGraphics *graphics, INT dst_x, INT dst_y, @@ -433,20 +432,44 @@ static GpStatus alpha_blend_pixels_hrgn(GpGraphics *graphics, INT dst_x, INT dst int i, size; RGNDATA *rgndata; RECT *rects; + HRGN hrgn, visible_rgn; + + hrgn = CreateRectRgn(dst_x, dst_y, dst_x + src_width, dst_y + src_height); + if (!hrgn) + return OutOfMemory; + + stat = get_clip_hrgn(graphics, &visible_rgn); + if (stat != Ok) + { + DeleteObject(hrgn); + return stat; + } + + if (visible_rgn) + { + CombineRgn(hrgn, hrgn, visible_rgn, RGN_AND); + DeleteObject(visible_rgn); + } - size = GetRegionData(hregion, 0, NULL); + if (hregion) + CombineRgn(hrgn, hrgn, hregion, RGN_AND); + + size = GetRegionData(hrgn, 0, NULL); rgndata = GdipAlloc(size); if (!rgndata) + { + DeleteObject(hrgn); return OutOfMemory; + } - GetRegionData(hregion, size, rgndata); + GetRegionData(hrgn, size, rgndata); rects = (RECT*)&rgndata->Buffer; for (i=0; stat == Ok && i<rgndata->rdh.nCount; i++) { - stat = alpha_blend_pixels(graphics, rects[i].left, rects[i].top, + stat = alpha_blend_bmp_pixels(graphics, rects[i].left, rects[i].top, &src[(rects[i].left - dst_x) * 4 + (rects[i].top - dst_y) * src_stride], rects[i].right - rects[i].left, rects[i].bottom - rects[i].top, src_stride); @@ -454,6 +477,8 @@ static GpStatus alpha_blend_pixels_hrgn(GpGraphics *graphics, INT dst_x, INT dst GdipFree(rgndata); + DeleteObject(hrgn); + return stat; } else if (graphics->image && graphics->image->type == ImageTypeMetafile) @@ -463,21 +488,39 @@ static GpStatus alpha_blend_pixels_hrgn(GpGraphics *graphics, INT dst_x, INT dst } else { + HRGN hrgn; int save; + stat = get_clip_hrgn(graphics, &hrgn); + + if (stat != Ok) + return stat; + save = SaveDC(graphics->hdc); - ExtSelectClipRgn(graphics->hdc, hregion, RGN_AND); + if (hrgn) + ExtSelectClipRgn(graphics->hdc, hrgn, RGN_AND); - stat = alpha_blend_pixels(graphics, dst_x, dst_y, src, src_width, + if (hregion) + ExtSelectClipRgn(graphics->hdc, hregion, RGN_AND); + + stat = alpha_blend_hdc_pixels(graphics, dst_x, dst_y, src, src_width, src_height, src_stride); RestoreDC(graphics->hdc, save); + DeleteObject(hrgn); + return stat; } } +static GpStatus alpha_blend_pixels(GpGraphics *graphics, INT dst_x, INT dst_y, + const BYTE *src, INT src_width, INT src_height, INT src_stride) +{ + return alpha_blend_pixels_hrgn(graphics, dst_x, dst_y, src, src_width, src_height, src_stride, NULL); +} + static ARGB blend_colors(ARGB start, ARGB end, REAL position) { ARGB result=0;

1 0

Alexandre Julliard : winex11: Don' t bother waiting for XShmPutImage to finish.
by Alexandre Julliard 28 Nov '12

28 Nov '12

Module: wine Branch: master Commit: e2da590a8550292182b96562cd20f11cfe94ce2b URL: http://source.winehq.org/git/wine.git/?a=commit;h=e2da590a8550292182b96562c… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Nov 28 14:40:13 2012 +0100 winex11: Don't bother waiting for XShmPutImage to finish. --- dlls/winex11.drv/bitblt.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/dlls/winex11.drv/bitblt.c b/dlls/winex11.drv/bitblt.c index 17ebde7..23837de 100644 --- a/dlls/winex11.drv/bitblt.c +++ b/dlls/winex11.drv/bitblt.c @@ -1910,15 +1910,12 @@ static void x11drv_surface_flush( struct window_surface *window_surface ) #ifdef HAVE_LIBXXSHM if (surface->shminfo.shmid != -1) - { XShmPutImage( gdi_display, surface->window, surface->gc, surface->image, coords.visrect.left, coords.visrect.top, surface->header.rect.left + coords.visrect.left, surface->header.rect.top + coords.visrect.top, coords.visrect.right - coords.visrect.left, coords.visrect.bottom - coords.visrect.top, False ); - XSync( gdi_display, False ); - } else #endif XPutImage( gdi_display, surface->window, surface->gc, surface->image,

1 0

Alexandre Julliard : gdi32: Add a font glyph cache in the DIB engine.
by Alexandre Julliard 28 Nov '12

28 Nov '12

Module: wine Branch: master Commit: 6050a025bb15fe7d91b9086fad04e83de6177b9f URL: http://source.winehq.org/git/wine.git/?a=commit;h=6050a025bb15fe7d91b9086fa… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 27 23:19:29 2012 +0100 gdi32: Add a font glyph cache in the DIB engine. --- dlls/gdi32/dibdrv/dc.c | 1 + dlls/gdi32/dibdrv/dibdrv.h | 3 + dlls/gdi32/dibdrv/graphics.c | 282 +++++++++++++++++++++++++++++++++--------- 3 files changed, 226 insertions(+), 60 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=6050a025bb15fe7d91b90…

1 0

Christian Costa : quartz: Fix case in some methods name.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 0c0b229717b94b08bf80186fe67e338dd55c96e2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0c0b229717b94b08bf80186fe… Author: Christian Costa <titan.costa(a)gmail.com> Date: Tue Nov 27 09:15:08 2012 +0100 quartz: Fix case in some methods name. --- dlls/quartz/videorenderer.c | 42 ++++++++++++++++++++++++------------------ 1 files changed, 24 insertions(+), 18 deletions(-) diff --git a/dlls/quartz/videorenderer.c b/dlls/quartz/videorenderer.c index a7f0a59..9afa7bf 100644 --- a/dlls/quartz/videorenderer.c +++ b/dlls/quartz/videorenderer.c @@ -796,7 +796,7 @@ static const IBaseFilterVtbl VideoRenderer_Vtbl = }; /*** IUnknown methods ***/ -static HRESULT WINAPI Basicvideo_QueryInterface(IBasicVideo *iface, REFIID riid, LPVOID *ppvObj) +static HRESULT WINAPI BasicVideo_QueryInterface(IBasicVideo *iface, REFIID riid, LPVOID *ppvObj) { VideoRendererImpl *This = impl_from_IBasicVideo(iface); @@ -805,7 +805,8 @@ static HRESULT WINAPI Basicvideo_QueryInterface(IBasicVideo *iface, REFIID riid, return IUnknown_QueryInterface(This->outer_unk, riid, ppvObj); } -static ULONG WINAPI Basicvideo_AddRef(IBasicVideo *iface) { +static ULONG WINAPI BasicVideo_AddRef(IBasicVideo *iface) +{ VideoRendererImpl *This = impl_from_IBasicVideo(iface); TRACE("(%p/%p)->()\n", This, iface); @@ -813,7 +814,8 @@ static ULONG WINAPI Basicvideo_AddRef(IBasicVideo *iface) { return IUnknown_AddRef(This->outer_unk); } -static ULONG WINAPI Basicvideo_Release(IBasicVideo *iface) { +static ULONG WINAPI BasicVideo_Release(IBasicVideo *iface) +{ VideoRendererImpl *This = impl_from_IBasicVideo(iface); TRACE("(%p/%p)->()\n", This, iface); @@ -823,9 +825,9 @@ static ULONG WINAPI Basicvideo_Release(IBasicVideo *iface) { static const IBasicVideoVtbl IBasicVideo_VTable = { - Basicvideo_QueryInterface, - Basicvideo_AddRef, - Basicvideo_Release, + BasicVideo_QueryInterface, + BasicVideo_AddRef, + BasicVideo_Release, BaseControlVideoImpl_GetTypeInfoCount, BaseControlVideoImpl_GetTypeInfo, BaseControlVideoImpl_GetIDsOfNames, @@ -866,7 +868,7 @@ static const IBasicVideoVtbl IBasicVideo_VTable = /*** IUnknown methods ***/ -static HRESULT WINAPI Videowindow_QueryInterface(IVideoWindow *iface, REFIID riid, LPVOID *ppvObj) +static HRESULT WINAPI VideoWindow_QueryInterface(IVideoWindow *iface, REFIID riid, LPVOID *ppvObj) { VideoRendererImpl *This = impl_from_IVideoWindow(iface); @@ -875,7 +877,8 @@ static HRESULT WINAPI Videowindow_QueryInterface(IVideoWindow *iface, REFIID rii return IUnknown_QueryInterface(This->outer_unk, riid, ppvObj); } -static ULONG WINAPI Videowindow_AddRef(IVideoWindow *iface) { +static ULONG WINAPI VideoWindow_AddRef(IVideoWindow *iface) +{ VideoRendererImpl *This = impl_from_IVideoWindow(iface); TRACE("(%p/%p)->()\n", This, iface); @@ -883,7 +886,8 @@ static ULONG WINAPI Videowindow_AddRef(IVideoWindow *iface) { return IUnknown_AddRef(This->outer_unk); } -static ULONG WINAPI Videowindow_Release(IVideoWindow *iface) { +static ULONG WINAPI VideoWindow_Release(IVideoWindow *iface) +{ VideoRendererImpl *This = impl_from_IVideoWindow(iface); TRACE("(%p/%p)->()\n", This, iface); @@ -891,8 +895,9 @@ static ULONG WINAPI Videowindow_Release(IVideoWindow *iface) { return IUnknown_Release(This->outer_unk); } -static HRESULT WINAPI Videowindow_get_FullScreenMode(IVideoWindow *iface, - LONG *FullScreenMode) { +static HRESULT WINAPI VideoWindow_get_FullScreenMode(IVideoWindow *iface, + LONG *FullScreenMode) +{ VideoRendererImpl *This = impl_from_IVideoWindow(iface); FIXME("(%p/%p)->(%p): stub !!!\n", This, iface, FullScreenMode); @@ -900,8 +905,9 @@ static HRESULT WINAPI Videowindow_get_FullScreenMode(IVideoWindow *iface, return S_OK; } -static HRESULT WINAPI Videowindow_put_FullScreenMode(IVideoWindow *iface, - LONG FullScreenMode) { +static HRESULT WINAPI VideoWindow_put_FullScreenMode(IVideoWindow *iface, + LONG FullScreenMode) +{ VideoRendererImpl *This = impl_from_IVideoWindow(iface); FIXME("(%p/%p)->(%d): stub !!!\n", This, iface, FullScreenMode); @@ -928,9 +934,9 @@ static HRESULT WINAPI Videowindow_put_FullScreenMode(IVideoWindow *iface, static const IVideoWindowVtbl IVideoWindow_VTable = { - Videowindow_QueryInterface, - Videowindow_AddRef, - Videowindow_Release, + VideoWindow_QueryInterface, + VideoWindow_AddRef, + VideoWindow_Release, BaseControlWindowImpl_GetTypeInfoCount, BaseControlWindowImpl_GetTypeInfo, BaseControlWindowImpl_GetIDsOfNames, @@ -963,8 +969,8 @@ static const IVideoWindowVtbl IVideoWindow_VTable = BaseControlWindowImpl_get_MessageDrain, BaseControlWindowImpl_get_BorderColor, BaseControlWindowImpl_put_BorderColor, - Videowindow_get_FullScreenMode, - Videowindow_put_FullScreenMode, + VideoWindow_get_FullScreenMode, + VideoWindow_put_FullScreenMode, BaseControlWindowImpl_SetWindowForeground, BaseControlWindowImpl_NotifyOwnerMessage, BaseControlWindowImpl_SetWindowPosition,

1 0

Christian Costa : amstream: Fix return value of BasePinImp_GetMediaType.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: eca0bc35656fef9f0e9179cfe5fec3074d8cbe9a URL: http://source.winehq.org/git/wine.git/?a=commit;h=eca0bc35656fef9f0e9179cfe… Author: Christian Costa <titan.costa(a)gmail.com> Date: Tue Nov 27 09:14:13 2012 +0100 amstream: Fix return value of BasePinImp_GetMediaType. --- dlls/amstream/mediastreamfilter.c | 13 ++++++------- 1 files changed, 6 insertions(+), 7 deletions(-) diff --git a/dlls/amstream/mediastreamfilter.c b/dlls/amstream/mediastreamfilter.c index 3c0777c..afd080a 100644 --- a/dlls/amstream/mediastreamfilter.c +++ b/dlls/amstream/mediastreamfilter.c @@ -181,15 +181,14 @@ static HRESULT WINAPI BasePinImp_GetMediaType(BasePin *This, int index, AM_MEDIA } else if (IsEqualGUID(&purpose_id, &MSPID_PrimaryAudio)) { - if (!index) - { - amt->majortype = MEDIATYPE_Audio; - amt->subtype = MEDIASUBTYPE_PCM; - return S_OK; - } + if (index) + return S_FALSE; + + amt->majortype = MEDIATYPE_Audio; + amt->subtype = MEDIASUBTYPE_PCM; } - return S_FALSE; + return S_OK; } static const BasePinFuncTable input_BaseFuncTable = {

1 0

Alexandre Julliard : user32: Fix handling of NULL paint struct in BeginPaint.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: ab2cac4815e0ef4dbacea2708b121a22180438c3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab2cac4815e0ef4dbacea2708… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Nov 27 20:52:25 2012 +0100 user32: Fix handling of NULL paint struct in BeginPaint. --- dlls/user32/painting.c | 24 ++++++++++++++++-------- dlls/user32/tests/msg.c | 20 ++++++++++++++++++++ 2 files changed, 36 insertions(+), 8 deletions(-) diff --git a/dlls/user32/painting.c b/dlls/user32/painting.c index b2ddfe6..a6fb23f 100644 --- a/dlls/user32/painting.c +++ b/dlls/user32/painting.c @@ -893,20 +893,28 @@ static HWND fix_caret(HWND hWnd, const RECT *scroll_rect, INT dx, INT dy, HDC WINAPI BeginPaint( HWND hwnd, PAINTSTRUCT *lps ) { HRGN hrgn; + HDC hdc; + BOOL erase; + RECT rect; UINT flags = UPDATE_NONCLIENT | UPDATE_ERASE | UPDATE_PAINT | UPDATE_INTERNALPAINT | UPDATE_NOCHILDREN; - if (!lps) return 0; - HideCaret( hwnd ); if (!(hrgn = send_ncpaint( hwnd, NULL, &flags ))) return 0; - lps->fErase = send_erase( hwnd, flags, hrgn, &lps->rcPaint, &lps->hdc ); + erase = send_erase( hwnd, flags, hrgn, &rect, &hdc ); - TRACE("hdc = %p box = (%s), fErase = %d\n", - lps->hdc, wine_dbgstr_rect(&lps->rcPaint), lps->fErase); + TRACE("hdc = %p box = (%s), fErase = %d\n", hdc, wine_dbgstr_rect(&rect), erase); - return lps->hdc; + if (!lps) + { + release_dc( hwnd, hdc, TRUE ); + return 0; + } + lps->fErase = erase; + lps->rcPaint = rect; + lps->hdc = hdc; + return hdc; } @@ -915,10 +923,10 @@ HDC WINAPI BeginPaint( HWND hwnd, PAINTSTRUCT *lps ) */ BOOL WINAPI EndPaint( HWND hwnd, const PAINTSTRUCT *lps ) { - if (!lps) return FALSE; - release_dc( hwnd, lps->hdc, TRUE ); ShowCaret( hwnd ); flush_window_surfaces( FALSE ); + if (!lps) return FALSE; + release_dc( hwnd, lps->hdc, TRUE ); return TRUE; } diff --git a/dlls/user32/tests/msg.c b/dlls/user32/tests/msg.c index 9816f13..ac3ba16 100644 --- a/dlls/user32/tests/msg.c +++ b/dlls/user32/tests/msg.c @@ -9093,6 +9093,26 @@ static void test_DispatchMessage(void) if (++count > 10) break; } } + + flush_sequence(); + RedrawWindow( hwnd, &rect, 0, RDW_INVALIDATE|RDW_ERASE|RDW_FRAME ); + count = 0; + while (PeekMessage( &msg, 0, 0, 0, PM_REMOVE )) + { + if (msg.message != WM_PAINT) DispatchMessage( &msg ); + else + { + HDC hdc; + + flush_sequence(); + hdc = BeginPaint( hwnd, NULL ); + ok( !hdc, "got valid hdc %p from BeginPaint\n", hdc ); + ok( !EndPaint( hwnd, NULL ), "EndPaint succeeded\n" ); + ok_sequence( WmDispatchPaint, "WmDispatchPaint", FALSE ); + ok( !count, "Got multiple WM_PAINTs\n" ); + if (++count > 10) break; + } + } DestroyWindow(hwnd); }

1 0

Daniel Jelinski : comctl32: Properly initialize internal structures.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: c1157b79fd2d3963e02020cbcc0c8d02c709938c URL: http://source.winehq.org/git/wine.git/?a=commit;h=c1157b79fd2d3963e02020cbc… Author: Daniel Jelinski <djelinski1(a)gmail.com> Date: Mon Nov 26 21:39:01 2012 +0100 comctl32: Properly initialize internal structures. --- dlls/comctl32/listview.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dlls/comctl32/listview.c b/dlls/comctl32/listview.c index d8d11ca..4bac508 100644 --- a/dlls/comctl32/listview.c +++ b/dlls/comctl32/listview.c @@ -9423,6 +9423,7 @@ static LRESULT LISTVIEW_Create(HWND hwnd, const CREATESTRUCTW *lpcs) /* init item size to avoid division by 0 */ LISTVIEW_UpdateItemSize (infoPtr); + LISTVIEW_UpdateSize (infoPtr); if (infoPtr->uView == LV_VIEW_DETAILS) {

1 0

Jason Edmeades : cmd: Prevent overflow for long command string.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: d71f5c9483b87e16ce36e9d992541c8968cb1d47 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d71f5c9483b87e16ce36e9d99… Author: Jason Edmeades <jason(a)edmeades.me.uk> Date: Mon Nov 19 22:34:09 2012 +0000 cmd: Prevent overflow for long command string. --- programs/cmd/batch.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/cmd/batch.c b/programs/cmd/batch.c index e9b98dc..8cd48e8 100644 --- a/programs/cmd/batch.c +++ b/programs/cmd/batch.c @@ -153,7 +153,7 @@ WCHAR *WCMD_parameter_with_delims (WCHAR *s, int n, WCHAR **start, BOOL raw, BOOL wholecmdline, const WCHAR *delims) { int curParamNb = 0; - static WCHAR param[MAX_PATH]; + static WCHAR param[MAXSTRING]; WCHAR *p = s, *begin; if (start != NULL) *start = NULL;

1 0

Detlef Riekenberg : shell32/tests: Remove wrong comment.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: c0ff5872031354b821c0972ff3f16c6b8b1e97f4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c0ff5872031354b821c0972ff… Author: Detlef Riekenberg <wine.dev(a)web.de> Date: Mon Nov 26 16:53:05 2012 +0100 shell32/tests: Remove wrong comment. --- dlls/shell32/tests/shelllink.c | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/dlls/shell32/tests/shelllink.c b/dlls/shell32/tests/shelllink.c index f2f33aa..b22079c 100644 --- a/dlls/shell32/tests/shelllink.c +++ b/dlls/shell32/tests/shelllink.c @@ -16,9 +16,6 @@ * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA - * This is a test program for the SHGet{Special}Folder{Path|Location} functions - * of shell32, that get either a filesystem path or a LPITEMIDLIST (shell - * namespace) path for a given folder (CSIDL value). * */

1 0

Frédéric Delanoy : ole32: Fix some leaks ( coverity).
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 8ddb00b22b02004640c6c316faacf6d971ed2620 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8ddb00b22b02004640c6c316f… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Mon Nov 26 12:41:42 2012 +0100 ole32: Fix some leaks (coverity). --- dlls/ole32/filemoniker.c | 16 ++++++++++++++-- 1 files changed, 14 insertions(+), 2 deletions(-) diff --git a/dlls/ole32/filemoniker.c b/dlls/ole32/filemoniker.c index 37c86ca..7a97100 100644 --- a/dlls/ole32/filemoniker.c +++ b/dlls/ole32/filemoniker.c @@ -973,10 +973,17 @@ FileMonikerImpl_CommonPrefixWith(IMoniker* iface,IMoniker* pmkOther,IMoniker** p return nb1; nb2=FileMonikerImpl_DecomposePath(pathOther,&stringTable2); if (FAILED(nb2)) + { + free_stringtable(stringTable1); return nb2; + } if (nb1==0 || nb2==0) + { + free_stringtable(stringTable1); + free_stringtable(stringTable2); return MK_E_NOPREFIX; + } commonPath=HeapAlloc(GetProcessHeap(),0,sizeof(WCHAR)*(min(lstrlenW(pathThis),lstrlenW(pathOther))+1)); if (!commonPath) @@ -1136,10 +1143,15 @@ FileMonikerImpl_RelativePathTo(IMoniker* iface,IMoniker* pmOther, IMoniker** ppm return res; len1=FileMonikerImpl_DecomposePath(str1,&tabStr1); + if (FAILED(len1)) + return E_OUTOFMEMORY; len2=FileMonikerImpl_DecomposePath(str2,&tabStr2); - if (FAILED(len1) || FAILED(len2)) - return E_OUTOFMEMORY; + if (FAILED(len2)) + { + free_stringtable(tabStr1); + return E_OUTOFMEMORY; + } /* count the number of similar items from the begin of the two paths */ for(sameIdx=0; ( (tabStr1[sameIdx]!=NULL) &&

1 0

Frédéric Delanoy : ole32: Add helper for string table memory freeing.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 02da0411e148ccb21ab2dc8f72764d3491adb7aa URL: http://source.winehq.org/git/wine.git/?a=commit;h=02da0411e148ccb21ab2dc8f7… Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Mon Nov 26 12:41:41 2012 +0100 ole32: Add helper for string table memory freeing. --- dlls/ole32/filemoniker.c | 43 +++++++++++++++++-------------------------- 1 files changed, 17 insertions(+), 26 deletions(-) diff --git a/dlls/ole32/filemoniker.c b/dlls/ole32/filemoniker.c index b3a5cc2..37c86ca 100644 --- a/dlls/ole32/filemoniker.c +++ b/dlls/ole32/filemoniker.c @@ -657,6 +657,15 @@ FileMonikerImpl_Reduce(IMoniker* iface, IBindCtx* pbc, DWORD dwReduceHowFar, return MK_S_REDUCED_TO_SELF; } +static void free_stringtable(LPOLESTR *stringTable) +{ + int i; + + for (i=0; stringTable[i]!=NULL; i++) + CoTaskMemFree(stringTable[i]); + CoTaskMemFree(stringTable); +} + /****************************************************************************** * FileMoniker_ComposeWith */ @@ -731,12 +740,8 @@ FileMonikerImpl_ComposeWith(IMoniker* iface, IMoniker* pmkRight, } else res = E_OUTOFMEMORY; - for(i=0; strDec1[i]!=NULL;i++) - CoTaskMemFree(strDec1[i]); - for(i=0; strDec2[i]!=NULL;i++) - CoTaskMemFree(strDec2[i]); - CoTaskMemFree(strDec1); - CoTaskMemFree(strDec2); + free_stringtable(strDec1); + free_stringtable(strDec2); CoTaskMemFree(str1); CoTaskMemFree(str2); @@ -1004,17 +1009,9 @@ FileMonikerImpl_CommonPrefixWith(IMoniker* iface,IMoniker* pmkOther,IMoniker** p { for(i=0;i<sameIdx;i++) strcatW(commonPath,stringTable1[i]); - - for(i=0;i<nb1;i++) - CoTaskMemFree(stringTable1[i]); - - CoTaskMemFree(stringTable1); - - for(i=0;i<nb2;i++) - CoTaskMemFree(stringTable2[i]); - - CoTaskMemFree(stringTable2); - + + free_stringtable(stringTable1); + free_stringtable(stringTable2); ret = CreateFileMoniker(commonPath,ppmkPrefix); } HeapFree(GetProcessHeap(),0,commonPath); @@ -1167,12 +1164,8 @@ FileMonikerImpl_RelativePathTo(IMoniker* iface,IMoniker* pmOther, IMoniker** ppm res=CreateFileMoniker(relPath,ppmkRelPath); - for(j=0; tabStr1[j]!=NULL;j++) - CoTaskMemFree(tabStr1[j]); - for(j=0; tabStr2[j]!=NULL;j++) - CoTaskMemFree(tabStr2[j]); - CoTaskMemFree(tabStr1); - CoTaskMemFree(tabStr2); + free_stringtable(tabStr1); + free_stringtable(tabStr2); CoTaskMemFree(str1); CoTaskMemFree(str2); HeapFree(GetProcessHeap(),0,relPath); @@ -1410,9 +1403,7 @@ static HRESULT FileMonikerImpl_Construct(FileMonikerImpl* This, LPCOLESTR lpszPa strcatW(This->filePathName,bkSlash); } - for(i=0; tabStr[i]!=NULL;i++) - CoTaskMemFree(tabStr[i]); - CoTaskMemFree(tabStr); + free_stringtable(tabStr); return S_OK; }

1 0

Dmitry Timoshkov : windowscodecs: Implement QueryCapability of the TGA decoder.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 380d0cd0233f1f3721a7417eb52a34423d57a71a URL: http://source.winehq.org/git/wine.git/?a=commit;h=380d0cd0233f1f3721a7417eb… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Nov 23 11:50:33 2012 +0800 windowscodecs: Implement QueryCapability of the TGA decoder. --- dlls/windowscodecs/tgaformat.c | 18 ++++++++++++++---- 1 files changed, 14 insertions(+), 4 deletions(-) diff --git a/dlls/windowscodecs/tgaformat.c b/dlls/windowscodecs/tgaformat.c index ac57e54..bb6d969 100644 --- a/dlls/windowscodecs/tgaformat.c +++ b/dlls/windowscodecs/tgaformat.c @@ -182,11 +182,21 @@ static ULONG WINAPI TgaDecoder_Release(IWICBitmapDecoder *iface) return ref; } -static HRESULT WINAPI TgaDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *pIStream, - DWORD *pdwCapability) +static HRESULT WINAPI TgaDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *stream, + DWORD *capability) { - FIXME("(%p,%p,%p): stub\n", iface, pIStream, pdwCapability); - return E_NOTIMPL; + HRESULT hr; + + TRACE("(%p,%p,%p)\n", iface, stream, capability); + + if (!stream || !capability) return E_INVALIDARG; + + hr = IWICBitmapDecoder_Initialize(iface, stream, WICDecodeMetadataCacheOnDemand); + if (hr != S_OK) return hr; + + *capability = WICBitmapDecoderCapabilityCanDecodeAllImages | + WICBitmapDecoderCapabilityCanDecodeSomeImages; + return S_OK; } static HRESULT WINAPI TgaDecoder_Initialize(IWICBitmapDecoder *iface, IStream *pIStream,

1 0

Dmitry Timoshkov : windowscodecs: Add a NULL check to GetFrameCount of the TGA decoder.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 03efd5c0f78354e1182133ec8246d09594ac38eb URL: http://source.winehq.org/git/wine.git/?a=commit;h=03efd5c0f78354e1182133ec8… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Nov 23 11:50:20 2012 +0800 windowscodecs: Add a NULL check to GetFrameCount of the TGA decoder. --- dlls/windowscodecs/tgaformat.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/windowscodecs/tgaformat.c b/dlls/windowscodecs/tgaformat.c index cd615c7..ac57e54 100644 --- a/dlls/windowscodecs/tgaformat.c +++ b/dlls/windowscodecs/tgaformat.c @@ -405,6 +405,8 @@ static HRESULT WINAPI TgaDecoder_GetThumbnail(IWICBitmapDecoder *iface, static HRESULT WINAPI TgaDecoder_GetFrameCount(IWICBitmapDecoder *iface, UINT *pCount) { + if (!pCount) return E_INVALIDARG; + *pCount = 1; return S_OK; }

1 0

Dmitry Timoshkov : windowscodecs: Implement QueryCapability of the PNG decoder.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 92d445bcca7c00a3759c84abdecd17763c250b12 URL: http://source.winehq.org/git/wine.git/?a=commit;h=92d445bcca7c00a3759c84abd… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Nov 23 11:50:05 2012 +0800 windowscodecs: Implement QueryCapability of the PNG decoder. --- dlls/windowscodecs/pngformat.c | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/dlls/windowscodecs/pngformat.c b/dlls/windowscodecs/pngformat.c index 46a1908..009532d 100644 --- a/dlls/windowscodecs/pngformat.c +++ b/dlls/windowscodecs/pngformat.c @@ -351,11 +351,22 @@ static ULONG WINAPI PngDecoder_Release(IWICBitmapDecoder *iface) return ref; } -static HRESULT WINAPI PngDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *pIStream, - DWORD *pdwCapability) +static HRESULT WINAPI PngDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *stream, + DWORD *capability) { - FIXME("(%p,%p,%p): stub\n", iface, pIStream, pdwCapability); - return E_NOTIMPL; + HRESULT hr; + + TRACE("(%p,%p,%p)\n", iface, stream, capability); + + if (!stream || !capability) return E_INVALIDARG; + + hr = IWICBitmapDecoder_Initialize(iface, stream, WICDecodeMetadataCacheOnDemand); + if (hr != S_OK) return hr; + + *capability = WICBitmapDecoderCapabilityCanDecodeAllImages | + WICBitmapDecoderCapabilityCanDecodeSomeImages; + /* FIXME: WICBitmapDecoderCapabilityCanEnumerateMetadata */ + return S_OK; } static void user_read_data(png_structp png_ptr, png_bytep data, png_size_t length)

1 0

Dmitry Timoshkov : windowscodecs: Add a NULL check to GetFrameCount of the PNG decoder.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 5285756f938371457c3577ec9ad03ccacbcb658d URL: http://source.winehq.org/git/wine.git/?a=commit;h=5285756f938371457c3577ec9… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Nov 23 11:49:44 2012 +0800 windowscodecs: Add a NULL check to GetFrameCount of the PNG decoder. --- dlls/windowscodecs/pngformat.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/windowscodecs/pngformat.c b/dlls/windowscodecs/pngformat.c index 4c94489..46a1908 100644 --- a/dlls/windowscodecs/pngformat.c +++ b/dlls/windowscodecs/pngformat.c @@ -640,6 +640,8 @@ static HRESULT WINAPI PngDecoder_GetThumbnail(IWICBitmapDecoder *iface, static HRESULT WINAPI PngDecoder_GetFrameCount(IWICBitmapDecoder *iface, UINT *pCount) { + if (!pCount) return E_INVALIDARG; + *pCount = 1; return S_OK; }

1 0

Dmitry Timoshkov : windowscodecs: Implement QueryCapability of the JPEG decoder.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 67eafab883e9a9c5c22aa990806d35154d4e9dec URL: http://source.winehq.org/git/wine.git/?a=commit;h=67eafab883e9a9c5c22aa9908… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Nov 23 11:49:23 2012 +0800 windowscodecs: Implement QueryCapability of the JPEG decoder. --- dlls/windowscodecs/jpegformat.c | 19 +++++++++++++++---- 1 files changed, 15 insertions(+), 4 deletions(-) diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c index e9c722e..57f1b55 100644 --- a/dlls/windowscodecs/jpegformat.c +++ b/dlls/windowscodecs/jpegformat.c @@ -220,11 +220,22 @@ static ULONG WINAPI JpegDecoder_Release(IWICBitmapDecoder *iface) return ref; } -static HRESULT WINAPI JpegDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *pIStream, - DWORD *pdwCapability) +static HRESULT WINAPI JpegDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *stream, + DWORD *capability) { - FIXME("(%p,%p,%p): stub\n", iface, pIStream, pdwCapability); - return E_NOTIMPL; + HRESULT hr; + + TRACE("(%p,%p,%p)\n", iface, stream, capability); + + if (!stream || !capability) return E_INVALIDARG; + + hr = IWICBitmapDecoder_Initialize(iface, stream, WICDecodeMetadataCacheOnDemand); + if (hr != S_OK) return hr; + + *capability = WICBitmapDecoderCapabilityCanDecodeAllImages | + WICBitmapDecoderCapabilityCanDecodeSomeImages; + /* FIXME: WICBitmapDecoderCapabilityCanEnumerateMetadata */ + return S_OK; } static void source_mgr_init_source(j_decompress_ptr cinfo)

1 0

Dmitry Timoshkov : windowscodecs: Add a NULL check to GetFrameCount of the JPEG decoder.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: c44024f1e0be0065a43e87b81c187e0c43b04ab7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c44024f1e0be0065a43e87b81… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Nov 23 11:49:09 2012 +0800 windowscodecs: Add a NULL check to GetFrameCount of the JPEG decoder. --- dlls/windowscodecs/jpegformat.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c index eab50f0..e9c722e 100644 --- a/dlls/windowscodecs/jpegformat.c +++ b/dlls/windowscodecs/jpegformat.c @@ -430,6 +430,8 @@ static HRESULT WINAPI JpegDecoder_GetThumbnail(IWICBitmapDecoder *iface, static HRESULT WINAPI JpegDecoder_GetFrameCount(IWICBitmapDecoder *iface, UINT *pCount) { + if (!pCount) return E_INVALIDARG; + *pCount = 1; return S_OK; }

1 0

Dmitry Timoshkov : windowscodecs: Implement QueryCapability of the ICO decoder.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 5e10f2e0ec896a275d69b77bfe699e841dc0b7c8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5e10f2e0ec896a275d69b77bf… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Nov 23 11:48:49 2012 +0800 windowscodecs: Implement QueryCapability of the ICO decoder. --- dlls/windowscodecs/icoformat.c | 17 +++++++++++++---- 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/dlls/windowscodecs/icoformat.c b/dlls/windowscodecs/icoformat.c index 6606341..7aec245 100644 --- a/dlls/windowscodecs/icoformat.c +++ b/dlls/windowscodecs/icoformat.c @@ -489,11 +489,20 @@ static ULONG WINAPI IcoDecoder_Release(IWICBitmapDecoder *iface) return ref; } -static HRESULT WINAPI IcoDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *pIStream, - DWORD *pdwCapability) +static HRESULT WINAPI IcoDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *stream, + DWORD *capability) { - FIXME("(%p,%p,%p): stub\n", iface, pIStream, pdwCapability); - return E_NOTIMPL; + HRESULT hr; + + TRACE("(%p,%p,%p)\n", iface, stream, capability); + + if (!stream || !capability) return E_INVALIDARG; + + hr = IWICBitmapDecoder_Initialize(iface, stream, WICDecodeMetadataCacheOnDemand); + if (hr != S_OK) return hr; + + *capability = WICBitmapDecoderCapabilityCanDecodeAllImages; + return S_OK; } static HRESULT WINAPI IcoDecoder_Initialize(IWICBitmapDecoder *iface, IStream *pIStream,

1 0

Dmitry Timoshkov : windowscodecs: Reimplement GetFrameCount of the ICO decoder.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: 075d28d8570341060af65e0fb3b218efe8399da8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=075d28d8570341060af65e0fb… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Nov 23 11:48:28 2012 +0800 windowscodecs: Reimplement GetFrameCount of the ICO decoder. --- dlls/windowscodecs/icoformat.c | 10 ++++++---- 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/dlls/windowscodecs/icoformat.c b/dlls/windowscodecs/icoformat.c index 6b454c2..6606341 100644 --- a/dlls/windowscodecs/icoformat.c +++ b/dlls/windowscodecs/icoformat.c @@ -603,12 +603,14 @@ static HRESULT WINAPI IcoDecoder_GetFrameCount(IWICBitmapDecoder *iface, UINT *pCount) { IcoDecoder *This = impl_from_IWICBitmapDecoder(iface); - TRACE("(%p,%p)\n", iface, pCount); - if (!This->initialized) return WINCODEC_ERR_NOTINITIALIZED; + if (!pCount) return E_INVALIDARG; - *pCount = This->header.idCount; - TRACE("<-- %u\n", *pCount); + EnterCriticalSection(&This->lock); + *pCount = This->initialized ? This->header.idCount : 0; + LeaveCriticalSection(&This->lock); + + TRACE("(%p) <-- %d\n", iface, *pCount); return S_OK; }

1 0

Dmitry Timoshkov : windowscodecs: Reimplement QueryCapability of the BMP decoder.
by Alexandre Julliard 27 Nov '12

27 Nov '12

Module: wine Branch: master Commit: eb26db27a75bb0332f8877feec06558aaeab9db1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=eb26db27a75bb0332f8877fee… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Nov 23 11:48:04 2012 +0800 windowscodecs: Reimplement QueryCapability of the BMP decoder. --- dlls/windowscodecs/bmpdecode.c | 18 ++++++++---------- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/dlls/windowscodecs/bmpdecode.c b/dlls/windowscodecs/bmpdecode.c index 54de0f1..e029369 100644 --- a/dlls/windowscodecs/bmpdecode.c +++ b/dlls/windowscodecs/bmpdecode.c @@ -1010,22 +1010,20 @@ static ULONG WINAPI BmpDecoder_Release(IWICBitmapDecoder *iface) return ref; } -static HRESULT WINAPI BmpDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *pIStream, - DWORD *pdwCapability) +static HRESULT WINAPI BmpDecoder_QueryCapability(IWICBitmapDecoder *iface, IStream *stream, + DWORD *capability) { HRESULT hr; BmpDecoder *This = impl_from_IWICBitmapDecoder(iface); - EnterCriticalSection(&This->lock); - hr = BmpDecoder_ReadHeaders(This, pIStream); - LeaveCriticalSection(&This->lock); - if (FAILED(hr)) return hr; + TRACE("(%p,%p,%p)\n", iface, stream, capability); - if (This->read_data_func == BmpFrameDecode_ReadUnsupported) - *pdwCapability = 0; - else - *pdwCapability = WICBitmapDecoderCapabilityCanDecodeAllImages; + if (!stream || !capability) return E_INVALIDARG; + + hr = IWICBitmapDecoder_Initialize(iface, stream, WICDecodeMetadataCacheOnDemand); + if (hr != S_OK) return hr; + *capability = This->read_data_func == BmpFrameDecode_ReadUnsupported ? 0 : WICBitmapDecoderCapabilityCanDecodeAllImages; return S_OK; }

1 0

← Newer
1
2
3
4
5
6
7
8
...
29
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits November 2012