winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
December 2012
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
549 discussions
Start a n
N
ew thread
Dmitry Timoshkov : wineps.drv: Add a trace to PSDRV_GetDeviceCaps.
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: fd193bc78116f3021d486d6fc327fa9ccfd64cc7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fd193bc78116f3021d486d6fc…
Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Dec 17 17:40:04 2012 +0800 wineps.drv: Add a trace to PSDRV_GetDeviceCaps. --- dlls/wineps.drv/init.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/dlls/wineps.drv/init.c b/dlls/wineps.drv/init.c index 3f31f45..01d7f13 100644 --- a/dlls/wineps.drv/init.c +++ b/dlls/wineps.drv/init.c @@ -355,6 +355,8 @@ static INT PSDRV_GetDeviceCaps( PHYSDEV dev, INT cap ) { PSDRV_PDEVICE *physDev = get_psdrv_dev( dev ); + TRACE("%p,%d\n", dev->hdc, cap); + switch(cap) { case DRIVERVERSION:
1
0
0
0
Jacek Caban : urlmon: Added IWinInetInfo and IWinInetHttpInfo proxy/ stub implementation.
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: cc75a52c6a59c4f13d0f02f6b9d5083ae805e06d URL:
http://source.winehq.org/git/wine.git/?a=commit;h=cc75a52c6a59c4f13d0f02f6b…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 17 14:53:24 2012 +0100 urlmon: Added IWinInetInfo and IWinInetHttpInfo proxy/stub implementation. --- dlls/urlmon/usrmarshal.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/urlmon/usrmarshal.c b/dlls/urlmon/usrmarshal.c index e6b468a..d669918 100644 --- a/dlls/urlmon/usrmarshal.c +++ b/dlls/urlmon/usrmarshal.c @@ -26,30 +26,30 @@ HRESULT CALLBACK IWinInetHttpInfo_QueryInfo_Proxy(IWinInetHttpInfo* This, DWORD dwOption, LPVOID pBuffer, DWORD *pcbBuf, DWORD *pdwFlags, DWORD *pdwReserved) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p %x %p %p %p %p)\n", This, dwOption, pBuffer, pcbBuf, pdwFlags, pdwReserved); + return IWinInetHttpInfo_RemoteQueryInfo_Proxy(This, dwOption, pBuffer, pcbBuf, pdwFlags, pdwReserved); } HRESULT __RPC_STUB IWinInetHttpInfo_QueryInfo_Stub(IWinInetHttpInfo* This, DWORD dwOption, BYTE *pBuffer, DWORD *pcbBuf, DWORD *pdwFlags, DWORD *pdwReserved) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p %x %p %p %p %p)\n", This, dwOption, pBuffer, pcbBuf, pdwFlags, pdwReserved); + return IWinInetHttpInfo_QueryInfo(This, dwOption, pBuffer, pcbBuf, pdwFlags, pdwReserved); } HRESULT CALLBACK IWinInetInfo_QueryOption_Proxy(IWinInetInfo* This, DWORD dwOption, LPVOID pBuffer, DWORD *pcbBuf) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p %x %p %p)\n", This, dwOption, pBuffer, pcbBuf); + return IWinInetInfo_RemoteQueryOption_Proxy(This, dwOption, pBuffer, pcbBuf); } HRESULT __RPC_STUB IWinInetInfo_QueryOption_Stub(IWinInetInfo* This, DWORD dwOption, BYTE *pBuffer, DWORD *pcbBuf) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p %x %p %p)\n", This, dwOption, pBuffer, pcbBuf); + return IWinInetInfo_QueryOption(This, dwOption, pBuffer, pcbBuf); } HRESULT CALLBACK IBindHost_MonikerBindToStorage_Proxy(IBindHost* This,
1
0
0
0
Jacek Caban : jscript: Fixed deleting property by ID from IDispatchEx interface.
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: f780ae0f86cb925e6fa149b901960536f50202d7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f780ae0f86cb925e6fa149b90…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 17 13:36:55 2012 +0100 jscript: Fixed deleting property by ID from IDispatchEx interface. --- dlls/jscript/dispex.c | 2 +- dlls/jscript/tests/run.c | 34 +++++++++++++++++++++++++++++----- 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index 0ecd20a..9e2ba5b 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -1501,7 +1501,7 @@ HRESULT disp_delete(IDispatch *disp, DISPID id, BOOL *ret) if(FAILED(hres)) return hres; - *ret = TRUE; + *ret = hres == S_OK; return S_OK; } diff --git a/dlls/jscript/tests/run.c b/dlls/jscript/tests/run.c index 52fee57..0b0215c 100644 --- a/dlls/jscript/tests/run.c +++ b/dlls/jscript/tests/run.c @@ -81,6 +81,7 @@ DEFINE_EXPECT(global_propget_i); DEFINE_EXPECT(global_propput_d); DEFINE_EXPECT(global_propput_i); DEFINE_EXPECT(global_propdelete_d); +DEFINE_EXPECT(global_nopropdelete_d); DEFINE_EXPECT(global_success_d); DEFINE_EXPECT(global_success_i); DEFINE_EXPECT(global_notexists_d); @@ -102,6 +103,7 @@ DEFINE_EXPECT(GetItemInfo_testVal); DEFINE_EXPECT(ActiveScriptSite_OnScriptError); DEFINE_EXPECT(invoke_func); DEFINE_EXPECT(DeleteMemberByDispID); +DEFINE_EXPECT(DeleteMemberByDispID_false); #define DISPID_GLOBAL_TESTPROPGET 0x1000 #define DISPID_GLOBAL_TESTPROPPUT 0x1001 @@ -130,7 +132,8 @@ DEFINE_EXPECT(DeleteMemberByDispID); #define DISPID_GLOBAL_TESTRES 0x1018 #define DISPID_GLOBAL_TESTNORES 0x1019 -#define DISPID_GLOBAL_TESTPROPDELETE 0x2000 +#define DISPID_GLOBAL_TESTPROPDELETE 0x2000 +#define DISPID_GLOBAL_TESTNOPROPDELETE 0x2001 #define DISPID_TESTOBJ_PROP 0x2000 #define DISPID_TESTOBJ_ONLYDISPID 0x2001 @@ -497,6 +500,12 @@ static HRESULT WINAPI Global_GetDispID(IDispatchEx *iface, BSTR bstrName, DWORD *pid = DISPID_GLOBAL_TESTPROPDELETE; return S_OK; } + if(!strcmp_wa(bstrName, "testNoPropDelete")) { + CHECK_EXPECT(global_nopropdelete_d); + test_grfdex(grfdex, fdexNameCaseSensitive); + *pid = DISPID_GLOBAL_TESTNOPROPDELETE; + return S_OK; + } if(!strcmp_wa(bstrName, "getVT")) { test_grfdex(grfdex, fdexNameCaseSensitive); *pid = DISPID_GLOBAL_GETVT; @@ -1082,9 +1091,18 @@ static HRESULT WINAPI Global_InvokeEx(IDispatchEx *iface, DISPID id, LCID lcid, static HRESULT WINAPI Global_DeleteMemberByDispID(IDispatchEx *iface, DISPID id) { - CHECK_EXPECT(DeleteMemberByDispID); - ok(id == DISPID_GLOBAL_TESTPROPDELETE, "id = %d\n", id); - return S_OK; + switch(id) { + case DISPID_GLOBAL_TESTPROPDELETE: + CHECK_EXPECT(DeleteMemberByDispID); + return S_OK; + case DISPID_GLOBAL_TESTNOPROPDELETE: + CHECK_EXPECT(DeleteMemberByDispID_false); + return S_FALSE; + default: + ok(0, "id = %d\n", id); + } + + return E_FAIL; } static IDispatchExVtbl GlobalVtbl = { @@ -1855,10 +1873,16 @@ static BOOL run_tests(void) SET_EXPECT(global_propdelete_d); SET_EXPECT(DeleteMemberByDispID); - parse_script_a("delete testPropDelete;"); + parse_script_a("ok((delete testPropDelete) === true, 'delete testPropDelete did not return true');"); CHECK_CALLED(global_propdelete_d); CHECK_CALLED(DeleteMemberByDispID); + SET_EXPECT(global_nopropdelete_d); + SET_EXPECT(DeleteMemberByDispID_false); + parse_script_a("ok((delete testNoPropDelete) === false, 'delete testPropDelete did not return false');"); + CHECK_CALLED(global_nopropdelete_d); + CHECK_CALLED(DeleteMemberByDispID_false); + SET_EXPECT(puredisp_prop_d); parse_script_a("ok((delete pureDisp.prop) === false, 'delete pureDisp.prop did not return true');"); CHECK_CALLED(puredisp_prop_d);
1
0
0
0
Jacek Caban : jscript: Fixed deleting properties by name from IDispatchEx interface.
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: 2d7a3bb4827533ee102497de12c61b850be59c9b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2d7a3bb4827533ee102497de1…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 17 13:36:44 2012 +0100 jscript: Fixed deleting properties by name from IDispatchEx interface. --- dlls/jscript/dispex.c | 3 ++- dlls/jscript/tests/run.c | 29 +++++++++++++++++++++-------- 2 files changed, 23 insertions(+), 9 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index 78809ee..0ecd20a 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -1535,7 +1535,8 @@ HRESULT disp_delete_name(script_ctx_t *ctx, IDispatch *disp, jsstr_t *name, BOOL if(bstr) { hres = IDispatchEx_DeleteMemberByName(dispex, bstr, make_grfdex(ctx, fdexNameCaseSensitive)); SysFreeString(bstr); - *ret = TRUE; + if(SUCCEEDED(hres)) + *ret = hres == S_OK; }else { hres = E_OUTOFMEMORY; } diff --git a/dlls/jscript/tests/run.c b/dlls/jscript/tests/run.c index 46f519a..52fee57 100644 --- a/dlls/jscript/tests/run.c +++ b/dlls/jscript/tests/run.c @@ -89,7 +89,8 @@ DEFINE_EXPECT(global_propargput_i); DEFINE_EXPECT(global_testargtypes_i); DEFINE_EXPECT(puredisp_prop_d); DEFINE_EXPECT(puredisp_noprop_d); -DEFINE_EXPECT(testobj_delete); +DEFINE_EXPECT(testobj_delete_test); +DEFINE_EXPECT(testobj_delete_nodelete); DEFINE_EXPECT(testobj_value); DEFINE_EXPECT(testobj_prop_d); DEFINE_EXPECT(testobj_withprop_d); @@ -402,11 +403,19 @@ static HRESULT WINAPI testObj_InvokeEx(IDispatchEx *iface, DISPID id, LCID lcid, static HRESULT WINAPI testObj_DeleteMemberByName(IDispatchEx *iface, BSTR bstrName, DWORD grfdex) { - CHECK_EXPECT(testobj_delete); + if(!strcmp_wa(bstrName, "deleteTest")) { + CHECK_EXPECT(testobj_delete_test); + test_grfdex(grfdex, fdexNameCaseSensitive); + return S_OK; + } + if(!strcmp_wa(bstrName, "noDeleteTest")) { + CHECK_EXPECT(testobj_delete_nodelete); + test_grfdex(grfdex, fdexNameCaseSensitive); + return S_FALSE; + } - ok(!strcmp_wa(bstrName, "deleteTest"), "unexpected name %s\n", wine_dbgstr_w(bstrName)); - test_grfdex(grfdex, fdexNameCaseSensitive); - return S_OK; + ok(0, "unexpected name %s\n", wine_dbgstr_w(bstrName)); + return E_FAIL; } static IDispatchExVtbl testObjVtbl = { @@ -1836,9 +1845,13 @@ static BOOL run_tests(void) CHECK_CALLED(global_success_d); CHECK_CALLED(global_success_i); - SET_EXPECT(testobj_delete); - parse_script_a("delete testObj.deleteTest;"); - CHECK_CALLED(testobj_delete); + SET_EXPECT(testobj_delete_test); + parse_script_a("ok((delete testObj.deleteTest) === true, 'delete testObj.deleteTest did not return true');"); + CHECK_CALLED(testobj_delete_test); + + SET_EXPECT(testobj_delete_nodelete); + parse_script_a("ok((delete testObj.noDeleteTest) === false, 'delete testObj.noDeleteTest did not return false');"); + CHECK_CALLED(testobj_delete_nodelete); SET_EXPECT(global_propdelete_d); SET_EXPECT(DeleteMemberByDispID);
1
0
0
0
Jacek Caban : jscript: Fixed deleting properties of pure dispatch interface .
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: 7202f1a32f884838586c1b019b02401f22cafd7a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7202f1a32f884838586c1b019…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 17 13:36:31 2012 +0100 jscript: Fixed deleting properties of pure dispatch interface. --- dlls/jscript/dispex.c | 14 ++++++++++++-- dlls/jscript/tests/run.c | 8 ++++++++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index dbb1c63..78809ee 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -1542,8 +1542,18 @@ HRESULT disp_delete_name(script_ctx_t *ctx, IDispatch *disp, jsstr_t *name, BOOL IDispatchEx_Release(dispex); }else { - hres = S_OK; - ret = FALSE; + WCHAR *name_str = name->str; + DISPID id; + + hres = IDispatch_GetIDsOfNames(disp, &IID_NULL, &name_str, 1, 0, &id); + if(SUCCEEDED(hres)) { + /* Property exists and we can't delete it from pure IDispatch interface, so return false. */ + *ret = FALSE; + }else if(hres == DISP_E_UNKNOWNNAME) { + /* Property doesn't exist, so nothing to delete */ + *ret = TRUE; + hres = S_OK; + } } return hres; diff --git a/dlls/jscript/tests/run.c b/dlls/jscript/tests/run.c index 55b1398..46f519a 100644 --- a/dlls/jscript/tests/run.c +++ b/dlls/jscript/tests/run.c @@ -1846,6 +1846,14 @@ static BOOL run_tests(void) CHECK_CALLED(global_propdelete_d); CHECK_CALLED(DeleteMemberByDispID); + SET_EXPECT(puredisp_prop_d); + parse_script_a("ok((delete pureDisp.prop) === false, 'delete pureDisp.prop did not return true');"); + CHECK_CALLED(puredisp_prop_d); + + SET_EXPECT(puredisp_noprop_d); + parse_script_a("ok((delete pureDisp.noprop) === true, 'delete pureDisp.noprop did not return false');"); + CHECK_CALLED(puredisp_noprop_d); + parse_script_a("(function reportSuccess() {})()"); parse_script_a("ok(typeof(test) === 'object', \"typeof(test) != 'object'\");");
1
0
0
0
Jacek Caban : jscript: Fixed deleting nonexistent identifiers.
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: 4dbd777de289ee58a11b2c9919e9b2765b81941a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4dbd777de289ee58a11b2c991…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 17 13:36:18 2012 +0100 jscript: Fixed deleting nonexistent identifiers. --- dlls/jscript/engine.c | 16 +++++++++++----- dlls/jscript/tests/lang.js | 1 + 2 files changed, 12 insertions(+), 5 deletions(-) diff --git a/dlls/jscript/engine.c b/dlls/jscript/engine.c index fbfa460..489aef6 100644 --- a/dlls/jscript/engine.c +++ b/dlls/jscript/engine.c @@ -1631,16 +1631,22 @@ static HRESULT interp_delete_ident(exec_ctx_t *ctx) if(FAILED(hres)) return hres; - if(exprval.type != EXPRVAL_IDREF) { + switch(exprval.type) { + case EXPRVAL_IDREF: + hres = disp_delete(exprval.u.idref.disp, exprval.u.idref.id, &ret); + IDispatch_Release(exprval.u.idref.disp); + if(FAILED(hres)) + return ret; + break; + case EXPRVAL_INVALID: + ret = TRUE; + break; + default: FIXME("Unsupported exprval\n"); exprval_release(&exprval); return E_NOTIMPL; } - hres = disp_delete(exprval.u.idref.disp, exprval.u.idref.id, &ret); - IDispatch_Release(exprval.u.idref.disp); - if(FAILED(hres)) - return ret; return stack_push(ctx, jsval_bool(ret)); } diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js index f9c05bd..bac2deb 100644 --- a/dlls/jscript/tests/lang.js +++ b/dlls/jscript/tests/lang.js @@ -1123,6 +1123,7 @@ for(iter in tmp) ok(false, "tmp has prop " + iter); ok((delete tmp.test) === true, "deleting test didn't return true"); ok((delete tmp.nonexistent) === true, "deleting nonexistent didn't return true"); +ok((delete nonexistent) === true, "deleting nonexistent didn't return true"); tmp = new Object(); tmp.test = false;
1
0
0
0
Jacek Caban : jscript: Fixed deleting nonexisting properties from member expression.
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: 7f07bb9a7a1dbb9cab148ce58ec45775764a2f73 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7f07bb9a7a1dbb9cab148ce58…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 17 13:36:08 2012 +0100 jscript: Fixed deleting nonexisting properties from member expression. --- dlls/jscript/dispex.c | 8 +++++--- dlls/jscript/tests/lang.js | 2 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/dlls/jscript/dispex.c b/dlls/jscript/dispex.c index 2cd4ad5..dbb1c63 100644 --- a/dlls/jscript/dispex.c +++ b/dlls/jscript/dispex.c @@ -1516,10 +1516,12 @@ HRESULT disp_delete_name(script_ctx_t *ctx, IDispatch *disp, jsstr_t *name, BOOL dispex_prop_t *prop; hres = find_prop_name(jsdisp, string_hash(name->str), name->str, &prop); - if(prop) + if(prop) { hres = delete_prop(prop, ret); - else - hres = DISP_E_MEMBERNOTFOUND; + }else { + *ret = TRUE; + hres = S_OK; + } jsdisp_release(jsdisp); return hres; diff --git a/dlls/jscript/tests/lang.js b/dlls/jscript/tests/lang.js index 23e12cc..f9c05bd 100644 --- a/dlls/jscript/tests/lang.js +++ b/dlls/jscript/tests/lang.js @@ -1121,6 +1121,8 @@ ok(typeof(tmp.test) === "undefined", "tmp.test type = " + typeof(tmp.test)); ok(!("test" in tmp), "test is still in tmp after delete?"); for(iter in tmp) ok(false, "tmp has prop " + iter); +ok((delete tmp.test) === true, "deleting test didn't return true"); +ok((delete tmp.nonexistent) === true, "deleting nonexistent didn't return true"); tmp = new Object(); tmp.test = false;
1
0
0
0
Jacek Caban : jscript: Fixed Number.toFixed for value 0 with 0 precision.
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: 9de9c353ac5c09546fba139f3f446e62522e49a5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9de9c353ac5c09546fba139f3…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Mon Dec 17 13:35:54 2012 +0100 jscript: Fixed Number.toFixed for value 0 with 0 precision. --- dlls/jscript/number.c | 6 ++++-- dlls/jscript/tests/api.js | 8 ++++++++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/dlls/jscript/number.c b/dlls/jscript/number.c index ed773a3..351e915 100644 --- a/dlls/jscript/number.c +++ b/dlls/jscript/number.c @@ -99,15 +99,17 @@ static inline jsstr_t *number_to_fixed(double val, int prec) jsstr_t *ret; WCHAR *str; + TRACE("%lf %d\n", val, prec); + if(val < 0) { neg = TRUE; val = -val; } - if(val<=-1 || val>=1) + if(val >= 1) buf_size = log10(val)+prec+2; else - buf_size = prec+1; + buf_size = prec ? prec+1 : 2; if(buf_size > NUMBER_DTOA_SIZE) buf_size = NUMBER_DTOA_SIZE; diff --git a/dlls/jscript/tests/api.js b/dlls/jscript/tests/api.js index 6322eae..5d45777 100644 --- a/dlls/jscript/tests/api.js +++ b/dlls/jscript/tests/api.js @@ -1204,6 +1204,14 @@ ok(tmp === "101.1", "num(5.5).toString(2) = " + tmp); tmp = (new Number(3)).toFixed(3); ok(tmp === "3.000", "num(3).toFixed(3) = " + tmp); +tmp = (new Number(3)).toFixed(); +ok(tmp === "3", "Number(3).toFixed() = " + tmp); +tmp = (new Number(0)).toFixed(); +ok(tmp === "0", "Number(0).toFixed() = " + tmp); +tmp = (new Number(0)).toFixed(1); +ok(tmp === "0.0", "Number(0).toFixed(1) = " + tmp); +tmp = (new Number(0)).toFixed(2); +ok(tmp === "0.00", "Number(0).toFixed(2) = " + tmp); tmp = (new Number(1.76)).toFixed(1); ok(tmp === "1.8", "num(1.76).toFixed(1) = " + tmp); tmp = (new Number(7.92)).toFixed(5);
1
0
0
0
Ken Thomases : winemac: Implement minimal Create[Compatible]DC() and DeleteDC().
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: 59e339faac8b6fdf1672bdbfbce4c1bc1dbd72ad URL:
http://source.winehq.org/git/wine.git/?a=commit;h=59e339faac8b6fdf1672bdbfb…
Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Dec 16 18:07:10 2012 -0600 winemac: Implement minimal Create[Compatible]DC() and DeleteDC(). --- dlls/winemac.drv/Makefile.in | 1 + dlls/winemac.drv/gdi.c | 254 +++++++++++++++++++++++++++++++++++++ dlls/winemac.drv/winemac.drv.spec | 4 +- 3 files changed, 258 insertions(+), 1 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=59e339faac8b6fdf1672b…
1
0
0
0
Ken Thomases : winequartz.drv: Rename to winemac.drv ("the Mac driver").
by Alexandre Julliard
17 Dec '12
17 Dec '12
Module: wine Branch: master Commit: 35033025aa9358961053b9d755ca33f93f218b8b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=35033025aa9358961053b9d75…
Author: Ken Thomases <ken(a)codeweavers.com> Date: Sun Dec 16 18:06:52 2012 -0600 winequartz.drv: Rename to winemac.drv ("the Mac driver"). --- configure | 6 +++--- configure.ac | 8 ++++---- dlls/{winequartz.drv => winemac.drv}/Makefile.in | 4 ++-- .../quartzdrv_main.c => winemac.drv/macdrv_main.c} | 4 ++-- .../winemac.drv.spec} | 0 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/configure b/configure index e96750d..7b3b31d 100755 --- a/configure +++ b/configure @@ -6673,7 +6673,7 @@ done then CARBONLIB="-framework Carbon" - enable_winequartz_drv=${enable_winequartz_drv:-yes} + enable_winemac_drv=${enable_winemac_drv:-yes} fi if test "x$enable_win16" = "xyes" then @@ -7129,7 +7129,7 @@ $as_echo "$ac_cv_c_dll_hpux" >&6; } esac enable_wineqtdecoder=${enable_wineqtdecoder:-no} -enable_winequartz_drv=${enable_winequartz_drv:-no} +enable_winemac_drv=${enable_winemac_drv:-no} if test "$LIBEXT" = "a"; then as_fn_error $? "could not find a way to build shared libraries. @@ -15866,13 +15866,13 @@ wine_fn_config_lib winecrt0 wine_fn_config_dll wined3d enable_wined3d implib wine_fn_config_dll winegstreamer enable_winegstreamer wine_fn_config_dll winejoystick.drv enable_winejoystick_drv +wine_fn_config_dll winemac.drv enable_winemac_drv wine_fn_config_dll winemapi enable_winemapi wine_fn_config_dll winemp3.acm enable_winemp3_acm wine_fn_config_dll wineoss.drv enable_wineoss_drv wine_fn_config_dll wineps.drv enable_wineps_drv install-lib,po wine_fn_config_dll wineps16.drv16 enable_win16 wine_fn_config_dll wineqtdecoder enable_wineqtdecoder -wine_fn_config_dll winequartz.drv enable_winequartz_drv wine_fn_config_dll winex11.drv enable_winex11_drv wine_fn_config_dll wing.dll16 enable_win16 wine_fn_config_dll wing32 enable_wing32 diff --git a/configure.ac b/configure.ac index 2a4ea4e..3a07cbf 100644 --- a/configure.ac +++ b/configure.ac @@ -796,11 +796,11 @@ case $host_os in else WINE_NOTICE([QuickTime ${notice_platform}development files not found, video decoding won't be supported.]) fi - dnl Enable quartz driver on Mac OS X + dnl Enable Mac driver on Mac OS X if test "$ac_cv_header_Carbon_Carbon_h" = "yes" then AC_SUBST(CARBONLIB,"-framework Carbon") - enable_winequartz_drv=${enable_winequartz_drv:-yes} + enable_winemac_drv=${enable_winemac_drv:-yes} fi dnl Check for Xcode 3.x broken 16-bit support if test "x$enable_win16" = "xyes" @@ -899,7 +899,7 @@ case $host_os in esac enable_wineqtdecoder=${enable_wineqtdecoder:-no} -enable_winequartz_drv=${enable_winequartz_drv:-no} +enable_winemac_drv=${enable_winemac_drv:-no} if test "$LIBEXT" = "a"; then AC_MSG_ERROR( @@ -3045,13 +3045,13 @@ WINE_CONFIG_LIB(winecrt0) WINE_CONFIG_DLL(wined3d,,[implib]) WINE_CONFIG_DLL(winegstreamer) WINE_CONFIG_DLL(winejoystick.drv) +WINE_CONFIG_DLL(winemac.drv) WINE_CONFIG_DLL(winemapi) WINE_CONFIG_DLL(winemp3.acm) WINE_CONFIG_DLL(wineoss.drv) WINE_CONFIG_DLL(wineps.drv,,[install-lib,po]) WINE_CONFIG_DLL(wineps16.drv16,enable_win16) WINE_CONFIG_DLL(wineqtdecoder) -WINE_CONFIG_DLL(winequartz.drv) WINE_CONFIG_DLL(winex11.drv) WINE_CONFIG_DLL(wing.dll16,enable_win16) WINE_CONFIG_DLL(wing32) diff --git a/dlls/winequartz.drv/Makefile.in b/dlls/winemac.drv/Makefile.in similarity index 58% rename from dlls/winequartz.drv/Makefile.in rename to dlls/winemac.drv/Makefile.in index 18801f5..4145dff 100644 --- a/dlls/winequartz.drv/Makefile.in +++ b/dlls/winemac.drv/Makefile.in @@ -1,7 +1,7 @@ -MODULE = winequartz.drv +MODULE = winemac.drv IMPORTS = user32 gdi32 advapi32 C_SRCS = \ - quartzdrv_main.c + macdrv_main.c @MAKE_DLL_RULES@ diff --git a/dlls/winequartz.drv/quartzdrv_main.c b/dlls/winemac.drv/macdrv_main.c similarity index 94% rename from dlls/winequartz.drv/quartzdrv_main.c rename to dlls/winemac.drv/macdrv_main.c index 88bc6ac..17aebf6 100644 --- a/dlls/winequartz.drv/quartzdrv_main.c +++ b/dlls/winemac.drv/macdrv_main.c @@ -1,5 +1,5 @@ /* - * QUARTZDRV initialization code + * MACDRV initialization code * * Copyright 1998 Patrik Stridvall * Copyright 2000 Alexandre Julliard @@ -27,7 +27,7 @@ #include "winreg.h" /*********************************************************************** - * QUARTZDRV initialisation routine + * MACDRV initialisation routine */ BOOL WINAPI DllMain( HINSTANCE hinst, DWORD reason, LPVOID reserved ) { diff --git a/dlls/winequartz.drv/winequartz.drv.spec b/dlls/winemac.drv/winemac.drv.spec similarity index 100% rename from dlls/winequartz.drv/winequartz.drv.spec rename to dlls/winemac.drv/winemac.drv.spec
1
0
0
0
← Newer
1
...
18
19
20
21
22
23
24
...
55
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
Results per page:
10
25
50
100
200