winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
February 2012
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
442 discussions
Start a n
N
ew thread
Frédéric Delanoy : po: Fix some trailing ellipses errors in Russian translation.
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: ed3c69091054505a199683d321940013cc7ba533 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ed3c69091054505a199683d32…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Feb 7 00:35:18 2012 +0100 po: Fix some trailing ellipses errors in Russian translation. --- po/ru.po | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/po/ru.po b/po/ru.po index 4bc676f..61e20a3 100644 --- a/po/ru.po +++ b/po/ru.po @@ -6751,7 +6751,7 @@ msgstr "&Настройки..." #: msvfw32.rc:40 msgid "&About" -msgstr "&Информация..." +msgstr "&Информация" #: msvfw32.rc:44 msgid "Compression &Quality:" @@ -10765,7 +10765,7 @@ msgstr "&Создать..." #: progman.rc:31 msgid "O&pen\tEnter" -msgstr "О&ткрыть...\tEnter" +msgstr "О&ткрыть\tEnter" #: progman.rc:32 winefile.rc:27 msgid "&Move...\tF7"
1
0
0
0
Frédéric Delanoy : po: Fix some trailing ellipses errors in Japanese translation.
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: 7accb957a3c444c119a38e898b5d1edc27229d99 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7accb957a3c444c119a38e898…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Feb 7 00:35:13 2012 +0100 po: Fix some trailing ellipses errors in Japanese translation. --- po/ja.po | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/po/ja.po b/po/ja.po index aa9157f..5e1a7be 100644 --- a/po/ja.po +++ b/po/ja.po @@ -2174,7 +2174,7 @@ msgstr "ファイル名(&F):" #: cryptui.rc:293 cryptui.rc:315 cryptui.rc:429 winecfg.rc:295 msgid "B&rowse..." -msgstr "参照(&R)" +msgstr "参照(&R)..." #: cryptui.rc:294 msgid "" @@ -3177,7 +3177,7 @@ msgstr "ウィンドウ(&W)" #: ieframe.rc:31 view.rc:30 winhlp32.rc:29 msgid "&Open..." -msgstr "開く(&O)" +msgstr "開く(&O)..." #: ieframe.rc:33 notepad.rc:30 wordpad.rc:31 msgid "Save &as..."
1
0
0
0
Frédéric Delanoy : po: Fix some trailing ellipses errors in Italian translation.
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: 6900853f91c1e1da66f69156a88e813e1c2da600 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6900853f91c1e1da66f69156a…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Feb 7 00:35:12 2012 +0100 po: Fix some trailing ellipses errors in Italian translation. --- po/it.po | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/po/it.po b/po/it.po index 8256063..088d8d4 100644 --- a/po/it.po +++ b/po/it.po @@ -10828,7 +10828,7 @@ msgstr "&Copia...\tF8" #: progman.rc:35 msgid "&Properties\tAlt+Enter" -msgstr "Propri&età...\tAlt+Invio" +msgstr "Propri&età\tAlt+Invio" #: progman.rc:37 msgid "&Execute..." @@ -13326,7 +13326,7 @@ msgstr "Ri&nomina..." #: winefile.rc:31 msgid "Propert&ies\tAlt+Enter" -msgstr "Propri&età...\tAlt+Invio" +msgstr "Propri&età\tAlt+Invio" #: winefile.rc:33 msgid "&Run..."
1
0
0
0
Frédéric Delanoy : po: Fix some trailing ellipses errors in Brazilian Portuguese translation.
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: 78ce1bd0c3e6f022f324eb517e753578128209e3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=78ce1bd0c3e6f022f324eb517…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Feb 7 00:35:10 2012 +0100 po: Fix some trailing ellipses errors in Brazilian Portuguese translation. --- po/pt_BR.po | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/po/pt_BR.po b/po/pt_BR.po index dfcf031..cdee8a5 100644 --- a/po/pt_BR.po +++ b/po/pt_BR.po @@ -10818,7 +10818,7 @@ msgstr "&Copiar...\tF8" #: progman.rc:35 msgid "&Properties\tAlt+Enter" -msgstr "&Propriedades...\tAlt+Enter" +msgstr "&Propriedades\tAlt+Enter" #: progman.rc:37 msgid "&Execute..."
1
0
0
0
Frédéric Delanoy : po: Update French translation.
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: e050861907b43a692380be99856ec068146114bd URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e050861907b43a692380be998…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Mon Feb 6 23:40:37 2012 +0100 po: Update French translation. --- po/fr.po | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/po/fr.po b/po/fr.po index 7b72e31..11a37ae 100644 --- a/po/fr.po +++ b/po/fr.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To:
http://bugs.winehq.org\n
" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2012-01-26 22:30+0100\n" +"PO-Revision-Date: 2012-02-06 23:40+0100\n" "Last-Translator: Frédéric Delanoy <frederic.delanoy(a)gmail.com>\n" "Language-Team: none\n" "Language: French\n" @@ -2966,7 +2966,7 @@ msgstr "Actions" #: dinput.rc:51 msgid "Mapping" -msgstr "Mapping" +msgstr "Configuration" #: dinput.rc:53 msgid "Show Assigned First" @@ -13124,11 +13124,11 @@ msgstr "Menu contextuel" #: wineconsole.rc:67 msgid "&Control" -msgstr "&Control" +msgstr "&Contrôle" #: wineconsole.rc:68 msgid "S&hift" -msgstr "S&hift" +msgstr "Ma&j" #: wineconsole.rc:69 msgid "Quick edit"
1
0
0
0
Aric Stewart : gdi32: Keep our internal generated system links separate and append them to any user defined system links .
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: e7a79b5565803f4d38d5c54276579ea589e50246 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e7a79b5565803f4d38d5c5427…
Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Feb 7 07:18:34 2012 -0600 gdi32: Keep our internal generated system links separate and append them to any user defined system links. --- dlls/gdi32/freetype.c | 102 ++++++++++++++++++++++++++++++++++++++++++++++-- 1 files changed, 97 insertions(+), 5 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index afbc971..ce9556d 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -532,6 +532,10 @@ static const WCHAR system_link[] = {'S','o','f','t','w','a','r','e','\\','M','i' 'C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\','F','o','n','t','L','i','n','k','\\', 'S','y','s','t','e','m','L','i','n','k',0}; +static const WCHAR internal_system_link[] = {'S','o','f','t','w','a','r','e','\\','W','i','n','e','\\', + 'F','o','n','t','L','i','n','k','\\', + 'S','y','s','t','e','m','L','i','n','k',0}; + /**************************************** * Notes on .fon files * @@ -2007,6 +2011,97 @@ static BOOL init_system_links(void) RegCloseKey(hkey); } + if(RegOpenKeyW(HKEY_CURRENT_USER, internal_system_link, &hkey) == ERROR_SUCCESS) + { + RegQueryInfoKeyW(hkey, NULL, NULL, NULL, NULL, NULL, NULL, NULL, &max_val, &max_data, NULL, NULL); + value = HeapAlloc(GetProcessHeap(), 0, (max_val + 1) * sizeof(WCHAR)); + data = HeapAlloc(GetProcessHeap(), 0, max_data); + val_len = max_val + 1; + data_len = max_data; + index = 0; + while(RegEnumValueW(hkey, index++, value, &val_len, NULL, &type, (LPBYTE)data, &data_len) == ERROR_SUCCESS) + { + BOOL existing = FALSE; + memset(&fs, 0, sizeof(fs)); + psub = get_font_subst(&font_subst_list, value, -1); + /* Don't store fonts that are only substitutes for other fonts */ + if(psub) + { + TRACE("%s: Internal SystemLink entry for substituted font, ignoring\n", debugstr_w(value)); + goto next_internal; + } + + LIST_FOR_EACH_ENTRY(font_link, &system_links, SYSTEM_LINKS, entry) + { + if(!strcmpiW(font_link->font_name, value)) + { + existing = TRUE; + break; + } + } + + if (!existing) + { + font_link = HeapAlloc(GetProcessHeap(), 0, sizeof(*font_link)); + font_link->font_name = strdupW(value); + list_init(&font_link->links); + } + + for(entry = data; (char*)entry < (char*)data + data_len && *entry != 0; entry = next) + { + WCHAR *face_name; + CHILD_FONT *child_font; + + TRACE("Internal entry %s: %s\n", debugstr_w(value), debugstr_w(entry)); + + next = entry + strlenW(entry) + 1; + + face_name = strchrW(entry, ','); + if(face_name) + { + *face_name++ = 0; + while(isspaceW(*face_name)) + face_name++; + + psub = get_font_subst(&font_subst_list, face_name, -1); + if(psub) + face_name = psub->to.name; + } + face = find_face_from_filename(entry, face_name); + if(!face) + { + TRACE("Unable to find file %s face name %s\n", debugstr_w(entry), debugstr_w(face_name)); + continue; + } + + child_font = HeapAlloc(GetProcessHeap(), 0, sizeof(*child_font)); + child_font->face = face; + child_font->font = NULL; + fs.fsCsb[0] |= face->fs.fsCsb[0]; + fs.fsCsb[1] |= face->fs.fsCsb[1]; + TRACE("Adding file %s index %ld\n", child_font->face->file, child_font->face->face_index); + list_add_tail(&font_link->links, &child_font->entry); + } + family = find_family_from_name(font_link->font_name); + if(family) + { + LIST_FOR_EACH_ENTRY(face, &family->faces, Face, entry) + { + face->fs_links = fs; + } + } + if (!existing) + list_add_tail(&system_links, &font_link->entry); + next_internal: + val_len = max_val + 1; + data_len = max_data; + } + + HeapFree(GetProcessHeap(), 0, value); + HeapFree(GetProcessHeap(), 0, data); + RegCloseKey(hkey); + } + /* Explicitly add an entry for the system font, this links to Tahoma and any links that Tahoma has */ @@ -2798,9 +2893,6 @@ static void update_font_info(void) } if (!done) FIXME("there is no font defaults for codepages %u,%u\n", ansi_cp, oem_cp); - - /* Clear out system links */ - RegDeleteKeyW(HKEY_LOCAL_MACHINE, system_link); } static void populate_system_links(HKEY hkey, const WCHAR *name, const WCHAR *const *values) @@ -2885,7 +2977,7 @@ static void update_system_links(void) static const WCHAR MS_Shell_Dlg[] = {'M','S',' ','S','h','e','l','l',' ','D','l','g',0}; - if (!RegCreateKeyExW(HKEY_LOCAL_MACHINE, system_link, 0, NULL, 0, KEY_ALL_ACCESS, NULL, &hkey, &disposition)) + if (!RegCreateKeyExW(HKEY_CURRENT_USER, internal_system_link, 0, NULL, REG_OPTION_VOLATILE, KEY_ALL_ACCESS, NULL, &hkey, &disposition)) { if (disposition == REG_OPENED_EXISTING_KEY) { @@ -2924,7 +3016,7 @@ static void update_system_links(void) if (!done) WARN("there is no SystemLink default list for MS Shell Dlg %s\n", debugstr_w(psub->to.name)); } else - WARN("failed to create SystemLink key\n"); + WARN("failed to create Internal SystemLink key\n"); }
1
0
0
0
Huw Davies : oleaut32: [restricted] members with negative dispids may still be called.
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: 0425a110d92ba61fcb3638443bc7782c9dbd7cde URL:
http://source.winehq.org/git/wine.git/?a=commit;h=0425a110d92ba61fcb3638443…
Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Feb 7 14:28:05 2012 +0000 oleaut32: [restricted] members with negative dispids may still be called. --- dlls/oleaut32/tests/tmarshal.c | 38 ++++++++++++++++++++++++++++++++ dlls/oleaut32/tests/tmarshal.idl | 6 +++++ dlls/oleaut32/tests/tmarshal_dispids.h | 2 + dlls/oleaut32/typelib.c | 7 +++++- 4 files changed, 52 insertions(+), 1 deletions(-) diff --git a/dlls/oleaut32/tests/tmarshal.c b/dlls/oleaut32/tests/tmarshal.c index 2fbc2e0..e261464 100644 --- a/dlls/oleaut32/tests/tmarshal.c +++ b/dlls/oleaut32/tests/tmarshal.c @@ -660,6 +660,20 @@ static HRESULT WINAPI Widget_put_prop_req_arg( return S_OK; } +static HRESULT WINAPI Widget_restrict(IWidget* iface, INT *i) +{ + trace("restrict\n"); + *i = DISPID_TM_RESTRICTED; + return S_OK; +} + +static HRESULT WINAPI Widget_neg_restrict(IWidget* iface, INT *i) +{ + trace("neg_restrict\n"); + *i = DISPID_TM_NEG_RESTRICTED; + return S_OK; +} + static const struct IWidgetVtbl Widget_VTable = { Widget_QueryInterface, @@ -696,6 +710,8 @@ static const struct IWidgetVtbl Widget_VTable = Widget_ByRefUInt, Widget_put_prop_opt_arg, Widget_put_prop_req_arg, + Widget_restrict, + Widget_neg_restrict }; static HRESULT WINAPI StaticWidget_QueryInterface(IStaticWidget *iface, REFIID riid, void **ppvObject) @@ -1511,6 +1527,28 @@ static void test_typelibmarshal(void) ok_ole_success(hr, ITypeInfo_Invoke); VariantClear(&varresult); + /* restricted member */ + dispparams.cNamedArgs = 0; + dispparams.rgdispidNamedArgs = NULL; + dispparams.cArgs = 0; + dispparams.rgvarg = NULL; + VariantInit(&varresult); + hr = IDispatch_Invoke(pDispatch, DISPID_TM_RESTRICTED, &IID_NULL, 0x40c, DISPATCH_METHOD, &dispparams, &varresult, &excepinfo, NULL); + ok( hr == DISP_E_MEMBERNOTFOUND, "got %08x\n", hr ); + VariantClear(&varresult); + + /* restricted member with -ve memid (not restricted) */ + dispparams.cNamedArgs = 0; + dispparams.rgdispidNamedArgs = NULL; + dispparams.cArgs = 0; + dispparams.rgvarg = NULL; + VariantInit(&varresult); + hr = IDispatch_Invoke(pDispatch, DISPID_TM_NEG_RESTRICTED, &IID_NULL, 0x40c, DISPATCH_METHOD, &dispparams, &varresult, &excepinfo, NULL); + ok( hr == S_OK, "got %08x\n", hr ); + ok(V_VT(&varresult) == VT_I4, "got %x\n", V_VT(&varresult)); + ok(V_I4(&varresult) == DISPID_TM_NEG_RESTRICTED, "got %x\n", V_I4(&varresult)); + VariantClear(&varresult); + IDispatch_Release(pDispatch); IWidget_Release(pWidget); diff --git a/dlls/oleaut32/tests/tmarshal.idl b/dlls/oleaut32/tests/tmarshal.idl index 30b6d8f..88c13bf 100644 --- a/dlls/oleaut32/tests/tmarshal.idl +++ b/dlls/oleaut32/tests/tmarshal.idl @@ -149,6 +149,12 @@ library TestTypelib [id(DISPID_TM_PROP_REQ_ARG), propput] HRESULT prop_req_arg([in] INT req, [in] INT i); + + [id(DISPID_TM_RESTRICTED), restricted] + HRESULT restrict([out, retval] INT *i); + + [id(DISPID_TM_NEG_RESTRICTED), restricted] + HRESULT neg_restrict([out, retval] INT *i); } [ diff --git a/dlls/oleaut32/tests/tmarshal_dispids.h b/dlls/oleaut32/tests/tmarshal_dispids.h index 0e49505..8570fe9 100644 --- a/dlls/oleaut32/tests/tmarshal_dispids.h +++ b/dlls/oleaut32/tests/tmarshal_dispids.h @@ -41,6 +41,8 @@ #define DISPID_TM_PROP_OPT_ARG 22 #define DISPID_TM_PROP_REQ_ARG 23 #define DISPID_TM_VARCARRAY 24 +#define DISPID_TM_RESTRICTED 25 +#define DISPID_TM_NEG_RESTRICTED -26 #define DISPID_NOA_BSTRRET 1 #define DISPID_NOA_ERROR 2 diff --git a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c index 07e294b..95cdc36 100644 --- a/dlls/oleaut32/typelib.c +++ b/dlls/oleaut32/typelib.c @@ -6241,6 +6241,11 @@ DispCallFunc( #endif } +static inline BOOL func_restricted( const FUNCDESC *desc ) +{ + return (desc->wFuncFlags & FUNCFLAG_FRESTRICTED) && (desc->memid >= 0); +} + #define INVBUF_ELEMENT_SIZE \ (sizeof(VARIANTARG) + sizeof(VARIANTARG) + sizeof(VARIANTARG *) + sizeof(VARTYPE)) #define INVBUF_GET_ARG_ARRAY(buffer, params) (buffer) @@ -6297,7 +6302,7 @@ static HRESULT WINAPI ITypeInfo_fnInvoke( pFuncInfo = &This->funcdescs[fdc]; if ((memid == pFuncInfo->funcdesc.memid) && (wFlags & pFuncInfo->funcdesc.invkind) && - (pFuncInfo->funcdesc.wFuncFlags & FUNCFLAG_FRESTRICTED) == 0) + !func_restricted( &pFuncInfo->funcdesc )) break; }
1
0
0
0
Huw Davies : ole32: Don't hold a ref to the drop target in the wrapper. Apps tend to destroy the target object without calling RevokeDragDrop.
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: 5c8edb0449f6c261b9d7d1756011a08decd4c081 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5c8edb0449f6c261b9d7d1756…
Author: Huw Davies <huw(a)codeweavers.com> Date: Tue Feb 7 12:02:26 2012 +0000 ole32: Don't hold a ref to the drop target in the wrapper. Apps tend to destroy the target object without calling RevokeDragDrop. --- dlls/ole32/ole2.c | 72 +++++++++++++++++++++++++++++++++++++++-------------- 1 files changed, 53 insertions(+), 19 deletions(-) diff --git a/dlls/ole32/ole2.c b/dlls/ole32/ole2.c index b449a76..cb667c9 100644 --- a/dlls/ole32/ole2.c +++ b/dlls/ole32/ole2.c @@ -382,10 +382,12 @@ static HRESULT create_stream_from_map(HANDLE map, IStream **stream) * IDropTarget::QueryInterface(). Windows doesn't expose this because it * doesn't call CoMarshallInterface() in RegisterDragDrop(). * The wrapper is only used internally, and only exists for the life of - * the marshal. */ + * the marshal. We don't want to hold a ref on the app provided target + * as some apps destroy this prior to CoUninitialize without calling + * RevokeDragDrop. The only (long-term) ref is held by the window prop. */ typedef struct { IDropTarget IDropTarget_iface; - IDropTarget* inner; + HWND hwnd; LONG refs; } DropTargetWrapper; @@ -420,22 +422,34 @@ static ULONG WINAPI DropTargetWrapper_Release(IDropTarget* iface) { DropTargetWrapper* This = impl_from_IDropTarget(iface); ULONG refs = InterlockedDecrement(&This->refs); - if (!refs) - { - IDropTarget_Release(This->inner); - HeapFree(GetProcessHeap(), 0, This); - } + if (!refs) HeapFree(GetProcessHeap(), 0, This); return refs; } +static inline HRESULT get_target_from_wrapper( IDropTarget *wrapper, IDropTarget **target ) +{ + DropTargetWrapper* This = impl_from_IDropTarget( wrapper ); + *target = GetPropW( This->hwnd, prop_oledroptarget ); + if (!*target) return DRAGDROP_E_NOTREGISTERED; + IDropTarget_AddRef( *target ); + return S_OK; +} + static HRESULT WINAPI DropTargetWrapper_DragEnter(IDropTarget* iface, IDataObject* pDataObj, DWORD grfKeyState, POINTL pt, DWORD* pdwEffect) { - DropTargetWrapper* This = impl_from_IDropTarget(iface); - return IDropTarget_DragEnter(This->inner, pDataObj, grfKeyState, pt, pdwEffect); + IDropTarget *target; + HRESULT r = get_target_from_wrapper( iface, &target ); + + if (SUCCEEDED( r )) + { + r = IDropTarget_DragEnter( target, pDataObj, grfKeyState, pt, pdwEffect ); + IDropTarget_Release( target ); + } + return r; } static HRESULT WINAPI DropTargetWrapper_DragOver(IDropTarget* iface, @@ -443,14 +457,28 @@ static HRESULT WINAPI DropTargetWrapper_DragOver(IDropTarget* iface, POINTL pt, DWORD* pdwEffect) { - DropTargetWrapper* This = impl_from_IDropTarget(iface); - return IDropTarget_DragOver(This->inner, grfKeyState, pt, pdwEffect); + IDropTarget *target; + HRESULT r = get_target_from_wrapper( iface, &target ); + + if (SUCCEEDED( r )) + { + r = IDropTarget_DragOver( target, grfKeyState, pt, pdwEffect ); + IDropTarget_Release( target ); + } + return r; } static HRESULT WINAPI DropTargetWrapper_DragLeave(IDropTarget* iface) { - DropTargetWrapper* This = impl_from_IDropTarget(iface); - return IDropTarget_DragLeave(This->inner); + IDropTarget *target; + HRESULT r = get_target_from_wrapper( iface, &target ); + + if (SUCCEEDED( r )) + { + r = IDropTarget_DragLeave( target ); + IDropTarget_Release( target ); + } + return r; } static HRESULT WINAPI DropTargetWrapper_Drop(IDropTarget* iface, @@ -459,8 +487,15 @@ static HRESULT WINAPI DropTargetWrapper_Drop(IDropTarget* iface, POINTL pt, DWORD* pdwEffect) { - DropTargetWrapper* This = impl_from_IDropTarget(iface); - return IDropTarget_Drop(This->inner, pDataObj, grfKeyState, pt, pdwEffect); + IDropTarget *target; + HRESULT r = get_target_from_wrapper( iface, &target ); + + if (SUCCEEDED( r )) + { + r = IDropTarget_Drop( target, pDataObj, grfKeyState, pt, pdwEffect ); + IDropTarget_Release( target ); + } + return r; } static const IDropTargetVtbl DropTargetWrapperVTbl = @@ -474,15 +509,14 @@ static const IDropTargetVtbl DropTargetWrapperVTbl = DropTargetWrapper_Drop }; -static IDropTarget* WrapDropTarget(IDropTarget* inner) +static IDropTarget* WrapDropTarget( HWND hwnd ) { DropTargetWrapper* This = HeapAlloc(GetProcessHeap(), 0, sizeof(*This)); if (This) { - IDropTarget_AddRef(inner); This->IDropTarget_iface.lpVtbl = &DropTargetWrapperVTbl; - This->inner = inner; + This->hwnd = hwnd; This->refs = 1; } return &This->IDropTarget_iface; @@ -562,7 +596,7 @@ HRESULT WINAPI RegisterDragDrop(HWND hwnd, LPDROPTARGET pDropTarget) if(FAILED(hr)) return hr; /* IDropTarget::QueryInterface() shouldn't be called, some (broken) apps depend on this. */ - wrapper = WrapDropTarget(pDropTarget); + wrapper = WrapDropTarget( hwnd ); if(!wrapper) { IStream_Release(stream);
1
0
0
0
Michael Stefaniuc : inetcpl.cpl: Remove an obsolete resource attribute.
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: 8116d8a53d7467381a26f42d62ba2715b2b8c3c6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8116d8a53d7467381a26f42d6…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Feb 7 10:09:59 2012 +0100 inetcpl.cpl: Remove an obsolete resource attribute. --- dlls/inetcpl.cpl/inetcpl.rc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/inetcpl.cpl/inetcpl.rc b/dlls/inetcpl.cpl/inetcpl.rc index 49ef5e6..f6ecaac 100644 --- a/dlls/inetcpl.cpl/inetcpl.rc +++ b/dlls/inetcpl.cpl/inetcpl.rc @@ -23,7 +23,7 @@ LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT -STRINGTABLE DISCARDABLE +STRINGTABLE BEGIN IDS_CPL_NAME "Internet Settings" IDS_CPL_INFO "Configure Wine Internet Browser and related settings"
1
0
0
0
Michael Stefaniuc : comctl32: Remove an obsolete resource attribute.
by Alexandre Julliard
07 Feb '12
07 Feb '12
Module: wine Branch: master Commit: 482a5746eec602cfbbbe925288a1ef3b127538ee URL:
http://source.winehq.org/git/wine.git/?a=commit;h=482a5746eec602cfbbbe92528…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Feb 7 10:18:59 2012 +0100 comctl32: Remove an obsolete resource attribute. --- dlls/comctl32/tests/rsrc.rc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/comctl32/tests/rsrc.rc b/dlls/comctl32/tests/rsrc.rc index 76b3642..34b8362 100644 --- a/dlls/comctl32/tests/rsrc.rc +++ b/dlls/comctl32/tests/rsrc.rc @@ -64,7 +64,7 @@ FONT 8, "MS Shell Dlg" LTEXT "This has been a test property sheet!", -1, 10, 6, 170, 8 } -IDD_PROP_PAGE_MESSAGE_TEST DIALOG DISCARDABLE 0, 0, 339, 179 +IDD_PROP_PAGE_MESSAGE_TEST DIALOG 0, 0, 339, 179 STYLE DS_MODALFRAME | DS_3DLOOK | DS_CENTER | WS_CHILD | WS_VISIBLE | WS_CAPTION | WS_SYSMENU CAPTION "Message Test" BEGIN
1
0
0
0
← Newer
1
...
33
34
35
36
37
38
39
...
45
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
Results per page:
10
25
50
100
200