wine-commits March 2012

wine-commits@winehq.org

3 participants
710 discussions

Henri Verbeet : d3d9: Don' t return a pointer to the implementation in IDirect3DVolume9Impl_QueryInterface ().
by Alexandre Julliard 28 Mar '12

28 Mar '12

Module: wine Branch: master Commit: ad0980c65541b9ab04e684b9615fdeb1465e0fa0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ad0980c65541b9ab04e684b96… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Mar 27 20:35:52 2012 +0200 d3d9: Don't return a pointer to the implementation in IDirect3DVolume9Impl_QueryInterface(). --- dlls/d3d9/volume.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/d3d9/volume.c b/dlls/d3d9/volume.c index 58e7827..7814b93 100644 --- a/dlls/d3d9/volume.c +++ b/dlls/d3d9/volume.c @@ -32,18 +32,18 @@ static inline IDirect3DVolume9Impl *impl_from_IDirect3DVolume9(IDirect3DVolume9 static HRESULT WINAPI IDirect3DVolume9Impl_QueryInterface(IDirect3DVolume9 *iface, REFIID riid, void **ppobj) { - IDirect3DVolume9Impl *This = impl_from_IDirect3DVolume9(iface); - TRACE("iface %p, riid %s, object %p.\n", iface, debugstr_guid(riid), ppobj); - if (IsEqualGUID(riid, &IID_IUnknown) - || IsEqualGUID(riid, &IID_IDirect3DVolume9)) { + if (IsEqualGUID(riid, &IID_IDirect3DVolume9) + || IsEqualGUID(riid, &IID_IUnknown)) + { IDirect3DVolume9_AddRef(iface); - *ppobj = This; + *ppobj = iface; return S_OK; } - WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj); + WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(riid)); + *ppobj = NULL; return E_NOINTERFACE; }

1 0

Henri Verbeet : d3d9: Don' t return a pointer to the implementation in IDirect3DVolumeTexture9Impl_QueryInterface ().
by Alexandre Julliard 28 Mar '12

28 Mar '12

Module: wine Branch: master Commit: 8db93e2a551d973f79ece1faa9cea29e5caa3984 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8db93e2a551d973f79ece1faa… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Mar 27 20:35:51 2012 +0200 d3d9: Don't return a pointer to the implementation in IDirect3DVolumeTexture9Impl_QueryInterface(). --- dlls/d3d9/volumetexture.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/d3d9/volumetexture.c b/dlls/d3d9/volumetexture.c index d6d625b..03a467f 100644 --- a/dlls/d3d9/volumetexture.c +++ b/dlls/d3d9/volumetexture.c @@ -32,20 +32,20 @@ static inline IDirect3DVolumeTexture9Impl *impl_from_IDirect3DVolumeTexture9(IDi static HRESULT WINAPI IDirect3DVolumeTexture9Impl_QueryInterface(IDirect3DVolumeTexture9 *iface, REFIID riid, void **ppobj) { - IDirect3DVolumeTexture9Impl *This = impl_from_IDirect3DVolumeTexture9(iface); - TRACE("iface %p, riid %s, object %p.\n", iface, debugstr_guid(riid), ppobj); - if (IsEqualGUID(riid, &IID_IUnknown) - || IsEqualGUID(riid, &IID_IDirect3DResource9) - || IsEqualGUID(riid, &IID_IDirect3DBaseTexture9) - || IsEqualGUID(riid, &IID_IDirect3DVolumeTexture9)) { + if (IsEqualGUID(riid, &IID_IDirect3DVolumeTexture9) + || IsEqualGUID(riid, &IID_IDirect3DBaseTexture9) + || IsEqualGUID(riid, &IID_IDirect3DResource9) + || IsEqualGUID(riid, &IID_IUnknown)) + { IDirect3DVolumeTexture9_AddRef(iface); - *ppobj = This; + *ppobj = iface; return S_OK; } - WARN("(%p)->(%s,%p),not found\n", This, debugstr_guid(riid), ppobj); + WARN("%s not implemented, returning E_NOINTERFACE.\n", debugstr_guid(riid)); + *ppobj = NULL; return E_NOINTERFACE; }

1 0

Henri Verbeet : d3d9: Store an implementation pointer to the d3d9 structure in IDirect3DDevice9Impl .
by Alexandre Julliard 28 Mar '12

28 Mar '12

Module: wine Branch: master Commit: cbc3e9985c92658ad786be12f878e6862841a80e URL: http://source.winehq.org/git/wine.git/?a=commit;h=cbc3e9985c92658ad786be12f… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Mar 27 20:35:50 2012 +0200 d3d9: Store an implementation pointer to the d3d9 structure in IDirect3DDevice9Impl. --- dlls/d3d9/d3d9_private.h | 2 +- dlls/d3d9/device.c | 21 ++++++++------------- 2 files changed, 9 insertions(+), 14 deletions(-) diff --git a/dlls/d3d9/d3d9_private.h b/dlls/d3d9/d3d9_private.h index 5886618..7d1821c 100644 --- a/dlls/d3d9/d3d9_private.h +++ b/dlls/d3d9/d3d9_private.h @@ -165,7 +165,7 @@ typedef struct IDirect3DDevice9Impl struct wined3d_device_parent device_parent; LONG ref; struct wined3d_device *wined3d_device; - IDirect3D9Ex *d3d_parent; + struct IDirect3D9Impl *d3d_parent; /* Avoids recursion with nested ReleaseRef to 0 */ BOOL inDestruction; diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index 39cd740..ab96d79 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -190,8 +190,6 @@ static HRESULT WINAPI IDirect3DDevice9Impl_QueryInterface(IDirect3DDevice9Ex *if void **ppobj) { IDirect3DDevice9Impl *This = impl_from_IDirect3DDevice9Ex(iface); - IDirect3D9 *d3d; - IDirect3D9Impl *d3dimpl; TRACE("iface %p, riid %s, object %p.\n", iface, debugstr_guid(riid), ppobj); @@ -203,20 +201,16 @@ static HRESULT WINAPI IDirect3DDevice9Impl_QueryInterface(IDirect3DDevice9Ex *if return S_OK; } else if(IsEqualGUID(riid, &IID_IDirect3DDevice9Ex)) { /* Find out if the creating d3d9 interface was created with Direct3DCreate9Ex. - * It doesn't matter with which function the device was created. - */ - IDirect3DDevice9_GetDirect3D(iface, &d3d); - d3dimpl = (IDirect3D9Impl *) d3d; + * It doesn't matter with which function the device was created. */ - if(d3dimpl->extended) { + if (This->d3d_parent->extended) + { *ppobj = iface; IDirect3DDevice9Ex_AddRef((IDirect3DDevice9Ex *) *ppobj); - IDirect3D9_Release(d3d); TRACE("Returning IDirect3DDevice9Ex interface at %p\n", *ppobj); return S_OK; } else { WARN("IDirect3D9 instance wasn't created with CreateDirect3D9Ex, returning E_NOINTERFACE\n"); - IDirect3D9_Release(d3d); *ppobj = NULL; return E_NOINTERFACE; } @@ -265,7 +259,7 @@ static ULONG WINAPI DECLSPEC_HOTPATCH IDirect3DDevice9Impl_Release(IDirect3DDevi wined3d_device_decref(This->wined3d_device); wined3d_mutex_unlock(); - IDirect3D9_Release(This->d3d_parent); + IDirect3D9Ex_Release(&This->d3d_parent->IDirect3D9Ex_iface); HeapFree(GetProcessHeap(), 0, This); } @@ -325,7 +319,8 @@ static HRESULT WINAPI IDirect3DDevice9Impl_GetDirect3D(IDirect3DDevice9Ex *iface return D3DERR_INVALIDCALL; } - return IDirect3D9Ex_QueryInterface(This->d3d_parent, &IID_IDirect3D9, (void **)ppD3D9); + return IDirect3D9Ex_QueryInterface(&This->d3d_parent->IDirect3D9Ex_iface, + &IID_IDirect3D9, (void **)ppD3D9); } static HRESULT WINAPI IDirect3DDevice9Impl_GetDeviceCaps(IDirect3DDevice9Ex *iface, D3DCAPS9 *pCaps) @@ -3513,8 +3508,8 @@ HRESULT device_init(IDirect3DDevice9Impl *device, IDirect3D9Impl *parent, struct return E_OUTOFMEMORY; } - device->d3d_parent = &parent->IDirect3D9Ex_iface; - IDirect3D9_AddRef(device->d3d_parent); + IDirect3D9Ex_AddRef(&parent->IDirect3D9Ex_iface); + device->d3d_parent = parent; return D3D_OK; }

1 0

Henri Verbeet : winex11: Use GLX_DONT_CARE instead of ~0 in ConvertAttribWGLtoGLX().
by Alexandre Julliard 28 Mar '12

28 Mar '12

Module: wine Branch: master Commit: 22d3e6dba1a2cc3fa891be9d1121697e541860b1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=22d3e6dba1a2cc3fa891be9d1… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Mar 27 20:35:49 2012 +0200 winex11: Use GLX_DONT_CARE instead of ~0 in ConvertAttribWGLtoGLX(). --- dlls/winex11.drv/opengl.c | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c index e8d0f89..e25e082 100644 --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -680,7 +680,7 @@ static int ConvertAttribWGLtoGLX(const int* iWGLAttr, int* oGLXAttr, Wine_GLPBuf int pop; int drawattrib = 0; int nvfloatattrib = GLX_DONT_CARE; - int pixelattrib = ~0; + int pixelattrib = GLX_DONT_CARE; /* The list of WGL attributes is allowed to be NULL. We don't return here for NULL * because we need to do fixups for GLX_DRAWABLE_TYPE/GLX_RENDER_TYPE/GLX_FLOAT_COMPONENTS_NV. */ @@ -876,15 +876,15 @@ static int ConvertAttribWGLtoGLX(const int* iWGLAttr, int* oGLXAttr, Wine_GLPBuf } /* By default glXChooseFBConfig defaults to GLX_WINDOW_BIT. wglChoosePixelFormatARB searches through - * all formats. Unless drawattrib is set to a non-zero value override it with ~0, so that pixmap and pbuffer - * formats appear as well. */ - if(!drawattrib) drawattrib = ~0; + * all formats. Unless drawattrib is set to a non-zero value override it with GLX_DONT_CARE, so that + * pixmap and pbuffer formats appear as well. */ + if (!drawattrib) drawattrib = GLX_DONT_CARE; PUSH2(oGLXAttr, GLX_DRAWABLE_TYPE, drawattrib); TRACE("pAttr[?] = GLX_DRAWABLE_TYPE: %#x\n", drawattrib); /* By default glXChooseFBConfig uses GLX_RGBA_BIT as the default value. Since wglChoosePixelFormatARB - * searches in all formats we have to do the same. For this reason we set GLX_RENDER_TYPE to ~0 unless - * it is overridden. */ + * searches in all formats we have to do the same. For this reason we set GLX_RENDER_TYPE to + * GLX_DONT_CARE unless it is overridden. */ PUSH2(oGLXAttr, GLX_RENDER_TYPE, pixelattrib); TRACE("pAttr[?] = GLX_RENDER_TYPE: %#x\n", pixelattrib);

1 0

Vincent Povirk : gdiplus: Measure strings at device size, then rescale to world size.
by Alexandre Julliard 28 Mar '12

28 Mar '12

Module: wine Branch: master Commit: e2e77545fff96e52d6b3f931e40e622586777ea4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e2e77545fff96e52d6b3f931e… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Mar 27 11:44:52 2012 -0500 gdiplus: Measure strings at device size, then rescale to world size. --- dlls/gdiplus/graphics.c | 34 +++++++++++++++++++++++++++------- 1 files changed, 27 insertions(+), 7 deletions(-) diff --git a/dlls/gdiplus/graphics.c b/dlls/gdiplus/graphics.c index 89ed61b..f46d1ce 100644 --- a/dlls/gdiplus/graphics.c +++ b/dlls/gdiplus/graphics.c @@ -4943,6 +4943,7 @@ struct measure_string_args { RectF *bounds; INT *codepointsfitted; INT *linesfilled; + REAL rel_width, rel_height; }; static GpStatus measure_string_callback(HDC hdc, @@ -4952,12 +4953,16 @@ static GpStatus measure_string_callback(HDC hdc, INT underlined_index_count, void *user_data) { struct measure_string_args *args = user_data; + REAL new_width, new_height; + + new_width = bounds->Width / args->rel_width; + new_height = (bounds->Height + bounds->Y - args->bounds->Y) / args->rel_height; - if (bounds->Width > args->bounds->Width) - args->bounds->Width = bounds->Width; + if (new_width > args->bounds->Width) + args->bounds->Width = new_width; - if (bounds->Height + bounds->Y > args->bounds->Height + args->bounds->Y) - args->bounds->Height = bounds->Height + bounds->Y - args->bounds->Y; + if (new_height > args->bounds->Height) + args->bounds->Height = new_height; if (args->codepointsfitted) *args->codepointsfitted = index + length; @@ -4977,9 +4982,10 @@ GpStatus WINGDIPAPI GdipMeasureString(GpGraphics *graphics, GDIPCONST RectF *rect, GDIPCONST GpStringFormat *format, RectF *bounds, INT *codepointsfitted, INT *linesfilled) { - HFONT oldfont; + HFONT oldfont, gdifont; struct measure_string_args args; HDC temp_hdc=NULL, hdc; + GpPointF pt[3]; TRACE("(%p, %s, %i, %p, %s, %p, %p, %p, %p)\n", graphics, debugstr_wn(string, length), length, font, debugstr_rectf(rect), format, @@ -5002,7 +5008,20 @@ GpStatus WINGDIPAPI GdipMeasureString(GpGraphics *graphics, if(format) TRACE("may be ignoring some format flags: attr %x\n", format->attr); - oldfont = SelectObject(hdc, CreateFontIndirectW(&font->lfw)); + pt[0].X = 0.0; + pt[0].Y = 0.0; + pt[1].X = 1.0; + pt[1].Y = 0.0; + pt[2].X = 0.0; + pt[2].Y = 1.0; + GdipTransformPoints(graphics, CoordinateSpaceDevice, CoordinateSpaceWorld, pt, 3); + args.rel_width = sqrt((pt[1].Y-pt[0].Y)*(pt[1].Y-pt[0].Y)+ + (pt[1].X-pt[0].X)*(pt[1].X-pt[0].X)); + args.rel_height = sqrt((pt[2].Y-pt[0].Y)*(pt[2].Y-pt[0].Y)+ + (pt[2].X-pt[0].X)*(pt[2].X-pt[0].X)); + + get_font_hfont(graphics, font, &gdifont); + oldfont = SelectObject(hdc, gdifont); bounds->X = rect->X; bounds->Y = rect->Y; @@ -5016,7 +5035,8 @@ GpStatus WINGDIPAPI GdipMeasureString(GpGraphics *graphics, gdip_format_string(hdc, string, length, font, rect, format, measure_string_callback, &args); - DeleteObject(SelectObject(hdc, oldfont)); + SelectObject(hdc, oldfont); + DeleteObject(gdifont); if (temp_hdc) DeleteDC(temp_hdc);

1 0

Andrew Eikum : winmm: Report waveIn devices' component type as Microphone.
by Alexandre Julliard 28 Mar '12

28 Mar '12

Module: wine Branch: master Commit: 447b045825e1d0ba7cdeb2f75ef3935d320f97bc URL: http://source.winehq.org/git/wine.git/?a=commit;h=447b045825e1d0ba7cdeb2f75… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Tue Mar 27 11:11:11 2012 -0500 winmm: Report waveIn devices' component type as Microphone. --- dlls/winmm/waveform.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c index 3ca087e..c7d3118 100644 --- a/dlls/winmm/waveform.c +++ b/dlls/winmm/waveform.c @@ -3671,7 +3671,7 @@ static UINT WINMM_GetSourceLineInfo(WINMM_MMDevice *mmdevice, UINT mmdev_index, memcpy(info->Target.szPname, mmdevice->out_caps.szPname, sizeof(info->Target.szPname)); }else{ - info->dwComponentType = MIXERLINE_COMPONENTTYPE_SRC_LINE; + info->dwComponentType = MIXERLINE_COMPONENTTYPE_SRC_MICROPHONE; info->Target.dwType = MIXERLINE_TARGETTYPE_UNDEFINED; info->Target.szPname[0] = '\0'; } @@ -3740,7 +3740,7 @@ static UINT WINMM_GetComponentTypeLineInfo(WINMM_MMDevice *mmdevice, return WINMM_GetDestinationLineInfo(mmdevice, mmdev_index, info, flags); } - if(info->dwComponentType == MIXERLINE_COMPONENTTYPE_SRC_LINE){ + if(info->dwComponentType == MIXERLINE_COMPONENTTYPE_SRC_MICROPHONE){ if(is_out) return MIXERR_INVALLINE; info->dwSource = 0;

1 0

Andrew Eikum : winmm: Support DRVM_MAPPER_PREFERRED_GET in waveXxxMessage.
by Alexandre Julliard 28 Mar '12

28 Mar '12

Module: wine Branch: master Commit: 6a6e1bd50ea1bbef09b62f4593794959abff1a2d URL: http://source.winehq.org/git/wine.git/?a=commit;h=6a6e1bd50ea1bbef09b62f459… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Tue Mar 27 12:41:04 2012 -0500 winmm: Support DRVM_MAPPER_PREFERRED_GET in waveXxxMessage. --- dlls/winmm/tests/capture.c | 10 ++++++++++ dlls/winmm/tests/wave.c | 9 +++++++++ dlls/winmm/waveform.c | 28 ++++++++++++++++++++++++++++ 3 files changed, 47 insertions(+), 0 deletions(-) diff --git a/dlls/winmm/tests/capture.c b/dlls/winmm/tests/capture.c index 50a34c2..32deb28 100644 --- a/dlls/winmm/tests/capture.c +++ b/dlls/winmm/tests/capture.c @@ -27,6 +27,7 @@ #include "windef.h" #include "winbase.h" #include "winnls.h" +#include "mmddk.h" #include "mmsystem.h" #define NOBITMAP #include "mmreg.h" @@ -639,11 +640,20 @@ static void wave_in_tests(void) WAVEFORMATEX format; HWAVEIN win; MMRESULT rc; + DWORD preferred, status; UINT ndev,d; ndev=waveInGetNumDevs(); trace("found %d WaveIn devices\n",ndev); + rc = waveInMessage((HWAVEIN)WAVE_MAPPER, DRVM_MAPPER_PREFERRED_GET, + (DWORD_PTR)&preferred, (DWORD_PTR)&status); + ok((ndev == 0 && rc == MMSYSERR_NODRIVER) || + rc == MMSYSERR_NOERROR, "waveInMessage(DRVM_MAPPER_PREFERRED_GET) failed: %u\n", rc); + + ok((ndev == 0 && (preferred == -1 || broken(preferred != -1))) || + preferred < ndev, "Got invalid preferred device: 0x%x\n", preferred); + rc=waveInGetDevCapsA(ndev+1,&capsA,sizeof(capsA)); ok(rc==MMSYSERR_BADDEVICEID, "waveInGetDevCapsA(%s): MMSYSERR_BADDEVICEID expected, got %s\n", diff --git a/dlls/winmm/tests/wave.c b/dlls/winmm/tests/wave.c index a96d088..8a070b3 100644 --- a/dlls/winmm/tests/wave.c +++ b/dlls/winmm/tests/wave.c @@ -1378,11 +1378,20 @@ static void wave_out_tests(void) WAVEFORMATEX format; HWAVEOUT wout; MMRESULT rc; + DWORD preferred, status; UINT ndev,d; ndev=waveOutGetNumDevs(); trace("found %d WaveOut devices\n",ndev); + rc = waveOutMessage((HWAVEOUT)WAVE_MAPPER, DRVM_MAPPER_PREFERRED_GET, + (DWORD_PTR)&preferred, (DWORD_PTR)&status); + ok((ndev == 0 && rc == MMSYSERR_NODRIVER) || + rc == MMSYSERR_NOERROR, "waveOutMessage(DRVM_MAPPER_PREFERRED_GET) failed: %u\n", rc); + + ok((ndev == 0 && (preferred == -1 || broken(preferred != -1))) || + preferred < ndev, "Got invalid preferred device: 0x%x\n", preferred); + rc=waveOutGetDevCapsA(ndev+1,&capsA,sizeof(capsA)); ok(rc==MMSYSERR_BADDEVICEID, "waveOutGetDevCapsA(%s): MMSYSERR_BADDEVICEID expected, got %s\n", diff --git a/dlls/winmm/waveform.c b/dlls/winmm/waveform.c index d7d2be6..3ca087e 100644 --- a/dlls/winmm/waveform.c +++ b/dlls/winmm/waveform.c @@ -2797,6 +2797,20 @@ UINT WINAPI waveOutMessage(HWAVEOUT hWaveOut, UINT uMessage, return WINMM_QueryInstanceID(HandleToULong(hWaveOut), (WCHAR*)dwParam1, dwParam2, TRUE); case DRV_QUERYMAPPABLE: return MMSYSERR_NOERROR; + case DRVM_MAPPER_PREFERRED_GET: + if(dwParam1) { + if(g_outmmdevices_count > 0) + /* Device 0 is always the default device */ + *(DWORD *)dwParam1 = 0; + else + *(DWORD *)dwParam1 = -1; + } + + if(dwParam2) + /* Status flags */ + *(DWORD *)dwParam2 = 0; + + return MMSYSERR_NOERROR; } TRACE("Message not supported: %u\n", uMessage); @@ -3173,6 +3187,20 @@ UINT WINAPI waveInMessage(HWAVEIN hWaveIn, UINT uMessage, return WINMM_QueryInstanceID(HandleToULong(hWaveIn), (WCHAR*)dwParam1, dwParam2, FALSE); case DRV_QUERYMAPPABLE: return MMSYSERR_NOERROR; + case DRVM_MAPPER_PREFERRED_GET: + if(dwParam1) { + if(g_inmmdevices_count > 0) + /* Device 0 is always the default device */ + *(DWORD *)dwParam1 = 0; + else + *(DWORD *)dwParam1 = -1; + } + + if(dwParam2) + /* Status flags */ + *(DWORD *)dwParam2 = 0; + + return MMSYSERR_NOERROR; } TRACE("Message not supported: %u\n", uMessage);

1 0

Aric Stewart : wineqtdecoder: Implement base IQualityControl in QTOutPin.
by Alexandre Julliard 28 Mar '12

28 Mar '12

Module: wine Branch: master Commit: d2348911b73ce30985998dbd80ea797407741f74 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d2348911b73ce30985998dbd8… Author: Aric Stewart <aric(a)codeweavers.com> Date: Mon Mar 26 14:05:59 2012 -0500 wineqtdecoder: Implement base IQualityControl in QTOutPin. --- dlls/wineqtdecoder/qtsplitter.c | 50 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 50 insertions(+), 0 deletions(-) diff --git a/dlls/wineqtdecoder/qtsplitter.c b/dlls/wineqtdecoder/qtsplitter.c index e7bfa0b..ba2d05d 100644 --- a/dlls/wineqtdecoder/qtsplitter.c +++ b/dlls/wineqtdecoder/qtsplitter.c @@ -133,6 +133,7 @@ extern CLSID CLSID_QTSplitter; typedef struct QTOutPin { BaseOutputPin pin; + IQualityControl IQualityControl_iface; AM_MEDIA_TYPE * pmt; OutputQueue * queue; @@ -1246,6 +1247,8 @@ static HRESULT WINAPI QTOutPin_QueryInterface(IPin *iface, REFIID riid, void **p *ppv = iface; else if (IsEqualIID(riid, &IID_IMediaSeeking)) return IBaseFilter_QueryInterface(This->pin.pin.pinInfo.pFilter, &IID_IMediaSeeking, ppv); + else if (IsEqualIID(riid, &IID_IQualityControl)) + *ppv = &This->IQualityControl_iface; if (*ppv) { @@ -1346,6 +1349,52 @@ static const IPinVtbl QT_OutputPin_Vtbl = { BasePinImpl_NewSegment }; +static inline QTOutPin *impl_from_IQualityControl( IQualityControl *iface ) +{ + return CONTAINING_RECORD(iface, QTOutPin, IQualityControl_iface); +} + +HRESULT WINAPI QT_QualityControl_QueryInterface(IQualityControl *iface, REFIID riid, void **ppv) +{ + QTOutPin *This = impl_from_IQualityControl(iface); + return IPin_QueryInterface(&This->pin.pin.IPin_iface, riid, ppv); +} + +ULONG WINAPI QT_QualityControl_AddRef(IQualityControl *iface) +{ + QTOutPin *This = impl_from_IQualityControl(iface); + return IPin_AddRef(&This->pin.pin.IPin_iface); +} + +ULONG WINAPI QT_QualityControl_Release(IQualityControl *iface) +{ + QTOutPin *This = impl_from_IQualityControl(iface); + return IPin_Release(&This->pin.pin.IPin_iface); +} + +static HRESULT WINAPI QT_QualityControl_Notify(IQualityControl *iface, IBaseFilter *sender, Quality qm) +{ + REFERENCE_TIME late = qm.Late; + if (qm.Late < 0 && -qm.Late > qm.TimeStamp) + late = -qm.TimeStamp; + /* TODO: Do Something */ + return S_OK; +} + +HRESULT WINAPI QT_QualityControl_SetSink(IQualityControl *iface, IQualityControl *tonotify) +{ + /* Do nothing */ + return S_OK; +} + +static const IQualityControlVtbl QTOutPin_QualityControl_Vtbl = { + QT_QualityControl_QueryInterface, + QT_QualityControl_AddRef, + QT_QualityControl_Release, + QT_QualityControl_Notify, + QT_QualityControl_SetSink +}; + static const BasePinFuncTable output_BaseFuncTable = { NULL, BaseOutputPinImpl_AttemptConnection, @@ -1386,6 +1435,7 @@ static HRESULT QT_AddPin(QTSplitter *This, const PIN_INFO *piOutput, const AM_ME pin->pmt = CoTaskMemAlloc(sizeof(AM_MEDIA_TYPE)); CopyMediaType(pin->pmt, amt); pin->pin.pin.pinInfo.pFilter = (LPVOID)This; + pin->IQualityControl_iface.lpVtbl = &QTOutPin_QualityControl_Vtbl; BaseFilterImpl_IncrementPinVersion(&This->filter);

1 0

Dmitry Timoshkov : psapi: Add missing return value checks.
by Alexandre Julliard 27 Mar '12

27 Mar '12

Module: wine Branch: master Commit: 4c6a19837b7eb2477a65ab107d36405446d8c28b URL: http://source.winehq.org/git/wine.git/?a=commit;h=4c6a19837b7eb2477a65ab107… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Mar 22 16:27:26 2012 +0800 psapi: Add missing return value checks. --- dlls/psapi/tests/psapi_main.c | 22 +++++++++++++++------- 1 files changed, 15 insertions(+), 7 deletions(-) diff --git a/dlls/psapi/tests/psapi_main.c b/dlls/psapi/tests/psapi_main.c index 2087881..1944065 100644 --- a/dlls/psapi/tests/psapi_main.c +++ b/dlls/psapi/tests/psapi_main.c @@ -178,15 +178,20 @@ static void test_GetProcessMemoryInfo(void) DWORD ret; SetLastError(0xdeadbeef); - pGetProcessMemoryInfo(NULL, &pmc, sizeof(pmc)); + ret = pGetProcessMemoryInfo(NULL, &pmc, sizeof(pmc)); + ok(!ret, "GetProcessMemoryInfo should fail\n"); ok(GetLastError() == ERROR_INVALID_HANDLE, "expected error=ERROR_INVALID_HANDLE but got %d\n", GetLastError()); SetLastError(0xdeadbeef); - pGetProcessMemoryInfo(hpSR, &pmc, sizeof(pmc)); - todo_wine ok(GetLastError() == ERROR_ACCESS_DENIED, "expected error=ERROR_ACCESS_DENIED but got %d\n", GetLastError()); + ret = pGetProcessMemoryInfo(hpSR, &pmc, sizeof(pmc)); +todo_wine + ok(!ret, "GetProcessMemoryInfo should fail\n"); +todo_wine + ok(GetLastError() == ERROR_ACCESS_DENIED, "expected error=ERROR_ACCESS_DENIED but got %d\n", GetLastError()); SetLastError(0xdeadbeef); - pGetProcessMemoryInfo(hpQI, &pmc, sizeof(pmc)-1); + ret = pGetProcessMemoryInfo(hpQI, &pmc, sizeof(pmc)-1); + ok(!ret, "GetProcessMemoryInfo should fail\n"); ok(GetLastError() == ERROR_INSUFFICIENT_BUFFER, "expected error=ERROR_INSUFFICIENT_BUFFER but got %d\n", GetLastError()); SetLastError(0xdeadbeef); @@ -239,13 +244,16 @@ static void test_GetMappedFileName(void) HANDLE hfile, hmap; SetLastError(0xdeadbeef); - pGetMappedFileNameA(NULL, hMod, szMapPath, sizeof(szMapPath)); + ret = pGetMappedFileNameA(NULL, hMod, szMapPath, sizeof(szMapPath)); + ok(!ret, "GetMappedFileName should fail\n"); todo_wine ok(GetLastError() == ERROR_INVALID_HANDLE, "expected error=ERROR_INVALID_HANDLE but got %d\n", GetLastError()); SetLastError(0xdeadbeef); - pGetMappedFileNameA(hpSR, hMod, szMapPath, sizeof(szMapPath)); - todo_wine ok(GetLastError() == ERROR_ACCESS_DENIED, "expected error=ERROR_ACCESS_DENIED but got %d\n", GetLastError()); + ret = pGetMappedFileNameA(hpSR, hMod, szMapPath, sizeof(szMapPath)); + ok(!ret, "GetMappedFileName should fail\n"); +todo_wine + ok(GetLastError() == ERROR_ACCESS_DENIED, "expected error=ERROR_ACCESS_DENIED but got %d\n", GetLastError()); SetLastError( 0xdeadbeef ); ret = pGetMappedFileNameA(hpQI, hMod, szMapPath, sizeof(szMapPath));

1 0

André Hentschel : winedbg: Fix a typo.
by Alexandre Julliard 27 Mar '12

27 Mar '12

Module: wine Branch: master Commit: db8d76034d7125415ddcb0ca5896ea1e73db6bf6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=db8d76034d7125415ddcb0ca5… Author: André Hentschel <nerv(a)dawncrow.de> Date: Sun Mar 25 12:33:49 2012 +0200 winedbg: Fix a typo. --- programs/winedbg/db_disasm.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/winedbg/db_disasm.c b/programs/winedbg/db_disasm.c index e2270fc..c745617 100644 --- a/programs/winedbg/db_disasm.c +++ b/programs/winedbg/db_disasm.c @@ -1334,7 +1334,7 @@ void be_i386_disasm_one_insn(ADDRESS64 *addr, int display) struct i_addr address; /* - * Set this so we get can suppress the printout if we need to. + * Set this so we can suppress the printout if we need to. */ db_display = display; switch (addr->Mode)

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
71
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2012