wine-commits April 2012

wine-commits@winehq.org

2 participants
718 discussions

Huw Davies : wineps: Pass the devmode to OpenPrinter.
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: 83ba3189b3f669318dc9af35d5a942496268eae9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=83ba3189b3f669318dc9af35d… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Apr 12 13:03:11 2012 +0100 wineps: Pass the devmode to OpenPrinter. --- dlls/wineps.drv/escape.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/dlls/wineps.drv/escape.c b/dlls/wineps.drv/escape.c index 512dfb7..d2a8d2a 100644 --- a/dlls/wineps.drv/escape.c +++ b/dlls/wineps.drv/escape.c @@ -415,6 +415,7 @@ INT PSDRV_StartDoc( PHYSDEV dev, const DOCINFOW *doc ) { PSDRV_PDEVICE *physDev = get_psdrv_dev( dev ); DOC_INFO_1W di; + PRINTER_DEFAULTSW prn_def; TRACE("(%p, %p) => %s, %s, %s\n", physDev, doc, debugstr_w(doc->lpszDocName), debugstr_w(doc->lpszOutput), debugstr_w(doc->lpszDatatype)); @@ -424,8 +425,12 @@ INT PSDRV_StartDoc( PHYSDEV dev, const DOCINFOW *doc ) return 0; } - /* FIXME: use PRINTER_DEFAULTS here */ - if(!OpenPrinterW( physDev->pi->friendly_name, &physDev->job.hprinter, NULL )) { + prn_def.pDatatype = NULL; + prn_def.pDevMode = &physDev->pi->Devmode->dmPublic; + prn_def.DesiredAccess = PRINTER_ACCESS_USE; + + if (!OpenPrinterW( physDev->pi->friendly_name, &physDev->job.hprinter, &prn_def )) + { WARN("OpenPrinter(%s, ...) failed: %d\n", debugstr_w(physDev->pi->friendly_name), GetLastError()); return 0;

1 0

Huw Davies : wineps: Switch to using a Unicode devmode.
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: 210f3e333828917335ec219bacd2fca712a7e339 URL: http://source.winehq.org/git/wine.git/?a=commit;h=210f3e333828917335ec219ba… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Apr 12 13:03:10 2012 +0100 wineps: Switch to using a Unicode devmode. --- dlls/wineps.drv/driver.c | 69 ++++++++++++++++++++++++++++----- dlls/wineps.drv/init.c | 96 ++++++++++++--------------------------------- dlls/wineps.drv/psdrv.h | 10 ++-- 3 files changed, 90 insertions(+), 85 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=210f3e333828917335ec2…

1 0

Huw Davies : wineps: Return from a common point.
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: 0c7a6d89a26ed24b5cf100dad2e11872729945c6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0c7a6d89a26ed24b5cf100dad… Author: Huw Davies <huw(a)codeweavers.com> Date: Thu Apr 12 13:03:09 2012 +0100 wineps: Return from a common point. --- dlls/wineps.drv/driver.c | 128 +++++++++++++++++++++++++++++---------------- 1 files changed, 82 insertions(+), 46 deletions(-) diff --git a/dlls/wineps.drv/driver.c b/dlls/wineps.drv/driver.c index 83597c3..4e8774b 100644 --- a/dlls/wineps.drv/driver.c +++ b/dlls/wineps.drv/driver.c @@ -473,7 +473,8 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP if(lpszOutput != NULL) *wp++ = ps->WinPage; } - return i; + ret = i; + break; } case DC_PAPERSIZE: @@ -492,7 +493,8 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP pt++; } } - return i; + ret = i; + break; } case DC_PAPERNAMES: @@ -510,11 +512,13 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP cp += 64; } } - return i; + ret = i; + break; } case DC_ORIENTATION: - return pi->ppd->LandscapeOrientation ? pi->ppd->LandscapeOrientation : 90; + ret = pi->ppd->LandscapeOrientation ? pi->ppd->LandscapeOrientation : 90; + break; case DC_BINS: { @@ -528,7 +532,8 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP if (lpszOutput != NULL) *wp++ = slot->WinBin; } - return i; + ret = i; + break; } case DC_BINNAMES: @@ -546,12 +551,14 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP cp += 24; } } - return i; + ret = i; + break; } case DC_BINADJUST: FIXME("DC_BINADJUST: stub.\n"); - return DCBA_FACEUPNONE; + ret = DCBA_FACEUPNONE; + break; case DC_ENUMRESOLUTIONS: { @@ -561,41 +568,49 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP lp[0] = pi->ppd->DefaultResolution; lp[1] = pi->ppd->DefaultResolution; } - return 1; + ret = 1; + break; } /* Windows returns 9999 too */ case DC_COPIES: TRACE("DC_COPIES: returning 9999\n"); - return 9999; + ret = 9999; + break; case DC_DRIVER: - return lpdm->dmDriverVersion; + ret = lpdm->dmDriverVersion; + break; case DC_DATATYPE_PRODUCED: FIXME("DATA_TYPE_PRODUCED: stub.\n"); - return -1; /* simulate that the driver supports 'RAW' */ + ret = -1; /* simulate that the driver supports 'RAW' */ + break; case DC_DUPLEX: ret = 0; if(pi->ppd->DefaultDuplex && pi->ppd->DefaultDuplex->WinDuplex != 0) ret = 1; TRACE("DC_DUPLEX: returning %d\n", ret); - return ret; + break; case DC_EMF_COMPLIANT: FIXME("DC_EMF_COMPLIANT: stub.\n"); - return -1; /* simulate that the driver do not support EMF */ + ret = -1; /* simulate that the driver do not support EMF */ + break; case DC_EXTRA: - return lpdm->dmDriverExtra; + ret = lpdm->dmDriverExtra; + break; case DC_FIELDS: - return lpdm->dmFields; + ret = lpdm->dmFields; + break; case DC_FILEDEPENDENCIES: FIXME("DC_FILEDEPENDENCIES: stub.\n"); - return 0; + ret = 0; + break; case DC_MAXEXTENT: { @@ -607,7 +622,8 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP if (ps->PaperDimension->x > x) x = ps->PaperDimension->x; if (ps->PaperDimension->y > y) y = ps->PaperDimension->y; } - return MAKELONG( paper_size_from_points(x), paper_size_from_points(y) ); + ret = MAKELONG( paper_size_from_points(x), paper_size_from_points(y) ); + break; } case DC_MINEXTENT: @@ -620,50 +636,60 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP if (ps->PaperDimension->x < x) x = ps->PaperDimension->x; if (ps->PaperDimension->y < y) y = ps->PaperDimension->y; } - return MAKELONG( paper_size_from_points(x), paper_size_from_points(y) ); + ret = MAKELONG( paper_size_from_points(x), paper_size_from_points(y) ); + break; } case DC_SIZE: - return lpdm->dmSize; + ret = lpdm->dmSize; + break; case DC_TRUETYPE: FIXME("DC_TRUETYPE: stub\n"); - return DCTT_SUBDEV; + ret = DCTT_SUBDEV; + break; case DC_VERSION: - return lpdm->dmSpecVersion; + ret = lpdm->dmSpecVersion; + break; /* We'll just return false here, very few printers can collate anyway */ case DC_COLLATE: TRACE("DC_COLLATE: returning FALSE\n"); - return FALSE; + ret = FALSE; + break; /* Printer supports colour printing - 1 if yes, 0 if no (Win2k/XP only) */ case DC_COLORDEVICE: - return (pi->ppd->ColorDevice != CD_False) ? TRUE : FALSE; + ret = (pi->ppd->ColorDevice != CD_False) ? TRUE : FALSE; + break; /* Identification number of the printer manufacturer for use with ICM (Win9x only) */ case DC_MANUFACTURER: FIXME("DC_MANUFACTURER: stub\n"); - return -1; - + ret = -1; + break; + /* Identification number of the printer model for use with ICM (Win9x only) */ case DC_MODEL: FIXME("DC_MODEL: stub\n"); - return -1; - + ret = -1; + break; + /* Nonzero if the printer supports stapling, zero otherwise (Win2k/XP only) */ case DC_STAPLE: /* WINVER >= 0x0500 */ FIXME("DC_STAPLE: stub\n"); - return -1; - + ret = -1; + break; + /* Returns an array of 64-character string buffers containing the names of the paper forms * available for use, unless pOutput is NULL. The return value is the number of paper forms. * (Win2k/XP only) */ case DC_MEDIAREADY: /* WINVER >= 0x0500 */ FIXME("DC_MEDIAREADY: stub\n"); - return -1; + ret = -1; + break; /* Returns an array of 64-character string buffers containing the names of the supported * media types, unless pOutput is NULL. The return value is the number of supported. @@ -671,14 +697,16 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP */ case DC_MEDIATYPENAMES: /* WINVER >= 0x0501 */ FIXME("DC_MEDIATYPENAMES: stub\n"); - return -1; - + ret = -1; + break; + /* Returns an array of DWORD values which represent the supported media types, unless * pOutput is NULL. The return value is the number of supported media types. (XP only) */ case DC_MEDIATYPES: /* WINVER >= 0x0501 */ FIXME("DC_MEDIATYPES: stub\n"); - return -1; + ret = -1; + break; /* Returns an array of DWORD values, each representing a supported number of document * pages per printed page, unless pOutput is NULL. The return value is the number of @@ -686,8 +714,9 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP */ case DC_NUP: FIXME("DC_NUP: stub\n"); - return -1; - + ret = -1; + break; + /* Returns an array of 32-character string buffers containing a list of printer description * languages supported by the printer, unless pOutput is NULL. The return value is * number of array entries. (Win2k/XP only) @@ -695,34 +724,41 @@ DWORD PSDRV_DeviceCapabilities(LPSTR lpszDriver, LPCSTR lpszDevice, LPCSTR lpszP case DC_PERSONALITY: /* WINVER >= 0x0500 */ FIXME("DC_PERSONALITY: stub\n"); - return -1; - + ret = -1; + break; + /* Returns the amount of printer memory in kilobytes. (Win2k/XP only) */ case DC_PRINTERMEM: /* WINVER >= 0x0500 */ FIXME("DC_PRINTERMEM: stub\n"); - return -1; - + ret = -1; + break; + /* Returns the printer's print rate in PRINTRATEUNIT units. (Win2k/XP only) */ case DC_PRINTRATE: /* WINVER >= 0x0500 */ FIXME("DC_PRINTRATE: stub\n"); - return -1; - + ret = -1; + break; + /* Returns the printer's print rate in pages per minute. (Win2k/XP only) */ case DC_PRINTRATEPPM: /* WINVER >= 0x0500 */ FIXME("DC_PRINTRATEPPM: stub\n"); - return -1; - + ret = -1; + break; + /* Returns the printer rate unit used for DC_PRINTRATE, which is one of * PRINTRATEUNIT_{CPS,IPM,LPM,PPM} (Win2k/XP only) */ case DC_PRINTRATEUNIT: /* WINVER >= 0x0500 */ FIXME("DC_PRINTRATEUNIT: stub\n"); - return -1; - + ret = -1; + break; + default: FIXME("Unsupported capability %d\n", fwCapability); + ret = -1; } - return -1; + + return ret; } #if 0

1 0

Vincent Povirk : windowscodecs: Implement JpegEncoder_Frame_SetSize.
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: f5847da7141f87d0ee569a7ee76c52fed0631455 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f5847da7141f87d0ee569a7ee… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Jun 10 15:46:44 2011 -0500 windowscodecs: Implement JpegEncoder_Frame_SetSize. --- dlls/windowscodecs/jpegformat.c | 23 +++++++++++++++++++++-- 1 files changed, 21 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c index 2b4b14c..0149043 100644 --- a/dlls/windowscodecs/jpegformat.c +++ b/dlls/windowscodecs/jpegformat.c @@ -711,6 +711,8 @@ typedef struct JpegEncoder { int initialized; int frame_count; int frame_initialized; + int started_compress; + UINT width, height; IStream *stream; CRITICAL_SECTION lock; BYTE dest_buffer[1024]; @@ -834,8 +836,23 @@ static HRESULT WINAPI JpegEncoder_Frame_Initialize(IWICBitmapFrameEncode *iface, static HRESULT WINAPI JpegEncoder_Frame_SetSize(IWICBitmapFrameEncode *iface, UINT uiWidth, UINT uiHeight) { - FIXME("(%p,%u,%u): stub\n", iface, uiWidth, uiHeight); - return E_NOTIMPL; + JpegEncoder *This = impl_from_IWICBitmapFrameEncode(iface); + TRACE("(%p,%u,%u)\n", iface, uiWidth, uiHeight); + + EnterCriticalSection(&This->lock); + + if (!This->frame_initialized || This->started_compress) + { + LeaveCriticalSection(&This->lock); + return WINCODEC_ERR_WRONGSTATE; + } + + This->width = uiWidth; + This->height = uiHeight; + + LeaveCriticalSection(&This->lock); + + return S_OK; } static HRESULT WINAPI JpegEncoder_Frame_SetResolution(IWICBitmapFrameEncode *iface, @@ -1154,6 +1171,8 @@ HRESULT JpegEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) This->initialized = 0; This->frame_count = 0; This->frame_initialized = 0; + This->started_compress = 0; + This->width = This->height = 0; This->stream = NULL; InitializeCriticalSection(&This->lock); This->lock.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": JpegEncoder.lock");

1 0

Vincent Povirk : windowscodecs: Implement JpegEncoder_Frame_Initialize.
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: 1ce8a66e791d31afdbb2a1ffdf98a430ae2fab4f URL: http://source.winehq.org/git/wine.git/?a=commit;h=1ce8a66e791d31afdbb2a1ffd… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Jun 10 15:33:09 2011 -0500 windowscodecs: Implement JpegEncoder_Frame_Initialize. --- dlls/windowscodecs/jpegformat.c | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c index 50e4367..2b4b14c 100644 --- a/dlls/windowscodecs/jpegformat.c +++ b/dlls/windowscodecs/jpegformat.c @@ -710,6 +710,7 @@ typedef struct JpegEncoder { struct jpeg_destination_mgr dest_mgr; int initialized; int frame_count; + int frame_initialized; IStream *stream; CRITICAL_SECTION lock; BYTE dest_buffer[1024]; @@ -812,8 +813,22 @@ static ULONG WINAPI JpegEncoder_Frame_Release(IWICBitmapFrameEncode *iface) static HRESULT WINAPI JpegEncoder_Frame_Initialize(IWICBitmapFrameEncode *iface, IPropertyBag2 *pIEncoderOptions) { - FIXME("(%p,%p): stub\n", iface, pIEncoderOptions); - return E_NOTIMPL; + JpegEncoder *This = impl_from_IWICBitmapFrameEncode(iface); + TRACE("(%p,%p)\n", iface, pIEncoderOptions); + + EnterCriticalSection(&This->lock); + + if (This->frame_initialized) + { + LeaveCriticalSection(&This->lock); + return WINCODEC_ERR_WRONGSTATE; + } + + This->frame_initialized = TRUE; + + LeaveCriticalSection(&This->lock); + + return S_OK; } static HRESULT WINAPI JpegEncoder_Frame_SetSize(IWICBitmapFrameEncode *iface, @@ -1138,6 +1153,7 @@ HRESULT JpegEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) This->ref = 1; This->initialized = 0; This->frame_count = 0; + This->frame_initialized = 0; This->stream = NULL; InitializeCriticalSection(&This->lock); This->lock.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": JpegEncoder.lock");

1 0

Vincent Povirk : windowscodecs: Implement JpegEncoder_CreateNewFrame.
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: 7f302c81b3fe5b24ab69bcfe5bed8a095be86cef URL: http://source.winehq.org/git/wine.git/?a=commit;h=7f302c81b3fe5b24ab69bcfe5… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Jun 10 15:29:01 2011 -0500 windowscodecs: Implement JpegEncoder_CreateNewFrame. --- dlls/windowscodecs/jpegformat.c | 173 ++++++++++++++++++++++++++++++++++++++- 1 files changed, 171 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c index db5cc29..50e4367 100644 --- a/dlls/windowscodecs/jpegformat.c +++ b/dlls/windowscodecs/jpegformat.c @@ -703,11 +703,13 @@ HRESULT JpegDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) typedef struct JpegEncoder { IWICBitmapEncoder IWICBitmapEncoder_iface; + IWICBitmapFrameEncode IWICBitmapFrameEncode_iface; LONG ref; struct jpeg_compress_struct cinfo; struct jpeg_error_mgr jerr; struct jpeg_destination_mgr dest_mgr; int initialized; + int frame_count; IStream *stream; CRITICAL_SECTION lock; BYTE dest_buffer[1024]; @@ -718,6 +720,11 @@ static inline JpegEncoder *impl_from_IWICBitmapEncoder(IWICBitmapEncoder *iface) return CONTAINING_RECORD(iface, JpegEncoder, IWICBitmapEncoder_iface); } +static inline JpegEncoder *impl_from_IWICBitmapFrameEncode(IWICBitmapFrameEncode *iface) +{ + return CONTAINING_RECORD(iface, JpegEncoder, IWICBitmapFrameEncode_iface); +} + static inline JpegEncoder *encoder_from_compress(j_compress_ptr compress) { return CONTAINING_RECORD(compress, JpegEncoder, cinfo); @@ -767,6 +774,134 @@ static void dest_mgr_term_destination(j_compress_ptr cinfo) } } +static HRESULT WINAPI JpegEncoder_Frame_QueryInterface(IWICBitmapFrameEncode *iface, REFIID iid, + void **ppv) +{ + JpegEncoder *This = impl_from_IWICBitmapFrameEncode(iface); + TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); + + if (!ppv) return E_INVALIDARG; + + if (IsEqualIID(&IID_IUnknown, iid) || + IsEqualIID(&IID_IWICBitmapFrameEncode, iid)) + { + *ppv = &This->IWICBitmapFrameEncode_iface; + } + else + { + *ppv = NULL; + return E_NOINTERFACE; + } + + IUnknown_AddRef((IUnknown*)*ppv); + return S_OK; +} + +static ULONG WINAPI JpegEncoder_Frame_AddRef(IWICBitmapFrameEncode *iface) +{ + JpegEncoder *This = impl_from_IWICBitmapFrameEncode(iface); + return IWICBitmapEncoder_AddRef(&This->IWICBitmapEncoder_iface); +} + +static ULONG WINAPI JpegEncoder_Frame_Release(IWICBitmapFrameEncode *iface) +{ + JpegEncoder *This = impl_from_IWICBitmapFrameEncode(iface); + return IWICBitmapEncoder_Release(&This->IWICBitmapEncoder_iface); +} + +static HRESULT WINAPI JpegEncoder_Frame_Initialize(IWICBitmapFrameEncode *iface, + IPropertyBag2 *pIEncoderOptions) +{ + FIXME("(%p,%p): stub\n", iface, pIEncoderOptions); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_Frame_SetSize(IWICBitmapFrameEncode *iface, + UINT uiWidth, UINT uiHeight) +{ + FIXME("(%p,%u,%u): stub\n", iface, uiWidth, uiHeight); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_Frame_SetResolution(IWICBitmapFrameEncode *iface, + double dpiX, double dpiY) +{ + FIXME("(%p,%0.2f,%0.2f): stub\n", iface, dpiX, dpiY); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_Frame_SetPixelFormat(IWICBitmapFrameEncode *iface, + WICPixelFormatGUID *pPixelFormat) +{ + FIXME("(%p,%s): stub\n", iface, debugstr_guid(pPixelFormat)); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_Frame_SetColorContexts(IWICBitmapFrameEncode *iface, + UINT cCount, IWICColorContext **ppIColorContext) +{ + FIXME("(%p,%u,%p): stub\n", iface, cCount, ppIColorContext); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_Frame_SetPalette(IWICBitmapFrameEncode *iface, + IWICPalette *pIPalette) +{ + FIXME("(%p,%p): stub\n", iface, pIPalette); + return WINCODEC_ERR_UNSUPPORTEDOPERATION; +} + +static HRESULT WINAPI JpegEncoder_Frame_SetThumbnail(IWICBitmapFrameEncode *iface, + IWICBitmapSource *pIThumbnail) +{ + FIXME("(%p,%p): stub\n", iface, pIThumbnail); + return WINCODEC_ERR_UNSUPPORTEDOPERATION; +} + +static HRESULT WINAPI JpegEncoder_Frame_WritePixels(IWICBitmapFrameEncode *iface, + UINT lineCount, UINT cbStride, UINT cbBufferSize, BYTE *pbPixels) +{ + FIXME("(%p,%u,%u,%u,%p): stub\n", iface, lineCount, cbStride, cbBufferSize, pbPixels); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_Frame_WriteSource(IWICBitmapFrameEncode *iface, + IWICBitmapSource *pIBitmapSource, WICRect *prc) +{ + FIXME("(%p,%p,%p): stub\n", iface, pIBitmapSource, prc); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_Frame_Commit(IWICBitmapFrameEncode *iface) +{ + FIXME("(%p): stub\n", iface); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_Frame_GetMetadataQueryWriter(IWICBitmapFrameEncode *iface, + IWICMetadataQueryWriter **ppIMetadataQueryWriter) +{ + FIXME("(%p, %p): stub\n", iface, ppIMetadataQueryWriter); + return E_NOTIMPL; +} + +static const IWICBitmapFrameEncodeVtbl JpegEncoder_FrameVtbl = { + JpegEncoder_Frame_QueryInterface, + JpegEncoder_Frame_AddRef, + JpegEncoder_Frame_Release, + JpegEncoder_Frame_Initialize, + JpegEncoder_Frame_SetSize, + JpegEncoder_Frame_SetResolution, + JpegEncoder_Frame_SetPixelFormat, + JpegEncoder_Frame_SetColorContexts, + JpegEncoder_Frame_SetPalette, + JpegEncoder_Frame_SetThumbnail, + JpegEncoder_Frame_WritePixels, + JpegEncoder_Frame_WriteSource, + JpegEncoder_Frame_Commit, + JpegEncoder_Frame_GetMetadataQueryWriter +}; + static HRESULT WINAPI JpegEncoder_QueryInterface(IWICBitmapEncoder *iface, REFIID iid, void **ppv) { @@ -913,8 +1048,40 @@ static HRESULT WINAPI JpegEncoder_SetPreview(IWICBitmapEncoder *iface, IWICBitma static HRESULT WINAPI JpegEncoder_CreateNewFrame(IWICBitmapEncoder *iface, IWICBitmapFrameEncode **ppIFrameEncode, IPropertyBag2 **ppIEncoderOptions) { - FIXME("(%p,%p,%p): stub\n", iface, ppIFrameEncode, ppIEncoderOptions); - return E_NOTIMPL; + JpegEncoder *This = impl_from_IWICBitmapEncoder(iface); + HRESULT hr; + + TRACE("(%p,%p,%p)\n", iface, ppIFrameEncode, ppIEncoderOptions); + + EnterCriticalSection(&This->lock); + + if (This->frame_count != 0) + { + LeaveCriticalSection(&This->lock); + return WINCODEC_ERR_UNSUPPORTEDOPERATION; + } + + if (!This->initialized) + { + LeaveCriticalSection(&This->lock); + return WINCODEC_ERR_NOTINITIALIZED; + } + + hr = CreatePropertyBag2(ppIEncoderOptions); + if (FAILED(hr)) + { + LeaveCriticalSection(&This->lock); + return hr; + } + + This->frame_count = 1; + + LeaveCriticalSection(&This->lock); + + IWICBitmapEncoder_AddRef(iface); + *ppIFrameEncode = &This->IWICBitmapFrameEncode_iface; + + return S_OK; } static HRESULT WINAPI JpegEncoder_Commit(IWICBitmapEncoder *iface) @@ -967,8 +1134,10 @@ HRESULT JpegEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) if (!This) return E_OUTOFMEMORY; This->IWICBitmapEncoder_iface.lpVtbl = &JpegEncoder_Vtbl; + This->IWICBitmapFrameEncode_iface.lpVtbl = &JpegEncoder_FrameVtbl; This->ref = 1; This->initialized = 0; + This->frame_count = 0; This->stream = NULL; InitializeCriticalSection(&This->lock); This->lock.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": JpegEncoder.lock");

1 0

Vincent Povirk : windowscodecs: Implement JpegEncoder_Initialize.
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: 8a066b2c20b15432f229781e7c91b2d0d4b4d4cb URL: http://source.winehq.org/git/wine.git/?a=commit;h=8a066b2c20b15432f229781e7… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Jun 10 15:10:49 2011 -0500 windowscodecs: Implement JpegEncoder_Initialize. --- dlls/windowscodecs/jpegformat.c | 117 ++++++++++++++++++++++++++++++++++++++- 1 files changed, 115 insertions(+), 2 deletions(-) diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c index 15c4377..db5cc29 100644 --- a/dlls/windowscodecs/jpegformat.c +++ b/dlls/windowscodecs/jpegformat.c @@ -62,7 +62,9 @@ WINE_DECLARE_DEBUG_CHANNEL(jpeg); static void *libjpeg_handle; #define MAKE_FUNCPTR(f) static typeof(f) * p##f +MAKE_FUNCPTR(jpeg_CreateCompress); MAKE_FUNCPTR(jpeg_CreateDecompress); +MAKE_FUNCPTR(jpeg_destroy_compress); MAKE_FUNCPTR(jpeg_destroy_decompress); MAKE_FUNCPTR(jpeg_read_header); MAKE_FUNCPTR(jpeg_read_scanlines); @@ -81,7 +83,9 @@ static void *load_libjpeg(void) return NULL; \ } + LOAD_FUNCPTR(jpeg_CreateCompress); LOAD_FUNCPTR(jpeg_CreateDecompress); + LOAD_FUNCPTR(jpeg_destroy_compress); LOAD_FUNCPTR(jpeg_destroy_decompress); LOAD_FUNCPTR(jpeg_read_header); LOAD_FUNCPTR(jpeg_read_scanlines); @@ -700,6 +704,13 @@ HRESULT JpegDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) typedef struct JpegEncoder { IWICBitmapEncoder IWICBitmapEncoder_iface; LONG ref; + struct jpeg_compress_struct cinfo; + struct jpeg_error_mgr jerr; + struct jpeg_destination_mgr dest_mgr; + int initialized; + IStream *stream; + CRITICAL_SECTION lock; + BYTE dest_buffer[1024]; } JpegEncoder; static inline JpegEncoder *impl_from_IWICBitmapEncoder(IWICBitmapEncoder *iface) @@ -707,6 +718,55 @@ static inline JpegEncoder *impl_from_IWICBitmapEncoder(IWICBitmapEncoder *iface) return CONTAINING_RECORD(iface, JpegEncoder, IWICBitmapEncoder_iface); } +static inline JpegEncoder *encoder_from_compress(j_compress_ptr compress) +{ + return CONTAINING_RECORD(compress, JpegEncoder, cinfo); +} + +static void dest_mgr_init_destination(j_compress_ptr cinfo) +{ + JpegEncoder *This = encoder_from_compress(cinfo); + + This->dest_mgr.next_output_byte = This->dest_buffer; + This->dest_mgr.free_in_buffer = sizeof(This->dest_buffer); +} + +static jpeg_boolean dest_mgr_empty_output_buffer(j_compress_ptr cinfo) +{ + JpegEncoder *This = encoder_from_compress(cinfo); + HRESULT hr; + ULONG byteswritten; + + hr = IStream_Write(This->stream, This->dest_buffer, + sizeof(This->dest_buffer), &byteswritten); + + if (hr != S_OK || byteswritten == 0) + { + ERR("Failed writing data, hr=%x\n", hr); + return FALSE; + } + + This->dest_mgr.next_output_byte = This->dest_buffer; + This->dest_mgr.free_in_buffer = sizeof(This->dest_buffer); + return TRUE; +} + +static void dest_mgr_term_destination(j_compress_ptr cinfo) +{ + JpegEncoder *This = encoder_from_compress(cinfo); + ULONG byteswritten; + HRESULT hr; + + if (This->dest_mgr.free_in_buffer != sizeof(This->dest_buffer)) + { + hr = IStream_Write(This->stream, This->dest_buffer, + sizeof(This->dest_buffer) - This->dest_mgr.free_in_buffer, &byteswritten); + + if (hr != S_OK || byteswritten == 0) + ERR("Failed writing data, hr=%x\n", hr); + } +} + static HRESULT WINAPI JpegEncoder_QueryInterface(IWICBitmapEncoder *iface, REFIID iid, void **ppv) { @@ -749,6 +809,10 @@ static ULONG WINAPI JpegEncoder_Release(IWICBitmapEncoder *iface) if (ref == 0) { + This->lock.DebugInfo->Spare[0] = 0; + DeleteCriticalSection(&This->lock); + if (This->initialized) pjpeg_destroy_compress(&This->cinfo); + if (This->stream) IStream_Release(This->stream); HeapFree(GetProcessHeap(), 0, This); } @@ -758,8 +822,53 @@ static ULONG WINAPI JpegEncoder_Release(IWICBitmapEncoder *iface) static HRESULT WINAPI JpegEncoder_Initialize(IWICBitmapEncoder *iface, IStream *pIStream, WICBitmapEncoderCacheOption cacheOption) { - FIXME("(%p,%p,%u): stub\n", iface, pIStream, cacheOption); - return E_NOTIMPL; + JpegEncoder *This = impl_from_IWICBitmapEncoder(iface); + jmp_buf jmpbuf; + + TRACE("(%p,%p,%u)\n", iface, pIStream, cacheOption); + + EnterCriticalSection(&This->lock); + + if (This->initialized) + { + LeaveCriticalSection(&This->lock); + return WINCODEC_ERR_WRONGSTATE; + } + + pjpeg_std_error(&This->jerr); + + This->jerr.error_exit = error_exit_fn; + This->jerr.emit_message = emit_message_fn; + + This->cinfo.err = &This->jerr; + + This->cinfo.client_data = &jmpbuf; + + if (setjmp(jmpbuf)) + { + LeaveCriticalSection(&This->lock); + return E_FAIL; + } + + pjpeg_CreateCompress(&This->cinfo, JPEG_LIB_VERSION, sizeof(struct jpeg_compress_struct)); + + This->stream = pIStream; + IStream_AddRef(pIStream); + + This->dest_mgr.next_output_byte = This->dest_buffer; + This->dest_mgr.free_in_buffer = sizeof(This->dest_buffer); + + This->dest_mgr.init_destination = dest_mgr_init_destination; + This->dest_mgr.empty_output_buffer = dest_mgr_empty_output_buffer; + This->dest_mgr.term_destination = dest_mgr_term_destination; + + This->cinfo.dest = &This->dest_mgr; + + This->initialized = TRUE; + + LeaveCriticalSection(&This->lock); + + return S_OK; } static HRESULT WINAPI JpegEncoder_GetContainerFormat(IWICBitmapEncoder *iface, @@ -859,6 +968,10 @@ HRESULT JpegEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) This->IWICBitmapEncoder_iface.lpVtbl = &JpegEncoder_Vtbl; This->ref = 1; + This->initialized = 0; + This->stream = NULL; + InitializeCriticalSection(&This->lock); + This->lock.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": JpegEncoder.lock"); ret = IUnknown_QueryInterface((IUnknown*)This, iid, ppv); IUnknown_Release((IUnknown*)This);

1 0

Vincent Povirk : windowscodecs: Add stub JPEG encoder.
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: 2e2b045db0f149f79d562b94540486932dc8483b URL: http://source.winehq.org/git/wine.git/?a=commit;h=2e2b045db0f149f79d562b945… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Jun 10 14:17:17 2011 -0500 windowscodecs: Add stub JPEG encoder. --- dlls/windowscodecs/clsfactory.c | 1 + dlls/windowscodecs/jpegformat.c | 175 +++++++++++++++++++++++++ dlls/windowscodecs/regsvr.c | 9 ++ dlls/windowscodecs/wincodecs_private.h | 1 + dlls/windowscodecs/windowscodecs_wincodec.idl | 7 + 5 files changed, 193 insertions(+), 0 deletions(-) diff --git a/dlls/windowscodecs/clsfactory.c b/dlls/windowscodecs/clsfactory.c index 0f30115..9089924 100644 --- a/dlls/windowscodecs/clsfactory.c +++ b/dlls/windowscodecs/clsfactory.c @@ -53,6 +53,7 @@ static classinfo wic_classes[] = { {&CLSID_WICGifDecoder, GifDecoder_CreateInstance}, {&CLSID_WICIcoDecoder, IcoDecoder_CreateInstance}, {&CLSID_WICJpegDecoder, JpegDecoder_CreateInstance}, + {&CLSID_WICJpegEncoder, JpegEncoder_CreateInstance}, {&CLSID_WICTiffDecoder, TiffDecoder_CreateInstance}, {&CLSID_WICTiffEncoder, TiffEncoder_CreateInstance}, {&CLSID_WICIcnsEncoder, IcnsEncoder_CreateInstance}, diff --git a/dlls/windowscodecs/jpegformat.c b/dlls/windowscodecs/jpegformat.c index 0cb9fc2..15c4377 100644 --- a/dlls/windowscodecs/jpegformat.c +++ b/dlls/windowscodecs/jpegformat.c @@ -697,6 +697,175 @@ HRESULT JpegDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) return ret; } +typedef struct JpegEncoder { + IWICBitmapEncoder IWICBitmapEncoder_iface; + LONG ref; +} JpegEncoder; + +static inline JpegEncoder *impl_from_IWICBitmapEncoder(IWICBitmapEncoder *iface) +{ + return CONTAINING_RECORD(iface, JpegEncoder, IWICBitmapEncoder_iface); +} + +static HRESULT WINAPI JpegEncoder_QueryInterface(IWICBitmapEncoder *iface, REFIID iid, + void **ppv) +{ + JpegEncoder *This = impl_from_IWICBitmapEncoder(iface); + TRACE("(%p,%s,%p)\n", iface, debugstr_guid(iid), ppv); + + if (!ppv) return E_INVALIDARG; + + if (IsEqualIID(&IID_IUnknown, iid) || + IsEqualIID(&IID_IWICBitmapEncoder, iid)) + { + *ppv = This; + } + else + { + *ppv = NULL; + return E_NOINTERFACE; + } + + IUnknown_AddRef((IUnknown*)*ppv); + return S_OK; +} + +static ULONG WINAPI JpegEncoder_AddRef(IWICBitmapEncoder *iface) +{ + JpegEncoder *This = impl_from_IWICBitmapEncoder(iface); + ULONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p) refcount=%u\n", iface, ref); + + return ref; +} + +static ULONG WINAPI JpegEncoder_Release(IWICBitmapEncoder *iface) +{ + JpegEncoder *This = impl_from_IWICBitmapEncoder(iface); + ULONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p) refcount=%u\n", iface, ref); + + if (ref == 0) + { + HeapFree(GetProcessHeap(), 0, This); + } + + return ref; +} + +static HRESULT WINAPI JpegEncoder_Initialize(IWICBitmapEncoder *iface, + IStream *pIStream, WICBitmapEncoderCacheOption cacheOption) +{ + FIXME("(%p,%p,%u): stub\n", iface, pIStream, cacheOption); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_GetContainerFormat(IWICBitmapEncoder *iface, + GUID *pguidContainerFormat) +{ + FIXME("(%p,%s): stub\n", iface, debugstr_guid(pguidContainerFormat)); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_GetEncoderInfo(IWICBitmapEncoder *iface, + IWICBitmapEncoderInfo **ppIEncoderInfo) +{ + FIXME("(%p,%p): stub\n", iface, ppIEncoderInfo); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_SetColorContexts(IWICBitmapEncoder *iface, + UINT cCount, IWICColorContext **ppIColorContext) +{ + FIXME("(%p,%u,%p): stub\n", iface, cCount, ppIColorContext); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_SetPalette(IWICBitmapEncoder *iface, IWICPalette *pIPalette) +{ + TRACE("(%p,%p)\n", iface, pIPalette); + return WINCODEC_ERR_UNSUPPORTEDOPERATION; +} + +static HRESULT WINAPI JpegEncoder_SetThumbnail(IWICBitmapEncoder *iface, IWICBitmapSource *pIThumbnail) +{ + TRACE("(%p,%p)\n", iface, pIThumbnail); + return WINCODEC_ERR_UNSUPPORTEDOPERATION; +} + +static HRESULT WINAPI JpegEncoder_SetPreview(IWICBitmapEncoder *iface, IWICBitmapSource *pIPreview) +{ + TRACE("(%p,%p)\n", iface, pIPreview); + return WINCODEC_ERR_UNSUPPORTEDOPERATION; +} + +static HRESULT WINAPI JpegEncoder_CreateNewFrame(IWICBitmapEncoder *iface, + IWICBitmapFrameEncode **ppIFrameEncode, IPropertyBag2 **ppIEncoderOptions) +{ + FIXME("(%p,%p,%p): stub\n", iface, ppIFrameEncode, ppIEncoderOptions); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_Commit(IWICBitmapEncoder *iface) +{ + FIXME("(%p): stub\n", iface); + return E_NOTIMPL; +} + +static HRESULT WINAPI JpegEncoder_GetMetadataQueryWriter(IWICBitmapEncoder *iface, + IWICMetadataQueryWriter **ppIMetadataQueryWriter) +{ + FIXME("(%p,%p): stub\n", iface, ppIMetadataQueryWriter); + return E_NOTIMPL; +} + +static const IWICBitmapEncoderVtbl JpegEncoder_Vtbl = { + JpegEncoder_QueryInterface, + JpegEncoder_AddRef, + JpegEncoder_Release, + JpegEncoder_Initialize, + JpegEncoder_GetContainerFormat, + JpegEncoder_GetEncoderInfo, + JpegEncoder_SetColorContexts, + JpegEncoder_SetPalette, + JpegEncoder_SetThumbnail, + JpegEncoder_SetPreview, + JpegEncoder_CreateNewFrame, + JpegEncoder_Commit, + JpegEncoder_GetMetadataQueryWriter +}; + +HRESULT JpegEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) +{ + JpegEncoder *This; + HRESULT ret; + + TRACE("(%p,%s,%p)\n", pUnkOuter, debugstr_guid(iid), ppv); + + *ppv = NULL; + + if (pUnkOuter) return CLASS_E_NOAGGREGATION; + + if (!libjpeg_handle && !load_libjpeg()) + { + ERR("Failed writing JPEG because unable to find %s\n",SONAME_LIBJPEG); + return E_FAIL; + } + + This = HeapAlloc(GetProcessHeap(), 0, sizeof(JpegEncoder)); + if (!This) return E_OUTOFMEMORY; + + This->IWICBitmapEncoder_iface.lpVtbl = &JpegEncoder_Vtbl; + This->ref = 1; + + ret = IUnknown_QueryInterface((IUnknown*)This, iid, ppv); + IUnknown_Release((IUnknown*)This); + + return ret; +} + #else /* !defined(SONAME_LIBJPEG) */ HRESULT JpegDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) @@ -705,4 +874,10 @@ HRESULT JpegDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) return E_FAIL; } +HRESULT JpegEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) +{ + ERR("Trying to save JPEG picture, but JPEG support is not compiled in.\n"); + return E_FAIL; +} + #endif diff --git a/dlls/windowscodecs/regsvr.c b/dlls/windowscodecs/regsvr.c index 5bb4854..e81ae00 100644 --- a/dlls/windowscodecs/regsvr.c +++ b/dlls/windowscodecs/regsvr.c @@ -937,6 +937,15 @@ static struct regsvr_encoder const encoder_list[] = { ".bmp,.dib,.rle", bmp_encode_formats }, + { &CLSID_WICJpegEncoder, + "The Wine Project", + "JPEG Encoder", + "1.0.0.0", + &GUID_VendorMicrosoft, + "image/jpeg", + ".jpg;.jpeg;.jfif", + jpeg_formats + }, { &CLSID_WICPngEncoder, "The Wine Project", "PNG Encoder", diff --git a/dlls/windowscodecs/wincodecs_private.h b/dlls/windowscodecs/wincodecs_private.h index 691b1ec..ce322ef 100644 --- a/dlls/windowscodecs/wincodecs_private.h +++ b/dlls/windowscodecs/wincodecs_private.h @@ -37,6 +37,7 @@ extern HRESULT DibDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** extern HRESULT GifDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID riid, void** ppv) DECLSPEC_HIDDEN; extern HRESULT IcoDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) DECLSPEC_HIDDEN; extern HRESULT JpegDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) DECLSPEC_HIDDEN; +extern HRESULT JpegEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) DECLSPEC_HIDDEN; extern HRESULT TiffDecoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) DECLSPEC_HIDDEN; extern HRESULT TiffEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) DECLSPEC_HIDDEN; extern HRESULT IcnsEncoder_CreateInstance(IUnknown *pUnkOuter, REFIID iid, void** ppv) DECLSPEC_HIDDEN; diff --git a/dlls/windowscodecs/windowscodecs_wincodec.idl b/dlls/windowscodecs/windowscodecs_wincodec.idl index bf42679..56cf112 100644 --- a/dlls/windowscodecs/windowscodecs_wincodec.idl +++ b/dlls/windowscodecs/windowscodecs_wincodec.idl @@ -81,6 +81,13 @@ coclass WICIcoDecoder { interface IWICBitmapDecoder; } coclass WICJpegDecoder { interface IWICBitmapDecoder; } [ + helpstring("WIC JPEG Encoder"), + threading(both), + uuid(1a34f5c1-4a5a-46dc-b644-1f4567e7a676) +] +coclass WICJpegEncoder { interface IWICBitmapEncoder; } + +[ helpstring("WIC TIFF Decoder"), threading(both), uuid(b54e85d9-fe23-499f-8b88-6acea713752b)

1 0

Henri Verbeet : d3dx9: Don' t return a pointer to the implementation in ID3DXEffectImpl_QueryInterface( ).
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: cdc2c53158a5d4c3dddbd602022d3a4bdd9f453a URL: http://source.winehq.org/git/wine.git/?a=commit;h=cdc2c53158a5d4c3dddbd6020… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Apr 11 22:52:06 2012 +0200 d3dx9: Don't return a pointer to the implementation in ID3DXEffectImpl_QueryInterface(). --- dlls/d3dx9_36/effect.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index 766f311..c76bdef 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -2778,15 +2778,13 @@ static inline struct ID3DXEffectImpl *impl_from_ID3DXEffect(ID3DXEffect *iface) /*** IUnknown methods ***/ static HRESULT WINAPI ID3DXEffectImpl_QueryInterface(ID3DXEffect *iface, REFIID riid, void **object) { - struct ID3DXEffectImpl *This = impl_from_ID3DXEffect(iface); - - TRACE("(%p)->(%s, %p)\n", This, debugstr_guid(riid), object); + TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), object); if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_ID3DXEffect)) { - This->ID3DXEffect_iface.lpVtbl->AddRef(iface); - *object = This; + iface->lpVtbl->AddRef(iface); + *object = iface; return S_OK; }

1 0

Henri Verbeet : d3dx9: Don' t return a pointer to the implementation in ID3DXEffectCompilerImpl_QueryInterface ().
by Alexandre Julliard 12 Apr '12

12 Apr '12

Module: wine Branch: master Commit: 86b14209a0c1da50dd7fdb0733cc4d584b5a804a URL: http://source.winehq.org/git/wine.git/?a=commit;h=86b14209a0c1da50dd7fdb073… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Apr 11 22:52:05 2012 +0200 d3dx9: Don't return a pointer to the implementation in ID3DXEffectCompilerImpl_QueryInterface(). --- dlls/d3dx9_36/effect.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/dlls/d3dx9_36/effect.c b/dlls/d3dx9_36/effect.c index 0a07ddf..766f311 100644 --- a/dlls/d3dx9_36/effect.c +++ b/dlls/d3dx9_36/effect.c @@ -3757,15 +3757,13 @@ static inline struct ID3DXEffectCompilerImpl *impl_from_ID3DXEffectCompiler(ID3D /*** IUnknown methods ***/ static HRESULT WINAPI ID3DXEffectCompilerImpl_QueryInterface(ID3DXEffectCompiler *iface, REFIID riid, void **object) { - struct ID3DXEffectCompilerImpl *This = impl_from_ID3DXEffectCompiler(iface); - - TRACE("iface %p, riid %s, object %p\n", This, debugstr_guid(riid), object); + TRACE("iface %p, riid %s, object %p.\n", iface, debugstr_guid(riid), object); if (IsEqualGUID(riid, &IID_IUnknown) || IsEqualGUID(riid, &IID_ID3DXEffectCompiler)) { - This->ID3DXEffectCompiler_iface.lpVtbl->AddRef(iface); - *object = This; + iface->lpVtbl->AddRef(iface); + *object = iface; return S_OK; }

1 0

← Newer
1
...
39
40
41
42
43
44
45
...
72
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits April 2012