winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
June 2012
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
3 participants
827 discussions
Start a n
N
ew thread
Julian Rüger : ntprint/tests: Fix some typos.
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: 132937a4e86dc349b6cc505f564e0685dcb8084b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=132937a4e86dc349b6cc505f5…
Author: Julian Rüger <jr98(a)gmx.net> Date: Thu Jun 21 00:01:19 2012 +0200 ntprint/tests: Fix some typos. --- dlls/ntprint/tests/ntprint.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/ntprint/tests/ntprint.c b/dlls/ntprint/tests/ntprint.c index 7e1ab58..e0bc01e 100644 --- a/dlls/ntprint/tests/ntprint.c +++ b/dlls/ntprint/tests/ntprint.c @@ -71,7 +71,7 @@ static void test_PSetupCreateMonitorInfo(VOID) SetLastError(0xdeadbeef); mi = pPSetupCreateMonitorInfo(NULL, NULL, NULL); if (!mi && (GetLastError() == RPC_S_SERVER_UNAVAILABLE)) { - win_skip("The Service 'Spooler' is required for many test\n"); + win_skip("The service 'Spooler' is required for many tests\n"); return; } ok( mi != NULL, "got %p with %u (expected '!= NULL')\n", mi, GetLastError()); @@ -101,7 +101,7 @@ static void test_PSetupDestroyMonitorInfo(VOID) SetLastError(0xdeadbeef); mi = pPSetupCreateMonitorInfo(NULL, NULL, NULL); if (!mi && (GetLastError() == RPC_S_SERVER_UNAVAILABLE)) { - win_skip("The Service 'Spooler' is required for many test\n"); + win_skip("The service 'Spooler' is required for many tests\n"); return; } ok( mi != NULL, "got %p with %u (expected '!= NULL')\n", mi, GetLastError()); @@ -113,7 +113,7 @@ static void test_PSetupDestroyMonitorInfo(VOID) /* lasterror is returned */ trace("returned with %u\n", GetLastError()); - /* Try to destroy the handle twice crash with native ntprint.dll */ + /* Trying to destroy the handle twice crashes with native ntprint.dll */ if (0) { SetLastError(0xdeadbeef); pPSetupDestroyMonitorInfo(mi);
1
0
0
0
Francois Gouget : oleaut32: Use the CSTR_XXX macros instead of numeric literals.
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: 4d22dc440b57d8b3183e23eb4e29129c76631e6a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4d22dc440b57d8b3183e23eb4…
Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Jun 20 23:41:13 2012 +0200 oleaut32: Use the CSTR_XXX macros instead of numeric literals. --- dlls/oleaut32/vartype.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/oleaut32/vartype.c b/dlls/oleaut32/vartype.c index 9810d35..2d27f9d 100644 --- a/dlls/oleaut32/vartype.c +++ b/dlls/oleaut32/vartype.c @@ -7017,7 +7017,7 @@ HRESULT WINAPI VarBstrCmp(BSTR pbstrLeft, BSTR pbstrRight, LCID lcid, DWORD dwFl } hres = CompareStringW(lcid, dwFlags, pbstrLeft, lenLeft, - pbstrRight, lenRight) - 1; + pbstrRight, lenRight) - CSTR_LESS_THAN; TRACE("%d\n", hres); return hres; }
1
0
0
0
Francois Gouget : xcopy: Use the CSTR_XXX macros instead of numeric literals.
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: ec5e3a3b50ab4a128a12c49c4eea7aad0a80b840 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ec5e3a3b50ab4a128a12c49c4…
Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Jun 20 23:41:05 2012 +0200 xcopy: Use the CSTR_XXX macros instead of numeric literals. --- programs/xcopy/xcopy.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/xcopy/xcopy.c b/programs/xcopy/xcopy.c index 604c07a..cec0828 100644 --- a/programs/xcopy/xcopy.c +++ b/programs/xcopy/xcopy.c @@ -761,7 +761,7 @@ static int XCOPY_ParseCommandLine(WCHAR *suppliedsource, case 'E': if (CompareStringW(LOCALE_USER_DEFAULT, NORM_IGNORECASE | SORT_STRINGSORT, &word[1], 8, - EXCLUDE, -1) == 2) { + EXCLUDE, -1) == CSTR_EQUAL) { if (XCOPY_ProcessExcludeList(&word[9])) { XCOPY_FailMessage(ERROR_INVALID_PARAMETER); goto out;
1
0
0
0
Francois Gouget : reg: Use the CSTR_XXX macros instead of numeric literals.
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: f9c2e21fb1a1425652d3a2b256380be9cc55c0fb URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f9c2e21fb1a1425652d3a2b25…
Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Jun 20 23:41:25 2012 +0200 reg: Use the CSTR_XXX macros instead of numeric literals. --- programs/reg/reg.c | 20 ++++++++++---------- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/programs/reg/reg.c b/programs/reg/reg.c index 8a6ffc4..1b46661 100644 --- a/programs/reg/reg.c +++ b/programs/reg/reg.c @@ -80,20 +80,20 @@ static HKEY get_rootkey(LPWSTR key) static const WCHAR szHKCC[] = {'H','K','C','C',0}; static const WCHAR szHKEY_CURRENT_CONFIG[] = {'H','K','E','Y','_','C','U','R','R','E','N','T','_','C','O','N','F','I','G',0}; - if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,4,szHKLM,4)==2 || - CompareStringW(CP_ACP,NORM_IGNORECASE,key,18,szHKEY_LOCAL_MACHINE,18)==2) + if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,4,szHKLM,4)==CSTR_EQUAL || + CompareStringW(CP_ACP,NORM_IGNORECASE,key,18,szHKEY_LOCAL_MACHINE,18)==CSTR_EQUAL) return HKEY_LOCAL_MACHINE; - else if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,4,szHKCU,4)==2 || - CompareStringW(CP_ACP,NORM_IGNORECASE,key,17,szHKEY_CURRENT_USER,17)==2) + else if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,4,szHKCU,4)==CSTR_EQUAL || + CompareStringW(CP_ACP,NORM_IGNORECASE,key,17,szHKEY_CURRENT_USER,17)==CSTR_EQUAL) return HKEY_CURRENT_USER; - else if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,4,szHKCR,4)==2 || - CompareStringW(CP_ACP,NORM_IGNORECASE,key,17,szHKEY_CLASSES_ROOT,17)==2) + else if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,4,szHKCR,4)==CSTR_EQUAL || + CompareStringW(CP_ACP,NORM_IGNORECASE,key,17,szHKEY_CLASSES_ROOT,17)==CSTR_EQUAL) return HKEY_CLASSES_ROOT; - else if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,3,szHKU,3)==2 || - CompareStringW(CP_ACP,NORM_IGNORECASE,key,10,szHKEY_USERS,10)==2) + else if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,3,szHKU,3)==CSTR_EQUAL || + CompareStringW(CP_ACP,NORM_IGNORECASE,key,10,szHKEY_USERS,10)==CSTR_EQUAL) return HKEY_USERS; - else if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,4,szHKCC,4)==2 || - CompareStringW(CP_ACP,NORM_IGNORECASE,key,19,szHKEY_CURRENT_CONFIG,19)==2) + else if (CompareStringW(CP_ACP,NORM_IGNORECASE,key,4,szHKCC,4)==CSTR_EQUAL || + CompareStringW(CP_ACP,NORM_IGNORECASE,key,19,szHKEY_CURRENT_CONFIG,19)==CSTR_EQUAL) return HKEY_CURRENT_CONFIG; else return NULL; }
1
0
0
0
Francois Gouget : shlwapi: Simplify the string comparison functions a bit and use the CSTR_XXX macros .
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: de049ff1ed801aadd93d46e6be2d855da46f9768 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=de049ff1ed801aadd93d46e6b…
Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Jun 20 23:40:56 2012 +0200 shlwapi: Simplify the string comparison functions a bit and use the CSTR_XXX macros. --- dlls/shlwapi/string.c | 40 ++++++++-------------------------------- 1 files changed, 8 insertions(+), 32 deletions(-) diff --git a/dlls/shlwapi/string.c b/dlls/shlwapi/string.c index e2f1cba..a919d8a 100644 --- a/dlls/shlwapi/string.c +++ b/dlls/shlwapi/string.c @@ -176,7 +176,7 @@ static BOOL SHLWAPI_ChrCmpHelperA(WORD ch1, WORD ch2, DWORD dwFlags) else str2[1] = '\0'; - return CompareStringA(GetThreadLocale(), dwFlags, str1, -1, str2, -1) - 2; + return CompareStringA(GetThreadLocale(), dwFlags, str1, -1, str2, -1) - CSTR_EQUAL; } /************************************************************************* @@ -216,7 +216,7 @@ BOOL WINAPI ChrCmpIA(WORD ch1, WORD ch2) */ BOOL WINAPI ChrCmpIW(WCHAR ch1, WCHAR ch2) { - return CompareStringW(GetThreadLocale(), NORM_IGNORECASE, &ch1, 1, &ch2, 1) - 2; + return CompareStringW(GetThreadLocale(), NORM_IGNORECASE, &ch1, 1, &ch2, 1) - CSTR_EQUAL; } /************************************************************************* @@ -352,12 +352,8 @@ LPWSTR WINAPI StrChrNW(LPCWSTR lpszStr, WCHAR ch, UINT cchMax) */ int WINAPI StrCmpIW(LPCWSTR lpszStr, LPCWSTR lpszComp) { - int iRet; - TRACE("(%s,%s)\n", debugstr_w(lpszStr),debugstr_w(lpszComp)); - - iRet = CompareStringW(GetThreadLocale(), NORM_IGNORECASE, lpszStr, -1, lpszComp, -1); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringW(GetThreadLocale(), NORM_IGNORECASE, lpszStr, -1, lpszComp, -1) - CSTR_EQUAL; } /************************************************************************* @@ -376,12 +372,8 @@ int WINAPI StrCmpIW(LPCWSTR lpszStr, LPCWSTR lpszComp) */ INT WINAPI StrCmpNA(LPCSTR lpszStr, LPCSTR lpszComp, INT iLen) { - INT iRet; - TRACE("(%s,%s,%i)\n", debugstr_a(lpszStr), debugstr_a(lpszComp), iLen); - - iRet = CompareStringA(GetThreadLocale(), 0, lpszStr, iLen, lpszComp, iLen); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringA(GetThreadLocale(), 0, lpszStr, iLen, lpszComp, iLen) - CSTR_EQUAL; } /************************************************************************* @@ -391,12 +383,8 @@ INT WINAPI StrCmpNA(LPCSTR lpszStr, LPCSTR lpszComp, INT iLen) */ INT WINAPI StrCmpNW(LPCWSTR lpszStr, LPCWSTR lpszComp, INT iLen) { - INT iRet; - TRACE("(%s,%s,%i)\n", debugstr_w(lpszStr), debugstr_w(lpszComp), iLen); - - iRet = CompareStringW(GetThreadLocale(), 0, lpszStr, iLen, lpszComp, iLen); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringW(GetThreadLocale(), 0, lpszStr, iLen, lpszComp, iLen) - CSTR_EQUAL; } /************************************************************************* @@ -415,12 +403,8 @@ INT WINAPI StrCmpNW(LPCWSTR lpszStr, LPCWSTR lpszComp, INT iLen) */ int WINAPI StrCmpNIA(LPCSTR lpszStr, LPCSTR lpszComp, int iLen) { - INT iRet; - TRACE("(%s,%s,%i)\n", debugstr_a(lpszStr), debugstr_a(lpszComp), iLen); - - iRet = CompareStringA(GetThreadLocale(), NORM_IGNORECASE, lpszStr, iLen, lpszComp, iLen); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringA(GetThreadLocale(), NORM_IGNORECASE, lpszStr, iLen, lpszComp, iLen) - CSTR_EQUAL; } /************************************************************************* @@ -430,12 +414,8 @@ int WINAPI StrCmpNIA(LPCSTR lpszStr, LPCSTR lpszComp, int iLen) */ INT WINAPI StrCmpNIW(LPCWSTR lpszStr, LPCWSTR lpszComp, int iLen) { - INT iRet; - TRACE("(%s,%s,%i)\n", debugstr_w(lpszStr), debugstr_w(lpszComp), iLen); - - iRet = CompareStringW(GetThreadLocale(), NORM_IGNORECASE, lpszStr, iLen, lpszComp, iLen); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringW(GetThreadLocale(), NORM_IGNORECASE, lpszStr, iLen, lpszComp, iLen) - CSTR_EQUAL; } /************************************************************************* @@ -453,12 +433,8 @@ INT WINAPI StrCmpNIW(LPCWSTR lpszStr, LPCWSTR lpszComp, int iLen) */ int WINAPI StrCmpW(LPCWSTR lpszStr, LPCWSTR lpszComp) { - INT iRet; - TRACE("(%s,%s)\n", debugstr_w(lpszStr), debugstr_w(lpszComp)); - - iRet = CompareStringW(GetThreadLocale(), 0, lpszStr, -1, lpszComp, -1); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringW(GetThreadLocale(), 0, lpszStr, -1, lpszComp, -1) - CSTR_EQUAL; } /*************************************************************************
1
0
0
0
Francois Gouget : msvcrt: Use the CSTR_XXX macros instead of numeric literals.
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: d817bbd6f45a1e329ba339a2b8691261a7045239 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d817bbd6f45a1e329ba339a2b…
Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Jun 20 23:40:33 2012 +0200 msvcrt: Use the CSTR_XXX macros instead of numeric literals. --- dlls/msvcrt/string.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dlls/msvcrt/string.c b/dlls/msvcrt/string.c index ad9e88b..6fe5aab 100644 --- a/dlls/msvcrt/string.c +++ b/dlls/msvcrt/string.c @@ -543,7 +543,7 @@ int CDECL MSVCRT_strcoll_l( const char* str1, const char* str2, MSVCRT__locale_t else locinfo = locale->locinfo; - return CompareStringA(locinfo->lc_handle[MSVCRT_LC_CTYPE], 0, str1, -1, str2, -1)-2; + return CompareStringA(locinfo->lc_handle[MSVCRT_LC_CTYPE], 0, str1, -1, str2, -1)-CSTR_EQUAL; } /********************************************************************* @@ -567,7 +567,7 @@ int CDECL MSVCRT__stricoll_l( const char* str1, const char* str2, MSVCRT__locale locinfo = locale->locinfo; return CompareStringA(locinfo->lc_handle[MSVCRT_LC_CTYPE], NORM_IGNORECASE, - str1, -1, str2, -1)-2; + str1, -1, str2, -1)-CSTR_EQUAL; } /********************************************************************* @@ -590,7 +590,7 @@ int CDECL MSVCRT_strncoll_l( const char* str1, const char* str2, MSVCRT_size_t c else locinfo = locale->locinfo; - return CompareStringA(locinfo->lc_handle[MSVCRT_LC_CTYPE], 0, str1, count, str2, count)-2; + return CompareStringA(locinfo->lc_handle[MSVCRT_LC_CTYPE], 0, str1, count, str2, count)-CSTR_EQUAL; } /********************************************************************* @@ -614,7 +614,7 @@ int CDECL MSVCRT__strnicoll_l( const char* str1, const char* str2, MSVCRT_size_t locinfo = locale->locinfo; return CompareStringA(locinfo->lc_handle[MSVCRT_LC_CTYPE], NORM_IGNORECASE, - str1, count, str2, count)-2; + str1, count, str2, count)-CSTR_EQUAL; } /*********************************************************************
1
0
0
0
Francois Gouget : comctl32: Simplify the string comparison functions a bit and use the CSTR_XXX macros .
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: ac323a20ba226cd778fd87c65fae085082000762 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ac323a20ba226cd778fd87c65…
Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Jun 20 23:40:13 2012 +0200 comctl32: Simplify the string comparison functions a bit and use the CSTR_XXX macros. --- dlls/comctl32/string.c | 46 ++++++++++++++++------------------------------ 1 files changed, 16 insertions(+), 30 deletions(-) diff --git a/dlls/comctl32/string.c b/dlls/comctl32/string.c index 7fead7c..a9544fa 100644 --- a/dlls/comctl32/string.c +++ b/dlls/comctl32/string.c @@ -77,7 +77,7 @@ static BOOL COMCTL32_ChrCmpHelperA(WORD ch1, WORD ch2, DWORD dwFlags) else str2[1] = '\0'; - return CompareStringA(GetThreadLocale(), dwFlags, str1, -1, str2, -1) - 2; + return CompareStringA(GetThreadLocale(), dwFlags, str1, -1, str2, -1) - CSTR_EQUAL; } /************************************************************************* @@ -117,7 +117,7 @@ static BOOL COMCTL32_ChrCmpIA(WORD ch1, WORD ch2) */ static inline BOOL COMCTL32_ChrCmpIW(WCHAR ch1, WCHAR ch2) { - return CompareStringW(GetThreadLocale(), NORM_IGNORECASE, &ch1, 1, &ch2, 1) - 2; + return CompareStringW(GetThreadLocale(), NORM_IGNORECASE, &ch1, 1, &ch2, 1) - CSTR_EQUAL; } /************************************************************************** @@ -299,12 +299,8 @@ LPSTR WINAPI StrChrA(LPCSTR lpszStr, WORD ch) */ INT WINAPI StrCmpNIA(LPCSTR lpszStr, LPCSTR lpszComp, INT iLen) { - INT iRet; - TRACE("(%s,%s,%i)\n", debugstr_a(lpszStr), debugstr_a(lpszComp), iLen); - - iRet = CompareStringA(GetThreadLocale(), NORM_IGNORECASE, lpszStr, iLen, lpszComp, iLen); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringA(GetThreadLocale(), NORM_IGNORECASE, lpszStr, iLen, lpszComp, iLen) - CSTR_EQUAL; } /************************************************************************* @@ -314,12 +310,8 @@ INT WINAPI StrCmpNIA(LPCSTR lpszStr, LPCSTR lpszComp, INT iLen) */ INT WINAPI StrCmpNIW(LPCWSTR lpszStr, LPCWSTR lpszComp, INT iLen) { - INT iRet; - TRACE("(%s,%s,%i)\n", debugstr_w(lpszStr), debugstr_w(lpszComp), iLen); - - iRet = CompareStringW(GetThreadLocale(), NORM_IGNORECASE, lpszStr, iLen, lpszComp, iLen); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringW(GetThreadLocale(), NORM_IGNORECASE, lpszStr, iLen, lpszComp, iLen) - CSTR_EQUAL; } /************************************************************************* @@ -496,12 +488,8 @@ LPWSTR WINAPI StrChrW(LPCWSTR lpszStr, WCHAR ch) */ INT WINAPI StrCmpNA(LPCSTR lpszStr, LPCSTR lpszComp, INT iLen) { - INT iRet; - TRACE("(%s,%s,%i)\n", debugstr_a(lpszStr), debugstr_a(lpszComp), iLen); - - iRet = CompareStringA(GetThreadLocale(), 0, lpszStr, iLen, lpszComp, iLen); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringA(GetThreadLocale(), 0, lpszStr, iLen, lpszComp, iLen) - CSTR_EQUAL; } /************************************************************************** @@ -511,12 +499,8 @@ INT WINAPI StrCmpNA(LPCSTR lpszStr, LPCSTR lpszComp, INT iLen) */ INT WINAPI StrCmpNW(LPCWSTR lpszStr, LPCWSTR lpszComp, INT iLen) { - INT iRet; - TRACE("(%s,%s,%i)\n", debugstr_w(lpszStr), debugstr_w(lpszComp), iLen); - - iRet = CompareStringW(GetThreadLocale(), 0, lpszStr, iLen, lpszComp, iLen); - return iRet == CSTR_LESS_THAN ? -1 : iRet == CSTR_GREATER_THAN ? 1 : 0; + return CompareStringW(GetThreadLocale(), 0, lpszStr, iLen, lpszComp, iLen) - CSTR_EQUAL; } /************************************************************************** @@ -877,10 +861,11 @@ BOOL WINAPI IntlStrEqWorkerA(BOOL bCase, LPCSTR lpszStr, LPCSTR lpszComp, TRACE("(%d,%s,%s,%d)\n", bCase, debugstr_a(lpszStr), debugstr_a(lpszComp), iLen); - /* FIXME: These flags are undocumented and unknown by our CompareString. - * We need defines for them. + /* FIXME: This flag is undocumented and unknown by our CompareString. + * We need a define for it. */ - dwFlags |= bCase ? 0x10000000 : 0x10000001; + dwFlags = 0x10000000; + if (!bCase) dwFlags |= NORM_IGNORECASE; iRet = CompareStringA(GetThreadLocale(), dwFlags, lpszStr, iLen, lpszComp, iLen); @@ -888,7 +873,7 @@ BOOL WINAPI IntlStrEqWorkerA(BOOL bCase, LPCSTR lpszStr, LPCSTR lpszComp, if (!iRet) iRet = CompareStringA(2048, dwFlags, lpszStr, iLen, lpszComp, iLen); - return iRet == 2 ? TRUE : FALSE; + return iRet == CSTR_EQUAL; } /************************************************************************* @@ -905,10 +890,11 @@ BOOL WINAPI IntlStrEqWorkerW(BOOL bCase, LPCWSTR lpszStr, LPCWSTR lpszComp, TRACE("(%d,%s,%s,%d)\n", bCase, debugstr_w(lpszStr),debugstr_w(lpszComp), iLen); - /* FIXME: These flags are undocumented and unknown by our CompareString. - * We need defines for them. + /* FIXME: This flag is undocumented and unknown by our CompareString. + * We need a define for it. */ - dwFlags = bCase ? 0x10000000 : 0x10000001; + dwFlags = 0x10000000; + if (!bCase) dwFlags |= NORM_IGNORECASE; iRet = CompareStringW(GetThreadLocale(), dwFlags, lpszStr, iLen, lpszComp, iLen); @@ -916,5 +902,5 @@ BOOL WINAPI IntlStrEqWorkerW(BOOL bCase, LPCWSTR lpszStr, LPCWSTR lpszComp, if (!iRet) iRet = CompareStringW(2048, dwFlags, lpszStr, iLen, lpszComp, iLen); - return iRet == 2 ? TRUE : FALSE; + return iRet == CSTR_EQUAL; }
1
0
0
0
Julian Rüger : po: Update German translation.
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: e215f28a451997108d394e2de4223d557e44cfec URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e215f28a451997108d394e2de…
Author: Julian Rüger <jr98(a)gmx.net> Date: Wed Jun 20 23:55:30 2012 +0200 po: Update German translation. --- po/de.po | 18 ++++++------------ 1 files changed, 6 insertions(+), 12 deletions(-) diff --git a/po/de.po b/po/de.po index 72aa218..5d58fea 100644 --- a/po/de.po +++ b/po/de.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To:
http://bugs.winehq.org\n
" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2012-06-13 22:52+0200\n" +"PO-Revision-Date: 2012-06-20 21:55+0200\n" "Last-Translator: Julian Rüger\n" "Language-Team: none\n" "Language: German\n" @@ -13707,34 +13707,28 @@ msgstr "Hilfe-Dateien (*.hlp)" #: winhlp32.rc:89 msgid "Cannot find '%s'. Do you want to find this file yourself?" msgstr "" -"'%s' konnte nicht gefunden werden. Wollen Sie selber nach dieser Datei " +"'%s' konnte nicht gefunden werden. Möchten Sie selbst nach dieser Datei " "suchen?" #: winhlp32.rc:90 msgid "Cannot find a richedit implementation... Aborting" -msgstr "Die Richedit Implementation konnte nicht gefunden werden... Breche ab" +msgstr "Es konnte keine Richedit-Implementierung gefunden werden... Abbruch" #: winhlp32.rc:91 msgid "Help topics: " msgstr "Hilfethemen: " #: wmic.rc:25 -#, fuzzy -#| msgid "Error: Invalid command line parameters\n" msgid "Error: Command line not supported\n" -msgstr "Fehler: Ungültige Befehlszeilenargumente\n" +msgstr "Fehler: Befehlszeile nicht unterstützt\n" #: wmic.rc:26 -#, fuzzy -#| msgid "Property set not found.\n" msgid "Error: Alias not found\n" -msgstr "Eigenschaften nicht gefunden.\n" +msgstr "Fehler: Alias nicht gefunden\n" #: wmic.rc:27 -#, fuzzy -#| msgid "Error: Invalid key name\n" msgid "Error: Invalid query\n" -msgstr "Fehler: Ungültiger Schlüssel\n" +msgstr "Fehler: Ungültige Anfrage\n" #: wordpad.rc:28 msgid "&New...\tCtrl+N"
1
0
0
0
Lauri Kenttä : po: Update Swedish translation.
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: 04c7ccd240cfc14e72e14d4a5540e2e0c0946fea URL:
http://source.winehq.org/git/wine.git/?a=commit;h=04c7ccd240cfc14e72e14d4a5…
Author: Lauri Kenttä <lauri.kentta(a)gmail.com> Date: Wed Jun 20 23:37:52 2012 +0300 po: Update Swedish translation. --- po/sv.po | 26 ++++++++++---------------- 1 files changed, 10 insertions(+), 16 deletions(-) diff --git a/po/sv.po b/po/sv.po index dfaa5c6..5251c0c 100644 --- a/po/sv.po +++ b/po/sv.po @@ -2057,7 +2057,7 @@ msgstr "Meddelandenummer=" #: cryptdlg.rc:37 msgid "Notice Text=" -msgstr "Meddelandetext" +msgstr "Meddelandetext=" #: cryptui.rc:177 cryptui.rc:232 inetcpl.rc:43 msgid "General" @@ -3438,7 +3438,7 @@ msgstr "Testa joysticken" #: joy.rc:50 msgid "Buttons" -msgstr "" +msgstr "Knappar" #: joy.rc:58 msgid "Test Force Feedback" @@ -3506,15 +3506,15 @@ msgstr "Oterminerad strängkonstant" #: jscript.rc:39 msgid "Can't have 'break' outside of loop" -msgstr "" +msgstr "Går ej att ha 'break' utanför loop" #: jscript.rc:40 msgid "Can't have 'continue' outside of loop" -msgstr "" +msgstr "Går ej att ha 'continue' utanför loop" #: jscript.rc:41 msgid "Label redefined" -msgstr "" +msgstr "Etiketten är redan definierat" #: jscript.rc:42 msgid "Label not found" @@ -11013,11 +11013,11 @@ msgstr "Operation slutfördes utan problem\n" #: reg.rc:32 msgid "Error: Invalid key name\n" -msgstr "Fel: ogiltigt nyckelnamn\n" +msgstr "Fel: Ogiltigt nyckelnamn\n" #: reg.rc:33 msgid "Error: Invalid command line parameters\n" -msgstr "Fel: ogiltiga kommandoradsparametrar\n" +msgstr "Fel: Ogiltiga kommandoradsparametrar\n" #: reg.rc:34 msgid "Error: Unable to add keys to remote machine\n" @@ -13555,22 +13555,16 @@ msgid "Help topics: " msgstr "Hjälprubriker: " #: wmic.rc:25 -#, fuzzy -#| msgid "Error: Invalid command line parameters\n" msgid "Error: Command line not supported\n" -msgstr "Fel: ogiltiga kommandoradsparametrar\n" +msgstr "Fel: Kommandoraden stöds inte\n" #: wmic.rc:26 -#, fuzzy -#| msgid "Property set not found.\n" msgid "Error: Alias not found\n" -msgstr "Egenskapsmängden hittades inte.\n" +msgstr "Fel: Aliaset hittades inte\n" #: wmic.rc:27 -#, fuzzy -#| msgid "Error: Invalid key name\n" msgid "Error: Invalid query\n" -msgstr "Fel: ogiltigt nyckelnamn\n" +msgstr "Fel: Ogiltig fråga\n" #: wordpad.rc:28 msgid "&New...\tCtrl+N"
1
0
0
0
Lauri Kenttä : po: Update Finnish translation.
by Alexandre Julliard
21 Jun '12
21 Jun '12
Module: wine Branch: master Commit: 9217526be963163d276447ca54f63d416365beea URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9217526be963163d276447ca5…
Author: Lauri Kenttä <lauri.kentta(a)gmail.com> Date: Wed Jun 20 23:37:51 2012 +0300 po: Update Finnish translation. --- po/fi.po | 14 ++++---------- 1 files changed, 4 insertions(+), 10 deletions(-) diff --git a/po/fi.po b/po/fi.po index 11f2d07..644f85e 100644 --- a/po/fi.po +++ b/po/fi.po @@ -3443,7 +3443,7 @@ msgstr "Testaa joystickia" #: joy.rc:50 msgid "Buttons" -msgstr "" +msgstr "Painikkeet" #: joy.rc:58 msgid "Test Force Feedback" @@ -13605,22 +13605,16 @@ msgid "Help topics: " msgstr "Ohjeen otsikot: " #: wmic.rc:25 -#, fuzzy -#| msgid "Error: Invalid command line parameters\n" msgid "Error: Command line not supported\n" -msgstr "Virhe: Viallisia komentoriviparametreja\n" +msgstr "Virhe: Komentoriviä ei tueta\n" #: wmic.rc:26 -#, fuzzy -#| msgid "Property set not found.\n" msgid "Error: Alias not found\n" -msgstr "Ominaisuusjoukkoa ei löytynyt.\n" +msgstr "Virhe: Aliasta ei löydy\n" #: wmic.rc:27 -#, fuzzy -#| msgid "Error: Invalid key name\n" msgid "Error: Invalid query\n" -msgstr "Virhe: Viallinen avaimen nimi\n" +msgstr "Virhe: Viallinen kysely\n" #: wordpad.rc:28 msgid "&New...\tCtrl+N"
1
0
0
0
← Newer
1
...
31
32
33
34
35
36
37
...
83
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
Results per page:
10
25
50
100
200