winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
September 2012
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
828 discussions
Start a n
N
ew thread
Rico Schüller : d3dx9: Use float functions in D3DXQuaternionSlerp().
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: ce319e9d53374e94e544d958f4e490aa9dc4e104 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ce319e9d53374e94e544d958f…
Author: Rico Schüller <kgbricola(a)web.de> Date: Wed Sep 26 13:57:01 2012 +0200 d3dx9: Use float functions in D3DXQuaternionSlerp(). --- dlls/d3dx9_36/math.c | 37 ++++++++++++++++++++----------------- 1 files changed, 20 insertions(+), 17 deletions(-) diff --git a/dlls/d3dx9_36/math.c b/dlls/d3dx9_36/math.c index 1e80e2e..7599a0a 100644 --- a/dlls/d3dx9_36/math.c +++ b/dlls/d3dx9_36/math.c @@ -1435,32 +1435,35 @@ D3DXQUATERNION* WINAPI D3DXQuaternionRotationYawPitchRoll(D3DXQUATERNION *pout, return pout; } -D3DXQUATERNION* WINAPI D3DXQuaternionSlerp(D3DXQUATERNION *pout, CONST D3DXQUATERNION *pq1, CONST D3DXQUATERNION *pq2, FLOAT t) +D3DXQUATERNION * WINAPI D3DXQuaternionSlerp(D3DXQUATERNION *out, const D3DXQUATERNION *q1, + const D3DXQUATERNION *q2, FLOAT t) { - FLOAT dot, epsilon, temp, theta, u; + FLOAT dot, temp; - TRACE("(%p, %p, %p, %f)\n", pout, pq1, pq2, t); + TRACE("out %p, q1 %p, q2 %p, t %f\n", out, q1, q2, t); - epsilon = 1.0f; temp = 1.0f - t; - u = t; - dot = D3DXQuaternionDot(pq1, pq2); - if ( dot < 0.0f ) + dot = D3DXQuaternionDot(q1, q2); + if (dot < 0.0f) { - epsilon = -1.0f; + t = -t; dot = -dot; } - if( 1.0f - dot > 0.001f ) + + if (1.0f - dot > 0.001f) { - theta = acos(dot); - temp = sin(theta * temp) / sin(theta); - u = sin(theta * u) / sin(theta); + FLOAT theta = acosf(dot); + + temp = sinf(theta * temp) / sinf(theta); + t = sinf(theta * t) / sinf(theta); } - pout->x = temp * pq1->x + epsilon * u * pq2->x; - pout->y = temp * pq1->y + epsilon * u * pq2->y; - pout->z = temp * pq1->z + epsilon * u * pq2->z; - pout->w = temp * pq1->w + epsilon * u * pq2->w; - return pout; + + out->x = temp * q1->x + t * q2->x; + out->y = temp * q1->y + t * q2->y; + out->z = temp * q1->z + t * q2->z; + out->w = temp * q1->w + t * q2->w; + + return out; } D3DXQUATERNION* WINAPI D3DXQuaternionSquad(D3DXQUATERNION *pout, CONST D3DXQUATERNION *pq1, CONST D3DXQUATERNION *pq2, CONST D3DXQUATERNION *pq3, CONST D3DXQUATERNION *pq4, FLOAT t)
1
0
0
0
Rico Schüller : d3dx9: Use float functions in D3DXSHRotateZ().
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: 398eb275387c51ba9543d40e1fee77643361b7f2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=398eb275387c51ba9543d40e1…
Author: Rico Schüller <kgbricola(a)web.de> Date: Wed Sep 26 13:56:57 2012 +0200 d3dx9: Use float functions in D3DXSHRotateZ(). --- dlls/d3dx9_36/math.c | 35 +++++++++++++++++------------------ 1 files changed, 17 insertions(+), 18 deletions(-) diff --git a/dlls/d3dx9_36/math.c b/dlls/d3dx9_36/math.c index 00cf9c3..1e80e2e 100644 --- a/dlls/d3dx9_36/math.c +++ b/dlls/d3dx9_36/math.c @@ -2466,38 +2466,33 @@ FLOAT* WINAPI D3DXSHRotate(FLOAT *out, UINT order, CONST D3DXMATRIX *matrix, CON return out; } -FLOAT* WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT *in) +FLOAT * WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT *in) { FLOAT c1a, c2a, c3a, c4a, c5a, s1a, s2a, s3a, s4a, s5a; - TRACE("%p, %u, %f, %p)\n", out, order, angle, in); - - c1a = cos( angle ); - c2a = cos( 2.0f * angle ); - c3a = cos( 3.0f * angle ); - c4a = cos( 4.0f * angle ); - c5a = cos( 5.0f * angle ); - s1a = sin( angle ); - s2a = sin( 2.0f * angle ); - s3a = sin( 3.0f * angle ); - s4a = sin( 4.0f * angle ); - s5a = sin( 5.0f * angle ); + TRACE("out %p, order %u, angle %f, in %p\n", out, order, angle, in); + c1a = cosf(angle); + s1a = sinf(angle); out[0] = in[0]; out[1] = c1a * in[1] + s1a * in[3]; out[2] = in[2]; - out[3] = c1a * in[3] - s1a * in[1]; - if ( order <= D3DXSH_MINORDER ) + out[3] = c1a * in[3] - s1a * in[1]; + if (order <= D3DXSH_MINORDER) return out; + c2a = cosf(2.0f * angle); + s2a = sinf(2.0f * angle); out[4] = c2a * in[4] + s2a * in[8]; out[5] = c1a * in[5] + s1a * in[7]; out[6] = in[6]; out[7] = c1a * in[7] - s1a * in[5]; out[8] = c2a * in[8] - s2a * in[4]; - if ( order == 3 ) + if (order == 3) return out; + c3a = cosf(3.0f * angle); + s3a = sinf(3.0f * angle); out[9] = c3a * in[9] + s3a * in[15]; out[10] = c2a * in[10] + s2a * in[14]; out[11] = c1a * in[11] + s1a * in[13]; @@ -2505,9 +2500,11 @@ FLOAT* WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT *in out[13] = c1a * in[13] - s1a * in[11]; out[14] = c2a * in[14] - s2a * in[10]; out[15] = c3a * in[15] - s3a * in[9]; - if ( order == 4 ) + if (order == 4) return out; + c4a = cosf(4.0f * angle); + s4a = sinf(4.0f * angle); out[16] = c4a * in[16] + s4a * in[24]; out[17] = c3a * in[17] + s3a * in[23]; out[18] = c2a * in[18] + s2a * in[22]; @@ -2517,9 +2514,11 @@ FLOAT* WINAPI D3DXSHRotateZ(FLOAT *out, UINT order, FLOAT angle, CONST FLOAT *in out[22] = c2a * in[22] - s2a * in[18]; out[23] = c3a * in[23] - s3a * in[17]; out[24] = c4a * in[24] - s4a * in[16]; - if ( order == 5 ) + if (order == 5) return out; + c5a = cosf(5.0f * angle); + s5a = sinf(5.0f * angle); out[25] = c5a * in[25] + s5a * in[35]; out[26] = c4a * in[26] + s4a * in[34]; out[27] = c3a * in[27] + s3a * in[33];
1
0
0
0
Rico Schüller : d3dx9: Improve RegisterCount calculation for D3DXRS_INT4/BOOL.
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: 82a800c128be2681633e6d4c9e62a1d2e0984b57 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=82a800c128be2681633e6d4c9…
Author: Rico Schüller <kgbricola(a)web.de> Date: Wed Sep 26 12:22:02 2012 +0200 d3dx9: Improve RegisterCount calculation for D3DXRS_INT4/BOOL. --- dlls/d3dx9_36/shader.c | 21 +++++++++++++++++++++ 1 files changed, 21 insertions(+), 0 deletions(-) diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c index dfa0488..3147d40 100644 --- a/dlls/d3dx9_36/shader.c +++ b/dlls/d3dx9_36/shader.c @@ -1644,6 +1644,27 @@ static HRESULT parse_ctab_constant_type(const char *ctab, DWORD typeoffset, stru /* offset in bytes => offsetdiff * components(4) * sizeof(DWORD) */ if (offset) *offset += offsetdiff * 4 * 4; + + /* int and bool registerset have different sizes */ + if (regset == D3DXRS_INT4 || regset == D3DXRS_BOOL) + { + switch (type->Class) + { + case D3DXPC_SCALAR: + case D3DXPC_VECTOR: + size = type->Columns; + break; + + case D3DXPC_MATRIX_ROWS: + case D3DXPC_MATRIX_COLUMNS: + size = 4 * type->Columns; + break; + + default: + FIXME("Unhandled type class %s\n", debug_d3dxparameter_class(type->Class)); + break; + } + } } constant->desc.RegisterCount = max(0, min(max - index, size));
1
0
0
0
Rico Schüller : d3dx9: Fix shader constant byte calculation.
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: 3eb26010d8a1b350035dafeb47af4bdc1cc9766f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=3eb26010d8a1b350035dafeb4…
Author: Rico Schüller <kgbricola(a)web.de> Date: Wed Sep 26 12:21:54 2012 +0200 d3dx9: Fix shader constant byte calculation. --- dlls/d3dx9_36/shader.c | 11 +---------- 1 files changed, 1 insertions(+), 10 deletions(-) diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c index c62c8e5..dfa0488 100644 --- a/dlls/d3dx9_36/shader.c +++ b/dlls/d3dx9_36/shader.c @@ -671,15 +671,6 @@ static inline int is_vertex_shader(DWORD version) return (version & 0xFFFF0000) == 0xFFFE0000; } -static DWORD calc_bytes(D3DXCONSTANT_DESC *desc) -{ - if (desc->RegisterSet != D3DXRS_FLOAT4 && desc->RegisterSet != D3DXRS_SAMPLER) - FIXME("Don't know how to calculate Bytes for constants of type %s\n", - debug_d3dxparameter_registerset(desc->RegisterSet)); - - return 4 * desc->Elements * desc->Rows * desc->Columns; -} - static inline struct ctab_constant *constant_from_handle(D3DXHANDLE handle) { return (struct ctab_constant *)handle; @@ -1656,7 +1647,7 @@ static HRESULT parse_ctab_constant_type(const char *ctab, DWORD typeoffset, stru } constant->desc.RegisterCount = max(0, min(max - index, size)); - constant->desc.Bytes = calc_bytes(&constant->desc); + constant->desc.Bytes = 4 * constant->desc.Elements * type->Rows * type->Columns; return D3D_OK;
1
0
0
0
Rico Schüller : d3dx9: Handle D3DXPT_VOID in get_float /bool/int().
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: e817bc3f0483fdde3536eb754ed1d8c31206706b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=e817bc3f0483fdde3536eb754…
Author: Rico Schüller <kgbricola(a)web.de> Date: Wed Sep 26 11:52:02 2012 +0200 d3dx9: Handle D3DXPT_VOID in get_float/bool/int(). --- dlls/d3dx9_36/util.c | 61 ++++++++++++++++++++++++------------------------- 1 files changed, 30 insertions(+), 31 deletions(-) diff --git a/dlls/d3dx9_36/util.c b/dlls/d3dx9_36/util.c index b4cdefe..72008a2 100644 --- a/dlls/d3dx9_36/util.c +++ b/dlls/d3dx9_36/util.c @@ -271,63 +271,62 @@ const char *debug_d3dxparameter_registerset(D3DXREGISTER_SET r) #undef WINE_D3DX_TO_STR /* parameter type conversion helpers */ -static BOOL get_bool(LPCVOID data) +static BOOL get_bool(D3DXPARAMETER_TYPE type, LPCVOID data) { - return (*(DWORD *)data) != 0; + switch (type) + { + case D3DXPT_FLOAT: + case D3DXPT_INT: + case D3DXPT_BOOL: + return *(DWORD *)data != 0; + + case D3DXPT_VOID: + return *(BOOL *)data; + + default: + FIXME("Unhandled type %s.\n", debug_d3dxparameter_type(type)); + return FALSE; + } } static INT get_int(D3DXPARAMETER_TYPE type, LPCVOID data) { - INT i; - switch (type) { case D3DXPT_FLOAT: - i = *(FLOAT *)data; - break; + return *(FLOAT *)data; case D3DXPT_INT: - i = *(INT *)data; - break; + case D3DXPT_VOID: + return *(INT *)data; case D3DXPT_BOOL: - i = get_bool(data); - break; + return get_bool(type, data); default: - i = 0; - FIXME("Unhandled type %s. This should not happen!\n", debug_d3dxparameter_type(type)); - break; + FIXME("Unhandled type %s.\n", debug_d3dxparameter_type(type)); + return 0; } - - return i; } static FLOAT get_float(D3DXPARAMETER_TYPE type, LPCVOID data) { - FLOAT f; - switch (type) { case D3DXPT_FLOAT: - f = *(FLOAT *)data; - break; + case D3DXPT_VOID: + return *(FLOAT *)data; case D3DXPT_INT: - f = *(INT *)data; - break; + return *(INT *)data; case D3DXPT_BOOL: - f = get_bool(data); - break; + return get_bool(type, data); default: - f = 0.0f; - FIXME("Unhandled type %s. This should not happen!\n", debug_d3dxparameter_type(type)); - break; + FIXME("Unhandled type %s.\n", debug_d3dxparameter_type(type)); + return 0.0f; } - - return f; } void set_number(LPVOID outdata, D3DXPARAMETER_TYPE outtype, LPCVOID indata, D3DXPARAMETER_TYPE intype) @@ -347,7 +346,7 @@ void set_number(LPVOID outdata, D3DXPARAMETER_TYPE outtype, LPCVOID indata, D3DX break; case D3DXPT_BOOL: - *(BOOL *)outdata = get_bool(indata); + *(BOOL *)outdata = get_bool(intype, indata); break; case D3DXPT_INT: @@ -355,8 +354,8 @@ void set_number(LPVOID outdata, D3DXPARAMETER_TYPE outtype, LPCVOID indata, D3DX break; default: - FIXME("Unhandled type %s. This should not happen!\n", debug_d3dxparameter_type(outtype)); - *(INT *)outdata = 0; + FIXME("Unhandled type %s.\n", debug_d3dxparameter_type(outtype)); + *(DWORD *)outdata = 0; break; } }
1
0
0
0
Rico Schüller : winex11.drv: Remove unneeded include file.
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: 9be684622495906f25d99663154438dc07026449 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9be684622495906f25d996631…
Author: Rico Schüller <kgbricola(a)web.de> Date: Wed Sep 26 11:45:58 2012 +0200 winex11.drv: Remove unneeded include file. --- dlls/winex11.drv/brush.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dlls/winex11.drv/brush.c b/dlls/winex11.drv/brush.c index 3f3a79b..46bd2dd 100644 --- a/dlls/winex11.drv/brush.c +++ b/dlls/winex11.drv/brush.c @@ -22,7 +22,6 @@ #include <stdlib.h> -#include "wine/winbase16.h" #include "x11drv.h" #include "wine/debug.h"
1
0
0
0
Francois Gouget : d3dx9_36/tests: Remove spaces before '\n's in ok() calls.
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: 91c7dca35fee32bfc8fa286223cfa2ff75da78f9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=91c7dca35fee32bfc8fa28622…
Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Sep 26 11:12:51 2012 +0200 d3dx9_36/tests: Remove spaces before '\n's in ok() calls. --- dlls/d3dx9_36/tests/math.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/d3dx9_36/tests/math.c b/dlls/d3dx9_36/tests/math.c index 2cb6a7a..9043ab3 100644 --- a/dlls/d3dx9_36/tests/math.c +++ b/dlls/d3dx9_36/tests/math.c @@ -2560,7 +2560,7 @@ static void test_D3DXSHEvalDirectionalLight(void) else expected = test[l].red_out[startindex + j]; ok(relative_error(expected, red_out[j]) < admitted_error, - "Red: case %u, order %u: expected[%u] = %f, received %f \n", l, order, j, expected, red_out[j]); + "Red: case %u, order %u: expected[%u] = %f, received %f\n", l, order, j, expected, red_out[j]); if ( green_out ) { @@ -2569,7 +2569,7 @@ static void test_D3DXSHEvalDirectionalLight(void) else expected = test[l].green_out[startindex + j]; ok(relative_error(expected, green_out[j]) < admitted_error, - "Green: case %u, order %u: expected[%u] = %f, received %f \n", l, order, j, expected, green_out[j]); + "Green: case %u, order %u: expected[%u] = %f, received %f\n", l, order, j, expected, green_out[j]); } if ( blue_out ) @@ -2579,7 +2579,7 @@ static void test_D3DXSHEvalDirectionalLight(void) else expected = test[l].blue_out[startindex + j]; ok(relative_error(expected, blue_out[j]) < admitted_error, - "Blue: case %u, order %u: expected[%u] = %f, received %f \n", l, order, j, expected, blue_out[j]); + "Blue: case %u, order %u: expected[%u] = %f, received %f\n", l, order, j, expected, blue_out[j]); } }
1
0
0
0
Francois Gouget : wininet: Add a trailing '\n' to a couple of Wine traces.
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: 83af29fb03c3d00be7bd490b0203a6f71df9118a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=83af29fb03c3d00be7bd490b0…
Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Sep 26 11:12:46 2012 +0200 wininet: Add a trailing '\n' to a couple of Wine traces. --- dlls/wininet/urlcache.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c index 3be3b15..13633ac 100644 --- a/dlls/wininet/urlcache.c +++ b/dlls/wininet/urlcache.c @@ -1772,7 +1772,7 @@ BOOL WINAPI GetUrlCacheEntryInfoExA( return FALSE; } if (dwFlags & ~GET_INSTALLED_ENTRY) - FIXME("ignorring unsupported flags: %x", dwFlags); + FIXME("ignoring unsupported flags: %x\n", dwFlags); error = URLCacheContainers_FindContainerA(lpszUrl, &pContainer); if (error != ERROR_SUCCESS) @@ -1913,7 +1913,7 @@ BOOL WINAPI GetUrlCacheEntryInfoExW( return FALSE; } if (dwFlags) - FIXME("ignorring unsupported flags: %x", dwFlags); + FIXME("ignoring unsupported flags: %x\n", dwFlags); error = URLCacheContainers_FindContainerW(lpszUrl, &pContainer); if (error != ERROR_SUCCESS)
1
0
0
0
Piotr Caban : wininet: Delete cache directory when cache version doesn' t match.
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: fa0f0630c59c5f13f8d5f2303fb85ebf00ea889e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fa0f0630c59c5f13f8d5f2303…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Sep 26 11:37:55 2012 +0200 wininet: Delete cache directory when cache version doesn't match. --- dlls/wininet/urlcache.c | 41 +++++++++++++++++++++++++++++++++++++++-- 1 files changed, 39 insertions(+), 2 deletions(-) diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c index 36e0a35..3be3b15 100644 --- a/dlls/wininet/urlcache.c +++ b/dlls/wininet/urlcache.c @@ -60,6 +60,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(wininet); +static const char urlcache_ver_prefix[] = "WINE URLCache Ver "; +static const char urlcache_ver[] = "0.2012001"; + #define ENTRY_START_OFFSET 0x4000 #define DIR_LENGTH 8 #define MAX_DIR_NO 0x20 @@ -337,7 +340,8 @@ static DWORD URLCacheContainer_OpenIndex(URLCACHECONTAINER * pContainer, DWORD b HASH_CACHEFILE_ENTRY *pHashEntry; /* First set some constants and defaults in the header */ - strcpy(pHeader->szSignature, "WINE URLCache Ver 0.2005001"); + memcpy(pHeader->szSignature, urlcache_ver_prefix, sizeof(urlcache_ver_prefix)-1); + memcpy(pHeader->szSignature+sizeof(urlcache_ver_prefix)-1, urlcache_ver, sizeof(urlcache_ver)-1); pHeader->dwFileSize = new_file_size; pHeader->dwIndexCapacityInBlocks = blocks_no; /* 127MB - taken from default for Windows 2000 */ @@ -457,8 +461,41 @@ static DWORD URLCacheContainer_OpenIndex(URLCACHECONTAINER * pContainer, DWORD b URLCache_PathToObjectName(wszFilePath, '_'); pContainer->hMapping = OpenFileMappingW(FILE_MAP_WRITE, FALSE, wszFilePath); if (!pContainer->hMapping) + { pContainer->hMapping = CreateFileMappingW(hFile, NULL, PAGE_READWRITE, 0, 0, wszFilePath); - CloseHandle(hFile); + CloseHandle(hFile); + + /* Validate cache index file on first open */ + if (pContainer->hMapping && blocks_no==MIN_BLOCK_NO) + { + URLCACHE_HEADER *pHeader = MapViewOfFile(pContainer->hMapping, FILE_MAP_WRITE, 0, 0, 0); + if (!pHeader) + { + ERR("MapViewOfFile failed (error is %d)\n", GetLastError()); + CloseHandle(pContainer->hMapping); + pContainer->hMapping = NULL; + ReleaseMutex(pContainer->hMutex); + return GetLastError(); + } + + if (!memcmp(pHeader->szSignature, urlcache_ver_prefix, sizeof(urlcache_ver_prefix)-1) && + memcmp(pHeader->szSignature+sizeof(urlcache_ver_prefix)-1, urlcache_ver, sizeof(urlcache_ver)-1)) + { + TRACE("detected wrong version of cache: %s, expected %s\n", pHeader->szSignature, urlcache_ver); + UnmapViewOfFile(pHeader); + + FreeUrlCacheSpaceW(pContainer->path, 100, 0); + } + else + { + UnmapViewOfFile(pHeader); + } + } + } + else + { + CloseHandle(hFile); + } if (!pContainer->hMapping) { ERR("Couldn't create file mapping (error is %d)\n", GetLastError());
1
0
0
0
Piotr Caban : wininet: Don' t ask for confirmation while deleting cache directory.
by Alexandre Julliard
26 Sep '12
26 Sep '12
Module: wine Branch: master Commit: d2e5bb30eb271d8c297a7abc0eb17ee368b88a32 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d2e5bb30eb271d8c297a7abc0…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Wed Sep 26 11:37:41 2012 +0200 wininet: Don't ask for confirmation while deleting cache directory. --- dlls/wininet/urlcache.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/wininet/urlcache.c b/dlls/wininet/urlcache.c index eac3402..36e0a35 100644 --- a/dlls/wininet/urlcache.c +++ b/dlls/wininet/urlcache.c @@ -1657,7 +1657,7 @@ static BOOL URLCache_DeleteCacheDirectory(LPCWSTR lpszPath) shfos.wFunc = FO_DELETE; shfos.pFrom = path; shfos.pTo = NULL; - shfos.fFlags = 0; + shfos.fFlags = FOF_NOCONFIRMATION; shfos.fAnyOperationsAborted = FALSE; ret = SHFileOperationW(&shfos); if (ret)
1
0
0
0
← Newer
1
...
7
8
9
10
11
12
13
...
83
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
Results per page:
10
25
50
100
200