wine-commits September 2012

wine-commits@winehq.org

2 participants
828 discussions

Rico Schüller : d3dx9: Fix ID3DXConstantTable:: GetConstantElement() for structs.
by Alexandre Julliard 04 Sep '12

04 Sep '12

Module: wine Branch: master Commit: b999ab16b3d5f69b3fa4b8c80a3a4d3f690c419e URL: http://source.winehq.org/git/wine.git/?a=commit;h=b999ab16b3d5f69b3fa4b8c80… Author: Rico Schüller <kgbricola(a)web.de> Date: Tue Sep 4 09:44:28 2012 +0200 d3dx9: Fix ID3DXConstantTable::GetConstantElement() for structs. --- dlls/d3dx9_36/shader.c | 2 +- dlls/d3dx9_36/tests/shader.c | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c index 766b897..5745884 100644 --- a/dlls/d3dx9_36/shader.c +++ b/dlls/d3dx9_36/shader.c @@ -1009,7 +1009,7 @@ static D3DXHANDLE WINAPI ID3DXConstantTableImpl_GetConstantElement(ID3DXConstant if (c && index < c->desc.Elements) { - if (c->constants) c = &c->constants[index]; + if (c->desc.Elements > 1) c = &c->constants[index]; TRACE("Returning constant %p\n", c); return handle_from_constant(c); } diff --git a/dlls/d3dx9_36/tests/shader.c b/dlls/d3dx9_36/tests/shader.c index 2792327..ad092ab 100644 --- a/dlls/d3dx9_36/tests/shader.c +++ b/dlls/d3dx9_36/tests/shader.c @@ -1848,6 +1848,12 @@ static void test_get_shader_constant_variables(void) element = ID3DXConstantTable_GetConstantByName(ctable, "s_2[0]", "invalid"); ok(element == NULL, "GetConstantByName failed\n"); + constant = ID3DXConstantTable_GetConstantByName(ctable, NULL, "s_2[0]"); + ok(constant != NULL, "GetConstantByName failed\n"); + + element = ID3DXConstantTable_GetConstantElement(ctable, "s_2[0]", 0); + ok(constant == element, "GetConstantByName failed, got %p, expected %p\n", element, constant); + count = ID3DXConstantTable_Release(ctable); ok(count == 0, "Release failed, got %u, expected %u\n", count, 0); }

1 0

Jason Edmeades : cmd: Fix renaming inside directories.
by Alexandre Julliard 04 Sep '12

04 Sep '12

Module: wine Branch: master Commit: c5a72379a1fd8b61e649ff3c45225b7111ec1249 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c5a72379a1fd8b61e649ff3c4… Author: Jason Edmeades <jason(a)edmeades.me.uk> Date: Mon Sep 3 22:48:08 2012 +0100 cmd: Fix renaming inside directories. --- programs/cmd/builtins.c | 2 +- programs/cmd/tests/test_builtins.cmd.exp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c index c92822b..16f4eff 100644 --- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -1872,7 +1872,7 @@ void WCMD_rename (void) } /* Destination cannot contain a drive letter or directory separator */ - if ((strchrW(param1,':') != NULL) || (strchrW(param1,'\\') != NULL)) { + if ((strchrW(param2,':') != NULL) || (strchrW(param2,'\\') != NULL)) { SetLastError(ERROR_INVALID_PARAMETER); WCMD_print_error(); errorlevel = 1; diff --git a/programs/cmd/tests/test_builtins.cmd.exp b/programs/cmd/tests/test_builtins.cmd.exp index c444be6..b7bcd96 100644 --- a/programs/cmd/tests/test_builtins.cmd.exp +++ b/programs/cmd/tests/test_builtins.cmd.exp @@ -629,8 +629,8 @@ read-only file renamed dir renamed read-only dir renamed --- rename in other directory -@todo_wine@rename impossible in other directory -@todo_wine@original file still present +rename impossible in other directory +original file still present ------------ Testing move ------------ --- file move file move succeeded

1 0

Jason Edmeades : cmd: Fix rmdir error during recursive delete.
by Alexandre Julliard 04 Sep '12

04 Sep '12

Module: wine Branch: master Commit: 94f9e789c94f90dad3d771cdabded15aeeedba8f URL: http://source.winehq.org/git/wine.git/?a=commit;h=94f9e789c94f90dad3d771cda… Author: Jason Edmeades <us(a)edmeades.me.uk> Date: Mon Sep 3 22:03:58 2012 +0100 cmd: Fix rmdir error during recursive delete. --- programs/cmd/builtins.c | 4 ++++ programs/cmd/tests/test_builtins.cmd | 2 +- 2 files changed, 5 insertions(+), 1 deletions(-) diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c index a83947b..c92822b 100644 --- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -1827,6 +1827,10 @@ void WCMD_remove_dir (WCHAR *command) { lpDir.pFrom = thisArg; lpDir.fFlags = FOF_SILENT | FOF_NOCONFIRMATION | FOF_NOERRORUI; lpDir.wFunc = FO_DELETE; + + /* SHFileOperationW needs file list with a double null termination */ + thisArg[lstrlenW(thisArg) + 1] = 0x00; + if (SHFileOperationW(&lpDir)) WCMD_print_error (); } } diff --git a/programs/cmd/tests/test_builtins.cmd b/programs/cmd/tests/test_builtins.cmd index 36bc73f..13b53c5 100644 --- a/programs/cmd/tests/test_builtins.cmd +++ b/programs/cmd/tests/test_builtins.cmd @@ -1163,7 +1163,7 @@ if not exist foo ( ) mkdir foo\bar\baz echo foo > foo\bar\brol -rmdir /s /Q foo +rmdir /s /Q foo 2>&1 if not exist foo ( echo recursive rmdir succeeded ) else (

1 0

Alexandre Julliard : winex11: Store the rectangle of the GL drawable and use it when updating the window size .
by Alexandre Julliard 04 Sep '12

04 Sep '12

Module: wine Branch: master Commit: 514eb695846b45c89c0fc0d56653d187f1840eec URL: http://source.winehq.org/git/wine.git/?a=commit;h=514eb695846b45c89c0fc0d56… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Sep 4 15:03:04 2012 +0200 winex11: Store the rectangle of the GL drawable and use it when updating the window size. --- dlls/winex11.drv/opengl.c | 70 ++++++++++++++++++++++++++++---------------- dlls/winex11.drv/window.c | 58 +------------------------------------ dlls/winex11.drv/x11drv.h | 2 +- 3 files changed, 46 insertions(+), 84 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=514eb695846b45c89c0fc…

1 0

Alexandre Julliard : winex11: Create the whole window at window creation time.
by Alexandre Julliard 04 Sep '12

04 Sep '12

Module: wine Branch: master Commit: ea07c310ecfee6b301e7af8413760eb446e6f184 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ea07c310ecfee6b301e7af841… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Sep 4 13:34:15 2012 +0200 winex11: Create the whole window at window creation time. --- dlls/winex11.drv/opengl.c | 3 +-- dlls/winex11.drv/systray.c | 5 +---- dlls/winex11.drv/window.c | 29 ++++++++--------------------- dlls/winex11.drv/x11drv.h | 1 - 4 files changed, 10 insertions(+), 28 deletions(-) diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c index a2d88a0..b23ec98 100644 --- a/dlls/winex11.drv/opengl.c +++ b/dlls/winex11.drv/opengl.c @@ -1176,8 +1176,7 @@ BOOL set_win_format( HWND hwnd, XID fbconfig_id ) if (!(format = pixelformat_from_fbconfig_id( fbconfig_id ))) return FALSE; - if (!(data = X11DRV_get_win_data(hwnd)) && - !(data = X11DRV_create_win_data(hwnd))) return FALSE; + if (!(data = X11DRV_get_win_data(hwnd))) return FALSE; gl = HeapAlloc( GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(*gl) ); gl->pixel_format = format; diff --git a/dlls/winex11.drv/systray.c b/dlls/winex11.drv/systray.c index 7efc63d..f46ea29 100644 --- a/dlls/winex11.drv/systray.c +++ b/dlls/winex11.drv/systray.c @@ -517,10 +517,7 @@ static void dock_systray_icon( Display *display, struct tray_icon *icon, Window icon->window = CreateWindowW( icon_classname, NULL, WS_CLIPSIBLINGS | WS_POPUP, CW_USEDEFAULT, CW_USEDEFAULT, icon_cx, icon_cy, NULL, NULL, NULL, icon ); - if (!icon->window) return; - - if (!(data = X11DRV_get_win_data( icon->window )) && - !(data = X11DRV_create_win_data( icon->window ))) return; + if (!(data = X11DRV_get_win_data( icon->window ))) return; TRACE( "icon window %p/%lx managed %u\n", data->hwnd, data->whole_window, data->managed ); diff --git a/dlls/winex11.drv/window.c b/dlls/winex11.drv/window.c index 7d2d1e2..e5b731c 100644 --- a/dlls/winex11.drv/window.c +++ b/dlls/winex11.drv/window.c @@ -911,12 +911,9 @@ static Window get_owner_whole_window( HWND owner, BOOL force_managed ) if (!owner) return 0; - if (!(data = X11DRV_get_win_data( owner ))) - { - if (!(data = X11DRV_create_win_data( owner ))) - return (Window)GetPropA( owner, whole_window_prop ); - } - else if (!data->managed && force_managed) /* make it managed */ + if (!(data = X11DRV_get_win_data( owner ))) return (Window)GetPropA( owner, whole_window_prop ); + + if (!data->managed && force_managed) /* make it managed */ { SetWindowPos( owner, 0, 0, 0, 0, 0, SWP_NOACTIVATE | SWP_NOZORDER | SWP_NOSIZE | SWP_NOMOVE | @@ -1722,7 +1719,8 @@ struct x11drv_win_data *X11DRV_get_win_data( HWND hwnd ) * * Create an X11 data window structure for an existing window. */ -struct x11drv_win_data *X11DRV_create_win_data( HWND hwnd ) +static struct x11drv_win_data *X11DRV_create_win_data( HWND hwnd, const RECT *window_rect, + const RECT *client_rect ) { Display *display; struct x11drv_win_data *data; @@ -1733,16 +1731,11 @@ struct x11drv_win_data *X11DRV_create_win_data( HWND hwnd ) /* don't create win data for HWND_MESSAGE windows */ if (parent != GetDesktopWindow() && !GetAncestor( parent, GA_PARENT )) return NULL; - if (GetWindowThreadProcessId( hwnd, NULL ) != GetCurrentThreadId()) return NULL; - display = thread_init_display(); if (!(data = alloc_win_data( display, hwnd ))) return NULL; - GetWindowRect( hwnd, &data->window_rect ); - MapWindowPoints( 0, parent, (POINT *)&data->window_rect, 2 ); - data->whole_rect = data->window_rect; - GetClientRect( hwnd, &data->client_rect ); - MapWindowPoints( hwnd, parent, (POINT *)&data->client_rect, 2 ); + data->whole_rect = data->window_rect = *window_rect; + data->client_rect = *client_rect; if (parent == GetDesktopWindow()) { @@ -2076,14 +2069,8 @@ void CDECL X11DRV_WindowPosChanging( HWND hwnd, HWND insert_after, UINT swp_flag const RECT *window_rect, const RECT *client_rect, RECT *visible_rect ) { struct x11drv_win_data *data = X11DRV_get_win_data( hwnd ); - DWORD style = GetWindowLongW( hwnd, GWL_STYLE ); - if (!data) - { - /* create the win data if the window is being made visible */ - if (!(style & WS_VISIBLE) && !(swp_flags & SWP_SHOWWINDOW)) return; - if (!(data = X11DRV_create_win_data( hwnd ))) return; - } + if (!data && !(data = X11DRV_create_win_data( hwnd, window_rect, client_rect ))) return; /* check if we need to switch the window to managed */ if (!data->managed && data->whole_window && is_window_managed( hwnd, swp_flags, window_rect )) diff --git a/dlls/winex11.drv/x11drv.h b/dlls/winex11.drv/x11drv.h index d1db819..eae047a 100644 --- a/dlls/winex11.drv/x11drv.h +++ b/dlls/winex11.drv/x11drv.h @@ -551,7 +551,6 @@ struct x11drv_win_data }; extern struct x11drv_win_data *X11DRV_get_win_data( HWND hwnd ) DECLSPEC_HIDDEN; -extern struct x11drv_win_data *X11DRV_create_win_data( HWND hwnd ) DECLSPEC_HIDDEN; extern Window X11DRV_get_whole_window( HWND hwnd ) DECLSPEC_HIDDEN; extern XIC X11DRV_get_ic( HWND hwnd ) DECLSPEC_HIDDEN;

1 0

Alexandre Julliard : server: Always repaint the whole non-client area if part of it is exposed.
by Alexandre Julliard 04 Sep '12

04 Sep '12

Module: wine Branch: master Commit: a76f60d14ef8f30063219f9b333d88e24f7d5865 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a76f60d14ef8f30063219f9b3… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Sep 4 13:37:46 2012 +0200 server: Always repaint the whole non-client area if part of it is exposed. --- server/window.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/server/window.c b/server/window.c index fefe1ac..b6fcde0 100644 --- a/server/window.c +++ b/server/window.c @@ -1631,6 +1631,14 @@ static void set_window_pos( struct window *win, struct window *previous, client_rect->bottom - old_client_rect.bottom != y_offset || !valid_rects || memcmp( &valid_rects[0], client_rect, sizeof(*client_rect) )); + /* if part of the non-client area was exposed, consider it changed */ + if (exposed_rgn && !frame_changed) + { + get_region_extents( exposed_rgn, &rect ); + offset_rect( &rect, client_rect->left, client_rect->top ); + frame_changed = (rect.left < client_rect->left || rect.top < client_rect->top || + rect.right > client_rect->right || rect.bottom > client_rect->bottom); + } } if (frame_changed || client_changed)

1 0

Alexandre Julliard : user32: Only show a window the first time WS_VISIBLE is toggled, to work around Steam's WM_SETREDRAW usage.
by Alexandre Julliard 04 Sep '12

04 Sep '12

Module: wine Branch: master Commit: 2dc234d923b70fa0a0e1815d909035d059aa8772 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2dc234d923b70fa0a0e1815d9… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Sep 4 12:38:33 2012 +0200 user32: Only show a window the first time WS_VISIBLE is toggled, to work around Steam's WM_SETREDRAW usage. --- dlls/user32/win.c | 58 +++++++++++++++++++++++++++++++------------------- dlls/user32/win.h | 1 + dlls/user32/winpos.c | 3 ++ 3 files changed, 40 insertions(+), 22 deletions(-) diff --git a/dlls/user32/win.c b/dlls/user32/win.c index 66fc8cc..82d62b1 100644 --- a/dlls/user32/win.c +++ b/dlls/user32/win.c @@ -606,7 +606,7 @@ HWND WIN_SetOwner( HWND hwnd, HWND owner ) */ ULONG WIN_SetStyle( HWND hwnd, ULONG set_bits, ULONG clear_bits ) { - BOOL ok; + BOOL ok, needs_show = FALSE; STYLESTRUCT style; WND *win = WIN_GetPtr( hwnd ); @@ -638,20 +638,29 @@ ULONG WIN_SetStyle( HWND hwnd, ULONG set_bits, ULONG clear_bits ) } } SERVER_END_REQ; - WIN_ReleasePtr( win ); - if (ok) + + if (ok && ((style.styleOld ^ style.styleNew) & WS_VISIBLE)) { - if ((style.styleOld ^ style.styleNew) & WS_VISIBLE) - { - RECT window_rect, client_rect; - UINT flags = style.styleNew & WS_VISIBLE ? SWP_SHOWWINDOW : 0; /* we don't hide it */ + /* Some apps try to make their window visible through WM_SETREDRAW. + * Only do that if the window was never explicitly hidden, + * because Steam messes with WM_SETREDRAW after hiding its windows. */ + needs_show = !(win->flags & WIN_HIDDEN) && (style.styleNew & WS_VISIBLE); + invalidate_dce( win, NULL ); + } + WIN_ReleasePtr( win ); - WIN_GetRectangles( hwnd, COORDS_PARENT, &window_rect, &client_rect ); - set_window_pos( hwnd, 0, SWP_NOSIZE | SWP_NOMOVE | SWP_NOCLIENTSIZE | SWP_NOCLIENTMOVE | - SWP_NOZORDER | SWP_NOACTIVATE | flags, &window_rect, &client_rect, NULL ); - } - USER_Driver->pSetWindowStyle( hwnd, GWL_STYLE, &style ); + if (!ok) return 0; + + if (needs_show) + { + RECT window_rect, client_rect; + WIN_GetRectangles( hwnd, COORDS_PARENT, &window_rect, &client_rect ); + set_window_pos( hwnd, 0, SWP_NOSIZE | SWP_NOMOVE | SWP_NOCLIENTSIZE | SWP_NOCLIENTMOVE | + SWP_NOZORDER | SWP_NOACTIVATE | SWP_SHOWWINDOW, + &window_rect, &client_rect, NULL ); } + + USER_Driver->pSetWindowStyle( hwnd, GWL_STYLE, &style ); return style.styleOld; } @@ -2135,7 +2144,7 @@ static LONG_PTR WIN_GetWindowLong( HWND hwnd, INT offset, UINT size, BOOL unicod LONG_PTR WIN_SetWindowLong( HWND hwnd, INT offset, UINT size, LONG_PTR newval, BOOL unicode ) { STYLESTRUCT style; - BOOL ok; + BOOL ok, needs_show = FALSE; LONG_PTR retval = 0; WND *wndPtr; @@ -2334,23 +2343,28 @@ LONG_PTR WIN_SetWindowLong( HWND hwnd, INT offset, UINT size, LONG_PTR newval, B } } SERVER_END_REQ; + + if (offset == GWL_STYLE && ((style.styleOld ^ style.styleNew) & WS_VISIBLE)) + { + needs_show = !(wndPtr->flags & WIN_HIDDEN) && (style.styleNew & WS_VISIBLE); + invalidate_dce( wndPtr, NULL ); + } WIN_ReleasePtr( wndPtr ); if (!ok) return 0; + if (needs_show) + { + RECT window_rect, client_rect; + WIN_GetRectangles( hwnd, COORDS_PARENT, &window_rect, &client_rect ); + set_window_pos( hwnd, 0, SWP_NOSIZE | SWP_NOMOVE | SWP_NOCLIENTSIZE | SWP_NOCLIENTMOVE | + SWP_NOZORDER | SWP_NOACTIVATE | SWP_SHOWWINDOW, + &window_rect, &client_rect, NULL ); + } if (offset == GWL_STYLE || offset == GWL_EXSTYLE) { style.styleOld = retval; style.styleNew = newval; - if (offset == GWL_STYLE && ((style.styleOld ^ style.styleNew) & WS_VISIBLE)) - { - RECT window_rect, client_rect; - UINT flags = style.styleNew & WS_VISIBLE ? SWP_SHOWWINDOW : 0; /* we don't hide it */ - - WIN_GetRectangles( hwnd, COORDS_PARENT, &window_rect, &client_rect ); - set_window_pos( hwnd, 0, SWP_NOSIZE | SWP_NOMOVE | SWP_NOCLIENTSIZE | SWP_NOCLIENTMOVE | - SWP_NOZORDER | SWP_NOACTIVATE | flags, &window_rect, &client_rect, NULL ); - } USER_Driver->pSetWindowStyle( hwnd, offset, &style ); SendMessageW( hwnd, WM_STYLECHANGED, offset, (LPARAM)&style ); } diff --git a/dlls/user32/win.h b/dlls/user32/win.h index 13ee58e..7c899ac 100644 --- a/dlls/user32/win.h +++ b/dlls/user32/win.h @@ -73,6 +73,7 @@ typedef struct tagWND #define WIN_ISUNICODE 0x0010 /* Window is Unicode */ #define WIN_NEEDS_SHOW_OWNEDPOPUP 0x0020 /* WM_SHOWWINDOW:SC_SHOW must be sent in the next ShowOwnedPopup call */ #define WIN_CHILDREN_MOVED 0x0040 /* children may have moved, ignore stored positions */ +#define WIN_HIDDEN 0x0080 /* hidden by an explicit SWP_HIDEWINDOW (as opposed to WM_SETREDRAW) */ /* Window functions */ extern HWND get_hwnd_message_parent(void) DECLSPEC_HIDDEN; diff --git a/dlls/user32/winpos.c b/dlls/user32/winpos.c index 23b0b7f..507a5ce 100644 --- a/dlls/user32/winpos.c +++ b/dlls/user32/winpos.c @@ -1872,6 +1872,9 @@ static BOOL fixup_flags( WINDOWPOS *winpos ) parent = GetAncestor( winpos->hwnd, GA_PARENT ); if (!IsWindowVisible( parent )) winpos->flags |= SWP_NOREDRAW; + if (winpos->flags & SWP_HIDEWINDOW) wndPtr->flags |= WIN_HIDDEN; + else if (winpos->flags & SWP_SHOWWINDOW) wndPtr->flags &= ~WIN_HIDDEN; + if (wndPtr->dwStyle & WS_VISIBLE) winpos->flags &= ~SWP_SHOWWINDOW; else {

1 0

Kyle Auble : Move Spanish patch guide to wiki
by Jeremy Newman 04 Sep '12

04 Sep '12

Module: website Branch: master Commit: f418f863859805a1dba5c57a9bcd29ac8a0e1522 URL: http://source.winehq.org/git/website.git/?a=commit;h=f418f863859805a1dba5c5… Author: Kyle Auble <randomidman48(a)yahoo.com> Date: Sun Sep 2 22:34:04 2012 -0700 Move Spanish patch guide to wiki --- templates/es/sending_patches.template | 119 --------------------------------- 1 files changed, 0 insertions(+), 119 deletions(-) diff --git a/templates/es/sending_patches.template b/templates/es/sending_patches.template deleted file mode 100644 index 38cbb58..0000000 --- a/templates/es/sending_patches.template +++ /dev/null @@ -1,119 +0,0 @@ - - - -<h1>Generando y enviando parches</h1> - -<p><b>Nota</b>: esto es una referencia rápida sobre como enviarnos -parches. Para obtener instrucciones detalladas por favor vea el -capítulo -<a href="{$root}/docs/winedev-guide/codingpractice">Práctica de -codificación</a> en nuestra documentación en linea. -</p> - -<p> Por favor envie los parches a la lista de correo de parches de -Wine, <a href="mailto:wine-patches@winehq.org"> -wine-patches(a)winehq.org </a>. -(Tenga en cuenta que si usted no está <a href="{$root}/forums">suscrito</a> -a la lista de correo, los administradores de la lista de correo -deben comprobar primero su envío para asegurarse de que no se trata de spam -antes de que se pueda aceptar el parche. -No habrá ningún intento de aplicar los parches que no aparezcan en el grupo de noticias -o en cualquier otro lugar que no sea el árbol Git) -</p> - -<p> Al presentar parches, por favor: </p> -<ul> - <li>Incluya una entrada del fichero de cambios (ChangeLog) con su - <b>nombre real</b>, dirección de correo electrónico y - una descripción de lo que hace el parche. - - <li>Mantenga el parche pequeño y el punto del cambio claro. - - <li>Envíe un arreglo o grupo de cambios relacionados por parche. - - <li>Genere su parche de nuevo con la versión más reciente de Wine desde el árbol Git WineHQ (véase más adelante). - - <li>Pon a prueba tu parche, y si es posible escribe una prueba que demuestre que es correcto. - - <li>Tenga cuidado de no corromper el parche a través de envolturas de línea. - - <li>Evite innecesariamente cambios de formateo del código. - - <li>No mezcle tabuladores y espacios porque hace que la salida diff sea ilegible, use identación consistente. - - <li>Use C estándar, evite comentarios C++ y declaraciones de variables en línea. - - <li>Lea el diff y asegúrese de que contenga sólo lo que quiere en él. -</ul> - -<p>Los parches aceptados se publicarán en la lista de correo <a href="{$root}/forums">wine-cvs </a>. - -<p>Los parches con problemas evidentes pueden recibir una respuesta en wine-devel. - -<p>Algunos parches no podrán recibir ninguna respuesta. En ese caso, su parche - puede considerarse <i>Obviamente No Correcto</i>, y puede hacer lo siguiente: - -<ul> - <li> Compruebe el parche usted mismo, y piense en lo que se puede hacer para - aclarar el parche (pistas en la lista anterior). - - <li> Escribir un correo electrónico a wine-devel, explicando el parche y solicitud para que sea - examinado por cualquier persona encargada de revisar. - - <li> Pida consejo acerca de su parche en #winehackers. - - <li> A menos que ya existe uno, abra un bug en bugzilla describiendo el - problema que está tratando de resolver (por ejemplo: ./configure falla en Solaris, - etc) y adjuntar su parche. -</ ul> - -<p> - Si el parche no ha recibido una respuesta en 3 días del WineHQ Git confirma - que tu parche tiene una gran oportunidad de estar en esta categoría. - <br/> - Tal vez le resulte difícil el solicitar información, - a fin de reflexionar cuidadosamente sobre los comentarios que recibe. - <br/> - ¡Simplemente no se dé por vencido! -</p> - -<hr> - -<h2>Generación de un parche para WineHQ con Git</h2> - -<p> Es mejor enviar pequeños parches contra el actual árbol utilizando Git. -En primer lugar, asegúrese de que su árbol es hasta la fecha, tal y como -se describe en la página <a href="http://wiki.winehq.org/GitWine">Git</a>. - -<p>Compruebe sus parches en su árbol Git utilizando -<a href="http://www.kernel.org/pub/software/scm/git/docs/git-commit.html">git commit</a>.</p> - -<p> Si va a utilizar -<a href="http://www.kernel.org/pub/software/scm/git/docs/git-imap-send.html">git imap-send</a> -asegúrese de que ha creado las opciones adecuadas en su fichero de -configuración de Git, y a continuación, ejecute:</p> - - <table width="700" border=0 cellpadding=10><tr><td class=black> - <span class=inverse> - git format-patch --stdout --keep-subject --attach origin | git imap-send<br> - </span> - </td></tr> - </table> - -<p>Esto debería subir sus parches en su carpeta de proyectos IMAP, y -le permitirá comprobar y enviarlos. En Mozilla Thunderbird, eso es tan -simple como hacer clic en "Editar Proyecto..." y luego "Enviar" si -tiene configurado el archivo de cabeceras de correo Git correctamente. - -<p>Si usted no puede utilizar IMAP, utilice el siguiente comando para generar parches:</p> - - <table width="700" border=0 cellpadding=10><tr><td class=black> - <span class=inverse> - git format-patch --keep-subject origin<br> - </span> - </td></tr> - </table> - -<p>Esto debería generar una serie de archivos txt, que puede enviar manualmente.</p> - -<p> </p>

1 0

Kyle Auble : Delete moved acknowledgement pages
by Jeremy Newman 04 Sep '12

04 Sep '12

Module: website Branch: master Commit: dac02682581cfaf8477aa9dcd5620f21e1f5b534 URL: http://source.winehq.org/git/website.git/?a=commit;h=dac02682581cfaf8477aa9… Author: Kyle Auble <randomidman48(a)yahoo.com> Date: Sun Sep 2 22:33:54 2012 -0700 Delete moved acknowledgement pages --- templates/de/acknowledgement.template | 209 -------------------------------- templates/en/acknowledgement.template | 207 ------------------------------- templates/he/acknowledgement.template | 195 ------------------------------ templates/pl/acknowledgement.template | 206 ------------------------------- templates/pt/acknowledgement.template | 214 --------------------------------- 5 files changed, 0 insertions(+), 1031 deletions(-) Diff: http://source.winehq.org/git/website.git/?a=commitdiff;h=dac02682581cfaf847…

1 0

Kyle Auble : Redirect acknowledgement links to wiki
by Jeremy Newman 04 Sep '12

04 Sep '12

Module: website Branch: master Commit: 6f1d3490367ad1fcbc949b5e6d5bbe2ef69a7c96 URL: http://source.winehq.org/git/website.git/?a=commit;h=6f1d3490367ad1fcbc949b… Author: Kyle Auble <randomidman48(a)yahoo.com> Date: Sun Sep 2 22:33:34 2012 -0700 Redirect acknowledgement links to wiki --- templates/pl/about.template | 2 +- templates/pt/about.template | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/pl/about.template b/templates/pl/about.template index f8a72f0..2301289 100644 --- a/templates/pl/about.template +++ b/templates/pl/about.template @@ -38,7 +38,7 @@ Julliard kieruje projektem Wine, i można się z nim skontaktować przez e-mail <li><a href="http://wiki.winehq.org/ImportanceOfWine">Dlaczego Wine jest tak ważny</a></li> <li><a href="http://wiki.winehq.org/Debunking_Wine_Myths">Obalanie mitów o Wine</a></li> <li><a href="http://wiki.winehq.org/WineFeatures">Możliwości Wine</a></li> - <li><a href="{$root}/acknowledgement">Dowody uznania</a></li> + <li><a href="http://wiki.winehq.org/DowodyUznania">Dowody uznania</a></li> <li><a href="{$root}/wwn">World Wine News</a></li> <li><a href="{$root}/interview">Wywiady</a></li> </ul> diff --git a/templates/pt/about.template b/templates/pt/about.template index b0ee4de..ef35e2c 100644 --- a/templates/pt/about.template +++ b/templates/pt/about.template @@ -40,7 +40,7 @@ projecto:</p> <li><a href="http://wiki.winehq.org/ImportanceOfWine">Porque é que o Wine é importante</a></li> <li><a href="http://wiki.winehq.org/Debunking_Wine_Myths">Clarificação dos Mitos do Wine</a></li> <li><a href="http://wiki.winehq.org/WineFeatures">Características do Wine</a></li> - <li><a href="{$root}/acknowledgement">Agradecimentos</a></li> + <li><a href="http://wiki.winehq.org/Agradecimentos">Agradecimentos</a></li> <li><a href="{$root}/wwn">World Wine News</a></li> <li><a href="{$root}/interview">Entrevistas</a></li> </ul>

1 0

← Newer
1
...
76
77
78
79
80
81
82
83
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits September 2012