wine-commits January 2013

wine-commits@winehq.org

2 participants
736 discussions

Henri Verbeet : d3drm: Avoid LPDDPIXELFORMAT.
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: wine Branch: master Commit: bb163ef0b95b4946da44a563138e4745b702808d URL: http://source.winehq.org/git/wine.git/?a=commit;h=bb163ef0b95b4946da44a5631… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Jan 22 11:34:06 2013 +0100 d3drm: Avoid LPDDPIXELFORMAT. --- dlls/d3drm/device.c | 6 ++---- include/d3drmobj.h | 2 +- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/dlls/d3drm/device.c b/dlls/d3drm/device.c index ed6055b..6d72d92 100644 --- a/dlls/d3drm/device.c +++ b/dlls/d3drm/device.c @@ -904,10 +904,8 @@ static HRESULT WINAPI IDirect3DRMDevice3Impl_GetDirect3DDevice2(IDirect3DRMDevic } /*** IDirect3DRMDevice3 methods ***/ -static HRESULT WINAPI IDirect3DRMDevice3Impl_FindPreferredTextureFormat(IDirect3DRMDevice3* iface, - DWORD bitdepths, - DWORD flags, - LPDDPIXELFORMAT lpDDPF) +static HRESULT WINAPI IDirect3DRMDevice3Impl_FindPreferredTextureFormat(IDirect3DRMDevice3 *iface, + DWORD bitdepths, DWORD flags, DDPIXELFORMAT *lpDDPF) { IDirect3DRMDeviceImpl *This = impl_from_IDirect3DRMDevice3(iface); diff --git a/include/d3drmobj.h b/include/d3drmobj.h index 11922c5..69ab35d 100644 --- a/include/d3drmobj.h +++ b/include/d3drmobj.h @@ -678,7 +678,7 @@ DECLARE_INTERFACE_(IDirect3DRMDevice3,IDirect3DRMObject) STDMETHOD_(DWORD, GetRenderMode)(THIS) PURE; STDMETHOD(GetDirect3DDevice2)(THIS_ IDirect3DDevice2 **device) PURE; /*** IDirect3DRMDevice3 methods ***/ - STDMETHOD(FindPreferredTextureFormat)(THIS_ DWORD BitDepths, DWORD flags, LPDDPIXELFORMAT pDDPF) PURE; + STDMETHOD(FindPreferredTextureFormat)(THIS_ DWORD BitDepths, DWORD flags, DDPIXELFORMAT *format) PURE; STDMETHOD(RenderStateChange)(THIS_ D3DRENDERSTATETYPE drsType, DWORD val, DWORD flags) PURE; STDMETHOD(LightStateChange)(THIS_ D3DLIGHTSTATETYPE drsType, DWORD val, DWORD flags) PURE; STDMETHOD(GetStateChangeOptions)(THIS_ DWORD StateClass, DWORD StateNum, LPDWORD pFlags) PURE;

1 0

Henri Verbeet : d3drm: Avoid LPD3DRECT.
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: wine Branch: master Commit: c309046cb1b9b29526db5314a7e00880001d9d54 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c309046cb1b9b29526db5314a… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Tue Jan 22 11:34:05 2013 +0100 d3drm: Avoid LPD3DRECT. --- include/d3drmobj.h | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/d3drmobj.h b/include/d3drmobj.h index 5e50abe..11922c5 100644 --- a/include/d3drmobj.h +++ b/include/d3drmobj.h @@ -157,8 +157,9 @@ typedef struct IDirect3DRMClippedVisual *LPDIRECT3DRMCLIPPEDVISUAL, **LPLPDIRE typedef void (__cdecl *D3DRMOBJECTCALLBACK)(LPDIRECT3DRMOBJECT obj, LPVOID arg); typedef void (__cdecl *D3DRMFRAMEMOVECALLBACK)(LPDIRECT3DRMFRAME obj, LPVOID arg, D3DVALUE delta); typedef void (__cdecl *D3DRMFRAME3MOVECALLBACK)(LPDIRECT3DRMFRAME3 obj, LPVOID arg, D3DVALUE delta); -typedef void (__cdecl *D3DRMUPDATECALLBACK)(LPDIRECT3DRMDEVICE obj, LPVOID arg, int, LPD3DRECT); -typedef void (__cdecl *D3DRMDEVICE3UPDATECALLBACK)(LPDIRECT3DRMDEVICE3 obj, LPVOID arg, int, LPD3DRECT); +typedef void (__cdecl *D3DRMUPDATECALLBACK)(struct IDirect3DRMDevice *device, void *ctx, int count, D3DRECT *rects); +typedef void (__cdecl *D3DRMDEVICE3UPDATECALLBACK)(struct IDirect3DRMDevice3 *device, void *ctx, + int count, D3DRECT *rects); typedef int (__cdecl *D3DRMUSERVISUALCALLBACK)(LPDIRECT3DRMUSERVISUAL obj, LPVOID arg, D3DRMUSERVISUALREASON reason, LPDIRECT3DRMDEVICE dev, LPDIRECT3DRMVIEWPORT view); typedef HRESULT (__cdecl *D3DRMLOADTEXTURECALLBACK)(char *tex_name, void *arg, LPDIRECT3DRMTEXTURE *);

1 0

Nikolay Sivov : xmllite: Implement end tag parsing.
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: wine Branch: master Commit: fad7e7a011c187ee48f59372bdc4e6475c60531b URL: http://source.winehq.org/git/wine.git/?a=commit;h=fad7e7a011c187ee48f59372b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 22 13:11:51 2013 +0400 xmllite: Implement end tag parsing. --- dlls/xmllite/reader.c | 60 ++++++++++++++++++++++++++++++++++++++++--- dlls/xmllite/tests/reader.c | 52 +++++++++++++++++++++++++++++++++++- 2 files changed, 106 insertions(+), 6 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index e0e6542..647af24 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -69,6 +69,7 @@ static const WCHAR utf8W[] = {'U','T','F','-','8',0}; static const WCHAR dblquoteW[] = {'\"',0}; static const WCHAR quoteW[] = {'\'',0}; +static const WCHAR gtW[] = {'>',0}; struct xml_encoding_data { @@ -299,6 +300,14 @@ static void reader_free_strvalues(xmlreader *reader) reader_free_strvalue(reader, type); } +/* This helper should only be used to test if strings are the same, + it doesn't try to sort. */ +static inline int strval_eq(const strval *str1, const strval *str2) +{ + if (str1->len != str2->len) return 0; + return !memcmp(str1->str, str2->str, str1->len*sizeof(WCHAR)); +} + static void reader_clear_elements(xmlreader *reader) { struct element *elem, *elem2; @@ -338,6 +347,18 @@ static HRESULT reader_push_element(xmlreader *reader, strval *qname) return hr; } +static void reader_pop_element(xmlreader *reader) +{ + struct element *elem = LIST_ENTRY(list_head(&reader->elements), struct element, entry); + + if (elem) + { + list_remove(&elem->entry); + reader_free_strvalued(reader, &elem->qname); + reader_free(reader, elem); + } +} + /* always make a copy, cause strings are supposed to be null terminated */ static void reader_set_strvalue(xmlreader *reader, XmlReaderStringValue type, const strval *value) { @@ -1465,7 +1486,6 @@ static HRESULT reader_parse_qname(xmlreader *reader, strval *prefix, strval *loc static HRESULT reader_parse_stag(xmlreader *reader, strval *prefix, strval *local, strval *qname, int *empty) { static const WCHAR endW[] = {'/','>',0}; - static const WCHAR gtW[] = {'>',0}; HRESULT hr; /* skip '<' */ @@ -1477,7 +1497,12 @@ static HRESULT reader_parse_stag(xmlreader *reader, strval *prefix, strval *loca reader_skipspaces(reader); /* empty element */ - if ((*empty = !reader_cmp(reader, endW))) return S_OK; + if ((*empty = !reader_cmp(reader, endW))) + { + /* skip '/>' */ + reader_skipn(reader, 2); + return S_OK; + } /* got a start tag */ if (!reader_cmp(reader, gtW)) @@ -1528,8 +1553,35 @@ static HRESULT reader_parse_element(xmlreader *reader) /* [13 NS] ETag ::= '</' QName S? '>' */ static HRESULT reader_parse_endtag(xmlreader *reader) { - FIXME("ETag parsing not implemented\n"); - return E_NOTIMPL; + strval prefix, local, qname; + struct element *elem; + HRESULT hr; + + /* skip '</' */ + reader_skipn(reader, 2); + + hr = reader_parse_qname(reader, &prefix, &local, &qname); + if (FAILED(hr)) return hr; + + reader_skipspaces(reader); + + if (reader_cmp(reader, gtW)) return WC_E_GREATERTHAN; + + /* skip '>' */ + reader_skipn(reader, 1); + + /* Element stack should never be empty at this point, cause we shouldn't get to + content parsing if it's empty. */ + elem = LIST_ENTRY(list_head(&reader->elements), struct element, entry); + if (!strval_eq(&elem->qname, &qname)) return WC_E_ELEMENTMATCH; + + reader_pop_element(reader); + + reader->nodetype = XmlNodeType_EndElement; + reader_set_strvalue(reader, StringValue_LocalName, &local); + reader_set_strvalue(reader, StringValue_QualifiedName, &qname); + + return S_OK; } /* [43] content ::= CharData? ((element | Reference | CDSect | PI | Comment) CharData?)* */ diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index 8a1f3f7..babb1c9 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -888,6 +888,8 @@ static const char misc_test_xml[] = " \t \r \n" "" "<a>" + "" + "</a>" ; static struct nodes_test misc_test = { @@ -900,6 +902,8 @@ static struct nodes_test misc_test = { XmlNodeType_Whitespace, XmlNodeType_Comment, XmlNodeType_Element, + XmlNodeType_Element, + XmlNodeType_EndElement, XmlNodeType_None } }; @@ -1032,13 +1036,15 @@ static struct test_entry element_tests[] = { { "<a>", "a", "", S_OK }, { "<a >", "a", "", S_OK }, { "<a \r \t\n>", "a", "", S_OK }, + { "</a>", NULL, NULL, NC_E_QNAMECHARACTER }, { NULL } }; static void test_read_element(void) { struct test_entry *test = element_tests; - static const char stag[] = "<a>"; + static const char stag[] = "<a></a>"; + static const char mismatch[] = "<a>"; IXmlReader *reader; XmlNodeType type; IStream *stream; @@ -1090,7 +1096,8 @@ static void test_read_element(void) test++; } - stream = create_stream_on_data(stag, strlen(stag)+1); + /* test reader depth increment */ + stream = create_stream_on_data(stag, sizeof(stag)); hr = IXmlReader_SetInput(reader, (IUnknown*)stream); ok(hr == S_OK, "got %08x\n", hr); @@ -1115,6 +1122,47 @@ static void test_read_element(void) ok(hr == S_OK, "got %08x\n", hr); ok(depth == 1, "got %d\n", depth); + /* read end tag for inner element */ + type = XmlNodeType_None; + hr = IXmlReader_Read(reader, &type); + ok(hr == S_OK, "got %08x\n", hr); + ok(type == XmlNodeType_EndElement, "got %d\n", type); + + depth = 0; + hr = IXmlReader_GetDepth(reader, &depth); + ok(hr == S_OK, "got %08x\n", hr); +todo_wine + ok(depth == 2, "got %d\n", depth); + + /* read end tag for container element */ + type = XmlNodeType_None; + hr = IXmlReader_Read(reader, &type); + ok(hr == S_OK, "got %08x\n", hr); + ok(type == XmlNodeType_EndElement, "got %d\n", type); + + depth = 0; + hr = IXmlReader_GetDepth(reader, &depth); + ok(hr == S_OK, "got %08x\n", hr); + ok(depth == 1, "got %d\n", depth); + + IStream_Release(stream); + + /* start/end tag mismatch */ + stream = create_stream_on_data(mismatch, sizeof(mismatch)); + hr = IXmlReader_SetInput(reader, (IUnknown*)stream); + ok(hr == S_OK, "got %08x\n", hr); + + type = XmlNodeType_None; + hr = IXmlReader_Read(reader, &type); + ok(hr == S_OK, "got %08x\n", hr); + ok(type == XmlNodeType_Element, "got %d\n", type); + + type = XmlNodeType_Element; + hr = IXmlReader_Read(reader, &type); + ok(hr == WC_E_ELEMENTMATCH, "got %08x\n", hr); +todo_wine + ok(type == XmlNodeType_None, "got %d\n", type); + IStream_Release(stream); IXmlReader_Release(reader);

1 0

Alexandre Julliard : gdi32: Fix copy/ paste typo in get_char_positions_indices.
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: wine Branch: master Commit: f496a5a0e69ac21a45c9048131ef59469c45f8d7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f496a5a0e69ac21a45c904813… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 22 12:13:19 2013 +0100 gdi32: Fix copy/paste typo in get_char_positions_indices. --- dlls/gdi32/font.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c index 68559f1..a24acd4 100644 --- a/dlls/gdi32/font.c +++ b/dlls/gdi32/font.c @@ -358,7 +358,7 @@ static BOOL get_char_positions_indices( DC *dc, const WORD *indices, INT count, dev = GET_DC_PHYSDEV( dc, pGetTextMetrics ); dev->funcs->pGetTextMetrics( dev, &tm ); - dev = GET_DC_PHYSDEV( dc, pGetTextExtentExPoint ); + dev = GET_DC_PHYSDEV( dc, pGetTextExtentExPointI ); if (!dev->funcs->pGetTextExtentExPointI( dev, indices, count, dx )) return FALSE; if (dc->breakExtra || dc->breakRem)

1 0

Alexandre Julliard : server: Use the __NR_ names for Linux system calls.
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: wine Branch: master Commit: 2b95df8fbdcf7069ddea0db5490c8c4e005d6e15 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2b95df8fbdcf7069ddea0db54… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jan 21 21:37:10 2013 +0100 server: Use the __NR_ names for Linux system calls. --- server/ptrace.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/ptrace.c b/server/ptrace.c index 19ec7da..db2804a 100644 --- a/server/ptrace.c +++ b/server/ptrace.c @@ -203,8 +203,8 @@ static int waitpid_thread( struct thread *thread, int signal ) static inline int tkill( int tgid, int pid, int sig ) { #ifdef __linux__ - int ret = syscall( SYS_tgkill, tgid, pid, sig ); - if (ret < 0 && errno == ENOSYS) ret = syscall( SYS_tkill, pid, sig ); + int ret = syscall( __NR_tgkill, tgid, pid, sig ); + if (ret < 0 && errno == ENOSYS) ret = syscall( __NR_tkill, pid, sig ); return ret; #elif (defined(__FreeBSD__) || defined (__FreeBSD_kernel__)) && defined(HAVE_THR_KILL2) return thr_kill2( tgid, pid, sig );

1 0

Alexandre Julliard : ntdll: Use the __NR_ names for Linux system calls.
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: wine Branch: master Commit: 606c88a348fa240359a25aa5a3659a0b41ee0cb4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=606c88a348fa240359a25aa5a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jan 21 21:37:02 2013 +0100 ntdll: Use the __NR_ names for Linux system calls. --- dlls/ntdll/critsection.c | 4 ++-- dlls/ntdll/directory.c | 4 ++-- dlls/ntdll/server.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/ntdll/critsection.c b/dlls/ntdll/critsection.c index fb69b31..dcc66e0 100644 --- a/dlls/ntdll/critsection.c +++ b/dlls/ntdll/critsection.c @@ -66,12 +66,12 @@ static int wake_op = 129; /*FUTEX_WAKE|FUTEX_PRIVATE_FLAG*/ static inline int futex_wait( int *addr, int val, struct timespec *timeout ) { - return syscall( SYS_futex, addr, wait_op, val, timeout, 0, 0 ); + return syscall( __NR_futex, addr, wait_op, val, timeout, 0, 0 ); } static inline int futex_wake( int *addr, int val ) { - return syscall( SYS_futex, addr, wake_op, val, NULL, 0, 0 ); + return syscall( __NR_futex, addr, wake_op, val, NULL, 0, 0 ); } static inline int use_futexes(void) diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c index cc075b7..863a320 100644 --- a/dlls/ntdll/directory.c +++ b/dlls/ntdll/directory.c @@ -109,7 +109,7 @@ typedef struct # define O_DIRECTORY 0200000 /* must be directory */ #endif -#ifdef SYS_getdents64 +#ifdef __NR_getdents64 typedef struct { ULONG64 d_ino; @@ -121,7 +121,7 @@ typedef struct static inline int getdents64( int fd, char *de, unsigned int size ) { - return syscall( SYS_getdents64, fd, de, size ); + return syscall( __NR_getdents64, fd, de, size ); } #define USE_GETDENTS #endif diff --git a/dlls/ntdll/server.c b/dlls/ntdll/server.c index af2ce06..dd0d83e 100644 --- a/dlls/ntdll/server.c +++ b/dlls/ntdll/server.c @@ -962,7 +962,7 @@ static int get_unix_tid(void) #ifdef HAVE_PTHREAD_GETTHREADID_NP ret = pthread_getthreadid_np(); #elif defined(linux) - ret = syscall( SYS_gettid ); + ret = syscall( __NR_gettid ); #elif defined(__sun) ret = pthread_self(); #elif defined(__APPLE__)

1 0

Francois Gouget : testbot: Make it possible to restart a failed job.
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: tools Branch: master Commit: b8fbfb378bbaa359068131d038280b5a1d05f2c7 URL: http://source.winehq.org/git/tools.git/?a=commit;h=b8fbfb378bbaa359068131d0… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jan 22 04:15:50 2013 +0100 testbot: Make it possible to restart a failed job. Mostly this is so that jobs that failed because of a transient WineTestBot error can be restarted by the administrator. --- testbot/bin/Engine.pl | 31 +++++++++++++ testbot/lib/WineTestBot/Engine/Notify.pm | 22 ++++++++- testbot/lib/WineTestBot/Jobs.pm | 38 +++++++++++++++ testbot/web/JobDetails.pl | 73 ++++++++++++++++++++++++++++-- 4 files changed, 158 insertions(+), 6 deletions(-) diff --git a/testbot/bin/Engine.pl b/testbot/bin/Engine.pl index e233e80..3d8f159 100755 --- a/testbot/bin/Engine.pl +++ b/testbot/bin/Engine.pl @@ -171,6 +171,36 @@ sub HandleJobCancel return "1OK"; } +sub HandleJobRestart +{ + my $JobKey = $_[0]; + + my $Job = CreateJobs()->GetItem($JobKey); + if (! $Job) + { + LogMsg "JobRestart for nonexistent job $JobKey\n"; + return "0Job $JobKey not found"; + } + # We've already determined that JobKey is valid, untaint it + $JobKey =~ m/^(.*)$/; + $JobKey = $1; + + my $ErrMessage = $Job->Restart(); + if (defined($ErrMessage)) + { + LogMsg "Restart problem: $ErrMessage\n"; + return "0$ErrMessage"; + } + + $ErrMessage = ScheduleJobs(); + if (defined($ErrMessage)) + { + LogMsg "Scheduling problem in HandleJobRestart: $ErrMessage\n"; + } + + return "1OK"; +} + sub HandleTaskComplete { my $ErrMessage = ScheduleJobs(); @@ -452,6 +482,7 @@ my %Handlers=( "foundwinetestupdate" => \&HandleFoundWinetestUpdate, "getscreenshot" => \&HandleGetScreenshot, "jobcancel" => \&HandleJobCancel, + "jobrestart" => \&HandleJobRestart, "jobstatuschange" => \&HandleJobStatusChange, "jobsubmit" => \&HandleJobSubmit, "ping" => \&HandlePing, diff --git a/testbot/lib/WineTestBot/Engine/Notify.pm b/testbot/lib/WineTestBot/Engine/Notify.pm index 6bbec87..b836751 100644 --- a/testbot/lib/WineTestBot/Engine/Notify.pm +++ b/testbot/lib/WineTestBot/Engine/Notify.pm @@ -33,8 +33,9 @@ use vars qw (@ISA @EXPORT @EXPORT_OK $RunningInEngine); require Exporter; @ISA = qw(Exporter); -@EXPORT = qw(&PingEngine &JobSubmit &JobStatusChange &JobCancel &TaskComplete - &VMStatusChange &ExpectWinetestUpdate &FoundWinetestUpdate +@EXPORT = qw(&PingEngine &JobSubmit &JobStatusChange &JobCancel &JobRestart + &TaskComplete &VMStatusChange + &ExpectWinetestUpdate &FoundWinetestUpdate &WinePatchMLSubmission &WinePatchWebNotification &WinePatchWebSubmission &GetScreenshot); @EXPORT_OK = qw($RunningInEngine); @@ -132,6 +133,23 @@ sub JobCancel return substr($Reply, 1); } +sub JobRestart +{ + my $JobKey = $_[0]; + + my $Reply = SendCmdReceiveReply("jobrestart $JobKey\n"); + if (length($Reply) < 1) + { + return "Unrecognized reply received from engine"; + } + if (substr($Reply, 0, 1) eq "1") + { + return undef; + } + + return substr($Reply, 1); +} + sub TaskComplete { my ($JobKey, $StepKey, $TaskKey) = @_; diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm index 269643d..66f87ba 100644 --- a/testbot/lib/WineTestBot/Jobs.pm +++ b/testbot/lib/WineTestBot/Jobs.pm @@ -50,6 +50,7 @@ A Job is composed of multiple WineTestBot::Step objects. =cut +use WineTestBot::Config; use WineTestBot::Branches; use WineTestBot::Engine::Notify; use WineTestBot::WineTestBotObjects; @@ -205,6 +206,43 @@ sub Cancel return undef; } +sub Restart +{ + my $self = shift; + + if ($self->Status ne "failed" && $self->Status ne "completed") + { + return "Only completed/failed jobs can be restarted"; + } + + my $JobDir = "$DataDir/jobs/" . $self->Id; + my $FirstStep = 1; + my $Steps = $self->Steps; + my @SortedSteps = sort { $a->No <=> $b->No } @{$Steps->GetItems()}; + foreach my $Step (@SortedSteps) + { + my $Tasks = $Step->Tasks; + foreach my $Task (@{$Tasks->GetItems()}) + { + if ($FirstStep) + { + # The first step contains the patch or test executable + # so only delete its task folders + system("rm", "-rf", "$JobDir/" . $Step->No . "/" . $Task->No); + } + $Task->Status("queued"); + } + # Subsequent steps only contain files generated by the previous steps + system("rm", "-rf", "$JobDir/" . $Step->No) if (!$FirstStep); + $FirstStep = undef; + $Step->Status("queued"); + } + $self->Status("queued"); + $self->Save(); # Save it all + + return undef; +} + sub GetEMailRecipient { my $self = shift; diff --git a/testbot/web/JobDetails.pl b/testbot/web/JobDetails.pl index 2ca81b8..b191327 100644 --- a/testbot/web/JobDetails.pl +++ b/testbot/web/JobDetails.pl @@ -27,6 +27,7 @@ use WineTestBot::Config; use WineTestBot::Jobs; use WineTestBot::StepsTasks; use WineTestBot::Engine::Notify; +use WineTestBot::Log; @JobDetailsPage::ISA = qw(ObjectModel::CGI::CollectionPage); @@ -112,13 +113,40 @@ sub CanCancel return undef; } -sub GetActions +sub CanRestart { my $self = shift; - my $ErrMessage = $self->CanCancel(); + my $Job = CreateJobs()->GetItem($self->{JobId}); + my $Status = $Job->Status; + if ($Status ne "failed") + { + return "Job did not fail"; + } - return defined($ErrMessage) ? [] : ["Cancel job"]; + my $Session = $self->GetCurrentSession(); + if (! defined($Session)) + { + return "You are not authorized to restart this job"; + } + my $CurrentUser = $Session->User; + if (! $CurrentUser->HasRole("admin") && + $Job->User->GetKey() ne $CurrentUser->GetKey()) # FIXME: Admin only? + { + return "You are not authorized to restart this job"; + } + + return undef; +} + +sub GetActions +{ + my $self = shift; + + # These are mutually exclusive + return ["Cancel job"] if (!defined $self->CanCancel()); + return ["Restart job"] if (!defined $self->CanRestart()); + return []; } sub OnCancel @@ -142,6 +170,27 @@ sub OnCancel return 1; } +sub OnRestart +{ + my $self = shift; + + my $ErrMessage = $self->CanRestart(); + if (defined($ErrMessage)) + { + $self->{ErrMessage} = $ErrMessage; + return !1; + } + + $ErrMessage = JobRestart($self->{JobId}); + if (defined($ErrMessage)) + { + $self->{ErrMessage} = $ErrMessage; + return !1; + } + + return 1; +} + sub OnAction { my $self = shift; @@ -151,6 +200,10 @@ sub OnAction { return $self->OnCancel(); } + elsif ($Action eq "Restart job") + { + return $self->OnRestart(); + } return $self->SUPER::OnAction(@_); } @@ -189,7 +242,19 @@ sub GenerateBody { print "<h1>" . $self->GetTitle() . "</h1>\n"; print "<div class='Content'>\n"; - print "Job will be cancelled.\n"; + my $Action = $self->GetParam("Action"); + if ($Action eq "Cancel job") + { + print "Job will be cancelled.\n"; + } + elsif ($Action eq "Restart job") + { + print "Job will be restarted.\n"; + } + else + { + print "Unknown action $Action.\n"; + } print "</div>\n"; return; }

1 0

Francois Gouget : testbot/lib: Simplify Jobs::ScheduleOnHost() a bit.
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: tools Branch: master Commit: e9d494a87824255b00ecdc923838ad80eb3410cd URL: http://source.winehq.org/git/tools.git/?a=commit;h=e9d494a87824255b00ecdc92… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jan 22 04:10:41 2013 +0100 testbot/lib: Simplify Jobs::ScheduleOnHost() a bit. --- testbot/lib/WineTestBot/Jobs.pm | 11 +++++------ 1 files changed, 5 insertions(+), 6 deletions(-) diff --git a/testbot/lib/WineTestBot/Jobs.pm b/testbot/lib/WineTestBot/Jobs.pm index c15c7af..269643d 100644 --- a/testbot/lib/WineTestBot/Jobs.pm +++ b/testbot/lib/WineTestBot/Jobs.pm @@ -388,16 +388,16 @@ sub ScheduleOnHost($$) my @SortedTasks = sort CompareTaskStatus @{$Tasks->GetItems()}; foreach my $Task (@SortedTasks) { - if ($Task->Status eq "queued" && - $HostVMs->ItemExists($Task->VM->GetKey())) + my $VM = $Task->VM; + my $VMKey = $VM->GetKey(); + if ($Task->Status eq "queued" && $HostVMs->ItemExists($VMKey)) { - my $VM = $HostVMs->GetItem($Task->VM->GetKey()); if ($VM->Status eq "idle" && $RunningVMs < $MaxRunningVMs && $RevertingVMs == 0) { $VM->Status("running"); - my ($ErrProperty, $ErrMessage) = $HostVMs->Save(); + my ($ErrProperty, $ErrMessage) = $VM->Save(); if (defined($ErrMessage)) { return $ErrMessage; @@ -407,12 +407,11 @@ sub ScheduleOnHost($$) { return $ErrMessage; } - $Job->UpdateStatus; + $Job->UpdateStatus(); $RunningVMs++; } elsif ($VM->Status eq "dirty") { - my $VMKey = $VM->GetKey(); if (! defined($DirtyVMsBlockingJobs{$VMKey}) || $Job->Priority < $DirtyVMsBlockingJobs{$VMKey}) {

1 0

Francois Gouget : testbot/web: Improve the job status reporting on the home page.
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: tools Branch: master Commit: 9250db91d194c341aac98a676df235e2c3533443 URL: http://source.winehq.org/git/tools.git/?a=commit;h=9250db91d194c341aac98a67… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jan 22 04:11:34 2013 +0100 testbot/web: Improve the job status reporting on the home page. It is interesting to know if there were test failures even if a VM misbehaved. So report test failures even if some of the job's tasks failed. Conversely, don't claim that jobs like the 'Wine update' have 0 test failures. Colorize the status to make errors and test failures easier to spot. Also link to the job details page from the status field. --- testbot/web/WineTestBot.css | 6 ++++ testbot/web/index.pl | 64 +++++++++++++++++++++++++++++++++++------- 2 files changed, 59 insertions(+), 11 deletions(-) diff --git a/testbot/web/WineTestBot.css b/testbot/web/WineTestBot.css index 29902ff..b7e7248 100644 --- a/testbot/web/WineTestBot.css +++ b/testbot/web/WineTestBot.css @@ -320,3 +320,9 @@ pre margin-bottom: 2em; background-color: red; } + +.queued { color: black; } +.running { color: blue; } +.success { color: green; } +.testfail { color: red; } +.botfail { color: #e55600; } diff --git a/testbot/web/index.pl b/testbot/web/index.pl index 20ac591..6d88106 100644 --- a/testbot/web/index.pl +++ b/testbot/web/index.pl @@ -20,6 +20,7 @@ use strict; package JobStatusBlock; +use URI::Escape; use ObjectModel::CGI::CollectionBlock; use WineTestBot::Branches; @@ -76,23 +77,64 @@ sub GetDisplayValue return $Item->Patch->FromName; } - if ($PropertyDescriptor->GetName() eq "Status" && - $Item->Status eq "completed") + return $self->SUPER::GetDisplayValue(@_); +} + +sub GenerateDataCell +{ + my $self = shift; + my ($Item, $PropertyDescriptor, $DetailsPage) = @_; + + my $PropertyName = $PropertyDescriptor->GetName(); + if ($PropertyName eq "Status") { - my $Failures = 0; - my $Steps = $Item->Steps; - foreach my $StepKey (@{$Steps->GetKeys()}) + print "<td><a href='/JobDetails.pl?Key=", uri_escape($Item->GetKey()), "'>"; + + my %HTMLChunks = ("queued" => "queued", + "running" => "running", + "completed" => "completed", + "failed" => "failed"); + my $Status = $Item->Status; + my $HTMLStatus = $HTMLChunks{$Status} || $Status; + if ($Status eq "completed" || $Status eq "failed") { - my $Tasks = $Steps->GetItem($StepKey)->Tasks; - foreach my $TaskKey (@{$Tasks->GetKeys()}) + my $Failures = 0; + my $HasTestResult; + my $Steps = $Item->Steps; + foreach my $StepKey (@{$Steps->GetKeys()}) + { + my $Tasks = $Steps->GetItem($StepKey)->Tasks; + foreach my $TaskKey (@{$Tasks->GetKeys()}) + { + my $TaskFailures = $Tasks->GetItem($TaskKey)->TestFailures; + if ($TaskFailures ne "") + { + $HasTestResult = 1; + $Failures += $TaskFailures; + } + } + } + if (!$HasTestResult) { - $Failures += $Tasks->GetItem($TaskKey)->TestFailures; + print $HTMLStatus; + } + else + { + $HTMLStatus = $Item->Status eq "completed" ? "" : "$HTMLStatus - "; + my $class = $Failures ? "testfail" : "success"; + print "$HTMLStatus$Failures test failures"; } } - return $Item->Status . " - " . $Failures . " failures"; + else + { + print $HTMLStatus; + } + print "</a></td>\n"; + } + else + { + $self->SUPER::GenerateDataCell(@_); } - - return $self->SUPER::GetDisplayValue(@_); } package VMStatusBlock;

1 0

Francois Gouget : testbot: Directly use TestAgent for the file transfers and to run scripts instead of going through the VMs module .
by Alexandre Julliard 22 Jan '13

22 Jan '13

Module: tools Branch: master Commit: 378581759ba311ddf40c24839e9db7aa3ed30c41 URL: http://source.winehq.org/git/tools.git/?a=commit;h=378581759ba311ddf40c2483… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Tue Jan 22 04:08:20 2013 +0100 testbot: Directly use TestAgent for the file transfers and to run scripts instead of going through the VMs module. --- testbot/bin/RevertVM.pl | 11 ++++-- testbot/bin/WineRunBuild.pl | 34 ++++++++++++------ testbot/bin/WineRunReconfig.pl | 25 ++++++++++--- testbot/bin/WineRunTask.pl | 76 ++++++++++++++++++++++------------------ testbot/lib/WineTestBot/VMs.pm | 63 ++++----------------------------- 5 files changed, 100 insertions(+), 109 deletions(-) Diff: http://source.winehq.org/git/tools.git/?a=commitdiff;h=378581759ba311ddf40c…

1 0

← Newer
1
...
21
22
23
24
25
26
27
...
74
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits January 2013