wine-commits January 2013

wine-commits@winehq.org

2 participants
736 discussions

Aric Stewart : usp10: Correct issues if a feature tag is duplicated between GSUB and GPOS.
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: 9dd91d31984170c378f33e96341a16d2906f4cde URL: http://source.winehq.org/git/wine.git/?a=commit;h=9dd91d31984170c378f33e963… Author: Aric Stewart <aric(a)codeweavers.com> Date: Tue Jan 8 10:00:06 2013 -0600 usp10: Correct issues if a feature tag is duplicated between GSUB and GPOS. Identified by Huw Davies. --- dlls/usp10/opentype.c | 23 +++++++++++++++++++---- dlls/usp10/shape.c | 38 +++++++++++++++++++------------------- dlls/usp10/usp10_internal.h | 7 ++++++- 3 files changed, 44 insertions(+), 24 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=9dd91d31984170c378f33…

1 0

Nikolay Sivov : xmllite: Explicitly set value and names to empty for xml decl node.
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: 430bde34f3cee625678e00565ecf23eb81acce57 URL: http://source.winehq.org/git/wine.git/?a=commit;h=430bde34f3cee625678e00565… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 8 15:44:27 2013 +0400 xmllite: Explicitly set value and names to empty for xml decl node. --- dlls/xmllite/reader.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index fec4234..9c14899 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -883,6 +883,9 @@ static HRESULT reader_parse_xmldecl(xmlreader *reader) reader_skipn(reader, 2); reader->nodetype = XmlNodeType_XmlDeclaration; + reader_set_strvalue(reader, StringValue_LocalName, &strval_empty); + reader_set_strvalue(reader, StringValue_QualifiedName, &strval_empty); + reader_set_strvalue(reader, StringValue_Value, &strval_empty); return S_OK; }

1 0

Nikolay Sivov : xmllite: Report value for PI nodes.
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: e79b2b3fc4f7d3ef66bca7429ea2d3559ceb20ff URL: http://source.winehq.org/git/wine.git/?a=commit;h=e79b2b3fc4f7d3ef66bca7429… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 8 15:42:57 2013 +0400 xmllite: Report value for PI nodes. --- dlls/xmllite/reader.c | 6 +++++- dlls/xmllite/tests/reader.c | 36 ++++++++++++++++++++++++------------ 2 files changed, 29 insertions(+), 13 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index 7d3d93a..fec4234 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -1031,7 +1031,7 @@ static HRESULT reader_parse_pitarget(xmlreader *reader, strval *target) /* [16] PI ::= '<?' PITarget (S (Char* - (Char* '?>' Char*)))? '?>' */ static HRESULT reader_parse_pi(xmlreader *reader) { - const WCHAR *ptr, *start; + WCHAR *ptr, *start; strval target; HRESULT hr; @@ -1051,6 +1051,7 @@ static HRESULT reader_parse_pi(xmlreader *reader) reader->nodetype = XmlNodeType_ProcessingInstruction; reader_set_strvalue(reader, StringValue_LocalName, &target); reader_set_strvalue(reader, StringValue_QualifiedName, &target); + reader_set_strvalue(reader, StringValue_Value, &strval_empty); return S_OK; } @@ -1066,12 +1067,15 @@ static HRESULT reader_parse_pi(xmlreader *reader) { if (ptr[1] == '>') { + strval value = { start, ptr-start }; + TRACE("%s\n", debugstr_wn(start, ptr-start)); /* skip '?>' */ reader_skipn(reader, 2); reader->nodetype = XmlNodeType_ProcessingInstruction; reader_set_strvalue(reader, StringValue_LocalName, &target); reader_set_strvalue(reader, StringValue_QualifiedName, &target); + reader_set_strvalue(reader, StringValue_Value, &value); return S_OK; } else diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index cd22f49..140c99e 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -799,6 +799,8 @@ static void test_read_comment(void) static struct test_entry pi_tests[] = { { "<?pi?>", "pi", "", S_OK }, { "<?pi ?>", "pi", "", S_OK }, + { "<?pi pi data?>", "pi", "pi data", S_OK }, + { "<?pi pi data ?>", "pi", "pi data ", S_OK }, { "<?pi:pi?>", NULL, NULL, NC_E_NAMECOLON, WC_E_NAMECHARACTER }, { "<?:pi ?>", NULL, NULL, WC_E_PI, WC_E_NAMECHARACTER }, { "<?-pi ?>", NULL, NULL, WC_E_PI, WC_E_NAMECHARACTER }, @@ -832,29 +834,39 @@ static void test_read_pi(void) ok(hr == test->hr, "got %08x for %s\n", hr, test->xml); if (hr == S_OK) { - const WCHAR *name; - WCHAR *name_exp; + const WCHAR *str; + WCHAR *str_exp; UINT len; ok(type == XmlNodeType_ProcessingInstruction, "got %d for %s\n", type, test->xml); len = 0; - name = NULL; - hr = IXmlReader_GetLocalName(reader, &name, &len); + str = NULL; + hr = IXmlReader_GetLocalName(reader, &str, &len); ok(hr == S_OK, "got 0x%08x\n", hr); ok(len == strlen(test->name), "got %u\n", len); - name_exp = a2w(test->name); - ok(!lstrcmpW(name, name_exp), "got %s\n", wine_dbgstr_w(name)); - free_str(name_exp); + str_exp = a2w(test->name); + ok(!lstrcmpW(str, str_exp), "got %s\n", wine_dbgstr_w(str)); + free_str(str_exp); len = 0; - name = NULL; - hr = IXmlReader_GetQualifiedName(reader, &name, &len); + str = NULL; + hr = IXmlReader_GetQualifiedName(reader, &str, &len); ok(hr == S_OK, "got 0x%08x\n", hr); ok(len == strlen(test->name), "got %u\n", len); - name_exp = a2w(test->name); - ok(!lstrcmpW(name, name_exp), "got %s\n", wine_dbgstr_w(name)); - free_str(name_exp); + str_exp = a2w(test->name); + ok(!lstrcmpW(str, str_exp), "got %s\n", wine_dbgstr_w(str)); + free_str(str_exp); + + /* value */ + len = !strlen(test->value); + str = NULL; + hr = IXmlReader_GetValue(reader, &str, &len); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(len == strlen(test->value), "got %u\n", len); + str_exp = a2w(test->value); + ok(!lstrcmpW(str, str_exp), "got %s\n", wine_dbgstr_w(str)); + free_str(str_exp); } IStream_Release(stream);

1 0

Nikolay Sivov : xmllite: Report node value for comment nodes.
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: 57148ae964314378ad8999b904fafab6b616858c URL: http://source.winehq.org/git/wine.git/?a=commit;h=57148ae964314378ad8999b90… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jan 8 14:32:21 2013 +0400 xmllite: Report node value for comment nodes. --- dlls/xmllite/reader.c | 23 ++++++++++++----- dlls/xmllite/tests/reader.c | 58 +++++++++++++++++++++++++----------------- 2 files changed, 50 insertions(+), 31 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index 82aca68..7d3d93a 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -56,6 +56,7 @@ typedef enum { StringValue_LocalName, StringValue_QualifiedName, + StringValue_Value, StringValue_Last } XmlReaderStringValue; @@ -889,7 +890,7 @@ static HRESULT reader_parse_xmldecl(xmlreader *reader) /* [15] Comment ::= '' */ static HRESULT reader_parse_comment(xmlreader *reader) { - const WCHAR *start, *ptr; + WCHAR *start, *ptr; /* skip '' */ reader_skipn(reader, 3); reader_set_strvalue(reader, StringValue_LocalName, &strval_empty); reader_set_strvalue(reader, StringValue_QualifiedName, &strval_empty); + reader_set_strvalue(reader, StringValue_Value, &value); reader->nodetype = XmlNodeType_Comment; return S_OK; } @@ -1421,12 +1425,14 @@ static HRESULT WINAPI xmlreader_GetPrefix(IXmlReader* iface, return E_NOTIMPL; } -static HRESULT WINAPI xmlreader_GetValue(IXmlReader* iface, - LPCWSTR *value, - UINT *value_length) +static HRESULT WINAPI xmlreader_GetValue(IXmlReader* iface, LPCWSTR *value, UINT *len) { - FIXME("(%p %p %p): stub\n", iface, value, value_length); - return E_NOTIMPL; + xmlreader *This = impl_from_IXmlReader(iface); + + TRACE("(%p)->(%p %p)\n", This, value, len); + *value = This->strvalues[StringValue_Value].str; + if (len) *len = This->strvalues[StringValue_Value].len; + return S_OK; } static HRESULT WINAPI xmlreader_ReadValueChunk(IXmlReader* iface, @@ -1600,6 +1606,7 @@ static const struct IUnknownVtbl xmlreaderinput_vtbl = HRESULT WINAPI CreateXmlReader(REFIID riid, void **obj, IMalloc *imalloc) { xmlreader *reader; + int i; TRACE("(%s, %p, %p)\n", wine_dbgstr_guid(riid), obj, imalloc); @@ -1628,7 +1635,9 @@ HRESULT WINAPI CreateXmlReader(REFIID riid, void **obj, IMalloc *imalloc) list_init(&reader->attrs); reader->attr_count = 0; reader->attr = NULL; - memset(&reader->strvalues, 0, sizeof(reader->strvalues)); + + for (i = 0; i < StringValue_Last; i++) + reader->strvalues[i] = strval_empty; *obj = &reader->IXmlReader_iface; diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c index 2de1047..cd22f49 100644 --- a/dlls/xmllite/tests/reader.c +++ b/dlls/xmllite/tests/reader.c @@ -648,10 +648,8 @@ static void test_read_xmldeclaration(void) test_read_state(reader, XmlReadState_Interactive, -1, 0); hr = IXmlReader_GetValue(reader, &val, NULL); -todo_wine ok(hr == S_OK, "got %08x\n", hr); - if (hr == S_OK) - ok(*val == 0, "got %s\n", wine_dbgstr_w(val)); + ok(*val == 0, "got %s\n", wine_dbgstr_w(val)); /* check attributes */ hr = IXmlReader_MoveToNextAttribute(reader); @@ -717,14 +715,16 @@ todo_wine { struct test_entry { const char *xml; const char *name; + const char *value; HRESULT hr; HRESULT hr_broken; /* this is set to older version results */ }; static struct test_entry comment_tests[] = { - { "", "", S_OK }, - { "", "", S_OK }, - { "", NULL, WC_E_COMMENT, WC_E_GREATERTHAN }, + { "", "", " comment ", S_OK }, + { "", "", " - comment", S_OK }, + { "", NULL, NULL, WC_E_COMMENT, WC_E_GREATERTHAN }, + { "", NULL, NULL, WC_E_COMMENT, WC_E_GREATERTHAN }, { NULL } }; @@ -754,29 +754,39 @@ static void test_read_comment(void) ok(hr == test->hr, "got %08x for %s\n", hr, test->xml); if (hr == S_OK) { - const WCHAR *name; - WCHAR *name_exp; + const WCHAR *str; + WCHAR *str_exp; UINT len; ok(type == XmlNodeType_Comment, "got %d for %s\n", type, test->xml); len = 1; - name = NULL; - hr = IXmlReader_GetLocalName(reader, &name, &len); + str = NULL; + hr = IXmlReader_GetLocalName(reader, &str, &len); ok(hr == S_OK, "got 0x%08x\n", hr); ok(len == strlen(test->name), "got %u\n", len); - name_exp = a2w(test->name); - ok(!lstrcmpW(name, name_exp), "got %s\n", wine_dbgstr_w(name)); - free_str(name_exp); + str_exp = a2w(test->name); + ok(!lstrcmpW(str, str_exp), "got %s\n", wine_dbgstr_w(str)); + free_str(str_exp); len = 1; - name = NULL; - hr = IXmlReader_GetQualifiedName(reader, &name, &len); + str = NULL; + hr = IXmlReader_GetQualifiedName(reader, &str, &len); ok(hr == S_OK, "got 0x%08x\n", hr); ok(len == strlen(test->name), "got %u\n", len); - name_exp = a2w(test->name); - ok(!lstrcmpW(name, name_exp), "got %s\n", wine_dbgstr_w(name)); - free_str(name_exp); + str_exp = a2w(test->name); + ok(!lstrcmpW(str, str_exp), "got %s\n", wine_dbgstr_w(str)); + free_str(str_exp); + + /* value */ + len = 1; + str = NULL; + hr = IXmlReader_GetValue(reader, &str, &len); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(len == strlen(test->value), "got %u\n", len); + str_exp = a2w(test->value); + ok(!lstrcmpW(str, str_exp), "got %s\n", wine_dbgstr_w(str)); + free_str(str_exp); } IStream_Release(stream); @@ -787,12 +797,12 @@ static void test_read_comment(void) } static struct test_entry pi_tests[] = { - { "<?pi?>", "pi", S_OK }, - { "<?pi ?>", "pi", S_OK }, - { "<?pi:pi?>", NULL, NC_E_NAMECOLON, WC_E_NAMECHARACTER }, - { "<?:pi ?>", NULL, WC_E_PI, WC_E_NAMECHARACTER }, - { "<?-pi ?>", NULL, WC_E_PI, WC_E_NAMECHARACTER }, - { "<?xml-stylesheet ?>", "xml-stylesheet", S_OK }, + { "<?pi?>", "pi", "", S_OK }, + { "<?pi ?>", "pi", "", S_OK }, + { "<?pi:pi?>", NULL, NULL, NC_E_NAMECOLON, WC_E_NAMECHARACTER }, + { "<?:pi ?>", NULL, NULL, WC_E_PI, WC_E_NAMECHARACTER }, + { "<?-pi ?>", NULL, NULL, WC_E_PI, WC_E_NAMECHARACTER }, + { "<?xml-stylesheet ?>", "xml-stylesheet", "", S_OK }, { NULL } };

1 0

Christian Costa : d3drm: Avoid LP stuff and rename some variables.
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: 1db9fb9036d9d58826b4c085a9338910855d9f0e URL: http://source.winehq.org/git/wine.git/?a=commit;h=1db9fb9036d9d58826b4c085a… Author: Christian Costa <titan.costa(a)gmail.com> Date: Tue Jan 8 08:47:12 2013 +0100 d3drm: Avoid LP stuff and rename some variables. --- dlls/d3drm/meshbuilder.c | 51 +++++++++++++++++++++++---------------------- 1 files changed, 26 insertions(+), 25 deletions(-) diff --git a/dlls/d3drm/meshbuilder.c b/dlls/d3drm/meshbuilder.c index 3e6aa6d..46e95ac 100644 --- a/dlls/d3drm/meshbuilder.c +++ b/dlls/d3drm/meshbuilder.c @@ -1137,14 +1137,13 @@ static HRESULT WINAPI IDirect3DRMMeshBuilder3Impl_GetClassName(IDirect3DRMMeshBu return D3DRM_OK; } -HRESULT load_mesh_data(IDirect3DRMMeshBuilder3* iface, IDirectXFileData *pData, D3DRMLOADTEXTURECALLBACK load_texture_proc, void *arg) +HRESULT load_mesh_data(IDirect3DRMMeshBuilder3 *iface, IDirectXFileData *pData, D3DRMLOADTEXTURECALLBACK load_texture_proc, void *arg) { IDirect3DRMMeshBuilderImpl *This = impl_from_IDirect3DRMMeshBuilder3(iface); - LPDIRECTXFILEOBJECT pObject = NULL; - LPDIRECTXFILEDATA pData2 = NULL; - const GUID* pGuid; + IDirectXFileData *pData2 = NULL; + const GUID* guid; DWORD size; - LPBYTE ptr; + BYTE *ptr; HRESULT hr; HRESULT ret = D3DRMERR_BADOBJECT; DWORD* faces_vertex_idx_data = NULL; @@ -1194,12 +1193,14 @@ HRESULT load_mesh_data(IDirect3DRMMeshBuilder3* iface, IDirectXFileData *pData, memcpy(faces_vertex_idx_data, ptr + sizeof(DWORD) + This->nb_vertices * sizeof(D3DVECTOR) + sizeof(DWORD), faces_vertex_idx_size); /* Each vertex index will have its normal index counterpart so just allocate twice the size */ - This->pFaceData = HeapAlloc(GetProcessHeap(), 0, faces_vertex_idx_size*2); + This->pFaceData = HeapAlloc(GetProcessHeap(), 0, faces_vertex_idx_size * 2); faces_data_ptr = (DWORD*)This->pFaceData; while (1) { - hr = IDirectXFileData_GetNextObject(pData, &pObject); + IDirectXFileObject *object; + + hr = IDirectXFileData_GetNextObject(pData, &object); if (hr == DXFILEERR_NOMOREOBJECTS) { TRACE("No more object\n"); @@ -1208,18 +1209,18 @@ HRESULT load_mesh_data(IDirect3DRMMeshBuilder3* iface, IDirectXFileData *pData, if (hr != DXFILE_OK) goto end; - hr = IDirectXFileObject_QueryInterface(pObject, &IID_IDirectXFileData, (void**)&pData2); - IDirectXFileObject_Release(pObject); + hr = IDirectXFileObject_QueryInterface(object, &IID_IDirectXFileData, (void**)&pData2); + IDirectXFileObject_Release(object); if (hr != DXFILE_OK) goto end; - hr = IDirectXFileData_GetType(pData2, &pGuid); + hr = IDirectXFileData_GetType(pData2, &guid); if (hr != DXFILE_OK) goto end; - TRACE("Found object type whose GUID = %s\n", debugstr_guid(pGuid)); + TRACE("Found object type whose GUID = %s\n", debugstr_guid(guid)); - if (IsEqualGUID(pGuid, &TID_D3DRMMeshNormals)) + if (IsEqualGUID(guid, &TID_D3DRMMeshNormals)) { DWORD nb_faces_normals; DWORD faces_normal_idx_size; @@ -1238,11 +1239,11 @@ HRESULT load_mesh_data(IDirect3DRMMeshBuilder3* iface, IDirectXFileData *pData, This->pNormals = HeapAlloc(GetProcessHeap(), 0, This->nb_normals * sizeof(D3DVECTOR)); memcpy(This->pNormals, ptr + sizeof(DWORD), This->nb_normals * sizeof(D3DVECTOR)); - faces_normal_idx_size = size - (2*sizeof(DWORD) + This->nb_normals * sizeof(D3DVECTOR)); + faces_normal_idx_size = size - (2 * sizeof(DWORD) + This->nb_normals * sizeof(D3DVECTOR)); faces_normal_idx_ptr = faces_normal_idx_data = HeapAlloc(GetProcessHeap(), 0, faces_normal_idx_size); memcpy(faces_normal_idx_data, ptr + sizeof(DWORD) + This->nb_normals * sizeof(D3DVECTOR) + sizeof(DWORD), faces_normal_idx_size); } - else if (IsEqualGUID(pGuid, &TID_D3DRMMeshTextureCoords)) + else if (IsEqualGUID(guid, &TID_D3DRMMeshTextureCoords)) { hr = IDirectXFileData_GetData(pData2, NULL, &size, (void**)&ptr); if (hr != DXFILE_OK) @@ -1256,12 +1257,12 @@ HRESULT load_mesh_data(IDirect3DRMMeshBuilder3* iface, IDirectXFileData *pData, memcpy(This->pCoords2d, ptr + sizeof(DWORD), This->nb_coords2d * sizeof(Coords2d)); } - else if (IsEqualGUID(pGuid, &TID_D3DRMMeshMaterialList)) + else if (IsEqualGUID(guid, &TID_D3DRMMeshMaterialList)) { DWORD nb_materials; DWORD nb_face_indices; DWORD data_size; - LPDIRECTXFILEOBJECT child; + IDirectXFileObject *child; DWORD i = 0; float* values; @@ -1295,9 +1296,9 @@ HRESULT load_mesh_data(IDirect3DRMMeshBuilder3* iface, IDirectXFileData *pData, while (SUCCEEDED(hr = IDirectXFileData_GetNextObject(pData2, &child)) && (i < nb_materials)) { - LPDIRECTXFILEDATA data; - LPDIRECTXFILEDATAREFERENCE reference; - LPDIRECTXFILEOBJECT material_child; + IDirectXFileData *data; + IDirectXFileDataReference *reference; + IDirectXFileObject *material_child; hr = IDirectXFileObject_QueryInterface(child, &IID_IDirectXFileData, (void **)&data); if (FAILED(hr)) @@ -1349,13 +1350,13 @@ HRESULT load_mesh_data(IDirect3DRMMeshBuilder3* iface, IDirectXFileData *pData, hr = IDirectXFileData_GetNextObject(data, &material_child); if (hr == S_OK) { - LPDIRECTXFILEDATA data; - char** filename; + IDirectXFileData *data; + char **filename; hr = IDirectXFileObject_QueryInterface(material_child, &IID_IDirectXFileData, (void **)&data); if (FAILED(hr)) { - LPDIRECTXFILEDATAREFERENCE reference; + IDirectXFileDataReference *reference; hr = IDirectXFileObject_QueryInterface(material_child, &IID_IDirectXFileDataReference, (void **)&reference); if (FAILED(hr)) @@ -1367,10 +1368,10 @@ HRESULT load_mesh_data(IDirect3DRMMeshBuilder3* iface, IDirectXFileData *pData, goto end; } - hr = IDirectXFileData_GetType(data, &pGuid); + hr = IDirectXFileData_GetType(data, &guid); if (hr != DXFILE_OK) goto end; - if (!IsEqualGUID(pGuid, &TID_D3DRMTextureFilename)) + if (!IsEqualGUID(guid, &TID_D3DRMTextureFilename)) { WARN("Not a texture filename\n"); goto end; @@ -1433,7 +1434,7 @@ HRESULT load_mesh_data(IDirect3DRMMeshBuilder3* iface, IDirectXFileData *pData, } else { - FIXME("Unknown GUID %s, ignoring...\n", debugstr_guid(pGuid)); + FIXME("Unknown GUID %s, ignoring...\n", debugstr_guid(guid)); } IDirectXFileData_Release(pData2);

1 0

Christian Costa : d3dx9_36: Implement partially ID3DXFileImpl_CreateEnumObject with stubbed ID3DXFileEnumObject interface .
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: 5c5deb34c8b6b12c69a5c0fdf2139c177df6d417 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5c5deb34c8b6b12c69a5c0fdf… Author: Christian Costa <titan.costa(a)gmail.com> Date: Tue Jan 8 08:46:44 2013 +0100 d3dx9_36: Implement partially ID3DXFileImpl_CreateEnumObject with stubbed ID3DXFileEnumObject interface. --- dlls/d3dx9_36/xfile.c | 127 ++++++++++++++++++++++++++++++++++++++++++++++++- 1 files changed, 125 insertions(+), 2 deletions(-) diff --git a/dlls/d3dx9_36/xfile.c b/dlls/d3dx9_36/xfile.c index 6c9403e..aaf1391 100644 --- a/dlls/d3dx9_36/xfile.c +++ b/dlls/d3dx9_36/xfile.c @@ -50,12 +50,119 @@ typedef struct { IDirectXFile *dxfile; } ID3DXFileImpl; +typedef struct { + ID3DXFileEnumObject ID3DXFileEnumObject_iface; + LONG ref; +} ID3DXFileEnumObjectImpl; static inline ID3DXFileImpl* impl_from_ID3DXFile(ID3DXFile *iface) { return CONTAINING_RECORD(iface, ID3DXFileImpl, ID3DXFile_iface); } +static inline ID3DXFileEnumObjectImpl* impl_from_ID3DXFileEnumObject(ID3DXFileEnumObject *iface) +{ + return CONTAINING_RECORD(iface, ID3DXFileEnumObjectImpl, ID3DXFileEnumObject_iface); +} + + +/*** IUnknown methods ***/ + +static HRESULT WINAPI ID3DXFileEnumObjectImpl_QueryInterface(ID3DXFileEnumObject *iface, REFIID riid, void **ret_iface) +{ + TRACE("(%p)->(%s, %p)\n", iface, debugstr_guid(riid), ret_iface); + + if (IsEqualGUID(riid, &IID_IUnknown) || + IsEqualGUID(riid, &IID_ID3DXFileEnumObject)) + { + iface->lpVtbl->AddRef(iface); + *ret_iface = iface; + return S_OK; + } + + WARN("(%p)->(%s, %p), not found\n", iface, debugstr_guid(riid), ret_iface); + *ret_iface = NULL; + return E_NOINTERFACE; +} + +static ULONG WINAPI ID3DXFileEnumObjectImpl_AddRef(ID3DXFileEnumObject *iface) +{ + ID3DXFileEnumObjectImpl *This = impl_from_ID3DXFileEnumObject(iface); + ULONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p)->(): new ref %u\n", iface, ref); + + return ref; +} + +static ULONG WINAPI ID3DXFileEnumObjectImpl_Release(ID3DXFileEnumObject *iface) +{ + ID3DXFileEnumObjectImpl *This = impl_from_ID3DXFileEnumObject(iface); + ULONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p)->(): new ref %u\n", iface, ref); + + if (!ref) + HeapFree(GetProcessHeap(), 0, This); + + return ref; +} + + +/*** ID3DXFileEnumObject methods ***/ + +static HRESULT WINAPI ID3DXFileEnumObjectImpl_GetFile(ID3DXFileEnumObject *iface, ID3DXFile **file) +{ + FIXME("(%p)->(%p): stub\n", iface, file); + + return E_NOTIMPL; +} + + +static HRESULT WINAPI ID3DXFileEnumObjectImpl_GetChildren(ID3DXFileEnumObject *iface, SIZE_T *children) +{ + FIXME("(%p)->(%p): stub\n", iface, children); + + return E_NOTIMPL; +} + + +static HRESULT WINAPI ID3DXFileEnumObjectImpl_GetChild(ID3DXFileEnumObject *iface, SIZE_T id, ID3DXFileData **object) +{ + FIXME("(%p)->(%lu, %p): stub\n", iface, id, object); + + return E_NOTIMPL; +} + + +static HRESULT WINAPI ID3DXFileEnumObjectImpl_GetDataObjectById(ID3DXFileEnumObject *iface, REFGUID guid, ID3DXFileData **object) +{ + FIXME("(%p)->(%s, %p): stub\n", iface, debugstr_guid(guid), object); + + return E_NOTIMPL; +} + + +static HRESULT WINAPI ID3DXFileEnumObjectImpl_GetDataObjectByName(ID3DXFileEnumObject *iface, const char *name, ID3DXFileData **object) +{ + FIXME("(%p)->(%s, %p): stub\n", iface, debugstr_a(name), object); + + return E_NOTIMPL; +} + + +static const ID3DXFileEnumObjectVtbl ID3DXFileEnumObject_Vtbl = +{ + ID3DXFileEnumObjectImpl_QueryInterface, + ID3DXFileEnumObjectImpl_AddRef, + ID3DXFileEnumObjectImpl_Release, + ID3DXFileEnumObjectImpl_GetFile, + ID3DXFileEnumObjectImpl_GetChildren, + ID3DXFileEnumObjectImpl_GetChild, + ID3DXFileEnumObjectImpl_GetDataObjectById, + ID3DXFileEnumObjectImpl_GetDataObjectByName +}; + /*** IUnknown methods ***/ @@ -109,9 +216,25 @@ static ULONG WINAPI ID3DXFileImpl_Release(ID3DXFile *iface) static HRESULT WINAPI ID3DXFileImpl_CreateEnumObject(ID3DXFile *iface, const void *source, D3DXF_FILELOADOPTIONS options, ID3DXFileEnumObject **enum_object) { - FIXME("(%p)->(%p, %x, %p): stub\n", iface, source, options, enum_object); + ID3DXFileEnumObjectImpl *object; - return E_NOTIMPL; + FIXME("(%p)->(%p, %x, %p): partial stub\n", iface, source, options, enum_object); + + if (!enum_object) + return E_POINTER; + + *enum_object = NULL; + + object = HeapAlloc(GetProcessHeap(), 0, sizeof(*object)); + if (!object) + return E_OUTOFMEMORY; + + object->ID3DXFileEnumObject_iface.lpVtbl = &ID3DXFileEnumObject_Vtbl; + object->ref = 1; + + *enum_object = &object->ID3DXFileEnumObject_iface; + + return S_OK; }

1 0

Marcus Meissner : dmloader: Check return of CoCreateInstance (Coverity).
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: b27027ef09a15bbdf40328107647be813faced46 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b27027ef09a15bbdf40328107… Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Jan 7 22:17:25 2013 +0100 dmloader: Check return of CoCreateInstance (Coverity). --- dlls/dmloader/loader.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/dlls/dmloader/loader.c b/dlls/dmloader/loader.c index 9a4bddc..39f00a0 100644 --- a/dlls/dmloader/loader.c +++ b/dlls/dmloader/loader.c @@ -463,7 +463,11 @@ static HRESULT WINAPI IDirectMusicLoaderImpl_SetObject(IDirectMusicLoader8 *ifac } /* create object */ - CoCreateInstance (&pDesc->guidClass, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectMusicObject, (LPVOID*)&pObject); + hr = CoCreateInstance (&pDesc->guidClass, NULL, CLSCTX_INPROC_SERVER, &IID_IDirectMusicObject, (LPVOID*)&pObject); + if (FAILED(hr)) { + ERR("Object creation of %s failed 0x%08x\n", debugstr_guid(&pDesc->guidClass),hr); + return DMUS_E_LOADER_FAILEDOPEN; + } /* *sigh*... some ms objects have lousy implementation of ParseDescriptor that clears input descriptor :( */ #ifdef NOW_WE_ARE_FREE

1 0

Marcus Meissner : dplayx: Check return of CoCreateInstance (Coverity).
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: 2cd1fed6ee48e7ff2f919b10cdc0ecc1982847fd URL: http://source.winehq.org/git/wine.git/?a=commit;h=2cd1fed6ee48e7ff2f919b10c… Author: Marcus Meissner <meissner(a)suse.de> Date: Mon Jan 7 22:17:28 2013 +0100 dplayx: Check return of CoCreateInstance (Coverity). --- dlls/dplayx/tests/dplayx.c | 204 ++++++++++++++++++++++++++++++-------------- 1 files changed, 139 insertions(+), 65 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=2cd1fed6ee48e7ff2f919…

1 0

Rico Schüller : d3dx9: Remove unused variable.
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: 7ff6afd091d51c2df2b2632350a5832fd2c7ee04 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7ff6afd091d51c2df2b263235… Author: Rico Schüller <kgbricola(a)web.de> Date: Mon Jan 7 21:57:33 2013 +0100 d3dx9: Remove unused variable. --- dlls/d3dx9_36/shader.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c index ea459ce..3e28a03 100644 --- a/dlls/d3dx9_36/shader.c +++ b/dlls/d3dx9_36/shader.c @@ -1736,10 +1736,9 @@ HRESULT WINAPI D3DXGetShaderConstantTable(const DWORD *byte_code, ID3DXConstantT HRESULT WINAPI D3DXGetShaderSamplers(const DWORD *byte_code, const char **samplers, UINT *count) { - HRESULT hr; UINT i, sampler_count = 0; UINT size; - LPCSTR data; + const char *data; const D3DXSHADER_CONSTANTTABLE *ctab_header; const D3DXSHADER_CONSTANTINFO *constant_info; @@ -1747,8 +1746,8 @@ HRESULT WINAPI D3DXGetShaderSamplers(const DWORD *byte_code, const char **sample if (count) *count = 0; - hr = D3DXFindShaderComment(byte_code, MAKEFOURCC('C','T','A','B'), (LPCVOID *)&data, &size); - if (hr != D3D_OK) return D3D_OK; + if (D3DXFindShaderComment(byte_code, MAKEFOURCC('C','T','A','B'), (const void **)&data, &size) != D3D_OK) + return D3D_OK; if (size < sizeof(*ctab_header)) return D3D_OK;

1 0

Rico Schüller : d3dx9: Constify some variables.
by Alexandre Julliard 08 Jan '13

08 Jan '13

Module: wine Branch: master Commit: e7cd340e8a1292c2f82e52d1537b1009b9464ad3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e7cd340e8a1292c2f82e52d15… Author: Rico Schüller <kgbricola(a)web.de> Date: Mon Jan 7 21:57:29 2013 +0100 d3dx9: Constify some variables. --- dlls/d3dx9_36/shader.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/d3dx9_36/shader.c b/dlls/d3dx9_36/shader.c index 20fcb26..ea459ce 100644 --- a/dlls/d3dx9_36/shader.c +++ b/dlls/d3dx9_36/shader.c @@ -1626,7 +1626,7 @@ HRESULT WINAPI D3DXGetShaderConstantTableEx(const DWORD *byte_code, DWORD flags, LPCVOID data; UINT size; const D3DXSHADER_CONSTANTTABLE *ctab_header; - D3DXSHADER_CONSTANTINFO *constant_info; + const D3DXSHADER_CONSTANTINFO *constant_info; DWORD i; TRACE("byte_code %p, flags %x, constant_table %p\n", byte_code, flags, constant_table); @@ -1703,7 +1703,7 @@ HRESULT WINAPI D3DXGetShaderConstantTableEx(const DWORD *byte_code, DWORD flags, goto error; } - constant_info = (LPD3DXSHADER_CONSTANTINFO)(object->ctab + ctab_header->ConstantInfo); + constant_info = (const D3DXSHADER_CONSTANTINFO *)(object->ctab + ctab_header->ConstantInfo); for (i = 0; i < ctab_header->Constants; i++) { DWORD offset = constant_info[i].DefaultValue; @@ -1734,7 +1734,7 @@ HRESULT WINAPI D3DXGetShaderConstantTable(const DWORD *byte_code, ID3DXConstantT return D3DXGetShaderConstantTableEx(byte_code, 0, constant_table); } -HRESULT WINAPI D3DXGetShaderSamplers(CONST DWORD *byte_code, LPCSTR *samplers, UINT *count) +HRESULT WINAPI D3DXGetShaderSamplers(const DWORD *byte_code, const char **samplers, UINT *count) { HRESULT hr; UINT i, sampler_count = 0; @@ -1755,14 +1755,14 @@ HRESULT WINAPI D3DXGetShaderSamplers(CONST DWORD *byte_code, LPCSTR *samplers, U ctab_header = (const D3DXSHADER_CONSTANTTABLE *)data; if (ctab_header->Size != sizeof(*ctab_header)) return D3D_OK; - constant_info = (D3DXSHADER_CONSTANTINFO *)(data + ctab_header->ConstantInfo); + constant_info = (const D3DXSHADER_CONSTANTINFO *)(data + ctab_header->ConstantInfo); for (i = 0; i < ctab_header->Constants; i++) { const D3DXSHADER_TYPEINFO *type; TRACE("name = %s\n", data + constant_info[i].Name); - type = (D3DXSHADER_TYPEINFO *)(data + constant_info[i].TypeInfo); + type = (const D3DXSHADER_TYPEINFO *)(data + constant_info[i].TypeInfo); if (type->Type == D3DXPT_SAMPLER || type->Type == D3DXPT_SAMPLER1D

1 0

← Newer
1
...
55
56
57
58
59
60
61
...
74
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits January 2013