winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
October 2013
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
757 discussions
Start a n
N
ew thread
Frédéric Delanoy : xcopy: Use BOOL type where appropriate.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: 9b6715226e00d0be889226dfb8e8ae67a6af6a15 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9b6715226e00d0be889226dfb…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Oct 15 00:27:18 2013 +0200 xcopy: Use BOOL type where appropriate. --- programs/xcopy/xcopy.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/xcopy/xcopy.c b/programs/xcopy/xcopy.c index e3312db..3967b18 100644 --- a/programs/xcopy/xcopy.c +++ b/programs/xcopy/xcopy.c @@ -662,7 +662,7 @@ static WCHAR *skip_whitespace(WCHAR *p) Example: 'XCOPY "c:\DIR A" "c:DIR B\"' is OK. */ static int find_end_of_word(const WCHAR *word, WCHAR **end) { - BOOL in_quotes = 0; + BOOL in_quotes = FALSE; const WCHAR *ptr = word; for (;;) { for (; *ptr != '\0' && *ptr != '"' &&
1
0
0
0
Frédéric Delanoy : win87em.dll16: Use BOOL type where appropriate.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: 34ad2d20a22e5f983b911feed10d811a3aa4f8e3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=34ad2d20a22e5f983b911feed…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Oct 15 00:27:17 2013 +0200 win87em.dll16: Use BOOL type where appropriate. --- dlls/win87em.dll16/win87em.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/win87em.dll16/win87em.c b/dlls/win87em.dll16/win87em.c index 6154ac6..c8d4545 100644 --- a/dlls/win87em.dll16/win87em.c +++ b/dlls/win87em.dll16/win87em.c @@ -45,7 +45,7 @@ struct Win87EmInfoStruct */ /* FIXME: Still rather skeletal implementation only */ -static BOOL Installed = 1; /* 8087 is installed */ +static BOOL Installed = TRUE; /* 8087 is installed */ static WORD RefCount = 0; static WORD CtrlWord_1 = 0; static WORD CtrlWord_2 = 0;
1
0
0
0
Frédéric Delanoy : ole32: Use BOOL type where appropriate.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: 4bb61ec0df4c1ec68a105011eca29f5b5770798c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4bb61ec0df4c1ec68a105011e…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Oct 15 00:27:16 2013 +0200 ole32: Use BOOL type where appropriate. --- dlls/ole32/bindctx.c | 7 +++---- dlls/ole32/filemoniker.c | 12 ++++++------ dlls/ole32/ifs.c | 32 ++++++++++++++++---------------- dlls/ole32/storage32.c | 20 ++++++++++---------- dlls/ole32/storage32.h | 6 +++--- dlls/ole32/stubmanager.c | 2 +- 6 files changed, 39 insertions(+), 40 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=4bb61ec0df4c1ec68a105…
1
0
0
0
Frédéric Delanoy : net: Use BOOL type where appropriate.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: 06a66688a3a794c3e0e6bf72ab9f464981c49836 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=06a66688a3a794c3e0e6bf72a…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Oct 15 00:27:15 2013 +0200 net: Use BOOL type where appropriate. --- programs/net/net.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/programs/net/net.c b/programs/net/net.c index 06c8aac..0d5de52 100644 --- a/programs/net/net.c +++ b/programs/net/net.c @@ -235,7 +235,7 @@ static BOOL StopService(SC_HANDLE SCManager, SC_HANDLE serviceHandle) static BOOL net_service(int operation, const WCHAR* service_name) { SC_HANDLE SCManager, serviceHandle; - BOOL result = 0; + BOOL result = FALSE; WCHAR service_display_name[4096]; DWORD buffer_size; @@ -288,7 +288,7 @@ static BOOL net_service(int operation, const WCHAR* service_name) return result; } -static int arg_is(const WCHAR* str1, const WCHAR* str2) +static BOOL arg_is(const WCHAR* str1, const WCHAR* str2) { return CompareStringW(LOCALE_USER_DEFAULT, NORM_IGNORECASE, str1, -1, str2, -1) == CSTR_EQUAL; }
1
0
0
0
Frédéric Delanoy : attrib: Use BOOL type where appropriate.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: 70205f583c30b4946a6a137953f275336d2788e3 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=70205f583c30b4946a6a13795…
Author: Frédéric Delanoy <frederic.delanoy(a)gmail.com> Date: Tue Oct 15 00:27:14 2013 +0200 attrib: Use BOOL type where appropriate. --- programs/attrib/attrib.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/programs/attrib/attrib.c b/programs/attrib/attrib.c index 4342779..28172b0 100644 --- a/programs/attrib/attrib.c +++ b/programs/attrib/attrib.c @@ -253,7 +253,7 @@ int wmain(int argc, WCHAR *argv[]) WCHAR originalname[MAX_PATH]; DWORD attrib_set = 0; DWORD attrib_clear = 0; - BOOL attrib_recurse = 0; + BOOL attrib_recurse = FALSE; BOOL attrib_includedirs = FALSE; static const WCHAR help_option[] = {'/','?','\0'}; static const WCHAR wildcardsW[] = {'*','?','\0'};
1
0
0
0
Michael Stefaniuc : dsound/tests: Compile with -D__WINESRC__.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: 4dd5893ad773833000d39058ce90e7207a8e805e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4dd5893ad773833000d39058c…
Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Mon Oct 14 23:19:31 2013 +0200 dsound/tests: Compile with -D__WINESRC__. --- dlls/dsound/tests/Makefile.in | 1 - dlls/dsound/tests/capture.c | 4 ++-- dlls/dsound/tests/ds3d.c | 2 +- dlls/dsound/tests/ds3d8.c | 2 +- dlls/dsound/tests/dsound.c | 4 ++-- dlls/dsound/tests/dsound8.c | 2 +- dlls/dsound/tests/duplex.c | 2 +- dlls/dsound/tests/propset.c | 1 + 8 files changed, 9 insertions(+), 9 deletions(-) diff --git a/dlls/dsound/tests/Makefile.in b/dlls/dsound/tests/Makefile.in index 7302458..f97f716 100644 --- a/dlls/dsound/tests/Makefile.in +++ b/dlls/dsound/tests/Makefile.in @@ -1,6 +1,5 @@ TESTDLL = dsound.dll IMPORTS = ole32 version user32 -EXTRADEFS = -U__WINESRC__ -DWINE_STRICT_PROTOTYPES -DWINE_NO_NAMELESS_EXTENSION -DWIDL_C_INLINE_WRAPPERS C_SRCS = \ capture.c \ diff --git a/dlls/dsound/tests/capture.c b/dlls/dsound/tests/capture.c index 74889d6..3e717f5 100644 --- a/dlls/dsound/tests/capture.c +++ b/dlls/dsound/tests/capture.c @@ -24,8 +24,8 @@ #include "initguid.h" #include "windows.h" #include "wine/test.h" +#include "mmsystem.h" #include "dsound.h" -#include "mmreg.h" #include "dsconf.h" #include "dsound_test.h" @@ -373,7 +373,7 @@ static void test_capture_buffer(LPDIRECTSOUNDCAPTURE dsco, state.wfx=&wfx; state.buffer_size = dscbcaps.dwBufferBytes; for (i = 0; i < NOTIFICATIONS; i++) - state.event[i] = CreateEvent( NULL, FALSE, FALSE, NULL ); + state.event[i] = CreateEventW(NULL, FALSE, FALSE, NULL); state.size = dscbcaps.dwBufferBytes / NOTIFICATIONS; rc=IDirectSoundCaptureBuffer_QueryInterface(dscbo,&IID_IDirectSoundNotify, diff --git a/dlls/dsound/tests/ds3d.c b/dlls/dsound/tests/ds3d.c index 7682851..8cf46a8 100644 --- a/dlls/dsound/tests/ds3d.c +++ b/dlls/dsound/tests/ds3d.c @@ -28,8 +28,8 @@ #include <math.h> #include "wine/test.h" +#include "mmsystem.h" #include "dsound.h" -#include "mmreg.h" #include "ks.h" #include "ksmedia.h" #include "dsound_test.h" diff --git a/dlls/dsound/tests/ds3d8.c b/dlls/dsound/tests/ds3d8.c index 77f6f88..1c8b285 100644 --- a/dlls/dsound/tests/ds3d8.c +++ b/dlls/dsound/tests/ds3d8.c @@ -28,8 +28,8 @@ #include <math.h> #include "wine/test.h" +#include "mmsystem.h" #include "dsound.h" -#include "mmreg.h" #include "ks.h" #include "ksmedia.h" #include "dsound_test.h" diff --git a/dlls/dsound/tests/dsound.c b/dlls/dsound/tests/dsound.c index 4be91fb..92262ce 100644 --- a/dlls/dsound/tests/dsound.c +++ b/dlls/dsound/tests/dsound.c @@ -29,9 +29,9 @@ #include <windows.h> #include "wine/test.h" +#include "mmsystem.h" #include "dsound.h" #include "dsconf.h" -#include "mmreg.h" #include "initguid.h" #include "ks.h" #include "ksmedia.h" @@ -1135,7 +1135,7 @@ static HRESULT test_duplicate(LPGUID lpGuid) /* Prepare notify events */ for (i=0;i<sizeof(event)/sizeof(event[0]);i++) { - event[i] = CreateEvent(NULL,FALSE,FALSE,NULL); + event[i] = CreateEventW(NULL, FALSE, FALSE, NULL); } /* Make silent buffer */ diff --git a/dlls/dsound/tests/dsound8.c b/dlls/dsound/tests/dsound8.c index fe5bbe0..dc7af3d 100644 --- a/dlls/dsound/tests/dsound8.c +++ b/dlls/dsound/tests/dsound8.c @@ -31,9 +31,9 @@ #include <stdio.h> #include "wine/test.h" +#include "mmsystem.h" #include "dsound.h" #include "dsconf.h" -#include "mmreg.h" #include "ks.h" #include "ksmedia.h" diff --git a/dlls/dsound/tests/duplex.c b/dlls/dsound/tests/duplex.c index d30cc25..739811d 100644 --- a/dlls/dsound/tests/duplex.c +++ b/dlls/dsound/tests/duplex.c @@ -23,8 +23,8 @@ #include <stdio.h> #include "wine/test.h" +#include "mmsystem.h" #include "dsound.h" -#include "mmreg.h" #include "dsconf.h" #include "dsound_test.h" diff --git a/dlls/dsound/tests/propset.c b/dlls/dsound/tests/propset.c index c62c02a..222120d 100644 --- a/dlls/dsound/tests/propset.c +++ b/dlls/dsound/tests/propset.c @@ -23,6 +23,7 @@ #include <windows.h> #include "wine/test.h" +#include "mmsystem.h" #include "dsound.h" #include "dsconf.h"
1
0
0
0
Alexandre Julliard : makefiles: Generate explicit build rules for testlist. c from makedep.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: edf4dab5efe086305e6553f32343c8d03a4068b2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=edf4dab5efe086305e6553f32…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 15 12:39:42 2013 +0200 makefiles: Generate explicit build rules for testlist.c from makedep. --- Make.rules.in | 3 --- tools/makedep.c | 26 ++++++++++++++++++++++---- 2 files changed, 22 insertions(+), 7 deletions(-) diff --git a/Make.rules.in b/Make.rules.in index 116dffd..cc04821 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -123,9 +123,6 @@ $(CROSSTESTMODULE): $(CROSSOBJS) Makefile.in $(WINETEST_RES): $(TESTMODULE_STRIPPED) echo "$(TESTMODULE) TESTRES \"$(TESTMODULE_STRIPPED)\"" | $(WRC) $(RCFLAGS) -o $@ -testlist.c: Makefile.in $(MAKECTESTS) - $(MAKECTESTS) -o $@ $(C_SRCS) - testclean:: $(RM) *.ok diff --git a/tools/makedep.c b/tools/makedep.c index 6141d4b..e41fa77 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -835,6 +835,17 @@ static void parse_generated_idl( struct incl_file *source ) } /******************************************************************* + * is_generated_idl + */ +static int is_generated_idl( struct incl_file *source ) +{ + return (strendswith( source->name, "_c.c" ) || + strendswith( source->name, "_i.c" ) || + strendswith( source->name, "_p.c" ) || + strendswith( source->name, "_s.c" )); +} + +/******************************************************************* * parse_file */ static void parse_file( struct incl_file *source, int src ) @@ -842,10 +853,7 @@ static void parse_file( struct incl_file *source, int src ) FILE *file; /* special case for source files generated from idl */ - if (strendswith( source->name, "_c.c" ) || - strendswith( source->name, "_i.c" ) || - strendswith( source->name, "_p.c" ) || - strendswith( source->name, "_s.c" )) + if (is_generated_idl( source )) { parse_generated_idl( source ); return; @@ -1106,6 +1114,16 @@ static void output_sources(void) output_filename( source->filename, &column ); output( "\n" ); } + + if (find_src_file( "testlist.o" )) + { + output( "testlist.c: $(MAKECTESTS) Makefile.in\n" ); + column = output( "\t$(MAKECTESTS) -o $@" ); + LIST_FOR_EACH_ENTRY( source, &sources, struct incl_file, entry ) + if (strendswith( source->name, ".c" ) && !is_generated_idl( source )) + output_filename( source->filename, &column ); + output( "\n" ); + } }
1
0
0
0
Alexandre Julliard : makefiles: Generate explicit build rules for dlldata. c from makedep.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: d4593274dcd02ce875f3f88974f1d10c59d590d9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d4593274dcd02ce875f3f8897…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 15 12:35:11 2013 +0200 makefiles: Generate explicit build rules for dlldata.c from makedep. --- Make.rules.in | 5 ----- tools/makedep.c | 10 ++++++++++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/Make.rules.in b/Make.rules.in index 83797ba..116dffd 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -65,11 +65,6 @@ CROSSOBJS = $(OBJS:.o=.cross.o) .po.mo: $(MSGFMT) -o $@ $< -# Rules for IDL files - -dlldata.c: $(WIDL) Makefile.in - $(WIDL) $(IDLFLAGS) --dlldata-only -o $@ $(IDL_P_SRCS) - # Rules for main module $(MODULE) $(MODULE:%=%.so) $(MODULE:%=%.fake): $(MAINSPEC) $(OBJS) Makefile.in diff --git a/tools/makedep.c b/tools/makedep.c index 384a1a2..6141d4b 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -1096,6 +1096,16 @@ static void output_sources(void) if (strendswith( source->name, ".mc" )) output_filename( source->filename, &column ); output( "\n" ); } + + if (find_src_file( "dlldata.o" )) + { + output( "dlldata.c: $(WIDL) Makefile.in\n" ); + column = output( "\t$(WIDL) $(IDLFLAGS) --dlldata-only -o $@" ); + LIST_FOR_EACH_ENTRY( source, &sources, struct incl_file, entry ) + if (strendswith( source->name, ".idl" ) && find_target_src_file( source->name, "_p.c" )) + output_filename( source->filename, &column ); + output( "\n" ); + } }
1
0
0
0
Alexandre Julliard : makefiles: Generate explicit build rules for idl files from makedep.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: d9a75184c77b292e5ac028cb0bb6158a89630162 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d9a75184c77b292e5ac028cb0…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 15 12:30:54 2013 +0200 makefiles: Generate explicit build rules for idl files from makedep. --- Make.rules.in | 32 +---------------------------- tools/makedep.c | 59 ++++++++++++++++++++++++++++++++++-------------------- 2 files changed, 39 insertions(+), 52 deletions(-) diff --git a/Make.rules.in b/Make.rules.in index ee51208..83797ba 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -36,7 +36,7 @@ CROSSOBJS = $(OBJS:.o=.cross.o) # Implicit rules -.SUFFIXES: .idl .tlb .h .ok .man.in .man _c.c _i.c _p.c _s.c _r.res _t.res .cross.o .po .mo @MAINTAINER_MODE@ .sfd .ttf .svg .ico .bmp +.SUFFIXES: .ok .man.in .man .cross.o .po .mo @MAINTAINER_MODE@ .sfd .ttf .svg .ico .bmp .c.o: $(CC) -c $(ALLCFLAGS) -o $@ $< @@ -47,30 +47,6 @@ CROSSOBJS = $(OBJS:.o=.cross.o) .c.cross.o: $(CROSSCC) -c $(INCLUDES) $(DEFS) -DWINE_CROSSTEST $(CPPFLAGS) $(CFLAGS) -o $@ $< -.idl.h: - $(WIDL) $(IDLFLAGS) -h -o $@ $< - -.idl_c.c: - $(WIDL) $(IDLFLAGS) -c -o $@ $< - -.idl_i.c: - $(WIDL) $(IDLFLAGS) -u -o $@ $< - -.idl_p.c: - $(WIDL) $(IDLFLAGS) -p -o $@ $< - -.idl_r.res: - $(WIDL) $(IDLFLAGS) -r -o $@ $< - -.idl_s.c: - $(WIDL) $(IDLFLAGS) -s -o $@ $< - -.idl.tlb: - $(WIDL) $(TARGETFLAGS) $(IDLFLAGS) -t -o $@ $< - -.idl_t.res: - $(WIDL) $(TARGETFLAGS) $(IDLFLAGS) -t -o $@ $< - .c.ok: $(RUNTEST) $(RUNTESTFLAGS) $< && touch $@ @@ -129,7 +105,7 @@ $(IMPORTLIB:%=lib%.cross.a): $(MAINSPEC) $(IMPLIB_SRCS:.c=.cross.o) # Rules for dependencies DEPEND_SRCS = $(C_SRCS) $(OBJC_SRCS) $(RC_SRCS) $(MC_SRCS) $(PO_SRCS:.rc=.pot) \ - $(IDL_H_SRCS) $(IDL_C_SRCS) $(IDL_I_SRCS) $(IDL_P_SRCS) $(IDL_S_SRCS) \ + $(IDL_H_SRCS) $(IDL_C_SRCS) $(IDL_I_SRCS) $(IDL_P_SRCS) $(IDL_R_SRCS) $(IDL_S_SRCS) \ $(IDL_GEN_C_SRCS) $(IDL_R_SRCS:.idl=_r.res) $(IDL_TLB_SRCS) $(IDL_TLB_SRCS:.idl=.tlb) \ $(BISON_SRCS) $(LEX_SRCS) $(EXTRA_OBJS) @@ -207,8 +183,4 @@ install install-lib install-dev uninstall:: .PHONY: install install-lib install-dev uninstall -# Misc. rules - -$(IDL_GEN_HEADERS) $(IDL_GEN_C_SRCS) $(IDL_TLB_SRCS:.idl=.tlb) $(IDL_TLB_RES) $(IDL_R_SRCS:.idl=_r.res): $(WIDL) - # End of global rules diff --git a/tools/makedep.c b/tools/makedep.c index dcf7414..384a1a2 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -1005,36 +1005,51 @@ static void output_sources(void) } else if (!strcmp( ext, "idl" )) /* IDL file */ { - char *name; - int got_header = 0; - const char *suffix = "cips"; + char *targets[8]; + int nb_targets = 0; + char ending[] = "_?.c"; + const char *suffix; + char *header = strmake( "%s.h", obj ); - name = strmake( "%s.tlb", obj ); - if (find_src_file( name )) column += output( "%s %s_t.res", name, obj ); - else + if (find_target_src_file( source->name, ".tlb" )) { - got_header = 1; - column += output( "%s.h", obj ); + output( "%s.tlb %s_t.res: $(WIDL)\n", obj, obj ); + output( "\t$(WIDL) $(TARGETFLAGS) $(IDLFLAGS) -t -o $@ %s\n", source->filename ); + targets[nb_targets++] = strmake( "%s.tlb", obj ); + targets[nb_targets++] = strmake( "%s_t.res", obj ); } - free( name ); - while (*suffix) + for (suffix = "cips"; *suffix; suffix++) { - name = strmake( "%s_%c.c", obj, *suffix ); - if (find_src_file( name )) - { - if (!got_header++) column += output( " %s.h", obj ); - column += output( " %s", name ); - } - free( name ); - suffix++; + ending[1] = *suffix; + if (!find_target_src_file( source->name, ending )) continue; + output( "%s%s: $(WIDL)\n", obj, ending ); + output( "\t$(WIDL) $(IDLFLAGS) -%c -o $@ %s\n", + *suffix == 'i' ? 'u' : *suffix, source->filename ); + targets[nb_targets++] = strmake( "%s%s", obj, ending ); } - name = strmake( "%s_r.res", obj ); - if (find_src_file( name )) column += output( " %s", name ); - free( name ); + if (find_target_src_file( source->name, "_r.res" )) + { + output( "%s_r.res: $(WIDL)\n", obj ); + output( "\t$(WIDL) $(IDLFLAGS) -r -o $@ %s\n", source->filename ); + targets[nb_targets++] = strmake( "%s_r.res", obj ); + } - column += output( ": %s", source->filename ); + if (!nb_targets || find_include_file( header )) + { + output( "%s.h: $(WIDL)\n", obj ); + output( "\t$(WIDL) $(IDLFLAGS) -h -o $@ %s\n", source->filename ); + targets[nb_targets++] = header; + } + else free( header ); + + for (i = 0; i < nb_targets; i++) + { + column += output( "%s%c", targets[i], i < nb_targets - 1 ? ' ' : ':' ); + free( targets[i] ); + } + column += output( " %s", source->filename ); } else if (!strcmp( ext, "tlb" ) || !strcmp( ext, "res" ) || !strcmp( ext, "pot" )) {
1
0
0
0
Alexandre Julliard : makefiles: Generate explicit build rules for resource files from makedep.
by Alexandre Julliard
15 Oct '13
15 Oct '13
Module: wine Branch: master Commit: 25b08106550508edfb8c471d7fc84f7543d7f401 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=25b08106550508edfb8c471d7…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Oct 15 00:14:51 2013 +0200 makefiles: Generate explicit build rules for resource files from makedep. --- Make.rules.in | 15 +---------- programs/winetest/Makefile.in | 3 +- tools/makedep.c | 52 ++++++++++++++++++++++++++++++++++++++-- 3 files changed, 53 insertions(+), 17 deletions(-) diff --git a/Make.rules.in b/Make.rules.in index 06dea78..ee51208 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -36,7 +36,7 @@ CROSSOBJS = $(OBJS:.o=.cross.o) # Implicit rules -.SUFFIXES: .rc .res .idl .tlb .h .ok .man.in .man _c.c _i.c _p.c _s.c _r.res _t.res .cross.o .po .mo @MAINTAINER_MODE@ .sfd .ttf .svg .ico .bmp +.SUFFIXES: .idl .tlb .h .ok .man.in .man _c.c _i.c _p.c _s.c _r.res _t.res .cross.o .po .mo @MAINTAINER_MODE@ .sfd .ttf .svg .ico .bmp .c.o: $(CC) -c $(ALLCFLAGS) -o $@ $< @@ -47,9 +47,6 @@ CROSSOBJS = $(OBJS:.o=.cross.o) .c.cross.o: $(CROSSCC) -c $(INCLUDES) $(DEFS) -DWINE_CROSSTEST $(CPPFLAGS) $(CFLAGS) -o $@ $< -.rc.res: - $(WRC) $(RCFLAGS) -o $@ $< - .idl.h: $(WIDL) $(IDLFLAGS) -h -o $@ $< @@ -131,7 +128,7 @@ $(IMPORTLIB:%=lib%.cross.a): $(MAINSPEC) $(IMPLIB_SRCS:.c=.cross.o) # Rules for dependencies -DEPEND_SRCS = $(C_SRCS) $(OBJC_SRCS) $(RC_SRCS) $(MC_SRCS) \ +DEPEND_SRCS = $(C_SRCS) $(OBJC_SRCS) $(RC_SRCS) $(MC_SRCS) $(PO_SRCS:.rc=.pot) \ $(IDL_H_SRCS) $(IDL_C_SRCS) $(IDL_I_SRCS) $(IDL_P_SRCS) $(IDL_S_SRCS) \ $(IDL_GEN_C_SRCS) $(IDL_R_SRCS:.idl=_r.res) $(IDL_TLB_SRCS) $(IDL_TLB_SRCS:.idl=.tlb) \ $(BISON_SRCS) $(LEX_SRCS) $(EXTRA_OBJS) @@ -210,14 +207,6 @@ install install-lib install-dev uninstall:: .PHONY: install install-lib install-dev uninstall -# Rules for resources - -rsrc.pot: $(WRC) - $(WRC) $(RCFLAGS) -O pot -o $@ $(PO_SRCS) - -$(RC_SRCS:.rc=.res): $(WRC) -$(PO_SRCS:.rc=.res): $(ALL_MO_FILES) - # Misc. rules $(IDL_GEN_HEADERS) $(IDL_GEN_C_SRCS) $(IDL_TLB_SRCS:.idl=.tlb) $(IDL_TLB_RES) $(IDL_R_SRCS:.idl=_r.res): $(WIDL) diff --git a/programs/winetest/Makefile.in b/programs/winetest/Makefile.in index 898e995..6865e93 100644 --- a/programs/winetest/Makefile.in +++ b/programs/winetest/Makefile.in @@ -25,6 +25,7 @@ build.rc: dummy build.nfo: -$(CC) -v 2>$@ -build.res: build.nfo +build.res: build.rc build.nfo + $(WRC) $(RCFLAGS) -o $@ build.rc @MAKE_PROG_RULES@ diff --git a/tools/makedep.c b/tools/makedep.c index db92d53..dcf7414 100644 --- a/tools/makedep.c +++ b/tools/makedep.c @@ -96,6 +96,7 @@ static const char Usage[] = static void fatal_error( const char *msg, ... ) __attribute__ ((__format__ (__printf__, 1, 2))); static void fatal_perror( const char *msg, ... ) __attribute__ ((__format__ (__printf__, 1, 2))); static int output( const char *format, ... ) __attribute__ ((__format__ (__printf__, 1, 2))); +static char *strmake( const char* fmt, ... ) __attribute__ ((__format__ (__printf__, 1, 2))); /******************************************************************* * fatal_error @@ -341,6 +342,24 @@ static struct incl_file *find_include_file( const char *name ) } /******************************************************************* + * find_target_src_file + * + * Check if we have a source file as a target for the specified source with a different extension. + */ +static struct incl_file *find_target_src_file( const char *name, const char *ext ) +{ + struct incl_file *ret; + char *p, *match = xmalloc( strlen( name ) + strlen( ext ) + 1 ); + + strcpy( match, name ); + if ((p = get_extension( match ))) strcpy( p, ext ); + else strcat( match, ext ); + ret = find_src_file( match ); + free( match ); + return ret; +} + +/******************************************************************* * add_include * * Add an include file if it doesn't already exists. @@ -858,6 +877,7 @@ static void parse_file( struct incl_file *source, int src ) /* don't try to open certain types of files */ if (strendswith( source->name, ".tlb" ) || strendswith( source->name, ".res" ) || + strendswith( source->name, ".pot" ) || strendswith( source->name, ".x" )) { source->filename = xstrdup( source->name ); @@ -926,7 +946,7 @@ static void output_include( struct incl_file *pFile, struct incl_file *owner, in static void output_sources(void) { struct incl_file *source; - int i, column, mc_srcs = 0; + int i, column, po_srcs = 0, mc_srcs = 0; LIST_FOR_EACH_ENTRY( source, &sources, struct incl_file, entry ) { @@ -962,7 +982,19 @@ static void output_sources(void) } else if (!strcmp( ext, "rc" )) /* resource file */ { - column += output( "rsrc.pot %s.res: %s", obj, source->filename ); + if (find_target_src_file( source->name, ".pot" )) + { + output( "%s.res: $(WRC) $(ALL_MO_FILES) %s\n", obj, source->filename ); + output( "\t$(WRC) $(RCFLAGS) -o $@ %s\n", source->filename ); + column += output( "%s.res rsrc.pot:", obj ); + po_srcs++; + } + else + { + output( "%s.res: $(WRC) %s\n", obj, source->filename ); + output( "\t$(WRC) $(RCFLAGS) -o $@ %s\n", source->filename ); + column += output( "%s.res:", obj ); + } } else if (!strcmp( ext, "mc" )) /* message file */ { @@ -1004,7 +1036,7 @@ static void output_sources(void) column += output( ": %s", source->filename ); } - else if (!strcmp( ext, "tlb" ) || !strcmp( ext, "res" )) + else if (!strcmp( ext, "tlb" ) || !strcmp( ext, "res" ) || !strcmp( ext, "pot" )) { continue; /* nothing to do for typelib files */ } @@ -1024,6 +1056,20 @@ static void output_sources(void) /* rules for files that depend on multiple sources */ + if (po_srcs) + { + column = output( "rsrc.pot: $(WRC)" ); + LIST_FOR_EACH_ENTRY( source, &sources, struct incl_file, entry ) + if (strendswith( source->name, ".rc" ) && find_target_src_file( source->name, ".pot" )) + output_filename( source->filename, &column ); + output( "\n" ); + column = output( "\t$(WRC) $(RCFLAGS) -O pot -o $@" ); + LIST_FOR_EACH_ENTRY( source, &sources, struct incl_file, entry ) + if (strendswith( source->name, ".rc" ) && find_target_src_file( source->name, ".pot" )) + output_filename( source->filename, &column ); + output( "\n" ); + } + if (mc_srcs) { column = output( "msg.pot: $(WMC)" );
1
0
0
0
← Newer
1
...
41
42
43
44
45
46
47
...
76
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
Results per page:
10
25
50
100
200