wine-commits December 2013

wine-commits@winehq.org

3 participants
462 discussions

Aric Stewart : tools: Build vertical orientation table.
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: 742cde4fab39bdcfb4cd101673328b891b2b168b URL: http://source.winehq.org/git/wine.git/?a=commit;h=742cde4fab39bdcfb4cd10167… Author: Aric Stewart <aric(a)codeweavers.com> Date: Fri Nov 15 10:37:24 2013 -0600 tools: Build vertical orientation table. Based on data related to UTR #50 Unicode Vertical Text Layout. --- dlls/gdi32/Makefile.in | 3 +- dlls/gdi32/vertical.c | 204 +++++++++++++++++++++++++++++++++++++++++++ dlls/wineps.drv/Makefile.in | 3 +- dlls/wineps.drv/vertical.c | 204 +++++++++++++++++++++++++++++++++++++++++++ tools/make_unicode | 60 +++++++++++++ 5 files changed, 472 insertions(+), 2 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=742cde4fab39bdcfb4cd1…

1 0

Henri Verbeet : ddraw: Reject creating primary surfaces with DDSCAPS_TEXTURE.
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: 6cba2285bc9bc5adeed3f4300d4a23c3e23c56a8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6cba2285bc9bc5adeed3f4300… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 4 09:49:37 2013 +0100 ddraw: Reject creating primary surfaces with DDSCAPS_TEXTURE. --- dlls/ddraw/surface.c | 20 ++++++++++++++------ 1 files changed, 14 insertions(+), 6 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 9d570e4..79d5b31 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -5627,13 +5627,21 @@ HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_ if ((desc->ddsCaps.dwCaps & DDSCAPS_ALLOCONLOAD) || !desc->lpSurface) desc->dwFlags &= ~DDSD_LPSURFACE; - if ((desc->ddsCaps.dwCaps & (DDSCAPS_FLIP | DDSCAPS_PRIMARYSURFACE)) - == (DDSCAPS_FLIP | DDSCAPS_PRIMARYSURFACE) - && !(ddraw->cooperative_level & DDSCL_EXCLUSIVE)) + if (desc->ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE) { - WARN("Tried to create a flippable primary surface without DDSCL_EXCLUSIVE.\n"); - HeapFree(GetProcessHeap(), 0, texture); - return DDERR_NOEXCLUSIVEMODE; + if (desc->ddsCaps.dwCaps & DDSCAPS_TEXTURE) + { + WARN("Tried to create a primary surface with DDSCAPS_TEXTURE.\n"); + HeapFree(GetProcessHeap(), 0, texture); + return DDERR_INVALIDCAPS; + } + + if ((desc->ddsCaps.dwCaps & DDSCAPS_FLIP) && !(ddraw->cooperative_level & DDSCL_EXCLUSIVE)) + { + WARN("Tried to create a flippable primary surface without DDSCL_EXCLUSIVE.\n"); + HeapFree(GetProcessHeap(), 0, texture); + return DDERR_NOEXCLUSIVEMODE; + } } /* This is a special case in ddrawex, but not allowed in ddraw. */

1 0

Henri Verbeet : ddraw: Reject explicitly creating a flippable front buffer.
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: a9afc9356e5469b24cdf6f8b4be912e33b52c422 URL: http://source.winehq.org/git/wine.git/?a=commit;h=a9afc9356e5469b24cdf6f8b4… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 4 09:49:36 2013 +0100 ddraw: Reject explicitly creating a flippable front buffer. --- dlls/ddraw/ddraw.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c index 7fca84c..ee1d19c 100644 --- a/dlls/ddraw/ddraw.c +++ b/dlls/ddraw/ddraw.c @@ -2921,11 +2921,10 @@ static HRESULT WINAPI ddraw1_CreateSurface(IDirectDraw *iface, return DDERR_INVALIDPARAMS; } - /* Remove front buffer flag, this causes failure in v7, and its added to normal - * primaries anyway. */ - surface_desc->ddsCaps.dwCaps &= ~DDSCAPS_FRONTBUFFER; if ((surface_desc->ddsCaps.dwCaps & (DDSCAPS_PRIMARYSURFACE | DDSCAPS_BACKBUFFER)) - == (DDSCAPS_PRIMARYSURFACE | DDSCAPS_BACKBUFFER)) + == (DDSCAPS_PRIMARYSURFACE | DDSCAPS_BACKBUFFER) + || (surface_desc->ddsCaps.dwCaps & (DDSCAPS_FLIP | DDSCAPS_FRONTBUFFER)) + == ((DDSCAPS_FLIP | DDSCAPS_FRONTBUFFER))) { WARN("Application tried to create an explicit front or back buffer.\n"); wined3d_mutex_unlock();

1 0

Henri Verbeet : ddraw: Validate that surfaces are on the same swap chain in ddraw_surface7_Flip() .
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: 00eaf27dc78353c23b9068051c988e301f902208 URL: http://source.winehq.org/git/wine.git/?a=commit;h=00eaf27dc78353c23b9068051… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 4 09:49:35 2013 +0100 ddraw: Validate that surfaces are on the same swap chain in ddraw_surface7_Flip(). --- dlls/ddraw/surface.c | 73 ++++++++++++++++++++------------------------ dlls/ddraw/tests/ddraw1.c | 2 +- dlls/ddraw/tests/ddraw2.c | 2 +- dlls/ddraw/tests/ddraw4.c | 2 +- dlls/ddraw/tests/ddraw7.c | 2 +- 5 files changed, 37 insertions(+), 44 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 477ef4f..9d570e4 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -1170,62 +1170,55 @@ static HRESULT WINAPI ddraw_surface1_Unlock(IDirectDrawSurface *iface, void *dat return ddraw_surface7_Unlock(&surface->IDirectDrawSurface7_iface, NULL); } -/***************************************************************************** - * IDirectDrawSurface7::Flip - * - * Flips a surface with the DDSCAPS_FLIP flag. The flip is relayed to - * IWineD3DSurface::Flip. Because WineD3D doesn't handle attached surfaces, - * the flip target is passed to WineD3D, even if the app didn't specify one - * - * Params: - * DestOverride: Specifies the surface that will become the new front - * buffer. If NULL, the current back buffer is used - * Flags: some DirectDraw flags, see include/ddraw.h - * - * Returns: - * DD_OK on success - * DDERR_NOTFLIPPABLE if no flip target could be found - * DDERR_INVALIDOBJECT if the surface isn't a front buffer - * For more details, see IWineD3DSurface::Flip - * - *****************************************************************************/ -static HRESULT WINAPI ddraw_surface7_Flip(IDirectDrawSurface7 *iface, IDirectDrawSurface7 *DestOverride, DWORD Flags) +static HRESULT WINAPI ddraw_surface7_Flip(IDirectDrawSurface7 *iface, IDirectDrawSurface7 *src, DWORD flags) { - struct ddraw_surface *surface = impl_from_IDirectDrawSurface7(iface); - struct ddraw_surface *Override = unsafe_impl_from_IDirectDrawSurface7(DestOverride); - IDirectDrawSurface7 *Override7; + struct ddraw_surface *dst_impl = impl_from_IDirectDrawSurface7(iface); + struct ddraw_surface *src_impl = unsafe_impl_from_IDirectDrawSurface7(src); + DDSCAPS2 caps = {DDSCAPS_FLIP, 0, 0, 0}; + IDirectDrawSurface7 *current; HRESULT hr; - TRACE("iface %p, dst %p, flags %#x.\n", iface, DestOverride, Flags); + TRACE("iface %p, src %p, flags %#x.\n", iface, src, flags); - if (DestOverride == iface || !(surface->surface_desc.ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER | DDSCAPS_OVERLAY))) + if (src == iface || !(dst_impl->surface_desc.ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER | DDSCAPS_OVERLAY))) return DDERR_NOTFLIPPABLE; wined3d_mutex_lock(); - /* WineD3D doesn't keep track of attached surface, so find the target */ - if(!Override) + if (src_impl) { - DDSCAPS2 Caps; - - memset(&Caps, 0, sizeof(Caps)); - Caps.dwCaps |= DDSCAPS_BACKBUFFER; - hr = ddraw_surface7_GetAttachedSurface(iface, &Caps, &Override7); - if(hr != DD_OK) + for (current = iface; current != src;) + { + if (FAILED(hr = ddraw_surface7_GetAttachedSurface(current, &caps, &current))) + { + WARN("Surface %p is not on the same flip chain as surface %p.\n", src, iface); + wined3d_mutex_unlock(); + return DDERR_NOTFLIPPABLE; + } + ddraw_surface7_Release(current); + if (current == iface) + { + WARN("Surface %p is not on the same flip chain as surface %p.\n", src, iface); + wined3d_mutex_unlock(); + return DDERR_NOTFLIPPABLE; + } + } + } + else + { + if (FAILED(hr = ddraw_surface7_GetAttachedSurface(iface, &caps, &current))) { ERR("Can't find a flip target\n"); wined3d_mutex_unlock(); return DDERR_NOTFLIPPABLE; /* Unchecked */ } - Override = impl_from_IDirectDrawSurface7(Override7); - - /* For the GetAttachedSurface */ - ddraw_surface7_Release(Override7); + src_impl = impl_from_IDirectDrawSurface7(current); + ddraw_surface7_Release(current); } - hr = wined3d_surface_flip(surface->wined3d_surface, Override->wined3d_surface, Flags); - if (SUCCEEDED(hr) && surface->surface_desc.ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE) - hr = ddraw_surface_update_frontbuffer(surface, NULL, FALSE); + if (SUCCEEDED(hr = wined3d_surface_flip(dst_impl->wined3d_surface, src_impl->wined3d_surface, flags)) + && (dst_impl->surface_desc.ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE)) + hr = ddraw_surface_update_frontbuffer(dst_impl, NULL, FALSE); wined3d_mutex_unlock(); diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c index c8d60fe..46e1239 100644 --- a/dlls/ddraw/tests/ddraw1.c +++ b/dlls/ddraw/tests/ddraw1.c @@ -3618,7 +3618,7 @@ static void test_flip(void) hr = IDirectDraw_CreateSurface(ddraw, &surface_desc, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); hr = IDirectDrawSurface_Flip(primary, surface, DDFLIP_WAIT); - todo_wine ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); IDirectDrawSurface_Release(surface); hr = IDirectDrawSurface_Flip(primary, primary, DDFLIP_WAIT); diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 34559cc..80c86ff 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -4299,7 +4299,7 @@ static void test_flip(void) hr = IDirectDraw2_CreateSurface(ddraw, &surface_desc, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); hr = IDirectDrawSurface_Flip(primary, surface, DDFLIP_WAIT); - todo_wine ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); IDirectDrawSurface_Release(surface); hr = IDirectDrawSurface_Flip(primary, primary, DDFLIP_WAIT); diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index 865dc0f..489dfe7 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -4903,7 +4903,7 @@ static void test_flip(void) hr = IDirectDraw4_CreateSurface(ddraw, &surface_desc, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); hr = IDirectDrawSurface4_Flip(primary, surface, DDFLIP_WAIT); - todo_wine ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); IDirectDrawSurface4_Release(surface); hr = IDirectDrawSurface4_Flip(primary, primary, DDFLIP_WAIT); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 050d303..8818828 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -4790,7 +4790,7 @@ static void test_flip(void) hr = IDirectDraw7_CreateSurface(ddraw, &surface_desc, &surface, NULL); ok(SUCCEEDED(hr), "Failed to create surface, hr %#x.\n", hr); hr = IDirectDrawSurface7_Flip(primary, surface, DDFLIP_WAIT); - todo_wine ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); IDirectDrawSurface7_Release(surface); hr = IDirectDrawSurface7_Flip(primary, primary, DDFLIP_WAIT);

1 0

Henri Verbeet : ddraw: Attach the first surface in the swap chain to the last one.
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: 74e3f516bc331205474835811d3984b9c53b0f35 URL: http://source.winehq.org/git/wine.git/?a=commit;h=74e3f516bc331205474835811… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 4 09:49:34 2013 +0100 ddraw: Attach the first surface in the swap chain to the last one. --- dlls/ddraw/surface.c | 19 ++++++++++++------- dlls/ddraw/tests/ddraw1.c | 7 +++---- dlls/ddraw/tests/ddraw2.c | 7 +++---- dlls/ddraw/tests/ddraw4.c | 7 +++---- dlls/ddraw/tests/ddraw7.c | 7 +++---- 5 files changed, 24 insertions(+), 23 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 8d35d1e..477ef4f 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -469,7 +469,8 @@ static void ddraw_surface_cleanup(struct ddraw_surface *surface) surf = surface->complex_array[i]; surface->complex_array[i] = NULL; - ddraw_surface_cleanup(surf); + if (!surf->is_complex_root) + ddraw_surface_cleanup(surf); } if (surface->device1) @@ -4724,19 +4725,22 @@ static HRESULT WINAPI ddraw_surface7_SetPalette(IDirectDrawSurface7 *iface, IDir DDSCAPS2 caps2 = { DDSCAPS_FLIP, 0, 0, 0 }; surf = This; - while(1) + for (;;) { IDirectDrawSurface7 *attach; - HRESULT hr; - hr = ddraw_surface7_GetAttachedSurface(&surf->IDirectDrawSurface7_iface, &caps2, &attach); - if(hr != DD_OK) + + if (FAILED(hr = ddraw_surface7_GetAttachedSurface(&surf->IDirectDrawSurface7_iface, &caps2, &attach))) + break; + + surf = impl_from_IDirectDrawSurface7(attach); + if (surf == This) { + ddraw_surface7_Release(attach); break; } - TRACE("Setting palette on %p\n", attach); + TRACE("Setting palette on %p.\n", attach); ddraw_surface7_SetPalette(attach, Pal); - surf = impl_from_IDirectDrawSurface7(attach); ddraw_surface7_Release(attach); } } @@ -6002,6 +6006,7 @@ HRESULT ddraw_surface_create(struct ddraw *ddraw, const DDSURFACEDESC2 *surface_ *attach = last; attach = &last->complex_array[0]; } + *attach = root; } if (surface_desc->ddsCaps.dwCaps & DDSCAPS_PRIMARYSURFACE) diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c index 64f8f37..c8d60fe 100644 --- a/dlls/ddraw/tests/ddraw1.c +++ b/dlls/ddraw/tests/ddraw1.c @@ -3605,10 +3605,9 @@ static void test_flip(void) "Got unexpected caps %#x.\n", surface_desc.ddsCaps.dwCaps); hr = IDirectDrawSurface_GetAttachedSurface(backbuffer3, &caps, &surface); - todo_wine ok(SUCCEEDED(hr), "Failed to get attached surface, hr %#x.\n", hr); - todo_wine ok(surface == primary, "Got unexpected surface %p, expected %p.\n", surface, primary); - if (surface) - IDirectDrawSurface_Release(surface); + ok(SUCCEEDED(hr), "Failed to get attached surface, hr %#x.\n", hr); + ok(surface == primary, "Got unexpected surface %p, expected %p.\n", surface, primary); + IDirectDrawSurface_Release(surface); memset(&surface_desc, 0, sizeof(surface_desc)); surface_desc.dwSize = sizeof(surface_desc); diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 77a1419..34559cc 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -4286,10 +4286,9 @@ static void test_flip(void) "Got unexpected caps %#x.\n", surface_desc.ddsCaps.dwCaps); hr = IDirectDrawSurface_GetAttachedSurface(backbuffer3, &caps, &surface); - todo_wine ok(SUCCEEDED(hr), "Failed to get attached surface, hr %#x.\n", hr); - todo_wine ok(surface == primary, "Got unexpected surface %p, expected %p.\n", surface, primary); - if (surface) - IDirectDrawSurface_Release(surface); + ok(SUCCEEDED(hr), "Failed to get attached surface, hr %#x.\n", hr); + ok(surface == primary, "Got unexpected surface %p, expected %p.\n", surface, primary); + IDirectDrawSurface_Release(surface); memset(&surface_desc, 0, sizeof(surface_desc)); surface_desc.dwSize = sizeof(surface_desc); diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index 994bfb3..865dc0f 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -4890,10 +4890,9 @@ static void test_flip(void) "Got unexpected caps %#x.\n", surface_desc.ddsCaps.dwCaps); hr = IDirectDrawSurface4_GetAttachedSurface(backbuffer3, &caps, &surface); - todo_wine ok(SUCCEEDED(hr), "Failed to get attached surface, hr %#x.\n", hr); - todo_wine ok(surface == primary, "Got unexpected surface %p, expected %p.\n", surface, primary); - if (surface) - IDirectDrawSurface4_Release(surface); + ok(SUCCEEDED(hr), "Failed to get attached surface, hr %#x.\n", hr); + ok(surface == primary, "Got unexpected surface %p, expected %p.\n", surface, primary); + IDirectDrawSurface4_Release(surface); memset(&surface_desc, 0, sizeof(surface_desc)); surface_desc.dwSize = sizeof(surface_desc); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index 2ea98cb..050d303 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -4777,10 +4777,9 @@ static void test_flip(void) "Got unexpected caps %#x.\n", surface_desc.ddsCaps.dwCaps); hr = IDirectDrawSurface7_GetAttachedSurface(backbuffer3, &caps, &surface); - todo_wine ok(SUCCEEDED(hr), "Failed to get attached surface, hr %#x.\n", hr); - todo_wine ok(surface == primary, "Got unexpected surface %p, expected %p.\n", surface, primary); - if (surface) - IDirectDrawSurface7_Release(surface); + ok(SUCCEEDED(hr), "Failed to get attached surface, hr %#x.\n", hr); + ok(surface == primary, "Got unexpected surface %p, expected %p.\n", surface, primary); + IDirectDrawSurface7_Release(surface); memset(&surface_desc, 0, sizeof(surface_desc)); surface_desc.dwSize = sizeof(surface_desc);

1 0

Henri Verbeet : ddraw: Reject flips of surfaces with themselves.
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: ab8d59c29ddb3f38379b8eab59913c785dc80845 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ab8d59c29ddb3f38379b8eab5… Author: Henri Verbeet <hverbeet(a)codeweavers.com> Date: Wed Dec 4 09:49:33 2013 +0100 ddraw: Reject flips of surfaces with themselves. --- dlls/ddraw/surface.c | 2 +- dlls/ddraw/tests/ddraw1.c | 2 +- dlls/ddraw/tests/ddraw2.c | 2 +- dlls/ddraw/tests/ddraw4.c | 2 +- dlls/ddraw/tests/ddraw7.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/ddraw/surface.c b/dlls/ddraw/surface.c index 0704744..8d35d1e 100644 --- a/dlls/ddraw/surface.c +++ b/dlls/ddraw/surface.c @@ -1197,7 +1197,7 @@ static HRESULT WINAPI ddraw_surface7_Flip(IDirectDrawSurface7 *iface, IDirectDra TRACE("iface %p, dst %p, flags %#x.\n", iface, DestOverride, Flags); - if (!(surface->surface_desc.ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER | DDSCAPS_OVERLAY))) + if (DestOverride == iface || !(surface->surface_desc.ddsCaps.dwCaps & (DDSCAPS_FRONTBUFFER | DDSCAPS_OVERLAY))) return DDERR_NOTFLIPPABLE; wined3d_mutex_lock(); diff --git a/dlls/ddraw/tests/ddraw1.c b/dlls/ddraw/tests/ddraw1.c index 2d62ec6..64f8f37 100644 --- a/dlls/ddraw/tests/ddraw1.c +++ b/dlls/ddraw/tests/ddraw1.c @@ -3623,7 +3623,7 @@ static void test_flip(void) IDirectDrawSurface_Release(surface); hr = IDirectDrawSurface_Flip(primary, primary, DDFLIP_WAIT); - todo_wine ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawSurface_Flip(backbuffer1, NULL, DDFLIP_WAIT); ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawSurface_Flip(backbuffer2, NULL, DDFLIP_WAIT); diff --git a/dlls/ddraw/tests/ddraw2.c b/dlls/ddraw/tests/ddraw2.c index 417e0be..77a1419 100644 --- a/dlls/ddraw/tests/ddraw2.c +++ b/dlls/ddraw/tests/ddraw2.c @@ -4304,7 +4304,7 @@ static void test_flip(void) IDirectDrawSurface_Release(surface); hr = IDirectDrawSurface_Flip(primary, primary, DDFLIP_WAIT); - todo_wine ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawSurface_Flip(backbuffer1, NULL, DDFLIP_WAIT); ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawSurface_Flip(backbuffer2, NULL, DDFLIP_WAIT); diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c index b1b01bb..994bfb3 100644 --- a/dlls/ddraw/tests/ddraw4.c +++ b/dlls/ddraw/tests/ddraw4.c @@ -4908,7 +4908,7 @@ static void test_flip(void) IDirectDrawSurface4_Release(surface); hr = IDirectDrawSurface4_Flip(primary, primary, DDFLIP_WAIT); - todo_wine ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawSurface4_Flip(backbuffer1, NULL, DDFLIP_WAIT); ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawSurface4_Flip(backbuffer2, NULL, DDFLIP_WAIT); diff --git a/dlls/ddraw/tests/ddraw7.c b/dlls/ddraw/tests/ddraw7.c index fe1d35f..2ea98cb 100644 --- a/dlls/ddraw/tests/ddraw7.c +++ b/dlls/ddraw/tests/ddraw7.c @@ -4795,7 +4795,7 @@ static void test_flip(void) IDirectDrawSurface7_Release(surface); hr = IDirectDrawSurface7_Flip(primary, primary, DDFLIP_WAIT); - todo_wine ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); + ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawSurface7_Flip(backbuffer1, NULL, DDFLIP_WAIT); ok(hr == DDERR_NOTFLIPPABLE, "Got unexpected hr %#x.\n", hr); hr = IDirectDrawSurface7_Flip(backbuffer2, NULL, DDFLIP_WAIT);

1 0

Nikolay Sivov : ole32: Trace library path to be added to list.
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: 3b6d06e33cfc93cb2f6ae79b1bce016fa63816f2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3b6d06e33cfc93cb2f6ae79b1… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Dec 4 11:14:41 2013 +0400 ole32: Trace library path to be added to list. --- dlls/ole32/compobj.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c index d3f4804..3c0c085 100644 --- a/dlls/ole32/compobj.c +++ b/dlls/ole32/compobj.c @@ -485,7 +485,7 @@ static HRESULT COMPOBJ_DllList_Add(LPCWSTR library_name, OpenDll **ret) DllCanUnloadNowFunc DllCanUnloadNow; DllGetClassObjectFunc DllGetClassObject; - TRACE("\n"); + TRACE("%s\n", debugstr_w(library_name)); *ret = COMPOBJ_DllList_Get(library_name); if (*ret) return S_OK;

1 0

Nikolay Sivov : qmgr: Rearrange BSC methods in a natural way, call with proper wrapper.
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: 5edaed3ee3837e9b267039d54c65385edd8fb273 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5edaed3ee3837e9b267039d54… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Dec 4 09:58:56 2013 +0400 qmgr: Rearrange BSC methods in a natural way, call with proper wrapper. --- dlls/qmgr/file.c | 38 +++++++++++++++++++------------------- 1 files changed, 19 insertions(+), 19 deletions(-) diff --git a/dlls/qmgr/file.c b/dlls/qmgr/file.c index eeb2725..6d3cca9 100644 --- a/dlls/qmgr/file.c +++ b/dlls/qmgr/file.c @@ -223,6 +223,25 @@ static inline DLBindStatusCallback *impl_from_IBindStatusCallback(IBindStatusCal return CONTAINING_RECORD(iface, DLBindStatusCallback, IBindStatusCallback_iface); } +static HRESULT WINAPI DLBindStatusCallback_QueryInterface( + IBindStatusCallback *iface, + REFIID riid, + void **ppvObject) +{ + DLBindStatusCallback *This = impl_from_IBindStatusCallback(iface); + + if (IsEqualGUID(riid, &IID_IUnknown) + || IsEqualGUID(riid, &IID_IBindStatusCallback)) + { + *ppvObject = &This->IBindStatusCallback_iface; + IBindStatusCallback_AddRef(iface); + return S_OK; + } + + *ppvObject = NULL; + return E_NOINTERFACE; +} + static ULONG WINAPI DLBindStatusCallback_AddRef(IBindStatusCallback *iface) { DLBindStatusCallback *This = impl_from_IBindStatusCallback(iface); @@ -243,25 +262,6 @@ static ULONG WINAPI DLBindStatusCallback_Release(IBindStatusCallback *iface) return ref; } -static HRESULT WINAPI DLBindStatusCallback_QueryInterface( - IBindStatusCallback *iface, - REFIID riid, - void **ppvObject) -{ - DLBindStatusCallback *This = impl_from_IBindStatusCallback(iface); - - if (IsEqualGUID(riid, &IID_IUnknown) - || IsEqualGUID(riid, &IID_IBindStatusCallback)) - { - *ppvObject = &This->IBindStatusCallback_iface; - DLBindStatusCallback_AddRef(iface); - return S_OK; - } - - *ppvObject = NULL; - return E_NOINTERFACE; -} - static HRESULT WINAPI DLBindStatusCallback_GetBindInfo( IBindStatusCallback *iface, DWORD *grfBINDF,

1 0

Nikolay Sivov : qmgr: Add file to a job with 1 refcount.
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: f4a2163de7650cb372113de20c3bca0008db3a76 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f4a2163de7650cb372113de20… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Dec 3 23:32:15 2013 +0400 qmgr: Add file to a job with 1 refcount. --- dlls/qmgr/job.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c index 419ec09..f99d837 100644 --- a/dlls/qmgr/job.c +++ b/dlls/qmgr/job.c @@ -113,7 +113,6 @@ static HRESULT WINAPI BackgroundCopyJob_AddFileSet( if (hr != S_OK) break; /* Add a reference to the file to file list */ - IBackgroundCopyFile_AddRef(&file->IBackgroundCopyFile_iface); list_add_head(&This->files, &file->entryFromJob); This->jobProgress.BytesTotal = BG_SIZE_UNKNOWN; ++This->jobProgress.FilesTotal;

1 0

Nikolay Sivov : qmgr: Implement AddFile() with AddFileSet().
by Alexandre Julliard 04 Dec '13

04 Dec '13

Module: wine Branch: master Commit: 5cbd28aa5128a1b35e21a94825b0659542b186f6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=5cbd28aa5128a1b35e21a9482… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Dec 3 23:30:32 2013 +0400 qmgr: Implement AddFile() with AddFileSet(). --- dlls/qmgr/job.c | 46 ++++++++++++++++++++++++---------------------- 1 files changed, 24 insertions(+), 22 deletions(-) diff --git a/dlls/qmgr/job.c b/dlls/qmgr/job.c index fdbf234..419ec09 100644 --- a/dlls/qmgr/job.c +++ b/dlls/qmgr/job.c @@ -95,18 +95,33 @@ static HRESULT WINAPI BackgroundCopyJob_AddFileSet( BG_FILE_INFO *pFileSet) { BackgroundCopyJobImpl *This = impl_from_IBackgroundCopyJob2(iface); + HRESULT hr = S_OK; ULONG i; TRACE("(%p)->(%d %p)\n", This, cFileCount, pFileSet); + EnterCriticalSection(&This->cs); + for (i = 0; i < cFileCount; ++i) { - HRESULT hr = IBackgroundCopyJob2_AddFile(iface, pFileSet[i].RemoteName, - pFileSet[i].LocalName); - if (FAILED(hr)) - return hr; + BackgroundCopyFileImpl *file; + + /* We should return E_INVALIDARG in these cases. */ + FIXME("Check for valid filenames and supported protocols\n"); + + hr = BackgroundCopyFileConstructor(This, pFileSet[i].RemoteName, pFileSet[i].LocalName, &file); + if (hr != S_OK) break; + + /* Add a reference to the file to file list */ + IBackgroundCopyFile_AddRef(&file->IBackgroundCopyFile_iface); + list_add_head(&This->files, &file->entryFromJob); + This->jobProgress.BytesTotal = BG_SIZE_UNKNOWN; + ++This->jobProgress.FilesTotal; } - return S_OK; + + LeaveCriticalSection(&This->cs); + + return hr; } static HRESULT WINAPI BackgroundCopyJob_AddFile( @@ -115,26 +130,13 @@ static HRESULT WINAPI BackgroundCopyJob_AddFile( LPCWSTR LocalName) { BackgroundCopyJobImpl *This = impl_from_IBackgroundCopyJob2(iface); - BackgroundCopyFileImpl *file; - HRESULT res; + BG_FILE_INFO file; TRACE("(%p)->(%s %s)\n", This, debugstr_w(RemoteUrl), debugstr_w(LocalName)); - /* We should return E_INVALIDARG in these cases. */ - FIXME("Check for valid filenames and supported protocols\n"); - - res = BackgroundCopyFileConstructor(This, RemoteUrl, LocalName, &file); - if (res != S_OK) - return res; - /* Add a reference to the file to file list */ - IBackgroundCopyFile_AddRef(&file->IBackgroundCopyFile_iface); - EnterCriticalSection(&This->cs); - list_add_head(&This->files, &file->entryFromJob); - This->jobProgress.BytesTotal = BG_SIZE_UNKNOWN; - ++This->jobProgress.FilesTotal; - LeaveCriticalSection(&This->cs); - - return S_OK; + file.RemoteName = (LPWSTR)RemoteUrl; + file.LocalName = (LPWSTR)LocalName; + return IBackgroundCopyJob2_AddFileSet(iface, 1, &file); } static HRESULT WINAPI BackgroundCopyJob_EnumFiles(

1 0

← Newer
1
...
37
38
39
40
41
42
43
...
47
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits December 2013