winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
April 2013
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
579 discussions
Start a n
N
ew thread
Alexandre Julliard : odbc32: Don' t unload external libraries on process shutdown.
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: 21bfa0812eb45fe1ca048ace0e63d5b7071bf2f8 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=21bfa0812eb45fe1ca048ace0…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Apr 30 17:25:29 2013 +0200 odbc32: Don't unload external libraries on process shutdown. --- dlls/odbc32/proxyodbc.c | 32 +++++++++----------------------- 1 files changed, 9 insertions(+), 23 deletions(-) diff --git a/dlls/odbc32/proxyodbc.c b/dlls/odbc32/proxyodbc.c index c7a5038..85b3dfe 100644 --- a/dlls/odbc32/proxyodbc.c +++ b/dlls/odbc32/proxyodbc.c @@ -465,39 +465,25 @@ static void ODBC_ReplicateToRegistry (void) /*********************************************************************** * DllMain [Internal] Initializes the internal 'ODBC32.DLL'. - * - * PARAMS - * hinstDLL [I] handle to the DLL's instance - * fdwReason [I] - * lpvReserved [I] reserved, must be NULL - * - * RETURNS - * Success: TRUE - * Failure: FALSE */ - -BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) +BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD reason, LPVOID reserved) { - TRACE("Initializing or Finalizing proxy ODBC: %p,%x,%p\n", hinstDLL, fdwReason, lpvReserved); + TRACE("proxy ODBC: %p,%x,%p\n", hinstDLL, reason, reserved); - if (fdwReason == DLL_PROCESS_ATTACH) + switch (reason) { - TRACE("Loading ODBC...\n"); + case DLL_PROCESS_ATTACH: DisableThreadLibraryCalls(hinstDLL); if (ODBC_LoadDriverManager()) { ODBC_LoadDMFunctions(); ODBC_ReplicateToRegistry(); } - } - else if (fdwReason == DLL_PROCESS_DETACH) - { - TRACE("Unloading ODBC...\n"); - if (dmHandle) - { - wine_dlclose(dmHandle,NULL,0); - dmHandle = NULL; - } + break; + + case DLL_PROCESS_DETACH: + if (reserved) break; + if (dmHandle) wine_dlclose(dmHandle,NULL,0); } return TRUE;
1
0
0
0
Alexandre Julliard : msxml3: Don' t unload external libraries on process shutdown.
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: 2710f05cef19a4bb07c63b9c03eb765cf81c6e06 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2710f05cef19a4bb07c63b9c0…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Apr 30 17:25:29 2013 +0200 msxml3: Don't unload external libraries on process shutdown. --- dlls/msxml3/main.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msxml3/main.c b/dlls/msxml3/main.c index da3969e..46742ef 100644 --- a/dlls/msxml3/main.c +++ b/dlls/msxml3/main.c @@ -209,7 +209,7 @@ static void init_libxslt(void) #endif } -BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) +BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID reserved) { MSXML_hInstance = hInstDLL; @@ -235,12 +235,12 @@ BOOL WINAPI DllMain(HINSTANCE hInstDLL, DWORD fdwReason, LPVOID lpv) DisableThreadLibraryCalls(hInstDLL); break; case DLL_PROCESS_DETACH: + if (reserved) break; #ifdef SONAME_LIBXSLT if (libxslt_handle) { pxsltCleanupGlobals(); wine_dlclose(libxslt_handle, NULL, 0); - libxslt_handle = NULL; } #endif #ifdef HAVE_LIBXML2
1
0
0
0
Alexandre Julliard : ctapi32: Don' t unload external libraries on process shutdown.
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: 6eca89efa7c0aa673a488833c3d20cfc260cfce4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6eca89efa7c0aa673a488833c…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Apr 30 17:25:29 2013 +0200 ctapi32: Don't unload external libraries on process shutdown. --- dlls/ctapi32/ctapi32.c | 17 ++--------------- 1 files changed, 2 insertions(+), 15 deletions(-) diff --git a/dlls/ctapi32/ctapi32.c b/dlls/ctapi32/ctapi32.c index 7889e2a..089e0ab 100644 --- a/dlls/ctapi32/ctapi32.c +++ b/dlls/ctapi32/ctapi32.c @@ -92,16 +92,6 @@ LOAD_FUNCPTR(CT_close); return 0; } -static void unload_functions(void) -{ - pCT_close = NULL; - pCT_data = NULL; - pCT_init = NULL; - if (ctapi_handle) - wine_dlclose(ctapi_handle, NULL, 0); -} - - /* * ct-API specific functions */ @@ -137,18 +127,15 @@ BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) switch (fdwReason) { case DLL_PROCESS_ATTACH: - { DisableThreadLibraryCalls(hinstDLL); /* Try to load low-level library */ if (load_functions() != 0) return FALSE; /* error */ break; - } case DLL_PROCESS_DETACH: - { - unload_functions(); + if (lpvReserved) break; + if (ctapi_handle) wine_dlclose(ctapi_handle, NULL, 0); break; - } } return TRUE;
1
0
0
0
Alexandre Julliard : server: When changing a process desktop, start the close timeout on the old desktop if necessary.
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: be417d68909aa3bdbfcb0439b4940dc9c11a6e21 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=be417d68909aa3bdbfcb0439b…
Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Apr 30 13:55:54 2013 +0200 server: When changing a process desktop, start the close timeout on the old desktop if necessary. --- server/winstation.c | 63 ++++++++++++++++++++++++++++++-------------------- 1 files changed, 38 insertions(+), 25 deletions(-) diff --git a/server/winstation.c b/server/winstation.c index e0b7613..57e6995 100644 --- a/server/winstation.c +++ b/server/winstation.c @@ -300,6 +300,40 @@ struct desktop *get_thread_desktop( struct thread *thread, unsigned int access ) return get_desktop_obj( thread->process, thread->desktop, access ); } +static void close_desktop_timeout( void *private ) +{ + struct desktop *desktop = private; + + desktop->close_timeout = NULL; + unlink_named_object( &desktop->obj ); /* make sure no other process can open it */ + post_desktop_message( desktop, WM_CLOSE, 0, 0 ); /* and signal the owner to quit */ +} + +/* add a user of the desktop and cancel the close timeout */ +static void add_desktop_user( struct desktop *desktop ) +{ + desktop->users++; + if (desktop->close_timeout) + { + remove_timeout_user( desktop->close_timeout ); + desktop->close_timeout = NULL; + } +} + +/* remove a user of the desktop and start the close timeout if necessary */ +static void remove_desktop_user( struct desktop *desktop ) +{ + assert( desktop->users > 0 ); + desktop->users--; + + /* if we have one remaining user, it has to be the manager of the desktop window */ + if (desktop->users == 1 && get_top_window_owner( desktop )) + { + assert( !desktop->close_timeout ); + desktop->close_timeout = add_timeout_user( -TICKS_PER_SEC, close_desktop_timeout, desktop ); + } +} + /* set the process default desktop handle */ void set_process_default_desktop( struct process *process, struct desktop *desktop, obj_handle_t handle ) @@ -316,15 +350,10 @@ void set_process_default_desktop( struct process *process, struct desktop *deskt LIST_FOR_EACH_ENTRY( thread, &process->thread_list, struct thread, proc_entry ) if (!thread->desktop) thread->desktop = handle; - if (!process->is_system) + if (!process->is_system && desktop != old_desktop) { - desktop->users++; - if (desktop->close_timeout) - { - remove_timeout_user( desktop->close_timeout ); - desktop->close_timeout = NULL; - } - if (old_desktop) old_desktop->users--; + add_desktop_user( desktop ); + if (old_desktop) remove_desktop_user( old_desktop ); } if (old_desktop) release_object( old_desktop ); @@ -372,15 +401,6 @@ done: clear_error(); } -static void close_desktop_timeout( void *private ) -{ - struct desktop *desktop = private; - - desktop->close_timeout = NULL; - unlink_named_object( &desktop->obj ); /* make sure no other process can open it */ - post_desktop_message( desktop, WM_CLOSE, 0, 0 ); /* and signal the owner to quit */ -} - /* close the desktop of a given process */ void close_process_desktop( struct process *process ) { @@ -388,14 +408,7 @@ void close_process_desktop( struct process *process ) if (process->desktop && (desktop = get_desktop_obj( process, process->desktop, 0 ))) { - assert( desktop->users > 0 ); - desktop->users--; - /* if we have one remaining user, it has to be the manager of the desktop window */ - if (desktop->users == 1 && get_top_window_owner( desktop )) - { - assert( !desktop->close_timeout ); - desktop->close_timeout = add_timeout_user( -TICKS_PER_SEC, close_desktop_timeout, desktop ); - } + remove_desktop_user( desktop ); release_object( desktop ); } clear_error(); /* ignore errors */
1
0
0
0
Sam Edwards : gdi32: Prevent another possible buffer overflow in get_glyph_outline.
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: 53ec9b3291be1d7a5531aa2a04dbcf6b1fa83b9c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=53ec9b3291be1d7a5531aa2a0…
Author: Sam Edwards <CFSworks(a)gmail.com> Date: Tue Apr 30 00:41:47 2013 -0600 gdi32: Prevent another possible buffer overflow in get_glyph_outline. --- dlls/gdi32/freetype.c | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c index fec752a..5b3c138 100644 --- a/dlls/gdi32/freetype.c +++ b/dlls/gdi32/freetype.c @@ -6362,9 +6362,10 @@ static DWORD get_glyph_outline(GdiFont *incoming_font, UINT glyph, UINT format, y_shift = height - (src_height / vmul); dst += x_shift + y_shift * ( pitch / 4 ); - while ( src_height ) + height = min( height, src_height / vmul ); + while ( height-- ) { - for ( x = 0; x < src_width / hmul; x++ ) + for ( x = 0; x < width && x < src_width / hmul; x++ ) { if ( rgb ) {
1
0
0
0
Christian Costa : d3dxof: Get rid of go_to_next_definition.
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: a180e5ed00a298f971d6a015ac476629010b1d68 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a180e5ed00a298f971d6a015a…
Author: Christian Costa <titan.costa(a)gmail.com> Date: Mon Apr 29 21:43:03 2013 +0200 d3dxof: Get rid of go_to_next_definition. --- dlls/d3dxof/parsing.c | 40 ++-------------------------------------- 1 files changed, 2 insertions(+), 38 deletions(-) diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c index b1dde86..37cf2e1 100644 --- a/dlls/d3dxof/parsing.c +++ b/dlls/d3dxof/parsing.c @@ -1065,39 +1065,6 @@ static BOOL parse_template_parts(parse_buffer * buf) return TRUE; } -static void go_to_next_definition(parse_buffer * buf) -{ - char c; - while (buf->rem_bytes) - { - if (!read_bytes(buf, &c, 1)) - return; - if ((c == '#') || (c == '/')) - { - /* Handle comment (# or //) */ - if (c == '/') - { - if (!read_bytes(buf, &c, 1)) - return; - if (c != '/') - return; - } - c = 0; - while (c != 0x0A) - { - if (!read_bytes(buf, &c, 1)) - return; - } - continue; - } - else if (!is_space(c)) - { - rewind_bytes(buf, 1); - break; - } - } -} - static BOOL parse_template(parse_buffer * buf) { if (get_TOKEN(buf) != TOKEN_TEMPLATE) @@ -1466,11 +1433,8 @@ BOOL parse_object(parse_buffer * buf) if (get_TOKEN(buf) != TOKEN_CBRACE) return FALSE; - if (buf->txt) - { - /* Go to the next object */ - go_to_next_definition(buf); - } + /* For seeking to a possibly eof to avoid parsing another object next time */ + check_TOKEN(buf); return TRUE; }
1
0
0
0
Christian Costa : d3dxof: Only parse templates for object files, but with RegisterTemplates parse the whole file.
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: 1bd5bfebaeb3cf7dd901203c6b554a20723fff0b URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1bd5bfebaeb3cf7dd901203c6…
Author: Christian Costa <titan.costa(a)gmail.com> Date: Mon Apr 29 21:42:55 2013 +0200 d3dxof: Only parse templates for object files, but with RegisterTemplates parse the whole file. --- dlls/d3dx9_36/tests/xfile.c | 2 +- dlls/d3dxof/d3dxof.c | 7 ++++--- dlls/d3dxof/d3dxof_private.h | 2 +- dlls/d3dxof/parsing.c | 6 ++++-- dlls/d3dxof/tests/d3dxof.c | 2 +- 5 files changed, 11 insertions(+), 8 deletions(-) diff --git a/dlls/d3dx9_36/tests/xfile.c b/dlls/d3dx9_36/tests/xfile.c index 1238bcd..e514a5f 100644 --- a/dlls/d3dx9_36/tests/xfile.c +++ b/dlls/d3dx9_36/tests/xfile.c @@ -77,7 +77,7 @@ static void test_templates(void) ok(ret == D3DXFERR_BADFILEFLOATSIZE, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_BADFILEFLOATSIZE); ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, templates_parse_error, sizeof(templates_parse_error) - 1); - todo_wine ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_PARSEERROR); + ok(ret == D3DXFERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, D3DXFERR_PARSEERROR); ret = d3dxfile->lpVtbl->RegisterTemplates(d3dxfile, templates, sizeof(templates) - 1); ok(ret == S_OK, "RegisterTemplates failed with %#x\n", ret); diff --git a/dlls/d3dxof/d3dxof.c b/dlls/d3dxof/d3dxof.c index 5a08b21..498b192 100644 --- a/dlls/d3dxof/d3dxof.c +++ b/dlls/d3dxof/d3dxof.c @@ -241,7 +241,8 @@ static HRESULT WINAPI IDirectXFileImpl_CreateEnumObject(IDirectXFile* iface, LPV if (FAILED(hr)) goto error; - if (!parse_templates(&object->buf)) + /* Check if there are templates defined before the object */ + if (!parse_templates(&object->buf, TRUE)) { hr = DXFILEERR_PARSEERROR; goto error; @@ -320,7 +321,7 @@ static HRESULT WINAPI IDirectXFileImpl_RegisterTemplates(IDirectXFile* iface, LP if (FAILED(hr)) goto cleanup; - if (!parse_templates(&buf)) + if (!parse_templates(&buf, FALSE)) { hr = DXFILEERR_PARSEERROR; goto cleanup; @@ -1003,7 +1004,7 @@ static HRESULT WINAPI IDirectXFileEnumObjectImpl_GetNextDataObject(IDirectXFileE } /* Check if there are templates defined before the object */ - if (!parse_templates(&This->buf)) + if (!parse_templates(&This->buf, TRUE)) return DXFILEERR_PARSEERROR; if (!This->buf.rem_bytes) diff --git a/dlls/d3dxof/d3dxof_private.h b/dlls/d3dxof/d3dxof_private.h index 8872c14..5bd3c71 100644 --- a/dlls/d3dxof/d3dxof_private.h +++ b/dlls/d3dxof/d3dxof_private.h @@ -161,7 +161,7 @@ HRESULT IDirectXFileImpl_Create(IUnknown *pUnkOuter, LPVOID *ppObj) DECLSPEC_HID HRESULT parse_header(parse_buffer *buf, BYTE **decomp_buffer_ptr) DECLSPEC_HIDDEN; BOOL parse_object(parse_buffer * buf) DECLSPEC_HIDDEN; -BOOL parse_templates(parse_buffer * buf) DECLSPEC_HIDDEN; +BOOL parse_templates(parse_buffer * buf, BOOL templates_only) DECLSPEC_HIDDEN; int mszip_decompress(int inlen, int outlen, char* inbuffer, char* outbuffer) DECLSPEC_HIDDEN; diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c index 1c624d3..b1dde86 100644 --- a/dlls/d3dxof/parsing.c +++ b/dlls/d3dxof/parsing.c @@ -1121,10 +1121,12 @@ static BOOL parse_template(parse_buffer * buf) return TRUE; } -BOOL parse_templates(parse_buffer * buf) +BOOL parse_templates(parse_buffer * buf, BOOL templates_only) { - while (check_TOKEN(buf) == TOKEN_TEMPLATE) + while (check_TOKEN(buf) != TOKEN_NONE) { + if (templates_only && (check_TOKEN(buf) != TOKEN_TEMPLATE)) + return TRUE; if (!parse_template(buf)) { WARN("Template is not correct\n"); diff --git a/dlls/d3dxof/tests/d3dxof.c b/dlls/d3dxof/tests/d3dxof.c index 43a7fde..f6874a4 100644 --- a/dlls/d3dxof/tests/d3dxof.c +++ b/dlls/d3dxof/tests/d3dxof.c @@ -427,7 +427,7 @@ static void test_templates(void) ok(ret == DXFILEERR_BADFILEFLOATSIZE, "RegisterTemplates returned %#x, expected %#x\n", ret, DXFILEERR_BADFILEFLOATSIZE); ret = IDirectXFile_RegisterTemplates(dxfile, templates_parse_error, sizeof(templates_parse_error) - 1); - todo_wine ok(ret == DXFILEERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, DXFILEERR_PARSEERROR); + ok(ret == DXFILEERR_PARSEERROR, "RegisterTemplates returned %#x, expected %#x\n", ret, DXFILEERR_PARSEERROR); IDirectXFile_Release(dxfile); }
1
0
0
0
Christian Costa : d3dxof: Avoid dealing with remaining byte until next token or eof, check_TOKEN handles them fine.
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: 37d037749d9c8954a41818d03b9f073336021f23 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=37d037749d9c8954a41818d03…
Author: Christian Costa <titan.costa(a)gmail.com> Date: Mon Apr 29 21:42:46 2013 +0200 d3dxof: Avoid dealing with remaining byte until next token or eof, check_TOKEN handles them fine. --- dlls/d3dxof/parsing.c | 7 +------ 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/dlls/d3dxof/parsing.c b/dlls/d3dxof/parsing.c index 546166a..1c624d3 100644 --- a/dlls/d3dxof/parsing.c +++ b/dlls/d3dxof/parsing.c @@ -1114,11 +1114,6 @@ static BOOL parse_template(parse_buffer * buf) return FALSE; if (get_TOKEN(buf) != TOKEN_CBRACE) return FALSE; - if (buf->txt) - { - /* Go to the next template */ - go_to_next_definition(buf); - } TRACE("%d - %s - %s\n", buf->pdxf->nb_xtemplates, buf->pdxf->xtemplates[buf->pdxf->nb_xtemplates].name, debugstr_guid(&buf->pdxf->xtemplates[buf->pdxf->nb_xtemplates].class_id)); buf->pdxf->nb_xtemplates++; @@ -1128,7 +1123,7 @@ static BOOL parse_template(parse_buffer * buf) BOOL parse_templates(parse_buffer * buf) { - while (buf->rem_bytes && (check_TOKEN(buf) == TOKEN_TEMPLATE)) + while (check_TOKEN(buf) == TOKEN_TEMPLATE) { if (!parse_template(buf)) {
1
0
0
0
Hans Leidekker : winhttp: Add support for NTLM and Negotiate authentication .
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: a506d0aa3bb3ab19f9cea71f279a618761a02978 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=a506d0aa3bb3ab19f9cea71f2…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Apr 30 11:32:59 2013 +0200 winhttp: Add support for NTLM and Negotiate authentication. --- dlls/winhttp/request.c | 424 +++++++++++++++++++++++++++++++++------- dlls/winhttp/session.c | 3 + dlls/winhttp/winhttp_private.h | 28 +++- 3 files changed, 380 insertions(+), 75 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=a506d0aa3bb3ab19f9cea…
1
0
0
0
Hans Leidekker : winhttp: Resend any request data when handling an authentication or redirect response .
by Alexandre Julliard
30 Apr '13
30 Apr '13
Module: wine Branch: master Commit: d63ef4d855654a60ebc8b8660cf161ee837db46e URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d63ef4d855654a60ebc8b8660…
Author: Hans Leidekker <hans(a)codeweavers.com> Date: Tue Apr 30 11:32:31 2013 +0200 winhttp: Resend any request data when handling an authentication or redirect response. --- dlls/winhttp/request.c | 18 +++++++++++++----- dlls/winhttp/winhttp_private.h | 2 ++ 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/dlls/winhttp/request.c b/dlls/winhttp/request.c index bab576e..8d579b3 100644 --- a/dlls/winhttp/request.c +++ b/dlls/winhttp/request.c @@ -1124,9 +1124,13 @@ static BOOL send_request( request_t *request, LPCWSTR headers, DWORD headers_len heap_free( req_ascii ); if (!ret) goto end; - if (optional_len && !netconn_send( &request->netconn, optional, optional_len, 0, &bytes_sent )) goto end; - len += optional_len; - + if (optional_len) + { + if (!netconn_send( &request->netconn, optional, optional_len, 0, &bytes_sent )) goto end; + request->optional = optional; + request->optional_len = optional_len; + len += optional_len; + } send_callback( &request->hdr, WINHTTP_CALLBACK_STATUS_REQUEST_SENT, &len, sizeof(DWORD) ); end: @@ -1951,6 +1955,8 @@ static BOOL handle_redirect( request_t *request, DWORD status ) { heap_free( request->verb ); request->verb = strdupW( getW ); + request->optional = NULL; + request->optional_len = 0; } ret = TRUE; @@ -1987,7 +1993,8 @@ static BOOL receive_response( request_t *request, BOOL async ) if (!(ret = handle_redirect( request, status ))) break; - send_request( request, NULL, 0, NULL, 0, 0, 0, FALSE ); /* recurse synchronously */ + /* recurse synchronously */ + send_request( request, NULL, 0, request->optional, request->optional_len, 0, 0, FALSE ); continue; } else if (status == HTTP_STATUS_DENIED || status == HTTP_STATUS_PROXY_AUTH_REQ) @@ -2000,7 +2007,8 @@ static BOOL receive_response( request_t *request, BOOL async ) ret = TRUE; break; } - send_request( request, NULL, 0, NULL, 0, 0, 0, FALSE ); + /* recurse synchronously */ + send_request( request, NULL, 0, request->optional, request->optional_len, 0, 0, FALSE ); continue; } break; diff --git a/dlls/winhttp/winhttp_private.h b/dlls/winhttp/winhttp_private.h index 82b4582..d47bed3 100644 --- a/dlls/winhttp/winhttp_private.h +++ b/dlls/winhttp/winhttp_private.h @@ -156,6 +156,8 @@ typedef struct LPWSTR path; LPWSTR version; LPWSTR raw_headers; + void *optional; + DWORD optional_len; netconn_t netconn; int resolve_timeout; int connect_timeout;
1
0
0
0
← Newer
1
2
3
4
5
...
58
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
Results per page:
10
25
50
100
200