winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
December 2014
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
319 discussions
Start a n
N
ew thread
Piotr Caban : msvcrt: Use fd critical section in _fstat64.
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: 6c2d4f1092d044a2fc949e7189a30fcd4d96099f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=6c2d4f1092d044a2fc949e718…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Dec 5 14:43:17 2014 +0100 msvcrt: Use fd critical section in _fstat64. --- dlls/msvcrt/file.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 3eae1f1..ff1f5d6 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -1651,25 +1651,29 @@ int CDECL MSVCRT__fileno(MSVCRT_FILE* file) */ int CDECL MSVCRT__fstat64(int fd, struct MSVCRT__stat64* buf) { + ioinfo *info = get_ioinfo(fd); DWORD dw; DWORD type; BY_HANDLE_FILE_INFORMATION hfi; - HANDLE hand = msvcrt_fdtoh(fd); - TRACE(":fd (%d) stat (%p)\n",fd,buf); - if (hand == INVALID_HANDLE_VALUE) + TRACE(":fd (%d) stat (%p)\n", fd, buf); + if (info->handle == INVALID_HANDLE_VALUE) + { + release_ioinfo(info); return -1; + } if (!buf) { WARN(":failed-NULL buf\n"); msvcrt_set_errno(ERROR_INVALID_PARAMETER); + release_ioinfo(info); return -1; } memset(&hfi, 0, sizeof(hfi)); memset(buf, 0, sizeof(struct MSVCRT__stat64)); - type = GetFileType(hand); + type = GetFileType(info->handle); if (type == FILE_TYPE_PIPE) { buf->st_dev = buf->st_rdev = fd; @@ -1684,10 +1688,11 @@ int CDECL MSVCRT__fstat64(int fd, struct MSVCRT__stat64* buf) } else /* FILE_TYPE_DISK etc. */ { - if (!GetFileInformationByHandle(hand, &hfi)) + if (!GetFileInformationByHandle(info->handle, &hfi)) { WARN(":failed-last error (%d)\n",GetLastError()); msvcrt_set_errno(ERROR_INVALID_PARAMETER); + release_ioinfo(info); return -1; } buf->st_mode = S_IFREG | 0444; @@ -1702,6 +1707,7 @@ int CDECL MSVCRT__fstat64(int fd, struct MSVCRT__stat64* buf) } TRACE(":dwFileAttributes = 0x%x, mode set to 0x%x\n",hfi.dwFileAttributes, buf->st_mode); + release_ioinfo(info); return 0; }
1
0
0
0
Piotr Caban : msvcrt: Use fd critical section in _chsize_s.
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: f2f45d5fe67cd8e4129e5ec409fde10fb62b87bd URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f2f45d5fe67cd8e4129e5ec40…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Dec 5 14:43:07 2014 +0100 msvcrt: Use fd critical section in _chsize_s. --- dlls/msvcrt/file.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 174ec64..3eae1f1 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -1377,18 +1377,17 @@ int CDECL MSVCRT__fseek_nolock(MSVCRT_FILE* file, MSVCRT_long offset, int whence */ int CDECL MSVCRT__chsize_s(int fd, __int64 size) { + ioinfo *info; __int64 cur, pos; - HANDLE handle; BOOL ret = FALSE; TRACE("(fd=%d, size=%s)\n", fd, wine_dbgstr_longlong(size)); if (!MSVCRT_CHECK_PMT(size >= 0)) return MSVCRT_EINVAL; - LOCK_FILES(); - handle = msvcrt_fdtoh(fd); - if (handle != INVALID_HANDLE_VALUE) + info = get_ioinfo(fd); + if (info->handle != INVALID_HANDLE_VALUE) { /* save the current file pointer */ cur = MSVCRT__lseeki64(fd, 0, SEEK_CUR); @@ -1397,7 +1396,7 @@ int CDECL MSVCRT__chsize_s(int fd, __int64 size) pos = MSVCRT__lseeki64(fd, size, SEEK_SET); if (pos >= 0) { - ret = SetEndOfFile(handle); + ret = SetEndOfFile(info->handle); if (!ret) msvcrt_set_errno(GetLastError()); } @@ -1406,7 +1405,7 @@ int CDECL MSVCRT__chsize_s(int fd, __int64 size) } } - UNLOCK_FILES(); + release_ioinfo(info); return ret ? 0 : *MSVCRT__errno(); }
1
0
0
0
Piotr Caban : msvcrt: Use fd critical section in _lseeki64.
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: fa6de59770003958d2e6999a4bbaa5a9f1cc0d67 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=fa6de59770003958d2e6999a4…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Dec 5 14:42:50 2014 +0100 msvcrt: Use fd critical section in _lseeki64. --- dlls/msvcrt/file.c | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 8c4a9f4..174ec64 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -1180,15 +1180,20 @@ void msvcrt_free_io(void) */ __int64 CDECL MSVCRT__lseeki64(int fd, __int64 offset, int whence) { - HANDLE hand = msvcrt_fdtoh(fd); + ioinfo *info = get_ioinfo(fd); LARGE_INTEGER ofs; - TRACE(":fd (%d) handle (%p)\n",fd,hand); - if (hand == INVALID_HANDLE_VALUE) + TRACE(":fd (%d) handle (%p)\n", fd, info->handle); + + if (info->handle == INVALID_HANDLE_VALUE) + { + release_ioinfo(info); return -1; + } if (whence < 0 || whence > 2) { + release_ioinfo(info); *MSVCRT__errno() = MSVCRT_EINVAL; return -1; } @@ -1202,14 +1207,16 @@ __int64 CDECL MSVCRT__lseeki64(int fd, __int64 offset, int whence) /* The MoleBox protection scheme expects msvcrt to use SetFilePointer only, * so a LARGE_INTEGER offset cannot be passed directly via SetFilePointerEx. */ ofs.QuadPart = offset; - if ((ofs.u.LowPart = SetFilePointer(hand, ofs.u.LowPart, &ofs.u.HighPart, whence)) != INVALID_SET_FILE_POINTER || + if ((ofs.u.LowPart = SetFilePointer(info->handle, ofs.u.LowPart, &ofs.u.HighPart, whence)) != INVALID_SET_FILE_POINTER || GetLastError() == ERROR_SUCCESS) { - get_ioinfo_nolock(fd)->wxflag &= ~WX_ATEOF; + info->wxflag &= ~WX_ATEOF; /* FIXME: What if we seek _to_ EOF - is EOF set? */ + release_ioinfo(info); return ofs.QuadPart; } + release_ioinfo(info); TRACE(":error-last error (%d)\n",GetLastError()); msvcrt_set_errno(GetLastError()); return -1;
1
0
0
0
Piotr Caban : msvcrt: Use fd critical section in _locking.
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: ffdd16cc0d76be068f6a12ca88371e7d761165b2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ffdd16cc0d76be068f6a12ca8…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Dec 5 14:42:55 2014 +0100 msvcrt: Use fd critical section in _locking. --- dlls/msvcrt/file.c | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 317e19e..8c4a9f4 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -1252,16 +1252,20 @@ void CDECL MSVCRT__unlock_file(MSVCRT_FILE *file) */ int CDECL MSVCRT__locking(int fd, int mode, LONG nbytes) { + ioinfo *info = get_ioinfo(fd); BOOL ret; DWORD cur_locn; - HANDLE hand = msvcrt_fdtoh(fd); - TRACE(":fd (%d) handle (%p)\n",fd,hand); - if (hand == INVALID_HANDLE_VALUE) + TRACE(":fd (%d) handle (%p)\n", fd, info->handle); + if (info->handle == INVALID_HANDLE_VALUE) + { + release_ioinfo(info); return -1; + } if (mode < 0 || mode > 4) { + release_ioinfo(info); *MSVCRT__errno() = MSVCRT_EINVAL; return -1; } @@ -1274,8 +1278,9 @@ int CDECL MSVCRT__locking(int fd, int mode, LONG nbytes) (mode==MSVCRT__LK_NBRLCK)?"_LK_NBRLCK": "UNKNOWN"); - if ((cur_locn = SetFilePointer(hand, 0L, NULL, SEEK_CUR)) == INVALID_SET_FILE_POINTER) + if ((cur_locn = SetFilePointer(info->handle, 0L, NULL, SEEK_CUR)) == INVALID_SET_FILE_POINTER) { + release_ioinfo(info); FIXME ("Seek failed\n"); *MSVCRT__errno() = MSVCRT_EINVAL; /* FIXME */ return -1; @@ -1286,16 +1291,17 @@ int CDECL MSVCRT__locking(int fd, int mode, LONG nbytes) ret = 1; /* just to satisfy gcc */ while (nretry--) { - ret = LockFile(hand, cur_locn, 0L, nbytes, 0L); + ret = LockFile(info->handle, cur_locn, 0L, nbytes, 0L); if (ret) break; Sleep(1); } } else if (mode == MSVCRT__LK_UNLCK) - ret = UnlockFile(hand, cur_locn, 0L, nbytes, 0L); + ret = UnlockFile(info->handle, cur_locn, 0L, nbytes, 0L); else - ret = LockFile(hand, cur_locn, 0L, nbytes, 0L); + ret = LockFile(info->handle, cur_locn, 0L, nbytes, 0L); /* FIXME - what about error settings? */ + release_ioinfo(info); return ret ? 0 : -1; }
1
0
0
0
Piotr Caban : msvcrt: Use fd critical section in _eof.
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: 9a4cfbc3edce79a1cca12b7dbed39fa14a9d65c2 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9a4cfbc3edce79a1cca12b7db…
Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Dec 5 14:42:44 2014 +0100 msvcrt: Use fd critical section in _eof. --- dlls/msvcrt/file.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/dlls/msvcrt/file.c b/dlls/msvcrt/file.c index 5176f58..317e19e 100644 --- a/dlls/msvcrt/file.c +++ b/dlls/msvcrt/file.c @@ -1081,29 +1081,38 @@ int CDECL MSVCRT__dup(int od) */ int CDECL MSVCRT__eof(int fd) { + ioinfo *info = get_ioinfo(fd); DWORD curpos,endpos; LONG hcurpos,hendpos; - HANDLE hand = msvcrt_fdtoh(fd); - TRACE(":fd (%d) handle (%p)\n",fd,hand); + TRACE(":fd (%d) handle (%p)\n", fd, info->handle); - if (hand == INVALID_HANDLE_VALUE) + if (info->handle == INVALID_HANDLE_VALUE) + { + release_ioinfo(info); return -1; + } - if (get_ioinfo_nolock(fd)->wxflag & WX_ATEOF) return TRUE; + if (info->wxflag & WX_ATEOF) + { + release_ioinfo(info); + return TRUE; + } /* Otherwise we do it the hard way */ hcurpos = hendpos = 0; - curpos = SetFilePointer(hand, 0, &hcurpos, FILE_CURRENT); - endpos = SetFilePointer(hand, 0, &hendpos, FILE_END); + curpos = SetFilePointer(info->handle, 0, &hcurpos, FILE_CURRENT); + endpos = SetFilePointer(info->handle, 0, &hendpos, FILE_END); if (curpos == endpos && hcurpos == hendpos) { /* FIXME: shouldn't WX_ATEOF be set here? */ + release_ioinfo(info); return TRUE; } - SetFilePointer(hand, curpos, &hcurpos, FILE_BEGIN); + SetFilePointer(info->handle, curpos, &hcurpos, FILE_BEGIN); + release_ioinfo(info); return FALSE; }
1
0
0
0
Francois Gouget : dwrite: Fix compilation on systems that don' t support nameless unions.
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: d1040304b2b507839a0c6cb7222a875ad8f6f5a7 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=d1040304b2b507839a0c6cb72…
Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Dec 5 12:55:00 2014 +0100 dwrite: Fix compilation on systems that don't support nameless unions. --- dlls/dwrite/font.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c index 135ea4d..df3d2dd 100644 --- a/dlls/dwrite/font.c +++ b/dlls/dwrite/font.c @@ -2120,8 +2120,8 @@ static HRESULT WINAPI localfontfilestream_GetLastWriteTime(IDWriteFontFileStream TRACE("(%p)->(%p)\n", This, last_writetime); - li.LowPart = This->entry->key->writetime.dwLowDateTime; - li.HighPart = This->entry->key->writetime.dwHighDateTime; + li.u.LowPart = This->entry->key->writetime.dwLowDateTime; + li.u.HighPart = This->entry->key->writetime.dwHighDateTime; *last_writetime = li.QuadPart; return S_OK;
1
0
0
0
Francois Gouget : dwrite: Add a trailing '\n' to a FIXME().
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: eaf4f695d16a08b00440d5331d18a7a06a6e299f URL:
http://source.winehq.org/git/wine.git/?a=commit;h=eaf4f695d16a08b00440d5331…
Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Dec 5 12:20:47 2014 +0100 dwrite: Add a trailing '\n' to a FIXME(). --- dlls/dwrite/opentype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dwrite/opentype.c b/dlls/dwrite/opentype.c index a76dd4b..9bd434c 100644 --- a/dlls/dwrite/opentype.c +++ b/dlls/dwrite/opentype.c @@ -1196,7 +1196,7 @@ HRESULT opentype_get_font_strings_from_id(const void *table_data, DWRITE_INFORMA heap_free(name_string); } else { - FIXME("handle NAME format 1"); + FIXME("handle NAME format 1\n"); continue; } }
1
0
0
0
Francois Gouget : msvcr120/tests: Make test_lconv*() static.
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: 1788674bdb92c5d099a8287cbff36f9d7ba2c266 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1788674bdb92c5d099a8287cb…
Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Dec 5 12:20:54 2014 +0100 msvcr120/tests: Make test_lconv*() static. --- dlls/msvcr120/tests/msvcr120.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/msvcr120/tests/msvcr120.c b/dlls/msvcr120/tests/msvcr120.c index bed1002..c0a582f 100644 --- a/dlls/msvcr120/tests/msvcr120.c +++ b/dlls/msvcr120/tests/msvcr120.c @@ -79,7 +79,7 @@ static BOOL init(void) return TRUE; } -void test_lconv_helper(const char *locstr) +static void test_lconv_helper(const char *locstr) { struct MSVCRT_lconv *lconv; char mbs[256]; @@ -133,7 +133,7 @@ void test_lconv_helper(const char *locstr) ok(strcmp(mbs, lconv->negative_sign) == 0, "%s: negative_sign\n", locstr); } -void test_lconv(void) +static void test_lconv(void) { int i; const char *locstrs[] =
1
0
0
0
Francois Gouget : Assorted spelling fixes.
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: ea932fbcc15951a13a12cfca8949597ebd9d6fe9 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ea932fbcc15951a13a12cfca8…
Author: Francois Gouget <fgouget(a)free.fr> Date: Fri Dec 5 12:21:02 2014 +0100 Assorted spelling fixes. --- dlls/dwrite/tests/font.c | 2 +- dlls/kernel32/tests/virtual.c | 4 ++-- dlls/user32/tests/input.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/dlls/dwrite/tests/font.c b/dlls/dwrite/tests/font.c index 2fe845c..49e7154 100644 --- a/dlls/dwrite/tests/font.c +++ b/dlls/dwrite/tests/font.c @@ -1513,7 +1513,7 @@ static void test_CustomFontCollection(void) ok(hr == S_OK, "got 0x%08x\n", hr); EXPECT_REF(idfont2, 1); EXPECT_REF(idfont, 1); - ok(idfont2 != idfont, "Font instances shoudl not match\n"); + ok(idfont2 != idfont, "Font instances should not match\n"); idfontface2 = NULL; hr = IDWriteFont_CreateFontFace(idfont2, &idfontface2); diff --git a/dlls/kernel32/tests/virtual.c b/dlls/kernel32/tests/virtual.c index 0015f98..75e91d5 100644 --- a/dlls/kernel32/tests/virtual.c +++ b/dlls/kernel32/tests/virtual.c @@ -1618,7 +1618,7 @@ static void test_guard_page(void) /* test behaviour of VirtualLock - first attempt should fail */ SetLastError( 0xdeadbeef ); success = VirtualLock( base, size ); - ok( !success, "VirtualLock unexpectedly succeded\n" ); + ok( !success, "VirtualLock unexpectedly succeeded\n" ); todo_wine ok( GetLastError() == STATUS_GUARD_PAGE_VIOLATION, "wrong error %u\n", GetLastError() ); @@ -1770,7 +1770,7 @@ static void test_guard_page(void) /* test behaviour of VirtualLock - first attempt should fail without triggering write watches */ SetLastError( 0xdeadbeef ); success = VirtualLock( base, size ); - ok( !success, "VirtualLock unexpectedly succeded\n" ); + ok( !success, "VirtualLock unexpectedly succeeded\n" ); todo_wine ok( GetLastError() == STATUS_GUARD_PAGE_VIOLATION, "wrong error %u\n", GetLastError() ); diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index 9b898d3..39afeb7 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -1863,8 +1863,8 @@ static void test_Input_mouse(void) ok(!got_button_down, "unexpected WM_RBUTTONDOWN message\n"); ok(!got_button_up, "unexpected WM_RBUTTONUP message\n"); - /* click on HTTRANSPARENT top-level window that belongs to ther thread, - * threads input queues are attached */ + /* click on HTTRANSPARENT top-level window that belongs to other thread, + * thread input queues are attached */ thread = CreateThread(NULL, 0, create_static_win, &thread_data, 0, &thread_id); ok(thread != NULL, "CreateThread failed\n"); hittest_no = 0;
1
0
0
0
Nikolay Sivov : shell32: Added a stub for SHAssocEnumHandlers().
by Alexandre Julliard
05 Dec '14
05 Dec '14
Module: wine Branch: master Commit: 717385b0ba2cc63410e06805c50d857220522e64 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=717385b0ba2cc63410e06805c…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Dec 5 13:30:08 2014 +0300 shell32: Added a stub for SHAssocEnumHandlers(). --- dlls/shell32/assoc.c | 90 +++++++++++++++++++++++++++++++++++++++++++++++ dlls/shell32/shell32.spec | 1 + 2 files changed, 91 insertions(+) diff --git a/dlls/shell32/assoc.c b/dlls/shell32/assoc.c index b0d815a..39e210d 100644 --- a/dlls/shell32/assoc.c +++ b/dlls/shell32/assoc.c @@ -77,6 +77,17 @@ static inline IQueryAssociationsImpl *impl_from_IQueryAssociations(IQueryAssocia return CONTAINING_RECORD(iface, IQueryAssociationsImpl, IQueryAssociations_iface); } +struct enumassochandlers +{ + IEnumAssocHandlers IEnumAssocHandlers_iface; + LONG ref; +}; + +static inline struct enumassochandlers *impl_from_IEnumAssocHandlers(IEnumAssocHandlers *iface) +{ + return CONTAINING_RECORD(iface, struct enumassochandlers, IEnumAssocHandlers_iface); +} + /************************************************************************** * IQueryAssociations_QueryInterface * @@ -965,3 +976,82 @@ HRESULT WINAPI ApplicationAssociationRegistration_Constructor(IUnknown *outer, R TRACE("returning 0x%x with %p\n", hr, *ppv); return hr; } + +static HRESULT WINAPI enumassochandlers_QueryInterface(IEnumAssocHandlers *iface, REFIID riid, void **obj) +{ + struct enumassochandlers *This = impl_from_IEnumAssocHandlers(iface); + + TRACE("(%p %s %p)\n", This, debugstr_guid(riid), obj); + + if (IsEqualIID(riid, &IID_IEnumAssocHandlers) || + IsEqualIID(riid, &IID_IUnknown)) + { + *obj = iface; + IEnumAssocHandlers_AddRef(iface); + return S_OK; + } + + *obj = NULL; + return E_NOINTERFACE; +} + +static ULONG WINAPI enumassochandlers_AddRef(IEnumAssocHandlers *iface) +{ + struct enumassochandlers *This = impl_from_IEnumAssocHandlers(iface); + ULONG ref = InterlockedIncrement(&This->ref); + + TRACE("(%p)->(%u)\n", This, ref); + return ref; +} + +static ULONG WINAPI enumassochandlers_Release(IEnumAssocHandlers *iface) +{ + struct enumassochandlers *This = impl_from_IEnumAssocHandlers(iface); + ULONG ref = InterlockedDecrement(&This->ref); + + TRACE("(%p)->(%u)\n", This, ref); + + if (!ref) + SHFree(This); + + return ref; +} + +static HRESULT WINAPI enumassochandlers_Next(IEnumAssocHandlers *iface, ULONG count, IAssocHandler **handlers, + ULONG *fetched) +{ + struct enumassochandlers *This = impl_from_IEnumAssocHandlers(iface); + + FIXME("(%p)->(%u %p %p): stub\n", This, count, handlers, fetched); + + return E_NOTIMPL; +} + +static const IEnumAssocHandlersVtbl enumassochandlersvtbl = { + enumassochandlers_QueryInterface, + enumassochandlers_AddRef, + enumassochandlers_Release, + enumassochandlers_Next +}; + +/************************************************************************** + * SHAssocEnumHandlers [SHELL32.@] + */ +HRESULT WINAPI SHAssocEnumHandlers(const WCHAR *extra, ASSOC_FILTER filter, IEnumAssocHandlers **enumhandlers) +{ + struct enumassochandlers *enumassoc; + + FIXME("(%s %d %p\n): stub", debugstr_w(extra), filter, enumhandlers); + + *enumhandlers = NULL; + + enumassoc = SHAlloc(sizeof(*enumassoc)); + if (!enumassoc) + return E_OUTOFMEMORY; + + enumassoc->IEnumAssocHandlers_iface.lpVtbl = &enumassochandlersvtbl; + enumassoc->ref = 1; + + *enumhandlers = &enumassoc->IEnumAssocHandlers_iface; + return S_OK; +} diff --git a/dlls/shell32/shell32.spec b/dlls/shell32/shell32.spec index e6858c8..0a8d448 100644 --- a/dlls/shell32/shell32.spec +++ b/dlls/shell32/shell32.spec @@ -328,6 +328,7 @@ @ stdcall SetCurrentProcessExplicitAppUserModelID(wstr) @ stdcall SHAddToRecentDocs (long ptr) @ stdcall SHAppBarMessage(long ptr) +@ stdcall SHAssocEnumHandlers(wstr long ptr) @ stdcall SHBindToParent(ptr ptr ptr ptr) @ stdcall SHBrowseForFolder(ptr) SHBrowseForFolderA @ stdcall SHBrowseForFolderA(ptr)
1
0
0
0
← Newer
1
...
19
20
21
22
23
24
25
...
32
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
Results per page:
10
25
50
100
200