wine-commits February 2014

wine-commits@winehq.org

2 participants
503 discussions

Jacek Caban : msxml3: Fixed qname leak.
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: 7dc605ae78e6ba24800c47fc8de5421b433c704d URL: http://source.winehq.org/git/wine.git/?a=commit;h=7dc605ae78e6ba24800c47fc8… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed Feb 12 11:14:49 2014 +0100 msxml3: Fixed qname leak. Spotted by Hans Leidekker. --- dlls/msxml3/saxreader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/msxml3/saxreader.c b/dlls/msxml3/saxreader.c index f861a25..45f6186 100644 --- a/dlls/msxml3/saxreader.c +++ b/dlls/msxml3/saxreader.c @@ -491,6 +491,7 @@ static void free_element_entry(element_entry *element) SysFreeString(element->prefix); SysFreeString(element->local); + SysFreeString(element->qname); heap_free(element->ns); heap_free(element);

1 0

Francois Gouget : dpnet/tests: Add a trailing '\n' to an ok() call.
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: c92f773a3d166078d6ffa63bc0b8a0fc8fe25ce3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c92f773a3d166078d6ffa63bc… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Feb 12 10:28:44 2014 +0100 dpnet/tests: Add a trailing '\n' to an ok() call. --- dlls/dpnet/tests/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dpnet/tests/server.c b/dlls/dpnet/tests/server.c index 723f829..c4de81e 100644 --- a/dlls/dpnet/tests/server.c +++ b/dlls/dpnet/tests/server.c @@ -69,7 +69,7 @@ static void create_server(void) DPN_APPLICATION_DESC appdesc; hr = CoCreateInstance( &CLSID_DirectPlay8Address, NULL, CLSCTX_ALL, &IID_IDirectPlay8Address, (LPVOID*)&localaddr); - ok(hr == S_OK, "Failed to create IDirectPlay8Address object"); + ok(hr == S_OK, "Failed to create IDirectPlay8Address object\n"); hr = IDirectPlay8Address_SetSP(localaddr, &CLSID_DP8SP_TCPIP); ok(hr == S_OK, "got 0x%08x\n", hr);

1 0

Francois Gouget : inetmib1/tests: Add a trailing '\n' to an ok() call.
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: 899cb20eb9f5b173a37483c198b3fac9246ef9a7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=899cb20eb9f5b173a37483c19… Author: Francois Gouget <fgouget(a)free.fr> Date: Wed Feb 12 10:28:38 2014 +0100 inetmib1/tests: Add a trailing '\n' to an ok() call. --- dlls/inetmib1/tests/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/inetmib1/tests/main.c b/dlls/inetmib1/tests/main.c index 29876b1..d7739f1 100644 --- a/dlls/inetmib1/tests/main.c +++ b/dlls/inetmib1/tests/main.c @@ -30,7 +30,7 @@ static HMODULE init_test_functions(void) { HMODULE mod = LoadLibraryA("inetmib1"); - ok(mod != NULL, "failed to load inetmib1.dll"); + ok(mod != NULL, "failed to load inetmib1.dll\n"); if (!mod) return NULL;

1 0

Nikolay Sivov : kernel32/tests: Don't test last error when there' s no failure.
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: ee518b5e3611bfa106d36e98aa250e251e4d50e7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ee518b5e3611bfa106d36e98a… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Feb 12 08:27:24 2014 +0400 kernel32/tests: Don't test last error when there's no failure. --- dlls/kernel32/tests/codepage.c | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/dlls/kernel32/tests/codepage.c b/dlls/kernel32/tests/codepage.c index a269c7e..8423c75 100644 --- a/dlls/kernel32/tests/codepage.c +++ b/dlls/kernel32/tests/codepage.c @@ -546,32 +546,22 @@ static void test_threadcp(void) SetLastError(0xdeadbeef); memset(&cpi, 0, sizeof(cpi)); ret = GetCPInfoExA(CP_ACP, 0, &cpi); - ok(ret, "GetCPInfoExA failed for lcid %04x\n", lcids[i].lcid); - ok(GetLastError() == 0xdeadbeef || - broken(GetLastError() == ERROR_RESOURCE_LANG_NOT_FOUND), /* win2k */ - "GetLastError() is %u for lcid %04x\n", GetLastError(), lcids[i].lcid); + ok(ret, "GetCPInfoExA failed for lcid %04x, error %d\n", lcids[i].lcid, GetLastError()); ok(cpi.CodePage == acp, "wrong codepage %u for lcid %04x, should be %u\n", cpi.CodePage, lcids[i].lcid, acp); /* WideCharToMultiByte - CP_ACP */ - SetLastError(0xdeadbeef); num = WideCharToMultiByte(CP_ACP, 0, foobarW, -1, NULL, 0, NULL, NULL); ok(num == 7, "ret is %d (%04x)\n", num, lcids[i].lcid); - ok(GetLastError() == 0xdeadbeef, "GetLastError() is %u (%04x)\n", GetLastError(), lcids[i].lcid); /* MultiByteToWideChar - CP_ACP */ - SetLastError(0xdeadbeef); num = MultiByteToWideChar(CP_ACP, 0, "foobar", -1, NULL, 0); ok(num == 7, "ret is %d (%04x)\n", num, lcids[i].lcid); - ok(GetLastError() == 0xdeadbeef, "GetLastError() is %u (%04x)\n", GetLastError(), lcids[i].lcid); /* GetCPInfoEx/GetCPInfo - CP_THREAD_ACP */ SetLastError(0xdeadbeef); memset(&cpi, 0, sizeof(cpi)); ret = GetCPInfoExA(CP_THREAD_ACP, 0, &cpi); - ok(ret, "GetCPInfoExA failed for lcid %04x\n", lcids[i].lcid); - ok(GetLastError() == 0xdeadbeef || - broken(GetLastError() == ERROR_RESOURCE_LANG_NOT_FOUND), /* win2k */ - "GetLastError() is %u for lcid %04x\n", GetLastError(), lcids[i].lcid); + ok(ret, "GetCPInfoExA failed for lcid %04x, error %d\n", lcids[i].lcid, GetLastError()); if (lcids[i].threadcp) ok(cpi.CodePage == lcids[i].threadcp, "wrong codepage %u for lcid %04x, should be %u\n", cpi.CodePage, lcids[i].lcid, lcids[i].threadcp); @@ -580,16 +570,12 @@ static void test_threadcp(void) cpi.CodePage, lcids[i].lcid, acp); /* WideCharToMultiByte - CP_THREAD_ACP */ - SetLastError(0xdeadbeef); num = WideCharToMultiByte(CP_THREAD_ACP, 0, foobarW, -1, NULL, 0, NULL, NULL); ok(num == 7, "ret is %d (%04x)\n", num, lcids[i].lcid); - ok(GetLastError() == 0xdeadbeef, "GetLastError() is %u (%04x)\n", GetLastError(), lcids[i].lcid); /* MultiByteToWideChar - CP_THREAD_ACP */ - SetLastError(0xdeadbeef); num = MultiByteToWideChar(CP_THREAD_ACP, 0, "foobar", -1, NULL, 0); ok(num == 7, "ret is %d (%04x)\n", num, lcids[i].lcid); - ok(GetLastError() == 0xdeadbeef, "GetLastError() is %u (%04x)\n", GetLastError(), lcids[i].lcid); } /* IsDBCSLeadByteEx - locales without codepage */

1 0

Nikolay Sivov : kernel32/tests: Fix some test failures in older XP/ Win2k3 versions.
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: 0a20d4680194e557f0f71b3f52965dca4d522313 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0a20d4680194e557f0f71b3f5… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed Feb 12 09:06:41 2014 +0400 kernel32/tests: Fix some test failures in older XP/Win2k3 versions. --- dlls/kernel32/tests/actctx.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/dlls/kernel32/tests/actctx.c b/dlls/kernel32/tests/actctx.c index 8499333..06b5c9c 100644 --- a/dlls/kernel32/tests/actctx.c +++ b/dlls/kernel32/tests/actctx.c @@ -723,7 +723,8 @@ static HANDLE test_create(const char *file) actctx.lpSource = path; handle = pCreateActCtxW(&actctx); - ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); + /* to be tested outside of this helper, including last error */ + if (handle == INVALID_HANDLE_VALUE) return handle; ok(actctx.cbSize == sizeof(actctx), "actctx.cbSize=%d\n", actctx.cbSize); ok(actctx.dwFlags == 0, "actctx.dwFlags=%d\n", actctx.dwFlags); @@ -1556,6 +1557,8 @@ static void test_wndclass_section(void) create_manifest_file("main_wndcls.manifest", manifest_wndcls_main, -1, NULL, NULL); handle = test_create("main_wndcls.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); + DeleteFileA("testdep1.manifest"); DeleteFileA("testdep2.manifest"); DeleteFileA("main_wndcls.manifest"); @@ -1618,6 +1621,8 @@ static void test_dllredirect_section(void) create_manifest_file("main_wndcls.manifest", manifest_wndcls_main, -1, NULL, NULL); handle = test_create("main_wndcls.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); + DeleteFileA("testdep1.manifest"); DeleteFileA("testdep2.manifest"); DeleteFileA("main_wndcls.manifest"); @@ -1671,6 +1676,8 @@ static void test_typelib_section(void) create_manifest_file("main_wndcls.manifest", manifest_wndcls_main, -1, NULL, NULL); handle = test_create("main_wndcls.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); + DeleteFileA("testdep1.manifest"); DeleteFileA("testdep2.manifest"); DeleteFileA("main_wndcls.manifest"); @@ -1744,7 +1751,7 @@ static void test_actctx(void) /* test for whitespace handling in Eq ::= S? '=' S? */ create_manifest_file("test1_1.manifest", manifest1_1, -1, NULL, NULL); handle = test_create("test1_1.manifest"); - ok(handle != INVALID_HANDLE_VALUE, "got %p\n", handle); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); DeleteFileA("test1_1.manifest"); pReleaseActCtx(handle); @@ -1756,6 +1763,7 @@ static void test_actctx(void) trace("manifest1\n"); handle = test_create("test1.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); DeleteFileA("test1.manifest"); if(handle != INVALID_HANDLE_VALUE) { test_basic_info(handle, __LINE__); @@ -1781,6 +1789,7 @@ static void test_actctx(void) trace("manifest2 depmanifest1\n"); handle = test_create("test2.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); DeleteFileA("test2.manifest"); DeleteFileA("testdep.manifest"); if(handle != INVALID_HANDLE_VALUE) { @@ -1799,6 +1808,7 @@ static void test_actctx(void) trace("manifest2 depmanifest2\n"); handle = test_create("test2-2.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); DeleteFileA("test2-2.manifest"); DeleteFileA("testdep.manifest"); if(handle != INVALID_HANDLE_VALUE) { @@ -1827,6 +1837,7 @@ static void test_actctx(void) } handle = test_create("test2-3.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); DeleteFileA("test2-3.manifest"); DeleteFileA("testdep.manifest"); if(handle != INVALID_HANDLE_VALUE) { @@ -1857,6 +1868,10 @@ static void test_actctx(void) } handle = test_create("test3.manifest"); + ok(handle != INVALID_HANDLE_VALUE || broken(handle == INVALID_HANDLE_VALUE) /* XP pre-SP2, win2k3 w/o SP */, + "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); + if (handle == INVALID_HANDLE_VALUE) + win_skip("Some activation context features not supported, skipping a test (possibly old XP/Win2k3 system\n"); DeleteFileA("test3.manifest"); if(handle != INVALID_HANDLE_VALUE) { static const WCHAR nameW[] = {'t','e','s','t','s','u','r','r','o','g','a','t','e',0}; @@ -1909,6 +1924,7 @@ static void test_actctx(void) } handle = test_create("test4.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); DeleteFileA("test4.manifest"); DeleteFileA("testdep.manifest"); if(handle != INVALID_HANDLE_VALUE) { @@ -1929,6 +1945,7 @@ static void test_actctx(void) return; } handle = test_create("..\\test1.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); DeleteFileA("..\\test1.manifest"); if(handle != INVALID_HANDLE_VALUE) { test_basic_info(handle, __LINE__); @@ -1949,6 +1966,7 @@ static void test_actctx(void) } handle = test_create("test1.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); DeleteFileA("test1.manifest"); if (handle != INVALID_HANDLE_VALUE) { test_basic_info(handle, __LINE__); @@ -1964,6 +1982,7 @@ static void test_actctx(void) } handle = test_create("test1.manifest"); + ok(handle != INVALID_HANDLE_VALUE, "handle == INVALID_HANDLE_VALUE, error %u\n", GetLastError()); DeleteFileA("test1.manifest"); if (handle != INVALID_HANDLE_VALUE) { test_basic_info(handle, __LINE__);

1 0

Alexandre Julliard : kernel32: Set correct binary type for COM and PIF files.
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: 7066ce0b1e22bc490bd791fd948bbbb3a1400bc9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7066ce0b1e22bc490bd791fd9… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Wed Feb 12 11:22:53 2014 +0100 kernel32: Set correct binary type for COM and PIF files. --- dlls/kernel32/process.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dlls/kernel32/process.c b/dlls/kernel32/process.c index bf113d6..60156aa 100644 --- a/dlls/kernel32/process.c +++ b/dlls/kernel32/process.c @@ -2368,6 +2368,8 @@ static BOOL create_process_impl( LPCWSTR app_name, LPWSTR cmd_line, LPSECURITY_A if (!strcmpiW( p, comW ) || !strcmpiW( p, pifW )) { TRACE( "starting %s as DOS binary\n", debugstr_w(name) ); + binary_info.type = BINARY_DOS; + binary_info.arch = IMAGE_FILE_MACHINE_I386; retv = create_vdm_process( name, tidy_cmdline, envW, cur_dir, process_attr, thread_attr, inherit, flags, startup_info, info, unixdir, &binary_info, FALSE ); @@ -2502,6 +2504,8 @@ static void exec_process( LPCWSTR name ) /* check for .com or .pif extension */ if (!(p = strrchrW( name, '.' ))) break; if (strcmpiW( p, comW ) && strcmpiW( p, pifW )) break; + binary_info.type = BINARY_DOS; + binary_info.arch = IMAGE_FILE_MACHINE_I386; /* fall through */ case BINARY_OS216: case BINARY_WIN16:

1 0

Michael Stefaniuc : qedit/tests: COM tests for IEnumPins from SampleGrabber.
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: 37e5d4c53c9045cea966d245ed565dba782ab043 URL: http://source.winehq.org/git/wine.git/?a=commit;h=37e5d4c53c9045cea966d245e… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Feb 12 01:10:54 2014 +0100 qedit/tests: COM tests for IEnumPins from SampleGrabber. --- dlls/qedit/tests/mediadet.c | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c index cc16b6b..fce3e97 100644 --- a/dlls/qedit/tests/mediadet.c +++ b/dlls/qedit/tests/mediadet.c @@ -432,6 +432,38 @@ static void test_samplegrabber(void) while (ISampleGrabber_Release(sg)); } +static void test_COM_sg_enumpins(void) +{ + IBaseFilter *bf; + IEnumPins *pins, *pins2; + IUnknown *unk; + ULONG refcount; + HRESULT hr; + + hr = CoCreateInstance(&CLSID_SampleGrabber, NULL, CLSCTX_INPROC_SERVER, &IID_IBaseFilter, + (void**)&bf); + ok(hr == S_OK, "SampleGrabber create failed: %08x, expected S_OK\n", hr); + hr = IBaseFilter_EnumPins(bf, &pins); + ok(hr == S_OK, "EnumPins create failed: %08x, expected S_OK\n", hr); + + /* Same refcount for all EnumPins interfaces */ + refcount = IEnumPins_AddRef(pins); + ok(refcount == 2, "refcount == %u, expected 2\n", refcount); + hr = IEnumPins_QueryInterface(pins, &IID_IEnumPins, (void**)&pins2); + ok(hr == S_OK, "QueryInterface for IID_IEnumPins failed: %08x\n", hr); + ok(pins == pins2, "QueryInterface for self failed (%p != %p)\n", pins, pins2); + IEnumPins_Release(pins2); + + hr = IEnumPins_QueryInterface(pins, &IID_IUnknown, (void**)&unk); + ok(hr == S_OK, "QueryInterface for IID_IUnknown failed: %08x\n", hr); + refcount = IUnknown_AddRef(unk); + ok(refcount == 4, "refcount == %u, expected 4\n", refcount); + refcount = IUnknown_Release(unk); + + while (IEnumPins_Release(pins)); + IBaseFilter_Release(bf); +} + START_TEST(mediadet) { if (!init_tests()) @@ -443,5 +475,6 @@ START_TEST(mediadet) CoInitialize(NULL); test_mediadet(); test_samplegrabber(); + test_COM_sg_enumpins(); CoUninitialize(); }

1 0

Michael Stefaniuc : qedit: Return the correct iface in IEnumPins_QueryInterface().
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: ec9d32adf88eecc898916488bbcb647d9ff46a99 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ec9d32adf88eecc898916488b… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Feb 12 01:07:08 2014 +0100 qedit: Return the correct iface in IEnumPins_QueryInterface(). --- dlls/qedit/samplegrabber.c | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c index 046f912..de3d797 100644 --- a/dlls/qedit/samplegrabber.c +++ b/dlls/qedit/samplegrabber.c @@ -79,20 +79,18 @@ Fixed_IEnumPins_Release(IEnumPins *iface) } /* IUnknown */ -static HRESULT WINAPI -Fixed_IEnumPins_QueryInterface(IEnumPins *iface, REFIID riid, void **ppvObject) +static HRESULT WINAPI Fixed_IEnumPins_QueryInterface(IEnumPins *iface, REFIID riid, + void **ret_iface) { - PE_Impl *This = (PE_Impl *)iface; - TRACE("(%p)->(%s %p)\n", This, debugstr_guid(riid), ppvObject); + TRACE("(%p)->(%s %p)\n", iface, debugstr_guid(riid), ret_iface); - if (IsEqualIID(riid, &IID_IUnknown) || - IsEqualIID(riid, &IID_IEnumPins)) { - Fixed_IEnumPins_AddRef(iface); - *ppvObject = This->pins; + if (IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid, &IID_IEnumPins)) { + IEnumPins_AddRef(iface); + *ret_iface = iface; return S_OK; } - *ppvObject = NULL; - WARN("(%p, %s,%p): not found\n", This, debugstr_guid(riid), ppvObject); + *ret_iface = NULL; + WARN("(%p, %s, %p): not found\n", iface, debugstr_guid(riid), ret_iface); return E_NOINTERFACE; }

1 0

Michael Stefaniuc : qedit/tests: Expand the SampleGrabber COM tests.
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: bb08b9f463e4436150a17aa532e7d277100a988e URL: http://source.winehq.org/git/wine.git/?a=commit;h=bb08b9f463e4436150a17aa53… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Feb 12 01:05:05 2014 +0100 qedit/tests: Expand the SampleGrabber COM tests. --- dlls/qedit/tests/mediadet.c | 56 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 55 insertions(+), 1 deletion(-) diff --git a/dlls/qedit/tests/mediadet.c b/dlls/qedit/tests/mediadet.c index c488b37..cc16b6b 100644 --- a/dlls/qedit/tests/mediadet.c +++ b/dlls/qedit/tests/mediadet.c @@ -27,6 +27,7 @@ #include "uuids.h" #include "wine/test.h" #include "qedit.h" +#include "control.h" #include "rc.h" /* Outer IUnknown for COM aggregation tests */ @@ -358,6 +359,10 @@ static void test_samplegrabber(void) { struct unk_impl unk_obj = {{&unk_vtbl}, 19, NULL}; ISampleGrabber *sg; + IBaseFilter *bf; + IMediaFilter *mf; + IPersist *persist; + IUnknown *unk; ULONG refcount; HRESULT hr; @@ -374,8 +379,57 @@ static void test_samplegrabber(void) ok(refcount == unk_obj.ref, "SampleGrabber just pretends to support COM aggregation\n"); refcount = ISampleGrabber_Release(sg); ok(refcount == 19, "Refcount should be back at 19 but is %u\n", refcount); - IUnknown_Release(unk_obj.inner_unk); + + /* Invalid RIID */ + hr = CoCreateInstance(&CLSID_SampleGrabber, NULL, CLSCTX_INPROC_SERVER, &IID_IClassFactory, + (void**)&sg); + ok(hr == E_NOINTERFACE, "SampleGrabber create failed: %08x, expected E_NOINTERFACE\n", hr); + + /* Same refcount for all SampleGrabber interfaces */ + hr = CoCreateInstance(&CLSID_SampleGrabber, NULL, CLSCTX_INPROC_SERVER, &IID_ISampleGrabber, + (void**)&sg); + ok(hr == S_OK, "SampleGrabber create failed: %08x, expected S_OK\n", hr); + refcount = ISampleGrabber_AddRef(sg); + ok(refcount == 2, "refcount == %u, expected 2\n", refcount); + + hr = ISampleGrabber_QueryInterface(sg, &IID_IBaseFilter, (void**)&bf); + ok(hr == S_OK, "QueryInterface for IID_IBaseFilter failed: %08x\n", hr); + refcount = IBaseFilter_AddRef(bf); + ok(refcount == 4, "refcount == %u, expected 4\n", refcount); + refcount = IBaseFilter_Release(bf); + + hr = ISampleGrabber_QueryInterface(sg, &IID_IMediaFilter, (void**)&mf); + ok(hr == S_OK, "QueryInterface for IID_IMediaFilter failed: %08x\n", hr); + refcount = IMediaFilter_AddRef(mf); + ok(refcount == 5, "refcount == %u, expected 5\n", refcount); + refcount = IMediaFilter_Release(mf); + + hr = ISampleGrabber_QueryInterface(sg, &IID_IPersist, (void**)&persist); + ok(hr == S_OK, "QueryInterface for IID_IPersist failed: %08x\n", hr); + refcount = IPersist_AddRef(persist); + ok(refcount == 6, "refcount == %u, expected 6\n", refcount); + refcount = IPersist_Release(persist); + + hr = ISampleGrabber_QueryInterface(sg, &IID_IUnknown, (void**)&unk); + ok(hr == S_OK, "QueryInterface for IID_IUnknown failed: %08x\n", hr); + refcount = IUnknown_AddRef(unk); + ok(refcount == 7, "refcount == %u, expected 7\n", refcount); + refcount = IUnknown_Release(unk); + + /* Interfaces that native does not support */ + hr = ISampleGrabber_QueryInterface(sg, &IID_IMediaPosition, (void**)&unk); + todo_wine ok(hr == E_NOINTERFACE, "QueryInterface for IID_IMediaPosition failed: %08x\n", hr); + hr = ISampleGrabber_QueryInterface(sg, &IID_IMediaSeeking, (void**)&unk); + todo_wine ok(hr == E_NOINTERFACE, "QueryInterface for IID_IMediaSeeking failed: %08x\n", hr); + hr = ISampleGrabber_QueryInterface(sg, &IID_IMemInputPin, (void**)&unk); + ok(hr == E_NOINTERFACE, "QueryInterface for IID_IMemInputPin failed: %08x\n", hr); + hr = ISampleGrabber_QueryInterface(sg, &IID_IQualityControl, (void**)&unk); + ok(hr == E_NOINTERFACE, "QueryInterface for IID_IQualityControl failed: %08x\n", hr); + hr = ISampleGrabber_QueryInterface(sg, &IID_ISeekingPassThru, (void**)&unk); + ok(hr == E_NOINTERFACE, "QueryInterface for IID_ISeekingPassThru failed: %08x\n", hr); + + while (ISampleGrabber_Release(sg)); } START_TEST(mediadet)

1 0

Michael Stefaniuc : qedit: IMemInputPin / IQualityControl are IPin stuff.
by Alexandre Julliard 12 Feb '14

12 Feb '14

Module: wine Branch: master Commit: e27adf2a8cf24cebb3f315e0bb4f934170fc93de URL: http://source.winehq.org/git/wine.git/?a=commit;h=e27adf2a8cf24cebb3f315e0b… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Wed Feb 12 01:02:40 2014 +0100 qedit: IMemInputPin / IQualityControl are IPin stuff. --- dlls/qedit/samplegrabber.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/dlls/qedit/samplegrabber.c b/dlls/qedit/samplegrabber.c index 15a3471..046f912 100644 --- a/dlls/qedit/samplegrabber.c +++ b/dlls/qedit/samplegrabber.c @@ -372,10 +372,8 @@ typedef struct _SG_Impl { IUnknown IUnknown_inner; IBaseFilter IBaseFilter_iface; ISampleGrabber ISampleGrabber_iface; - IMemInputPin IMemInputPin_iface; /* IMediaSeeking and IMediaPosition are implemented by ISeekingPassThru */ IUnknown* seekthru_unk; - /* TODO: IQualityControl */ IUnknown *outer_unk; LONG ref; CRITICAL_SECTION critSect; @@ -384,6 +382,7 @@ typedef struct _SG_Impl { AM_MEDIA_TYPE mtype; SG_Pin pin_in; SG_Pin pin_out; + IMemInputPin IMemInputPin_iface; IMemAllocator *allocator; IReferenceClock *refClock; IMemInputPin *memOutput; @@ -460,14 +459,10 @@ static HRESULT WINAPI SampleGrabber_QueryInterface(IUnknown *iface, REFIID riid, *ppv = &This->IBaseFilter_iface; else if (IsEqualIID(riid, &IID_ISampleGrabber)) *ppv = &This->ISampleGrabber_iface; - else if (IsEqualIID(riid, &IID_IMemInputPin)) - *ppv = &This->IMemInputPin_iface; else if (IsEqualIID(riid, &IID_IMediaPosition)) return IUnknown_QueryInterface(This->seekthru_unk, riid, ppv); else if (IsEqualIID(riid, &IID_IMediaSeeking)) return IUnknown_QueryInterface(This->seekthru_unk, riid, ppv); - else if (IsEqualIID(riid, &IID_IQualityControl)) - FIXME("IQualityControl not implemented\n"); else WARN("(%p, %s,%p): not found\n", This, debugstr_guid(riid), ppv);

1 0

← Newer
1
...
28
29
30
31
32
33
34
...
51
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits February 2014