wine-commits April 2014

wine-commits@winehq.org

2 participants
500 discussions

Nikolay Sivov : crypt32/tests: Fix some leaks (Valgrind).
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: fc8bf3c3b632cad603f980b05c04d8384c0d65ad URL: http://source.winehq.org/git/wine.git/?a=commit;h=fc8bf3c3b632cad603f980b05… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Apr 25 12:34:06 2014 +0400 crypt32/tests: Fix some leaks (Valgrind). --- dlls/crypt32/tests/cert.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/crypt32/tests/cert.c b/dlls/crypt32/tests/cert.c index 9c95629..66f13db 100644 --- a/dlls/crypt32/tests/cert.c +++ b/dlls/crypt32/tests/cert.c @@ -797,7 +797,7 @@ static void testLinkCert(void) ok(link->pCertInfo == context->pCertInfo, "unexpected pCertInfo\n"); CertFreeCertificateContext(link); - + CertFreeCertificateContext(context); CertCloseStore(store, 0); } @@ -2343,6 +2343,7 @@ static void testCreateSelfSignCert(void) "Expected NTE_NO_KEY, got %08x\n", GetLastError()); ret = CryptGenKey(csp, AT_KEYEXCHANGE, 0, &key); ok(ret, "CryptGenKey failed: %08x\n", GetLastError()); + CryptDestroyKey(key); memset(&info,0,sizeof(info)); info.dwProvType = PROV_RSA_FULL;

1 0

Vincent Povirk : appwiz.cpl: Don' t use SEE_MASK_NO_CONSOLE to run installers.
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: 71d5e6f4a69147544b15494de0875705e3aebb46 URL: http://source.winehq.org/git/wine.git/?a=commit;h=71d5e6f4a69147544b15494de… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Apr 22 12:52:10 2014 -0500 appwiz.cpl: Don't use SEE_MASK_NO_CONSOLE to run installers. --- dlls/appwiz.cpl/appwiz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/appwiz.cpl/appwiz.c b/dlls/appwiz.cpl/appwiz.c index 1e092b1..cd76f51 100644 --- a/dlls/appwiz.cpl/appwiz.c +++ b/dlls/appwiz.cpl/appwiz.c @@ -477,7 +477,7 @@ static void InstallProgram(HWND hWnd) sei.cbSize = sizeof(sei); sei.lpVerb = openW; sei.nShow = SW_SHOWDEFAULT; - sei.fMask = SEE_MASK_NO_CONSOLE; + sei.fMask = 0; sei.lpFile = ofn.lpstrFile; ShellExecuteExW(&sei);

1 0

Vincent Povirk : start: Don't use SEE_MASK_NO_CONSOLE.
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: 9e0971e374c87472af00df50a57dc8de7fe74f11 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9e0971e374c87472af00df50a… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Tue Apr 22 12:47:29 2014 -0500 start: Don't use SEE_MASK_NO_CONSOLE. --- programs/start/start.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/programs/start/start.c b/programs/start/start.c index 7bf8ea8..9f2c3f7 100644 --- a/programs/start/start.c +++ b/programs/start/start.c @@ -216,8 +216,7 @@ int wmain (int argc, WCHAR *argv[]) sei.nShow = SW_SHOWNORMAL; /* Dunno what these mean, but it looks like winMe's start uses them */ sei.fMask = SEE_MASK_FLAG_DDEWAIT| - SEE_MASK_FLAG_NO_UI| - SEE_MASK_NO_CONSOLE; + SEE_MASK_FLAG_NO_UI; sei.lpDirectory = NULL; creation_flags = CREATE_NEW_CONSOLE;

1 0

Vincent Povirk : shell32/tests: Use SEE_MASK_NO_CONSOLE with ShellExecuteExA.
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: 3d1cf168cfc517e71515bac04fa13fb2bbd4ab49 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3d1cf168cfc517e71515bac04… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Apr 17 17:32:27 2014 -0500 shell32/tests: Use SEE_MASK_NO_CONSOLE with ShellExecuteExA. --- dlls/shell32/tests/shlexec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/shell32/tests/shlexec.c b/dlls/shell32/tests/shlexec.c index 9f4b1a3..e3169c8 100644 --- a/dlls/shell32/tests/shlexec.c +++ b/dlls/shell32/tests/shlexec.c @@ -183,7 +183,7 @@ static INT_PTR shell_execute_ex(DWORD mask, LPCSTR verb, LPCSTR file, trace("%s\n", shell_call); sei.cbSize=sizeof(sei); - sei.fMask=SEE_MASK_NOCLOSEPROCESS | mask; + sei.fMask=SEE_MASK_NOCLOSEPROCESS | SEE_MASK_NO_CONSOLE | mask; sei.hwnd=NULL; sei.lpVerb=verb; sei.lpFile=file;

1 0

Vincent Povirk : shell32: Use CREATE_NEW_CONSOLE when SEE_MASK_NOCONSOLE is omitted.
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: 2005be6dc92c0943ede01525cecad88f8e83c9c7 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2005be6dc92c0943ede01525c… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Apr 16 15:50:37 2014 -0500 shell32: Use CREATE_NEW_CONSOLE when SEE_MASK_NOCONSOLE is omitted. --- dlls/shell32/shlexec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/shell32/shlexec.c b/dlls/shell32/shlexec.c index 41c147d..a6bc5c8 100644 --- a/dlls/shell32/shlexec.c +++ b/dlls/shell32/shlexec.c @@ -338,7 +338,7 @@ static UINT_PTR SHELL_ExecuteW(const WCHAR *lpCmd, WCHAR *env, BOOL shWait, startup.dwFlags = STARTF_USESHOWWINDOW; startup.wShowWindow = psei->nShow; dwCreationFlags = CREATE_UNICODE_ENVIRONMENT; - if (psei->fMask & SEE_MASK_NO_CONSOLE) + if (!(psei->fMask & SEE_MASK_NO_CONSOLE)) dwCreationFlags |= CREATE_NEW_CONSOLE; if (CreateProcessW(NULL, (LPWSTR)lpCmd, NULL, NULL, FALSE, dwCreationFlags, env, lpDirectory, &startup, &info))

1 0

Vincent Povirk : shell32: Pass MASK_NO_CONSOLE through to context menu handlers.
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: 33a22421337e2aa474e07e17aeefda0a6059b05f URL: http://source.winehq.org/git/wine.git/?a=commit;h=33a22421337e2aa474e07e17a… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Apr 17 17:31:53 2014 -0500 shell32: Pass MASK_NO_CONSOLE through to context menu handlers. --- dlls/shell32/shlexec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/shell32/shlexec.c b/dlls/shell32/shlexec.c index 39d640a..41c147d 100644 --- a/dlls/shell32/shlexec.c +++ b/dlls/shell32/shlexec.c @@ -1248,7 +1248,7 @@ static HRESULT shellex_run_context_menu_default( IShellExtInit *obj, memset( &ici, 0, sizeof ici ); ici.cbSize = sizeof ici; - ici.fMask = CMIC_MASK_UNICODE | (sei->fMask & (SEE_MASK_NOASYNC|SEE_MASK_ASYNCOK|SEE_MASK_FLAG_NO_UI)); + ici.fMask = CMIC_MASK_UNICODE | (sei->fMask & (SEE_MASK_NO_CONSOLE|SEE_MASK_NOASYNC|SEE_MASK_ASYNCOK|SEE_MASK_FLAG_NO_UI)); ici.nShow = sei->nShow; ici.lpVerb = MAKEINTRESOURCEA( def ); ici.hwnd = sei->hwnd;

1 0

Vincent Povirk : shell32: Respect CMIC_MASK_NO_CONSOLE in ShellLink InvokeCommand.
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: 7eebbf3b076aaa9438f04959e02a94c44c419b63 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7eebbf3b076aaa9438f04959e… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Thu Apr 17 17:30:43 2014 -0500 shell32: Respect CMIC_MASK_NO_CONSOLE in ShellLink InvokeCommand. --- dlls/shell32/shelllink.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/shell32/shelllink.c b/dlls/shell32/shelllink.c index 4000a1d..b9c9e75 100644 --- a/dlls/shell32/shelllink.c +++ b/dlls/shell32/shelllink.c @@ -2500,7 +2500,7 @@ ShellLink_InvokeCommand( IContextMenu* iface, LPCMINVOKECOMMANDINFO lpici ) memset( &sei, 0, sizeof sei ); sei.cbSize = sizeof sei; - sei.fMask = SEE_MASK_UNICODE | (lpici->fMask & (SEE_MASK_NOASYNC|SEE_MASK_ASYNCOK|SEE_MASK_FLAG_NO_UI)); + sei.fMask = SEE_MASK_UNICODE | (lpici->fMask & (SEE_MASK_NOASYNC|SEE_MASK_NO_CONSOLE|SEE_MASK_ASYNCOK|SEE_MASK_FLAG_NO_UI)); sei.lpFile = path; sei.nShow = This->iShowCmd; sei.lpIDList = This->pPidl;

1 0

Nikolay Sivov : comctl32/tests: Initialize text buffer pointer (Valgrind).
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: 9b2ea633114651dfe55f9026bf1654290ae501b3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9b2ea633114651dfe55f9026b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Apr 25 11:21:05 2014 +0400 comctl32/tests: Initialize text buffer pointer (Valgrind). --- dlls/comctl32/tests/tooltips.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/comctl32/tests/tooltips.c b/dlls/comctl32/tests/tooltips.c index 2766354..271009d 100644 --- a/dlls/comctl32/tests/tooltips.c +++ b/dlls/comctl32/tests/tooltips.c @@ -466,6 +466,7 @@ static void test_ttm_gettoolinfo(void) tiW.hwnd = NULL; tiW.uId = 0x1234ABCD; tiW.lParam = 0xaaaaaaaa; + tiW.lpszText = NULL; r = SendMessageA(hwnd, TTM_GETTOOLINFOW, 0, (LPARAM)&tiW); ok(r, "Getting tooltip info failed\n"); ok(0x1abe11ed == tiW.lParam ||

1 0

Nikolay Sivov : advapi32/tests: Fix some leaks in tests (Valgrind).
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: e543eeb42be157a5c6fb6bc17825d394af699aa4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e543eeb42be157a5c6fb6bc17… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Apr 25 09:22:48 2014 +0400 advapi32/tests: Fix some leaks in tests (Valgrind). --- dlls/advapi32/tests/security.c | 8 ++++++-- dlls/advapi32/tests/service.c | 4 +++- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c index bd45189..a0574c4 100644 --- a/dlls/advapi32/tests/security.c +++ b/dlls/advapi32/tests/security.c @@ -3124,6 +3124,7 @@ static void test_CreateDirectoryA(void) ok(ace->Mask == 0x1f01ff, "Administators Group ACE has unexpected mask (0x%x != 0x1f01ff)\n", ace->Mask); } + LocalFree(pSD); done: HeapFree(GetProcessHeap(), 0, user); @@ -3231,10 +3232,12 @@ static void test_GetNamedSecurityInfoA(void) NULL, NULL, NULL, NULL, NULL); ok(error==ERROR_INVALID_PARAMETER, "GetNamedSecurityInfo failed with error %d\n", error); + pDacl = NULL; error = pGetNamedSecurityInfoA(windows_dir, SE_FILE_OBJECT,DACL_SECURITY_INFORMATION, - NULL, NULL, &pDacl, NULL, NULL); + NULL, NULL, &pDacl, NULL, &pSD); ok(!error, "GetNamedSecurityInfo failed with error %d\n", error); ok(pDacl != NULL, "DACL should not be NULL\n"); + LocalFree(pSD); error = pGetNamedSecurityInfoA(windows_dir, SE_FILE_OBJECT,OWNER_SECURITY_INFORMATION, NULL, NULL, &pDacl, NULL, NULL); @@ -3950,7 +3953,7 @@ static void test_GetSecurityInfo(void) NULL, NULL, pDacl, NULL); ok(ret == ERROR_SUCCESS, "SetSecurityInfo returned %d\n", ret); ret = pGetSecurityInfo(obj, SE_FILE_OBJECT, DACL_SECURITY_INFORMATION, - NULL, NULL, &pDacl, NULL, NULL); + NULL, NULL, &pDacl, NULL, &pSD); ok(ret == ERROR_SUCCESS, "GetSecurityInfo returned %d\n", ret); ok(pDacl && IsValidAcl(pDacl), "GetSecurityInfo returned invalid DACL.\n"); bret = pGetAclInformation(pDacl, &acl_size, sizeof(acl_size), AclSizeInformation); @@ -3977,6 +3980,7 @@ static void test_GetSecurityInfo(void) ok(ace->Mask == 0x1f01ff, "Administators Group ACE has unexpected mask (0x%x != 0x1f01ff)\n", ace->Mask); } + LocalFree(pSD); CloseHandle(obj); } diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c index 9b6c1cf..4ebae1c 100644 --- a/dlls/advapi32/tests/service.c +++ b/dlls/advapi32/tests/service.c @@ -136,6 +136,7 @@ static void test_open_svc(void) ok(GetLastError() == ERROR_INVALID_ADDRESS /* W2K, XP, W2K3, Vista */ || GetLastError() == ERROR_INVALID_PARAMETER /* NT4 */, "Expected ERROR_INVALID_ADDRESS or ERROR_INVALID_PARAMETER, got %d\n", GetLastError()); + CloseServiceHandle(scm_handle); /* Nonexistent service */ scm_handle = OpenSCManagerA(NULL, NULL, SC_MANAGER_CONNECT); @@ -1840,8 +1841,9 @@ static void test_sequence(void) if (!is_nt4) { retval = pGetSecurityInfo(svc_handle, SE_SERVICE, DACL_SECURITY_INFORMATION, NULL, - NULL, &dacl, NULL, NULL); + NULL, &dacl, NULL, &pSD); ok(retval == ERROR_SUCCESS, "Expected GetSecurityInfo to succeed: result %d\n", retval); + LocalFree(pSD); SetLastError(0xdeadbeef); retval = pGetSecurityInfo(svc_handle, SE_SERVICE, DACL_SECURITY_INFORMATION, NULL, NULL, NULL, NULL, NULL);

1 0

Bruno Jesus : dinput: Remove duplicated TRACE check.
by Alexandre Julliard 25 Apr '14

25 Apr '14

Module: wine Branch: master Commit: e01130724493dab1e7bd6650db826c81c14cd3c1 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e01130724493dab1e7bd6650d… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Thu Apr 24 20:42:37 2014 -0300 dinput: Remove duplicated TRACE check. --- dlls/dinput/joystick.c | 1 - 1 file changed, 1 deletion(-) diff --git a/dlls/dinput/joystick.c b/dlls/dinput/joystick.c index 4eddd89..0d61f57 100644 --- a/dlls/dinput/joystick.c +++ b/dlls/dinput/joystick.c @@ -406,7 +406,6 @@ void _dump_DIDEVCAPS(const DIDEVCAPS *lpDIDevCaps) TRACE("dwFlags: %08x\n", lpDIDevCaps->dwFlags); TRACE("dwDevType: %08x %s\n", lpDIDevCaps->dwDevType, lpDIDevCaps->dwDevType == DIDEVTYPE_DEVICE ? "DIDEVTYPE_DEVICE" : - lpDIDevCaps->dwDevType == DIDEVTYPE_DEVICE ? "DIDEVTYPE_DEVICE" : lpDIDevCaps->dwDevType == DIDEVTYPE_MOUSE ? "DIDEVTYPE_MOUSE" : lpDIDevCaps->dwDevType == DIDEVTYPE_KEYBOARD ? "DIDEVTYPE_KEYBOARD" : lpDIDevCaps->dwDevType == DIDEVTYPE_JOYSTICK ? "DIDEVTYPE_JOYSTICK" :

1 0

← Newer
1
...
5
6
7
8
9
10
11
...
50
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits April 2014