Module: wine
Branch: master
Commit: bb8fdb734ed1552f0d9bf9b2bcec614d29d72bc2
URL: http://source.winehq.org/git/wine.git/?a=commit;h=bb8fdb734ed1552f0d9bf9b2b…
Author: Vincent Povirk <vincent(a)codeweavers.com>
Date: Thu Jun 12 14:15:21 2014 -0500
windowscodecs: Fix leak in DGifGetImageDesc.
---
dlls/windowscodecs/ungif.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/dlls/windowscodecs/ungif.c b/dlls/windowscodecs/ungif.c
index c2887ed..427b32f 100644
--- a/dlls/windowscodecs/ungif.c
+++ b/dlls/windowscodecs/ungif.c
@@ -405,10 +405,7 @@ DGifGetImageDesc(GifFileType * GifFile) {
GifFile->Image.Interlace = (Buf[0] & 0x40);
if (Buf[0] & 0x80) { /* Does this image have local color map? */
- /*** FIXME: Why do we check both of these in order to do this?
- * Why do we have both Image and SavedImages? */
- if (GifFile->Image.ColorMap && GifFile->SavedImages == NULL)
- FreeMapObject(GifFile->Image.ColorMap);
+ FreeMapObject(GifFile->Image.ColorMap);
GifFile->Image.ColorMap = MakeMapObject(1 << BitsPerPixel, NULL);
if (GifFile->Image.ColorMap == NULL) {
Module: tools
Branch: master
Commit: f792f79622fdb823f91f7809714fcfca36467414
URL: http://source.winehq.org/git/tools.git/?a=commit;h=f792f79622fdb823f91f7809…
Author: Francois Gouget <fgouget(a)codeweavers.com>
Date: Wed Jun 18 13:45:36 2014 +0200
testbot/lib: Improve the methods argument handling.
This standardizes the way we handle the arguments. Make it so one can
readily see the list of arguments the method takes without having to
hunt down the implementation of all its ancestors. Because these are
methods the added prototypes have no effect whatsoever as far as Perl
is concerned. However they do document which arguments are optional.
---
testbot/lib/WineTestBot/Branches.pm | 14 ++---
testbot/lib/WineTestBot/Jobs.pm | 46 +++++++-------
testbot/lib/WineTestBot/Patches.pm | 35 +++++------
testbot/lib/WineTestBot/PendingPatchSets.pm | 33 +++++-----
testbot/lib/WineTestBot/PendingPatches.pm | 4 +-
testbot/lib/WineTestBot/Roles.pm | 4 +-
testbot/lib/WineTestBot/Steps.pm | 14 ++---
testbot/lib/WineTestBot/StepsTasks.pm | 13 ++--
testbot/lib/WineTestBot/Tasks.pm | 11 ++--
testbot/lib/WineTestBot/UserRoles.pm | 4 +-
testbot/lib/WineTestBot/Users.pm | 81 +++++++++++--------------
testbot/lib/WineTestBot/VMs.pm | 56 ++++++++---------
testbot/lib/WineTestBot/WineTestBotObjects.pm | 6 +-
13 files changed, 146 insertions(+), 175 deletions(-)
Diff: http://source.winehq.org/git/tools.git/?a=commitdiff;h=f792f79622fdb823f91f…