wine-commits October 2015

wine-commits@winehq.org

2 participants
749 discussions

Nikolay Sivov : dwrite: Ignore embedded bitmaps when asked for outline.
by Alexandre Julliard 12 Oct '15

12 Oct '15

Module: wine Branch: master Commit: 925dc6da8f33ea1e1a092d92f62c127182d98745 URL: http://source.winehq.org/git/wine.git/?a=commit;h=925dc6da8f33ea1e1a092d92f… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Oct 9 17:56:02 2015 +0300 dwrite: Ignore embedded bitmaps when asked for outline. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dwrite/freetype.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dwrite/freetype.c b/dlls/dwrite/freetype.c index 4eaef02..cfae1af 100644 --- a/dlls/dwrite/freetype.c +++ b/dlls/dwrite/freetype.c @@ -399,7 +399,7 @@ HRESULT freetype_get_glyph_outline(IDWriteFontFace2 *fontface, FLOAT emSize, UIN EnterCriticalSection(&freetype_cs); if (pFTC_Manager_LookupSize(cache_manager, &scaler, &size) == 0) { - if (pFT_Load_Glyph(size->face, index, FT_LOAD_DEFAULT) == 0) { + if (pFT_Load_Glyph(size->face, index, FT_LOAD_NO_BITMAP) == 0) { FT_Outline *outline = &size->face->glyph->outline; short count; FT_Matrix m;

1 0

Dmitry Timoshkov : advapi32: Add CreatePrivateObjectSecurityWithMultipleInheritance semi-stub.
by Alexandre Julliard 12 Oct '15

12 Oct '15

Module: wine Branch: master Commit: d2f0bc2f74b7899aac4308d0a886d0447ab6b32a URL: http://source.winehq.org/git/wine.git/?a=commit;h=d2f0bc2f74b7899aac4308d0a… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Fri Oct 9 18:21:21 2015 +0800 advapi32: Add CreatePrivateObjectSecurityWithMultipleInheritance semi-stub. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/advapi32.spec | 2 +- dlls/advapi32/security.c | 8 ++++++++ .../api-ms-win-downlevel-advapi32-l1-1-0.spec | 2 +- .../api-ms-win-security-base-l1-1-0.spec | 2 +- .../api-ms-win-security-base-l1-2-0.spec | 2 +- include/winbase.h | 1 + 6 files changed, 13 insertions(+), 4 deletions(-) diff --git a/dlls/advapi32/advapi32.spec b/dlls/advapi32/advapi32.spec index 8b1c0d5..ff2b0de 100644 --- a/dlls/advapi32/advapi32.spec +++ b/dlls/advapi32/advapi32.spec @@ -121,7 +121,7 @@ # @ stub CreateCodeAuthzLevel @ stdcall CreatePrivateObjectSecurity(ptr ptr ptr long long ptr) # @ stub CreatePrivateObjectSecurityEx -# @ stub CreatePrivateObjectSecurityWithMultipleInheritance +@ stdcall CreatePrivateObjectSecurityWithMultipleInheritance(ptr ptr ptr ptr long long long long ptr) @ stdcall CreateProcessAsUserA(long str str ptr ptr long long ptr str ptr ptr) # @ stub CreateProcessAsUserSecure @ stdcall CreateProcessAsUserW(long wstr wstr ptr ptr long long ptr wstr ptr ptr) diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index e8f64d5..00dafe8 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -5296,6 +5296,14 @@ BOOL WINAPI CreatePrivateObjectSecurity( return TRUE; } +BOOL WINAPI CreatePrivateObjectSecurityWithMultipleInheritance( + PSECURITY_DESCRIPTOR parent, PSECURITY_DESCRIPTOR creator, PSECURITY_DESCRIPTOR *out, + GUID **types, ULONG count, BOOL is_container, ULONG flags, HANDLE token, PGENERIC_MAPPING mapping) +{ + FIXME(": semi-stub\n"); + return CreatePrivateObjectSecurity(parent, creator, out, is_container, token, mapping); +} + BOOL WINAPI DestroyPrivateObjectSecurity( PSECURITY_DESCRIPTOR* ObjectDescriptor ) { FIXME("%p - stub\n", ObjectDescriptor); diff --git a/dlls/api-ms-win-downlevel-advapi32-l1-1-0/api-ms-win-downlevel-advapi32-l1-1-0.spec b/dlls/api-ms-win-downlevel-advapi32-l1-1-0/api-ms-win-downlevel-advapi32-l1-1-0.spec index 130f285..4105e59 100644 --- a/dlls/api-ms-win-downlevel-advapi32-l1-1-0/api-ms-win-downlevel-advapi32-l1-1-0.spec +++ b/dlls/api-ms-win-downlevel-advapi32-l1-1-0/api-ms-win-downlevel-advapi32-l1-1-0.spec @@ -27,7 +27,7 @@ @ stdcall CopySid(long ptr ptr) advapi32.CopySid @ stdcall CreatePrivateObjectSecurity(ptr ptr ptr long long ptr) advapi32.CreatePrivateObjectSecurity @ stub CreatePrivateObjectSecurityEx -@ stub CreatePrivateObjectSecurityWithMultipleInheritance +@ stdcall CreatePrivateObjectSecurityWithMultipleInheritance(ptr ptr ptr ptr long long long long ptr) advapi32.CreatePrivateObjectSecurityWithMultipleInheritance @ stdcall CreateProcessAsUserW(long wstr wstr ptr ptr long long ptr wstr ptr ptr) advapi32.CreateProcessAsUserW @ stdcall CreateRestrictedToken(long long long ptr long ptr long ptr ptr) advapi32.CreateRestrictedToken @ stdcall CreateWellKnownSid(long ptr ptr ptr) advapi32.CreateWellKnownSid diff --git a/dlls/api-ms-win-security-base-l1-1-0/api-ms-win-security-base-l1-1-0.spec b/dlls/api-ms-win-security-base-l1-1-0/api-ms-win-security-base-l1-1-0.spec index edae6d1..a44f5b8 100644 --- a/dlls/api-ms-win-security-base-l1-1-0/api-ms-win-security-base-l1-1-0.spec +++ b/dlls/api-ms-win-security-base-l1-1-0/api-ms-win-security-base-l1-1-0.spec @@ -27,7 +27,7 @@ @ stdcall CopySid(long ptr ptr) advapi32.CopySid @ stdcall CreatePrivateObjectSecurity(ptr ptr ptr long long ptr) advapi32.CreatePrivateObjectSecurity @ stub CreatePrivateObjectSecurityEx -@ stub CreatePrivateObjectSecurityWithMultipleInheritance +@ stdcall CreatePrivateObjectSecurityWithMultipleInheritance(ptr ptr ptr ptr long long long long ptr) advapi32.CreatePrivateObjectSecurityWithMultipleInheritance @ stdcall CreateRestrictedToken(long long long ptr long ptr long ptr ptr) advapi32.CreateRestrictedToken @ stdcall CreateWellKnownSid(long ptr ptr ptr) advapi32.CreateWellKnownSid @ stdcall DeleteAce(ptr long) advapi32.DeleteAce diff --git a/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec b/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec index e19fe53..02e3b9a 100644 --- a/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec +++ b/dlls/api-ms-win-security-base-l1-2-0/api-ms-win-security-base-l1-2-0.spec @@ -31,7 +31,7 @@ @ stdcall CopySid(long ptr ptr) advapi32.CopySid @ stdcall CreatePrivateObjectSecurity(ptr ptr ptr long long ptr) advapi32.CreatePrivateObjectSecurity @ stub CreatePrivateObjectSecurityEx -@ stub CreatePrivateObjectSecurityWithMultipleInheritance +@ stdcall CreatePrivateObjectSecurityWithMultipleInheritance(ptr ptr ptr ptr long long long long ptr) advapi32.CreatePrivateObjectSecurityWithMultipleInheritance @ stdcall CreateRestrictedToken(long long long ptr long ptr long ptr ptr) advapi32.CreateRestrictedToken @ stdcall CreateWellKnownSid(long ptr ptr ptr) advapi32.CreateWellKnownSid @ stdcall DeleteAce(ptr long) advapi32.DeleteAce diff --git a/include/winbase.h b/include/winbase.h index b42bc0d..dd320c2 100644 --- a/include/winbase.h +++ b/include/winbase.h @@ -1771,6 +1771,7 @@ WINBASEAPI HANDLE WINAPI CreateNamedPipeW(LPCWSTR,DWORD,DWORD,DWORD,DWORD,D #define CreateNamedPipe WINELIB_NAME_AW(CreateNamedPipe) WINBASEAPI BOOL WINAPI CreatePipe(PHANDLE,PHANDLE,LPSECURITY_ATTRIBUTES,DWORD); WINADVAPI BOOL WINAPI CreatePrivateObjectSecurity(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR*,BOOL,HANDLE,PGENERIC_MAPPING); +WINADVAPI BOOL WINAPI CreatePrivateObjectSecurityWithMultipleInheritance(PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR,PSECURITY_DESCRIPTOR*,GUID**,ULONG,BOOL,ULONG,HANDLE,PGENERIC_MAPPING); WINBASEAPI PTP_POOL WINAPI CreateThreadpool(PVOID); WINBASEAPI PTP_WORK WINAPI CreateThreadpoolWork(PTP_WORK_CALLBACK,PVOID,PTP_CALLBACK_ENVIRON); WINBASEAPI BOOL WINAPI CreateProcessA(LPCSTR,LPSTR,LPSECURITY_ATTRIBUTES,LPSECURITY_ATTRIBUTES,BOOL,DWORD,LPVOID,LPCSTR,LPSTARTUPINFOA,LPPROCESS_INFORMATION);

1 0

Alistair Leslie-Hughes : gdiplus: Add GdipCreateEffect tests.
by Alexandre Julliard 12 Oct '15

12 Oct '15

Module: wine Branch: master Commit: 71294e2a119c5a5ea4f1cde50583ef353c1ef43f URL: http://source.winehq.org/git/wine.git/?a=commit;h=71294e2a119c5a5ea4f1cde50… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Oct 9 18:07:51 2015 +1100 gdiplus: Add GdipCreateEffect tests. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdiplus/tests/image.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/dlls/gdiplus/tests/image.c b/dlls/gdiplus/tests/image.c index 1335d97..51b99a3 100644 --- a/dlls/gdiplus/tests/image.c +++ b/dlls/gdiplus/tests/image.c @@ -4629,6 +4629,47 @@ static void test_supported_encoders(void) GdipDisposeImage((GpImage *)bm); } +static void test_createeffect(void) +{ + static const GUID noneffect = { 0xcd0c3d4b, 0xe15e, 0x4cf2, { 0x9e, 0xa8, 0x6e, 0x1d, 0x65, 0x48, 0xc5, 0xa5 } }; + GpStatus (WINAPI *pGdipCreateEffect)( const GUID guid, CGpEffect **effect); + GpStatus (WINAPI *pGdipDeleteEffect)( CGpEffect *effect); + GpStatus stat; + CGpEffect *effect; + HMODULE mod = GetModuleHandleA("gdiplus.dll"); + int i; + const GUID effectlist[] = + {BlurEffectGuid, SharpenEffectGuid, ColorMatrixEffectGuid, ColorLUTEffectGuid, + BrightnessContrastEffectGuid, HueSaturationLightnessEffectGuid, LevelsEffectGuid, + TintEffectGuid, ColorBalanceEffectGuid, RedEyeCorrectionEffectGuid, ColorCurveEffectGuid}; + + pGdipCreateEffect = (void*)GetProcAddress( mod, "GdipCreateEffect"); + pGdipDeleteEffect = (void*)GetProcAddress( mod, "GdipDeleteEffect"); + if(!pGdipCreateEffect || !pGdipDeleteEffect) + { + /* GdipCreateEffect/GdipDeleteEffect was introduced in Windows Vista. */ + win_skip("GDIPlus version 1.1 not available\n"); + return; + } + + stat = pGdipCreateEffect(BlurEffectGuid, NULL); + expect(InvalidParameter, stat); + + stat = pGdipCreateEffect(noneffect, &effect); + todo_wine expect(Win32Error, stat); + + for(i=0; i < sizeof(effectlist) / sizeof(GUID); i++) + { + stat = pGdipCreateEffect(effectlist[i], &effect); + todo_wine expect(Ok, stat); + if(stat == Ok) + { + stat = pGdipDeleteEffect(effect); + expect(Ok, stat); + } + } +} + START_TEST(image) { struct GdiplusStartupInput gdiplusStartupInput; @@ -4683,6 +4724,7 @@ START_TEST(image) test_remaptable(); test_colorkey(); test_dispose(); + test_createeffect(); GdiplusShutdown(gdiplusToken); }

1 0

Alistair Leslie-Hughes : gdiplus: Add GdipCreateEffect stub.
by Alexandre Julliard 12 Oct '15

12 Oct '15

Module: wine Branch: master Commit: e5d478c79986d98dbacdb91169c4abc1fca317f2 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e5d478c79986d98dbacdb9116… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Oct 9 18:07:50 2015 +1100 gdiplus: Add GdipCreateEffect stub. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdiplus/gdiplus.spec | 2 +- dlls/gdiplus/image.c | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec index 9701ee0..edf4e45 100644 --- a/dlls/gdiplus/gdiplus.spec +++ b/dlls/gdiplus/gdiplus.spec @@ -610,7 +610,7 @@ 610 stdcall GdipFindFirstImageItem(ptr ptr) 611 stub GdipFindNextImageItem 612 stdcall GdipGetImageItemData(ptr ptr) -613 stub GdipCreateEffect +613 stdcall GdipCreateEffect(int128 ptr) 614 stdcall GdipDeleteEffect(ptr) 615 stub GdipGetEffectParameterSize 616 stub GdipGetEffectParameters diff --git a/dlls/gdiplus/image.c b/dlls/gdiplus/image.c index b99b75d..0a8027a 100644 --- a/dlls/gdiplus/image.c +++ b/dlls/gdiplus/image.c @@ -5008,6 +5008,24 @@ GpStatus WINGDIPAPI GdipCreateBitmapFromHBITMAP(HBITMAP hbm, HPALETTE hpal, GpBi return retval; } +/***************************************************************************** + * GdipCreateEffect [GDIPLUS.@] + */ +GpStatus WINGDIPAPI GdipCreateEffect(const GUID guid, CGpEffect **effect) +{ + FIXME("(%s, %p): stub\n", debugstr_guid(&guid), effect); + + if(!effect) + return InvalidParameter; + + *effect = NULL; + + return NotImplemented; +} + +/***************************************************************************** + * GdipDeleteEffect [GDIPLUS.@] + */ GpStatus WINGDIPAPI GdipDeleteEffect(CGpEffect *effect) { FIXME("(%p): stub\n", effect);

1 0

Alistair Leslie-Hughes : include: Add gdipluseffects.h.
by Alexandre Julliard 12 Oct '15

12 Oct '15

Module: wine Branch: master Commit: 447ee4cf46093242088034330bccc43a43379691 URL: http://source.winehq.org/git/wine.git/?a=commit;h=447ee4cf46093242088034330… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Fri Oct 9 18:07:49 2015 +1100 include: Add gdipluseffects.h. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/Makefile.in | 1 + include/gdiplus.h | 2 ++ include/gdipluseffects.h | 45 +++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 48 insertions(+) diff --git a/include/Makefile.in b/include/Makefile.in index 3d2c97f..c5563a2 100644 --- a/include/Makefile.in +++ b/include/Makefile.in @@ -345,6 +345,7 @@ SRCDIR_INCLUDES = \ gdiplus.h \ gdipluscolor.h \ gdipluscolormatrix.h \ + gdipluseffects.h \ gdiplusenums.h \ gdiplusflat.h \ gdiplusgpstubs.h \ diff --git a/include/gdiplus.h b/include/gdiplus.h index f063b3e..e85343b 100644 --- a/include/gdiplus.h +++ b/include/gdiplus.h @@ -37,6 +37,7 @@ namespace Gdiplus #include "gdipluscolor.h" #include "gdipluscolormatrix.h" #include "gdiplusgpstubs.h" +#include "gdipluseffects.h" namespace DllExports { @@ -57,6 +58,7 @@ namespace Gdiplus #include "gdipluscolor.h" #include "gdipluscolormatrix.h" #include "gdiplusgpstubs.h" +#include "gdipluseffects.h" #include "gdiplusflat.h" diff --git a/include/gdipluseffects.h b/include/gdipluseffects.h new file mode 100644 index 0000000..d2d6a05 --- /dev/null +++ b/include/gdipluseffects.h @@ -0,0 +1,45 @@ +/* + * Copyright (C) 2015 Alistair Leslie-Hughes + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#ifndef _GDIPLUSEFFECTS_H +#define _GDIPLUSEFFECTS_H + +DEFINE_GUID(BlurEffectGuid, 0x633c80a4, 0x1843, 0x482b, 0x9e, 0xf2, 0xbe, 0x28, 0x34, 0xc5, 0xfd, 0xd4); +DEFINE_GUID(SharpenEffectGuid, 0x63cbf3ee, 0xc526, 0x402c, 0x8f, 0x71, 0x62, 0xc5, 0x40, 0xbf, 0x51, 0x42); +DEFINE_GUID(ColorMatrixEffectGuid, 0x718f2615, 0x7933, 0x40e3, 0xa5, 0x11, 0x5f, 0x68, 0xfe, 0x14, 0xdd, 0x74); +DEFINE_GUID(ColorLUTEffectGuid, 0xa7ce72a9, 0x0f7f, 0x40d7, 0xb3, 0xcc, 0xd0, 0xc0, 0x2d, 0x5c, 0x32, 0x12); +DEFINE_GUID(BrightnessContrastEffectGuid, 0xd3a1dbe1, 0x8ec4, 0x4c17, 0x9f, 0x4c, 0xea, 0x97, 0xad, 0x1c, 0x34, 0x3d); +DEFINE_GUID(HueSaturationLightnessEffectGuid, 0x8b2dd6c3, 0xeb07, 0x4d87, 0xa5, 0xf0, 0x71, 0x08, 0xe2, 0x6a, 0x9c, 0x5f); +DEFINE_GUID(LevelsEffectGuid, 0x99c354ec, 0x2a31, 0x4f3a, 0x8c, 0x34, 0x17, 0xa8, 0x03, 0xb3, 0x3a, 0x25); +DEFINE_GUID(TintEffectGuid, 0x1077af00, 0x2848, 0x4441, 0x94, 0x89, 0x44, 0xad, 0x4c, 0x2d, 0x7a, 0x2c); +DEFINE_GUID(ColorBalanceEffectGuid, 0x537e597d, 0x251e, 0x48da, 0x96, 0x64, 0x29, 0xca, 0x49, 0x6b, 0x70, 0xf8); +DEFINE_GUID(RedEyeCorrectionEffectGuid, 0x74d29d05, 0x69a4, 0x4266, 0x95, 0x49, 0x3c, 0xc5, 0x28, 0x36, 0xb6, 0x32); +DEFINE_GUID(ColorCurveEffectGuid, 0xdd6a0022, 0x58e4, 0x4a67, 0x9d, 0x9b, 0xd4, 0x8e, 0xb8, 0x81, 0xa5, 0x3d); + +#ifdef __cplusplus +extern "C" { +#endif + +GpStatus WINGDIPAPI GdipCreateEffect(const GUID guid, CGpEffect **effect); +GpStatus WINGDIPAPI GdipDeleteEffect(CGpEffect *effect); + +#ifdef __cplusplus +} +#endif + +#endif

1 0

Sebastian Lackner : gdiplus: Do not use GdipAlloc and GdipFree in internal functions.
by Alexandre Julliard 12 Oct '15

12 Oct '15

Module: wine Branch: master Commit: aa70a90c6ef8c746b868990d0cd11ca013beef58 URL: http://source.winehq.org/git/wine.git/?a=commit;h=aa70a90c6ef8c746b868990d0… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Mon Oct 5 00:22:34 2015 +0200 gdiplus: Do not use GdipAlloc and GdipFree in internal functions. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdiplus/brush.c | 158 ++++++++++++++++++++-------------------- dlls/gdiplus/customlinecap.c | 30 ++++---- dlls/gdiplus/font.c | 26 +++---- dlls/gdiplus/gdiplus.c | 10 +-- dlls/gdiplus/gdiplus_private.h | 11 +++ dlls/gdiplus/graphics.c | 160 ++++++++++++++++++++--------------------- dlls/gdiplus/graphicspath.c | 132 +++++++++++++++++----------------- dlls/gdiplus/image.c | 126 ++++++++++++++++---------------- dlls/gdiplus/imageattributes.c | 12 ++-- dlls/gdiplus/matrix.c | 18 ++--- dlls/gdiplus/metafile.c | 26 +++---- dlls/gdiplus/pathiterator.c | 12 ++-- dlls/gdiplus/pen.c | 18 ++--- dlls/gdiplus/region.c | 68 +++++++++--------- dlls/gdiplus/stringformat.c | 26 +++---- 15 files changed, 422 insertions(+), 411 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=aa70a90c6ef8c746b8689…

1 0

Alexandre Julliard : patches: Send notification emails on patch status change.
by Alexandre Julliard 12 Oct '15

12 Oct '15

Module: tools Branch: master Commit: 03e4c1bd866a6c61e46679622e611bdd45e534c3 URL: http://source.winehq.org/git/tools.git/?a=commit;h=03e4c1bd866a6c61e4667962… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Oct 8 21:35:13 2015 +0900 patches: Send notification emails on patch status change. --- patches/expire | 189 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 188 insertions(+), 1 deletion(-) diff --git a/patches/expire b/patches/expire index a3b99c1..0f26d8a 100755 --- a/patches/expire +++ b/patches/expire @@ -43,6 +43,94 @@ my %status_expiry = "testfail" => 7, ); +my %status_descr = +( + "nil" => "New", + "pending" => "Pending", + "applied" => "Applied", + "committed" => "Committed", + "applyfail" => "Apply failure", + "buildfail" => "Build failure", + "deferred" => "Deferred", + "formatting" => "Formatting", + "other" => "Other project", + "nopatch" => "No patch", + "rejected" => "Rejected", + "split" => "Needs splitting", + "depend" => "Dependency", + "sequence" => "Bad sequence", + "signoff" => "Sign-off", + "superseded" => "Superseded", + "testcase" => "Needs tests", + "testfail" => "Test failure", +); + +my %status_explanation = +( + "pending" => +"This means that the patch is not necessarily wrong, but its +correctness is not obvious. You should either write a test case +demonstrating that it is correct, try to fix the problem in a more +straightforward way, or better explain why you are doing things this +way.", + "committed" => +"This means that your patch has been approved, and committed to the +main git tree. Congratulations!", + "applyfail" => +"This means that git-apply refused to apply the patch. This could be +either because it got mangled in transit, it's not relative to the +latest git, or it conflicts with someone else's patch in the same +area. You need to resend an updated patch.", + "buildfail" => +"This means that the patched code doesn't compile. It could also be +because you forgot to include some changes or new files required for +compilation, or that the patch causes compiler warnings (maintainer +mode implies -Werror). You need to resend a fixed patch.", + "deferred" => +"This means that the patch is deferred because of code freeze for an +upcoming release. You need to either resend after the release, make +the patch less intrusive, or make a convincing argument that it needs +to be included in the release.", + "formatting" => +"This means that there are some formatting issues with your +patch. Either the author's full name, email address, or Signed-off-by +headers are missing, indentation is messed up (usually from editing +with a non-standard tab size), or there are gratuitous formatting +changes to the code. You need to resend a fixed patch.", + "other" => +"This means that the patch belongs to another WineHQ project (website, +appdb, etc.) and will be applied by the respective maintainer.", + "nopatch" => +"This means that no patch was found in your mail.", + "rejected" => +"This means that the patch has been rejected by a reviewer. You should +have received a mail explaining why it was rejected. You need to fix +the issue and resend the patch, or if you are convinced that your +patch is good as is, you should reply to the rejection message with +your counterarguments.", + "split" => +"This means that the patch needs to be split, either because it +contains unrelated changes that should be their own separate patch, or +because it's too large for review. You need to find a way to resend +the changes in smaller chunks.", + "depend" => +"This means that the patch is part of a series in which a previous +patch hasn't been applied. You need to resend when the dependent patch +is fixed.", + "sequence" => +"This means that the patch is part of a series but it's not correctly +numbered. You need to resend the series with correct sequence numbers +to enable the Testbot to figure it out.", + "testcase" => +"This means that you need to write some test cases demonstrating that +the patch is correct.", +# No notifications are sent for the following: +# "nil" +# "signoff" +# "superseded" +# "testfail" +); + sub usage() { print STDERR "Usage: $0 [-n] [-v] [directory]\n"; @@ -53,6 +141,7 @@ my $dir = "."; my $dry_run = 0; my $quiet = 1; my $now = time(); +my $email_from = "Marvin <testbot\(a)winehq.org>"; foreach my $arg (@ARGV) { @@ -100,15 +189,112 @@ sub get_patch_state($) return ($status, $mtime); } +sub get_previous_state($) +{ + my $file = shift; + my $prev_status = "nil"; + + if (open PREVSTATUS, "<$dir/OLD/$file.status") + { + $prev_status = <PREVSTATUS>; + chomp $prev_status; + close PREVSTATUS; + } + return $prev_status; +} + +sub get_notify_headers($$) +{ + my $file = shift; + my $status = shift; + my @headers; + + return () unless open PATCH, "<$dir/$file"; + + push @headers, "From: $email_from"; + + while (<PATCH>) + { + if (/^Subject: (.*)$/) + { + my $subject = $1; + $subject = "Re: " . $subject unless $subject =~ /^[Rr][Ee]: /; + push @headers, "Subject: $subject"; + } + elsif (/^From: (.*)$/) + { + push @headers, "To: $1"; + } + elsif (/^Message-Id: (.*)$/) + { + push @headers, "In-Reply-To: $1"; + push @headers, "References: $1"; + } + last if (/^$/); + } + close PATCH; + + push @headers, "X-Patch-Status: $status_descr{$status}"; + push @headers, "X-Patch-URL: https://source.winehq.org/patches/data/$file"; + push @headers, "Reply-To: wine-devel\(a)winehq.org"; + return @headers; +} + +sub notify_state_change($$$) +{ + my $file = shift; + my $prev_status = shift; + my $status = shift; + + return if $prev_status eq $status; + + printf "file %s status changed %s -> %s\n", $file, $prev_status, $status unless $quiet; + + # if there's no available explanation, don't notify + return unless defined $status_explanation{$status}; + + my @headers = get_notify_headers( $file, $status ); + return unless @headers; + + open PREVSTATUS, ">$dir/OLD/$file.status" or return; + printf PREVSTATUS "%s\n", $status; + close PREVSTATUS; + + open SENDMAIL, "|/usr/sbin/sendmail -oi -t -odq" or return; + print SENDMAIL join("\n", @headers), "\n\n"; + print SENDMAIL <<"EOF"; +Thank you for your contribution to Wine! + +This is an automated notification to let you know that your patch has +been reviewed and its status set to "$status_descr{$status}". + +$status_explanation{$status} +EOF + + if ($status ne "committed") + { + print SENDMAIL <<"EOF"; + +If you do not understand the reason for this status, disagree with our +assessment, or are simply not sure how to proceed next, please ask for +clarification by replying to this email. +EOF + } + close SENDMAIL; +} + # expire current patches opendir DIR, $dir or die "cannot open '$dir': $!\n"; foreach my $file (sort readdir DIR) { next unless $file =~ /^[0-9]+$/; - my ($status, $mtime) = get_patch_state( "$file" ); + my ($status, $mtime) = get_patch_state( $file ); + my $prev_status = get_previous_state( $file ); my $limit = $status_expiry{$status} || 7; + notify_state_change( $file, $prev_status, $status ); + if (($now - $mtime - 12*60*60) / (24*60*60) > $limit) { if ($status eq "nil" || $status eq "pending") @@ -136,6 +322,7 @@ foreach my $file (sort readdir DIR) unlink "$dir/$file.signoff"; unlink "$dir/$file.testbot"; unlink "$dir/$file.testfail"; + unlink "$dir/OLD/$file.status"; } } }

1 0

Alexandre Julliard : patches: Separate parsing of headers and mail body.
by Alexandre Julliard 12 Oct '15

12 Oct '15

Module: tools Branch: master Commit: 400ba40298a73d7c4f39f690658bfd9703516a49 URL: http://source.winehq.org/git/tools.git/?a=commit;h=400ba40298a73d7c4f39f690… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Oct 8 00:03:59 2015 +0900 patches: Separate parsing of headers and mail body. --- patches/update | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/patches/update b/patches/update index aa8d8c9..a11d17e 100755 --- a/patches/update +++ b/patches/update @@ -131,7 +131,11 @@ foreach my $file (readdir DIR) { if (/^Subject: (.*)$/) { $patch{"subject"} = $1; } elsif (/^From: (.*)$/) { $patch{"author"} = format_author($1); } - elsif (/^Signed-off-by: (.*)$/) { push @{$patch{"signoff"}}, format_author($1); } + last if (/^$/); + } + while (<PATCH>) + { + if (/^\s*Signed-off-by: (.*)$/) { push @{$patch{"signoff"}}, format_author($1); } last if (/^---$/); } close PATCH;

1 0

Alexandre Julliard : xaudio2_7: Fix a typo.
by Alexandre Julliard 09 Oct '15

09 Oct '15

Module: wine Branch: master Commit: d548639d977dee847350b408aec9522d68aef813 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d548639d977dee847350b408a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Fri Oct 9 23:23:17 2015 +0900 xaudio2_7: Fix a typo. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/xaudio2_7/xaudio_dll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c index feab321..76d9503 100644 --- a/dlls/xaudio2_7/xaudio_dll.c +++ b/dlls/xaudio2_7/xaudio_dll.c @@ -2489,7 +2489,7 @@ static IClassFactory *make_xaudio2_factory(DWORD version) static IClassFactory *make_xapo_factory(REFCLSID clsid, DWORD version) { struct xapo_cf *ret = HeapAlloc(GetProcessHeap(), 0, sizeof(struct xaudio2_cf)); - ret->IClassFactory_iface.lpVtbl = &XAudio2CF_Vtbl; + ret->IClassFactory_iface.lpVtbl = &xapo_Vtbl; ret->version = version; ret->class = clsid; ret->ref = 0;

1 0

Alistair Leslie-Hughes : oledberr.h: Add more defines.
by Alexandre Julliard 09 Oct '15

09 Oct '15

Module: wine Branch: master Commit: c94a16cfe1ac8879d979dd0ac2b6922fdeda6a41 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c94a16cfe1ac8879d979dd0ac… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Thu Oct 8 20:06:17 2015 +1100 oledberr.h: Add more defines. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/oledberr.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/include/oledberr.h b/include/oledberr.h index 96adcae..8af38ef 100644 --- a/include/oledberr.h +++ b/include/oledberr.h @@ -23,6 +23,11 @@ #define DB_E_BADBINDINFO 0x80040e08 +#define DB_E_ERRORSINCOMMAND 0x80040e14 +#define DB_E_CANTCANCEL 0x80040e15 +#define DB_E_DIALECTNOTSUPPORTED 0x80040e16 +#define DB_E_DUPLICATEDATASOURCE 0x80040e17 +#define DB_E_CANNOTRESTART 0x80040e18 #define DB_E_NOTFOUND 0x80040e19 #define DB_E_UNSUPPORTEDCONVERSION 0x80040e1d

1 0

← Newer
1
...
45
46
47
48
49
50
51
...
75
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits October 2015