wine-commits November 2015

wine-commits@winehq.org

2 participants
623 discussions

Andrey Gusev : wine.inf: Add HKLM\Software\Microsoft\MediaPlayer\Installation DirectoryLFN key.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: 6b97ce5bf00756f2a6835512e6e496b26c0dd043 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6b97ce5bf00756f2a6835512e… Author: Andrey Gusev <andrey.goosev(a)gmail.com> Date: Mon Nov 16 12:54:37 2015 +0200 wine.inf: Add HKLM\Software\Microsoft\MediaPlayer\Installation DirectoryLFN key. Signed-off-by: Andrey Gusev <andrey.goosev(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- loader/wine.inf.in | 1 + 1 file changed, 1 insertion(+) diff --git a/loader/wine.inf.in b/loader/wine.inf.in index e091727..c8de5f9 100644 --- a/loader/wine.inf.in +++ b/loader/wine.inf.in @@ -635,6 +635,7 @@ HKLM,Software\Microsoft\DFS,,16 HKLM,Software\Microsoft\Driver Signing,,16 HKLM,Software\Microsoft\EnterpriseCertificates,,16 HKLM,Software\Microsoft\EventSystem,,16 +HKLM,Software\Microsoft\MediaPlayer,"Installation DirectoryLFN",2,"%16422%\Windows Media Player" HKLM,Software\Microsoft\MediaPlayer\PlayerUpgrade,"PlayerVersion",2,"12,0,7601,18840" HKLM,Software\Microsoft\MSMQ,,16 HKLM,Software\Microsoft\Non-Driver Signing,,16

1 0

Hugh McMaster : cmd: Set colour attributes when clearing the screen with ' cls'.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: ca8b3843abc7407212ec83c2d70d7a09bbb70ba3 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ca8b3843abc7407212ec83c2d… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Mon Nov 16 11:53:06 2015 +1100 cmd: Set colour attributes when clearing the screen with 'cls'. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/cmd/builtins.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c index e9b9ddd..22f0580 100644 --- a/programs/cmd/builtins.c +++ b/programs/cmd/builtins.c @@ -236,13 +236,14 @@ void WCMD_clear_screen (void) { if (GetConsoleScreenBufferInfo(hStdOut, &consoleInfo)) { COORD topLeft; - DWORD screenSize; + DWORD screenSize, written; screenSize = consoleInfo.dwSize.X * (consoleInfo.dwSize.Y + 1); topLeft.X = 0; topLeft.Y = 0; - FillConsoleOutputCharacterW(hStdOut, ' ', screenSize, topLeft, &screenSize); + FillConsoleOutputCharacterW(hStdOut, ' ', screenSize, topLeft, &written); + FillConsoleOutputAttribute(hStdOut, consoleInfo.wAttributes, screenSize, topLeft, &written); SetConsoleCursorPosition(hStdOut, topLeft); } }

1 0

Hugh McMaster : reg/tests: Fix the add empty type test.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: 9e4e1cf9be9dd1f71879bb85eb003b021c652096 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9e4e1cf9be9dd1f71879bb85e… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Mon Nov 16 11:53:07 2015 +1100 reg/tests: Fix the add empty type test. The exit code of this test will always be REG_EXIT_FAILURE, so the return code is neither broken nor todo_wine. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/reg/tests/reg.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/programs/reg/tests/reg.c b/programs/reg/tests/reg.c index 2880d37..4981bdd 100644 --- a/programs/reg/tests/reg.c +++ b/programs/reg/tests/reg.c @@ -110,12 +110,7 @@ static void test_add(void) /* Test empty type */ run_reg_exe("reg add HKCU\\" KEY_BASE " /v emptyType /t \"\" /d WineTest /f", &r); - todo_wine ok(r == REG_EXIT_SUCCESS || broken(r == REG_EXIT_FAILURE /* WinXP */), - "got exit code %u\n", r); - if (r == REG_EXIT_SUCCESS) - todo_wine verify_reg(hkey, "emptyType", REG_SZ, "", 1, 0); - else - todo_wine win_skip("broken reg.exe detected\n"); + ok(r == REG_EXIT_FAILURE, "got exit code %u\n", r); /* Test input key formats */ run_reg_exe("reg add \\HKCU\\" KEY_BASE "\\keytest0 /f", &r);

1 0

Sebastian Lackner : server: Do not require SeBackupPrivilege in load_registry and unload_registry.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: 96f4f53937915955063865d2949265d8d1576794 URL: http://source.winehq.org/git/wine.git/?a=commit;h=96f4f53937915955063865d29… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Mon Nov 16 08:32:29 2015 +0100 server: Do not require SeBackupPrivilege in load_registry and unload_registry. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/tests/registry.c | 109 ++++++++++++++++++++++++----------------- server/registry.c | 20 +------- 2 files changed, 65 insertions(+), 64 deletions(-) diff --git a/dlls/advapi32/tests/registry.c b/dlls/advapi32/tests/registry.c index 8808822..254a8b6 100644 --- a/dlls/advapi32/tests/registry.c +++ b/dlls/advapi32/tests/registry.c @@ -1513,39 +1513,6 @@ static void test_reg_delete_key(void) RegCloseKey(key); } -static void test_reg_save_key(void) -{ - DWORD ret; - - ret = RegSaveKeyA(hkey_main, "saved_key", NULL); - ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); -} - -static void test_reg_load_key(void) -{ - DWORD ret; - HKEY hkHandle; - - ret = RegLoadKeyA(HKEY_LOCAL_MACHINE, "Test", "saved_key"); - ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); - - ret = RegOpenKeyA(HKEY_LOCAL_MACHINE, "Test", &hkHandle); - ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); - - RegCloseKey(hkHandle); -} - -static void test_reg_unload_key(void) -{ - DWORD ret; - - ret = RegUnLoadKeyA(HKEY_LOCAL_MACHINE, "Test"); - ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); - - DeleteFileA("saved_key"); - DeleteFileA("saved_key.LOG"); -} - static BOOL set_privileges(LPCSTR privilege, BOOL set) { TOKEN_PRIVILEGES tp; @@ -1580,6 +1547,66 @@ static BOOL set_privileges(LPCSTR privilege, BOOL set) return TRUE; } +static void test_reg_save_key(void) +{ + DWORD ret; + + if (!set_privileges(SE_BACKUP_NAME, TRUE) || + !set_privileges(SE_RESTORE_NAME, FALSE)) + { + win_skip("Failed to set SE_BACKUP_NAME privileges, skipping tests\n"); + return; + } + + ret = RegSaveKeyA(hkey_main, "saved_key", NULL); + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); + + set_privileges(SE_BACKUP_NAME, FALSE); +} + +static void test_reg_load_key(void) +{ + DWORD ret; + HKEY hkHandle; + + if (!set_privileges(SE_RESTORE_NAME, TRUE) || + !set_privileges(SE_BACKUP_NAME, FALSE)) + { + win_skip("Failed to set SE_RESTORE_NAME privileges, skipping tests\n"); + return; + } + + ret = RegLoadKeyA(HKEY_LOCAL_MACHINE, "Test", "saved_key"); + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); + + set_privileges(SE_RESTORE_NAME, FALSE); + + ret = RegOpenKeyA(HKEY_LOCAL_MACHINE, "Test", &hkHandle); + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); + + RegCloseKey(hkHandle); +} + +static void test_reg_unload_key(void) +{ + DWORD ret; + + if (!set_privileges(SE_RESTORE_NAME, TRUE) || + !set_privileges(SE_BACKUP_NAME, FALSE)) + { + win_skip("Failed to set SE_RESTORE_NAME privileges, skipping tests\n"); + return; + } + + ret = RegUnLoadKeyA(HKEY_LOCAL_MACHINE, "Test"); + ok(ret == ERROR_SUCCESS, "expected ERROR_SUCCESS, got %d\n", ret); + + set_privileges(SE_RESTORE_NAME, FALSE); + + DeleteFileA("saved_key"); + DeleteFileA("saved_key.LOG"); +} + /* tests that show that RegConnectRegistry and OpenSCManager accept computer names without the \\ prefix (what MSDN says). */ @@ -3275,19 +3302,9 @@ START_TEST(registry) test_classesroot(); test_classesroot_enum(); test_classesroot_mask(); - - /* SaveKey/LoadKey require the SE_BACKUP_NAME privilege to be set */ - if (set_privileges(SE_BACKUP_NAME, TRUE) && - set_privileges(SE_RESTORE_NAME, TRUE)) - { - test_reg_save_key(); - test_reg_load_key(); - test_reg_unload_key(); - - set_privileges(SE_BACKUP_NAME, FALSE); - set_privileges(SE_RESTORE_NAME, FALSE); - } - + test_reg_save_key(); + test_reg_load_key(); + test_reg_unload_key(); test_reg_delete_tree(); test_rw_order(); test_deleted_key(); diff --git a/server/registry.c b/server/registry.c index c95e103..a3c1390 100644 --- a/server/registry.c +++ b/server/registry.c @@ -2182,17 +2182,9 @@ DECL_HANDLER(delete_key_value) DECL_HANDLER(load_registry) { struct key *key, *parent; - struct token *token = thread_get_impersonation_token( current ); struct unicode_str name; - const LUID_AND_ATTRIBUTES privs[] = - { - { SeBackupPrivilege, 0 }, - { SeRestorePrivilege, 0 }, - }; - - if (!token || !token_check_privileges( token, TRUE, privs, - sizeof(privs)/sizeof(privs[0]), NULL )) + if (!thread_single_check_privilege( current, &SeRestorePrivilege )) { set_error( STATUS_PRIVILEGE_NOT_HELD ); return; @@ -2214,16 +2206,8 @@ DECL_HANDLER(load_registry) DECL_HANDLER(unload_registry) { struct key *key; - struct token *token = thread_get_impersonation_token( current ); - - const LUID_AND_ATTRIBUTES privs[] = - { - { SeBackupPrivilege, 0 }, - { SeRestorePrivilege, 0 }, - }; - if (!token || !token_check_privileges( token, TRUE, privs, - sizeof(privs)/sizeof(privs[0]), NULL )) + if (!thread_single_check_privilege( current, &SeRestorePrivilege )) { set_error( STATUS_PRIVILEGE_NOT_HELD ); return;

1 0

Andrew Nguyen : dinput: Allow EnumDevices callback functions with broken calling conventions.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: 6566cd76ce56cc2cfca16123b16a286f02d27327 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6566cd76ce56cc2cfca16123b… Author: Andrew Nguyen <arethusa26(a)gmail.com> Date: Mon Nov 16 08:25:45 2015 +0100 dinput: Allow EnumDevices callback functions with broken calling conventions. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/dinput_main.c | 23 +++++++++++++++++++++-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/dlls/dinput/dinput_main.c b/dlls/dinput/dinput_main.c index aef9d10..24e7951 100644 --- a/dlls/dinput/dinput_main.c +++ b/dlls/dinput/dinput_main.c @@ -339,6 +339,25 @@ static DWORD diactionformat_priorityW(LPDIACTIONFORMATW lpdiaf, DWORD genre) return priorityFlags; } +#ifdef __i386__ +extern BOOL enum_callback_wrapper(void *callback, const void *instance, void *ref); +__ASM_GLOBAL_FUNC( enum_callback_wrapper, + "pushl %ebp\n\t" + __ASM_CFI(".cfi_adjust_cfa_offset 4\n\t") + __ASM_CFI(".cfi_rel_offset %ebp,0\n\t") + "movl %esp,%ebp\n\t" + __ASM_CFI(".cfi_def_cfa_register %ebp\n\t") + "pushl 16(%ebp)\n\t" + "pushl 12(%ebp)\n\t" + "call *8(%ebp)\n\t" + "leave\n\t" + __ASM_CFI(".cfi_def_cfa %esp,4\n\t") + __ASM_CFI(".cfi_same_value %ebp\n\t") + "ret" ) +#else +#define enum_callback_wrapper(callback, instance, ref) (callback)((instance), (ref)) +#endif + /****************************************************************************** * IDirectInputA_EnumDevices */ @@ -371,7 +390,7 @@ static HRESULT WINAPI IDirectInputAImpl_EnumDevices( TRACE(" - checking device %u ('%s')\n", i, dinput_devices[i]->name); r = dinput_devices[i]->enum_deviceA(dwDevType, dwFlags, &devInstance, This->dwVersion, j); if (r == S_OK) - if (lpCallback(&devInstance,pvRef) == DIENUM_STOP) + if (enum_callback_wrapper(lpCallback, &devInstance, pvRef) == DIENUM_STOP) return S_OK; } } @@ -411,7 +430,7 @@ static HRESULT WINAPI IDirectInputWImpl_EnumDevices( TRACE(" - checking device %u ('%s')\n", i, dinput_devices[i]->name); r = dinput_devices[i]->enum_deviceW(dwDevType, dwFlags, &devInstance, This->dwVersion, j); if (r == S_OK) - if (lpCallback(&devInstance,pvRef) == DIENUM_STOP) + if (enum_callback_wrapper(lpCallback, &devInstance, pvRef) == DIENUM_STOP) return S_OK; } }

1 0

Vincent Povirk : setupapi: Add a manifest to indicate the tests don' t need elevation.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: 295346f81d05e7669c512aec278fa9ea25b0f983 URL: http://source.winehq.org/git/wine.git/?a=commit;h=295346f81d05e7669c512aec2… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Sun Nov 15 20:23:28 2015 -0600 setupapi: Add a manifest to indicate the tests don't need elevation. Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/setupapi/tests/Makefile.in | 2 ++ dlls/setupapi/tests/setupapi.manifest | 11 +++++++++++ dlls/setupapi/tests/setupapi.rc | 25 +++++++++++++++++++++++++ 3 files changed, 38 insertions(+) diff --git a/dlls/setupapi/tests/Makefile.in b/dlls/setupapi/tests/Makefile.in index 30902e7..083e576 100644 --- a/dlls/setupapi/tests/Makefile.in +++ b/dlls/setupapi/tests/Makefile.in @@ -10,3 +10,5 @@ C_SRCS = \ query.c \ setupcab.c \ stringtable.c + +RC_SRCS = setupapi.rc diff --git a/dlls/setupapi/tests/setupapi.manifest b/dlls/setupapi/tests/setupapi.manifest new file mode 100644 index 0000000..d0e3692 --- /dev/null +++ b/dlls/setupapi/tests/setupapi.manifest @@ -0,0 +1,11 @@ +<?xml version="1.0" encoding="UTF-8" standalone="yes"?> +<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0"> + <assemblyIdentity type="win32" name="Wine.SetupapiTest" version="0.0.0.0"/> + <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3"> + <security> + <requestedPrivileges> + <requestedExecutionLevel level="asInvoker" uiAccess="false"/> + </requestedPrivileges> + </security> + </trustInfo> +</assembly> diff --git a/dlls/setupapi/tests/setupapi.rc b/dlls/setupapi/tests/setupapi.rc new file mode 100644 index 0000000..3af9a20 --- /dev/null +++ b/dlls/setupapi/tests/setupapi.rc @@ -0,0 +1,25 @@ +/* + * setupapi test resources + * + * Copyright 2015 Vincent Povirk + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + * + */ + +#include <winuser.rh> + +/* @makedep: setupapi.manifest */ +1 RT_MANIFEST setupapi.manifest

1 0

Nikolay Sivov : winmm: Initialize AUXCAPSA.wReserved1 returned from auxGetDevCapsA() (Coverity).
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: 349f834976770baf6646ff812a807706d6e0c534 URL: http://source.winehq.org/git/wine.git/?a=commit;h=349f834976770baf6646ff812… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Nov 16 02:42:40 2015 +0300 winmm: Initialize AUXCAPSA.wReserved1 returned from auxGetDevCapsA() (Coverity). Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/winmm/winmm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/winmm/winmm.c b/dlls/winmm/winmm.c index 43f7268..a626a79 100644 --- a/dlls/winmm/winmm.c +++ b/dlls/winmm/winmm.c @@ -229,6 +229,7 @@ UINT WINAPI auxGetDevCapsA(UINT_PTR uDeviceID, LPAUXCAPSA lpCaps, UINT uSize) WideCharToMultiByte( CP_ACP, 0, acW.szPname, -1, acA.szPname, sizeof(acA.szPname), NULL, NULL ); acA.wTechnology = acW.wTechnology; + acA.wReserved1 = 0; acA.dwSupport = acW.dwSupport; memcpy(lpCaps, &acA, min(uSize, sizeof(acA))); }

1 0

Nikolay Sivov : kernel32: Fix context initialization for EnumDateFormatsExEx.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: e528765af4a353b820ef390b7030173cbc451c18 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e528765af4a353b820ef390b7… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Mon Nov 16 01:10:04 2015 +0300 kernel32: Fix context initialization for EnumDateFormatsExEx. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/lcformat.c | 1 + 1 file changed, 1 insertion(+) diff --git a/dlls/kernel32/lcformat.c b/dlls/kernel32/lcformat.c index 0985e35..c8a9746 100644 --- a/dlls/kernel32/lcformat.c +++ b/dlls/kernel32/lcformat.c @@ -1916,6 +1916,7 @@ BOOL WINAPI EnumDateFormatsExEx(DATEFMT_ENUMPROCEXEX proc, const WCHAR *locale, ctxt.lcid = LocaleNameToLCID(locale, 0); ctxt.flags = flags; ctxt.lParam = lParam; + ctxt.unicode = TRUE; return NLS_EnumDateFormats(&ctxt); }

1 0

Nikolay Sivov : user32/tests: Use separate test window for each scrollbar test.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: f7468386a78fb72556fcafafba0fc8f9b5ef0c34 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f7468386a78fb72556fcafafb… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Nov 15 22:37:24 2015 +0300 user32/tests: Use separate test window for each scrollbar test. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/user32/tests/scroll.c | 77 +++++++++++++++++++++++++++++++--------------- 1 file changed, 53 insertions(+), 24 deletions(-) diff --git a/dlls/user32/tests/scroll.c b/dlls/user32/tests/scroll.c index df37534..41201ec 100644 --- a/dlls/user32/tests/scroll.c +++ b/dlls/user32/tests/scroll.c @@ -25,7 +25,7 @@ #include "wine/test.h" -static HWND hScroll, hMainWnd; +static HWND hScroll; static BOOL bThemeActive = FALSE; static LRESULT CALLBACK MyWndProc( HWND hWnd, UINT msg, WPARAM wParam, LPARAM lParam ) @@ -52,20 +52,45 @@ static LRESULT CALLBACK MyWndProc( HWND hWnd, UINT msg, WPARAM wParam, LPARAM lP } return 0; } + +static HWND create_main_test_wnd(void) +{ + HWND hMainWnd; + + hScroll = NULL; + hMainWnd = CreateWindowExA( 0, "MyTestWnd", "Scroll", + WS_OVERLAPPEDWINDOW|WS_VSCROLL|WS_HSCROLL, + CW_USEDEFAULT, CW_USEDEFAULT, 100, 100, NULL, NULL, GetModuleHandleA(NULL), 0 ); + ok(hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n"); + ok(hScroll != NULL, "got NULL scroll bar handle\n"); + + return hMainWnd; +} + static void scrollbar_test_track(void) { + HWND mainwnd; + + mainwnd = create_main_test_wnd(); + /* test that scrollbar tracking is terminated when * the control looses mouse capture */ SendMessageA( hScroll, WM_LBUTTONDOWN, 0, MAKELPARAM( 1, 1)); /* a normal return from the sendmessage */ /* not normal for instance by closing the windws */ ok( IsWindow( hScroll), "Scrollbar has gone!\n"); + + DestroyWindow(hScroll); + DestroyWindow(mainwnd); } -static void scrollbar_test1(void) +static void test_EnableScrollBar(void) { + HWND mainwnd; BOOL ret; + mainwnd = create_main_test_wnd(); + ret = EnableScrollBar( hScroll, SB_CTL, ESB_DISABLE_BOTH ); ok( ret, "The scrollbar should be disabled.\n" ); ok( !IsWindowEnabled( hScroll ), "The scrollbar window should be disabled.\n" ); @@ -88,13 +113,17 @@ static void scrollbar_test1(void) ret = EnableScrollBar( hScroll, SB_CTL, ESB_ENABLE_BOTH ); ok( ret, "The scrollbar should be enabled.\n" ); ok( IsWindowEnabled( hScroll ), "The scrollbar window should be enabled.\n" ); + + DestroyWindow(hScroll); + DestroyWindow(mainwnd); } -static void scrollbar_test2(void) +static void test_SetScrollPos(void) { + HWND mainwnd; int ret; - trace("The scrollbar is disabled.\n"); + mainwnd = create_main_test_wnd(); EnableWindow( hScroll, FALSE ); ok( !IsWindowEnabled( hScroll ), "The scroll should be disabled.\n" ); @@ -114,8 +143,6 @@ static void scrollbar_test2(void) ret = GetScrollPos( hScroll, SB_CTL); ok( ret == 30, "The position should be set!!!\n"); - trace("The scrollbar is enabled.\n"); - EnableWindow( hScroll, TRUE ); ok( IsWindowEnabled( hScroll ), "The scroll should be enabled.\n" ); @@ -133,12 +160,18 @@ static void scrollbar_test2(void) ret = GetScrollPos( hScroll, SB_CTL); ok( ret == 30, "The position should not be equal to zero\n"); + + DestroyWindow(hScroll); + DestroyWindow(mainwnd); } -static void scrollbar_test3(void) +static void test_ShowScrollBar(void) { + HWND mainwnd; BOOL ret; + mainwnd = create_main_test_wnd(); + ret = ShowScrollBar( hScroll, SB_CTL, FALSE ); ok( ret, "The ShowScrollBar() should not failed.\n" ); ok( !IsWindowVisible( hScroll ), "The scrollbar window should not be visible\n" ); @@ -150,10 +183,13 @@ static void scrollbar_test3(void) ret = ShowScrollBar( NULL, SB_CTL, TRUE ); ok( !ret, "The ShowScrollBar() should failed.\n" ); + DestroyWindow(hScroll); + DestroyWindow(mainwnd); } -static void scrollbar_test4(void) +static void test_GetScrollBarInfo(void) { + HWND hMainWnd; BOOL ret; SCROLLBARINFO sbi; RECT rect; @@ -166,6 +202,8 @@ static void scrollbar_test4(void) return; } + hMainWnd = create_main_test_wnd(); + /* Test GetScrollBarInfo to make sure it returns rcScrollBar in screen * coordinates. */ sbi.cbSize = sizeof(sbi); @@ -218,6 +256,9 @@ static void scrollbar_test4(void) rect.top, rect.left, rect.bottom, rect.right, sbi.rcScrollBar.top, sbi.rcScrollBar.left, sbi.rcScrollBar.bottom, sbi.rcScrollBar.right ); + + DestroyWindow(hScroll); + DestroyWindow(hMainWnd); } /* some tests designed to show that Horizontal and Vertical @@ -502,19 +543,10 @@ START_TEST ( scroll ) wc.lpfnWndProc = MyWndProc; RegisterClassA(&wc); - hMainWnd = CreateWindowExA( 0, "MyTestWnd", "Scroll", - WS_OVERLAPPEDWINDOW|WS_VSCROLL|WS_HSCROLL, - CW_USEDEFAULT, CW_USEDEFAULT, 100, 100, NULL, NULL, GetModuleHandleA(NULL), 0 ); - - ok(hMainWnd != NULL, "Failed to create parent window. Tests aborted.\n"); - if (!hMainWnd) return; - - assert( hScroll ); - - scrollbar_test1(); - scrollbar_test2(); - scrollbar_test3(); - scrollbar_test4(); + test_EnableScrollBar(); + test_SetScrollPos(); + test_ShowScrollBar(); + test_GetScrollBarInfo(); scrollbar_test_track(); /* Some test results vary depending of theming being active or not */ @@ -533,7 +565,4 @@ START_TEST ( scroll ) scrollbar_test_default( WS_HSCROLL | WS_VSCROLL); scrollbar_test_init(); - - DestroyWindow(hScroll); - DestroyWindow(hMainWnd); }

1 0

Nikolay Sivov : oleaut32: Remove unused tracing macro.
by Alexandre Julliard 16 Nov '15

16 Nov '15

Module: wine Branch: master Commit: 68d09afc28c1d1af816802feabceb47a38a00028 URL: http://source.winehq.org/git/wine.git/?a=commit;h=68d09afc28c1d1af816802fea… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Sun Nov 15 19:14:10 2015 +0300 oleaut32: Remove unused tracing macro. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/oleaut32/varformat.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/dlls/oleaut32/varformat.c b/dlls/oleaut32/varformat.c index a4969c2..696763e 100644 --- a/dlls/oleaut32/varformat.c +++ b/dlls/oleaut32/varformat.c @@ -51,15 +51,6 @@ static const WCHAR szPercent_d[] = { '%','d','\0' }; static const WCHAR szPercentZeroTwo_d[] = { '%','0','2','d','\0' }; static const WCHAR szPercentZeroStar_d[] = { '%','0','*','d','\0' }; -#if 0 -#define dump_tokens(rgb) do { \ - int i_; TRACE("Tokens->{\n"); \ - for (i_ = 0; i_ < rgb[0]; i_++) \ - TRACE("%s0x%02x", i_?",":"",rgb[i_]); \ - TRACE(" }\n"); \ - } while(0) -#endif - /****************************************************************************** * Variant-Formats {OLEAUT32} *

1 0

← Newer
1
...
20
21
22
23
24
25
26
...
63
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits November 2015