wine-commits May 2015

wine-commits@winehq.org

2 participants
428 discussions

Piotr Caban : msvcr120: Add fmax implementation.
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: ec2f02db0cdb8de2368696cbb34f994a8643d859 URL: http://source.winehq.org/git/wine.git/?a=commit;h=ec2f02db0cdb8de2368696cbb… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Tue May 26 14:54:40 2015 +0200 msvcr120: Add fmax implementation. --- dlls/msvcr120/msvcr120.spec | 6 +++--- dlls/msvcr120_app/msvcr120_app.spec | 6 +++--- dlls/msvcrt/math.c | 28 ++++++++++++++++++++++++++++ 3 files changed, 34 insertions(+), 6 deletions(-) diff --git a/dlls/msvcr120/msvcr120.spec b/dlls/msvcr120/msvcr120.spec index bf6159b..7fa5f89 100644 --- a/dlls/msvcr120/msvcr120.spec +++ b/dlls/msvcr120/msvcr120.spec @@ -2164,9 +2164,9 @@ @ stub fma @ stub fmaf @ stub fmal -@ stub fmax -@ stub fmaxf -@ stub fmaxl +@ cdecl fmax(double double) MSVCR120_fmax +@ cdecl fmaxf(float float) MSVCR120_fmaxf +@ cdecl fmaxl(double double) MSVCR120_fmax @ stub fmin @ stub fminf @ stub fminl diff --git a/dlls/msvcr120_app/msvcr120_app.spec b/dlls/msvcr120_app/msvcr120_app.spec index 903120b..271e2f0 100644 --- a/dlls/msvcr120_app/msvcr120_app.spec +++ b/dlls/msvcr120_app/msvcr120_app.spec @@ -1833,9 +1833,9 @@ @ stub fma @ stub fmaf @ stub fmal -@ stub fmax -@ stub fmaxf -@ stub fmaxl +@ cdecl fmax(double double) msvcr120.fmax +@ cdecl fmaxf(float float) msvcr120.fmaxf +@ cdecl fmaxl(double double) msvcr120.fmaxl @ stub fmin @ stub fminf @ stub fminl diff --git a/dlls/msvcrt/math.c b/dlls/msvcrt/math.c index 7c971d3..f796dd9 100644 --- a/dlls/msvcrt/math.c +++ b/dlls/msvcrt/math.c @@ -2605,3 +2605,31 @@ short CDECL MSVCR120__ldtest(LDOUBLE *x) { return MSVCR120__dclass(*x); } + +/********************************************************************* + * fmaxf (MSVCR120.@) + */ +float CDECL MSVCR120_fmaxf(float x, float y) +{ + if(isnanf(x)) + return y; + if(isnanf(y)) + return x; + if(x==0 && y==0) + return signbit(x) ? y : x; + return x<y ? y : x; +} + +/********************************************************************* + * fmax (MSVCR120.@) + */ +double CDECL MSVCR120_fmax(double x, double y) +{ + if(isnan(x)) + return y; + if(isnan(y)) + return x; + if(x==0 && y==0) + return signbit(x) ? y : x; + return x<y ? y : x; +}

1 0

Qian Hong : atl: Added stub AtlIPersistPropertyBag_Save.
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: 852f6a5bccc0ce37dd06509dd866e2f4d6023b0d URL: http://source.winehq.org/git/wine.git/?a=commit;h=852f6a5bccc0ce37dd06509dd… Author: Qian Hong <qhong(a)codeweavers.com> Date: Tue May 26 16:43:43 2015 +0800 atl: Added stub AtlIPersistPropertyBag_Save. --- dlls/atl/atl.c | 12 ++++++++++++ dlls/atl/atl.spec | 2 +- dlls/atl100/atl100.spec | 2 +- dlls/atl110/atl110.spec | 2 +- dlls/atl80/atl80.spec | 2 +- dlls/atl90/atl90.spec | 2 +- 6 files changed, 17 insertions(+), 5 deletions(-) diff --git a/dlls/atl/atl.c b/dlls/atl/atl.c index 795ca9b..23be343 100644 --- a/dlls/atl/atl.c +++ b/dlls/atl/atl.c @@ -286,6 +286,18 @@ HRESULT WINAPI AtlIPersistPropertyBag_Load(LPPROPERTYBAG pPropBag, LPERRORLOG pE } /*********************************************************************** + * AtlIPersistPropertyBag_Save [atl100.@] + */ +HRESULT WINAPI AtlIPersistPropertyBag_Save(LPPROPERTYBAG pPropBag, BOOL fClearDirty, + BOOL fSaveAll, ATL_PROPMAP_ENTRY *pMap, + void *pThis, IUnknown *pUnk) +{ + FIXME("(%p, %d, %d, %p, %p, %p)\n", pPropBag, fClearDirty, fSaveAll, pMap, pThis, pUnk); + + return S_OK; +} + +/*********************************************************************** * AtlModuleAddTermFunc [atl100.@] */ HRESULT WINAPI AtlModuleAddTermFunc(_ATL_MODULE *pM, _ATL_TERMFUNC *pFunc, DWORD_PTR dw) diff --git a/dlls/atl/atl.spec b/dlls/atl/atl.spec index aa0f44b..da12228 100644 --- a/dlls/atl/atl.spec +++ b/dlls/atl/atl.spec @@ -44,7 +44,7 @@ 50 stdcall AtlIPersistStreamInit_Load(ptr ptr ptr ptr) 51 stdcall AtlIPersistStreamInit_Save(ptr long ptr ptr ptr) 52 stdcall AtlIPersistPropertyBag_Load(ptr ptr ptr ptr ptr) -53 stub AtlIPersistPropertyBag_Save +53 stdcall AtlIPersistPropertyBag_Save(ptr long long ptr ptr ptr) 54 stdcall AtlGetObjectSourceInterface(ptr ptr ptr ptr ptr) 55 stub AtlModuleUnRegisterTypeLib 56 stdcall AtlModuleLoadTypeLib(ptr wstr ptr ptr) diff --git a/dlls/atl100/atl100.spec b/dlls/atl100/atl100.spec index 25fad3d..80b4b16 100644 --- a/dlls/atl100/atl100.spec +++ b/dlls/atl100/atl100.spec @@ -36,7 +36,7 @@ 50 stdcall AtlIPersistStreamInit_Load(ptr ptr ptr ptr) 51 stdcall AtlIPersistStreamInit_Save(ptr long ptr ptr ptr) 52 stdcall AtlIPersistPropertyBag_Load(ptr ptr ptr ptr ptr) -53 stub AtlIPersistPropertyBag_Save +53 stdcall AtlIPersistPropertyBag_Save(ptr long long ptr ptr ptr) 54 stdcall AtlGetObjectSourceInterface(ptr ptr ptr ptr ptr) 56 stdcall AtlLoadTypeLib(long wstr ptr ptr) 58 stdcall AtlModuleAddTermFunc(ptr ptr long) diff --git a/dlls/atl110/atl110.spec b/dlls/atl110/atl110.spec index 25fad3d..80b4b16 100644 --- a/dlls/atl110/atl110.spec +++ b/dlls/atl110/atl110.spec @@ -36,7 +36,7 @@ 50 stdcall AtlIPersistStreamInit_Load(ptr ptr ptr ptr) 51 stdcall AtlIPersistStreamInit_Save(ptr long ptr ptr ptr) 52 stdcall AtlIPersistPropertyBag_Load(ptr ptr ptr ptr ptr) -53 stub AtlIPersistPropertyBag_Save +53 stdcall AtlIPersistPropertyBag_Save(ptr long long ptr ptr ptr) 54 stdcall AtlGetObjectSourceInterface(ptr ptr ptr ptr ptr) 56 stdcall AtlLoadTypeLib(long wstr ptr ptr) 58 stdcall AtlModuleAddTermFunc(ptr ptr long) diff --git a/dlls/atl80/atl80.spec b/dlls/atl80/atl80.spec index f313944..e82fba0 100644 --- a/dlls/atl80/atl80.spec +++ b/dlls/atl80/atl80.spec @@ -38,7 +38,7 @@ 50 stdcall AtlIPersistStreamInit_Load(ptr ptr ptr ptr) 51 stdcall AtlIPersistStreamInit_Save(ptr long ptr ptr ptr) 52 stdcall AtlIPersistPropertyBag_Load(ptr ptr ptr ptr ptr) -53 stub AtlIPersistPropertyBag_Save +53 stdcall AtlIPersistPropertyBag_Save(ptr long long ptr ptr ptr) 54 stdcall AtlGetObjectSourceInterface(ptr ptr ptr ptr ptr) 55 stub AtlUnRegisterTypeLib 56 stdcall AtlLoadTypeLib(long wstr ptr ptr) diff --git a/dlls/atl90/atl90.spec b/dlls/atl90/atl90.spec index 25fad3d..80b4b16 100644 --- a/dlls/atl90/atl90.spec +++ b/dlls/atl90/atl90.spec @@ -36,7 +36,7 @@ 50 stdcall AtlIPersistStreamInit_Load(ptr ptr ptr ptr) 51 stdcall AtlIPersistStreamInit_Save(ptr long ptr ptr ptr) 52 stdcall AtlIPersistPropertyBag_Load(ptr ptr ptr ptr ptr) -53 stub AtlIPersistPropertyBag_Save +53 stdcall AtlIPersistPropertyBag_Save(ptr long long ptr ptr ptr) 54 stdcall AtlGetObjectSourceInterface(ptr ptr ptr ptr ptr) 56 stdcall AtlLoadTypeLib(long wstr ptr ptr) 58 stdcall AtlModuleAddTermFunc(ptr ptr long)

1 0

Thomas Faller : vbscript: Fix for unchecked memory access.
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: 06dfe8fcd6e82ceb4adf4cee576e676f59d24778 URL: http://source.winehq.org/git/wine.git/?a=commit;h=06dfe8fcd6e82ceb4adf4cee5… Author: Thomas Faller <tfaller1(a)gmx.de> Date: Sat May 23 18:58:00 2015 +0200 vbscript: Fix for unchecked memory access. --- dlls/vbscript/global.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/vbscript/global.c b/dlls/vbscript/global.c index 1a20527..129d6ce 100644 --- a/dlls/vbscript/global.c +++ b/dlls/vbscript/global.c @@ -1827,7 +1827,7 @@ static HRESULT Global_InStrRev(vbdisp_t *This, VARIANT *args, unsigned args_cnt, assert(2 <= args_cnt && args_cnt <= 4); - if(V_VT(args) == VT_NULL || V_VT(args+1) == VT_NULL || V_VT(args+2) == VT_NULL) + if(V_VT(args) == VT_NULL || V_VT(args+1) == VT_NULL || (args_cnt > 2 && V_VT(args+2) == VT_NULL)) return MAKE_VBSERROR(VBSE_ILLEGAL_NULL_USE); hres = to_string(args, &str1);

1 0

Nikolay Sivov : riched20: Support setting boolean font properties.
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: 38f69193123b499f4cc283033b9d0e91461200f6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=38f69193123b499f4cc283033… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue May 26 09:18:48 2015 +0300 riched20: Support setting boolean font properties. --- dlls/riched20/richole.c | 175 ++++++++++++++++++++++-------------------------- 1 file changed, 81 insertions(+), 94 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=38f69193123b499f4cc28…

1 0

Nikolay Sivov : riched20: Initial support for changing font properties.
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: 64faf03cf3248d6fed7b89d9246e4b13f20300db URL: http://source.winehq.org/git/wine.git/?a=commit;h=64faf03cf3248d6fed7b89d92… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue May 26 09:17:02 2015 +0300 riched20: Initial support for changing font properties. --- dlls/riched20/richole.c | 90 ++++++++++++++++++++++++++++++++++++++++++- dlls/riched20/tests/richole.c | 49 +++++++++++++++++++++++ 2 files changed, 137 insertions(+), 2 deletions(-) diff --git a/dlls/riched20/richole.c b/dlls/riched20/richole.c index eb803e7..063522b 100644 --- a/dlls/riched20/richole.c +++ b/dlls/riched20/richole.c @@ -237,6 +237,7 @@ typedef struct ITextFontImpl { ITextRange *range; textfont_prop_val props[FONT_PROPID_LAST]; BOOL get_cache_enabled; + BOOL set_cache_enabled; } ITextFontImpl; typedef struct ITextParaImpl { @@ -556,6 +557,75 @@ static HRESULT get_textfont_propl(const ITextFontImpl *font, enum textfont_prop_ return hr; } +/* Value should already have a terminal value, for boolean properties it means tomToggle is not handled */ +static HRESULT set_textfont_prop(ITextFontImpl *font, enum textfont_prop_id propid, const textfont_prop_val *value) +{ + const IRichEditOleImpl *reole; + ME_Cursor from, to; + CHARFORMAT2W fmt; + LONG start, end; + + /* when font is not attached to any range use cache */ + if (!font->range || font->set_cache_enabled) { + font->props[propid] = *value; + return S_OK; + } + + if (!(reole = get_range_reole(font->range))) + return CO_E_RELEASED; + + memset(&fmt, 0, sizeof(fmt)); + fmt.cbSize = sizeof(fmt); + fmt.dwMask = textfont_prop_masks[propid]; + + switch (propid) + { + case FONT_ITALIC: + fmt.dwEffects = value->l == tomTrue ? CFE_ITALIC : 0; + break; + default: + FIXME("unhandled font property %d\n", propid); + return E_FAIL; + } + + ITextRange_GetStart(font->range, &start); + ITextRange_GetEnd(font->range, &end); + + ME_CursorFromCharOfs(reole->editor, start, &from); + ME_CursorFromCharOfs(reole->editor, end, &to); + ME_SetCharFormat(reole->editor, &from, &to, &fmt); + + return S_OK; +} + +static HRESULT set_textfont_propd(ITextFontImpl *font, enum textfont_prop_id propid, LONG value) +{ + textfont_prop_val v; + + switch (value) + { + case tomUndefined: + return S_OK; + case tomToggle: { + LONG oldvalue; + get_textfont_propl(font, propid, &oldvalue); + if (oldvalue == tomFalse) + value = tomTrue; + else if (oldvalue == tomTrue) + value = tomFalse; + else + return E_INVALIDARG; + /* fallthrough */ + } + case tomTrue: + case tomFalse: + v.l = value; + return set_textfont_prop(font, propid, &v); + default: + return E_INVALIDARG; + } +} + static HRESULT textfont_getname_from_range(ITextRange *range, BSTR *ret) { const IRichEditOleImpl *reole; @@ -2178,6 +2248,13 @@ static void textfont_reset_to_undefined(ITextFontImpl *font) } } +static void textfont_apply_range_props(ITextFontImpl *font) +{ + enum textfont_prop_id propid; + for (propid = FONT_PROPID_FIRST; propid < FONT_PROPID_LAST; propid++) + set_textfont_prop(font, propid, &font->props[propid]); +} + static HRESULT WINAPI TextFont_Reset(ITextFont *iface, LONG value) { ITextFontImpl *This = impl_from_ITextFont(iface); @@ -2201,6 +2278,13 @@ static HRESULT WINAPI TextFont_Reset(ITextFont *iface, LONG value) case tomTrackParms: This->get_cache_enabled = FALSE; break; + case tomApplyLater: + This->set_cache_enabled = TRUE; + break; + case tomApplyNow: + This->set_cache_enabled = FALSE; + textfont_apply_range_props(This); + break; default: FIXME("reset mode %d not supported\n", value); } @@ -2366,8 +2450,8 @@ static HRESULT WINAPI TextFont_GetItalic(ITextFont *iface, LONG *value) static HRESULT WINAPI TextFont_SetItalic(ITextFont *iface, LONG value) { ITextFontImpl *This = impl_from_ITextFont(iface); - FIXME("(%p)->(%d): stub\n", This, value); - return E_NOTIMPL; + TRACE("(%p)->(%d)\n", This, value); + return set_textfont_propd(This, FONT_ITALIC, value); } static HRESULT WINAPI TextFont_GetKerning(ITextFont *iface, FLOAT *value) @@ -2675,6 +2759,7 @@ static HRESULT create_textfont(ITextRange *range, const ITextFontImpl *src, ITex if (src) { font->range = NULL; font->get_cache_enabled = TRUE; + font->set_cache_enabled = TRUE; memcpy(&font->props, &src->props, sizeof(font->props)); if (font->props[FONT_NAME].str) font->props[FONT_NAME].str = SysAllocString(font->props[FONT_NAME].str); @@ -2685,6 +2770,7 @@ static HRESULT create_textfont(ITextRange *range, const ITextFontImpl *src, ITex /* cache current properties */ font->get_cache_enabled = FALSE; + font->set_cache_enabled = FALSE; textfont_cache_range_props(font); } diff --git a/dlls/riched20/tests/richole.c b/dlls/riched20/tests/richole.c index 72cb1db..adb96c3 100644 --- a/dlls/riched20/tests/richole.c +++ b/dlls/riched20/tests/richole.c @@ -2214,6 +2214,13 @@ static void test_ITextFont(void) ok(hr == S_OK, "got 0x%08x\n", hr); test_textfont_global_defaults(font2); + hr = ITextFont_SetItalic(font2, tomUndefined); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = ITextFont_GetItalic(font2, &value); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(value == tomFalse, "got %d\n", value); + hr = ITextFont_Reset(font2, tomCacheParms); ok(hr == S_OK, "got 0x%08x\n", hr); test_textfont_global_defaults(font2); @@ -2292,6 +2299,48 @@ static void test_ITextFont(void) ok(hr == S_OK, "got 0x%08x\n", hr); ok(value == tomTrue, "got %d\n", value); + /* tomApplyLater */ + hr = ITextFont_Reset(font, tomApplyLater); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = ITextFont_SetItalic(font, tomFalse); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = ITextFont_GetItalic(font, &value); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(value == tomFalse, "got %d\n", value); + + cf.dwEffects = 0; + SendMessageA(hwnd, EM_SETSEL, 0, 10); + ret = SendMessageA(hwnd, EM_GETCHARFORMAT, SCF_SELECTION, (LPARAM)&cf); + ok(ret, "got %d\n", ret); + ok((cf.dwEffects & CFE_ITALIC) == CFE_ITALIC, "got 0x%08x\n", cf.dwEffects); + + hr = ITextFont_Reset(font, tomApplyNow); + ok(hr == S_OK, "got 0x%08x\n", hr); + + cf.dwEffects = 0; + SendMessageA(hwnd, EM_SETSEL, 0, 10); + ret = SendMessageA(hwnd, EM_GETCHARFORMAT, SCF_SELECTION, (LPARAM)&cf); + ok(ret, "got %d\n", ret); + ok((cf.dwEffects & CFE_ITALIC) == 0, "got 0x%08x\n", cf.dwEffects); + + hr = ITextFont_SetItalic(font, tomUndefined); + ok(hr == S_OK, "got 0x%08x\n", hr); + + hr = ITextFont_GetItalic(font, &value); + ok(hr == S_OK, "got 0x%08x\n", hr); + ok(value == tomFalse, "got %d\n", value); + + hr = ITextFont_SetItalic(font, tomAutoColor); + ok(hr == E_INVALIDARG, "got 0x%08x\n", hr); + + cf.dwEffects = 0; + SendMessageA(hwnd, EM_SETSEL, 0, 10); + ret = SendMessageA(hwnd, EM_GETCHARFORMAT, SCF_SELECTION, (LPARAM)&cf); + ok(ret, "got %d\n", ret); + ok((cf.dwEffects & CFE_ITALIC) == 0, "got 0x%08x\n", cf.dwEffects); + ITextRange_Release(range); ITextFont_Release(font); release_interfaces(&hwnd, &reOle, &doc, NULL);

1 0

Nikolay Sivov : riched20: Implement tomTrackParms/tomCacheParms.
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: 1c0cf0efb324a72d843dcdf97b056703be387f7c URL: http://source.winehq.org/git/wine.git/?a=commit;h=1c0cf0efb324a72d843dcdf97… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue May 26 09:15:40 2015 +0300 riched20: Implement tomTrackParms/tomCacheParms. --- dlls/riched20/riched_tom.idl | 3 + dlls/riched20/richole.c | 152 +++++++++++++++++++++++++++++++++++------- dlls/riched20/tests/richole.c | 55 ++++++++++++++- include/tom.idl | 3 + 4 files changed, 189 insertions(+), 24 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=1c0cf0efb324a72d843dc…

1 0

Nikolay Sivov : riched20: Support ITextFont instances detached from a range.
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: 0cf3c2f3a1c2bd64b22b3a01b2bb7ef62283ffe9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0cf3c2f3a1c2bd64b22b3a01b… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue May 26 09:12:58 2015 +0300 riched20: Support ITextFont instances detached from a range. --- dlls/riched20/richole.c | 364 +++++++++++++++++++++++++++++------------- dlls/riched20/tests/richole.c | 291 +++++++++++++++++++++++++++++++-- 2 files changed, 527 insertions(+), 128 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=0cf3c2f3a1c2bd64b22b3…

1 0

Austin English : version: Move GetFileVersionInfo(A/W) implementation to GetFileVersionInfoEx(A/W).
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: 324acd5f1e30b6bbe4f02fe7f9230469b2aa0f95 URL: http://source.winehq.org/git/wine.git/?a=commit;h=324acd5f1e30b6bbe4f02fe7f… Author: Austin English <austinenglish(a)gmail.com> Date: Thu May 21 18:32:17 2015 -0700 version: Move GetFileVersionInfo(A/W) implementation to GetFileVersionInfoEx(A/W). --- dlls/version/version.c | 55 +++++++++++++++++++++++++------------------------- 1 file changed, 28 insertions(+), 27 deletions(-) diff --git a/dlls/version/version.c b/dlls/version/version.c index bcc6d01..e1295a0 100644 --- a/dlls/version/version.c +++ b/dlls/version/version.c @@ -722,10 +722,9 @@ DWORD WINAPI GetFileVersionInfoSizeExA( DWORD flags, LPCSTR filename, LPDWORD ha } /*********************************************************************** - * GetFileVersionInfoW [VERSION.@] + * GetFileVersionInfoExW [VERSION.@] */ -BOOL WINAPI GetFileVersionInfoW( LPCWSTR filename, DWORD handle, - DWORD datasize, LPVOID data ) +BOOL WINAPI GetFileVersionInfoExW( DWORD flags, LPCWSTR filename, DWORD handle, DWORD datasize, LPVOID data ) { static const char signature[4] = "FE2X"; DWORD len, offset, magic = 1; @@ -734,6 +733,13 @@ BOOL WINAPI GetFileVersionInfoW( LPCWSTR filename, DWORD handle, HMODULE hModule; VS_VERSION_INFO_STRUCT32* vvis = data; + if (flags) + { + FIXME("stub: %x %s %u %u %p\n", flags, wine_dbgstr_w(filename), handle, datasize, data); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return 0; + } + TRACE("(%s,%d,size=%d,data=%p)\n", debugstr_w(filename), handle, datasize, data ); @@ -797,10 +803,9 @@ BOOL WINAPI GetFileVersionInfoW( LPCWSTR filename, DWORD handle, } /*********************************************************************** - * GetFileVersionInfoA [VERSION.@] + * GetFileVersionInfoExA [VERSION.@] */ -BOOL WINAPI GetFileVersionInfoA( LPCSTR filename, DWORD handle, - DWORD datasize, LPVOID data ) +BOOL WINAPI GetFileVersionInfoExA( DWORD flags, LPCSTR filename, DWORD handle, DWORD datasize, LPVOID data ) { UNICODE_STRING filenameW; BOOL retval; @@ -813,7 +818,7 @@ BOOL WINAPI GetFileVersionInfoA( LPCSTR filename, DWORD handle, else filenameW.Buffer = NULL; - retval = GetFileVersionInfoW(filenameW.Buffer, handle, datasize, data); + retval = GetFileVersionInfoExW(flags, filenameW.Buffer, handle, datasize, data); RtlFreeUnicodeString(&filenameW); @@ -821,6 +826,22 @@ BOOL WINAPI GetFileVersionInfoA( LPCSTR filename, DWORD handle, } /*********************************************************************** + * GetFileVersionInfoW [VERSION.@] + */ +BOOL WINAPI GetFileVersionInfoW( LPCWSTR filename, DWORD handle, DWORD datasize, LPVOID data ) +{ + return GetFileVersionInfoExW(0, filename, handle, datasize, data); +} + +/*********************************************************************** + * GetFileVersionInfoA [VERSION.@] + */ +BOOL WINAPI GetFileVersionInfoA( LPCSTR filename, DWORD handle, DWORD datasize, LPVOID data ) +{ + return GetFileVersionInfoExA(0, filename, handle, datasize, data); +} + +/*********************************************************************** * VersionInfo16_FindChild [internal] */ static const VS_VERSION_INFO_STRUCT16 *VersionInfo16_FindChild( const VS_VERSION_INFO_STRUCT16 *info, @@ -1636,23 +1657,3 @@ DWORD WINAPI VerInstallFileW( HeapFree( GetProcessHeap(), 0, wcurd ); return ret; } - -/****************************************************************************** - * GetFileVersionInfoExA [VERSION.@] - */ -BOOL WINAPI GetFileVersionInfoExA(DWORD flags, LPCSTR filename, DWORD handle, DWORD len, LPVOID data) -{ - FIXME("stub: %u %s %u %u %p\n", flags, wine_dbgstr_a(filename), handle, len, data); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return 0; -} - -/****************************************************************************** - * GetFileVersionInfoExW [VERSION.@] - */ -BOOL WINAPI GetFileVersionInfoExW(DWORD flags, LPCWSTR filename, DWORD handle, DWORD len, LPVOID data) -{ - FIXME("stub: %u %s %u %u %p\n", flags, wine_dbgstr_w(filename), handle, len, data); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return 0; -}

1 0

Austin English : version: Move GetFileVersionInfoSize(A/W) implemementation to GetFileVersionInfoSizeEx(A/W).
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: e3ae89e8e204eb7948f7edfb869d171acdb71a68 URL: http://source.winehq.org/git/wine.git/?a=commit;h=e3ae89e8e204eb7948f7edfb8… Author: Austin English <austinenglish(a)gmail.com> Date: Thu May 21 18:23:58 2015 -0700 version: Move GetFileVersionInfoSize(A/W) implemementation to GetFileVersionInfoSizeEx(A/W). --- dlls/version/version.c | 51 ++++++++++++++++++++++++++------------------------ 1 file changed, 27 insertions(+), 24 deletions(-) diff --git a/dlls/version/version.c b/dlls/version/version.c index 68dab66..bcc6d01 100644 --- a/dlls/version/version.c +++ b/dlls/version/version.c @@ -607,11 +607,34 @@ typedef struct */ DWORD WINAPI GetFileVersionInfoSizeW( LPCWSTR filename, LPDWORD handle ) { + return GetFileVersionInfoSizeExW( 0, filename, handle ); +} + +/*********************************************************************** + * GetFileVersionInfoSizeA [VERSION.@] + */ +DWORD WINAPI GetFileVersionInfoSizeA( LPCSTR filename, LPDWORD handle ) +{ + return GetFileVersionInfoSizeExA( 0, filename, handle ); +} + +/****************************************************************************** + * GetFileVersionInfoSizeExW [VERSION.@] + */ +DWORD WINAPI GetFileVersionInfoSizeExW( DWORD flags, LPCWSTR filename, LPDWORD handle ) +{ DWORD len, offset, magic = 1; HFILE lzfd; HMODULE hModule; OFSTRUCT ofs; + if (flags) + { + FIXME("stub: %x %s %p\n", flags, wine_dbgstr_w(filename), handle); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return 0; + } + TRACE("(%s,%p)\n", debugstr_w(filename), handle ); if (handle) *handle = 0; @@ -676,10 +699,10 @@ DWORD WINAPI GetFileVersionInfoSizeW( LPCWSTR filename, LPDWORD handle ) } } -/*********************************************************************** - * GetFileVersionInfoSizeA [VERSION.@] +/****************************************************************************** + * GetFileVersionInfoSizeExA [VERSION.@] */ -DWORD WINAPI GetFileVersionInfoSizeA( LPCSTR filename, LPDWORD handle ) +DWORD WINAPI GetFileVersionInfoSizeExA( DWORD flags, LPCSTR filename, LPDWORD handle ) { UNICODE_STRING filenameW; DWORD retval; @@ -691,7 +714,7 @@ DWORD WINAPI GetFileVersionInfoSizeA( LPCSTR filename, LPDWORD handle ) else filenameW.Buffer = NULL; - retval = GetFileVersionInfoSizeW(filenameW.Buffer, handle); + retval = GetFileVersionInfoSizeExW(0, filenameW.Buffer, handle); RtlFreeUnicodeString(&filenameW); @@ -1615,26 +1638,6 @@ DWORD WINAPI VerInstallFileW( } /****************************************************************************** - * GetFileVersionInfoSizeExA [VERSION.@] - */ -DWORD WINAPI GetFileVersionInfoSizeExA(DWORD flags, LPCSTR filename, LPDWORD handle) -{ - FIXME("stub: %u %s %p\n", flags, wine_dbgstr_a(filename), handle); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return 0; -} - -/****************************************************************************** - * GetFileVersionInfoSizeExW [VERSION.@] - */ -DWORD WINAPI GetFileVersionInfoSizeExW(DWORD flags, LPCWSTR filename, LPDWORD handle) -{ - FIXME("stub: %u %s %p\n", flags, wine_dbgstr_w(filename), handle); - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return 0; -} - -/****************************************************************************** * GetFileVersionInfoExA [VERSION.@] */ BOOL WINAPI GetFileVersionInfoExA(DWORD flags, LPCSTR filename, DWORD handle, DWORD len, LPVOID data)

1 0

Mark Harmstone : include: Add GetFileMUIPath to winnls.h.
by Alexandre Julliard 26 May '15

26 May '15

Module: wine Branch: master Commit: 8d42c76e889f0f66150d46482bfe9b6435c51909 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8d42c76e889f0f66150d46482… Author: Mark Harmstone <hellas(a)burntcomma.com> Date: Mon May 25 18:19:04 2015 +0100 include: Add GetFileMUIPath to winnls.h. --- include/winnls.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/winnls.h b/include/winnls.h index 7e9bfa5..693cb30 100644 --- a/include/winnls.h +++ b/include/winnls.h @@ -877,6 +877,7 @@ WINBASEAPI INT WINAPI GetDateFormatEx(LPCWSTR,DWORD,const SYSTEMTIME*,LP WINBASEAPI INT WINAPI GetDateFormatW(LCID,DWORD,const SYSTEMTIME*,LPCWSTR,LPWSTR,INT); #define GetDateFormat WINELIB_NAME_AW(GetDateFormat) WINBASEAPI BOOL WINAPI GetFileMUIInfo(DWORD,PCWSTR,PFILEMUIINFO,DWORD*); +WINBASEAPI BOOL WINAPI GetFileMUIPath(DWORD,PCWSTR,PWSTR,PULONG,PWSTR,PULONG,PULONGLONG); WINBASEAPI INT WINAPI GetGeoInfoA(GEOID,GEOTYPE,LPSTR,INT,LANGID); WINBASEAPI INT WINAPI GetGeoInfoW(GEOID,GEOTYPE,LPWSTR,INT,LANGID); #define GetGeoInfo WINELIB_NAME_AW(GetGeoInfo)

1 0

← Newer
1
2
3
4
5
6
7
8
9
...
43
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits May 2015