wine-commits September 2015

wine-commits@winehq.org

2 participants
318 discussions

Vincent Povirk : comdlg32: Return success from IFileDialogCustomize:: MakeProminent.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: wine Branch: master Commit: 9068f2d10cac2b95ae1e983a8171b20cc39878d8 URL: http://source.winehq.org/git/wine.git/?a=commit;h=9068f2d10cac2b95ae1e983a8… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Sep 9 14:24:13 2015 -0500 comdlg32: Return success from IFileDialogCustomize::MakeProminent. --- dlls/comdlg32/itemdlg.c | 2 +- dlls/comdlg32/tests/itemdlg.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c index 8ca3064..aa42bf3 100644 --- a/dlls/comdlg32/itemdlg.c +++ b/dlls/comdlg32/itemdlg.c @@ -4302,7 +4302,7 @@ static HRESULT WINAPI IFileDialogCustomize_fnMakeProminent(IFileDialogCustomize { FileDialogImpl *This = impl_from_IFileDialogCustomize(iface); FIXME("stub - %p (%d)\n", This, dwIDCtl); - return E_NOTIMPL; + return S_OK; } static HRESULT WINAPI IFileDialogCustomize_fnSetControlItemText(IFileDialogCustomize *iface, diff --git a/dlls/comdlg32/tests/itemdlg.c b/dlls/comdlg32/tests/itemdlg.c index 45e9776..4649620 100644 --- a/dlls/comdlg32/tests/itemdlg.c +++ b/dlls/comdlg32/tests/itemdlg.c @@ -2233,7 +2233,7 @@ static void test_customize(void) ok(cdstate == CDCS_ENABLEDVISIBLE, "got 0x%08x.\n", cdstate); hr = IFileDialogCustomize_MakeProminent(pfdc, id_vgroup1); - todo_wine ok(hr == S_OK, "got 0x%08x.\n", hr); + ok(hr == S_OK, "got 0x%08x.\n", hr); IFileDialogCustomize_Release(pfdc); ref = IFileDialog_Release(pfod);

1 0

Vincent Povirk : comdlg32: Return success from IFileDialog2::AddPlace.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: wine Branch: master Commit: 4270a8a4dc55e2f99b5d1c721bdfbc778cf9e5f0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4270a8a4dc55e2f99b5d1c721… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Sep 9 14:23:55 2015 -0500 comdlg32: Return success from IFileDialog2::AddPlace. --- dlls/comdlg32/itemdlg.c | 2 +- dlls/comdlg32/tests/itemdlg.c | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c index e9d72cb..8ca3064 100644 --- a/dlls/comdlg32/itemdlg.c +++ b/dlls/comdlg32/itemdlg.c @@ -2554,7 +2554,7 @@ static HRESULT WINAPI IFileDialog2_fnAddPlace(IFileDialog2 *iface, IShellItem *p { FileDialogImpl *This = impl_from_IFileDialog2(iface); FIXME("stub - %p (%p, %d)\n", This, psi, fdap); - return E_NOTIMPL; + return S_OK; } static HRESULT WINAPI IFileDialog2_fnSetDefaultExtension(IFileDialog2 *iface, LPCWSTR pszDefaultExtension) diff --git a/dlls/comdlg32/tests/itemdlg.c b/dlls/comdlg32/tests/itemdlg.c index 5d8e410..45e9776 100644 --- a/dlls/comdlg32/tests/itemdlg.c +++ b/dlls/comdlg32/tests/itemdlg.c @@ -778,22 +778,19 @@ static void test_basics(void) IFileSaveDialog_AddPlace(pfsd, NULL, 0); } - todo_wine - { hr = IFileOpenDialog_AddPlace(pfod, psidesktop, FDAP_TOP + 1); - ok(hr == E_INVALIDARG, "got 0x%08x\n", hr); + todo_wine ok(hr == E_INVALIDARG, "got 0x%08x\n", hr); hr = IFileOpenDialog_AddPlace(pfod, psidesktop, FDAP_BOTTOM); ok(hr == S_OK, "got 0x%08x\n", hr); hr = IFileOpenDialog_AddPlace(pfod, psidesktop, FDAP_TOP); ok(hr == S_OK, "got 0x%08x\n", hr); hr = IFileSaveDialog_AddPlace(pfsd, psidesktop, FDAP_TOP + 1); - ok(hr == E_INVALIDARG, "got 0x%08x\n", hr); + todo_wine ok(hr == E_INVALIDARG, "got 0x%08x\n", hr); hr = IFileSaveDialog_AddPlace(pfsd, psidesktop, FDAP_BOTTOM); ok(hr == S_OK, "got 0x%08x\n", hr); hr = IFileSaveDialog_AddPlace(pfsd, psidesktop, FDAP_TOP); ok(hr == S_OK, "got 0x%08x\n", hr); - } /* SetFileName */ hr = IFileOpenDialog_SetFileName(pfod, NULL);

1 0

Vincent Povirk : comdlg32: Remove fixme from EnableOpenDropDown.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: wine Branch: master Commit: 3fc57e7b49a97816344d9706eec4b85550b88892 URL: http://source.winehq.org/git/wine.git/?a=commit;h=3fc57e7b49a97816344d9706e… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Wed Sep 9 14:18:33 2015 -0500 comdlg32: Remove fixme from EnableOpenDropDown. --- dlls/comdlg32/itemdlg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c index c8340df..e9d72cb 100644 --- a/dlls/comdlg32/itemdlg.c +++ b/dlls/comdlg32/itemdlg.c @@ -3582,7 +3582,7 @@ static HRESULT WINAPI IFileDialogCustomize_fnEnableOpenDropDown(IFileDialogCusto { FileDialogImpl *This = impl_from_IFileDialogCustomize(iface); MENUINFO mi; - FIXME("semi-stub - %p (%d)\n", This, dwIDCtl); + TRACE("%p (%d)\n", This, dwIDCtl); if (This->hmenu_opendropdown || get_cctrl(This, dwIDCtl)) return E_UNEXPECTED;

1 0

Vincent Povirk : comdlg32: Fix ignored out parameter.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: wine Branch: master Commit: bbe009778ef8894bf70a5dacd6def04bbcb85477 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bbe009778ef8894bf70a5dacd… Author: Vincent Povirk <vincent(a)codeweavers.com> Date: Fri Sep 11 11:17:52 2015 -0500 comdlg32: Fix ignored out parameter. --- dlls/comdlg32/itemdlg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dlls/comdlg32/itemdlg.c b/dlls/comdlg32/itemdlg.c index 8a52d71..c8340df 100644 --- a/dlls/comdlg32/itemdlg.c +++ b/dlls/comdlg32/itemdlg.c @@ -804,6 +804,8 @@ static HRESULT add_item(customctrl* parent, DWORD itemid, LPCWSTR label, cctrl_i item->cdcstate = CDCS_VISIBLE|CDCS_ENABLED; list_add_tail(&parent->sub_items, &item->entry); + *result = item; + return S_OK; }

1 0

Andrew Eikum : xaudio2: Support looping buffers.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: wine Branch: master Commit: c28bfbc5b274e9009060fafa6ffaab7375c46014 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c28bfbc5b274e9009060fafa6… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Sep 11 10:55:58 2015 -0500 xaudio2: Support looping buffers. Also shorten up the test runtime. --- dlls/xaudio2_7/tests/xaudio2.c | 265 ++++++++++++++++++++++++++++++++++++++++- dlls/xaudio2_7/xaudio_dll.c | 132 ++++++++++++++++++-- 2 files changed, 382 insertions(+), 15 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=c28bfbc5b274e9009060f…

1 0

Andrew Eikum : xaudio2: Quiet down some noisy stubs.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: wine Branch: master Commit: 031af2ca9aa82ac4cd2c9222b4d37e7c1a137973 URL: http://source.winehq.org/git/wine.git/?a=commit;h=031af2ca9aa82ac4cd2c9222b… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Sep 11 10:55:55 2015 -0500 xaudio2: Quiet down some noisy stubs. --- dlls/xaudio2_7/xaudio_dll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c index ce7a15b..e68f1b6 100644 --- a/dlls/xaudio2_7/xaudio_dll.c +++ b/dlls/xaudio2_7/xaudio_dll.c @@ -1964,7 +1964,7 @@ static HRESULT WINAPI IXAudio2Impl_CommitChanges(IXAudio2 *iface, { IXAudio2Impl *This = impl_from_IXAudio2(iface); - FIXME("(%p)->(0x%x): stub!\n", This, operationSet); + TRACE("(%p)->(0x%x): stub!\n", This, operationSet); return E_NOTIMPL; } @@ -1974,7 +1974,7 @@ static void WINAPI IXAudio2Impl_GetPerformanceData(IXAudio2 *iface, { IXAudio2Impl *This = impl_from_IXAudio2(iface); - FIXME("(%p)->(%p): stub!\n", This, pPerfData); + TRACE("(%p)->(%p): stub!\n", This, pPerfData); memset(pPerfData, 0, sizeof(*pPerfData)); }

1 0

Andrew Eikum : xaudio2: Don' t keep running after master voice is destroyed.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: wine Branch: master Commit: 4c8ed8d104bcdb6cb71bc9a73d1d7dd6e9a2f6bc URL: http://source.winehq.org/git/wine.git/?a=commit;h=4c8ed8d104bcdb6cb71bc9a73… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Sep 11 10:55:50 2015 -0500 xaudio2: Don't keep running after master voice is destroyed. --- dlls/xaudio2_7/xaudio_dll.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/dlls/xaudio2_7/xaudio_dll.c b/dlls/xaudio2_7/xaudio_dll.c index 739c919..ce7a15b 100644 --- a/dlls/xaudio2_7/xaudio_dll.c +++ b/dlls/xaudio2_7/xaudio_dll.c @@ -1188,6 +1188,8 @@ static void WINAPI XA2M_DestroyVoice(IXAudio2MasteringVoice *iface) return; } + This->running = FALSE; + IAudioRenderClient_Release(This->render); This->render = NULL; @@ -3068,11 +3070,13 @@ static DWORD WINAPI engine_threadproc(void *arg) if(This->stop_engine) break; - if(!This->running) - continue; - EnterCriticalSection(&This->lock); + if(!This->running || !This->aclient){ + LeaveCriticalSection(&This->lock); + continue; + } + do_engine_tick(This); LeaveCriticalSection(&This->lock);

1 0

Piotr Caban : msi/tests: Fix MsiProvideQualifiedComponent test failure.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: wine Branch: master Commit: f326e372d113332cb238584350b11702ec0b28a5 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f326e372d113332cb23858435… Author: Piotr Caban <piotr(a)codeweavers.com> Date: Fri Sep 11 16:33:33 2015 +0200 msi/tests: Fix MsiProvideQualifiedComponent test failure. --- dlls/msi/tests/action.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/dlls/msi/tests/action.c b/dlls/msi/tests/action.c index 2aa5b0b..05e3b1e 100644 --- a/dlls/msi/tests/action.c +++ b/dlls/msi/tests/action.c @@ -5902,9 +5902,8 @@ static void test_publish_components(void) res = RegDeleteKeyA(HKEY_CURRENT_USER, keypath); ok(res == ERROR_SUCCESS, "RegDeleteKey failed %d\n", res); - res = RegCreateKeyA(HKEY_LOCAL_MACHINE, keypath2, &key); - ok(res == ERROR_SUCCESS, "RegCreateKey failed %d\n", res); - + res = RegCreateKeyExA(HKEY_LOCAL_MACHINE, keypath2, 0, NULL, REG_OPTION_NON_VOLATILE, + MAXIMUM_ALLOWED | KEY_WOW64_64KEY, NULL, &key, NULL ); res = RegSetValueExA(key, "english.txt", 0, REG_MULTI_SZ, data, size); ok(res == ERROR_SUCCESS, "RegSetValueEx failed %d\n", res); RegCloseKey(key); @@ -5914,7 +5913,10 @@ static void test_publish_components(void) "english.txt", INSTALLMODE_DEFAULT, NULL, &size); ok(r == ERROR_SUCCESS, "MsiProvideQualifiedCompontent returned %d\n", r); - res = RegDeleteKeyA(HKEY_LOCAL_MACHINE, keypath2); + if (pRegDeleteKeyExA) + res = pRegDeleteKeyExA(HKEY_LOCAL_MACHINE, keypath2, KEY_WOW64_64KEY, 0); + else + res = RegDeleteKeyA(HKEY_LOCAL_MACHINE, keypath2); ok(res == ERROR_SUCCESS, "RegDeleteKey failed %d\n", res); res = RegCreateKeyA(HKEY_CURRENT_USER, keypath, &key);

1 0

Alexandre Julliard : include: Avoid some type redefinitions.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: wine Branch: master Commit: b30517defd743f4295eaada3a7eabe98f31a395a URL: http://source.winehq.org/git/wine.git/?a=commit;h=b30517defd743f4295eaada3a… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Sep 14 16:19:14 2015 +0900 include: Avoid some type redefinitions. --- include/webservices.h | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/include/webservices.h b/include/webservices.h index 744bee4..0a8b206 100644 --- a/include/webservices.h +++ b/include/webservices.h @@ -25,10 +25,11 @@ extern "C" { typedef struct _WS_ERROR WS_ERROR; typedef struct _WS_HEAP WS_HEAP; -typedef struct _WS_STRUCT_DESCRIPTION WS_STRUCT_DESCRIPTION; typedef struct _WS_XML_BUFFER WS_XML_BUFFER; typedef struct _WS_XML_READER WS_XML_READER; -typedef struct _WS_XML_STRING WS_XML_STRING; + +struct _WS_STRUCT_DESCRIPTION; +struct _WS_XML_STRING; typedef enum { WS_ERROR_PROPERTY_STRING_COUNT, @@ -140,10 +141,10 @@ typedef struct _WS_XML_READER_STREAM_INPUT { } WS_XML_READER_STREAM_INPUT; typedef struct _WS_XML_DICTIONARY { - GUID guid; - WS_XML_STRING *strings; - ULONG stringCount; - BOOL isConst; + GUID guid; + struct _WS_XML_STRING *strings; + ULONG stringCount; + BOOL isConst; } WS_XML_DICTIONARY; typedef struct _WS_XML_STRING { @@ -254,8 +255,8 @@ typedef struct _WS_STRUCT_DESCRIPTION { ULONG fieldCount; WS_XML_STRING *typeLocalName; WS_XML_STRING *typeNs; - WS_STRUCT_DESCRIPTION *parentType; - WS_STRUCT_DESCRIPTION **subTypes; + struct _WS_STRUCT_DESCRIPTION *parentType; + struct _WS_STRUCT_DESCRIPTION **subTypes; ULONG subTypeCount; ULONG structOptions; } WS_STRUCT_DESCRIPTION;

1 0

Francois Gouget : dissect: Raise the new platforms' failed tests limit so they get a chance to improve.
by Alexandre Julliard 14 Sep '15

14 Sep '15

Module: tools Branch: master Commit: f108c92f2cf6c03737f42d955cb7deea49f529ad URL: http://source.winehq.org/git/tools.git/?a=commit;h=f108c92f2cf6c03737f42d95… Author: Francois Gouget <fgouget(a)free.fr> Date: Sun Sep 13 15:56:28 2015 +0200 dissect: Raise the new platforms' failed tests limit so they get a chance to improve. New platforms typically have so many test failures that their results are ignored. But developers cannot fix test failures they are not aware of, resulting in slow progress. So temporarily cut some slack to the new platforms. --- winetest/dissect | 2 ++ 1 file changed, 2 insertions(+) diff --git a/winetest/dissect b/winetest/dissect index 7a40234..067fa7b 100755 --- a/winetest/dissect +++ b/winetest/dissect @@ -216,6 +216,8 @@ if ($plid==1 && $major==4) { } elsif ($plid==3) { #$version = "ce$major$minor"; } +# Give a little slack to the new platforms. +$maxfailedtests += 20 if ($version eq "win8" || $version eq "win10"); if ($prediluvian and not $acceptprediluvianwin) { mydie "platform $version not accepted\n"; }

1 0

← Newer
1
...
10
11
12
13
14
15
16
...
32
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits September 2015