winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
February 2016
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
755 discussions
Start a n
N
ew thread
Józef Kucia : wined3d: Add support for WINED3DFMT_R32G32B32A32_UINT format.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: ea6070b93f7fab5589199c0661a8ba6fa0f7e318 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ea6070b93f7fab5589199c066…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Feb 9 11:24:42 2016 +0100 wined3d: Add support for WINED3DFMT_R32G32B32A32_UINT format. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/utils.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index 0cc0b4c..d835bbe 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -200,6 +200,7 @@ static const struct wined3d_format_base_flags format_base_flags[] = {WINED3DFMT_R8G8B8A8_UINT, WINED3DFMT_FLAG_INTEGER}, {WINED3DFMT_R8G8B8A8_SINT, WINED3DFMT_FLAG_INTEGER}, {WINED3DFMT_R16_UINT, WINED3DFMT_FLAG_INTEGER}, + {WINED3DFMT_R32G32B32A32_UINT, WINED3DFMT_FLAG_INTEGER}, }; struct wined3d_format_block_info @@ -1315,6 +1316,10 @@ static const struct wined3d_format_texture_info format_texture_info[] = GL_DEPTH_STENCIL, GL_FLOAT_32_UNSIGNED_INT_24_8_REV, 8, WINED3DFMT_FLAG_TEXTURE | WINED3DFMT_FLAG_DEPTH | WINED3DFMT_FLAG_STENCIL | WINED3DFMT_FLAG_SHADOW, ARB_DEPTH_BUFFER_FLOAT, convert_s8_uint_d24_float}, + {WINED3DFMT_R32G32B32A32_UINT, GL_RGBA32UI, GL_RGBA32UI, 0, + GL_RGBA_INTEGER, GL_UNSIGNED_INT, 0, + WINED3DFMT_FLAG_TEXTURE, + EXT_TEXTURE_INTEGER, NULL}, /* Vendor-specific formats */ {WINED3DFMT_ATI1N, GL_COMPRESSED_RED_RGTC1, GL_COMPRESSED_RED_RGTC1, 0, GL_RED, GL_UNSIGNED_BYTE, 0,
1
0
0
0
Józef Kucia : wined3d: Add support for WINED3DFMT_R16_UINT format.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: ec45c894bc60008e8f6b9955e88adb33c92e1027 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ec45c894bc60008e8f6b9955e…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Feb 9 11:24:41 2016 +0100 wined3d: Add support for WINED3DFMT_R16_UINT format. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/utils.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index 4d00281..0cc0b4c 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -199,6 +199,7 @@ static const struct wined3d_format_base_flags format_base_flags[] = {WINED3DFMT_S8_UINT_D24_FLOAT, WINED3DFMT_FLAG_FLOAT}, {WINED3DFMT_R8G8B8A8_UINT, WINED3DFMT_FLAG_INTEGER}, {WINED3DFMT_R8G8B8A8_SINT, WINED3DFMT_FLAG_INTEGER}, + {WINED3DFMT_R16_UINT, WINED3DFMT_FLAG_INTEGER}, }; struct wined3d_format_block_info @@ -1138,6 +1139,10 @@ static const struct wined3d_format_texture_info format_texture_info[] = WINED3DFMT_FLAG_TEXTURE | WINED3DFMT_FLAG_POSTPIXELSHADER_BLENDING | WINED3DFMT_FLAG_FILTERING | WINED3DFMT_FLAG_RENDERTARGET, ARB_TEXTURE_RG, NULL}, + {WINED3DFMT_R16_UINT, GL_R16UI, GL_R16UI, 0, + GL_RED_INTEGER, GL_UNSIGNED_SHORT, 0, + WINED3DFMT_FLAG_TEXTURE, + ARB_TEXTURE_RG, NULL}, /* Luminance */ {WINED3DFMT_L8_UNORM, GL_LUMINANCE8, GL_SLUMINANCE8_EXT, 0, GL_LUMINANCE, GL_UNSIGNED_BYTE, 0, @@ -2319,6 +2324,11 @@ static BOOL init_format_texture_info(struct wined3d_adapter *adapter, struct win && (format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_FLOAT)) continue; + /* ARB_texture_rg defines integer formats if ARB_texture_integer is also supported. */ + if (!gl_info->supported[EXT_TEXTURE_INTEGER] + && (format->flags[WINED3D_GL_RES_TYPE_TEX_2D] & WINED3DFMT_FLAG_INTEGER)) + continue; + format->glInternal = format_texture_info[i].gl_internal; format->glGammaInternal = format_texture_info[i].gl_srgb_internal; format->rtInternal = format_texture_info[i].gl_rt_internal;
1
0
0
0
Hugh McMaster : reg: Ask the user whether they want to overwrite an existing registry value.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: ae48fbafa8e5411bd1b515cd21a772bb865e52ca URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ae48fbafa8e5411bd1b515cd2…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Feb 9 22:54:07 2016 +1100 reg: Ask the user whether they want to overwrite an existing registry value. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 16 +++++++++++++--- po/bg.po | 17 ++++++++++++++--- po/ca.po | 16 +++++++++++++--- po/cs.po | 16 +++++++++++++--- po/da.po | 16 +++++++++++++--- po/de.po | 16 +++++++++++++--- po/el.po | 17 ++++++++++++++--- po/en.po | 14 +++++++++++--- po/en_US.po | 14 +++++++++++--- po/eo.po | 16 +++++++++++++--- po/es.po | 16 +++++++++++++--- po/fa.po | 18 +++++++++++++++--- po/fi.po | 16 +++++++++++++--- po/fr.po | 16 +++++++++++++--- po/he.po | 17 ++++++++++++++--- po/hi.po | 14 +++++++++++--- po/hr.po | 16 +++++++++++++--- po/hu.po | 16 +++++++++++++--- po/it.po | 16 +++++++++++++--- po/ja.po | 16 +++++++++++++--- po/ko.po | 16 +++++++++++++--- po/lt.po | 16 +++++++++++++--- po/ml.po | 14 +++++++++++--- po/nb_NO.po | 16 +++++++++++++--- po/nl.po | 16 +++++++++++++--- po/or.po | 14 +++++++++++--- po/pa.po | 14 +++++++++++--- po/pl.po | 16 +++++++++++++--- po/pt_BR.po | 16 +++++++++++++--- po/pt_PT.po | 16 +++++++++++++--- po/rm.po | 14 +++++++++++--- po/ro.po | 16 +++++++++++++--- po/ru.po | 16 +++++++++++++--- po/sk.po | 20 +++++++++++++++++--- po/sl.po | 16 +++++++++++++--- po/sr_RS(a)cyrillic.po | 17 ++++++++++++++--- po/sr_RS(a)latin.po | 17 ++++++++++++++--- po/sv.po | 16 +++++++++++++--- po/te.po | 14 +++++++++++--- po/th.po | 14 +++++++++++--- po/tr.po | 16 +++++++++++++--- po/uk.po | 16 +++++++++++++--- po/wa.po | 14 +++++++++++--- po/wine.pot | 14 +++++++++++--- po/zh_CN.po | 16 +++++++++++++--- po/zh_TW.po | 16 +++++++++++++--- programs/reg/reg.c | 34 ++++++++++++++++++++++++++++++++-- programs/reg/reg.h | 5 +++++ programs/reg/reg.rc | 5 +++++ 49 files changed, 629 insertions(+), 140 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=ae48fbafa8e5411bd1b51…
1
0
0
0
Hugh McMaster : reg: Output program name instead of the generic 'Error'.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: 2b06308fdbc151d3f47bfc43ec63440cbcc2a893 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2b06308fdbc151d3f47bfc43e…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Feb 9 22:54:06 2016 +1100 reg: Output program name instead of the generic 'Error'. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 17 ++++++++++++----- po/bg.po | 16 +++++++++------- po/ca.po | 19 ++++++++++++++----- po/cs.po | 17 ++++++++++++----- po/da.po | 17 ++++++++++++----- po/de.po | 19 ++++++++++++++----- po/el.po | 16 +++++++++------- po/en.po | 20 ++++++++++---------- po/en_US.po | 20 ++++++++++---------- po/eo.po | 18 +++++++++++------- po/es.po | 17 ++++++++++++----- po/fa.po | 10 +++++----- po/fi.po | 19 ++++++++++++++----- po/fr.po | 19 ++++++++++++++----- po/he.po | 17 ++++++++++++----- po/hi.po | 10 +++++----- po/hr.po | 17 ++++++++++++----- po/hu.po | 17 ++++++++++++----- po/it.po | 17 ++++++++++++----- po/ja.po | 19 ++++++++++++++----- po/ko.po | 17 ++++++++++++----- po/lt.po | 19 ++++++++++++++----- po/ml.po | 10 +++++----- po/nb_NO.po | 17 ++++++++++++----- po/nl.po | 17 ++++++++++++----- po/or.po | 10 +++++----- po/pa.po | 10 +++++----- po/pl.po | 19 ++++++++++++++----- po/pt_BR.po | 19 ++++++++++++++----- po/pt_PT.po | 17 ++++++++++++----- po/rm.po | 10 +++++----- po/ro.po | 17 ++++++++++++----- po/ru.po | 19 ++++++++++++++----- po/sk.po | 18 +++++++++++------- po/sl.po | 17 ++++++++++++----- po/sr_RS(a)cyrillic.po | 15 +++++++++------ po/sr_RS(a)latin.po | 15 +++++++++------ po/sv.po | 19 ++++++++++++++----- po/te.po | 10 +++++----- po/th.po | 10 +++++----- po/tr.po | 19 ++++++++++++++----- po/uk.po | 19 ++++++++++++++----- po/wa.po | 10 +++++----- po/wine.pot | 10 +++++----- po/zh_CN.po | 19 ++++++++++++++----- po/zh_TW.po | 17 ++++++++++++----- programs/reg/reg.rc | 10 +++++----- 47 files changed, 495 insertions(+), 255 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=2b06308fdbc151d3f47bf…
1
0
0
0
Hugh McMaster : reg: Specify the data type that is unsupported.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: 5654b91f7cc5f5c23550e301a6dfa54510a86415 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5654b91f7cc5f5c23550e301a…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Feb 9 22:54:05 2016 +1100 reg: Specify the data type that is unsupported. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 2 +- po/bg.po | 2 +- po/ca.po | 4 +++- po/cs.po | 2 +- po/da.po | 2 +- po/de.po | 4 +++- po/el.po | 2 +- po/en.po | 4 ++-- po/en_US.po | 4 ++-- po/eo.po | 2 +- po/es.po | 2 +- po/fa.po | 2 +- po/fi.po | 4 +++- po/fr.po | 4 +++- po/he.po | 2 +- po/hi.po | 2 +- po/hr.po | 2 +- po/hu.po | 2 +- po/it.po | 2 +- po/ja.po | 4 +++- po/ko.po | 2 +- po/lt.po | 4 +++- po/ml.po | 2 +- po/nb_NO.po | 2 +- po/nl.po | 2 +- po/or.po | 2 +- po/pa.po | 2 +- po/pl.po | 4 +++- po/pt_BR.po | 4 +++- po/pt_PT.po | 2 +- po/rm.po | 2 +- po/ro.po | 2 +- po/ru.po | 4 +++- po/sk.po | 2 +- po/sl.po | 2 +- po/sr_RS(a)cyrillic.po | 2 +- po/sr_RS(a)latin.po | 2 +- po/sv.po | 4 +++- po/te.po | 2 +- po/th.po | 2 +- po/tr.po | 4 +++- po/uk.po | 4 +++- po/wa.po | 2 +- po/wine.pot | 2 +- po/zh_CN.po | 4 +++- po/zh_TW.po | 2 +- programs/reg/reg.c | 2 +- programs/reg/reg.rc | 2 +- 48 files changed, 76 insertions(+), 50 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=5654b91f7cc5f5c23550e…
1
0
0
0
Hugh McMaster : reg: Output messages with a variable number of arguments and convert message arrays to strings.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: 5f07f81ad189b934a62caa8179b2f8de99e79264 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=5f07f81ad189b934a62caa817…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Feb 9 22:54:04 2016 +1100 reg: Output messages with a variable number of arguments and convert message arrays to strings. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ar.po | 12 +++++++++ po/bg.po | 12 +++++++++ po/ca.po | 22 +++++++++++++++ po/cs.po | 12 +++++++++ po/da.po | 12 +++++++++ po/de.po | 22 +++++++++++++++ po/el.po | 12 +++++++++ po/en.po | 16 ++++++++++- po/en_US.po | 16 ++++++++++- po/eo.po | 12 +++++++++ po/es.po | 12 +++++++++ po/fa.po | 12 +++++++++ po/fi.po | 20 ++++++++++++++ po/fr.po | 24 +++++++++++++++++ po/he.po | 12 +++++++++ po/hi.po | 12 +++++++++ po/hr.po | 12 +++++++++ po/hu.po | 12 +++++++++ po/it.po | 12 +++++++++ po/ja.po | 22 +++++++++++++++ po/ko.po | 12 +++++++++ po/lt.po | 22 +++++++++++++++ po/ml.po | 12 +++++++++ po/nb_NO.po | 12 +++++++++ po/nl.po | 12 +++++++++ po/or.po | 12 +++++++++ po/pa.po | 12 +++++++++ po/pl.po | 20 ++++++++++++++ po/pt_BR.po | 12 +++++++++ po/pt_PT.po | 12 +++++++++ po/rm.po | 12 +++++++++ po/ro.po | 12 +++++++++ po/ru.po | 24 +++++++++++++++++ po/sk.po | 12 +++++++++ po/sl.po | 12 +++++++++ po/sr_RS(a)cyrillic.po | 12 +++++++++ po/sr_RS(a)latin.po | 12 +++++++++ po/sv.po | 12 +++++++++ po/te.po | 12 +++++++++ po/th.po | 12 +++++++++ po/tr.po | 22 +++++++++++++++ po/uk.po | 22 +++++++++++++++ po/wa.po | 12 +++++++++ po/wine.pot | 12 +++++++++ po/zh_CN.po | 20 ++++++++++++++ po/zh_TW.po | 12 +++++++++ programs/reg/reg.c | 75 ++++++++++++++++++++++++++-------------------------- programs/reg/reg.h | 3 +++ programs/reg/reg.rc | 3 +++ 49 files changed, 710 insertions(+), 39 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=5f07f81ad189b934a62ca…
1
0
0
0
Hugh McMaster : reg: Use FormatMessage for easier internationalization support.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: dfe1c2b57cbf5b99131136981b38e843ab832dec URL:
http://source.winehq.org/git/wine.git/?a=commit;h=dfe1c2b57cbf5b99131136981…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Feb 9 22:54:03 2016 +1100 reg: Use FormatMessage for easier internationalization support. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/reg/reg.c | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/programs/reg/reg.c b/programs/reg/reg.c index 7fddf62..33ae0cd 100644 --- a/programs/reg/reg.c +++ b/programs/reg/reg.c @@ -18,10 +18,13 @@ #include <windows.h> #include <wine/unicode.h> +#include <wine/debug.h> #include "reg.h" #define ARRAY_SIZE(A) (sizeof(A)/sizeof(*A)) +WINE_DEFAULT_DEBUG_CHANNEL(reg); + static const WCHAR short_hklm[] = {'H','K','L','M',0}; static const WCHAR short_hkcu[] = {'H','K','C','U',0}; static const WCHAR short_hkcr[] = {'H','K','C','R',0}; @@ -74,7 +77,7 @@ type_rels[] = {REG_MULTI_SZ, type_multi_sz}, }; -static void output_writeconsole(const WCHAR *str, int wlen) +static void output_writeconsole(const WCHAR *str, DWORD wlen) { DWORD count, ret; @@ -100,11 +103,19 @@ static void output_writeconsole(const WCHAR *str, int wlen) static void output_formatstring(const WCHAR *fmt, __ms_va_list va_args) { - WCHAR msg_buffer[8192]; - int len; + WCHAR *str; + DWORD len; - len = vsnprintfW(msg_buffer, sizeof(msg_buffer)/sizeof(WCHAR), fmt, va_args); - output_writeconsole(msg_buffer, len); + SetLastError(NO_ERROR); + len = FormatMessageW(FORMAT_MESSAGE_FROM_STRING|FORMAT_MESSAGE_ALLOCATE_BUFFER, + fmt, 0, 0, (WCHAR *)&str, 0, &va_args); + if (len == 0 && GetLastError() != NO_ERROR) + { + WINE_FIXME("Could not format string: le=%u, fmt=%s\n", GetLastError(), wine_dbgstr_w(fmt)); + return; + } + output_writeconsole(str, len); + LocalFree(str); } static void reg_message(int msg) @@ -237,7 +248,7 @@ static LPBYTE get_regdata(LPWSTR data, DWORD reg_type, WCHAR separator, DWORD *r } default: { - static const WCHAR unhandled[] = {'U','n','h','a','n','d','l','e','d',' ','T','y','p','e',' ','0','x','%','x',' ',' ','d','a','t','a',' ','%','s','\n',0}; + static const WCHAR unhandled[] = {'U','n','h','a','n','d','l','e','d',' ','T','y','p','e',' ','0','x','%','1','!','x','!',' ',' ','d','a','t','a',' ','%','2','\n',0}; output_string(unhandled, reg_type, data); } } @@ -446,7 +457,7 @@ static int reg_query(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, BOOL subkey) { static const WCHAR stubW[] = {'S','T','U','B',' ','Q','U','E','R','Y',' ', - '-',' ','%','s',' ','%','s',' ','%','d',' ','%','d','\n',0}; + '-',' ','%','1',' ','%','2',' ','%','3','!','d','!',' ','%','4','!','d','!','\n',0}; output_string(stubW, key_name, value_name, value_empty, subkey); return 1;
1
0
0
0
Hugh McMaster : reg: Split reg_printfW into separate functions.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: bfcee1f149f566452790049ce6591cf024608642 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bfcee1f149f566452790049ce…
Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Feb 9 22:54:02 2016 +1100 reg: Split reg_printfW into separate functions. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/reg/reg.c | 52 ++++++++++++++++++++++++++++------------------------ 1 file changed, 28 insertions(+), 24 deletions(-) diff --git a/programs/reg/reg.c b/programs/reg/reg.c index e7729a3..7fddf62 100644 --- a/programs/reg/reg.c +++ b/programs/reg/reg.c @@ -74,19 +74,11 @@ type_rels[] = {REG_MULTI_SZ, type_multi_sz}, }; -static int reg_printfW(const WCHAR *msg, ...) +static void output_writeconsole(const WCHAR *str, int wlen) { - va_list va_args; - int wlen; DWORD count, ret; - WCHAR msg_buffer[8192]; - - va_start(va_args, msg); - vsnprintfW(msg_buffer, 8192, msg, va_args); - va_end(va_args); - wlen = lstrlenW(msg_buffer); - ret = WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), msg_buffer, wlen, &count, NULL); + ret = WriteConsoleW(GetStdHandle(STD_OUTPUT_HANDLE), str, wlen, &count, NULL); if (!ret) { DWORD len; @@ -96,29 +88,41 @@ static int reg_printfW(const WCHAR *msg, ...) * back to WriteFile(), assuming the console encoding is still the right * one in that case. */ - len = WideCharToMultiByte(GetConsoleOutputCP(), 0, msg_buffer, wlen, - NULL, 0, NULL, NULL); + len = WideCharToMultiByte(GetConsoleOutputCP(), 0, str, wlen, NULL, 0, NULL, NULL); msgA = HeapAlloc(GetProcessHeap(), 0, len * sizeof(char)); - if (!msgA) - return 0; + if (!msgA) return; - WideCharToMultiByte(GetConsoleOutputCP(), 0, msg_buffer, wlen, msgA, len, - NULL, NULL); + WideCharToMultiByte(GetConsoleOutputCP(), 0, str, wlen, msgA, len, NULL, NULL); WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), msgA, len, &count, FALSE); HeapFree(GetProcessHeap(), 0, msgA); } +} - return count; +static void output_formatstring(const WCHAR *fmt, __ms_va_list va_args) +{ + WCHAR msg_buffer[8192]; + int len; + + len = vsnprintfW(msg_buffer, sizeof(msg_buffer)/sizeof(WCHAR), fmt, va_args); + output_writeconsole(msg_buffer, len); } -static int reg_message(int msg) +static void reg_message(int msg) { - static const WCHAR formatW[] = {'%','s',0}; WCHAR msg_buffer[8192]; LoadStringW(GetModuleHandleW(NULL), msg, msg_buffer, sizeof(msg_buffer)/sizeof(WCHAR)); - return reg_printfW(formatW, msg_buffer); + output_writeconsole(msg_buffer, strlenW(msg_buffer)); +} + +static void __cdecl output_string(const WCHAR *fmt, ...) +{ + __ms_va_list va_args; + + __ms_va_start(va_args, fmt); + output_formatstring(fmt, va_args); + __ms_va_end(va_args); } static inline BOOL path_rootname_cmp(const WCHAR *input_path, const WCHAR *rootkey_name) @@ -193,7 +197,7 @@ static LPBYTE get_regdata(LPWSTR data, DWORD reg_type, WCHAR separator, DWORD *r val = strtolW(data, &rest, 0); if (rest == data) { static const WCHAR nonnumber[] = {'E','r','r','o','r',':',' ','/','d',' ','r','e','q','u','i','r','e','s',' ','n','u','m','b','e','r','.','\n',0}; - reg_printfW(nonnumber); + output_string(nonnumber); break; } *reg_count = sizeof(DWORD); @@ -227,14 +231,14 @@ static LPBYTE get_regdata(LPWSTR data, DWORD reg_type, WCHAR separator, DWORD *r no_hex_data: /* cleanup, print error */ HeapFree(GetProcessHeap(), 0, out_data); - reg_printfW(nohex); + output_string(nohex); out_data = NULL; break; } default: { static const WCHAR unhandled[] = {'U','n','h','a','n','d','l','e','d',' ','T','y','p','e',' ','0','x','%','x',' ',' ','d','a','t','a',' ','%','s','\n',0}; - reg_printfW(unhandled, reg_type,data); + output_string(unhandled, reg_type, data); } } @@ -443,7 +447,7 @@ static int reg_query(WCHAR *key_name, WCHAR *value_name, BOOL value_empty, { static const WCHAR stubW[] = {'S','T','U','B',' ','Q','U','E','R','Y',' ', '-',' ','%','s',' ','%','s',' ','%','d',' ','%','d','\n',0}; - reg_printfW(stubW, key_name, value_name, value_empty, subkey); + output_string(stubW, key_name, value_name, value_empty, subkey); return 1; }
1
0
0
0
Jacek Caban : ntdll: Don't call NtOpenKeyEx directly from NtOpenKey.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: 7f005dc43cf76d09c9646969db1fa16639a1d960 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=7f005dc43cf76d09c9646969d…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Feb 9 12:12:43 2016 +0100 ntdll: Don't call NtOpenKeyEx directly from NtOpenKey. Needed by Office 2013. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/reg.c | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/dlls/ntdll/reg.c b/dlls/ntdll/reg.c index 6156409..8af2181 100644 --- a/dlls/ntdll/reg.c +++ b/dlls/ntdll/reg.c @@ -120,11 +120,7 @@ NTSTATUS WINAPI RtlpNtCreateKey( PHANDLE retkey, ACCESS_MASK access, const OBJEC return NtCreateKey(retkey, access, attr, 0, NULL, 0, dispos); } -/****************************************************************************** - * NtOpenKeyEx [NTDLL.@] - * ZwOpenKeyEx [NTDLL.@] - */ -NTSTATUS WINAPI NtOpenKeyEx( PHANDLE retkey, ACCESS_MASK access, const OBJECT_ATTRIBUTES *attr, ULONG options ) +static NTSTATUS open_key( PHANDLE retkey, ACCESS_MASK access, const OBJECT_ATTRIBUTES *attr, ULONG options ) { NTSTATUS ret; @@ -151,6 +147,15 @@ NTSTATUS WINAPI NtOpenKeyEx( PHANDLE retkey, ACCESS_MASK access, const OBJECT_AT } /****************************************************************************** + * NtOpenKeyEx [NTDLL.@] + * ZwOpenKeyEx [NTDLL.@] + */ +NTSTATUS WINAPI NtOpenKeyEx( PHANDLE retkey, ACCESS_MASK access, const OBJECT_ATTRIBUTES *attr, ULONG options ) +{ + return open_key( retkey, access, attr, options ); +} + +/****************************************************************************** * NtOpenKey [NTDLL.@] * ZwOpenKey [NTDLL.@] * @@ -160,7 +165,7 @@ NTSTATUS WINAPI NtOpenKeyEx( PHANDLE retkey, ACCESS_MASK access, const OBJECT_AT */ NTSTATUS WINAPI NtOpenKey( PHANDLE retkey, ACCESS_MASK access, const OBJECT_ATTRIBUTES *attr ) { - return NtOpenKeyEx( retkey, access, attr, 0 ); + return open_key( retkey, access, attr, 0 ); } NTSTATUS WINAPI NtOpenKeyTransactedEx( PHANDLE retkey, ACCESS_MASK access, const OBJECT_ATTRIBUTES *attr,
1
0
0
0
Jacek Caban : ntdll: Pass SYNCHRONIZE flag in NtOpenFile and NtCreateFile calls.
by Alexandre Julliard
09 Feb '16
09 Feb '16
Module: wine Branch: master Commit: 443c2a4719cd366a254eaa387417c357935b5634 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=443c2a4719cd366a254eaa387…
Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Feb 9 12:11:07 2016 +0100 ntdll: Pass SYNCHRONIZE flag in NtOpenFile and NtCreateFile calls. This is needed by Office 2013, which hooks those functions and expects flag to be set. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/actctx.c | 4 ++-- dlls/ntdll/directory.c | 2 +- dlls/ntdll/loader.c | 4 ++-- dlls/ntdll/path.c | 2 +- dlls/ntdll/reg.c | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/ntdll/actctx.c b/dlls/ntdll/actctx.c index 715a760..4aa1a72 100644 --- a/dlls/ntdll/actctx.c +++ b/dlls/ntdll/actctx.c @@ -2449,7 +2449,7 @@ static NTSTATUS open_nt_file( HANDLE *handle, UNICODE_STRING *name ) attr.ObjectName = name; attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - return NtOpenFile( handle, GENERIC_READ, &attr, &io, FILE_SHARE_READ, FILE_SYNCHRONOUS_IO_ALERT ); + return NtOpenFile( handle, GENERIC_READ | SYNCHRONIZE, &attr, &io, FILE_SHARE_READ, FILE_SYNCHRONOUS_IO_ALERT ); } static NTSTATUS get_module_filename( HMODULE module, UNICODE_STRING *str, unsigned int extra_len ) @@ -2790,7 +2790,7 @@ static NTSTATUS lookup_winsxs(struct actctx_loader* acl, struct assembly_identit attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - if (!NtOpenFile( &handle, GENERIC_READ, &attr, &io, FILE_SHARE_READ | FILE_SHARE_WRITE, + if (!NtOpenFile( &handle, GENERIC_READ | SYNCHRONIZE, &attr, &io, FILE_SHARE_READ | FILE_SHARE_WRITE, FILE_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT )) { sxs_ai = *ai; diff --git a/dlls/ntdll/directory.c b/dlls/ntdll/directory.c index 04c8e26..93fe594 100644 --- a/dlls/ntdll/directory.c +++ b/dlls/ntdll/directory.c @@ -3345,7 +3345,7 @@ NTSTATUS DIR_get_unix_cwd( char **cwd ) attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - status = NtOpenFile( &handle, 0, &attr, &io, 0, + status = NtOpenFile( &handle, SYNCHRONIZE, &attr, &io, 0, FILE_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT ); RtlFreeUnicodeString( &dirW ); if (status != STATUS_SUCCESS) goto done; diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c index 5bcc03e..bf1d365 100644 --- a/dlls/ntdll/loader.c +++ b/dlls/ntdll/loader.c @@ -2149,7 +2149,7 @@ static NTSTATUS find_dll_file( const WCHAR *load_path, const WCHAR *libname, attr.ObjectName = &nt_name; attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - if (NtOpenFile( handle, GENERIC_READ, &attr, &io, FILE_SHARE_READ|FILE_SHARE_DELETE, FILE_SYNCHRONOUS_IO_NONALERT|FILE_NON_DIRECTORY_FILE )) *handle = 0; + if (NtOpenFile( handle, GENERIC_READ|SYNCHRONIZE, &attr, &io, FILE_SHARE_READ|FILE_SHARE_DELETE, FILE_SYNCHRONOUS_IO_NONALERT|FILE_NON_DIRECTORY_FILE )) *handle = 0; goto found; } @@ -2184,7 +2184,7 @@ static NTSTATUS find_dll_file( const WCHAR *load_path, const WCHAR *libname, attr.ObjectName = &nt_name; attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - if (NtOpenFile( handle, GENERIC_READ, &attr, &io, FILE_SHARE_READ|FILE_SHARE_DELETE, FILE_SYNCHRONOUS_IO_NONALERT|FILE_NON_DIRECTORY_FILE )) *handle = 0; + if (NtOpenFile( handle, GENERIC_READ|SYNCHRONIZE, &attr, &io, FILE_SHARE_READ|FILE_SHARE_DELETE, FILE_SYNCHRONOUS_IO_NONALERT|FILE_NON_DIRECTORY_FILE )) *handle = 0; } found: RtlFreeUnicodeString( &nt_name ); diff --git a/dlls/ntdll/path.c b/dlls/ntdll/path.c index feaac9e..ae0646a 100644 --- a/dlls/ntdll/path.c +++ b/dlls/ntdll/path.c @@ -984,7 +984,7 @@ NTSTATUS WINAPI RtlSetCurrentDirectory_U(const UNICODE_STRING* dir) attr.SecurityDescriptor = NULL; attr.SecurityQualityOfService = NULL; - nts = NtOpenFile( &handle, 0, &attr, &io, 0, FILE_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT ); + nts = NtOpenFile( &handle, SYNCHRONIZE, &attr, &io, 0, FILE_DIRECTORY_FILE | FILE_SYNCHRONOUS_IO_NONALERT ); if (nts != STATUS_SUCCESS) goto out; /* don't keep the directory handle open on removable media */ diff --git a/dlls/ntdll/reg.c b/dlls/ntdll/reg.c index 77126de..6156409 100644 --- a/dlls/ntdll/reg.c +++ b/dlls/ntdll/reg.c @@ -659,7 +659,7 @@ NTSTATUS WINAPI NtLoadKey( const OBJECT_ATTRIBUTES *attr, OBJECT_ATTRIBUTES *fil TRACE("(%p,%p)\n", attr, file); - ret = NtCreateFile(&hive, GENERIC_READ, file, &io, NULL, FILE_ATTRIBUTE_NORMAL, 0, + ret = NtCreateFile(&hive, GENERIC_READ | SYNCHRONIZE, file, &io, NULL, FILE_ATTRIBUTE_NORMAL, 0, FILE_OPEN, 0, NULL, 0); if (ret) return ret;
1
0
0
0
← Newer
1
...
50
51
52
53
54
55
56
...
76
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
Results per page:
10
25
50
100
200