wine-commits March 2016

wine-commits@winehq.org

2 participants
722 discussions

Józef Kucia : d3d11: Implement d3d11_immediate_context_ClearDepthStencilView().
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: 526c4612c8d3a1665a55fcd4bfa8091fb5b2db01 URL: http://source.winehq.org/git/wine.git/?a=commit;h=526c4612c8d3a1665a55fcd4b… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Mar 15 10:52:50 2016 +0100 d3d11: Implement d3d11_immediate_context_ClearDepthStencilView(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/d3d11_private.h | 1 + dlls/d3d11/device.c | 17 +++++++++++++++-- dlls/d3d11/utils.c | 18 ++++++++++++++++++ 3 files changed, 34 insertions(+), 2 deletions(-) diff --git a/dlls/d3d11/d3d11_private.h b/dlls/d3d11/d3d11_private.h index 072afb4..a83a754 100644 --- a/dlls/d3d11/d3d11_private.h +++ b/dlls/d3d11/d3d11_private.h @@ -67,6 +67,7 @@ DWORD wined3d_usage_from_d3d11(UINT bind_flags, enum D3D11_USAGE usage) DECLSPEC struct wined3d_resource *wined3d_resource_from_d3d11_resource(ID3D11Resource *resource) DECLSPEC_HIDDEN; struct wined3d_resource *wined3d_resource_from_d3d10_resource(ID3D10Resource *resource) DECLSPEC_HIDDEN; DWORD wined3d_map_flags_from_d3d11_map_type(D3D11_MAP map_type) DECLSPEC_HIDDEN; +DWORD wined3d_clear_flags_from_d3d11_clear_flags(UINT clear_flags) DECLSPEC_HIDDEN; enum D3D11_USAGE d3d11_usage_from_d3d10_usage(enum D3D10_USAGE usage) DECLSPEC_HIDDEN; enum D3D10_USAGE d3d10_usage_from_d3d11_usage(enum D3D11_USAGE usage) DECLSPEC_HIDDEN; diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c index 0be9331..b820383 100644 --- a/dlls/d3d11/device.c +++ b/dlls/d3d11/device.c @@ -905,7 +905,7 @@ static void STDMETHODCALLTYPE d3d11_immediate_context_ClearRenderTargetView(ID3D const struct wined3d_color color = {color_rgba[0], color_rgba[1], color_rgba[2], color_rgba[3]}; HRESULT hr; - TRACE("iface %p, render_target_view %p, color_rgba {%.8e %.8e %.8e %.8e}.\n", + TRACE("iface %p, render_target_view %p, color_rgba {%.8e, %.8e, %.8e, %.8e}.\n", iface, render_target_view, color_rgba[0], color_rgba[1], color_rgba[2], color_rgba[3]); wined3d_mutex_lock(); @@ -932,8 +932,21 @@ static void STDMETHODCALLTYPE d3d11_immediate_context_ClearUnorderedAccessViewFl static void STDMETHODCALLTYPE d3d11_immediate_context_ClearDepthStencilView(ID3D11DeviceContext *iface, ID3D11DepthStencilView *depth_stencil_view, UINT flags, FLOAT depth, UINT8 stencil) { - FIXME("iface %p, depth_stencil_view %p, flags %#x, depth %f, stencil %u stub!\n", + struct d3d_device *device = device_from_immediate_ID3D11DeviceContext(iface); + struct d3d_depthstencil_view *view = unsafe_impl_from_ID3D11DepthStencilView(depth_stencil_view); + DWORD wined3d_flags; + HRESULT hr; + + TRACE("iface %p, depth_stencil_view %p, flags %#x, depth %.8e, stencil %u.\n", iface, depth_stencil_view, flags, depth, stencil); + + wined3d_flags = wined3d_clear_flags_from_d3d11_clear_flags(flags); + + wined3d_mutex_lock(); + if (FAILED(hr = wined3d_device_clear_rendertarget_view(device->wined3d_device, view->wined3d_view, NULL, + wined3d_flags, NULL, depth, stencil))) + ERR("Failed to clear view, hr %#x.\n", hr); + wined3d_mutex_unlock(); } static void STDMETHODCALLTYPE d3d11_immediate_context_GenerateMips(ID3D11DeviceContext *iface, diff --git a/dlls/d3d11/utils.c b/dlls/d3d11/utils.c index d05ff3d..6d50de5 100644 --- a/dlls/d3d11/utils.c +++ b/dlls/d3d11/utils.c @@ -593,6 +593,24 @@ DWORD wined3d_map_flags_from_d3d11_map_type(D3D11_MAP map_type) } } +DWORD wined3d_clear_flags_from_d3d11_clear_flags(UINT clear_flags) +{ + DWORD wined3d_clear_flags = 0; + + if (clear_flags & D3D11_CLEAR_DEPTH) + wined3d_clear_flags |= WINED3DCLEAR_ZBUFFER; + if (clear_flags & D3D11_CLEAR_STENCIL) + wined3d_clear_flags |= WINED3DCLEAR_STENCIL; + + if (clear_flags & ~(D3D11_CLEAR_DEPTH | D3D11_CLEAR_STENCIL)) + { + FIXME("Unhandled clear flags %#x.\n", + clear_flags & ~(D3D11_CLEAR_DEPTH | D3D11_CLEAR_STENCIL)); + } + + return wined3d_clear_flags; +} + HRESULT d3d_get_private_data(struct wined3d_private_store *store, REFGUID guid, UINT *data_size, void *data) {

1 0

Józef Kucia : wined3d: Implement stencil clear in wined3d_device_clear_rendertarget_view().
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: 3ae4be8696f6abeb2a83b6265d1e6b2127b6922d URL: http://source.winehq.org/git/wine.git/?a=commit;h=3ae4be8696f6abeb2a83b6265… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Mar 15 10:52:49 2016 +0100 wined3d: Implement stencil clear in wined3d_device_clear_rendertarget_view(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/arb_program_shader.c | 4 ++-- dlls/wined3d/device.c | 8 +------- dlls/wined3d/surface.c | 12 +++++++----- dlls/wined3d/wined3d_private.h | 4 ++-- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c index cdd6167..7c4c1db 100644 --- a/dlls/wined3d/arb_program_shader.c +++ b/dlls/wined3d/arb_program_shader.c @@ -7931,9 +7931,9 @@ static HRESULT arbfp_blit_color_fill(struct wined3d_device *device, struct wined } static HRESULT arbfp_blit_depth_fill(struct wined3d_device *device, struct wined3d_rendertarget_view *view, - const RECT *rect, float depth) + const RECT *rect, DWORD clear_flags, float depth, DWORD stencil) { - FIXME("Depth filling not implemented by arbfp_blit.\n"); + FIXME("Depth/stencil filling not implemented by arbfp_blit.\n"); return WINED3DERR_INVALIDCALL; } diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index be8d36f..37d9ee9 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -4092,12 +4092,6 @@ HRESULT CDECL wined3d_device_clear_rendertarget_view(struct wined3d_device *devi if (!flags) return WINED3D_OK; - if (flags & WINED3DCLEAR_STENCIL) - { - FIXME("Stencil clear not implemented.\n"); - return E_NOTIMPL; - } - resource = view->resource; if (resource->type != WINED3D_RTYPE_TEXTURE_2D) { @@ -4132,7 +4126,7 @@ HRESULT CDECL wined3d_device_clear_rendertarget_view(struct wined3d_device *devi if (blit_op == WINED3D_BLIT_OP_COLOR_FILL) return blitter->color_fill(device, view, rect, color); else - return blitter->depth_fill(device, view, rect, depth); + return blitter->depth_fill(device, view, rect, flags, depth, stencil); } struct wined3d_rendertarget_view * CDECL wined3d_device_get_rendertarget_view(const struct wined3d_device *device, diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index f7ca370..dcc946c 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -927,7 +927,7 @@ static HRESULT wined3d_surface_depth_fill(struct wined3d_surface *surface, const return hr; } - hr = blitter->depth_fill(device, view, rect, depth); + hr = blitter->depth_fill(device, view, rect, WINED3DCLEAR_ZBUFFER, depth, 0); wined3d_rendertarget_view_decref(view); return hr; @@ -3584,12 +3584,13 @@ static HRESULT ffp_blit_color_fill(struct wined3d_device *device, struct wined3d } static HRESULT ffp_blit_depth_fill(struct wined3d_device *device, - struct wined3d_rendertarget_view *view, const RECT *rect, float depth) + struct wined3d_rendertarget_view *view, const RECT *rect, DWORD clear_flags, + float depth, DWORD stencil) { const RECT draw_rect = {0, 0, view->width, view->height}; struct wined3d_fb_state fb = {NULL, view}; - device_clear_render_targets(device, 0, &fb, 1, rect, &draw_rect, WINED3DCLEAR_ZBUFFER, 0, depth, 0); + device_clear_render_targets(device, 0, &fb, 1, rect, &draw_rect, clear_flags, NULL, depth, stencil); return WINED3D_OK; } @@ -4279,9 +4280,10 @@ static HRESULT cpu_blit_color_fill(struct wined3d_device *device, struct wined3d } static HRESULT cpu_blit_depth_fill(struct wined3d_device *device, - struct wined3d_rendertarget_view *view, const RECT *rect, float depth) + struct wined3d_rendertarget_view *view, const RECT *rect, DWORD clear_flags, + float depth, DWORD stencil) { - FIXME("Depth filling not implemented by cpu_blit.\n"); + FIXME("Depth/stencil filling not implemented by cpu_blit.\n"); return WINED3DERR_INVALIDCALL; } diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index ec7de5a..23d8565 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -1473,8 +1473,8 @@ struct blit_shader const RECT *dst_rect, DWORD dst_usage, enum wined3d_pool dst_pool, const struct wined3d_format *dst_format); HRESULT (*color_fill)(struct wined3d_device *device, struct wined3d_rendertarget_view *view, const RECT *rect, const struct wined3d_color *color); - HRESULT (*depth_fill)(struct wined3d_device *device, - struct wined3d_rendertarget_view *view, const RECT *rect, float depth); + HRESULT (*depth_fill)(struct wined3d_device *device, struct wined3d_rendertarget_view *view, + const RECT *rect, DWORD clear_flags, float depth, DWORD stencil); void (*blit_surface)(struct wined3d_device *device, enum wined3d_blit_op op, DWORD filter, struct wined3d_surface *src_surface, const RECT *src_rect, struct wined3d_surface *dst_surface, const RECT *dst_rect,

1 0

Józef Kucia : wined3d: Implement depth clear in wined3d_device_clear_rendertarget_view().
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: c21dbb5149b613e5c5ffed6818358679a48af83e URL: http://source.winehq.org/git/wine.git/?a=commit;h=c21dbb5149b613e5c5ffed681… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Mar 15 10:52:48 2016 +0100 wined3d: Implement depth clear in wined3d_device_clear_rendertarget_view(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/device.c | 6 ++++-- dlls/d3d9/device.c | 3 ++- dlls/wined3d/device.c | 35 ++++++++++++++++++++++++++++++----- dlls/wined3d/wined3d.spec | 2 +- include/wine/wined3d.h | 3 ++- 5 files changed, 39 insertions(+), 10 deletions(-) diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c index 240c995..0be9331 100644 --- a/dlls/d3d11/device.c +++ b/dlls/d3d11/device.c @@ -909,7 +909,8 @@ static void STDMETHODCALLTYPE d3d11_immediate_context_ClearRenderTargetView(ID3D iface, render_target_view, color_rgba[0], color_rgba[1], color_rgba[2], color_rgba[3]); wined3d_mutex_lock(); - if (FAILED(hr = wined3d_device_clear_rendertarget_view(device->wined3d_device, view->wined3d_view, NULL, &color))) + if (FAILED(hr = wined3d_device_clear_rendertarget_view(device->wined3d_device, view->wined3d_view, NULL, + WINED3DCLEAR_TARGET, &color, 0.0f, 0))) ERR("Failed to clear view, hr %#x.\n", hr); wined3d_mutex_unlock(); } @@ -3301,7 +3302,8 @@ static void STDMETHODCALLTYPE d3d10_device_ClearRenderTargetView(ID3D10Device1 * iface, render_target_view, color_rgba[0], color_rgba[1], color_rgba[2], color_rgba[3]); wined3d_mutex_lock(); - if (FAILED(hr = wined3d_device_clear_rendertarget_view(device->wined3d_device, view->wined3d_view, NULL, &color))) + if (FAILED(hr = wined3d_device_clear_rendertarget_view(device->wined3d_device, view->wined3d_view, NULL, + WINED3DCLEAR_TARGET, &color, 0.0f, 0))) ERR("Failed to clear view, hr %#x.\n", hr); wined3d_mutex_unlock(); } diff --git a/dlls/d3d9/device.c b/dlls/d3d9/device.c index 918e1e0..0ed2aff 100644 --- a/dlls/d3d9/device.c +++ b/dlls/d3d9/device.c @@ -1450,7 +1450,8 @@ static HRESULT WINAPI d3d9_device_ColorFill(IDirect3DDevice9Ex *iface, } hr = wined3d_device_clear_rendertarget_view(device->wined3d_device, - d3d9_surface_get_rendertarget_view(surface_impl), rect, &c); + d3d9_surface_get_rendertarget_view(surface_impl), rect, + WINED3DCLEAR_TARGET, &c, 0.0f, 0); wined3d_mutex_unlock(); diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index 53e6420..be8d36f 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -4078,13 +4078,25 @@ void CDECL wined3d_device_update_sub_resource(struct wined3d_device *device, str } HRESULT CDECL wined3d_device_clear_rendertarget_view(struct wined3d_device *device, - struct wined3d_rendertarget_view *view, const RECT *rect, const struct wined3d_color *color) + struct wined3d_rendertarget_view *view, const RECT *rect, DWORD flags, + const struct wined3d_color *color, float depth, DWORD stencil) { + const struct blit_shader *blitter; struct wined3d_resource *resource; + enum wined3d_blit_op blit_op; RECT r; - TRACE("device %p, view %p, rect %s, color %s.\n", - device, view, wine_dbgstr_rect(rect), debug_color(color)); + TRACE("device %p, view %p, rect %s, flags %#x, color %s, depth %.8e, stencil %u.\n", + device, view, wine_dbgstr_rect(rect), flags, debug_color(color), depth, stencil); + + if (!flags) + return WINED3D_OK; + + if (flags & WINED3DCLEAR_STENCIL) + { + FIXME("Stencil clear not implemented.\n"); + return E_NOTIMPL; + } resource = view->resource; if (resource->type != WINED3D_RTYPE_TEXTURE_2D) @@ -4105,9 +4117,22 @@ HRESULT CDECL wined3d_device_clear_rendertarget_view(struct wined3d_device *devi rect = &r; } - resource = wined3d_texture_get_sub_resource(wined3d_texture_from_resource(resource), view->sub_resource_idx); + if (flags & WINED3DCLEAR_TARGET) + blit_op = WINED3D_BLIT_OP_COLOR_FILL; + else + blit_op = WINED3D_BLIT_OP_DEPTH_FILL; + + if (!(blitter = wined3d_select_blitter(&device->adapter->gl_info, &device->adapter->d3d_info, + blit_op, NULL, 0, 0, NULL, rect, resource->usage, resource->pool, resource->format))) + { + FIXME("No blitter is capable of performing the requested fill operation.\n"); + return WINED3DERR_INVALIDCALL; + } - return surface_color_fill(surface_from_resource(resource), rect, color); + if (blit_op == WINED3D_BLIT_OP_COLOR_FILL) + return blitter->color_fill(device, view, rect, color); + else + return blitter->depth_fill(device, view, rect, depth); } struct wined3d_rendertarget_view * CDECL wined3d_device_get_rendertarget_view(const struct wined3d_device *device, diff --git a/dlls/wined3d/wined3d.spec b/dlls/wined3d/wined3d.spec index 247e4de..82e0d4f 100644 --- a/dlls/wined3d/wined3d.spec +++ b/dlls/wined3d/wined3d.spec @@ -36,7 +36,7 @@ @ cdecl wined3d_device_begin_scene(ptr) @ cdecl wined3d_device_begin_stateblock(ptr) @ cdecl wined3d_device_clear(ptr long ptr long ptr float long) -@ cdecl wined3d_device_clear_rendertarget_view(ptr ptr ptr ptr) +@ cdecl wined3d_device_clear_rendertarget_view(ptr ptr ptr long ptr float long) @ cdecl wined3d_device_copy_resource(ptr ptr ptr) @ cdecl wined3d_device_copy_sub_resource_region(ptr ptr long long long long ptr long ptr) @ cdecl wined3d_device_create(ptr long long ptr long long ptr ptr) diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index e678c39..d69d11e 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -2054,7 +2054,8 @@ HRESULT __cdecl wined3d_device_begin_stateblock(struct wined3d_device *device); HRESULT __cdecl wined3d_device_clear(struct wined3d_device *device, DWORD rect_count, const RECT *rects, DWORD flags, const struct wined3d_color *color, float z, DWORD stencil); HRESULT __cdecl wined3d_device_clear_rendertarget_view(struct wined3d_device *device, - struct wined3d_rendertarget_view *view, const RECT *rect, const struct wined3d_color *color); + struct wined3d_rendertarget_view *view, const RECT *rect, DWORD flags, + const struct wined3d_color *color, float depth, DWORD stencil); void __cdecl wined3d_device_copy_resource(struct wined3d_device *device, struct wined3d_resource *dst_resource, struct wined3d_resource *src_resource); HRESULT __cdecl wined3d_device_copy_sub_resource_region(struct wined3d_device *device,

1 0

Józef Kucia : wined3d: Introduce debug_color().
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: c099f3a0607f9e6bfbd7adf4692c42d8ed5dce6b URL: http://source.winehq.org/git/wine.git/?a=commit;h=c099f3a0607f9e6bfbd7adf46… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Mar 15 10:52:47 2016 +0100 wined3d: Introduce debug_color(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/device.c | 39 +++++++++++++++------------------------ dlls/wined3d/state.c | 18 +++++------------- dlls/wined3d/utils.c | 8 ++++++++ dlls/wined3d/wined3d_private.h | 1 + 4 files changed, 29 insertions(+), 37 deletions(-) diff --git a/dlls/wined3d/device.c b/dlls/wined3d/device.c index d032184..53e6420 100644 --- a/dlls/wined3d/device.c +++ b/dlls/wined3d/device.c @@ -1559,14 +1559,13 @@ HRESULT CDECL wined3d_device_set_light(struct wined3d_device *device, } /* Initialize the object. */ - TRACE("Light %d setting to type %d, Diffuse(%f,%f,%f,%f), Specular(%f,%f,%f,%f), Ambient(%f,%f,%f,%f)\n", - light_idx, light->type, - light->diffuse.r, light->diffuse.g, light->diffuse.b, light->diffuse.a, - light->specular.r, light->specular.g, light->specular.b, light->specular.a, - light->ambient.r, light->ambient.g, light->ambient.b, light->ambient.a); - TRACE("... Pos(%f,%f,%f), Dir(%f,%f,%f)\n", light->position.x, light->position.y, light->position.z, - light->direction.x, light->direction.y, light->direction.z); - TRACE("... Range(%f), Falloff(%f), Theta(%f), Phi(%f)\n", + TRACE("Light %u setting to type %#x, diffuse %s, specular %s, ambient %s, " + "position {%.8e, %.8e, %.8e}, direction {%.8e, %.8e, %.8e}, " + "range %.8e, falloff %.8e, theta %.8e, phi %.8e.\n", + light_idx, light->type, debug_color(&light->diffuse), + debug_color(&light->specular), debug_color(&light->ambient), + light->position.x, light->position.y, light->position.z, + light->direction.x, light->direction.y, light->direction.z, light->range, light->falloff, light->theta, light->phi); /* Update the live definitions if the light is currently assigned a glIndex. */ @@ -1900,18 +1899,10 @@ void CDECL wined3d_device_get_material(const struct wined3d_device *device, stru *material = device->state.material; - TRACE("diffuse {%.8e, %.8e, %.8e, %.8e}\n", - material->diffuse.r, material->diffuse.g, - material->diffuse.b, material->diffuse.a); - TRACE("ambient {%.8e, %.8e, %.8e, %.8e}\n", - material->ambient.r, material->ambient.g, - material->ambient.b, material->ambient.a); - TRACE("specular {%.8e, %.8e, %.8e, %.8e}\n", - material->specular.r, material->specular.g, - material->specular.b, material->specular.a); - TRACE("emissive {%.8e, %.8e, %.8e, %.8e}\n", - material->emissive.r, material->emissive.g, - material->emissive.b, material->emissive.a); + TRACE("diffuse %s\n", debug_color(&material->diffuse)); + TRACE("ambient %s\n", debug_color(&material->ambient)); + TRACE("specular %s\n", debug_color(&material->specular)); + TRACE("emissive %s\n", debug_color(&material->emissive)); TRACE("power %.8e.\n", material->power); } @@ -3373,8 +3364,8 @@ HRESULT CDECL wined3d_device_end_scene(struct wined3d_device *device) HRESULT CDECL wined3d_device_clear(struct wined3d_device *device, DWORD rect_count, const RECT *rects, DWORD flags, const struct wined3d_color *color, float depth, DWORD stencil) { - TRACE("device %p, rect_count %u, rects %p, flags %#x, color {%.8e, %.8e, %.8e, %.8e}, depth %.8e, stencil %u.\n", - device, rect_count, rects, flags, color->r, color->g, color->b, color->a, depth, stencil); + TRACE("device %p, rect_count %u, rects %p, flags %#x, color %s, depth %.8e, stencil %u.\n", + device, rect_count, rects, flags, debug_color(color), depth, stencil); if (!rect_count && rects) { @@ -4092,8 +4083,8 @@ HRESULT CDECL wined3d_device_clear_rendertarget_view(struct wined3d_device *devi struct wined3d_resource *resource; RECT r; - TRACE("device %p, view %p, rect %s, color {%.8e, %.8e, %.8e, %.8e}.\n", - device, view, wine_dbgstr_rect(rect), color->r, color->g, color->b, color->a); + TRACE("device %p, view %p, rect %s, color %s.\n", + device, view, wine_dbgstr_rect(rect), debug_color(color)); resource = view->resource; if (resource->type != WINED3D_RTYPE_TEXTURE_2D) diff --git a/dlls/wined3d/state.c b/dlls/wined3d/state.c index 55e91c5..ec49d56 100644 --- a/dlls/wined3d/state.c +++ b/dlls/wined3d/state.c @@ -263,7 +263,7 @@ static void state_ambient(struct wined3d_context *context, const struct wined3d_ struct wined3d_color color; wined3d_color_from_d3dcolor(&color, state->render_states[WINED3D_RS_AMBIENT]); - TRACE("Setting ambient to {%.8e, %.8e, %.8e, %.8e}.\n", color.r, color.g, color.b, color.a); + TRACE("Setting ambient to %s.\n", debug_color(&color)); gl_info->gl_ops.gl.p_glLightModelfv(GL_LIGHT_MODEL_AMBIENT, &color.r); checkGLcall("glLightModel for MODEL_AMBIENT"); } @@ -712,18 +712,10 @@ static void state_specularenable(struct wined3d_context *context, const struct w } } - TRACE("diffuse {%.8e, %.8e, %.8e, %.8e}\n", - state->material.diffuse.r, state->material.diffuse.g, - state->material.diffuse.b, state->material.diffuse.a); - TRACE("ambient {%.8e, %.8e, %.8e, %.8e}\n", - state->material.ambient.r, state->material.ambient.g, - state->material.ambient.b, state->material.ambient.a); - TRACE("specular {%.8e, %.8e, %.8e, %.8e}\n", - state->material.specular.r, state->material.specular.g, - state->material.specular.b, state->material.specular.a); - TRACE("emissive {%.8e, %.8e, %.8e, %.8e}\n", - state->material.emissive.r, state->material.emissive.g, - state->material.emissive.b, state->material.emissive.a); + TRACE("diffuse %s\n", debug_color(&state->material.diffuse)); + TRACE("ambient %s\n", debug_color(&state->material.ambient)); + TRACE("specular %s\n", debug_color(&state->material.specular)); + TRACE("emissive %s\n", debug_color(&state->material.emissive)); gl_info->gl_ops.gl.p_glMaterialfv(GL_FRONT_AND_BACK, GL_AMBIENT, (float *)&state->material.ambient); checkGLcall("glMaterialfv(GL_AMBIENT)"); diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c index 5cd482e..e210a8a 100644 --- a/dlls/wined3d/utils.c +++ b/dlls/wined3d/utils.c @@ -3278,6 +3278,14 @@ const char *debug_box(const struct wined3d_box *box) box->right, box->bottom, box->back); } +const char *debug_color(const struct wined3d_color *color) +{ + if (!color) + return "(null)"; + return wine_dbg_sprintf("{%.8e, %.8e, %.8e, %.8e}", + color->r, color->g, color->b, color->a); +} + const char *debug_d3dformat(enum wined3d_format_id format_id) { switch (format_id) diff --git a/dlls/wined3d/wined3d_private.h b/dlls/wined3d/wined3d_private.h index df16d63..ec7de5a 100644 --- a/dlls/wined3d/wined3d_private.h +++ b/dlls/wined3d/wined3d_private.h @@ -2991,6 +2991,7 @@ void swapchain_update_draw_bindings(struct wined3d_swapchain *swapchain) DECLSPE /* Trace routines */ const char *debug_box(const struct wined3d_box *box) DECLSPEC_HIDDEN; +const char *debug_color(const struct wined3d_color *color) DECLSPEC_HIDDEN; const char *debug_d3dshaderinstructionhandler(enum WINED3D_SHADER_INSTRUCTION_HANDLER handler_idx) DECLSPEC_HIDDEN; const char *debug_d3dformat(enum wined3d_format_id format_id) DECLSPEC_HIDDEN; const char *debug_d3ddevicetype(enum wined3d_device_type device_type) DECLSPEC_HIDDEN;

1 0

Józef Kucia : d3d10core/tests: Add more create texture tests.
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: 4a8b305ed736a5ec5f7b8a3111c813d6519dcabc URL: http://source.winehq.org/git/wine.git/?a=commit;h=4a8b305ed736a5ec5f7b8a311… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Mar 15 10:52:46 2016 +0100 d3d10core/tests: Add more create texture tests. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d10core/tests/device.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dlls/d3d10core/tests/device.c b/dlls/d3d10core/tests/device.c index e9ae8d9..00d4482 100644 --- a/dlls/d3d10core/tests/device.c +++ b/dlls/d3d10core/tests/device.c @@ -539,6 +539,9 @@ static void test_create_texture2d(void) {DXGI_FORMAT_R8G8_TYPELESS, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16_TYPELESS, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R8_TYPELESS, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, + {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, FALSE}, + {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, + {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, }; if (!(device = create_device())) @@ -819,9 +822,15 @@ static void test_create_texture3d(void) } tests[] = { + {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_VERTEX_BUFFER, FALSE, TRUE}, + {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_INDEX_BUFFER, FALSE, TRUE}, + {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_CONSTANT_BUFFER, FALSE, TRUE}, {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16G16B16A16_TYPELESS, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R10G10B10A2_TYPELESS, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, + {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, FALSE}, + {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, + {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, }; if (!(device = create_device()))

1 0

Józef Kucia : d3d11: Translate WINED3DERR_INVALIDCALL to E_INVALIDARG in d3d_texture{2d, 3d}_init().
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: f1c58a93afa39c69cd121e90f86b2b93d23d3830 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f1c58a93afa39c69cd121e90f… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Mar 15 10:52:45 2016 +0100 d3d11: Translate WINED3DERR_INVALIDCALL to E_INVALIDARG in d3d_texture{2d, 3d}_init(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d10_1/tests/d3d10_1.c | 2 +- dlls/d3d10core/tests/device.c | 2 +- dlls/d3d11/device.c | 4 ++-- dlls/d3d11/tests/d3d11.c | 16 ++++++++-------- dlls/d3d11/texture.c | 4 +++- 5 files changed, 15 insertions(+), 13 deletions(-) diff --git a/dlls/d3d10_1/tests/d3d10_1.c b/dlls/d3d10_1/tests/d3d10_1.c index 7eba447..ccea06b 100644 --- a/dlls/d3d10_1/tests/d3d10_1.c +++ b/dlls/d3d10_1/tests/d3d10_1.c @@ -221,7 +221,7 @@ static void test_create_device(void) swapchain_desc.BufferDesc.Format = DXGI_FORMAT_BC5_UNORM; hr = D3D10CreateDeviceAndSwapChain1(NULL, D3D10_DRIVER_TYPE_HARDWARE, NULL, 0, supported_feature_level, D3D10_1_SDK_VERSION, &swapchain_desc, &swapchain, &device); - todo_wine ok(hr == E_INVALIDARG, "D3D10CreateDeviceAndSwapChain1 returned %#x.\n", hr); + ok(hr == E_INVALIDARG, "D3D10CreateDeviceAndSwapChain1 returned %#x.\n", hr); ok(!swapchain, "Got unexpected swapchain pointer %p.\n", swapchain); ok(!device, "Got unexpected device pointer %p.\n", device); diff --git a/dlls/d3d10core/tests/device.c b/dlls/d3d10core/tests/device.c index 22f1e9e..e9ae8d9 100644 --- a/dlls/d3d10core/tests/device.c +++ b/dlls/d3d10core/tests/device.c @@ -522,7 +522,7 @@ static void test_create_texture2d(void) {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D10_BIND_CONSTANT_BUFFER, FALSE, TRUE}, {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D10_BIND_RENDER_TARGET, TRUE, FALSE}, - {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D10_BIND_DEPTH_STENCIL, FALSE, TRUE}, + {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D10_BIND_DEPTH_STENCIL, FALSE, FALSE}, {DXGI_FORMAT_R32G32B32_TYPELESS, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16G16B16A16_TYPELESS, D3D10_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16G16B16A16_TYPELESS, D3D10_BIND_RENDER_TARGET, TRUE, FALSE}, diff --git a/dlls/d3d11/device.c b/dlls/d3d11/device.c index 6ec154f..240c995 100644 --- a/dlls/d3d11/device.c +++ b/dlls/d3d11/device.c @@ -4849,7 +4849,7 @@ static HRESULT CDECL device_parent_create_swapchain_texture(struct wined3d_devic FIXME("device_parent %p, container_parent %p, wined3d_desc %p, wined3d_texture %p partial stub!\n", device_parent, container_parent, wined3d_desc, wined3d_texture); - FIXME("Implement DXGI<->wined3d usage conversion\n"); + FIXME("Implement DXGI<->wined3d usage conversion.\n"); desc.Width = wined3d_desc->width; desc.Height = wined3d_desc->height; @@ -4866,7 +4866,7 @@ static HRESULT CDECL device_parent_create_swapchain_texture(struct wined3d_devic if (FAILED(hr = d3d10_device_CreateTexture2D(&device->ID3D10Device1_iface, &desc, NULL, &texture_iface))) { - ERR("CreateTexture2D failed, returning %#x\n", hr); + WARN("CreateTexture2D failed, returning %#x.\n", hr); return hr; } diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index ebed409..e8b6914 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -606,7 +606,7 @@ static void test_create_device(void) swapchain_desc.BufferDesc.Format = DXGI_FORMAT_BC5_UNORM; hr = D3D11CreateDeviceAndSwapChain(NULL, D3D_DRIVER_TYPE_HARDWARE, NULL, 0, NULL, 0, D3D11_SDK_VERSION, &swapchain_desc, &swapchain, &device, &feature_level, &immediate_context); - todo_wine ok(hr == E_INVALIDARG, "D3D11CreateDeviceAndSwapChain returned %#x.\n", hr); + ok(hr == E_INVALIDARG, "D3D11CreateDeviceAndSwapChain returned %#x.\n", hr); ok(!swapchain, "Got unexpected swapchain pointer %p.\n", swapchain); ok(!device, "Got unexpected device pointer %p.\n", device); ok(!feature_level, "Got unexpected feature level %#x.\n", feature_level); @@ -742,7 +742,7 @@ static void test_create_texture2d(void) {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_CONSTANT_BUFFER, FALSE, TRUE}, {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_RENDER_TARGET, TRUE, FALSE}, - {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_DEPTH_STENCIL, FALSE, TRUE}, + {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_DEPTH_STENCIL, FALSE, FALSE}, {DXGI_FORMAT_R32G32B32_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16G16B16A16_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16G16B16A16_TYPELESS, D3D11_BIND_RENDER_TARGET, TRUE, FALSE}, @@ -759,9 +759,9 @@ static void test_create_texture2d(void) {DXGI_FORMAT_R8G8_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R8_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, - {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, TRUE}, - {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, TRUE}, - {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, TRUE}, + {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, FALSE}, + {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, + {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, }; if (!(device = create_device(NULL))) @@ -1074,9 +1074,9 @@ static void test_create_texture3d(void) {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16G16B16A16_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R10G10B10A2_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, - {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, TRUE}, - {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, TRUE}, - {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, TRUE}, + {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, FALSE}, + {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, + {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, FALSE}, }; if (!(device = create_device(NULL))) diff --git a/dlls/d3d11/texture.c b/dlls/d3d11/texture.c index 11bda45..c6cdc29 100644 --- a/dlls/d3d11/texture.c +++ b/dlls/d3d11/texture.c @@ -482,7 +482,7 @@ static HRESULT d3d_texture2d_init(struct d3d_texture2d *texture, struct d3d_devi WARN("Failed to create wined3d texture, hr %#x.\n", hr); wined3d_private_store_cleanup(&texture->private_store); wined3d_mutex_unlock(); - if (hr == WINED3DERR_NOTAVAILABLE) + if (hr == WINED3DERR_NOTAVAILABLE || hr == WINED3DERR_INVALIDCALL) hr = E_INVALIDARG; return hr; } @@ -936,6 +936,8 @@ static HRESULT d3d_texture3d_init(struct d3d_texture3d *texture, struct d3d_devi WARN("Failed to create wined3d texture, hr %#x.\n", hr); wined3d_private_store_cleanup(&texture->private_store); wined3d_mutex_unlock(); + if (hr == WINED3DERR_INVALIDCALL) + hr = E_INVALIDARG; return hr; } wined3d_mutex_unlock();

1 0

Józef Kucia : d3d11/tests: Add more create texture tests.
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: d6bef36f229ad2570be5308f715f684d6f2dcedc URL: http://source.winehq.org/git/wine.git/?a=commit;h=d6bef36f229ad2570be5308f7… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Mar 15 10:52:44 2016 +0100 d3d11/tests: Add more create texture tests. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/tests/d3d11.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index d707067..ebed409 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -759,6 +759,9 @@ static void test_create_texture2d(void) {DXGI_FORMAT_R8G8_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R8_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, + {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, TRUE}, + {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, TRUE}, + {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, TRUE}, }; if (!(device = create_device(NULL))) @@ -1065,9 +1068,15 @@ static void test_create_texture3d(void) } tests[] = { + {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_VERTEX_BUFFER, FALSE, TRUE}, + {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_INDEX_BUFFER, FALSE, TRUE}, + {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_CONSTANT_BUFFER, FALSE, TRUE}, {DXGI_FORMAT_R32G32B32A32_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R16G16B16A16_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, {DXGI_FORMAT_R10G10B10A2_TYPELESS, D3D11_BIND_SHADER_RESOURCE, TRUE, FALSE}, + {DXGI_FORMAT_R8G8B8A8_UNORM, D3D11_BIND_DEPTH_STENCIL, FALSE, TRUE}, + {DXGI_FORMAT_D24_UNORM_S8_UINT, D3D11_BIND_RENDER_TARGET, FALSE, TRUE}, + {DXGI_FORMAT_D32_FLOAT, D3D11_BIND_RENDER_TARGET, FALSE, TRUE}, }; if (!(device = create_device(NULL)))

1 0

Józef Kucia : d3d11/tests: Move typeless textures test to test_create_texture{2d, 3d}().
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: 75c9178c9808544090e38c4362bed965570b369e URL: http://source.winehq.org/git/wine.git/?a=commit;h=75c9178c9808544090e38c436… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Mar 15 10:52:43 2016 +0100 d3d11/tests: Move typeless textures test to test_create_texture{2d, 3d}(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/tests/d3d11.c | 180 ++++++++++++++++++++--------------------------- 1 file changed, 77 insertions(+), 103 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=75c9178c9808544090e38…

1 0

Józef Kucia : d3d10core/tests: Move typeless textures test to test_create_texture{2d, 3d}().
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: d4c9ba84272793053a1a2d5f24d2cb640c2bd09f URL: http://source.winehq.org/git/wine.git/?a=commit;h=d4c9ba84272793053a1a2d5f2… Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Tue Mar 15 10:52:42 2016 +0100 d3d10core/tests: Move typeless textures test to test_create_texture{2d, 3d}(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d10core/tests/device.c | 180 ++++++++++++++++++------------------------ 1 file changed, 77 insertions(+), 103 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=d4c9ba84272793053a1a2…

1 0

Hugh McMaster : reg: Fail if multiple /v switches are passed in.
by Alexandre Julliard 15 Mar '16

15 Mar '16

Module: wine Branch: master Commit: bd278b1983d0913b28f85cfd897e1e6484bd5f35 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bd278b1983d0913b28f85cfd8… Author: Hugh McMaster <hugh.mcmaster(a)outlook.com> Date: Tue Mar 15 23:23:56 2016 +1100 reg: Fail if multiple /v switches are passed in. Signed-off-by: Hugh McMaster <hugh.mcmaster(a)outlook.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- programs/reg/reg.c | 6 +++--- programs/reg/tests/reg.c | 7 +++++++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/programs/reg/reg.c b/programs/reg/reg.c index 29be40e..9dbce32 100644 --- a/programs/reg/reg.c +++ b/programs/reg/reg.c @@ -602,7 +602,7 @@ int wmain(int argc, WCHAR *argvW[]) { if (!lstrcmpiW(argvW[i], slashVW)) { - if (!(value_name = argvW[++i])) + if (value_name || !(value_name = argvW[++i])) { output_message(STRING_INVALID_CMDLINE); return 1; @@ -659,7 +659,7 @@ int wmain(int argc, WCHAR *argvW[]) { if (!lstrcmpiW(argvW[i], slashVW)) { - if (!(value_name = argvW[++i])) + if (value_name || !(value_name = argvW[++i])) { output_message(STRING_INVALID_CMDLINE); return 1; @@ -696,7 +696,7 @@ int wmain(int argc, WCHAR *argvW[]) { if (!lstrcmpiW(argvW[i], slashVW)) { - if (!(value_name = argvW[++i])) + if (value_name || !(value_name = argvW[++i])) { output_message(STRING_INVALID_CMDLINE); return 1; diff --git a/programs/reg/tests/reg.c b/programs/reg/tests/reg.c index d1db5c4..927288d 100644 --- a/programs/reg/tests/reg.c +++ b/programs/reg/tests/reg.c @@ -532,6 +532,13 @@ static void test_v_flags(void) run_reg_exe("reg delete HKCU\\" KEY_BASE " /f /v", &r); ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); + + /* Multiple /v switches */ + run_reg_exe("reg add HKCU\\" KEY_BASE " /v Wine /t REG_DWORD /d 0x1 /v Test /f", &r); + ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); + + run_reg_exe("reg delete HKCU\\" KEY_BASE " /v Wine /v Test /f", &r); + ok(r == REG_EXIT_FAILURE, "got exit code %d, expected 1\n", r); } START_TEST(reg)

1 0

← Newer
1
...
39
40
41
42
43
44
45
...
73
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits March 2016