winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
April 2016
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
750 discussions
Start a n
N
ew thread
Louis Lenders : dwrite: Print a FIXME only once in dwritetextanalyzer_AnalyzeNumberSubstitution.
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: 938cd952ad2fbef13dce8181cdbceb897d79464c URL:
http://source.winehq.org/git/wine.git/?a=commit;h=938cd952ad2fbef13dce8181c…
Author: Louis Lenders <xerox.xerox2000x(a)gmail.com> Date: Mon Apr 25 16:51:36 2016 +0200 dwrite: Print a FIXME only once in dwritetextanalyzer_AnalyzeNumberSubstitution. Signed-off-by: Louis Lenders <xerox.xerox2000x(a)gmail.com> Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dwrite/analyzer.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dlls/dwrite/analyzer.c b/dlls/dwrite/analyzer.c index c7ef039..90b53ad 100644 --- a/dlls/dwrite/analyzer.c +++ b/dlls/dwrite/analyzer.c @@ -867,7 +867,10 @@ done: static HRESULT WINAPI dwritetextanalyzer_AnalyzeNumberSubstitution(IDWriteTextAnalyzer2 *iface, IDWriteTextAnalysisSource* source, UINT32 position, UINT32 length, IDWriteTextAnalysisSink* sink) { - FIXME("(%p %u %u %p): stub\n", source, position, length, sink); + static int once; + + if (!once++) + FIXME("(%p %u %u %p): stub\n", source, position, length, sink); return S_OK; }
1
0
0
0
Sebastian Lackner : wined3d: Fix a typo in TRACE message.
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: ad887d6049b7194dae899e0d4696835e4d2ba601 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=ad887d6049b7194dae899e0d4…
Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Mon Apr 25 22:47:19 2016 +0200 wined3d: Fix a typo in TRACE message. Spotted by Sergey Isakov. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/directx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 4aa5fe1..43208b6f 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -1454,7 +1454,7 @@ static const struct gpu_description *query_gpu_description(const struct wined3d_ if (wined3d_settings.pci_device_id != PCI_DEVICE_NONE) { device = wined3d_settings.pci_device_id; - TRACE("Overriding device PCI ID with 0x%04x.\n", vendor); + TRACE("Overriding device PCI ID with 0x%04x.\n", device); } if (wined3d_settings.emulated_textureram)
1
0
0
0
Aaryaman Vasishta : d3drm/tests: Add tests for IDirect3DRMTexture{2-3}_InitFromImage.
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: 2fe8e29140fbec38a2c83b78b39e871e187e7ef5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=2fe8e29140fbec38a2c83b78b…
Author: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> Date: Mon Apr 25 22:17:40 2016 +0530 d3drm/tests: Add tests for IDirect3DRMTexture{2-3}_InitFromImage. Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3drm/tests/d3drm.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/dlls/d3drm/tests/d3drm.c b/dlls/d3drm/tests/d3drm.c index 1c38ec8..583dbec 100644 --- a/dlls/d3drm/tests/d3drm.c +++ b/dlls/d3drm/tests/d3drm.c @@ -1852,6 +1852,61 @@ static void test_Texture(void) ref4 = get_refcount((IUnknown *)d3drm3); ok(ref4 == ref1, "expected ref4 == ref1, got ref1 = %u, ref4 = %u.\n", ref1, ref4); + /* InitFromImage tests */ + d3drm_img = NULL; + hr = IDirect3DRM2_CreateObject(d3drm2, &CLSID_CDirect3DRMTexture, NULL, &IID_IDirect3DRMTexture2, (void **)&texture2); + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture2 interface (hr = %x).\n", hr); + ref2 = get_refcount((IUnknown *)texture2); + hr = IDirect3DRMTexture2_InitFromImage(texture2, NULL); + todo_wine ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %x.\n", hr); + ref3 = get_refcount((IUnknown *)texture2); + ok(ref3 == ref2, "expected ref3 == ref2, got ref2 = %u , ref3 = %u.\n", ref2, ref3); + hr = IDirect3DRMTexture2_InitFromImage(texture2, &initimg); + todo_wine ok(SUCCEEDED(hr), "Cannot initialize IDirect3DRMTexture2 from image (hr = %x).\n", hr); + ref2 = get_refcount((IUnknown *)d3drm1); + todo_wine ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u , ref2 = %u.\n", ref1, ref2); + ref3 = get_refcount((IUnknown *)d3drm2); + ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u , ref3 = %u.\n", ref1, ref3); + ref4 = get_refcount((IUnknown *)d3drm3); + ok(ref4 == ref1, "expected ref4 == ref1, got ref1 = %u , ref4 = %u.\n", ref1, ref4); + d3drm_img = IDirect3DRMTexture2_GetImage(texture2); + todo_wine ok(!!d3drm_img, "Failed to get image.\n"); + todo_wine ok(d3drm_img == &initimg, "Expected image returned == %p, got %p.\n", &initimg, d3drm_img); + IDirect3DRMTexture2_Release(texture2); + ref2 = get_refcount((IUnknown *)d3drm1); + ok(ref2 == ref1, "expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", ref1, ref2); + ref3 = get_refcount((IUnknown *)d3drm2); + ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u, ref3 = %u.\n", ref1, ref3); + ref4 = get_refcount((IUnknown *)d3drm3); + ok(ref4 == ref1, "expected ref4 == ref1, got ref1 = %u, ref4 = %u.\n", ref1, ref4); + + d3drm_img = NULL; + hr = IDirect3DRM3_CreateObject(d3drm3, &CLSID_CDirect3DRMTexture, NULL, &IID_IDirect3DRMTexture3, (void **)&texture3); + ok(SUCCEEDED(hr), "Cannot get IDirect3DRMTexture3 interface (hr = %x).\n", hr); + ref2 = get_refcount((IUnknown *)texture3); + hr = IDirect3DRMTexture3_InitFromImage(texture3, NULL); + todo_wine ok(hr == D3DRMERR_BADOBJECT, "Expected hr == D3DRMERR_BADOBJECT, got %x.\n", hr); + ref3 = get_refcount((IUnknown *)texture3); + ok(ref3 == ref2, "expected ref3 == ref2, got ref2 = %u , ref3 = %u.\n", ref2, ref3); + hr = IDirect3DRMTexture3_InitFromImage(texture3, &initimg); + todo_wine ok(SUCCEEDED(hr), "Cannot initialize IDirect3DRMTexture3 from image (hr = %x).\n", hr); + ref2 = get_refcount((IUnknown *)d3drm1); + todo_wine ok(ref2 > ref1, "expected ref2 > ref1, got ref1 = %u , ref2 = %u.\n", ref1, ref2); + ref3 = get_refcount((IUnknown *)d3drm2); + ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u , ref3 = %u.\n", ref1, ref3); + ref4 = get_refcount((IUnknown *)d3drm3); + ok(ref4 == ref1, "expected ref4 == ref1, got ref1 = %u , ref4 = %u.\n", ref1, ref4); + d3drm_img = IDirect3DRMTexture3_GetImage(texture3); + todo_wine ok(!!d3drm_img, "Failed to get image.\n"); + todo_wine ok(d3drm_img == &initimg, "Expected image returned == %p, got %p.\n", &initimg, d3drm_img); + IDirect3DRMTexture3_Release(texture3); + ref2 = get_refcount((IUnknown *)d3drm1); + ok(ref2 == ref1, "expected ref2 == ref1, got ref1 = %u, ref2 = %u.\n", ref1, ref2); + ref3 = get_refcount((IUnknown *)d3drm2); + ok(ref3 == ref1, "expected ref3 == ref1, got ref1 = %u, ref3 = %u.\n", ref1, ref3); + ref4 = get_refcount((IUnknown *)d3drm3); + ok(ref4 == ref1, "expected ref4 == ref1, got ref1 = %u, ref4 = %u.\n", ref1, ref4); + IDirect3DRM3_Release(d3drm3); IDirect3DRM2_Release(d3drm2); IDirect3DRM_Release(d3drm1);
1
0
0
0
Aaryaman Vasishta : d3drm/tests: Replace test_Texture.
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: c64ce8cdbb673a8424898173a94ff1f5e9147ea6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=c64ce8cdbb673a8424898173a…
Author: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> Date: Mon Apr 25 22:17:39 2016 +0530 d3drm/tests: Replace test_Texture. Signed-off-by: Aaryaman Vasishta <jem456.vasishta(a)gmail.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3drm/tests/d3drm.c | 155 ++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 141 insertions(+), 14 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=c64ce8cdbb673a8424898…
1
0
0
0
Józef Kucia : d3d11/tests: Add tests for 2D texture RTVs.
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: 369d0da431e835bff590a78d03b3c216f9938f5a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=369d0da431e835bff590a78d0…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Apr 25 12:25:32 2016 +0200 d3d11/tests: Add tests for 2D texture RTVs. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/tests/d3d11.c | 191 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 191 insertions(+) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index 95afdac..03b6113 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -17,6 +17,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ +#include <assert.h> #define COBJMACROS #include "initguid.h" #include "d3d11.h" @@ -401,6 +402,9 @@ struct d3d11_test_context ID3D11InputLayout *input_layout; ID3D11VertexShader *vs; ID3D11Buffer *vb; + + ID3D11PixelShader *ps; + ID3D11Buffer *ps_cb; }; #define init_test_context(c, l) init_test_context_(__LINE__, c, l) @@ -456,6 +460,10 @@ static void release_test_context_(unsigned int line, struct d3d11_test_context * ID3D11VertexShader_Release(context->vs); if (context->vb) ID3D11Buffer_Release(context->vb); + if (context->ps) + ID3D11PixelShader_Release(context->ps); + if (context->ps_cb) + ID3D11Buffer_Release(context->ps_cb); ID3D11DeviceContext_Release(context->immediate_context); ID3D11RenderTargetView_Release(context->backbuffer_rtv); @@ -543,6 +551,59 @@ static void draw_quad_(unsigned int line, struct d3d11_test_context *context) ID3D11DeviceContext_Draw(context->immediate_context, 4, 0); } +#define draw_color_quad(c, color) draw_color_quad_(__LINE__, c, color) +static void draw_color_quad_(unsigned int line, struct d3d11_test_context *context, const struct vec4 *color) +{ + static const DWORD ps_color_code[] = + { +#if 0 + float4 color; + + float4 main() : SV_TARGET + { + return color; + } +#endif + 0x43425844, 0x80f1c810, 0xdacbbc8b, 0xe07b133e, 0x3059cbfa, 0x00000001, 0x000000b8, 0x00000003, + 0x0000002c, 0x0000003c, 0x00000070, 0x4e475349, 0x00000008, 0x00000000, 0x00000008, 0x4e47534f, + 0x0000002c, 0x00000001, 0x00000008, 0x00000020, 0x00000000, 0x00000000, 0x00000003, 0x00000000, + 0x0000000f, 0x545f5653, 0x45475241, 0xabab0054, 0x52444853, 0x00000040, 0x00000040, 0x00000010, + 0x04000059, 0x00208e46, 0x00000000, 0x00000001, 0x03000065, 0x001020f2, 0x00000000, 0x06000036, + 0x001020f2, 0x00000000, 0x00208e46, 0x00000000, 0x00000000, 0x0100003e, + }; + + ID3D11Device *device = context->device; + D3D11_BUFFER_DESC buffer_desc; + HRESULT hr; + + if (!context->ps) + { + hr = ID3D11Device_CreatePixelShader(device, ps_color_code, sizeof(ps_color_code), NULL, &context->ps); + ok_(__FILE__, line)(SUCCEEDED(hr), "Failed to create pixel shader, hr %#x.\n", hr); + } + + if (!context->ps_cb) + { + buffer_desc.ByteWidth = sizeof(*color); + buffer_desc.Usage = D3D11_USAGE_DEFAULT; + buffer_desc.BindFlags = D3D11_BIND_CONSTANT_BUFFER; + buffer_desc.CPUAccessFlags = 0; + buffer_desc.MiscFlags = 0; + buffer_desc.StructureByteStride = 0; + + hr = ID3D11Device_CreateBuffer(device, &buffer_desc, NULL, &context->ps_cb); + ok_(__FILE__, line)(SUCCEEDED(hr), "Failed to create constant buffer, hr %#x.\n", hr); + } + + ID3D11DeviceContext_PSSetShader(context->immediate_context, context->ps, NULL, 0); + ID3D11DeviceContext_PSSetConstantBuffers(context->immediate_context, 0, 1, &context->ps_cb); + + ID3D11DeviceContext_UpdateSubresource(context->immediate_context, (ID3D11Resource *)context->ps_cb, 0, + NULL, color, 0, 0); + + draw_quad_(line, context); +} + static void test_create_device(void) { static const D3D_FEATURE_LEVEL default_feature_levels[] = @@ -4504,6 +4565,135 @@ static void test_multiple_render_targets(void) ok(!refcount, "Device has %u references left.\n", refcount); } +static void test_render_target_views(void) +{ + struct texture + { + UINT miplevel_count; + UINT array_size; + }; + struct rtv + { + DXGI_FORMAT format; + D3D11_RTV_DIMENSION dimension; + unsigned int miplevel_idx; + unsigned int layer_idx; + unsigned int layer_count; + }; + + static const struct vec4 red = {1.0f, 0.0f, 0.0f, 1.0f}; + static struct test + { + struct texture texture; + struct rtv rtv; + DWORD expected_colors[4]; + } + tests[] = + { + {{2, 1}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2D, 0}, + {0xff0000ff, 0x00000000}}, + {{2, 1}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2D, 1}, + {0x00000000, 0xff0000ff}}, + {{2, 1}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 0, 0, 1}, + {0xff0000ff, 0x00000000}}, + {{2, 1}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 1, 0, 1}, + {0x00000000, 0xff0000ff}}, + {{1, 4}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2D, 0}, + {0xff0000ff, 0x00000000, 0x00000000, 0x00000000}}, + {{1, 4}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 0, 0, 1}, + {0xff0000ff, 0x00000000, 0x00000000, 0x00000000}}, + {{1, 4}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 0, 1, 1}, + {0x00000000, 0xff0000ff, 0x00000000, 0x00000000}}, + {{1, 4}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 0, 2, 1}, + {0x00000000, 0x00000000, 0xff0000ff, 0x00000000}}, + {{1, 4}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 0, 3, 1}, + {0x00000000, 0x00000000, 0x00000000, 0xff0000ff}}, + {{1, 4}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 0, 0, 4}, + {0xff0000ff, 0x00000000, 0x00000000, 0x00000000}}, + {{2, 2}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2D, 0}, + {0xff0000ff, 0x00000000, 0x00000000, 0x00000000}}, + {{2, 2}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 0, 0, 1}, + {0xff0000ff, 0x00000000, 0x00000000, 0x00000000}}, + {{2, 2}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 0, 1, 1}, + {0x00000000, 0x00000000, 0xff0000ff, 0x00000000}}, + {{2, 2}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 1, 0, 1}, + {0x00000000, 0xff0000ff, 0x00000000, 0x00000000}}, + {{2, 2}, {DXGI_FORMAT_UNKNOWN, D3D11_RTV_DIMENSION_TEXTURE2DARRAY, 1, 1, 1}, + {0x00000000, 0x00000000, 0x00000000, 0xff0000ff}}, + }; + + struct d3d11_test_context test_context; + D3D11_RENDER_TARGET_VIEW_DESC rtv_desc; + D3D11_TEXTURE2D_DESC texture_desc; + ID3D11DeviceContext *context; + ID3D11RenderTargetView *rtv; + ID3D11Texture2D *texture; + ID3D11Device *device; + unsigned int i, j; + HRESULT hr; + + if (!init_test_context(&test_context, NULL)) + return; + + device = test_context.device; + context = test_context.immediate_context; + + texture_desc.Width = 32; + texture_desc.Height = 32; + texture_desc.Format = DXGI_FORMAT_R8G8B8A8_UNORM; + texture_desc.SampleDesc.Count = 1; + texture_desc.SampleDesc.Quality = 0; + texture_desc.Usage = D3D11_USAGE_DEFAULT; + texture_desc.BindFlags = D3D11_BIND_RENDER_TARGET; + texture_desc.CPUAccessFlags = 0; + texture_desc.MiscFlags = 0; + + for (i = 0; i < sizeof(tests) / sizeof(*tests); ++i) + { + const struct test *test = &tests[i]; + unsigned int sub_resource_count; + + texture_desc.MipLevels = test->texture.miplevel_count; + texture_desc.ArraySize = test->texture.array_size; + + hr = ID3D11Device_CreateTexture2D(device, &texture_desc, NULL, &texture); + ok(SUCCEEDED(hr), "Test %u: Failed to create texture, hr %#x.\n", i, hr); + + rtv_desc.Format = texture_desc.Format; + rtv_desc.ViewDimension = test->rtv.dimension; + if (test->rtv.dimension == D3D11_RTV_DIMENSION_TEXTURE2D) + { + U(rtv_desc).Texture2D.MipSlice = test->rtv.miplevel_idx; + } + else if (test->rtv.dimension == D3D11_RTV_DIMENSION_TEXTURE2DARRAY) + { + U(rtv_desc).Texture2DArray.MipSlice = test->rtv.miplevel_idx; + U(rtv_desc).Texture2DArray.FirstArraySlice = test->rtv.layer_idx; + U(rtv_desc).Texture2DArray.ArraySize = test->rtv.layer_count; + } + else + { + trace("Test %u: Unhandled view dimension %#x.\n", i, test->rtv.dimension); + } + + hr = ID3D11Device_CreateRenderTargetView(device, (ID3D11Resource *)texture, &rtv_desc, &rtv); + ok(SUCCEEDED(hr), "Test %u: Failed to create render target view, hr %#x.\n", i, hr); + + ID3D11DeviceContext_OMSetRenderTargets(context, 1, &rtv, NULL); + draw_color_quad(&test_context, &red); + + sub_resource_count = texture_desc.MipLevels * texture_desc.ArraySize; + assert(sub_resource_count <= sizeof(test->expected_colors) / sizeof(*test->expected_colors)); + for (j = 0; j < sub_resource_count; ++j) + check_texture_sub_resource_color(texture, j, test->expected_colors[j], 1); + + ID3D11RenderTargetView_Release(rtv); + ID3D11Texture2D_Release(texture); + } + + release_test_context(&test_context); +} + static void test_scissor(void) { struct d3d11_test_context test_context; @@ -6627,6 +6817,7 @@ START_TEST(d3d11) test_blend(); test_texture(); test_multiple_render_targets(); + test_render_target_views(); test_scissor(); test_il_append_aligned(); test_fragment_coords();
1
0
0
0
Józef Kucia : d3d11/tests: Check all sub-resources in check_texture_* functions.
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: 569a7d34d83d91a6120f5c8a2e3795b11d0721bd URL:
http://source.winehq.org/git/wine.git/?a=commit;h=569a7d34d83d91a6120f5c8a2…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Apr 25 12:25:31 2016 +0200 d3d11/tests: Check all sub-resources in check_texture_* functions. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d11/tests/d3d11.c | 83 +++++++++++++++++++++++++++++++++--------------- 1 file changed, 58 insertions(+), 25 deletions(-) diff --git a/dlls/d3d11/tests/d3d11.c b/dlls/d3d11/tests/d3d11.c index 4f3ff8e..95afdac 100644 --- a/dlls/d3d11/tests/d3d11.c +++ b/dlls/d3d11/tests/d3d11.c @@ -118,12 +118,14 @@ struct texture_readback ID3D11Resource *texture; D3D11_MAPPED_SUBRESOURCE map_desc; ID3D11DeviceContext *immediate_context; - unsigned int width, height; + unsigned int width, height, sub_resource_idx; }; -static void get_texture_readback(ID3D11Texture2D *texture, struct texture_readback *rb) +static void get_texture_readback(ID3D11Texture2D *texture, unsigned int sub_resource_idx, + struct texture_readback *rb) { D3D11_TEXTURE2D_DESC texture_desc; + unsigned int miplevel; ID3D11Device *device; HRESULT hr; @@ -143,15 +145,18 @@ static void get_texture_readback(ID3D11Texture2D *texture, struct texture_readba return; } - rb->width = texture_desc.Width; - rb->height = texture_desc.Height; + miplevel = sub_resource_idx % texture_desc.MipLevels; + rb->width = max(1, texture_desc.Width >> miplevel); + rb->height = max(1, texture_desc.Height >> miplevel); + rb->sub_resource_idx = sub_resource_idx; ID3D11Device_GetImmediateContext(device, &rb->immediate_context); ID3D11DeviceContext_CopyResource(rb->immediate_context, rb->texture, (ID3D11Resource *)texture); - if (FAILED(hr = ID3D11DeviceContext_Map(rb->immediate_context, rb->texture, 0, D3D11_MAP_READ, 0, &rb->map_desc))) + if (FAILED(hr = ID3D11DeviceContext_Map(rb->immediate_context, rb->texture, sub_resource_idx, + D3D11_MAP_READ, 0, &rb->map_desc))) { - trace("Failed to map texture, hr %#x.\n", hr); + trace("Failed to map sub-resource %u, hr %#x.\n", sub_resource_idx, hr); ID3D11Resource_Release(rb->texture); rb->texture = NULL; ID3D11DeviceContext_Release(rb->immediate_context); @@ -173,7 +178,7 @@ static float get_readback_float(struct texture_readback *rb, unsigned int x, uns static void release_texture_readback(struct texture_readback *rb) { - ID3D11DeviceContext_Unmap(rb->immediate_context, rb->texture, 0); + ID3D11DeviceContext_Unmap(rb->immediate_context, rb->texture, rb->sub_resource_idx); ID3D11Resource_Release(rb->texture); ID3D11DeviceContext_Release(rb->immediate_context); } @@ -183,23 +188,23 @@ static DWORD get_texture_color(ID3D11Texture2D *texture, unsigned int x, unsigne struct texture_readback rb; DWORD color; - get_texture_readback(texture, &rb); + get_texture_readback(texture, 0, &rb); color = get_readback_color(&rb, x, y); release_texture_readback(&rb); return color; } -#define check_texture_color(t, c, d) check_texture_color_(__LINE__, t, c, d) -static void check_texture_color_(unsigned int line, ID3D11Texture2D *texture, - DWORD expected_color, BYTE max_diff) +#define check_texture_sub_resource_color(t, s, c, d) check_texture_sub_resource_color_(__LINE__, t, s, c, d) +static void check_texture_sub_resource_color_(unsigned int line, ID3D11Texture2D *texture, + unsigned int sub_resource_idx, DWORD expected_color, BYTE max_diff) { struct texture_readback rb; unsigned int x = 0, y = 0; BOOL all_match = TRUE; DWORD color = 0; - get_texture_readback(texture, &rb); + get_texture_readback(texture, sub_resource_idx, &rb); for (y = 0; y < rb.height; ++y) { for (x = 0; x < rb.width; ++x) @@ -216,19 +221,33 @@ static void check_texture_color_(unsigned int line, ID3D11Texture2D *texture, } release_texture_readback(&rb); ok_(__FILE__, line)(all_match, - "Got unexpected color 0x%08x at (%u, %u).\n", color, x, y); + "Got unexpected color 0x%08x at (%u, %u), sub-resource %u.\n", + color, x, y, sub_resource_idx); } -#define check_texture_float(r, f, d) check_texture_float_(__LINE__, r, f, d) -static void check_texture_float_(unsigned int line, ID3D11Texture2D *texture, - float expected_value, BYTE max_diff) +#define check_texture_color(t, c, d) check_texture_color_(__LINE__, t, c, d) +static void check_texture_color_(unsigned int line, ID3D11Texture2D *texture, + DWORD expected_color, BYTE max_diff) +{ + unsigned int sub_resource_idx, sub_resource_count; + D3D11_TEXTURE2D_DESC texture_desc; + + ID3D11Texture2D_GetDesc(texture, &texture_desc); + sub_resource_count = texture_desc.ArraySize * texture_desc.MipLevels; + for (sub_resource_idx = 0; sub_resource_idx < sub_resource_count; ++sub_resource_idx) + check_texture_sub_resource_color_(line, texture, sub_resource_idx, expected_color, max_diff); +} + +#define check_texture_sub_resource_float(t, s, c, d) check_texture_sub_resource_flot_(__LINE__, t, s, c, d) +static void check_texture_sub_resource_float_(unsigned int line, ID3D11Texture2D *texture, + unsigned int sub_resource_idx, float expected_value, BYTE max_diff) { struct texture_readback rb; unsigned int x = 0, y = 0; BOOL all_match = TRUE; float value = 0.0f; - get_texture_readback(texture, &rb); + get_texture_readback(texture, sub_resource_idx, &rb); for (y = 0; y < rb.height; ++y) { for (x = 0; x < rb.width; ++x) @@ -245,7 +264,21 @@ static void check_texture_float_(unsigned int line, ID3D11Texture2D *texture, } release_texture_readback(&rb); ok_(__FILE__, line)(all_match, - "Got unexpected value %.8e at (%u, %u).\n", value, x, y); + "Got unexpected value %.8e at (%u, %u), sub-resource %u.\n", + value, x, y, sub_resource_idx); +} + +#define check_texture_float(r, f, d) check_texture_float_(__LINE__, r, f, d) +static void check_texture_float_(unsigned int line, ID3D11Texture2D *texture, + float expected_value, BYTE max_diff) +{ + unsigned int sub_resource_idx, sub_resource_count; + D3D11_TEXTURE2D_DESC texture_desc; + + ID3D11Texture2D_GetDesc(texture, &texture_desc); + sub_resource_count = texture_desc.ArraySize * texture_desc.MipLevels; + for (sub_resource_idx = 0; sub_resource_idx < sub_resource_count; ++sub_resource_idx) + check_texture_sub_resource_float_(line, texture, sub_resource_idx, expected_value, max_diff); } static ID3D11Device *create_device(const struct device_desc *desc) @@ -4271,7 +4304,7 @@ static void test_texture(void) draw_quad(&test_context); - get_texture_readback(test_context.backbuffer, &rb); + get_texture_readback(test_context.backbuffer, 0, &rb); for (y = 0; y < 4; ++y) { for (x = 0; x < 4; ++x) @@ -5042,7 +5075,7 @@ static void test_update_subresource(void) ID3D11DeviceContext_UpdateSubresource(context, (ID3D11Resource *)texture, 0, &box, bitmap_data, 4 * sizeof(*bitmap_data), 0); draw_quad(&test_context); - get_texture_readback(test_context.backbuffer, &rb); + get_texture_readback(test_context.backbuffer, 0, &rb); for (i = 0; i < 4; ++i) { for (j = 0; j < 4; ++j) @@ -5058,7 +5091,7 @@ static void test_update_subresource(void) ID3D11DeviceContext_UpdateSubresource(context, (ID3D11Resource *)texture, 0, NULL, bitmap_data, 4 * sizeof(*bitmap_data), 0); draw_quad(&test_context); - get_texture_readback(test_context.backbuffer, &rb); + get_texture_readback(test_context.backbuffer, 0, &rb); for (i = 0; i < 4; ++i) { for (j = 0; j < 4; ++j) @@ -5244,7 +5277,7 @@ static void test_copy_subresource_region(void) ID3D11DeviceContext_CopySubresourceRegion(context, (ID3D11Resource *)dst_texture, 0, 0, 0, 0, (ID3D11Resource *)src_texture, 0, &box); draw_quad(&test_context); - get_texture_readback(test_context.backbuffer, &rb); + get_texture_readback(test_context.backbuffer, 0, &rb); for (i = 0; i < 4; ++i) { for (j = 0; j < 4; ++j) @@ -5260,7 +5293,7 @@ static void test_copy_subresource_region(void) ID3D11DeviceContext_CopySubresourceRegion(context, (ID3D11Resource *)dst_texture, 0, 0, 0, 0, (ID3D11Resource *)src_texture, 0, NULL); draw_quad(&test_context); - get_texture_readback(test_context.backbuffer, &rb); + get_texture_readback(test_context.backbuffer, 0, &rb); for (i = 0; i < 4; ++i) { for (j = 0; j < 4; ++j) @@ -5343,7 +5376,7 @@ static void test_copy_subresource_region(void) ID3D11DeviceContext_CopySubresourceRegion(context, (ID3D11Resource *)dst_buffer, 0, 0, 0, 0, (ID3D11Resource *)src_buffer, 0, &box); draw_quad(&test_context); - get_texture_readback(test_context.backbuffer, &rb); + get_texture_readback(test_context.backbuffer, 0, &rb); for (i = 0; i < 4; ++i) { for (j = 0; j < 4; ++j) @@ -6271,7 +6304,7 @@ static void test_draw_depth_only(void) draw_quad(&test_context); } } - get_texture_readback(texture, &rb); + get_texture_readback(texture, 0, &rb); for (i = 0; i < 4; ++i) { for (j = 0; j < 4; ++j)
1
0
0
0
Józef Kucia : wined3d: Implement creating 2D array textures.
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: 64da6b05260ab8bea430872b47783d469dcddeeb URL:
http://source.winehq.org/git/wine.git/?a=commit;h=64da6b05260ab8bea430872b4…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Apr 25 12:25:30 2016 +0200 wined3d: Implement creating 2D array textures. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/surface.c | 57 ++++++++++++++++++++++++++++++++++++++------------ dlls/wined3d/texture.c | 35 ++++++++++++++++++++++++------- 2 files changed, 71 insertions(+), 21 deletions(-) diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c index 9c12f48..28da2eb 100644 --- a/dlls/wined3d/surface.c +++ b/dlls/wined3d/surface.c @@ -993,14 +993,25 @@ void wined3d_surface_upload_data(struct wined3d_surface *surface, const struct w else internal = format->glInternal; - TRACE("glCompressedTexSubImage2D, target %#x, level %d, x %d, y %d, w %d, h %d, " - "format %#x, image_size %#x, addr %p.\n", surface->texture_target, surface->texture_level, + TRACE("Uploading compressed data, target %#x, level %u, layer %u, x %d, y %d, w %u, h %u, " + "format %#x, image_size %#x, addr %p.\n", + surface->texture_target, surface->texture_level, surface->texture_layer, dst_point->x, dst_point->y, update_w, update_h, internal, row_count * row_length, addr); if (row_length == src_pitch) { - GL_EXTCALL(glCompressedTexSubImage2D(surface->texture_target, surface->texture_level, - dst_point->x, dst_point->y, update_w, update_h, internal, row_count * row_length, addr)); + if (surface->texture_target == GL_TEXTURE_2D_ARRAY) + { + GL_EXTCALL(glCompressedTexSubImage3D(surface->texture_target, surface->texture_level, + dst_point->x, dst_point->y, surface->texture_layer, update_w, update_h, 1, + internal, row_count * row_length, addr)); + } + else + { + GL_EXTCALL(glCompressedTexSubImage2D(surface->texture_target, surface->texture_level, + dst_point->x, dst_point->y, update_w, update_h, + internal, row_count * row_length, addr)); + } } else { @@ -1010,13 +1021,23 @@ void wined3d_surface_upload_data(struct wined3d_surface *surface, const struct w * can't use the unpack row length like for glTexSubImage2D. */ for (row = 0, y = dst_point->y; row < row_count; ++row) { - GL_EXTCALL(glCompressedTexSubImage2D(surface->texture_target, surface->texture_level, - dst_point->x, y, update_w, format->block_height, internal, row_length, addr)); + if (surface->texture_target == GL_TEXTURE_2D_ARRAY) + { + GL_EXTCALL(glCompressedTexSubImage3D(surface->texture_target, surface->texture_level, + dst_point->x, y, surface->texture_layer, update_w, format->block_height, 1, + internal, row_length, addr)); + } + else + { + GL_EXTCALL(glCompressedTexSubImage2D(surface->texture_target, surface->texture_level, + dst_point->x, y, update_w, format->block_height, internal, row_length, addr)); + } + y += format->block_height; addr += src_pitch; } } - checkGLcall("glCompressedTexSubImage2D"); + checkGLcall("Upload compressed surface data"); } else { @@ -1025,15 +1046,25 @@ void wined3d_surface_upload_data(struct wined3d_surface *surface, const struct w addr += src_rect->top * src_pitch; addr += src_rect->left * format->byte_count; - TRACE("glTexSubImage2D, target %#x, level %d, x %d, y %d, w %d, h %d, format %#x, type %#x, addr %p.\n", - surface->texture_target, surface->texture_level, dst_point->x, dst_point->y, - update_w, update_h, format->glFormat, format->glType, addr); + TRACE("Uploading data, target %#x, level %u, layer %u, x %d, y %d, w %u, h %u, " + "format %#x, type %#x, addr %p.\n", + surface->texture_target, surface->texture_level, surface->texture_layer, + dst_point->x, dst_point->y, update_w, update_h, format->glFormat, format->glType, addr); gl_info->gl_ops.gl.p_glPixelStorei(GL_UNPACK_ROW_LENGTH, src_pitch / format->byte_count); - gl_info->gl_ops.gl.p_glTexSubImage2D(surface->texture_target, surface->texture_level, - dst_point->x, dst_point->y, update_w, update_h, format->glFormat, format->glType, addr); + if (surface->texture_target == GL_TEXTURE_2D_ARRAY) + { + GL_EXTCALL(glTexSubImage3D(surface->texture_target, surface->texture_level, + dst_point->x, dst_point->y, surface->texture_layer, update_w, update_h, 1, + format->glFormat, format->glType, addr)); + } + else + { + gl_info->gl_ops.gl.p_glTexSubImage2D(surface->texture_target, surface->texture_level, + dst_point->x, dst_point->y, update_w, update_h, format->glFormat, format->glType, addr); + } gl_info->gl_ops.gl.p_glPixelStorei(GL_UNPACK_ROW_LENGTH, 0); - checkGLcall("glTexSubImage2D"); + checkGLcall("Upload surface data"); } if (data->buffer_object) diff --git a/dlls/wined3d/texture.c b/dlls/wined3d/texture.c index 5e18c4c..3a03bb6 100644 --- a/dlls/wined3d/texture.c +++ b/dlls/wined3d/texture.c @@ -1359,10 +1359,10 @@ static BOOL texture2d_load_location(struct wined3d_texture *texture, unsigned in /* Context activation is done by the caller. */ static void texture2d_prepare_texture(struct wined3d_texture *texture, struct wined3d_context *context, BOOL srgb) { - UINT sub_count = texture->level_count * texture->layer_count; const struct wined3d_format *format = texture->resource.format; const struct wined3d_gl_info *gl_info = context->gl_info; const struct wined3d_color_key_conversion *conversion; + unsigned int sub_call_count; GLenum internal; UINT i; @@ -1394,7 +1394,10 @@ static void texture2d_prepare_texture(struct wined3d_texture *texture, struct wi TRACE("internal %#x, format %#x, type %#x.\n", internal, format->glFormat, format->glType); - for (i = 0; i < sub_count; ++i) + sub_call_count = texture->level_count; + if (texture->target != GL_TEXTURE_2D_ARRAY) + sub_call_count *= texture->layer_count; + for (i = 0; i < sub_call_count; ++i) { struct wined3d_surface *surface = texture->sub_resources[i].u.surface; GLsizei width, height; @@ -1407,12 +1410,22 @@ static void texture2d_prepare_texture(struct wined3d_texture *texture, struct wi height /= format->height_scale.denominator; } - TRACE("surface %p, target %#x, level %d, width %d, height %d.\n", + TRACE("surface %p, target %#x, level %u, width %u, height %u.\n", surface, surface->texture_target, surface->texture_level, width, height); - gl_info->gl_ops.gl.p_glTexImage2D(surface->texture_target, surface->texture_level, - internal, width, height, 0, format->glFormat, format->glType, NULL); - checkGLcall("glTexImage2D"); + if (texture->target == GL_TEXTURE_2D_ARRAY) + { + GL_EXTCALL(glTexImage3D(surface->texture_target, surface->texture_level, + internal, width, height, texture->layer_count, 0, + format->glFormat, format->glType, NULL)); + checkGLcall("glTexImage3D"); + } + else + { + gl_info->gl_ops.gl.p_glTexImage2D(surface->texture_target, surface->texture_level, + internal, width, height, 0, format->glFormat, format->glType, NULL); + checkGLcall("glTexImage2D"); + } } } @@ -1778,8 +1791,12 @@ static HRESULT texture_init(struct wined3d_texture *texture, const struct wined3 unsigned int i, j; HRESULT hr; - if (!(desc->usage & WINED3DUSAGE_LEGACY_CUBEMAP) && layer_count != 1) - FIXME("Array textures not implemented.\n"); + if (!(desc->usage & WINED3DUSAGE_LEGACY_CUBEMAP) && layer_count > 1 + && !gl_info->supported[EXT_TEXTURE_ARRAY]) + { + WARN("OpenGL implementation does not support array textures.\n"); + return WINED3DERR_INVALIDCALL; + } /* TODO: It should only be possible to create textures for formats * that are reported as supported. */ @@ -1909,6 +1926,8 @@ static HRESULT texture_init(struct wined3d_texture *texture, const struct wined3 } if (desc->usage & WINED3DUSAGE_LEGACY_CUBEMAP) texture->target = GL_TEXTURE_CUBE_MAP_ARB; + else if (layer_count > 1) + texture->target = GL_TEXTURE_2D_ARRAY; else texture->target = GL_TEXTURE_2D; }
1
0
0
0
Józef Kucia : wined3d: Add "layer_count" parameter to wined3d_texture_create().
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: 64014ae3ed5ff5785ccbb74684ab2c7ffab157b4 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=64014ae3ed5ff5785ccbb7468…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Mon Apr 25 12:25:29 2016 +0200 wined3d: Add "layer_count" parameter to wined3d_texture_create(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d10core/tests/device.c | 6 +++--- dlls/d3d11/tests/d3d11.c | 6 +++--- dlls/d3d11/texture.c | 8 +++----- dlls/d3d8/device.c | 4 ++-- dlls/d3d8/texture.c | 6 +++--- dlls/d3d9/device.c | 4 ++-- dlls/d3d9/texture.c | 6 +++--- dlls/ddraw/ddraw.c | 2 +- dlls/ddraw/surface.c | 4 ++-- dlls/wined3d/device.c | 4 ++-- dlls/wined3d/surface.c | 2 +- dlls/wined3d/texture.c | 47 +++++++++++++++++++++++++++++++------------ dlls/wined3d/wined3d.spec | 2 +- include/wine/wined3d.h | 4 ++-- 14 files changed, 62 insertions(+), 43 deletions(-) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=64014ae3ed5ff5785ccbb…
1
0
0
0
Dmitry Timoshkov : shlwapi: Fix IStream::Read() return value for partial reads.
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: 860f5562c70520a0acfe0cec6261dc8e96bfc619 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=860f5562c70520a0acfe0cec6…
Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Mon Apr 25 22:39:04 2016 +0200 shlwapi: Fix IStream::Read() return value for partial reads. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/shlwapi/istream.c | 2 +- dlls/shlwapi/tests/istream.c | 15 ++++++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/dlls/shlwapi/istream.c b/dlls/shlwapi/istream.c index e641995..946d2c8 100644 --- a/dlls/shlwapi/istream.c +++ b/dlls/shlwapi/istream.c @@ -130,7 +130,7 @@ static HRESULT WINAPI IStream_fnRead(IStream *iface, void* pv, ULONG cb, ULONG* } if (pcbRead) *pcbRead = dwRead; - return S_OK; + return dwRead == cb ? S_OK : S_FALSE; } /************************************************************************** diff --git a/dlls/shlwapi/tests/istream.c b/dlls/shlwapi/tests/istream.c index 48a292a..c9cf62f 100644 --- a/dlls/shlwapi/tests/istream.c +++ b/dlls/shlwapi/tests/istream.c @@ -247,11 +247,24 @@ static void test_stream_read_write(IStream *stream, DWORD mode) } else { -todo_wine ok(ret == S_FALSE, "expected S_FALSE, got %#x (access %#x, written %u)\n", ret, mode, written); ok(count == 0, "expected 0, got %u\n", count); } + ret = stream->lpVtbl->Seek(stream, start, STREAM_SEEK_SET, NULL); + ok(ret == S_OK, "Seek error %#x\n", ret); + + count = 0xdeadbeaf; + ret = stream->lpVtbl->Read(stream, buf, 0, &count); + ok(ret == S_OK, "IStream_Read error %#x (access %#x, written %u)\n", ret, mode, written); + ok(count == 0, "expected 0, got %u\n", count); + + count = 0xdeadbeaf; + ret = stream->lpVtbl->Read(stream, buf, sizeof(buf), &count); + ok(ret == S_FALSE, "expected S_FALSE, got %#x (access %#x, written %u)\n", ret, mode, written); + ok(count == written, "expected %u, got %u\n", written, count); + if (count) + ok(buf[0] == 0x5e && buf[1] == 0xa7, "expected 5ea7, got %02x%02x\n", buf[0], buf[1]); } static void test_SHCreateStreamOnFileA(DWORD mode, DWORD stgm)
1
0
0
0
Sebastian Lackner : server: Fix possible leak of root object in create_named_pipe handler.
by Alexandre Julliard
26 Apr '16
26 Apr '16
Module: wine Branch: master Commit: 20651c7dfe74aad58d17e527438df350b1b1afac URL:
http://source.winehq.org/git/wine.git/?a=commit;h=20651c7dfe74aad58d17e5274…
Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Tue Apr 26 03:34:58 2016 +0200 server: Fix possible leak of root object in create_named_pipe handler. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- server/named_pipe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/server/named_pipe.c b/server/named_pipe.c index f41c26e..0661c12 100644 --- a/server/named_pipe.c +++ b/server/named_pipe.c @@ -901,6 +901,7 @@ DECL_HANDLER(create_named_pipe) if (!req->sharing || (req->sharing & ~(FILE_SHARE_READ | FILE_SHARE_WRITE)) || (!(req->flags & NAMED_PIPE_MESSAGE_STREAM_WRITE) && (req->flags & NAMED_PIPE_MESSAGE_STREAM_READ))) { + if (root) release_object( root ); set_error( STATUS_INVALID_PARAMETER ); return; }
1
0
0
0
← Newer
1
...
7
8
9
10
11
12
13
...
75
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
Results per page:
10
25
50
100
200