wine-commits May 2016

wine-commits@winehq.org

4 participants
542 discussions

Jacek Caban : msctf: Moved thread manager' s sink list destructor implementation into a more generic helper.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: a27da35b0540bd6a45adb27c880d89c16b8df2dd URL: http://source.winehq.org/git/wine.git/?a=commit;h=a27da35b0540bd6a45adb27c8… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 4 19:41:13 2016 +0200 msctf: Moved thread manager's sink list destructor implementation into a more generic helper. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msctf/msctf.c | 9 +++++++++ dlls/msctf/msctf_internal.h | 1 + dlls/msctf/threadmgr.c | 49 ++++++--------------------------------------- 3 files changed, 16 insertions(+), 43 deletions(-) diff --git a/dlls/msctf/msctf.c b/dlls/msctf/msctf.c index 81f01dc..a47f16c 100644 --- a/dlls/msctf/msctf.c +++ b/dlls/msctf/msctf.c @@ -323,6 +323,15 @@ HRESULT unadvise_sink(DWORD cookie) return S_OK; } +void free_sinks(struct list *sink_list) +{ + while(!list_empty(sink_list)) + { + Sink* sink = LIST_ENTRY(sink_list->next, Sink, entry); + free_sink(sink); + } +} + /***************************************************************************** * Active Text Service Management *****************************************************************************/ diff --git a/dlls/msctf/msctf_internal.h b/dlls/msctf/msctf_internal.h index fc41de5..e4da480 100644 --- a/dlls/msctf/msctf_internal.h +++ b/dlls/msctf/msctf_internal.h @@ -77,6 +77,7 @@ typedef struct { HRESULT advise_sink(struct list *sink_list, REFIID riid, DWORD cookie_magic, IUnknown *unk, DWORD *cookie) DECLSPEC_HIDDEN; HRESULT unadvise_sink(DWORD cookie) DECLSPEC_HIDDEN; +void free_sinks(struct list *sink_list) DECLSPEC_HIDDEN; extern const WCHAR szwSystemTIPKey[] DECLSPEC_HIDDEN; extern const WCHAR szwSystemCTFKey[] DECLSPEC_HIDDEN; diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index bface5d..62508b9 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -157,12 +157,6 @@ static inline EnumTfDocumentMgr *impl_from_IEnumTfDocumentMgrs(IEnumTfDocumentMg return CONTAINING_RECORD(iface, EnumTfDocumentMgr, IEnumTfDocumentMgrs_iface); } -static void free_sink(Sink *sink) -{ - IUnknown_Release(sink->interfaces.pIUnknown); - HeapFree(GetProcessHeap(),0,sink); -} - static void ThreadMgr_Destructor(ThreadMgr *This) { struct list *cursor, *cursor2; @@ -176,43 +170,12 @@ static void ThreadMgr_Destructor(ThreadMgr *This) if (This->focus) ITfDocumentMgr_Release(This->focus); - /* free sinks */ - LIST_FOR_EACH_SAFE(cursor, cursor2, &This->ActiveLanguageProfileNotifySink) - { - Sink* sink = LIST_ENTRY(cursor,Sink,entry); - list_remove(cursor); - free_sink(sink); - } - LIST_FOR_EACH_SAFE(cursor, cursor2, &This->DisplayAttributeNotifySink) - { - Sink* sink = LIST_ENTRY(cursor,Sink,entry); - list_remove(cursor); - free_sink(sink); - } - LIST_FOR_EACH_SAFE(cursor, cursor2, &This->KeyTraceEventSink) - { - Sink* sink = LIST_ENTRY(cursor,Sink,entry); - list_remove(cursor); - free_sink(sink); - } - LIST_FOR_EACH_SAFE(cursor, cursor2, &This->PreservedKeyNotifySink) - { - Sink* sink = LIST_ENTRY(cursor,Sink,entry); - list_remove(cursor); - free_sink(sink); - } - LIST_FOR_EACH_SAFE(cursor, cursor2, &This->ThreadFocusSink) - { - Sink* sink = LIST_ENTRY(cursor,Sink,entry); - list_remove(cursor); - free_sink(sink); - } - LIST_FOR_EACH_SAFE(cursor, cursor2, &This->ThreadMgrEventSink) - { - Sink* sink = LIST_ENTRY(cursor,Sink,entry); - list_remove(cursor); - free_sink(sink); - } + free_sinks(&This->ActiveLanguageProfileNotifySink); + free_sinks(&This->DisplayAttributeNotifySink); + free_sinks(&This->KeyTraceEventSink); + free_sinks(&This->PreservedKeyNotifySink); + free_sinks(&This->ThreadFocusSink); + free_sinks(&This->ThreadMgrEventSink); LIST_FOR_EACH_SAFE(cursor, cursor2, &This->CurrentPreservedKeys) {

1 0

Jacek Caban : msctf: Moved thread manager' s UnadviseSink implementation into a more generic helper.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: 0374ee290d25f85abb06aa40f4d61950c44e98a6 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0374ee290d25f85abb06aa40f… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 4 19:40:59 2016 +0200 msctf: Moved thread manager's UnadviseSink implementation into a more generic helper. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msctf/msctf.c | 19 +++++++++++++++++++ dlls/msctf/msctf_internal.h | 1 + dlls/msctf/threadmgr.c | 10 +--------- 3 files changed, 21 insertions(+), 9 deletions(-) diff --git a/dlls/msctf/msctf.c b/dlls/msctf/msctf.c index 23845d4..81f01dc 100644 --- a/dlls/msctf/msctf.c +++ b/dlls/msctf/msctf.c @@ -304,6 +304,25 @@ HRESULT advise_sink(struct list *sink_list, REFIID riid, DWORD cookie_magic, IUn return S_OK; } +static void free_sink(Sink *sink) +{ + list_remove(&sink->entry); + IUnknown_Release(sink->interfaces.pIUnknown); + HeapFree(GetProcessHeap(), 0, sink); +} + +HRESULT unadvise_sink(DWORD cookie) +{ + Sink *sink; + + sink = remove_Cookie(cookie); + if (!sink) + return CONNECT_E_NOCONNECTION; + + free_sink(sink); + return S_OK; +} + /***************************************************************************** * Active Text Service Management *****************************************************************************/ diff --git a/dlls/msctf/msctf_internal.h b/dlls/msctf/msctf_internal.h index 1f7e7df..fc41de5 100644 --- a/dlls/msctf/msctf_internal.h +++ b/dlls/msctf/msctf_internal.h @@ -76,6 +76,7 @@ typedef struct { } Sink; HRESULT advise_sink(struct list *sink_list, REFIID riid, DWORD cookie_magic, IUnknown *unk, DWORD *cookie) DECLSPEC_HIDDEN; +HRESULT unadvise_sink(DWORD cookie) DECLSPEC_HIDDEN; extern const WCHAR szwSystemTIPKey[] DECLSPEC_HIDDEN; extern const WCHAR szwSystemCTFKey[] DECLSPEC_HIDDEN; diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index c6a227c..bface5d 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -659,21 +659,13 @@ static HRESULT WINAPI ThreadMgrSource_AdviseSink(ITfSource *iface, static HRESULT WINAPI ThreadMgrSource_UnadviseSink(ITfSource *iface, DWORD pdwCookie) { ThreadMgr *This = impl_from_ITfSource(iface); - Sink *sink; TRACE("(%p) %x\n",This,pdwCookie); if (get_Cookie_magic(pdwCookie)!=COOKIE_MAGIC_TMSINK) return E_INVALIDARG; - sink = remove_Cookie(pdwCookie); - if (!sink) - return CONNECT_E_NOCONNECTION; - - list_remove(&sink->entry); - free_sink(sink); - - return S_OK; + return unadvise_sink(pdwCookie); } static const ITfSourceVtbl ThreadMgrSourceVtbl =

1 0

Jacek Caban : msctf: Moved thread manager' s AdviseSink implementation into a more generic helper.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: c0efd074b2fc9bec2a520d8a80bdbd74c8d562dc URL: http://source.winehq.org/git/wine.git/?a=commit;h=c0efd074b2fc9bec2a520d8a8… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 4 19:40:47 2016 +0200 msctf: Moved thread manager's AdviseSink implementation into a more generic helper. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msctf/msctf.c | 21 +++++++++++++++++++++ dlls/msctf/msctf_internal.h | 2 ++ dlls/msctf/threadmgr.c | 24 +++--------------------- 3 files changed, 26 insertions(+), 21 deletions(-) diff --git a/dlls/msctf/msctf.c b/dlls/msctf/msctf.c index 83eaab9..23845d4 100644 --- a/dlls/msctf/msctf.c +++ b/dlls/msctf/msctf.c @@ -32,6 +32,7 @@ #include "shlwapi.h" #include "shlguid.h" #include "comcat.h" +#include "olectl.h" #include "rpcproxy.h" #include "msctf.h" #include "inputscope.h" @@ -283,6 +284,26 @@ DWORD enumerate_Cookie(DWORD magic, DWORD *index) return 0x0; } +HRESULT advise_sink(struct list *sink_list, REFIID riid, DWORD cookie_magic, IUnknown *unk, DWORD *cookie) +{ + Sink *sink; + + sink = HeapAlloc(GetProcessHeap(), 0, sizeof(*sink)); + if (!sink) + return E_OUTOFMEMORY; + + if (FAILED(IUnknown_QueryInterface(unk, riid, (void**)&sink->interfaces.pIUnknown))) + { + HeapFree(GetProcessHeap(), 0, sink); + return CONNECT_E_CANNOTCONNECT; + } + + list_add_head(sink_list, &sink->entry); + *cookie = generate_Cookie(cookie_magic, sink); + TRACE("cookie %x\n", *cookie); + return S_OK; +} + /***************************************************************************** * Active Text Service Management *****************************************************************************/ diff --git a/dlls/msctf/msctf_internal.h b/dlls/msctf/msctf_internal.h index 8923c60..1f7e7df 100644 --- a/dlls/msctf/msctf_internal.h +++ b/dlls/msctf/msctf_internal.h @@ -75,6 +75,8 @@ typedef struct { } interfaces; } Sink; +HRESULT advise_sink(struct list *sink_list, REFIID riid, DWORD cookie_magic, IUnknown *unk, DWORD *cookie) DECLSPEC_HIDDEN; + extern const WCHAR szwSystemTIPKey[] DECLSPEC_HIDDEN; extern const WCHAR szwSystemCTFKey[] DECLSPEC_HIDDEN; diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index 44e8c87..c6a227c 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -643,7 +643,6 @@ static HRESULT WINAPI ThreadMgrSource_AdviseSink(ITfSource *iface, REFIID riid, IUnknown *punk, DWORD *pdwCookie) { ThreadMgr *This = impl_from_ITfSource(iface); - Sink *tms; TRACE("(%p) %s %p %p\n",This,debugstr_guid(riid),punk,pdwCookie); @@ -651,27 +650,10 @@ static HRESULT WINAPI ThreadMgrSource_AdviseSink(ITfSource *iface, return E_INVALIDARG; if (IsEqualIID(riid, &IID_ITfThreadMgrEventSink)) - { - tms = HeapAlloc(GetProcessHeap(),0,sizeof(*tms)); - if (!tms) - return E_OUTOFMEMORY; - if (FAILED(IUnknown_QueryInterface(punk, riid, (LPVOID *)&tms->interfaces.pITfThreadMgrEventSink))) - { - HeapFree(GetProcessHeap(),0,tms); - return CONNECT_E_CANNOTCONNECT; - } - list_add_head(&This->ThreadMgrEventSink,&tms->entry); - *pdwCookie = generate_Cookie(COOKIE_MAGIC_TMSINK, tms); - } - else - { - FIXME("(%p) Unhandled Sink: %s\n",This,debugstr_guid(riid)); - return E_NOTIMPL; - } - - TRACE("cookie %x\n",*pdwCookie); + return advise_sink(&This->ThreadMgrEventSink, &IID_ITfThreadMgrEventSink, COOKIE_MAGIC_TMSINK, punk, pdwCookie); - return S_OK; + FIXME("(%p) Unhandled Sink: %s\n",This,debugstr_guid(riid)); + return E_NOTIMPL; } static HRESULT WINAPI ThreadMgrSource_UnadviseSink(ITfSource *iface, DWORD pdwCookie)

1 0

Jacek Caban : msctf: Use generic sink type for thread manager sinks.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: 0b912fecf6e9b6fcf022d0533952ce42d9841add URL: http://source.winehq.org/git/wine.git/?a=commit;h=0b912fecf6e9b6fcf022d0533… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 4 19:40:29 2016 +0200 msctf: Use generic sink type for thread manager sinks. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msctf/compartmentmgr.c | 1 - dlls/msctf/context.c | 1 - dlls/msctf/inputprocessor.c | 1 - dlls/msctf/msctf.c | 1 - dlls/msctf/msctf_internal.h | 10 ++++++++++ dlls/msctf/threadmgr.c | 45 +++++++++++++++------------------------------ 6 files changed, 25 insertions(+), 34 deletions(-) diff --git a/dlls/msctf/compartmentmgr.c b/dlls/msctf/compartmentmgr.c index 8182679..c39f194 100644 --- a/dlls/msctf/compartmentmgr.c +++ b/dlls/msctf/compartmentmgr.c @@ -36,7 +36,6 @@ #include "olectl.h" #include "wine/unicode.h" -#include "wine/list.h" #include "msctf.h" #include "msctf_internal.h" diff --git a/dlls/msctf/context.c b/dlls/msctf/context.c index 5a45466..fd23c2a 100644 --- a/dlls/msctf/context.c +++ b/dlls/msctf/context.c @@ -35,7 +35,6 @@ #include "olectl.h" #include "wine/unicode.h" -#include "wine/list.h" #include "msctf.h" #include "msctf_internal.h" diff --git a/dlls/msctf/inputprocessor.c b/dlls/msctf/inputprocessor.c index 01af325..08e51fd 100644 --- a/dlls/msctf/inputprocessor.c +++ b/dlls/msctf/inputprocessor.c @@ -35,7 +35,6 @@ #include "olectl.h" #include "wine/unicode.h" -#include "wine/list.h" #include "msctf.h" #include "msctf_internal.h" diff --git a/dlls/msctf/msctf.c b/dlls/msctf/msctf.c index a5cfc35..83eaab9 100644 --- a/dlls/msctf/msctf.c +++ b/dlls/msctf/msctf.c @@ -26,7 +26,6 @@ #define COBJMACROS #include "wine/debug.h" -#include "wine/list.h" #include "windef.h" #include "winbase.h" #include "winreg.h" diff --git a/dlls/msctf/msctf_internal.h b/dlls/msctf/msctf_internal.h index 06244ea..8923c60 100644 --- a/dlls/msctf/msctf_internal.h +++ b/dlls/msctf/msctf_internal.h @@ -21,6 +21,8 @@ #ifndef __WINE_MSCTF_I_H #define __WINE_MSCTF_I_H +#include "wine/list.h" + #define COOKIE_MAGIC_TMSINK 0x0010 #define COOKIE_MAGIC_CONTEXTSINK 0x0020 #define COOKIE_MAGIC_GUIDATOM 0x0030 @@ -65,6 +67,14 @@ extern CLSID get_textservice_clsid(TfClientId tid) DECLSPEC_HIDDEN; extern HRESULT get_textservice_sink(TfClientId tid, REFCLSID iid, IUnknown** sink) DECLSPEC_HIDDEN; extern HRESULT set_textservice_sink(TfClientId tid, REFCLSID iid, IUnknown* sink) DECLSPEC_HIDDEN; +typedef struct { + struct list entry; + union { + IUnknown *pIUnknown; + ITfThreadMgrEventSink *pITfThreadMgrEventSink; + } interfaces; +} Sink; + extern const WCHAR szwSystemTIPKey[] DECLSPEC_HIDDEN; extern const WCHAR szwSystemCTFKey[] DECLSPEC_HIDDEN; diff --git a/dlls/msctf/threadmgr.c b/dlls/msctf/threadmgr.c index ac47545..44e8c87 100644 --- a/dlls/msctf/threadmgr.c +++ b/dlls/msctf/threadmgr.c @@ -35,27 +35,12 @@ #include "olectl.h" #include "wine/unicode.h" -#include "wine/list.h" #include "msctf.h" #include "msctf_internal.h" WINE_DEFAULT_DEBUG_CHANNEL(msctf); -typedef struct tagThreadMgrSink { - struct list entry; - union { - /* ThreadMgr Sinks */ - IUnknown *pIUnknown; - /* ITfActiveLanguageProfileNotifySink *pITfActiveLanguageProfileNotifySink; */ - /* ITfDisplayAttributeNotifySink *pITfDisplayAttributeNotifySink; */ - /* ITfKeyTraceEventSink *pITfKeyTraceEventSink; */ - /* ITfPreservedKeyNotifySink *pITfPreservedKeyNotifySink; */ - /* ITfThreadFocusSink *pITfThreadFocusSink; */ - ITfThreadMgrEventSink *pITfThreadMgrEventSink; - } interfaces; -} ThreadMgrSink; - typedef struct tagPreservedKey { struct list entry; @@ -172,7 +157,7 @@ static inline EnumTfDocumentMgr *impl_from_IEnumTfDocumentMgrs(IEnumTfDocumentMg return CONTAINING_RECORD(iface, EnumTfDocumentMgr, IEnumTfDocumentMgrs_iface); } -static void free_sink(ThreadMgrSink *sink) +static void free_sink(Sink *sink) { IUnknown_Release(sink->interfaces.pIUnknown); HeapFree(GetProcessHeap(),0,sink); @@ -194,37 +179,37 @@ static void ThreadMgr_Destructor(ThreadMgr *This) /* free sinks */ LIST_FOR_EACH_SAFE(cursor, cursor2, &This->ActiveLanguageProfileNotifySink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); list_remove(cursor); free_sink(sink); } LIST_FOR_EACH_SAFE(cursor, cursor2, &This->DisplayAttributeNotifySink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); list_remove(cursor); free_sink(sink); } LIST_FOR_EACH_SAFE(cursor, cursor2, &This->KeyTraceEventSink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); list_remove(cursor); free_sink(sink); } LIST_FOR_EACH_SAFE(cursor, cursor2, &This->PreservedKeyNotifySink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); list_remove(cursor); free_sink(sink); } LIST_FOR_EACH_SAFE(cursor, cursor2, &This->ThreadFocusSink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); list_remove(cursor); free_sink(sink); } LIST_FOR_EACH_SAFE(cursor, cursor2, &This->ThreadMgrEventSink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); list_remove(cursor); free_sink(sink); } @@ -658,7 +643,7 @@ static HRESULT WINAPI ThreadMgrSource_AdviseSink(ITfSource *iface, REFIID riid, IUnknown *punk, DWORD *pdwCookie) { ThreadMgr *This = impl_from_ITfSource(iface); - ThreadMgrSink *tms; + Sink *tms; TRACE("(%p) %s %p %p\n",This,debugstr_guid(riid),punk,pdwCookie); @@ -667,7 +652,7 @@ static HRESULT WINAPI ThreadMgrSource_AdviseSink(ITfSource *iface, if (IsEqualIID(riid, &IID_ITfThreadMgrEventSink)) { - tms = HeapAlloc(GetProcessHeap(),0,sizeof(ThreadMgrSink)); + tms = HeapAlloc(GetProcessHeap(),0,sizeof(*tms)); if (!tms) return E_OUTOFMEMORY; if (FAILED(IUnknown_QueryInterface(punk, riid, (LPVOID *)&tms->interfaces.pITfThreadMgrEventSink))) @@ -692,7 +677,7 @@ static HRESULT WINAPI ThreadMgrSource_AdviseSink(ITfSource *iface, static HRESULT WINAPI ThreadMgrSource_UnadviseSink(ITfSource *iface, DWORD pdwCookie) { ThreadMgr *This = impl_from_ITfSource(iface); - ThreadMgrSink *sink; + Sink *sink; TRACE("(%p) %x\n",This,pdwCookie); @@ -1164,7 +1149,7 @@ static HRESULT WINAPI ThreadMgrEventSink_OnInitDocumentMgr( LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); ITfThreadMgrEventSink_OnInitDocumentMgr(sink->interfaces.pITfThreadMgrEventSink,pdim); } @@ -1181,7 +1166,7 @@ static HRESULT WINAPI ThreadMgrEventSink_OnUninitDocumentMgr( LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); ITfThreadMgrEventSink_OnUninitDocumentMgr(sink->interfaces.pITfThreadMgrEventSink,pdim); } @@ -1199,7 +1184,7 @@ static HRESULT WINAPI ThreadMgrEventSink_OnSetFocus( LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); ITfThreadMgrEventSink_OnSetFocus(sink->interfaces.pITfThreadMgrEventSink, pdimFocus, pdimPrevFocus); } @@ -1216,7 +1201,7 @@ static HRESULT WINAPI ThreadMgrEventSink_OnPushContext( LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); ITfThreadMgrEventSink_OnPushContext(sink->interfaces.pITfThreadMgrEventSink,pic); } @@ -1233,7 +1218,7 @@ static HRESULT WINAPI ThreadMgrEventSink_OnPopContext( LIST_FOR_EACH(cursor, &This->ThreadMgrEventSink) { - ThreadMgrSink* sink = LIST_ENTRY(cursor,ThreadMgrSink,entry); + Sink* sink = LIST_ENTRY(cursor,Sink,entry); ITfThreadMgrEventSink_OnPopContext(sink->interfaces.pITfThreadMgrEventSink,pic); }

1 0

Jacek Caban : msctf.idl: Added ITfTransitoryExtensionSink declaration.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: 8f91f7403e24952e40c72d2e36fbc05374f55c48 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8f91f7403e24952e40c72d2e3… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Wed May 4 19:40:18 2016 +0200 msctf.idl: Added ITfTransitoryExtensionSink declaration. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/msctf.idl | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/msctf.idl b/include/msctf.idl index 62dc0d6..0b96faa 100644 --- a/include/msctf.idl +++ b/include/msctf.idl @@ -1845,3 +1845,19 @@ interface ITfMouseTrackerACP : IUnknown HRESULT UnadviseMouseSink([in] DWORD dwCookie); } + +[ + object, + local, + uuid(a615096f-1c57-4813-8a15-55ee6e5a839c), + pointer_default(unique) +] +interface ITfTransitoryExtensionSink : IUnknown +{ + HRESULT OnTransitoryExtensionUpdated( + [in] ITfContext *pic, + [in] TfEditCookie ecReadOnly, + [in] ITfRange *pResultRange, + [in] ITfRange *pCompositionRange, + [out] BOOL *pfDeleteResultRange); +}

1 0

Daniel Lehman : ntdll: Remove stub from trace.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: 4c89d567f6d9705b528bd9905399ee0b71a475a9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4c89d567f6d9705b528bd9905… Author: Daniel Lehman <dlehman25(a)gmail.com> Date: Wed May 4 20:33:07 2016 -0700 ntdll: Remove stub from trace. Signed-off-by: Daniel Lehman <dlehman25(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/sync.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/ntdll/sync.c b/dlls/ntdll/sync.c index 74f7779..bef85a8 100644 --- a/dlls/ntdll/sync.c +++ b/dlls/ntdll/sync.c @@ -856,7 +856,7 @@ NTSTATUS WINAPI NtSetTimer(IN HANDLE handle, { NTSTATUS status = STATUS_SUCCESS; - TRACE("(%p,%p,%p,%p,%08x,0x%08x,%p) stub\n", + TRACE("(%p,%p,%p,%p,%08x,0x%08x,%p)\n", handle, when, callback, callback_arg, resume, period, state); SERVER_START_REQ( set_timer )

1 0

Alistair Leslie-Hughes : inetcomm: Ignore OID_SAVEBODY_KEEPBOUNDARY value in IMimeMessage_SetOption.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: c51c319b9f5f55103c49ec6876ad3f7730c8b525 URL: http://source.winehq.org/git/wine.git/?a=commit;h=c51c319b9f5f55103c49ec687… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Tue May 3 09:17:45 2016 +0000 inetcomm: Ignore OID_SAVEBODY_KEEPBOUNDARY value in IMimeMessage_SetOption. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/inetcomm/mimeole.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/dlls/inetcomm/mimeole.c b/dlls/inetcomm/mimeole.c index c653555..14739ab 100644 --- a/dlls/inetcomm/mimeole.c +++ b/dlls/inetcomm/mimeole.c @@ -2331,6 +2331,9 @@ static HRESULT WINAPI MimeMessage_SetOption( case OID_SHOW_MACBINARY: FIXME("OID_SHOW_MACBINARY (value %d): ignoring\n", pValue->u.boolVal); break; + case OID_SAVEBODY_KEEPBOUNDARY: + FIXME("OID_SAVEBODY_KEEPBOUNDARY (value %d): ignoring\n", pValue->u.boolVal); + break; default: FIXME("Unhandled oid %08x\n", oid); hr = MIME_E_INVALID_OPTION_ID;

1 0

Alistair Leslie-Hughes : inetcomm: Improve IMimeMessage SetOption.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: dcb659f03228fa9364cdcccda5a5ca0f6e17369d URL: http://source.winehq.org/git/wine.git/?a=commit;h=dcb659f03228fa9364cdcccda… Author: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Date: Tue May 3 09:17:36 2016 +0000 inetcomm: Improve IMimeMessage SetOption. Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/inetcomm/mimeole.c | 16 ++++++++++++---- dlls/inetcomm/tests/mimeole.c | 13 ++++++++++--- include/mimeole.idl | 4 ++++ 3 files changed, 26 insertions(+), 7 deletions(-) diff --git a/dlls/inetcomm/mimeole.c b/dlls/inetcomm/mimeole.c index 96eab81..c653555 100644 --- a/dlls/inetcomm/mimeole.c +++ b/dlls/inetcomm/mimeole.c @@ -2305,27 +2305,35 @@ static HRESULT WINAPI MimeMessage_SetOption( const TYPEDID oid, LPCPROPVARIANT pValue) { - HRESULT hr = E_NOTIMPL; + HRESULT hr = S_OK; TRACE("(%p)->(%08x, %p)\n", iface, oid, pValue); + /* Message ID is checked before type. + * OID 0x4D -> 0x56 and 0x58 aren't defined but will filtered out later. + */ + if(TYPEDID_ID(oid) < TYPEDID_ID(OID_ALLOW_8BIT_HEADER) || TYPEDID_ID(oid) > TYPEDID_ID(OID_SECURITY_2KEY_CERT_BAG_64)) + { + WARN("oid (%08x) out of range\n", oid); + return MIME_E_INVALID_OPTION_ID; + } + if(pValue->vt != TYPEDID_TYPE(oid)) { WARN("Called with vartype %04x and oid %08x\n", pValue->vt, oid); - return E_INVALIDARG; + return S_OK; } switch(oid) { case OID_HIDE_TNEF_ATTACHMENTS: FIXME("OID_HIDE_TNEF_ATTACHMENTS (value %d): ignoring\n", pValue->u.boolVal); - hr = S_OK; break; case OID_SHOW_MACBINARY: FIXME("OID_SHOW_MACBINARY (value %d): ignoring\n", pValue->u.boolVal); - hr = S_OK; break; default: FIXME("Unhandled oid %08x\n", oid); + hr = MIME_E_INVALID_OPTION_ID; } return hr; diff --git a/dlls/inetcomm/tests/mimeole.c b/dlls/inetcomm/tests/mimeole.c index 498bbb7..f0fac08 100644 --- a/dlls/inetcomm/tests/mimeole.c +++ b/dlls/inetcomm/tests/mimeole.c @@ -412,7 +412,7 @@ static void test_MessageOptions(void) prop.u.pszVal = CoTaskMemAlloc(strlen(string)+1); strcpy(prop.u.pszVal, string); hr = IMimeMessage_SetOption(msg, OID_HIDE_TNEF_ATTACHMENTS, &prop); - todo_wine ok(hr == S_OK, "ret %08x\n", hr); + ok(hr == S_OK, "ret %08x\n", hr); PropVariantClear(&prop); hr = IMimeMessage_GetOption(msg, OID_HIDE_TNEF_ATTACHMENTS, &prop); @@ -426,7 +426,7 @@ static void test_MessageOptions(void) prop.u.pszVal = CoTaskMemAlloc(strlen(zero)+1); strcpy(prop.u.pszVal, zero); hr = IMimeMessage_SetOption(msg, OID_HIDE_TNEF_ATTACHMENTS, &prop); - todo_wine ok(hr == S_OK, "ret %08x\n", hr); + ok(hr == S_OK, "ret %08x\n", hr); PropVariantClear(&prop); hr = IMimeMessage_GetOption(msg, OID_HIDE_TNEF_ATTACHMENTS, &prop); @@ -439,7 +439,14 @@ static void test_MessageOptions(void) prop.vt = VT_BOOL; prop.u.boolVal = TRUE; hr = IMimeMessage_SetOption(msg, 0xff00000a, &prop); - todo_wine ok(hr == MIME_E_INVALID_OPTION_ID, "ret %08x\n", hr); + ok(hr == MIME_E_INVALID_OPTION_ID, "ret %08x\n", hr); + PropVariantClear(&prop); + + /* Out of range before type. */ + prop.vt = VT_I4; + prop.u.lVal = 1; + hr = IMimeMessage_SetOption(msg, 0xff00000a, &prop); + ok(hr == MIME_E_INVALID_OPTION_ID, "ret %08x\n", hr); PropVariantClear(&prop); IMimeMessage_Release(msg); diff --git a/include/mimeole.idl b/include/mimeole.idl index 5990c29..4a0d86c 100644 --- a/include/mimeole.idl +++ b/include/mimeole.idl @@ -153,6 +153,7 @@ cpp_quote(" PID_ATT_ACCOUNTNAME = 78,") cpp_quote(" PID_LAST = 79,") cpp_quote("} MIMEPROPID;") +cpp_quote("#define TYPEDID_ID(_typedid) (((ULONG)(_typedid))>>16)") cpp_quote("#define TYPEDID_MASK ((ULONG)0xffff)") cpp_quote("#define TYPEDID_TYPE(t) ((VARTYPE)((t) & TYPEDID_MASK))") @@ -177,6 +178,9 @@ cpp_quote("#define OID_CAN_INLINE_TEXT_BODIES (0x00380000 | VT_BOOL)") cpp_quote("#define OID_SHOW_MACBINARY (0x00390000 | VT_BOOL)") cpp_quote("#define OID_SAVEBODY_KEEPBOUNDARY (0x00400000 | VT_BOOL)") +cpp_quote("#define OID_SECURITY_2KEY_CERT_BAG (0x00590000 | VT_VECTOR | VT_UI4)") +cpp_quote("#define OID_SECURITY_2KEY_CERT_BAG_64 (0x00590000 | VT_VECTOR | VT_UI8)") + [ uuid(e4b28371-83b0-11d0-8259-00c04fd85ab4), version(1.0)

1 0

Nikolay Sivov : po: Update Russian translation.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: 2fff4d0343842d9e9efc8e61f6e9021f1d73e5ee URL: http://source.winehq.org/git/wine.git/?a=commit;h=2fff4d0343842d9e9efc8e61f… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Wed May 4 22:23:45 2016 +0300 po: Update Russian translation. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/ru.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/po/ru.po b/po/ru.po index f6968af..a78a280 100644 --- a/po/ru.po +++ b/po/ru.po @@ -5,7 +5,7 @@ msgstr "" "Project-Id-Version: Wine\n" "Report-Msgid-Bugs-To: http://bugs.winehq.org\n" "POT-Creation-Date: N/A\n" -"PO-Revision-Date: 2016-04-14 19:13+0300\n" +"PO-Revision-Date: 2016-05-04 22:10+0300\n" "Last-Translator: Nikolay Sivov <nsivov(a)codeweavers.com>\n" "Language-Team: Russian\n" "Language: ru\n" @@ -11650,7 +11650,7 @@ msgstr "reg: не удалось завершить операцию. Произ #: reg.rc:55 msgid "Search complete. Number of matches found: %1!d!\n" -msgstr "" +msgstr "Поиск завершён. Найдено совпадений: %1!d!\n" #: regedit.rc:34 msgid "&Registry"

1 0

Andrew Eikum : winmm: Restrict some MCI actions to the creating thread.
by Alexandre Julliard 05 May '16

05 May '16

Module: wine Branch: master Commit: d7cc002566e375ccea62777befe3a67554ad6c48 URL: http://source.winehq.org/git/wine.git/?a=commit;h=d7cc002566e375ccea62777be… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed May 4 12:42:53 2016 -0500 winmm: Restrict some MCI actions to the creating thread. This reverts commit 46d5973961fe2266074ac2855368c3fcf987c1b5 and fixes bug 38241 another way. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Akihiro Sagawa <sagawa.aki(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mciqtz32/mciqtz.c | 199 +++++++++++------------------------------ dlls/mciqtz32/mciqtz_private.h | 13 --- dlls/winmm/mci.c | 6 ++ dlls/winmm/tests/mci.c | 41 +++++++++ 4 files changed, 97 insertions(+), 162 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=d7cc002566e375ccea627…

1 0

← Newer
1
...
42
43
44
45
46
47
48
...
55
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits May 2016