wine-commits July 2016

wine-commits@winehq.org

2 participants
680 discussions

Jacek Caban : mshtml: Get rid of no longer needed get_dispex_data function.
by Alexandre Julliard 06 Jul '16

06 Jul '16

Module: wine Branch: master Commit: fc42ccc3610e7f845ffb7ecee8cb9ebcdb0eae4d URL: http://source.winehq.org/git/wine.git/?a=commit;h=fc42ccc3610e7f845ffb7ecee… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 5 22:46:46 2016 +0200 mshtml: Get rid of no longer needed get_dispex_data function. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/dispex.c | 50 ++++++++++---------------------------------------- 1 file changed, 10 insertions(+), 40 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 4994eca..9a2cebd 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -469,11 +469,6 @@ HRESULT get_dispids(tid_t tid, DWORD *ret_size, DISPID **ret) return S_OK; } -static dispex_data_t *get_dispex_data(DispatchEx *This) -{ - return This->info; -} - static inline BOOL is_custom_dispid(DISPID id) { return MSHTML_DISPID_CUSTOM_MIN <= id && id <= MSHTML_DISPID_CUSTOM_MAX; @@ -895,25 +890,20 @@ static HRESULT get_builtin_func(dispex_data_t *data, DISPID id, func_info_t **re static HRESULT get_builtin_id(DispatchEx *This, BSTR name, DWORD grfdex, DISPID *ret) { - dispex_data_t *data; int min, max, n, c; - data = get_dispex_data(This); - if(!data) - return E_FAIL; - min = 0; - max = data->func_cnt-1; + max = This->info->func_cnt-1; while(min <= max) { n = (min+max)/2; - c = strcmpiW(data->name_table[n]->name, name); + c = strcmpiW(This->info->name_table[n]->name, name); if(!c) { - if((grfdex & fdexNameCaseSensitive) && strcmpW(data->name_table[n]->name, name)) + if((grfdex & fdexNameCaseSensitive) && strcmpW(This->info->name_table[n]->name, name)) break; - *ret = data->name_table[n]->id; + *ret = This->info->name_table[n]->id; return S_OK; } @@ -1213,15 +1203,10 @@ static HRESULT function_invoke(DispatchEx *This, func_info_t *func, WORD flags, static HRESULT invoke_builtin_prop(DispatchEx *This, DISPID id, LCID lcid, WORD flags, DISPPARAMS *dp, VARIANT *res, EXCEPINFO *ei, IServiceProvider *caller) { - dispex_data_t *data; func_info_t *func; HRESULT hres; - data = get_dispex_data(This); - if(!data) - return E_FAIL; - - hres = get_builtin_func(data, id, &func); + hres = get_builtin_func(This->info, id, &func); if(id == DISPID_VALUE && hres == DISP_E_UNKNOWNNAME) return dispex_value(This, lcid, flags, dp, res, ei, caller); if(FAILED(hres)) @@ -1289,15 +1274,10 @@ HRESULT remove_attribute(DispatchEx *This, DISPID id, VARIANT_BOOL *success) case DISPEXPROP_BUILTIN: { VARIANT var; DISPPARAMS dp = {&var,NULL,1,0}; - dispex_data_t *data; func_info_t *func; HRESULT hres; - data = get_dispex_data(This); - if(!data) - return E_FAIL; - - hres = get_builtin_func(data, id, &func); + hres = get_builtin_func(This->info, id, &func); if(FAILED(hres)) return hres; @@ -1561,7 +1541,6 @@ static HRESULT WINAPI DispatchEx_GetMemberProperties(IDispatchEx *iface, DISPID static HRESULT WINAPI DispatchEx_GetMemberName(IDispatchEx *iface, DISPID id, BSTR *pbstrName) { DispatchEx *This = impl_from_IDispatchEx(iface); - dispex_data_t *data; func_info_t *func; HRESULT hres; @@ -1580,11 +1559,7 @@ static HRESULT WINAPI DispatchEx_GetMemberName(IDispatchEx *iface, DISPID id, BS return S_OK; } - data = get_dispex_data(This); - if(!data) - return E_FAIL; - - hres = get_builtin_func(data, id, &func); + hres = get_builtin_func(This->info, id, &func); if(FAILED(hres)) return hres; @@ -1611,7 +1586,6 @@ static HRESULT next_dynamic_id(DispatchEx *dispex, DWORD idx, DISPID *ret_id) static HRESULT WINAPI DispatchEx_GetNextDispID(IDispatchEx *iface, DWORD grfdex, DISPID id, DISPID *pid) { DispatchEx *This = impl_from_IDispatchEx(iface); - dispex_data_t *data; func_info_t *func; HRESULT hres; @@ -1626,20 +1600,16 @@ static HRESULT WINAPI DispatchEx_GetNextDispID(IDispatchEx *iface, DWORD grfdex, return next_dynamic_id(This, idx+1, pid); } - data = get_dispex_data(This); - if(!data) - return E_FAIL; - if(id == DISPID_STARTENUM) { - func = data->funcs; + func = This->info->funcs; }else { - hres = get_builtin_func(data, id, &func); + hres = get_builtin_func(This->info, id, &func); if(FAILED(hres)) return hres; func++; } - while(func < data->funcs+data->func_cnt) { + while(func < This->info->funcs + This->info->func_cnt) { /* FIXME: Skip hidden properties */ if(func->func_disp_idx == -1) { *pid = func->id;

1 0

Jacek Caban : mshtml: Store dispex_data_t pointer instead of dispex_static_data_t in DispatchEx.
by Alexandre Julliard 06 Jul '16

06 Jul '16

Module: wine Branch: master Commit: 13c3ae6d9387df1e7de6100d18b47df96fcf3bac URL: http://source.winehq.org/git/wine.git/?a=commit;h=13c3ae6d9387df1e7de6100d1… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 5 22:46:33 2016 +0200 mshtml: Store dispex_data_t pointer instead of dispex_static_data_t in DispatchEx. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/dispex.c | 35 +++++++++++++++++++---------------- dlls/mshtml/mshtml_private.h | 2 +- 2 files changed, 20 insertions(+), 17 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 7af2854..4994eca 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -61,6 +61,8 @@ typedef struct { } func_info_t; struct dispex_data_t { + const dispex_static_data_t *desc; + DWORD func_cnt; DWORD func_size; func_info_t *funcs; @@ -372,6 +374,7 @@ static dispex_data_t *preprocess_dispex_data(const dispex_static_data_t *desc) ERR("Out of memory\n"); return NULL; } + data->desc = desc; data->func_cnt = 0; data->func_disp_cnt = 0; data->func_size = 16; @@ -468,7 +471,7 @@ HRESULT get_dispids(tid_t tid, DWORD *ret_size, DISPID **ret) static dispex_data_t *get_dispex_data(DispatchEx *This) { - return This->data->data; + return This->info; } static inline BOOL is_custom_dispid(DISPID id) @@ -510,8 +513,8 @@ static inline dispex_dynamic_data_t *get_dynamic_data(DispatchEx *This) if(!This->dynamic_data) return NULL; - if(This->data->vtbl && This->data->vtbl->populate_props) - This->data->vtbl->populate_props(This); + if(This->info->desc->vtbl && This->info->desc->vtbl->populate_props) + This->info->desc->vtbl->populate_props(This); return This->dynamic_data; } @@ -601,8 +604,8 @@ HRESULT dispex_get_dynid(DispatchEx *This, const WCHAR *name, DISPID *id) static HRESULT dispex_value(DispatchEx *This, LCID lcid, WORD flags, DISPPARAMS *params, VARIANT *res, EXCEPINFO *ei, IServiceProvider *caller) { - if(This->data->vtbl && This->data->vtbl->value) - return This->data->vtbl->value(This, lcid, flags, params, res, ei, caller); + if(This->info->desc->vtbl && This->info->desc->vtbl->value) + return This->info->desc->vtbl->value(This, lcid, flags, params, res, ei, caller); switch(flags) { case DISPATCH_PROPERTYGET: @@ -845,7 +848,7 @@ static HRESULT get_func_obj_entry(DispatchEx *This, func_info_t *func, func_obj_ return E_OUTOFMEMORY; if(!dynamic_data->func_disps) { - dynamic_data->func_disps = heap_alloc_zero(This->data->data->func_disp_cnt * sizeof(*dynamic_data->func_disps)); + dynamic_data->func_disps = heap_alloc_zero(This->info->func_disp_cnt * sizeof(*dynamic_data->func_disps)); if(!dynamic_data->func_disps) return E_OUTOFMEMORY; } @@ -920,10 +923,10 @@ static HRESULT get_builtin_id(DispatchEx *This, BSTR name, DWORD grfdex, DISPID min = n+1; } - if(This->data->vtbl && This->data->vtbl->get_dispid) { + if(This->info->desc->vtbl && This->info->desc->vtbl->get_dispid) { HRESULT hres; - hres = This->data->vtbl->get_dispid(This, name, grfdex, ret); + hres = This->info->desc->vtbl->get_dispid(This, name, grfdex, ret); if(hres != DISP_E_UNKNOWNNAME) return hres; } @@ -1381,7 +1384,7 @@ static HRESULT WINAPI DispatchEx_GetTypeInfo(IDispatchEx *iface, UINT iTInfo, TRACE("(%p)->(%u %u %p)\n", This, iTInfo, lcid, ppTInfo); - hres = get_typeinfo(This->data->disp_tid, ppTInfo); + hres = get_typeinfo(This->info->desc->disp_tid, ppTInfo); if(FAILED(hres)) return hres; @@ -1458,9 +1461,9 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc switch(get_dispid_type(id)) { case DISPEXPROP_CUSTOM: - if(!This->data->vtbl || !This->data->vtbl->invoke) + if(!This->info->desc->vtbl || !This->info->desc->vtbl->invoke) return DISP_E_UNKNOWNNAME; - return This->data->vtbl->invoke(This, id, lcid, wFlags, pdp, pvarRes, pei, pspCaller); + return This->info->desc->vtbl->invoke(This, id, lcid, wFlags, pdp, pvarRes, pei, pspCaller); case DISPEXPROP_DYNAMIC: { DWORD idx = id - DISPID_DYNPROP_0; @@ -1511,8 +1514,8 @@ static HRESULT WINAPI DispatchEx_InvokeEx(IDispatchEx *iface, DISPID id, LCID lc case DISPEXPROP_BUILTIN: if(wFlags == DISPATCH_CONSTRUCT) { if(id == DISPID_VALUE) { - if(This->data->vtbl && This->data->vtbl->value) { - return This->data->vtbl->value(This, lcid, wFlags, pdp, pvarRes, pei, pspCaller); + if(This->info->desc->vtbl && This->info->desc->vtbl->value) { + return This->info->desc->vtbl->value(This, lcid, wFlags, pdp, pvarRes, pei, pspCaller); } FIXME("DISPATCH_CONSTRUCT flag but missing value function\n"); return E_FAIL; @@ -1729,7 +1732,7 @@ void dispex_unlink(DispatchEx *This) const dispex_static_data_vtbl_t *dispex_get_vtbl(DispatchEx *dispex) { - return dispex->data->vtbl; + return dispex->info->desc->vtbl; } void release_dispex(DispatchEx *This) @@ -1749,7 +1752,7 @@ void release_dispex(DispatchEx *This) if(This->dynamic_data->func_disps) { func_obj_entry_t *iter; - for(iter = This->dynamic_data->func_disps; iter < This->dynamic_data->func_disps+This->data->data->func_disp_cnt; iter++) { + for(iter = This->dynamic_data->func_disps; iter < This->dynamic_data->func_disps + This->info->func_disp_cnt; iter++) { if(iter->func_obj) { iter->func_obj->obj = NULL; IDispatchEx_Release(&iter->func_obj->dispex.IDispatchEx_iface); @@ -1774,6 +1777,6 @@ void init_dispex(DispatchEx *dispex, IUnknown *outer, dispex_static_data_t *data dispex->IDispatchEx_iface.lpVtbl = &DispatchExVtbl; dispex->outer = outer; - dispex->data = data; + dispex->info = data->data; dispex->dynamic_data = NULL; } diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index 0e75c2f..d2191e3 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -261,7 +261,7 @@ struct DispatchEx { IUnknown *outer; - dispex_static_data_t *data; + dispex_data_t *info; dispex_dynamic_data_t *dynamic_data; };

1 0

Jacek Caban : mshtml: Preprocess typelib data in init_dispex.
by Alexandre Julliard 06 Jul '16

06 Jul '16

Module: wine Branch: master Commit: bb4227d6d5ffb9b9c7d6b73c91f5fec4d7af3353 URL: http://source.winehq.org/git/wine.git/?a=commit;h=bb4227d6d5ffb9b9c7d6b73c9… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 5 22:46:23 2016 +0200 mshtml: Preprocess typelib data in init_dispex. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/dispex.c | 31 +++++++++++++------------------ 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 09f0250..7af2854 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -351,7 +351,7 @@ static int func_name_cmp(const void *p1, const void *p2) return strcmpiW((*(func_info_t* const*)p1)->name, (*(func_info_t* const*)p2)->name); } -static dispex_data_t *preprocess_dispex_data(DispatchEx *This) +static dispex_data_t *preprocess_dispex_data(const dispex_static_data_t *desc) { const tid_t *tid; dispex_data_t *data; @@ -359,10 +359,8 @@ static dispex_data_t *preprocess_dispex_data(DispatchEx *This) ITypeInfo *dti; HRESULT hres; - TRACE("(%p)\n", This); - - if(This->data->disp_tid) { - hres = get_typeinfo(This->data->disp_tid, &dti); + if(desc->disp_tid) { + hres = get_typeinfo(desc->disp_tid, &dti); if(FAILED(hres)) { ERR("Could not get disp type info: %08x\n", hres); return NULL; @@ -385,14 +383,14 @@ static dispex_data_t *preprocess_dispex_data(DispatchEx *This) } list_add_tail(&dispex_data_list, &data->entry); - for(tid = This->data->iface_tids; *tid; tid++) { + for(tid = desc->iface_tids; *tid; tid++) { hres = process_interface(data, *tid, dti); if(FAILED(hres)) break; } - if(This->data->additional_tid) - process_interface(data, This->data->additional_tid, NULL); + if(desc->additional_tid) + process_interface(data, desc->additional_tid, NULL); if(!data->func_cnt) { heap_free(data->funcs); @@ -470,16 +468,6 @@ HRESULT get_dispids(tid_t tid, DWORD *ret_size, DISPID **ret) static dispex_data_t *get_dispex_data(DispatchEx *This) { - if(This->data->data) - return This->data->data; - - EnterCriticalSection(&cs_dispex_static_data); - - if(!This->data->data) - This->data->data = preprocess_dispex_data(This); - - LeaveCriticalSection(&cs_dispex_static_data); - return This->data->data; } @@ -1777,6 +1765,13 @@ void release_dispex(DispatchEx *This) void init_dispex(DispatchEx *dispex, IUnknown *outer, dispex_static_data_t *data) { + if(!data->data) { + EnterCriticalSection(&cs_dispex_static_data); + if(!data->data) + data->data = preprocess_dispex_data(data); + LeaveCriticalSection(&cs_dispex_static_data); + } + dispex->IDispatchEx_iface.lpVtbl = &DispatchExVtbl; dispex->outer = outer; dispex->data = data;

1 0

Jacek Caban : mshtml: Store function buffer size in dispex_data_t.
by Alexandre Julliard 06 Jul '16

06 Jul '16

Module: wine Branch: master Commit: 392a41060c4e195009666395766bdb4b168bb7d9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=392a41060c4e1950096663957… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 5 22:46:11 2016 +0200 mshtml: Store function buffer size in dispex_data_t. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/dispex.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 7c40d47..09f0250 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -62,6 +62,7 @@ typedef struct { struct dispex_data_t { DWORD func_cnt; + DWORD func_size; func_info_t *funcs; func_info_t **name_table; DWORD func_disp_cnt; @@ -225,7 +226,7 @@ static BOOL is_arg_type_supported(VARTYPE vt) return FALSE; } -static void add_func_info(dispex_data_t *data, DWORD *size, tid_t tid, const FUNCDESC *desc, ITypeInfo *dti) +static void add_func_info(dispex_data_t *data, tid_t tid, const FUNCDESC *desc, ITypeInfo *dti) { func_info_t *info; HRESULT hres; @@ -239,8 +240,8 @@ static void add_func_info(dispex_data_t *data, DWORD *size, tid_t tid, const FUN } if(info == data->funcs+data->func_cnt) { - if(data->func_cnt == *size) - data->funcs = heap_realloc_zero(data->funcs, (*size <<= 1)*sizeof(func_info_t)); + if(data->func_cnt == data->func_size) + data->funcs = heap_realloc_zero(data->funcs, (data->func_size <<= 1)*sizeof(func_info_t)); info = data->funcs+data->func_cnt; hres = ITypeInfo_GetDocumentation(dti, desc->memid, &info->name, NULL, NULL, NULL); @@ -315,7 +316,7 @@ static void add_func_info(dispex_data_t *data, DWORD *size, tid_t tid, const FUN } } -static HRESULT process_interface(dispex_data_t *data, tid_t tid, ITypeInfo *disp_typeinfo, DWORD *size) +static HRESULT process_interface(dispex_data_t *data, tid_t tid, ITypeInfo *disp_typeinfo) { unsigned i = 7; /* skip IDispatch functions */ ITypeInfo *typeinfo; @@ -333,7 +334,7 @@ static HRESULT process_interface(dispex_data_t *data, tid_t tid, ITypeInfo *disp TRACE("adding...\n"); - add_func_info(data, size, tid, funcdesc, disp_typeinfo ? disp_typeinfo : typeinfo); + add_func_info(data, tid, funcdesc, disp_typeinfo ? disp_typeinfo : typeinfo); ITypeInfo_ReleaseFuncDesc(typeinfo, funcdesc); } @@ -354,7 +355,7 @@ static dispex_data_t *preprocess_dispex_data(DispatchEx *This) { const tid_t *tid; dispex_data_t *data; - DWORD size = 16, i; + DWORD i; ITypeInfo *dti; HRESULT hres; @@ -375,7 +376,8 @@ static dispex_data_t *preprocess_dispex_data(DispatchEx *This) } data->func_cnt = 0; data->func_disp_cnt = 0; - data->funcs = heap_alloc_zero(size*sizeof(func_info_t)); + data->func_size = 16; + data->funcs = heap_alloc_zero(data->func_size*sizeof(func_info_t)); if (!data->funcs) { heap_free (data); ERR("Out of memory\n"); @@ -384,18 +386,19 @@ static dispex_data_t *preprocess_dispex_data(DispatchEx *This) list_add_tail(&dispex_data_list, &data->entry); for(tid = This->data->iface_tids; *tid; tid++) { - hres = process_interface(data, *tid, dti, &size); + hres = process_interface(data, *tid, dti); if(FAILED(hres)) break; } if(This->data->additional_tid) - process_interface(data, This->data->additional_tid, NULL, &size); + process_interface(data, This->data->additional_tid, NULL); if(!data->func_cnt) { heap_free(data->funcs); data->name_table = NULL; data->funcs = NULL; + data->func_size = 0; return data; }

1 0

Jacek Caban : mshtml: Added a helper to get vtbl from DispatchEx and use it to access vtbl outside dispex.c.
by Alexandre Julliard 06 Jul '16

06 Jul '16

Module: wine Branch: master Commit: dba85f124b10c883b111231e891af9c510fac143 URL: http://source.winehq.org/git/wine.git/?a=commit;h=dba85f124b10c883b111231e8… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 5 22:46:01 2016 +0200 mshtml: Added a helper to get vtbl from DispatchEx and use it to access vtbl outside dispex.c. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/dispex.c | 5 +++++ dlls/mshtml/htmlelem.c | 2 +- dlls/mshtml/htmlevent.c | 10 ++++++---- dlls/mshtml/htmlwindow.c | 2 +- dlls/mshtml/mshtml_private.h | 1 + 5 files changed, 14 insertions(+), 6 deletions(-) diff --git a/dlls/mshtml/dispex.c b/dlls/mshtml/dispex.c index 4ab2944..7c40d47 100644 --- a/dlls/mshtml/dispex.c +++ b/dlls/mshtml/dispex.c @@ -1736,6 +1736,11 @@ void dispex_unlink(DispatchEx *This) } } +const dispex_static_data_vtbl_t *dispex_get_vtbl(DispatchEx *dispex) +{ + return dispex->data->vtbl; +} + void release_dispex(DispatchEx *This) { dynamic_prop_t *prop; diff --git a/dlls/mshtml/htmlelem.c b/dlls/mshtml/htmlelem.c index 05ed66b..5fdbab0 100644 --- a/dlls/mshtml/htmlelem.c +++ b/dlls/mshtml/htmlelem.c @@ -5093,7 +5093,7 @@ static void HTMLElement_bind_event(DispatchEx *dispex, int eid) add_nsevent_listener(This->node.doc, This->node.nsnode, loadW); return; default: - This->node.doc->node.event_target.dispex.data->vtbl->bind_event(&This->node.doc->node.event_target.dispex, eid); + dispex_get_vtbl(&This->node.doc->node.event_target.dispex)->bind_event(&This->node.doc->node.event_target.dispex, eid); } } diff --git a/dlls/mshtml/htmlevent.c b/dlls/mshtml/htmlevent.c index 4bf168f..c2eeb7d 100644 --- a/dlls/mshtml/htmlevent.c +++ b/dlls/mshtml/htmlevent.c @@ -901,10 +901,11 @@ HRESULT create_event_obj(IHTMLEventObj **ret) static inline event_target_t *get_event_target_data(EventTarget *event_target, BOOL alloc) { + const dispex_static_data_vtbl_t *vtbl = dispex_get_vtbl(&event_target->dispex); event_target_t **ptr; - ptr = event_target->dispex.data->vtbl && event_target->dispex.data->vtbl->get_event_target_ptr - ? event_target->dispex.data->vtbl->get_event_target_ptr(&event_target->dispex) + ptr = vtbl && vtbl->get_event_target_ptr + ? vtbl->get_event_target_ptr(&event_target->dispex) : &event_target->ptr; if(*ptr || !alloc) return *ptr; @@ -1394,8 +1395,9 @@ void detach_events(HTMLDocumentNode *doc) /* Caller should ensure that it's called only once for given event in the target. */ static void bind_event(EventTarget *event_target, eventid_t eid) { - if(event_target->dispex.data->vtbl->bind_event) - event_target->dispex.data->vtbl->bind_event(&event_target->dispex, eid); + const dispex_static_data_vtbl_t *vtbl = dispex_get_vtbl(&event_target->dispex); + if(vtbl->bind_event) + vtbl->bind_event(&event_target->dispex, eid); else FIXME("Unsupported event binding on target %p\n", event_target); } diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c index 7484681..b75c9ba 100644 --- a/dlls/mshtml/htmlwindow.c +++ b/dlls/mshtml/htmlwindow.c @@ -2933,7 +2933,7 @@ static event_target_t **HTMLWindow_get_event_target_ptr(DispatchEx *dispex) static void HTMLWindow_bind_event(DispatchEx *dispex, int eid) { HTMLInnerWindow *This = impl_from_DispatchEx(dispex); - This->doc->node.event_target.dispex.data->vtbl->bind_event(&This->doc->node.event_target.dispex, eid); + dispex_get_vtbl(&This->doc->node.event_target.dispex)->bind_event(&This->doc->node.event_target.dispex, eid); } static const dispex_static_data_vtbl_t HTMLWindow_dispex_vtbl = { diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h index f6cf1a0..0e75c2f 100644 --- a/dlls/mshtml/mshtml_private.h +++ b/dlls/mshtml/mshtml_private.h @@ -303,6 +303,7 @@ void dispex_traverse(DispatchEx*,nsCycleCollectionTraversalCallback*) DECLSPEC_H void dispex_unlink(DispatchEx*) DECLSPEC_HIDDEN; void release_typelib(void) DECLSPEC_HIDDEN; HRESULT get_htmldoc_classinfo(ITypeInfo **typeinfo) DECLSPEC_HIDDEN; +const dispex_static_data_vtbl_t *dispex_get_vtbl(DispatchEx*) DECLSPEC_HIDDEN; typedef enum { DISPEXPROP_CUSTOM,

1 0

Jacek Caban : mshtml: Moved dispex_data_t pointer to the end of dispex_static_data_t struct.
by Alexandre Julliard 06 Jul '16

06 Jul '16

1 0

Jacek Caban : mshtml: Rewrite navigation tests using new HTTP emulation framework.
by Alexandre Julliard 06 Jul '16

06 Jul '16

Module: wine Branch: master Commit: 00f74afeefcf5ca64ce5303e3d62956bf64326da URL: http://source.winehq.org/git/wine.git/?a=commit;h=00f74afeefcf5ca64ce5303e3… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 5 22:45:32 2016 +0200 mshtml: Rewrite navigation tests using new HTTP emulation framework. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/navigation.js | 103 ++++++++++++++++++++++++++++++++++++++++ dlls/mshtml/tests/rsrc.rc | 4 +- dlls/mshtml/tests/script.c | 4 +- 3 files changed, 107 insertions(+), 4 deletions(-) diff --git a/dlls/mshtml/tests/navigation.js b/dlls/mshtml/tests/navigation.js new file mode 100644 index 0000000..63f3d57 --- /dev/null +++ b/dlls/mshtml/tests/navigation.js @@ -0,0 +1,103 @@ +/* + * Copyright 2016 Jacek Caban for CodeWeavers + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +function nav_parent_test() { + external.trace("Running _parent navigation tests..."); + + var iframe = document.getElementById("testframe"); + var subframe = iframe.contentWindow.document.createElement("iframe"); + + subframe.onload = function() { + var doc = subframe.contentWindow.document; + doc.body.innerHTML = '<a href="http://winetest.org/blank2.html" id="aid" target="_parent">test</a>'; + doc.getElementById("aid").click(); + } + + iframe.onload = function() { + iframe.onload = null; + var href = iframe.contentWindow.location.href; + ok(/.*blank2.html/.test(href), "Unexpected href " + href); + next_test(); + } + + iframe.contentWindow.document.body.appendChild(subframe); + subframe.src = "blank.html"; +} + +function window_navigate_test() { + external.trace("Running window.navigate() tests..."); + + var iframe = document.getElementById("testframe"); + + iframe.onload = function() { + iframe.onload = null; + var href = iframe.contentWindow.location.href; + ok(href === "about:blank", "Unexpected href " + href); + next_test(); + } + + iframe.contentWindow.navigate("about:blank"); +} + +function window_open_self_test() { + external.trace("Running window.open(_self) tests..."); + + var iframe = document.getElementById("testframe"); + var iframe_window = iframe.contentWindow; + + iframe.onload = function() { + iframe.onload = null; + var href = iframe.contentWindow.location.href; + ok(/.*blank.html\?window_open_self/.test(href), "Unexpected href " + href); + ok(iframe.contentWindow === iframe_window, "iframe.contentWindow !== iframe_window"); + next_test(); + } + + iframe_window.open("blank.html?window_open_self", "_self"); +} + +function detached_src_test() { + var iframe = document.createElement("iframe"); + var onload_called = false; + + iframe.onload = function() { + onload_called = true; + next_test(); + } + + iframe.src = "blank.html"; + document.body.appendChild(iframe); + ok(onload_called === false, "called onload too early?"); +} + +function init_test_iframe() { + var iframe = document.createElement("iframe"); + + iframe.onload = next_test; + iframe.id = "testframe"; + iframe.src = "about:blank"; + document.body.appendChild(iframe); +} + +var tests = [ + init_test_iframe, + nav_parent_test, + window_navigate_test, + window_open_self_test, + detached_src_test +]; diff --git a/dlls/mshtml/tests/rsrc.rc b/dlls/mshtml/tests/rsrc.rc index 1660dd6..a9ab563 100644 --- a/dlls/mshtml/tests/rsrc.rc +++ b/dlls/mshtml/tests/rsrc.rc @@ -34,8 +34,8 @@ events.html HTML "events.html" /* @makedep: externscr.js */ externscr.js HTML "externscr.js" -/* @makedep: nav_test.html */ -nav_test.html HTML "nav_test.html" +/* @makedep: navigation.js */ +navigation.js HTML "navigation.js" /* @makedep: xhr.js */ xhr.js HTML "xhr.js" diff --git a/dlls/mshtml/tests/script.c b/dlls/mshtml/tests/script.c index 57681c6..eadf737 100644 --- a/dlls/mshtml/tests/script.c +++ b/dlls/mshtml/tests/script.c @@ -3315,11 +3315,11 @@ static void run_js_tests(void) return; } - run_js_script("nav_test.html"); - init_protocol_handler(); run_script_as_http_with_mode("xhr.js", NULL, "11"); + run_script_as_http_with_mode("navigation.js", NULL, NULL); + run_script_as_http_with_mode("navigation.js", NULL, "11"); } static BOOL init_registry(BOOL init)

1 0

Jacek Caban : mshtml: Added scripted XHR tests with emulated HTTP connection.
by Alexandre Julliard 06 Jul '16

06 Jul '16

Module: wine Branch: master Commit: 2ad4e9f422f6d7e0a0cf710199f681b709ddf895 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2ad4e9f422f6d7e0a0cf71019… Author: Jacek Caban <jacek(a)codeweavers.com> Date: Tue Jul 5 22:45:17 2016 +0200 mshtml: Added scripted XHR tests with emulated HTTP connection. Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/tests/rsrc.rc | 6 + dlls/mshtml/tests/script.c | 465 ++++++++++++++++++++++++++++++++++++++++-- dlls/mshtml/tests/winetest.js | 49 +++++ dlls/mshtml/tests/xhr.js | 37 ++++ 4 files changed, 535 insertions(+), 22 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=2ad4e9f422f6d7e0a0cf7…

1 0

Nikolay Sivov : msxml3: Remove redundant refcount field.
by Alexandre Julliard 06 Jul '16

06 Jul '16

Module: wine Branch: master Commit: 01c63bdf7686fe2248bc2ab24a7920fdefb2ef0e URL: http://source.winehq.org/git/wine.git/?a=commit;h=01c63bdf7686fe2248bc2ab24… Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Tue Jul 5 22:28:00 2016 +0300 msxml3: Remove redundant refcount field. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msxml3/httprequest.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/dlls/msxml3/httprequest.c b/dlls/msxml3/httprequest.c index e0b6e1c..55339e1 100644 --- a/dlls/msxml3/httprequest.c +++ b/dlls/msxml3/httprequest.c @@ -114,7 +114,6 @@ typedef struct { httprequest req; IServerXMLHTTPRequest IServerXMLHTTPRequest_iface; - LONG ref; } serverhttp; static inline httprequest *impl_from_IXMLHTTPRequest( IXMLHTTPRequest *iface ) @@ -1737,7 +1736,7 @@ static HRESULT WINAPI ServerXMLHTTPRequest_QueryInterface(IServerXMLHTTPRequest static ULONG WINAPI ServerXMLHTTPRequest_AddRef(IServerXMLHTTPRequest *iface) { serverhttp *This = impl_from_IServerXMLHTTPRequest( iface ); - ULONG ref = InterlockedIncrement( &This->ref ); + ULONG ref = InterlockedIncrement( &This->req.ref ); TRACE("(%p)->(%u)\n", This, ref ); return ref; } @@ -1745,7 +1744,7 @@ static ULONG WINAPI ServerXMLHTTPRequest_AddRef(IServerXMLHTTPRequest *iface) static ULONG WINAPI ServerXMLHTTPRequest_Release(IServerXMLHTTPRequest *iface) { serverhttp *This = impl_from_IServerXMLHTTPRequest( iface ); - ULONG ref = InterlockedDecrement( &This->ref ); + ULONG ref = InterlockedDecrement( &This->req.ref ); TRACE("(%p)->(%u)\n", This, ref ); @@ -2041,7 +2040,6 @@ HRESULT ServerXMLHTTP_create(void **obj) init_httprequest(&req->req); req->IServerXMLHTTPRequest_iface.lpVtbl = &ServerXMLHTTPRequestVtbl; - req->ref = 1; *obj = &req->IServerXMLHTTPRequest_iface;

1 0

Thomas Faber : usp10: Avoid buffer overrun in ReplaceInsertChars.
by Alexandre Julliard 06 Jul '16

06 Jul '16

Module: wine Branch: master Commit: 37845242658a25edef059f3e1c0230d1b4b6255d URL: http://source.winehq.org/git/wine.git/?a=commit;h=37845242658a25edef059f3e1… Author: Thomas Faber <thomas.faber(a)reactos.org> Date: Sun Jun 26 10:57:50 2016 +0200 usp10: Avoid buffer overrun in ReplaceInsertChars. Signed-off-by: Thomas Faber <thomas.faber(a)reactos.org> Signed-off-by: Aric Stewart <aric(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/usp10/shape.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/usp10/shape.c b/dlls/usp10/shape.c index 3fdf84b..3ee412a 100644 --- a/dlls/usp10/shape.c +++ b/dlls/usp10/shape.c @@ -1596,7 +1596,7 @@ static void ReplaceInsertChars(HDC hdc, INT cWalk, INT* pcChars, WCHAR *pwOutCha cWalk=cWalk+1; /* Insert */ - for (i = 1; replacements[i] != 0x0000 && i < 3; i++) + for (i = 1; i < 3 && replacements[i] != 0x0000; i++) { int j; for (j = *pcChars; j > cWalk; j--)

1 0

← Newer
1
...
50
51
52
53
54
55
56
...
68
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits July 2016