winehq.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
February
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
January
2003
December
November
October
September
August
July
June
May
April
March
February
January
2002
December
November
October
September
August
July
June
May
April
March
February
January
2001
December
November
October
September
August
July
June
May
April
March
February
List overview
wine-commits
August 2016
----- 2025 -----
February 2025
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
January 2004
----- 2003 -----
December 2003
November 2003
October 2003
September 2003
August 2003
July 2003
June 2003
May 2003
April 2003
March 2003
February 2003
January 2003
----- 2002 -----
December 2002
November 2002
October 2002
September 2002
August 2002
July 2002
June 2002
May 2002
April 2002
March 2002
February 2002
January 2002
----- 2001 -----
December 2001
November 2001
October 2001
September 2001
August 2001
July 2001
June 2001
May 2001
April 2001
March 2001
February 2001
wine-commits@winehq.org
2 participants
777 discussions
Start a n
N
ew thread
Nikolay Sivov : dwrite: Fail stream creation on file mapping failure.
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: 1c7a1f8f27c1669f4f30193fe96ba424d69a466a URL:
http://source.winehq.org/git/wine.git/?a=commit;h=1c7a1f8f27c1669f4f30193fe…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Aug 26 13:47:17 2016 +0300 dwrite: Fail stream creation on file mapping failure. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dwrite/font.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/dlls/dwrite/font.c b/dlls/dwrite/font.c index cc82c26..e529d6f 100644 --- a/dlls/dwrite/font.c +++ b/dlls/dwrite/font.c @@ -4501,6 +4501,10 @@ static HRESULT WINAPI localfontfileloader_CreateStreamFromKey(IDWriteLocalFontFi file_ptr = MapViewOfFile(mapping, FILE_MAP_READ, 0, 0, 0); CloseHandle(mapping); + if (!file_ptr) { + ERR("mapping failed, file size %s, error %d\n", wine_dbgstr_longlong(size.QuadPart), GetLastError()); + return E_FAIL; + } stream = heap_alloc(sizeof(*stream)); if (!stream) {
1
0
0
0
Nikolay Sivov : urlmon: Added proxy/stubs for IBindHost.
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: 392e0c9c7a5032b4d88225cef1983fcefee085c6 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=392e0c9c7a5032b4d88225cef…
Author: Nikolay Sivov <nsivov(a)codeweavers.com> Date: Fri Aug 26 15:29:12 2016 +0300 urlmon: Added proxy/stubs for IBindHost. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/urlmon/usrmarshal.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/dlls/urlmon/usrmarshal.c b/dlls/urlmon/usrmarshal.c index d669918..e15c91b 100644 --- a/dlls/urlmon/usrmarshal.c +++ b/dlls/urlmon/usrmarshal.c @@ -53,35 +53,35 @@ HRESULT __RPC_STUB IWinInetInfo_QueryOption_Stub(IWinInetInfo* This, } HRESULT CALLBACK IBindHost_MonikerBindToStorage_Proxy(IBindHost* This, - IMoniker *pMk, IBindCtx *pBC, IBindStatusCallback *pBSC, - REFIID riid, void **ppvObj) + IMoniker *moniker, IBindCtx *bc, IBindStatusCallback *bsc, + REFIID riid, void **obj) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p %p %p %p %s %p)\n", This, moniker, bc, bsc, debugstr_guid(riid), obj); + return IBindHost_RemoteMonikerBindToStorage_Proxy(This, moniker, bc, bsc, riid, (IUnknown**)obj); } HRESULT __RPC_STUB IBindHost_MonikerBindToStorage_Stub(IBindHost* This, - IMoniker *pMk, IBindCtx *pBC, IBindStatusCallback *pBSC, - REFIID riid, IUnknown **ppvObj) + IMoniker *moniker, IBindCtx *bc, IBindStatusCallback *bsc, + REFIID riid, IUnknown **obj) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p %p %p %p %s %p)\n", This, moniker, bc, bsc, debugstr_guid(riid), obj); + return IBindHost_MonikerBindToStorage(This, moniker, bc, bsc, riid, (void**)obj); } HRESULT CALLBACK IBindHost_MonikerBindToObject_Proxy(IBindHost* This, - IMoniker *pMk, IBindCtx *pBC, IBindStatusCallback *pBSC, - REFIID riid, void **ppvObj) + IMoniker *moniker, IBindCtx *bc, IBindStatusCallback *bsc, + REFIID riid, void **obj) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p %p %p %p %s %p)\n", This, moniker, bc, bsc, debugstr_guid(riid), obj); + return IBindHost_RemoteMonikerBindToObject_Proxy(This, moniker, bc, bsc, riid, (IUnknown**)obj); } HRESULT __RPC_STUB IBindHost_MonikerBindToObject_Stub(IBindHost* This, - IMoniker *pMk, IBindCtx *pBC, IBindStatusCallback *pBSC, - REFIID riid, IUnknown **ppvObj) + IMoniker *moniker, IBindCtx *bc, IBindStatusCallback *bsc, + REFIID riid, IUnknown **obj) { - FIXME("stub\n"); - return E_NOTIMPL; + TRACE("(%p %p %p %p %s %p)\n", This, moniker, bc, bsc, debugstr_guid(riid), obj); + return IBindHost_MonikerBindToObject(This, moniker, bc, bsc, riid, (void**)obj); } HRESULT CALLBACK IBindStatusCallbackEx_GetBindInfoEx_Proxy(
1
0
0
0
Józef Kucia : d3d8/tests: Prefer higher resolutions in test_reset().
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: 4bc4e431c852ce3589b6f8c262b92e5f6ab22348 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=4bc4e431c852ce3589b6f8c26…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 25 12:34:19 2016 +0200 d3d8/tests: Prefer higher resolutions in test_reset(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/d3d8/tests/device.c | 25 ++++++++++++++++++++----- 1 file changed, 20 insertions(+), 5 deletions(-) diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c index 2f9c267..530ef00 100644 --- a/dlls/d3d8/tests/device.c +++ b/dlls/d3d8/tests/device.c @@ -22,6 +22,7 @@ */ #define WINVER 0x0602 /* for CURSOR_SUPPRESSED */ +#include <stdlib.h> #define COBJMACROS #include <initguid.h> #include <d3d8.h> @@ -1269,6 +1270,21 @@ static void test_display_modes(void) IDirect3D8_Release(d3d); } +struct mode +{ + unsigned int w; + unsigned int h; +}; + +static int compare_mode(const void *a, const void *b) +{ + const struct mode *mode_a = a; + const struct mode *mode_b = b; + unsigned int w = mode_a->w - mode_b->w; + unsigned int h = mode_b->h - mode_b->h; + return abs(w) >= abs(h) ? -w : -h; +} + static void test_reset(void) { UINT width, orig_width = GetSystemMetrics(SM_CXSCREEN); @@ -1303,11 +1319,7 @@ static void test_reset(void) D3DVSD_END(), }; - struct - { - UINT w; - UINT h; - } *modes = NULL; + struct mode *modes = NULL; window = CreateWindowA("d3d8_test_wc", "d3d8_test", WS_OVERLAPPEDWINDOW, 100, 100, 160, 160, NULL, NULL, NULL, NULL); @@ -1358,6 +1370,9 @@ static void test_reset(void) goto cleanup; } + /* Prefer higher resolutions. */ + qsort(modes, mode_count, sizeof(*modes), compare_mode); + i = 0; if (modes[i].w == orig_width && modes[i].h == orig_height) ++i;
1
0
0
0
Józef Kucia : wined3d: Optionally use closest matching mode in wined3d_swapchain_resize_target() .
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: bd10362667f04d6ea82144d1871ce143549a6bbc URL:
http://source.winehq.org/git/wine.git/?a=commit;h=bd10362667f04d6ea82144d18…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 25 12:22:56 2016 +0200 wined3d: Optionally use closest matching mode in wined3d_swapchain_resize_target(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/tests/device.c | 5 ++-- dlls/wined3d/swapchain.c | 60 ++++++++++++++++++++++++++++-------------------- 2 files changed, 37 insertions(+), 28 deletions(-) diff --git a/dlls/dxgi/tests/device.c b/dlls/dxgi/tests/device.c index 41a4d85..d9cedff 100644 --- a/dlls/dxgi/tests/device.c +++ b/dlls/dxgi/tests/device.c @@ -2215,10 +2215,9 @@ static void test_inexact_modes(void) swapchain_desc.BufferDesc.Width = sizes[i].width; swapchain_desc.BufferDesc.Height = sizes[i].height; hr = IDXGISwapChain_ResizeTarget(swapchain, &swapchain_desc.BufferDesc); - todo_wine ok(SUCCEEDED(hr), "ResizeTarget failed, hr %#x.\n", hr); + ok(SUCCEEDED(hr), "ResizeTarget failed, hr %#x.\n", hr); - if (SUCCEEDED(hr)) - check_swapchain_fullscreen_state(swapchain, &expected_state); + check_swapchain_fullscreen_state(swapchain, &expected_state); hr = IDXGISwapChain_GetDesc(swapchain, &result_desc); ok(SUCCEEDED(hr), "GetDesc failed, hr %#x.\n", hr); ok(result_desc.BufferDesc.Width == 800, "Got width %u.\n", result_desc.BufferDesc.Width); diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index fdfe337..695d409 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -1397,20 +1397,44 @@ HRESULT CDECL wined3d_swapchain_resize_buffers(struct wined3d_swapchain *swapcha return WINED3D_OK; } +static HRESULT wined3d_swapchain_set_display_mode(struct wined3d_swapchain *swapchain, + struct wined3d_display_mode *mode) +{ + struct wined3d_device *device = swapchain->device; + HRESULT hr; + + if (swapchain->desc.flags & WINED3D_SWAPCHAIN_USE_CLOSEST_MATCHING_MODE) + { + if (FAILED(hr = wined3d_find_closest_matching_adapter_mode(device->wined3d, + device->adapter->ordinal, mode))) + { + WARN("Failed to find closest matching mode, hr %#x.\n", hr); + } + } + + if (FAILED(hr = wined3d_set_adapter_display_mode(device->wined3d, + device->adapter->ordinal, mode))) + { + WARN("Failed to set display mode, hr %#x.\n", hr); + return WINED3DERR_INVALIDCALL; + } + + return WINED3D_OK; +} + HRESULT CDECL wined3d_swapchain_resize_target(struct wined3d_swapchain *swapchain, const struct wined3d_display_mode *mode) { struct wined3d_device *device = swapchain->device; - struct wined3d_display_mode current_mode; + struct wined3d_display_mode actual_mode; RECT original_window_rect, window_rect; HRESULT hr; TRACE("swapchain %p, mode %p.\n", swapchain, mode); - SetRect(&window_rect, 0, 0, mode->width, mode->height); - if (swapchain->desc.windowed) { + SetRect(&window_rect, 0, 0, mode->width, mode->height); AdjustWindowRectEx(&window_rect, GetWindowLongW(swapchain->device_window, GWL_STYLE), FALSE, GetWindowLongW(swapchain->device_window, GWL_EXSTYLE)); @@ -1421,22 +1445,21 @@ HRESULT CDECL wined3d_swapchain_resize_target(struct wined3d_swapchain *swapchai } else if (swapchain->desc.flags & WINED3D_SWAPCHAIN_ALLOW_MODE_SWITCH) { - if (FAILED(hr = wined3d_set_adapter_display_mode(device->wined3d, device->adapter->ordinal, mode))) - { - WARN("Failed to set display mode, hr %#x.\n", hr); - return WINED3DERR_INVALIDCALL; - } + actual_mode = *mode; + if (FAILED(hr = wined3d_swapchain_set_display_mode(swapchain, &actual_mode))) + return hr; + SetRect(&window_rect, 0, 0, actual_mode.width, actual_mode.height); } else { if (FAILED(hr = wined3d_get_adapter_display_mode(device->wined3d, device->adapter->ordinal, - ¤t_mode, NULL))) + &actual_mode, NULL))) { ERR("Failed to get display mode, hr %#x.\n", hr); return WINED3DERR_INVALIDCALL; } - SetRect(&window_rect, 0, 0, current_mode.width, current_mode.height); + SetRect(&window_rect, 0, 0, actual_mode.width, actual_mode.height); } MoveWindow(swapchain->device_window, window_rect.left, window_rect.top, @@ -1477,21 +1500,8 @@ HRESULT CDECL wined3d_swapchain_set_fullscreen(struct wined3d_swapchain *swapcha } } - if (swapchain->desc.flags & WINED3D_SWAPCHAIN_USE_CLOSEST_MATCHING_MODE) - { - if (FAILED(hr = wined3d_find_closest_matching_adapter_mode(device->wined3d, - device->adapter->ordinal, &actual_mode))) - { - WARN("Failed to find closest matching mode, hr %#x.\n", hr); - } - } - - if (FAILED(hr = wined3d_set_adapter_display_mode(device->wined3d, - device->adapter->ordinal, &actual_mode))) - { - WARN("Failed to set display mode, hr %#x.\n", hr); - return WINED3DERR_INVALIDCALL; - } + if (FAILED(hr = wined3d_swapchain_set_display_mode(swapchain, &actual_mode))) + return hr; } else {
1
0
0
0
Józef Kucia : dxgi: Enable WINED3D_SWAPCHAIN_USE_CLOSEST_MATCHING_MODE.
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: f94ef02dbcc5db2dafcb14beaf553e5dd7626791 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=f94ef02dbcc5db2dafcb14bea…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 25 12:22:55 2016 +0200 dxgi: Enable WINED3D_SWAPCHAIN_USE_CLOSEST_MATCHING_MODE. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/swapchain.c | 3 +++ dlls/dxgi/tests/device.c | 63 +++++++++++++++++++++--------------------------- dlls/dxgi/utils.c | 7 ++++-- 3 files changed, 36 insertions(+), 37 deletions(-) diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c index e0185dd..7b02b3e 100644 --- a/dlls/dxgi/swapchain.c +++ b/dlls/dxgi/swapchain.c @@ -481,6 +481,9 @@ HRESULT dxgi_swapchain_init(struct dxgi_swapchain *swapchain, struct dxgi_device wined3d_mutex_lock(); wined3d_private_store_init(&swapchain->private_store); + if (!desc->windowed && (!desc->backbuffer_width || !desc->backbuffer_height)) + FIXME("Fullscreen swapchain with back buffer width/height equal to 0 not supported properly.\n"); + swapchain->fullscreen = !desc->windowed; desc->windowed = TRUE; if (FAILED(hr = wined3d_swapchain_create(device->wined3d_device, desc, swapchain, diff --git a/dlls/dxgi/tests/device.c b/dlls/dxgi/tests/device.c index d533af4..41a4d85 100644 --- a/dlls/dxgi/tests/device.c +++ b/dlls/dxgi/tests/device.c @@ -1183,21 +1183,18 @@ static void test_create_swapchain(void) expected_height = expected_client_rect->bottom - expected_client_rect->top; hr = IDXGIFactory_CreateSwapChain(factory, obj, &creation_desc, &swapchain); - todo_wine ok(SUCCEEDED(hr), "CreateSwapChain failed, hr %#x.\n", hr); - if (SUCCEEDED(hr)) - { - hr = IDXGISwapChain_GetDesc(swapchain, &result_desc); - ok(SUCCEEDED(hr), "GetDesc failed, hr %#x.\n", hr); - ok(result_desc.BufferDesc.Width == expected_width, "Got width %u, expected %u.\n", - result_desc.BufferDesc.Width, expected_width); - ok(result_desc.BufferDesc.Height == expected_height, "Got height %u, expected %u.\n", - result_desc.BufferDesc.Height, expected_height); - check_swapchain_fullscreen_state(swapchain, &expected_state); - hr = IDXGISwapChain_SetFullscreenState(swapchain, FALSE, NULL); - ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); - check_swapchain_fullscreen_state(swapchain, &initial_state); - IDXGISwapChain_Release(swapchain); - } + ok(SUCCEEDED(hr), "CreateSwapChain failed, hr %#x.\n", hr); + hr = IDXGISwapChain_GetDesc(swapchain, &result_desc); + ok(SUCCEEDED(hr), "GetDesc failed, hr %#x.\n", hr); + todo_wine ok(result_desc.BufferDesc.Width == expected_width, "Got width %u, expected %u.\n", + result_desc.BufferDesc.Width, expected_width); + todo_wine ok(result_desc.BufferDesc.Height == expected_height, "Got height %u, expected %u.\n", + result_desc.BufferDesc.Height, expected_height); + check_swapchain_fullscreen_state(swapchain, &expected_state); + hr = IDXGISwapChain_SetFullscreenState(swapchain, FALSE, NULL); + ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); + check_swapchain_fullscreen_state(swapchain, &initial_state); + IDXGISwapChain_Release(swapchain); IDXGIOutput_Release(expected_state.target); @@ -2161,25 +2158,22 @@ static void test_inexact_modes(void) sizes[i].width, sizes[i].height, output); hr = IDXGIFactory_CreateSwapChain(factory, (IUnknown *)device, &swapchain_desc, &swapchain); - todo_wine ok(SUCCEEDED(hr), "CreateSwapChain failed, hr %#x.\n", hr); + ok(SUCCEEDED(hr), "CreateSwapChain failed, hr %#x.\n", hr); - if (SUCCEEDED(hr)) - { - check_swapchain_fullscreen_state(swapchain, &expected_state); - hr = IDXGISwapChain_GetDesc(swapchain, &result_desc); - ok(SUCCEEDED(hr), "GetDesc failed, hr %#x.\n", hr); - ok(result_desc.BufferDesc.Width == sizes[i].width, "Got width %u, expected %u.\n", - result_desc.BufferDesc.Width, sizes[i].width); - ok(result_desc.BufferDesc.Height == sizes[i].height, "Got height %u, expected %u.\n", - result_desc.BufferDesc.Height, sizes[i].height); + check_swapchain_fullscreen_state(swapchain, &expected_state); + hr = IDXGISwapChain_GetDesc(swapchain, &result_desc); + ok(SUCCEEDED(hr), "GetDesc failed, hr %#x.\n", hr); + ok(result_desc.BufferDesc.Width == sizes[i].width, "Got width %u, expected %u.\n", + result_desc.BufferDesc.Width, sizes[i].width); + ok(result_desc.BufferDesc.Height == sizes[i].height, "Got height %u, expected %u.\n", + result_desc.BufferDesc.Height, sizes[i].height); - hr = IDXGISwapChain_SetFullscreenState(swapchain, FALSE, NULL); - ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); - check_swapchain_fullscreen_state(swapchain, &initial_state); + hr = IDXGISwapChain_SetFullscreenState(swapchain, FALSE, NULL); + ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); + check_swapchain_fullscreen_state(swapchain, &initial_state); - refcount = IDXGISwapChain_Release(swapchain); - ok(!refcount, "IDXGISwapChain has %u references left.\n", refcount); - } + refcount = IDXGISwapChain_Release(swapchain); + ok(!refcount, "IDXGISwapChain has %u references left.\n", refcount); /* Test SetFullscreenState(). */ swapchain_desc.BufferDesc.Width = sizes[i].width; @@ -2189,11 +2183,10 @@ static void test_inexact_modes(void) hr = IDXGIFactory_CreateSwapChain(factory, (IUnknown *)device, &swapchain_desc, &swapchain); ok(SUCCEEDED(hr), "CreateSwapChain failed, hr %#x.\n", hr); - todo_wine hr = IDXGISwapChain_SetFullscreenState(swapchain, TRUE, output); - todo_wine ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); + hr = IDXGISwapChain_SetFullscreenState(swapchain, TRUE, output); + ok(SUCCEEDED(hr), "SetFullscreenState failed, hr %#x.\n", hr); - if (SUCCEEDED(hr)) - check_swapchain_fullscreen_state(swapchain, &expected_state); + check_swapchain_fullscreen_state(swapchain, &expected_state); hr = IDXGISwapChain_GetDesc(swapchain, &result_desc); ok(SUCCEEDED(hr), "GetDesc failed, hr %#x.\n", hr); ok(result_desc.BufferDesc.Width == sizes[i].width, "Got width %u, expected %u.\n", diff --git a/dlls/dxgi/utils.c b/dlls/dxgi/utils.c index eda279f..b940b15 100644 --- a/dlls/dxgi/utils.c +++ b/dlls/dxgi/utils.c @@ -453,11 +453,14 @@ void wined3d_display_mode_from_dxgi(struct wined3d_display_mode *wined3d_mode, wined3d_mode->scanline_ordering = wined3d_scanline_ordering_from_dxgi(mode->ScanlineOrdering); } +#define DXGI_WINED3D_SWAPCHAIN_FLAGS \ + (WINED3D_SWAPCHAIN_USE_CLOSEST_MATCHING_MODE | WINED3D_SWAPCHAIN_RESTORE_WINDOW_RECT) + unsigned int dxgi_swapchain_flags_from_wined3d(unsigned int wined3d_flags) { unsigned int flags = 0; - wined3d_flags &= ~WINED3D_SWAPCHAIN_RESTORE_WINDOW_RECT; + wined3d_flags &= ~DXGI_WINED3D_SWAPCHAIN_FLAGS; if (wined3d_flags & WINED3D_SWAPCHAIN_ALLOW_MODE_SWITCH) { @@ -473,7 +476,7 @@ unsigned int dxgi_swapchain_flags_from_wined3d(unsigned int wined3d_flags) unsigned int wined3d_swapchain_flags_from_dxgi(unsigned int flags) { - unsigned int wined3d_flags = WINED3D_SWAPCHAIN_RESTORE_WINDOW_RECT; /* WINED3D_SWAPCHAIN_DISCARD_DEPTHSTENCIL? */ + unsigned int wined3d_flags = DXGI_WINED3D_SWAPCHAIN_FLAGS; /* WINED3D_SWAPCHAIN_DISCARD_DEPTHSTENCIL? */ if (flags & DXGI_SWAP_CHAIN_FLAG_ALLOW_MODE_SWITCH) {
1
0
0
0
Józef Kucia : wined3d: Optionally use closest matching mode in wined3d_swapchain_set_fullscreen( ).
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: 92a6c5839d9ebda9b94facbfd5bdac1bbb423600 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=92a6c5839d9ebda9b94facbfd…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 25 12:22:54 2016 +0200 wined3d: Optionally use closest matching mode in wined3d_swapchain_set_fullscreen(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/swapchain.c | 48 ++++++++++++++++++++++++++++-------------------- include/wine/wined3d.h | 3 ++- 2 files changed, 30 insertions(+), 21 deletions(-) diff --git a/dlls/wined3d/swapchain.c b/dlls/wined3d/swapchain.c index e405457..fdfe337 100644 --- a/dlls/wined3d/swapchain.c +++ b/dlls/wined3d/swapchain.c @@ -1450,35 +1450,44 @@ HRESULT CDECL wined3d_swapchain_set_fullscreen(struct wined3d_swapchain *swapcha const struct wined3d_swapchain_desc *swapchain_desc, const struct wined3d_display_mode *mode) { struct wined3d_device *device = swapchain->device; - struct wined3d_display_mode default_mode; - unsigned int width, height; + struct wined3d_display_mode actual_mode; HRESULT hr; TRACE("swapchain %p, desc %p, mode %p.\n", swapchain, swapchain_desc, mode); if (swapchain->desc.flags & WINED3D_SWAPCHAIN_ALLOW_MODE_SWITCH) { - width = swapchain_desc->backbuffer_width; - height = swapchain_desc->backbuffer_height; - - if (!mode) + if (mode) + { + actual_mode = *mode; + } + else { if (!swapchain_desc->windowed) { - default_mode.width = swapchain_desc->backbuffer_width; - default_mode.height = swapchain_desc->backbuffer_height; - default_mode.refresh_rate = swapchain_desc->refresh_rate; - default_mode.format_id = swapchain_desc->backbuffer_format; - default_mode.scanline_ordering = WINED3D_SCANLINE_ORDERING_UNKNOWN; + actual_mode.width = swapchain_desc->backbuffer_width; + actual_mode.height = swapchain_desc->backbuffer_height; + actual_mode.refresh_rate = swapchain_desc->refresh_rate; + actual_mode.format_id = swapchain_desc->backbuffer_format; + actual_mode.scanline_ordering = WINED3D_SCANLINE_ORDERING_UNKNOWN; } else { - default_mode = swapchain->original_mode; + actual_mode = swapchain->original_mode; } - mode = &default_mode; } - if (FAILED(hr = wined3d_set_adapter_display_mode(device->wined3d, device->adapter->ordinal, mode))) + if (swapchain->desc.flags & WINED3D_SWAPCHAIN_USE_CLOSEST_MATCHING_MODE) + { + if (FAILED(hr = wined3d_find_closest_matching_adapter_mode(device->wined3d, + device->adapter->ordinal, &actual_mode))) + { + WARN("Failed to find closest matching mode, hr %#x.\n", hr); + } + } + + if (FAILED(hr = wined3d_set_adapter_display_mode(device->wined3d, + device->adapter->ordinal, &actual_mode))) { WARN("Failed to set display mode, hr %#x.\n", hr); return WINED3DERR_INVALIDCALL; @@ -1490,19 +1499,18 @@ HRESULT CDECL wined3d_swapchain_set_fullscreen(struct wined3d_swapchain *swapcha WARN("WINED3D_SWAPCHAIN_ALLOW_MODE_SWITCH is not set, ignoring mode.\n"); if (FAILED(hr = wined3d_get_adapter_display_mode(device->wined3d, device->adapter->ordinal, - &default_mode, NULL))) + &actual_mode, NULL))) { ERR("Failed to get display mode, hr %#x.\n", hr); return WINED3DERR_INVALIDCALL; } - mode = &default_mode; - - width = mode->width; - height = mode->height; } if (!swapchain_desc->windowed) { + unsigned int width = actual_mode.width; + unsigned int height = actual_mode.height; + if (swapchain->desc.windowed) { HWND focus_window = device->create_parms.focus_window; @@ -1522,7 +1530,7 @@ HRESULT CDECL wined3d_swapchain_set_fullscreen(struct wined3d_swapchain *swapcha /* Fullscreen -> fullscreen mode change */ MoveWindow(swapchain->device_window, 0, 0, width, height, TRUE); } - swapchain->d3d_mode = *mode; + swapchain->d3d_mode = actual_mode; } else if (!swapchain->desc.windowed) { diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index bc343ec..81dffea 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -829,7 +829,8 @@ enum wined3d_display_rotation #define WINED3D_SWAPCHAIN_NOAUTOROTATE 0x00000020u #define WINED3D_SWAPCHAIN_UNPRUNEDMODE 0x00000040u #define WINED3D_SWAPCHAIN_ALLOW_MODE_SWITCH 0x00001000u -#define WINED3D_SWAPCHAIN_RESTORE_WINDOW_RECT 0x00002000u +#define WINED3D_SWAPCHAIN_USE_CLOSEST_MATCHING_MODE 0x00002000u +#define WINED3D_SWAPCHAIN_RESTORE_WINDOW_RECT 0x00004000u #define WINED3DDP_MAXTEXCOORD 8
1
0
0
0
Józef Kucia : dxgi/tests: Add test for IDXGIOutput_FindClosestMatchingMode().
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: 09a4957401d49dfaf56cbb153c41b86466eeb8d5 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=09a4957401d49dfaf56cbb153…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 25 12:22:53 2016 +0200 dxgi/tests: Add test for IDXGIOutput_FindClosestMatchingMode(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/tests/device.c | 229 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 229 insertions(+) Diff:
http://source.winehq.org/git/wine.git/?a=commitdiff;h=09a4957401d49dfaf56cb…
1
0
0
0
Józef Kucia : dxgi: Implement dxgi_output_FindClosestMatchingMode().
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: 8d89d0ec1ee7f50aeee348edb30c6b228f522d27 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=8d89d0ec1ee7f50aeee348edb…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 25 12:22:52 2016 +0200 dxgi: Implement dxgi_output_FindClosestMatchingMode(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/output.c | 37 +++++++++++++++++++++++++++++++++++-- dlls/dxgi/tests/device.c | 2 +- 2 files changed, 36 insertions(+), 3 deletions(-) diff --git a/dlls/dxgi/output.c b/dlls/dxgi/output.c index 6d7ca20..0cf8084 100644 --- a/dlls/dxgi/output.c +++ b/dlls/dxgi/output.c @@ -228,9 +228,42 @@ static HRESULT STDMETHODCALLTYPE dxgi_output_GetDisplayModeList(IDXGIOutput *ifa static HRESULT STDMETHODCALLTYPE dxgi_output_FindClosestMatchingMode(IDXGIOutput *iface, const DXGI_MODE_DESC *mode, DXGI_MODE_DESC *closest_match, IUnknown *device) { - FIXME("iface %p, mode %p, closest_match %p, device %p stub!\n", iface, mode, closest_match, device); + struct dxgi_output *output = impl_from_IDXGIOutput(iface); + struct wined3d_display_mode wined3d_mode; + struct dxgi_adapter *adapter; + struct wined3d *wined3d; + HRESULT hr; - return E_NOTIMPL; + TRACE("iface %p, mode %p, closest_match %p, device %p.\n", iface, mode, closest_match, device); + + if ((!mode->Width && mode->Height) || (mode->Width && !mode->Height)) + return DXGI_ERROR_INVALID_CALL; + + if (mode->Format == DXGI_FORMAT_UNKNOWN && !device) + return DXGI_ERROR_INVALID_CALL; + + TRACE("Mode: %s.\n", debug_dxgi_mode(mode)); + if (mode->Format == DXGI_FORMAT_UNKNOWN) + { + FIXME("Matching formats to device not implemented.\n"); + return E_NOTIMPL; + } + + adapter = output->adapter; + wined3d = adapter->factory->wined3d; + + wined3d_mutex_lock(); + wined3d_display_mode_from_dxgi(&wined3d_mode, mode); + hr = wined3d_find_closest_matching_adapter_mode(wined3d, adapter->ordinal, &wined3d_mode); + wined3d_mutex_unlock(); + + if (SUCCEEDED(hr)) + { + dxgi_mode_from_wined3d(closest_match, &wined3d_mode); + TRACE("Returning %s.\n", debug_dxgi_mode(closest_match)); + } + + return hr; } static HRESULT STDMETHODCALLTYPE dxgi_output_WaitForVBlank(IDXGIOutput *iface) diff --git a/dlls/dxgi/tests/device.c b/dlls/dxgi/tests/device.c index 23624eb..8ec65e2 100644 --- a/dlls/dxgi/tests/device.c +++ b/dlls/dxgi/tests/device.c @@ -225,7 +225,7 @@ static void compute_expected_swapchain_fullscreen_state_after_fullscreen_change_ mode_desc.Width = new_width; mode_desc.Height = new_height; hr = IDXGIOutput_FindClosestMatchingMode(target, &mode_desc, &mode_desc, NULL); - todo_wine ok_(__FILE__, line)(SUCCEEDED(hr), "FindClosestMatchingMode failed, hr %#x.\n", hr); + ok_(__FILE__, line)(SUCCEEDED(hr), "FindClosestMatchingMode failed, hr %#x.\n", hr); new_width = mode_desc.Width; new_height = mode_desc.Height; }
1
0
0
0
Józef Kucia : wined3d: Introduce wined3d_find_closest_matching_adapter_mode().
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: 41d29a79f51cca0452fb37db38dc6b6df4b32dc1 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=41d29a79f51cca0452fb37db3…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 25 12:22:51 2016 +0200 wined3d: Introduce wined3d_find_closest_matching_adapter_mode(). Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/wined3d/directx.c | 100 ++++++++++++++++++++++++++++++++++++++++++++++ dlls/wined3d/wined3d.spec | 1 + include/wine/wined3d.h | 2 + 3 files changed, 103 insertions(+) diff --git a/dlls/wined3d/directx.c b/dlls/wined3d/directx.c index 9ff88a8..4213df3 100644 --- a/dlls/wined3d/directx.c +++ b/dlls/wined3d/directx.c @@ -4199,6 +4199,106 @@ HRESULT CDECL wined3d_enum_adapter_modes(const struct wined3d *wined3d, UINT ada return WINED3D_OK; } +HRESULT CDECL wined3d_find_closest_matching_adapter_mode(const struct wined3d *wined3d, + unsigned int adapter_idx, struct wined3d_display_mode *mode) +{ + unsigned int i, j, mode_count, matching_mode_count, closest; + struct wined3d_display_mode **matching_modes; + struct wined3d_display_mode *modes; + HRESULT hr; + + TRACE("wined3d %p, adapter_idx %u, mode %p.\n", wined3d, adapter_idx, mode); + + if (!(mode_count = wined3d_get_adapter_mode_count(wined3d, adapter_idx, + mode->format_id, WINED3D_SCANLINE_ORDERING_UNKNOWN))) + { + WARN("Adapter has 0 matching modes.\n"); + return E_FAIL; + } + + if (!(modes = wined3d_calloc(mode_count, sizeof(*modes)))) + return E_OUTOFMEMORY; + if (!(matching_modes = wined3d_calloc(mode_count, sizeof(*matching_modes)))) + { + HeapFree(GetProcessHeap(), 0, modes); + return E_OUTOFMEMORY; + } + + for (i = 0; i < mode_count; ++i) + { + if (FAILED(hr = wined3d_enum_adapter_modes(wined3d, adapter_idx, + mode->format_id, WINED3D_SCANLINE_ORDERING_UNKNOWN, i, &modes[i]))) + { + HeapFree(GetProcessHeap(), 0, matching_modes); + HeapFree(GetProcessHeap(), 0, modes); + return hr; + } + matching_modes[i] = &modes[i]; + } + + matching_mode_count = mode_count; + + if (mode->scanline_ordering != WINED3D_SCANLINE_ORDERING_UNKNOWN) + { + for (i = 0, j = 0; i < matching_mode_count; ++i) + { + if (matching_modes[i]->scanline_ordering == mode->scanline_ordering) + matching_modes[j++] = matching_modes[i]; + } + if (j > 0) + matching_mode_count = j; + } + + if (mode->refresh_rate) + { + for (i = 0, j = 0; i < matching_mode_count; ++i) + { + if (matching_modes[i]->refresh_rate == mode->refresh_rate) + matching_modes[j++] = matching_modes[i]; + } + if (j > 0) + matching_mode_count = j; + } + + if (!mode->width || !mode->height) + { + struct wined3d_display_mode current_mode; + if (FAILED(hr = wined3d_get_adapter_display_mode(wined3d, adapter_idx, + ¤t_mode, NULL))) + { + HeapFree(GetProcessHeap(), 0, matching_modes); + HeapFree(GetProcessHeap(), 0, modes); + return hr; + } + mode->width = current_mode.width; + mode->height = current_mode.height; + } + + closest = ~0u; + for (i = 0, j = 0; i < matching_mode_count; ++i) + { + unsigned int d = abs(mode->width - matching_modes[i]->width) + + abs(mode->height - matching_modes[i]->height); + + if (closest > d) + { + closest = d; + j = i; + } + } + + *mode = *matching_modes[j]; + + HeapFree(GetProcessHeap(), 0, matching_modes); + HeapFree(GetProcessHeap(), 0, modes); + + TRACE("Returning %ux%u@%u %s %#x.\n", mode->width, mode->height, + mode->refresh_rate, debug_d3dformat(mode->format_id), + mode->scanline_ordering); + + return WINED3D_OK; +} + HRESULT CDECL wined3d_get_adapter_display_mode(const struct wined3d *wined3d, UINT adapter_idx, struct wined3d_display_mode *mode, enum wined3d_display_rotation *rotation) { diff --git a/dlls/wined3d/wined3d.spec b/dlls/wined3d/wined3d.spec index c3899ed..0db371d 100644 --- a/dlls/wined3d/wined3d.spec +++ b/dlls/wined3d/wined3d.spec @@ -10,6 +10,7 @@ @ cdecl wined3d_create(long) @ cdecl wined3d_decref(ptr) @ cdecl wined3d_enum_adapter_modes(ptr long long long long ptr) +@ cdecl wined3d_find_closest_matching_adapter_mode(ptr long ptr) @ cdecl wined3d_get_adapter_count(ptr) @ cdecl wined3d_get_adapter_display_mode(ptr long ptr ptr) @ cdecl wined3d_get_adapter_identifier(ptr long long ptr) diff --git a/include/wine/wined3d.h b/include/wine/wined3d.h index 1c9b262..bc343ec 100644 --- a/include/wine/wined3d.h +++ b/include/wine/wined3d.h @@ -2105,6 +2105,8 @@ ULONG __cdecl wined3d_decref(struct wined3d *wined3d); HRESULT __cdecl wined3d_enum_adapter_modes(const struct wined3d *wined3d, UINT adapter_idx, enum wined3d_format_id format_id, enum wined3d_scanline_ordering scanline_ordering, UINT mode_idx, struct wined3d_display_mode *mode); +HRESULT __cdecl wined3d_find_closest_matching_adapter_mode(const struct wined3d *wined3d, + unsigned int adapter_idx, struct wined3d_display_mode *mode); UINT __cdecl wined3d_get_adapter_count(const struct wined3d *wined3d); HRESULT __cdecl wined3d_get_adapter_display_mode(const struct wined3d *wined3d, UINT adapter_idx, struct wined3d_display_mode *mode, enum wined3d_display_rotation *rotation);
1
0
0
0
Józef Kucia : dxgi: Introduce helper functions for converting wined3d_display_mode.
by Alexandre Julliard
26 Aug '16
26 Aug '16
Module: wine Branch: master Commit: 9381ad89fbe376dce1a318b11e2c8f0d0eae3505 URL:
http://source.winehq.org/git/wine.git/?a=commit;h=9381ad89fbe376dce1a318b11…
Author: Józef Kucia <jkucia(a)codeweavers.com> Date: Thu Aug 25 12:22:50 2016 +0200 dxgi: Introduce helper functions for converting wined3d_display_mode. Signed-off-by: Józef Kucia <jkucia(a)codeweavers.com> Signed-off-by: Henri Verbeet <hverbeet(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dxgi/dxgi_private.h | 2 ++ dlls/dxgi/output.c | 30 +++++++++++++++++------------- dlls/dxgi/swapchain.c | 6 +----- dlls/dxgi/utils.c | 10 ++++++++++ 4 files changed, 30 insertions(+), 18 deletions(-) diff --git a/dlls/dxgi/dxgi_private.h b/dlls/dxgi/dxgi_private.h index 987370f1..b417470 100644 --- a/dlls/dxgi/dxgi_private.h +++ b/dlls/dxgi/dxgi_private.h @@ -91,6 +91,8 @@ void dxgi_sample_desc_from_wined3d(DXGI_SAMPLE_DESC *desc, enum wined3d_multisample_type wined3d_type, unsigned int wined3d_quality) DECLSPEC_HIDDEN; void wined3d_sample_desc_from_dxgi(enum wined3d_multisample_type *wined3d_type, unsigned int *wined3d_quality, const DXGI_SAMPLE_DESC *dxgi_desc) DECLSPEC_HIDDEN; +void wined3d_display_mode_from_dxgi(struct wined3d_display_mode *wined3d_mode, + const DXGI_MODE_DESC *mode) DECLSPEC_HIDDEN; unsigned int dxgi_swapchain_flags_from_wined3d(unsigned int wined3d_flags) DECLSPEC_HIDDEN; unsigned int wined3d_swapchain_flags_from_dxgi(unsigned int flags) DECLSPEC_HIDDEN; HRESULT dxgi_get_private_data(struct wined3d_private_store *store, diff --git a/dlls/dxgi/output.c b/dlls/dxgi/output.c index cfd08fe..6d7ca20 100644 --- a/dlls/dxgi/output.c +++ b/dlls/dxgi/output.c @@ -23,6 +23,17 @@ WINE_DEFAULT_DEBUG_CHANNEL(dxgi); +static void dxgi_mode_from_wined3d(DXGI_MODE_DESC *mode, const struct wined3d_display_mode *wined3d_mode) +{ + mode->Width = wined3d_mode->width; + mode->Height = wined3d_mode->height; + mode->RefreshRate.Numerator = wined3d_mode->refresh_rate; + mode->RefreshRate.Denominator = 1; + mode->Format = dxgi_format_from_wined3dformat(wined3d_mode->format_id); + mode->ScanlineOrdering = wined3d_mode->scanline_ordering; + mode->Scaling = DXGI_MODE_SCALING_UNSPECIFIED; /* FIXME */ +} + static inline struct dxgi_output *impl_from_IDXGIOutput(IDXGIOutput *iface) { return CONTAINING_RECORD(iface, struct dxgi_output, IDXGIOutput_iface); @@ -154,11 +165,10 @@ static HRESULT STDMETHODCALLTYPE dxgi_output_GetDesc(IDXGIOutput *iface, DXGI_OU static HRESULT STDMETHODCALLTYPE dxgi_output_GetDisplayModeList(IDXGIOutput *iface, DXGI_FORMAT format, UINT flags, UINT *mode_count, DXGI_MODE_DESC *desc) { - struct dxgi_output *This = impl_from_IDXGIOutput(iface); + struct dxgi_output *output = impl_from_IDXGIOutput(iface); enum wined3d_format_id wined3d_format; + unsigned int i, max_count; struct wined3d *wined3d; - UINT i; - UINT max_count; FIXME("iface %p, format %s, flags %#x, mode_count %p, desc %p partial stub!\n", iface, debug_dxgi_format(format), flags, mode_count, desc); @@ -172,11 +182,11 @@ static HRESULT STDMETHODCALLTYPE dxgi_output_GetDisplayModeList(IDXGIOutput *ifa return S_OK; } - wined3d = This->adapter->factory->wined3d; + wined3d = output->adapter->factory->wined3d; wined3d_format = wined3dformat_from_dxgi_format(format); wined3d_mutex_lock(); - max_count = wined3d_get_adapter_mode_count(wined3d, This->adapter->ordinal, + max_count = wined3d_get_adapter_mode_count(wined3d, output->adapter->ordinal, wined3d_format, WINED3D_SCANLINE_ORDERING_UNKNOWN); if (!desc) @@ -199,7 +209,7 @@ static HRESULT STDMETHODCALLTYPE dxgi_output_GetDisplayModeList(IDXGIOutput *ifa struct wined3d_display_mode mode; HRESULT hr; - hr = wined3d_enum_adapter_modes(wined3d, This->adapter->ordinal, wined3d_format, + hr = wined3d_enum_adapter_modes(wined3d, output->adapter->ordinal, wined3d_format, WINED3D_SCANLINE_ORDERING_UNKNOWN, i, &mode); if (FAILED(hr)) { @@ -208,13 +218,7 @@ static HRESULT STDMETHODCALLTYPE dxgi_output_GetDisplayModeList(IDXGIOutput *ifa return hr; } - desc[i].Width = mode.width; - desc[i].Height = mode.height; - desc[i].RefreshRate.Numerator = mode.refresh_rate; - desc[i].RefreshRate.Denominator = 1; - desc[i].Format = format; - desc[i].ScanlineOrdering = mode.scanline_ordering; - desc[i].Scaling = DXGI_MODE_SCALING_UNSPECIFIED; /* FIXME */ + dxgi_mode_from_wined3d(&desc[i], &mode); } wined3d_mutex_unlock(); diff --git a/dlls/dxgi/swapchain.c b/dlls/dxgi/swapchain.c index 0057aa2..e0185dd 100644 --- a/dlls/dxgi/swapchain.c +++ b/dlls/dxgi/swapchain.c @@ -351,11 +351,7 @@ static HRESULT STDMETHODCALLTYPE dxgi_swapchain_ResizeTarget(IDXGISwapChain *ifa if (target_mode_desc->Scaling) FIXME("Ignoring scaling %#x.\n", target_mode_desc->Scaling); - mode.width = target_mode_desc->Width; - mode.height = target_mode_desc->Height; - mode.refresh_rate = dxgi_rational_to_uint(&target_mode_desc->RefreshRate); - mode.format_id = wined3dformat_from_dxgi_format(target_mode_desc->Format); - mode.scanline_ordering = wined3d_scanline_ordering_from_dxgi(target_mode_desc->ScanlineOrdering); + wined3d_display_mode_from_dxgi(&mode, target_mode_desc); wined3d_mutex_lock(); hr = wined3d_swapchain_resize_target(swapchain->wined3d_swapchain, &mode); diff --git a/dlls/dxgi/utils.c b/dlls/dxgi/utils.c index b9be4a5..eda279f 100644 --- a/dlls/dxgi/utils.c +++ b/dlls/dxgi/utils.c @@ -443,6 +443,16 @@ void wined3d_sample_desc_from_dxgi(enum wined3d_multisample_type *wined3d_type, } } +void wined3d_display_mode_from_dxgi(struct wined3d_display_mode *wined3d_mode, + const DXGI_MODE_DESC *mode) +{ + wined3d_mode->width = mode->Width; + wined3d_mode->height = mode->Height; + wined3d_mode->refresh_rate = dxgi_rational_to_uint(&mode->RefreshRate); + wined3d_mode->format_id = wined3dformat_from_dxgi_format(mode->Format); + wined3d_mode->scanline_ordering = wined3d_scanline_ordering_from_dxgi(mode->ScanlineOrdering); +} + unsigned int dxgi_swapchain_flags_from_wined3d(unsigned int wined3d_flags) { unsigned int flags = 0;
1
0
0
0
← Newer
1
...
7
8
9
10
11
12
13
...
78
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
Results per page:
10
25
50
100
200