wine-commits August 2016

wine-commits@winehq.org

2 participants
777 discussions

Colin Finck : include: Add a prototype for RpcBindingServerFromClient.
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: wine Branch: master Commit: 8c900c8fb251ad15845980f15c9cb826fc9fa868 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8c900c8fb251ad15845980f15… Author: Colin Finck <mail(a)colinfinck.de> Date: Fri Aug 19 11:52:57 2016 +0200 include: Add a prototype for RpcBindingServerFromClient. Signed-off-by: Colin Finck <mail(a)colinfinck.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/rpcdce.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/rpcdce.h b/include/rpcdce.h index f5f031c..ee01d88 100644 --- a/include/rpcdce.h +++ b/include/rpcdce.h @@ -338,6 +338,8 @@ RPCRTAPI RPC_STATUS RPC_ENTRY RPCRTAPI RPC_STATUS RPC_ENTRY RpcBindingReset( RPC_BINDING_HANDLE Binding ); RPCRTAPI RPC_STATUS RPC_ENTRY + RpcBindingServerFromClient( RPC_BINDING_HANDLE ClientBinding, RPC_BINDING_HANDLE* ServerBinding ); +RPCRTAPI RPC_STATUS RPC_ENTRY RpcBindingSetObject( RPC_BINDING_HANDLE Binding, UUID* ObjectUuid ); RPCRTAPI RPC_STATUS RPC_ENTRY RpcBindingSetOption( RPC_BINDING_HANDLE Binding, ULONG Option, ULONG_PTR OptionValue );

1 0

Andrew Eikum : mshtml: Don't crash creating a URI if we have no document.
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: wine Branch: master Commit: 22783dfef88acd506587ce183f8e9f791c31aa70 URL: http://source.winehq.org/git/wine.git/?a=commit;h=22783dfef88acd506587ce183… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Fri Aug 19 08:27:20 2016 -0500 mshtml: Don't crash creating a URI if we have no document. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Jacek Caban <jacek(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/mshtml/nsio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dlls/mshtml/nsio.c b/dlls/mshtml/nsio.c index 88164d0..0e2a748 100644 --- a/dlls/mshtml/nsio.c +++ b/dlls/mshtml/nsio.c @@ -3463,7 +3463,8 @@ HRESULT create_doc_uri(HTMLOuterWindow *window, IUri *iuri, nsWineURI **ret) nsWineURI *uri; nsresult nsres; - nsres = create_nsuri(iuri, window, window->doc_obj->nscontainer, NULL, &uri); + nsres = create_nsuri(iuri, window, window->doc_obj ? window->doc_obj->nscontainer : NULL, + NULL, &uri); if(NS_FAILED(nsres)) return E_FAIL;

1 0

André Hentschel : ntdll: Bump Win 10 version to 14393.
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: wine Branch: master Commit: 24031fef653e8f5ad34a2bf4117a7cd516a32eab URL: http://source.winehq.org/git/wine.git/?a=commit;h=24031fef653e8f5ad34a2bf41… Author: André Hentschel <nerv(a)dawncrow.de> Date: Fri Aug 19 16:17:36 2016 +0200 ntdll: Bump Win 10 version to 14393. Signed-off-by: André Hentschel <nerv(a)dawncrow.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/version.c | 2 +- programs/winecfg/appdefaults.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dlls/ntdll/version.c b/dlls/ntdll/version.c index 41b44f5..b6cafc6 100644 --- a/dlls/ntdll/version.c +++ b/dlls/ntdll/version.c @@ -187,7 +187,7 @@ static const RTL_OSVERSIONINFOEXW VersionData[NB_WINDOWS_VERSIONS] = }, /* WIN10 */ { - sizeof(RTL_OSVERSIONINFOEXW), 10, 0, 0x2800, VER_PLATFORM_WIN32_NT, + sizeof(RTL_OSVERSIONINFOEXW), 10, 0, 0x3839, VER_PLATFORM_WIN32_NT, {' ',0}, 0, 0, VER_SUITE_SINGLEUSERTS, VER_NT_WORKSTATION, 0 }, diff --git a/programs/winecfg/appdefaults.c b/programs/winecfg/appdefaults.c index 82dc870..91478fc 100644 --- a/programs/winecfg/appdefaults.c +++ b/programs/winecfg/appdefaults.c @@ -48,7 +48,7 @@ static const struct const char *szProductType; } win_versions[] = { - { "win10", "Windows 10", 10, 0, 0x2800,VER_PLATFORM_WIN32_NT, " ", 0, 0, "WinNT"}, + { "win10", "Windows 10", 10, 0, 0x3839,VER_PLATFORM_WIN32_NT, " ", 0, 0, "WinNT"}, { "win81", "Windows 8.1", 6, 3, 0x2580,VER_PLATFORM_WIN32_NT, " ", 0, 0, "WinNT"}, { "win8", "Windows 8", 6, 2, 0x23F0,VER_PLATFORM_WIN32_NT, " ", 0, 0, "WinNT"}, { "win2008r2", "Windows 2008 R2", 6, 1, 0x1DB1,VER_PLATFORM_WIN32_NT, "Service Pack 1", 1, 0, "ServerNT"},

1 0

Sebastian Lackner : ws2_32: Do not spawn a separate thread for each async task.
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: wine Branch: master Commit: d638653f07b948da3a149fa8c72c837836971e2d URL: http://source.winehq.org/git/wine.git/?a=commit;h=d638653f07b948da3a149fa8c… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Sun Aug 21 19:55:43 2016 +0200 ws2_32: Do not spawn a separate thread for each async task. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ws2_32/async.c | 61 +++++++++++++++++++++++++++-------------------------- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/dlls/ws2_32/async.c b/dlls/ws2_32/async.c index 573349f..56c60fc 100644 --- a/dlls/ws2_32/async.c +++ b/dlls/ws2_32/async.c @@ -52,6 +52,7 @@ WINE_DEFAULT_DEBUG_CHANNEL(winsock); struct async_query_header { + LPARAM (*func)( struct async_query_header *query ); HWND hWnd; UINT uMsg; void *sbuf; @@ -128,13 +129,6 @@ static int list_dup(char** l_src, char* ref, int item_size) return (p - ref); } -static DWORD finish_query( struct async_query_header *query, LPARAM lparam ) -{ - PostMessageW( query->hWnd, query->uMsg, (WPARAM)query->handle, lparam ); - HeapFree( GetProcessHeap(), 0, query ); - return 0; -} - /* ----- hostent */ static LPARAM copy_he(void *base, int size, const struct WS_hostent *he) @@ -162,20 +156,20 @@ static LPARAM copy_he(void *base, int size, const struct WS_hostent *he) return MAKELPARAM( needed, 0 ); } -static DWORD WINAPI async_gethostbyname(LPVOID arg) +static LPARAM async_gethostbyname( struct async_query_header *query ) { - struct async_query_gethostbyname *aq = arg; + struct async_query_gethostbyname *aq = CONTAINING_RECORD( query, struct async_query_gethostbyname, query ); struct WS_hostent *he = WS_gethostbyname( aq->host_name ); - return finish_query( &aq->query, copy_he( aq->query.sbuf, aq->query.sbuflen, he )); + return copy_he( query->sbuf, query->sbuflen, he ); } -static DWORD WINAPI async_gethostbyaddr(LPVOID arg) +static LPARAM async_gethostbyaddr( struct async_query_header *query ) { - struct async_query_gethostbyaddr *aq = arg; + struct async_query_gethostbyaddr *aq = CONTAINING_RECORD( query, struct async_query_gethostbyaddr, query ); struct WS_hostent *he = WS_gethostbyaddr( aq->host_addr, aq->host_len, aq->host_type ); - return finish_query( &aq->query, copy_he( aq->query.sbuf, aq->query.sbuflen, he )); + return copy_he( query->sbuf, query->sbuflen, he ); } /* ----- protoent */ @@ -200,20 +194,20 @@ static LPARAM copy_pe(void *base, int size, const struct WS_protoent* pe) return MAKELPARAM( needed, 0 ); } -static DWORD WINAPI async_getprotobyname(LPVOID arg) +static LPARAM async_getprotobyname( struct async_query_header *query ) { - struct async_query_getprotobyname *aq = arg; + struct async_query_getprotobyname *aq = CONTAINING_RECORD( query, struct async_query_getprotobyname, query ); struct WS_protoent *pe = WS_getprotobyname( aq->proto_name ); - return finish_query( &aq->query, copy_pe( aq->query.sbuf, aq->query.sbuflen, pe )); + return copy_pe( query->sbuf, query->sbuflen, pe ); } -static DWORD WINAPI async_getprotobynumber(LPVOID arg) +static LPARAM async_getprotobynumber( struct async_query_header *query ) { - struct async_query_getprotobynumber *aq = arg; + struct async_query_getprotobynumber *aq = CONTAINING_RECORD( query, struct async_query_getprotobynumber, query ); struct WS_protoent *pe = WS_getprotobynumber( aq->proto_number ); - return finish_query( &aq->query, copy_pe( aq->query.sbuf, aq->query.sbuflen, pe )); + return copy_pe( query->sbuf, query->sbuflen, pe ); } /* ----- servent */ @@ -240,20 +234,29 @@ static LPARAM copy_se(void *base, int size, const struct WS_servent* se) return MAKELPARAM( needed, 0 ); } -static DWORD WINAPI async_getservbyname(LPVOID arg) +static LPARAM async_getservbyname( struct async_query_header *query ) { - struct async_query_getservbyname *aq = arg; + struct async_query_getservbyname *aq = CONTAINING_RECORD( query, struct async_query_getservbyname, query ); struct WS_servent *se = WS_getservbyname( aq->serv_name, aq->serv_proto ); - return finish_query( &aq->query, copy_se( aq->query.sbuf, aq->query.sbuflen, se )); + return copy_se( query->sbuf, query->sbuflen, se ); } -static DWORD WINAPI async_getservbyport(LPVOID arg) +static LPARAM async_getservbyport( struct async_query_header *query ) { - struct async_query_getservbyport *aq = arg; + struct async_query_getservbyport *aq = CONTAINING_RECORD( query, struct async_query_getservbyport, query ); struct WS_servent *se = WS_getservbyport( aq->serv_port, aq->serv_proto ); - return finish_query( &aq->query, copy_se( aq->query.sbuf, aq->query.sbuflen, se )); + return copy_se( query->sbuf, query->sbuflen, se ); +} + + +static void WINAPI async_worker( TP_CALLBACK_INSTANCE *instance, void *context ) +{ + struct async_query_header *query = context; + LPARAM lparam = query->func( query ); + PostMessageW( query->hWnd, query->uMsg, (WPARAM)query->handle, lparam ); + HeapFree( GetProcessHeap(), 0, query ); } @@ -264,30 +267,28 @@ static DWORD WINAPI async_getservbyport(LPVOID arg) * with no thread support. This relies on the fact that PostMessage() does * not actually call the windowproc before the function returns. */ -static HANDLE run_query( HWND hWnd, UINT uMsg, LPTHREAD_START_ROUTINE func, +static HANDLE run_query( HWND hWnd, UINT uMsg, LPARAM (*func)(struct async_query_header *), struct async_query_header *query, void *sbuf, INT sbuflen ) { static LONG next_handle = 0xdead; - HANDLE thread; ULONG handle; do handle = LOWORD( InterlockedIncrement( &next_handle )); while (!handle); /* avoid handle 0 */ + query->func = func; query->hWnd = hWnd; query->uMsg = uMsg; query->handle = UlongToHandle( handle ); query->sbuf = sbuf; query->sbuflen = sbuflen; - thread = CreateThread( NULL, 0, func, query, 0, NULL ); - if (!thread) + if (!TrySubmitThreadpoolCallback( async_worker, query, NULL )) { SetLastError( WSAEWOULDBLOCK ); HeapFree( GetProcessHeap(), 0, query ); return 0; } - CloseHandle( thread ); return UlongToHandle( handle ); }

1 0

Sebastian Lackner : ws2_32/tests: Add basic tests for async messages.
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: wine Branch: master Commit: 58f944bb4b68cef5c95da4829214e59c9705bd6b URL: http://source.winehq.org/git/wine.git/?a=commit;h=58f944bb4b68cef5c95da4829… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Sun Aug 21 21:20:08 2016 +0200 ws2_32/tests: Add basic tests for async messages. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ws2_32/tests/sock.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c index d6412fd..2640dd4 100644 --- a/dlls/ws2_32/tests/sock.c +++ b/dlls/ws2_32/tests/sock.c @@ -8464,6 +8464,22 @@ static HWND create_async_message_window(void) return hWnd; } +static void wait_for_async_message(HWND hwnd, HANDLE handle) +{ + BOOL ret; + MSG msg; + + while ((ret = GetMessageA(&msg, 0, 0, 0)) && + !(msg.hwnd == hwnd && msg.message == WM_ASYNCCOMPLETE)) + { + TranslateMessage(&msg); + DispatchMessageA(&msg); + } + + ok(ret, "did not expect WM_QUIT message\n"); + ok(msg.wParam == (WPARAM)handle, "expected wParam = %p, got %lx\n", handle, msg.wParam); +} + static void test_WSAAsyncGetServByPort(void) { HWND hwnd = create_async_message_window(); @@ -8481,12 +8497,15 @@ static void test_WSAAsyncGetServByPort(void) ret = WSAAsyncGetServByPort(hwnd, WM_ASYNCCOMPLETE, 0, NULL, NULL, 0); ok(ret != NULL, "WSAAsyncGetServByPort returned NULL\n"); + wait_for_async_message(hwnd, ret); ret = WSAAsyncGetServByPort(hwnd, WM_ASYNCCOMPLETE, htons(80), NULL, NULL, 0); ok(ret != NULL, "WSAAsyncGetServByPort returned NULL\n"); + wait_for_async_message(hwnd, ret); ret = WSAAsyncGetServByPort(hwnd, WM_ASYNCCOMPLETE, htons(80), NULL, buffer, MAXGETHOSTSTRUCT); ok(ret != NULL, "WSAAsyncGetServByPort returned NULL\n"); + wait_for_async_message(hwnd, ret); DestroyWindow(hwnd); } @@ -8505,15 +8524,19 @@ static void test_WSAAsyncGetServByName(void) /* Parameters are not checked when initiating the asynchronous operation. */ ret = WSAAsyncGetServByName(hwnd, WM_ASYNCCOMPLETE, "", NULL, NULL, 0); ok(ret != NULL, "WSAAsyncGetServByName returned NULL\n"); + wait_for_async_message(hwnd, ret); ret = WSAAsyncGetServByName(hwnd, WM_ASYNCCOMPLETE, "", "", buffer, MAXGETHOSTSTRUCT); ok(ret != NULL, "WSAAsyncGetServByName returned NULL\n"); + wait_for_async_message(hwnd, ret); ret = WSAAsyncGetServByName(hwnd, WM_ASYNCCOMPLETE, "http", NULL, NULL, 0); ok(ret != NULL, "WSAAsyncGetServByName returned NULL\n"); + wait_for_async_message(hwnd, ret); ret = WSAAsyncGetServByName(hwnd, WM_ASYNCCOMPLETE, "http", "tcp", buffer, MAXGETHOSTSTRUCT); ok(ret != NULL, "WSAAsyncGetServByName returned NULL\n"); + wait_for_async_message(hwnd, ret); DestroyWindow(hwnd); }

1 0

Bruno Jesus : dinput: Get the controller type from the device instance for Linux drivers.
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: wine Branch: master Commit: 6b44c4f5cc501c7603bf98483dccb1a75f75ebe0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=6b44c4f5cc501c7603bf98483… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Sat Aug 20 22:55:34 2016 -0300 dinput: Get the controller type from the device instance for Linux drivers. Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/joystick_linux.c | 10 ++++++---- dlls/dinput/joystick_linuxinput.c | 9 +++++---- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/dlls/dinput/joystick_linux.c b/dlls/dinput/joystick_linux.c index c0a885d..3086e68 100644 --- a/dlls/dinput/joystick_linux.c +++ b/dlls/dinput/joystick_linux.c @@ -406,6 +406,7 @@ static HRESULT alloc_device(REFGUID rguid, IDirectInputImpl *dinput, HRESULT hr; LPDIDATAFORMAT df = NULL; int idx = 0; + DIDEVICEINSTANCEW ddi; TRACE("%s %p %p %hu\n", debugstr_guid(rguid), dinput, pdev, index); @@ -496,10 +497,11 @@ static HRESULT alloc_device(REFGUID rguid, IDirectInputImpl *dinput, newDevice->generic.devcaps.dwSize = sizeof(newDevice->generic.devcaps); newDevice->generic.devcaps.dwFlags = DIDC_ATTACHED; - if (newDevice->generic.base.dinput->dwVersion >= 0x0800) - newDevice->generic.devcaps.dwDevType = DI8DEVTYPE_JOYSTICK | (DI8DEVTYPEJOYSTICK_STANDARD << 8); - else - newDevice->generic.devcaps.dwDevType = DIDEVTYPE_JOYSTICK | (DIDEVTYPEJOYSTICK_TRADITIONAL << 8); + + ddi.dwSize = sizeof(ddi); + fill_joystick_dideviceinstanceW(&ddi, newDevice->generic.base.dinput->dwVersion, index); + newDevice->generic.devcaps.dwDevType = ddi.dwDevType; + newDevice->generic.devcaps.dwFFSamplePeriod = 0; newDevice->generic.devcaps.dwFFMinTimeResolution = 0; newDevice->generic.devcaps.dwFirmwareRevision = 0; diff --git a/dlls/dinput/joystick_linuxinput.c b/dlls/dinput/joystick_linuxinput.c index ecd239c..911700b 100644 --- a/dlls/dinput/joystick_linuxinput.c +++ b/dlls/dinput/joystick_linuxinput.c @@ -452,6 +452,7 @@ static JoystickImpl *alloc_device(REFGUID rguid, IDirectInputImpl *dinput, unsig LPDIDATAFORMAT df = NULL; int i, idx = 0; int default_axis_map[WINE_JOYSTICK_MAX_AXES + WINE_JOYSTICK_MAX_POVS*2]; + DIDEVICEINSTANCEW ddi; newDevice = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(JoystickImpl)); if (!newDevice) return NULL; @@ -571,10 +572,10 @@ static JoystickImpl *alloc_device(REFGUID rguid, IDirectInputImpl *dinput, unsig /* Fill the caps */ newDevice->generic.devcaps.dwSize = sizeof(newDevice->generic.devcaps); newDevice->generic.devcaps.dwFlags = DIDC_ATTACHED; - if (newDevice->generic.base.dinput->dwVersion >= 0x0800) - newDevice->generic.devcaps.dwDevType = DI8DEVTYPE_JOYSTICK | (DI8DEVTYPEJOYSTICK_STANDARD << 8); - else - newDevice->generic.devcaps.dwDevType = DIDEVTYPE_JOYSTICK | (DIDEVTYPEJOYSTICK_TRADITIONAL << 8); + + ddi.dwSize = sizeof(ddi); + fill_joystick_dideviceinstanceW(&ddi, newDevice->generic.base.dinput->dwVersion, index); + newDevice->generic.devcaps.dwDevType = ddi.dwDevType; if (newDevice->joydev->has_ff) newDevice->generic.devcaps.dwFlags |= DIDC_FORCEFEEDBACK;

1 0

Bruno Jesus : dinput: Dump the DIOBJECTDATAFORMAT flags.
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: wine Branch: master Commit: 4cc193bba589086a5f6a294b0bcd5fbaac4c412f URL: http://source.winehq.org/git/wine.git/?a=commit;h=4cc193bba589086a5f6a294b0… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Sat Aug 20 15:49:33 2016 -0300 dinput: Dump the DIOBJECTDATAFORMAT flags. Useful to check if the controller is asking for a specifc DIDOI_POSITION* type axis. Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/device.c | 49 ++++++++++++++++++++++++++++++++++++++++++++++--- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c index c34b541..a9ef2d4 100644 --- a/dlls/dinput/device.c +++ b/dlls/dinput/device.c @@ -85,6 +85,42 @@ static void _dump_cooperativelevel_DI(DWORD dwFlags) { } } +static void _dump_ObjectDataFormat_flags(DWORD dwFlags) { + unsigned int i; + static const struct { + DWORD mask; + const char *name; + } flags[] = { +#define FE(x) { x, #x} + FE(DIDOI_FFACTUATOR), + FE(DIDOI_FFEFFECTTRIGGER), + FE(DIDOI_POLLED), + FE(DIDOI_GUIDISUSAGE) +#undef FE + }; + + if (!dwFlags) return; + + TRACE("Flags:"); + + /* First the flags */ + for (i = 0; i < (sizeof(flags) / sizeof(flags[0])); i++) { + if (flags[i].mask & dwFlags) + TRACE(" %s",flags[i].name); + } + + /* Now specific values */ +#define FE(x) case x: TRACE(" "#x); break + switch (dwFlags & DIDOI_ASPECTMASK) { + FE(DIDOI_ASPECTACCEL); + FE(DIDOI_ASPECTFORCE); + FE(DIDOI_ASPECTPOSITION); + FE(DIDOI_ASPECTVELOCITY); + } +#undef FE + +} + static void _dump_EnumObjects_flags(DWORD dwFlags) { if (TRACE_ON(dinput)) { unsigned int i; @@ -229,6 +265,7 @@ void _dump_DIDATAFORMAT(const DIDATAFORMAT *df) { TRACE(" * dwType: 0x%08x\n", df->rgodf[i].dwType); TRACE(" "); _dump_EnumObjects_flags(df->rgodf[i].dwType); TRACE("\n"); TRACE(" * dwFlags: 0x%08x\n", df->rgodf[i].dwFlags); + TRACE(" "); _dump_ObjectDataFormat_flags(df->rgodf[i].dwFlags); TRACE("\n"); } } @@ -445,16 +482,20 @@ static HRESULT create_DataFormat(LPCDIDATAFORMAT asked_format, DataFormat *forma debugstr_guid(asked_format->rgodf[j].pguid), _dump_dinput_GUID(asked_format->rgodf[j].pguid)); TRACE(" * Offset: %3d\n", asked_format->rgodf[j].dwOfs); - TRACE(" * dwType: %08x\n", asked_format->rgodf[j].dwType); + TRACE(" * dwType: 0x%08x\n", asked_format->rgodf[j].dwType); TRACE(" "); _dump_EnumObjects_flags(asked_format->rgodf[j].dwType); TRACE("\n"); + TRACE(" * dwFlags: 0x%08x\n", asked_format->rgodf[j].dwFlags); + TRACE(" "); _dump_ObjectDataFormat_flags(asked_format->rgodf[j].dwFlags); TRACE("\n"); TRACE(" - Wine (%d) :\n", i); TRACE(" * GUID: %s ('%s')\n", debugstr_guid(format->wine_df->rgodf[i].pguid), _dump_dinput_GUID(format->wine_df->rgodf[i].pguid)); TRACE(" * Offset: %3d\n", format->wine_df->rgodf[i].dwOfs); - TRACE(" * dwType: %08x\n", format->wine_df->rgodf[i].dwType); + TRACE(" * dwType: 0x%08x\n", format->wine_df->rgodf[i].dwType); TRACE(" "); _dump_EnumObjects_flags(format->wine_df->rgodf[i].dwType); TRACE("\n"); + TRACE(" * dwFlags: 0x%08x\n", format->wine_df->rgodf[i].dwFlags); + TRACE(" "); _dump_ObjectDataFormat_flags(format->wine_df->rgodf[i].dwFlags); TRACE("\n"); if (format->wine_df->rgodf[i].dwType & DIDFT_BUTTON) dt[index].size = sizeof(BYTE); @@ -483,8 +524,10 @@ static HRESULT create_DataFormat(LPCDIDATAFORMAT asked_format, DataFormat *forma debugstr_guid(asked_format->rgodf[j].pguid), _dump_dinput_GUID(asked_format->rgodf[j].pguid)); TRACE(" * Offset: %3d\n", asked_format->rgodf[j].dwOfs); - TRACE(" * dwType: %08x\n", asked_format->rgodf[j].dwType); + TRACE(" * dwType: 0x%08x\n", asked_format->rgodf[j].dwType); TRACE(" "); _dump_EnumObjects_flags(asked_format->rgodf[j].dwType); TRACE("\n"); + TRACE(" * dwFlags: 0x%08x\n", asked_format->rgodf[j].dwFlags); + TRACE(" "); _dump_ObjectDataFormat_flags(asked_format->rgodf[j].dwFlags); TRACE("\n"); if (asked_format->rgodf[j].dwType & DIDFT_BUTTON) dt[index].size = sizeof(BYTE);

1 0

Bruno Jesus : dinput: Return the correct error when CreateEffect is not supported.
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: wine Branch: master Commit: f051de0d37946c559625b03274f6d07ae3595c09 URL: http://source.winehq.org/git/wine.git/?a=commit;h=f051de0d37946c559625b0327… Author: Bruno Jesus <00cpxxx(a)gmail.com> Date: Fri Aug 19 17:59:10 2016 -0300 dinput: Return the correct error when CreateEffect is not supported. Signed-off-by: Bruno Jesus <00cpxxx(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/dinput/device.c | 5 +- dlls/dinput/joystick_linuxinput.c | 12 +++- dlls/dinput/joystick_osx.c | 2 +- dlls/dinput/tests/joystick.c | 124 ++++++++++++++++++++------------------ 4 files changed, 81 insertions(+), 62 deletions(-) diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c index db4507d..c34b541 100644 --- a/dlls/dinput/device.c +++ b/dlls/dinput/device.c @@ -1551,7 +1551,10 @@ HRESULT WINAPI IDirectInputDevice2WImpl_CreateEffect(LPDIRECTINPUTDEVICE8W iface LPDIRECTINPUTEFFECT *ppdef, LPUNKNOWN pUnkOuter) { FIXME("(this=%p,%s,%p,%p,%p): stub!\n", iface, debugstr_guid(rguid), lpeff, ppdef, pUnkOuter); - return DI_OK; + + FIXME("not available in the generic implementation\n"); + *ppdef = NULL; + return DIERR_UNSUPPORTED; } HRESULT WINAPI IDirectInputDevice2AImpl_CreateEffect(LPDIRECTINPUTDEVICE8A iface, REFGUID rguid, LPCDIEFFECT lpeff, diff --git a/dlls/dinput/joystick_linuxinput.c b/dlls/dinput/joystick_linuxinput.c index 6fa5997..ecd239c 100644 --- a/dlls/dinput/joystick_linuxinput.c +++ b/dlls/dinput/joystick_linuxinput.c @@ -1049,10 +1049,16 @@ static HRESULT WINAPI JoystickWImpl_CreateEffect(LPDIRECTINPUTDEVICE8W iface, RE JoystickImpl* This = impl_from_IDirectInputDevice8W(iface); TRACE("(this=%p,%p,%p,%p,%p)\n", This, rguid, lpeff, ppdef, pUnkOuter); -#ifndef HAVE_STRUCT_FF_EFFECT_DIRECTION - TRACE("not available (compiled w/o ff support)\n"); *ppdef = NULL; - return DI_OK; + if (!This->joydev->has_ff) + { + TRACE("No force feedback support\n"); + return DIERR_UNSUPPORTED; + } + +#ifndef HAVE_STRUCT_FF_EFFECT_DIRECTION + TRACE("not available (compiled w/o force feedback support)\n"); + return DIERR_UNSUPPORTED; #else if (!(new_effect = HeapAlloc(GetProcessHeap(), 0, sizeof(*new_effect)))) diff --git a/dlls/dinput/joystick_osx.c b/dlls/dinput/joystick_osx.c index 24f60d7..43fa20e 100644 --- a/dlls/dinput/joystick_osx.c +++ b/dlls/dinput/joystick_osx.c @@ -1398,7 +1398,7 @@ static HRESULT WINAPI JoystickWImpl_CreateEffect(IDirectInputDevice8W *iface, if(!This->ff){ TRACE("No force feedback support\n"); *out = NULL; - return S_OK; + return DIERR_UNSUPPORTED; } if(outer) diff --git a/dlls/dinput/tests/joystick.c b/dlls/dinput/tests/joystick.c index af36e6d..ed74bb9 100644 --- a/dlls/dinput/tests/joystick.c +++ b/dlls/dinput/tests/joystick.c @@ -186,6 +186,15 @@ static BOOL CALLBACK EnumJoysticks(const DIDEVICEINSTANCEA *lpddi, void *pvRef) WCHAR nameBuffer[MAX_PATH]; HWND hWnd = get_hwnd(); char oldstate[248], curstate[248]; + DWORD axes[2] = {DIJOFS_X, DIJOFS_Y}; + LONG direction[2] = {0, 0}; + DICONSTANTFORCE force = {0}; + DIEFFECT eff; + LPDIRECTINPUTEFFECT effect = NULL; + LONG cnt1, cnt2; + HWND real_hWnd; + HINSTANCE hInstance = GetModuleHandleW(NULL); + DIPROPDWORD dip_gain_set, dip_gain_get; ok(data->version > 0x0300, "Joysticks not supported in version 0x%04x\n", data->version); @@ -384,54 +393,46 @@ static BOOL CALLBACK EnumJoysticks(const DIDEVICEINSTANCEA *lpddi, void *pvRef) ok(js.rgdwPOV[3] == -1, "Default for unassigned POV should be -1 not: %d\n", js.rgdwPOV[3]); } - if (caps.dwFlags & DIDC_FORCEFEEDBACK) - { - DWORD axes[2] = {DIJOFS_X, DIJOFS_Y}; - LONG direction[2] = {0, 0}; - DICONSTANTFORCE force = {0}; - DIEFFECT eff; - LPDIRECTINPUTEFFECT effect = NULL; - LONG cnt1, cnt2; - HWND real_hWnd; - HINSTANCE hInstance = GetModuleHandleW(NULL); - DIPROPDWORD dip_gain_set, dip_gain_get; - - trace("Testing force-feedback\n"); - memset(&eff, 0, sizeof(eff)); - eff.dwSize = sizeof(eff); - eff.dwFlags = DIEFF_CARTESIAN | DIEFF_OBJECTOFFSETS; - eff.dwDuration = INFINITE; - eff.dwGain = DI_FFNOMINALMAX; - eff.dwTriggerButton = DIEB_NOTRIGGER; - eff.cAxes = sizeof(axes) / sizeof(axes[0]); - eff.rgdwAxes = axes; - eff.rglDirection = direction; - eff.cbTypeSpecificParams = sizeof(force); - eff.lpvTypeSpecificParams = &force; - - /* Sending effects to joystick requires - * calling IDirectInputEffect_Initialize, which requires - * having exclusive access to the device, which requires - * - not having acquired the joystick when calling - * IDirectInputDevice_SetCooperativeLevel - * - a visible window - */ - real_hWnd = CreateWindowExA(0, "EDIT", "Test text", 0, 10, 10, 300, 300, NULL, NULL, - hInstance, NULL); - ok(real_hWnd!=0,"CreateWindowExA failed: %p\n", real_hWnd); - ShowWindow(real_hWnd, SW_SHOW); - hr = IDirectInputDevice_Unacquire(pJoystick); - ok(hr==DI_OK,"IDirectInputDevice_Unacquire() failed: %08x\n", hr); - hr = IDirectInputDevice_SetCooperativeLevel(pJoystick, real_hWnd, - DISCL_EXCLUSIVE | DISCL_FOREGROUND); - ok(hr==DI_OK,"IDirectInputDevice_SetCooperativeLevel() failed: %08x\n", hr); - hr = IDirectInputDevice_Acquire(pJoystick); - ok(hr==DI_OK,"IDirectInputDevice_Acquire() failed: %08x\n", hr); + trace("Testing force feedback\n"); + memset(&eff, 0, sizeof(eff)); + eff.dwSize = sizeof(eff); + eff.dwFlags = DIEFF_CARTESIAN | DIEFF_OBJECTOFFSETS; + eff.dwDuration = INFINITE; + eff.dwGain = DI_FFNOMINALMAX; + eff.dwTriggerButton = DIEB_NOTRIGGER; + eff.cAxes = sizeof(axes) / sizeof(axes[0]); + eff.rgdwAxes = axes; + eff.rglDirection = direction; + eff.cbTypeSpecificParams = sizeof(force); + eff.lpvTypeSpecificParams = &force; + + /* Sending effects to joystick requires + * calling IDirectInputEffect_Initialize, which requires + * having exclusive access to the device, which requires + * - not having acquired the joystick when calling + * IDirectInputDevice_SetCooperativeLevel + * - a visible window + */ + real_hWnd = CreateWindowExA(0, "EDIT", "Test text", 0, 10, 10, 300, 300, NULL, NULL, + hInstance, NULL); + ok(real_hWnd!=0,"CreateWindowExA failed: %p\n", real_hWnd); + ShowWindow(real_hWnd, SW_SHOW); + hr = IDirectInputDevice_Unacquire(pJoystick); + ok(hr==DI_OK,"IDirectInputDevice_Unacquire() failed: %08x\n", hr); + hr = IDirectInputDevice_SetCooperativeLevel(pJoystick, real_hWnd, + DISCL_EXCLUSIVE | DISCL_FOREGROUND); + ok(hr==DI_OK,"IDirectInputDevice_SetCooperativeLevel() failed: %08x\n", hr); + hr = IDirectInputDevice_Acquire(pJoystick); + ok(hr==DI_OK,"IDirectInputDevice_Acquire() failed: %08x\n", hr); - cnt1 = get_refcount((IUnknown*)pJoystick); + cnt1 = get_refcount((IUnknown*)pJoystick); - hr = IDirectInputDevice2_CreateEffect((IDirectInputDevice2A*)pJoystick, &GUID_ConstantForce, - &eff, &effect, NULL); + effect = (void *)0xdeadbeef; + hr = IDirectInputDevice2_CreateEffect((IDirectInputDevice2A*)pJoystick, &GUID_ConstantForce, + &eff, &effect, NULL); + if (caps.dwFlags & DIDC_FORCEFEEDBACK) + { + trace("force feedback supported\n"); ok(hr == DI_OK, "IDirectInputDevice_CreateEffect() failed: %08x\n", hr); cnt2 = get_refcount((IUnknown*)pJoystick); ok(cnt1 == cnt2, "Ref count is wrong %d != %d\n", cnt1, cnt2); @@ -622,18 +623,27 @@ static BOOL CALLBACK EnumJoysticks(const DIDEVICEINSTANCEA *lpddi, void *pvRef) } cnt1 = get_refcount((IUnknown*)pJoystick); ok(cnt1 == cnt2, "Ref count is wrong %d != %d\n", cnt1, cnt2); - - /* Before destroying the window, release joystick to revert to - * non-exclusive, background cooperative level. */ - hr = IDirectInputDevice_Unacquire(pJoystick); - ok(hr==DI_OK,"IDirectInputDevice_Unacquire() failed: %08x\n", hr); - hr = IDirectInputDevice_SetCooperativeLevel(pJoystick, hWnd, - DISCL_NONEXCLUSIVE | DISCL_BACKGROUND); - ok(hr==DI_OK,"IDirectInputDevice_SetCooperativeLevel() failed: %08x\n", hr); - DestroyWindow (real_hWnd); - hr = IDirectInputDevice_Acquire(pJoystick); - ok(hr==DI_OK,"IDirectInputDevice_Acquire() failed: %08x\n", hr); } + /* No force feedback support, CreateEffect is supposed to fail. Fairy Bloom Freesia + * calls CreateEffect without checking the DIDC_FORCEFEEDBACK. It expects the correct + * error return to determine if force feedback is unsupported. */ + else + { + trace("No force feedback support\n"); + ok(hr==DIERR_UNSUPPORTED, "IDirectInputDevice_CreateEffect() must fail with DIERR_UNSUPPORTED, got: %08x\n", hr); + ok(effect == NULL, "effect must be NULL, got %p\n", effect); + } + + /* Before destroying the window, release joystick to revert to + * non-exclusive, background cooperative level. */ + hr = IDirectInputDevice_Unacquire(pJoystick); + ok(hr==DI_OK,"IDirectInputDevice_Unacquire() failed: %08x\n", hr); + hr = IDirectInputDevice_SetCooperativeLevel(pJoystick, hWnd, + DISCL_NONEXCLUSIVE | DISCL_BACKGROUND); + ok(hr==DI_OK,"IDirectInputDevice_SetCooperativeLevel() failed: %08x\n", hr); + DestroyWindow (real_hWnd); + hr = IDirectInputDevice_Acquire(pJoystick); + ok(hr==DI_OK,"IDirectInputDevice_Acquire() failed: %08x\n", hr); if (winetest_interactive) { trace("You have 30 seconds to test all axes, sliders, POVs and buttons\n");

1 0

Dmitry Timoshkov : gdiplus: Reimplement metafile loading using gdi32 instead of IPicture.
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: wine Branch: master Commit: 2f7a2fdea3e832c31ca247948867bfe65df6dd39 URL: http://source.winehq.org/git/wine.git/?a=commit;h=2f7a2fdea3e832c31ca247948… Author: Dmitry Timoshkov <dmitry(a)baikal.ru> Date: Thu Aug 18 21:22:02 2016 +0200 gdiplus: Reimplement metafile loading using gdi32 instead of IPicture. Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Vincent Povirk <vincent(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/gdiplus/Makefile.in | 2 +- dlls/gdiplus/gdiplus_private.h | 1 - dlls/gdiplus/graphics.c | 18 +--- dlls/gdiplus/image.c | 238 +++++++++++++++++++++++++---------------- dlls/gdiplus/metafile.c | 1 - dlls/gdiplus/tests/image.c | 10 +- 6 files changed, 152 insertions(+), 118 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=2f7a2fdea3e832c31ca24…

1 0

Alexandre Julliard : Wine release 1.8.4
by Alexandre Julliard 22 Aug '16

22 Aug '16

Module: website Branch: master Commit: f9b977e94a6da965817e2321a9f9f79a6dd9c74f URL: http://source.winehq.org/git/website.git/?a=commit;h=f9b977e94a6da965817e23… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Aug 22 21:32:49 2016 +0900 Wine release 1.8.4 Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- news/en/2016082201.xml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/news/en/2016082201.xml b/news/en/2016082201.xml new file mode 100644 index 0000000..f8615e8 --- /dev/null +++ b/news/en/2016082201.xml @@ -0,0 +1,13 @@ +<news> +<date>August 22, 2016</date> +<title>Wine 1.8.4 Released</title> +<body> + The Wine maintenance release 1.8.4 is now available. + <a href="{$root}/announce/1.8.4">What's new</a> in this release: +<ul> + <li>Various bug fixes.</li> + <li>A few more cards added to the GPU description table.</li> +</ul> +The source is <a href="//dl.winehq.org/wine/source/1.8/wine-1.8.4.tar.bz2">available now</a>. +Binary packages are in the process of being built, and will appear soon at their respective <a href="{$root}/download">download locations</a>. +</body></news>

1 0

← Newer
1
...
20
21
22
23
24
25
26
...
78
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits August 2016