wine-commits August 2016

wine-commits@winehq.org

2 participants
777 discussions

Daniel Lehman : ntdll: Call __finally blocks in __C_specific_handler.
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: 0b6e5fae743a8fa096b8ad898ccace9de0776702 URL: http://source.winehq.org/git/wine.git/?a=commit;h=0b6e5fae743a8fa096b8ad898… Author: Daniel Lehman <dlehman(a)esri.com> Date: Tue Aug 2 23:52:12 2016 -0700 ntdll: Call __finally blocks in __C_specific_handler. Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/signal_x86_64.c | 27 ++++++++++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/dlls/ntdll/signal_x86_64.c b/dlls/ntdll/signal_x86_64.c index 009505f..4c88536 100644 --- a/dlls/ntdll/signal_x86_64.c +++ b/dlls/ntdll/signal_x86_64.c @@ -81,6 +81,7 @@ typedef EXCEPTION_DISPOSITION (WINAPI *PEXCEPTION_ROUTINE)( EXCEPTION_RECORD *re ULONG64 frame, CONTEXT *context, struct _DISPATCHER_CONTEXT *dispatch ); +typedef void (WINAPI *TERMINATION_HANDLER)( ULONG flags, ULONG64 frame ); typedef struct _DISPATCHER_CONTEXT { @@ -3733,8 +3734,32 @@ EXCEPTION_DISPOSITION WINAPI __C_specific_handler( EXCEPTION_RECORD *rec, TRACE( "%p %lx %p %p\n", rec, frame, context, dispatch ); if (TRACE_ON(seh)) dump_scope_table( dispatch->ImageBase, table ); - if (rec->ExceptionFlags & (EH_UNWINDING | EH_EXIT_UNWIND)) /* FIXME */ + if (rec->ExceptionFlags & (EH_UNWINDING | EH_EXIT_UNWIND)) + { + for (i = 0; i < table->Count; i++) + { + if (context->Rip >= dispatch->ImageBase + table->ScopeRecord[i].BeginAddress && + context->Rip < dispatch->ImageBase + table->ScopeRecord[i].EndAddress) + { + TERMINATION_HANDLER handler; + + if (table->ScopeRecord[i].JumpTarget) continue; + + if (rec->ExceptionFlags & EH_TARGET_UNWIND && + dispatch->TargetIp >= dispatch->ImageBase + table->ScopeRecord[i].BeginAddress && + dispatch->TargetIp < dispatch->ImageBase + table->ScopeRecord[i].EndAddress) + { + break; + } + + handler = (TERMINATION_HANDLER)(dispatch->ImageBase + table->ScopeRecord[i].HandlerAddress); + + TRACE( "calling __finally %p frame %lx\n", handler, frame ); + handler( 1, frame ); + } + } return ExceptionContinueSearch; + } for (i = 0; i < table->Count; i++) {

1 0

Iván Matellanes : msvcirt: Simplify some constructors and assignments.
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: 4b11bd80835ad7ca289b80d97499fbcf672e5fc4 URL: http://source.winehq.org/git/wine.git/?a=commit;h=4b11bd80835ad7ca289b80d97… Author: Iván Matellanes <matellanesivan(a)gmail.com> Date: Tue Aug 9 19:16:05 2016 +0100 msvcirt: Simplify some constructors and assignments. Signed-off-by: Iván Matellanes <matellanesivan(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcirt/msvcirt.c | 102 ++++++++++++++++++------------------------------- 1 file changed, 37 insertions(+), 65 deletions(-) diff --git a/dlls/msvcirt/msvcirt.c b/dlls/msvcirt/msvcirt.c index 6533af0..fd721b5 100644 --- a/dlls/msvcirt/msvcirt.c +++ b/dlls/msvcirt/msvcirt.c @@ -2296,28 +2296,37 @@ static inline ostream* ios_to_ostream(const ios *base) return (ostream*)((char*)base - ostream_vbtable[1]); } -/* ??0ostream@@QAE@PAVstreambuf@@@Z */ -/* ??0ostream@@QEAA@PEAVstreambuf@@@Z */ -DEFINE_THISCALL_WRAPPER(ostream_sb_ctor, 12) -ostream* __thiscall ostream_sb_ctor(ostream *this, streambuf *sb, BOOL virt_init) +/* ??0ostream@@IAE@XZ */ +/* ??0ostream@@IEAA@XZ */ +DEFINE_THISCALL_WRAPPER(ostream_ctor, 8) +ostream* __thiscall ostream_ctor(ostream *this, BOOL virt_init) { ios *base; - TRACE("(%p %p %d)\n", this, sb, virt_init); + TRACE("(%p %d)\n", this, virt_init); if (virt_init) { this->vbtable = ostream_vbtable; base = ostream_get_ios(this); - ios_sb_ctor(base, sb); - } else { + ios_ctor(base); + } else base = ostream_get_ios(this); - ios_init(base, sb); - } base->vtable = &MSVCP_ostream_vtable; this->unknown = 0; return this; } +/* ??0ostream@@QAE@PAVstreambuf@@@Z */ +/* ??0ostream@@QEAA@PEAVstreambuf@@@Z */ +DEFINE_THISCALL_WRAPPER(ostream_sb_ctor, 12) +ostream* __thiscall ostream_sb_ctor(ostream *this, streambuf *sb, BOOL virt_init) +{ + TRACE("(%p %p %d)\n", this, sb, virt_init); + ostream_ctor(this, virt_init); + ios_init(ostream_get_ios(this), sb); + return this; +} + /* ??0ostream@@IAE@ABV0@@Z */ /* ??0ostream@@IEAA@AEBV0@@Z */ DEFINE_THISCALL_WRAPPER(ostream_copy_ctor, 12) @@ -2326,26 +2335,6 @@ ostream* __thiscall ostream_copy_ctor(ostream *this, const ostream *copy, BOOL v return ostream_sb_ctor(this, ostream_get_ios(copy)->sb, virt_init); } -/* ??0ostream@@IAE@XZ */ -/* ??0ostream@@IEAA@XZ */ -DEFINE_THISCALL_WRAPPER(ostream_ctor, 8) -ostream* __thiscall ostream_ctor(ostream *this, BOOL virt_init) -{ - ios *base; - - TRACE("(%p %d)\n", this, virt_init); - - if (virt_init) { - this->vbtable = ostream_vbtable; - base = ostream_get_ios(this); - ios_ctor(base); - } else - base = ostream_get_ios(this); - base->vtable = &MSVCP_ostream_vtable; - this->unknown = 0; - return this; -} - /* ??1ostream@@UAE@XZ */ /* ??1ostream@@UEAA@XZ */ /* ??1ostream_withassign@@UAE@XZ */ @@ -2389,11 +2378,7 @@ ostream* __thiscall ostream_assign_sb(ostream *this, streambuf *sb) DEFINE_THISCALL_WRAPPER(ostream_assign, 8) ostream* __thiscall ostream_assign(ostream *this, const ostream *rhs) { - ios *base_rhs = ostream_get_ios(rhs); - - TRACE("(%p %p)\n", this, rhs); - - return ostream_assign_sb(this, base_rhs->sb); + return ostream_assign_sb(this, ostream_get_ios(rhs)->sb); } /* ??_Dostream@@QAEXXZ */ @@ -2956,23 +2941,21 @@ static inline istream* ios_to_istream(const ios *base) return (istream*)((char*)base - istream_vbtable[1]); } -/* ??0istream@@QAE@PAVstreambuf@@@Z */ -/* ??0istream@@QEAA@PEAVstreambuf@@@Z */ -DEFINE_THISCALL_WRAPPER(istream_sb_ctor, 12) -istream* __thiscall istream_sb_ctor(istream *this, streambuf *sb, BOOL virt_init) +/* ??0istream@@IAE@XZ */ +/* ??0istream@@IEAA@XZ */ +DEFINE_THISCALL_WRAPPER(istream_ctor, 8) +istream* __thiscall istream_ctor(istream *this, BOOL virt_init) { ios *base; - TRACE("(%p %p %d)\n", this, sb, virt_init); + TRACE("(%p %d)\n", this, virt_init); if (virt_init) { this->vbtable = istream_vbtable; base = istream_get_ios(this); - ios_sb_ctor(base, sb); - } else { + ios_ctor(base); + } else base = istream_get_ios(this); - ios_init(base, sb); - } base->vtable = &MSVCP_istream_vtable; base->flags |= FLAGS_skipws; this->extract_delim = 0; @@ -2980,6 +2963,17 @@ istream* __thiscall istream_sb_ctor(istream *this, streambuf *sb, BOOL virt_init return this; } +/* ??0istream@@QAE@PAVstreambuf@@@Z */ +/* ??0istream@@QEAA@PEAVstreambuf@@@Z */ +DEFINE_THISCALL_WRAPPER(istream_sb_ctor, 12) +istream* __thiscall istream_sb_ctor(istream *this, streambuf *sb, BOOL virt_init) +{ + TRACE("(%p %p %d)\n", this, sb, virt_init); + istream_ctor(this, virt_init); + ios_init(istream_get_ios(this), sb); + return this; +} + /* ??0istream@@IAE@ABV0@@Z */ /* ??0istream@@IEAA@AEBV0@@Z */ DEFINE_THISCALL_WRAPPER(istream_copy_ctor, 12) @@ -2988,28 +2982,6 @@ istream* __thiscall istream_copy_ctor(istream *this, const istream *copy, BOOL v return istream_sb_ctor(this, istream_get_ios(copy)->sb, virt_init); } -/* ??0istream@@IAE@XZ */ -/* ??0istream@@IEAA@XZ */ -DEFINE_THISCALL_WRAPPER(istream_ctor, 8) -istream* __thiscall istream_ctor(istream *this, BOOL virt_init) -{ - ios *base; - - TRACE("(%p %d)\n", this, virt_init); - - if (virt_init) { - this->vbtable = istream_vbtable; - base = istream_get_ios(this); - ios_ctor(base); - } else - base = istream_get_ios(this); - base->vtable = &MSVCP_istream_vtable; - base->flags |= FLAGS_skipws; - this->extract_delim = 0; - this->count = 0; - return this; -} - /* ??1istream@@UAE@XZ */ /* ??1istream@@UEAA@XZ */ /* ??1istream_withassign@@UAE@XZ */

1 0

Iván Matellanes : msvcirt: Implement iostream assignment operators.
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: 346a64c08940f949843f844205ca6231c2ea4150 URL: http://source.winehq.org/git/wine.git/?a=commit;h=346a64c08940f949843f84420… Author: Iván Matellanes <matellanesivan(a)gmail.com> Date: Tue Aug 9 19:16:04 2016 +0100 msvcirt: Implement iostream assignment operators. Signed-off-by: Iván Matellanes <matellanesivan(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcirt/msvcirt.c | 7 ++--- dlls/msvcirt/tests/msvcirt.c | 62 ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 66 insertions(+), 3 deletions(-) diff --git a/dlls/msvcirt/msvcirt.c b/dlls/msvcirt/msvcirt.c index 305eb9d..6533af0 100644 --- a/dlls/msvcirt/msvcirt.c +++ b/dlls/msvcirt/msvcirt.c @@ -3997,7 +3997,9 @@ void __thiscall iostream_dtor(ios *base) DEFINE_THISCALL_WRAPPER(iostream_assign_sb, 8) iostream* __thiscall iostream_assign_sb(iostream *this, streambuf *sb) { - FIXME("(%p %p) stub\n", this, sb); + TRACE("(%p %p)\n", this, sb); + this->base1.count = 0; + ostream_assign_sb(&this->base2, sb); return this; } @@ -4006,8 +4008,7 @@ iostream* __thiscall iostream_assign_sb(iostream *this, streambuf *sb) DEFINE_THISCALL_WRAPPER(iostream_assign, 8) iostream* __thiscall iostream_assign(iostream *this, const iostream *rhs) { - FIXME("(%p %p) stub\n", this, rhs); - return this; + return iostream_assign_sb(this, istream_get_ios(&rhs->base1)->sb); } /* ??_Diostream@@QAEXXZ */ diff --git a/dlls/msvcirt/tests/msvcirt.c b/dlls/msvcirt/tests/msvcirt.c index c26e906..1b15949 100644 --- a/dlls/msvcirt/tests/msvcirt.c +++ b/dlls/msvcirt/tests/msvcirt.c @@ -380,6 +380,8 @@ static iostream* (*__thiscall p_iostream_sb_ctor)(iostream*, streambuf*, BOOL); static iostream* (*__thiscall p_iostream_ctor)(iostream*, BOOL); static void (*__thiscall p_iostream_dtor)(ios*); static void (*__thiscall p_iostream_vbase_dtor)(iostream*); +static iostream* (*__thiscall p_iostream_assign_sb)(iostream*, streambuf*); +static iostream* (*__thiscall p_iostream_assign)(iostream*, const iostream*); /* Emulate a __thiscall */ #ifdef __i386__ @@ -631,6 +633,8 @@ static BOOL init(void) SET(p_iostream_ctor, "??0iostream@@IEAA@XZ"); SET(p_iostream_dtor, "??1iostream@@UEAA@XZ"); SET(p_iostream_vbase_dtor, "??_Diostream@@QEAAXXZ"); + SET(p_iostream_assign_sb, "??4iostream@@IEAAAEAV0@PEAVstreambuf@@@Z"); + SET(p_iostream_assign, "??4iostream@@IEAAAEAV0@AEAV0@@Z"); } else { p_operator_new = (void*)GetProcAddress(msvcrt, "??2@YAPAXI@Z"); p_operator_delete = (void*)GetProcAddress(msvcrt, "??3@YAXPAX@Z"); @@ -804,6 +808,8 @@ static BOOL init(void) SET(p_iostream_ctor, "??0iostream@@IAE@XZ"); SET(p_iostream_dtor, "??1iostream@@UAE@XZ"); SET(p_iostream_vbase_dtor, "??_Diostream@@QAEXXZ"); + SET(p_iostream_assign_sb, "??4iostream@@IAEAAV0@PAVstreambuf@@@Z"); + SET(p_iostream_assign, "??4iostream@@IAEAAV0@AAV0@@Z"); } SET(p_ios_static_lock, "?x_lockc@ios@@0U_CRT_CRITICAL_SECTION@@A"); SET(p_ios_lockc, "?lockc@ios@@KAXXZ"); @@ -5968,6 +5974,62 @@ static void test_iostream(void) ok(ios2.base_ios.width == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base_ios.width); ok(ios2.base_ios.do_lock == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base_ios.do_lock); call_func1(p_iostream_dtor, &ios2.base_ios); + + /* assignment */ + ios2.base1.extract_delim = ios2.base1.count = 0xcdcdcdcd; + ios2.base2.unknown = 0xcdcdcdcd; + ios2.base_ios.sb = (streambuf*) 0xcdcdcdcd; + ios2.base_ios.state = 0xcdcdcdcd; + pios = call_func2(p_iostream_assign_sb, &ios2, &sb); + ok(pios == &ios2, "wrong return, expected %p got %p\n", &ios2, pios); + ok(ios2.base1.extract_delim == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base1.extract_delim); + ok(ios2.base1.count == 0, "expected 0 got %d\n", ios2.base1.count); + ok(ios2.base2.unknown == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base2.unknown); + ok(ios2.base_ios.sb == &sb, "expected %p got %p\n", &sb, ios2.base_ios.sb); + ok(ios2.base_ios.state == IOSTATE_goodbit, "expected %d got %d\n", IOSTATE_goodbit, ios2.base_ios.state); + ok(ios2.base_ios.delbuf == 0, "expected 0 got %d\n", ios2.base_ios.delbuf); + ok(ios2.base_ios.tie == NULL, "expected %p got %p\n", NULL, ios2.base_ios.tie); + ok(ios2.base_ios.flags == 0, "expected 0 got %x\n", ios2.base_ios.flags); + ok(ios2.base_ios.precision == 6, "expected 6 got %d\n", ios2.base_ios.precision); + ok(ios2.base_ios.fill == ' ', "expected 32 got %d\n", ios2.base_ios.fill); + ok(ios2.base_ios.width == 0, "expected 0 got %d\n", ios2.base_ios.width); + ok(ios2.base_ios.do_lock == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base_ios.do_lock); + ios2.base1.count = 0xcdcdcdcd; + memset(&ios2.base_ios, 0xcd, sizeof(ios)); + ios2.base_ios.delbuf = 0; + pios = call_func2(p_iostream_assign_sb, &ios2, NULL); + ok(pios == &ios2, "wrong return, expected %p got %p\n", &ios2, pios); + ok(ios2.base1.extract_delim == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base1.extract_delim); + ok(ios2.base1.count == 0, "expected 0 got %d\n", ios2.base1.count); + ok(ios2.base2.unknown == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base2.unknown); + ok(ios2.base_ios.sb == NULL, "expected %p got %p\n", NULL, ios2.base_ios.sb); + ok(ios2.base_ios.state == IOSTATE_badbit, "expected %d got %d\n", IOSTATE_badbit, ios2.base_ios.state); + ok(ios2.base_ios.delbuf == 0, "expected 0 got %d\n", ios2.base_ios.delbuf); + ok(ios2.base_ios.tie == NULL, "expected %p got %p\n", NULL, ios2.base_ios.tie); + ok(ios2.base_ios.flags == 0, "expected 0 got %x\n", ios2.base_ios.flags); + ok(ios2.base_ios.precision == 6, "expected 6 got %d\n", ios2.base_ios.precision); + ok(ios2.base_ios.fill == ' ', "expected 32 got %d\n", ios2.base_ios.fill); + ok(ios2.base_ios.width == 0, "expected 0 got %d\n", ios2.base_ios.width); + ok(ios2.base_ios.do_lock == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base_ios.do_lock); + ios2.base1.count = 0xcdcdcdcd; + memset(&ios2.base_ios, 0xcd, sizeof(ios)); + ios2.base_ios.delbuf = 0; +if (0) /* crashes on native */ + pios = call_func2(p_iostream_assign, &ios2, NULL); + pios = call_func2(p_iostream_assign, &ios2, &ios1); + ok(pios == &ios2, "wrong return, expected %p got %p\n", &ios2, pios); + ok(ios2.base1.extract_delim == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base1.extract_delim); + ok(ios2.base1.count == 0, "expected 0 got %d\n", ios2.base1.count); + ok(ios2.base2.unknown == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base2.unknown); + ok(ios2.base_ios.sb == &sb, "expected %p got %p\n", &sb, ios2.base_ios.sb); + ok(ios2.base_ios.state == IOSTATE_goodbit, "expected %d got %d\n", IOSTATE_goodbit, ios2.base_ios.state); + ok(ios2.base_ios.delbuf == 0, "expected 0 got %d\n", ios2.base_ios.delbuf); + ok(ios2.base_ios.tie == NULL, "expected %p got %p\n", NULL, ios2.base_ios.tie); + ok(ios2.base_ios.flags == 0, "expected 0 got %x\n", ios2.base_ios.flags); + ok(ios2.base_ios.precision == 6, "expected 6 got %d\n", ios2.base_ios.precision); + ok(ios2.base_ios.fill == ' ', "expected 32 got %d\n", ios2.base_ios.fill); + ok(ios2.base_ios.width == 0, "expected 0 got %d\n", ios2.base_ios.width); + ok(ios2.base_ios.do_lock == 0xcdcdcdcd, "expected %d got %d\n", 0xcdcdcdcd, ios2.base_ios.do_lock); } START_TEST(msvcirt)

1 0

Iván Matellanes : msvcirt: Implement iostream constructors/destructors.
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: 7de6bca9d22fd7cda4a3114cda4ccf565c4609d0 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7de6bca9d22fd7cda4a3114cd… Author: Iván Matellanes <matellanesivan(a)gmail.com> Date: Tue Aug 9 19:16:03 2016 +0100 msvcirt: Implement iostream constructors/destructors. Signed-off-by: Iván Matellanes <matellanesivan(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcirt/msvcirt.c | 36 ++++++-- dlls/msvcirt/tests/msvcirt.c | 208 +++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 238 insertions(+), 6 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=7de6bca9d22fd7cda4a31…

1 0

Iván Matellanes : msvcirt: Add stub for class iostream.
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: adf3763e466761e88c6df41602a685df4db99e32 URL: http://source.winehq.org/git/wine.git/?a=commit;h=adf3763e466761e88c6df4160… Author: Iván Matellanes <matellanesivan(a)gmail.com> Date: Tue Aug 9 19:16:02 2016 +0100 msvcirt: Add stub for class iostream. Signed-off-by: Iván Matellanes <matellanesivan(a)gmail.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcirt/msvcirt.c | 125 ++++++++++++++++++++++++++++++++++++++++++++ dlls/msvcirt/msvcirt.spec | 38 +++++++------- dlls/msvcrt20/msvcrt20.spec | 38 +++++++------- dlls/msvcrt40/msvcrt40.spec | 38 +++++++------- 4 files changed, 182 insertions(+), 57 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=adf3763e466761e88c6df…

1 0

Daniel Lehman : msvcp140: Add _Query_perf_[counter|frequency].
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: 1026e85d9f041fbd34d431b718740d1deb76fc95 URL: http://source.winehq.org/git/wine.git/?a=commit;h=1026e85d9f041fbd34d431b71… Author: Daniel Lehman <dlehman(a)esri.com> Date: Wed Aug 10 10:09:25 2016 +0200 msvcp140: Add _Query_perf_[counter|frequency]. Signed-off-by: Daniel Lehman <dlehman(a)esri.com> Signed-off-by: Piotr Caban <piotr(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/msvcp140/msvcp140.spec | 4 ++-- dlls/msvcp90/misc.c | 16 ++++++++++++++++ 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/dlls/msvcp140/msvcp140.spec b/dlls/msvcp140/msvcp140.spec index 22c302e..6e17e0d 100644 --- a/dlls/msvcp140/msvcp140.spec +++ b/dlls/msvcp140/msvcp140.spec @@ -3690,8 +3690,8 @@ @ stub _Mtxunlock @ extern _Nan _Nan @ stub _Open_dir -@ stub _Query_perf_counter -@ stub _Query_perf_frequency +@ cdecl -ret64 _Query_perf_counter() +@ cdecl -ret64 _Query_perf_frequency() @ stub _Read_dir @ stub _Remove_dir @ stub _Rename diff --git a/dlls/msvcp90/misc.c b/dlls/msvcp90/misc.c index 418f42b..7418fd2 100644 --- a/dlls/msvcp90/misc.c +++ b/dlls/msvcp90/misc.c @@ -1180,3 +1180,19 @@ void free_misc(void) NtClose(keyed_event); #endif } + +#if _MSVCP_VER >= 140 +LONGLONG __cdecl _Query_perf_counter(void) +{ + LARGE_INTEGER li; + QueryPerformanceCounter(&li); + return li.QuadPart; +} + +LONGLONG __cdecl _Query_perf_frequency(void) +{ + LARGE_INTEGER li; + QueryPerformanceFrequency(&li); + return li.QuadPart; +} +#endif

1 0

Sebastian Lackner : services: Implement functionality to transfer extra data when sending service control.
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: 8f8626feef10ea1277d4201662e1212444b6a8f9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8f8626feef10ea1277d420166… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Wed Aug 10 08:32:11 2016 +0200 services: Implement functionality to transfer extra data when sending service control. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/service.c | 13 +++++++------ programs/services/rpc.c | 10 ++++++---- 2 files changed, 13 insertions(+), 10 deletions(-) diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index 273e7c7..86bd713 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -401,14 +401,14 @@ static DWORD service_handle_start(service_data *service, const WCHAR *data, DWOR /****************************************************************************** * service_handle_control */ -static DWORD service_handle_control(const service_data *service, DWORD dwControl) +static DWORD service_handle_control(const service_data *service, DWORD control, void *data) { DWORD ret = ERROR_INVALID_SERVICE_CONTROL; - TRACE("%s control %u\n", debugstr_w(service->name), dwControl); + TRACE("%s control %u data %p\n", debugstr_w(service->name), control, data); if (service->handler) - ret = service->handler(dwControl, 0, NULL, service->context); + ret = service->handler(control, 0, data, service->context); return ret; } @@ -494,7 +494,8 @@ static DWORD WINAPI service_control_dispatcher(LPVOID arg) result = service_handle_start(service, (WCHAR *)data, data_size / sizeof(WCHAR)); break; case WINESERV_SENDCONTROL: - result = service_handle_control(service, info.control); + result = service_handle_control(service, info.control, (data_size > info.name_size * sizeof(WCHAR)) ? + &data[info.name_size * sizeof(WCHAR)] : NULL); break; default: ERR("received invalid command %u\n", info.cmd); @@ -589,13 +590,13 @@ static BOOL service_run_main_thread(void) { FIXME("service should be able to delay shutdown\n"); timeout += spi.dwPreshutdownTimeout; - ret = service_handle_control( services[i], SERVICE_CONTROL_PRESHUTDOWN ); + ret = service_handle_control( services[i], SERVICE_CONTROL_PRESHUTDOWN, NULL ); wait_handles[n++] = services[i]->thread; } } else if (res && (st.dwControlsAccepted & SERVICE_ACCEPT_SHUTDOWN)) { - ret = service_handle_control( services[i], SERVICE_CONTROL_SHUTDOWN ); + ret = service_handle_control( services[i], SERVICE_CONTROL_SHUTDOWN, NULL ); wait_handles[n++] = services[i]->thread; } } diff --git a/programs/services/rpc.c b/programs/services/rpc.c index 54947c6..17900cc 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -1039,21 +1039,23 @@ BOOL process_send_command(struct process_entry *process, const void *data, DWORD /****************************************************************************** * process_send_control */ -static BOOL process_send_control(struct process_entry *process, const WCHAR *name, DWORD dwControl, DWORD *result) +static BOOL process_send_control(struct process_entry *process, const WCHAR *name, DWORD control, + const BYTE *data, DWORD data_size, DWORD *result) { service_start_info *ssi; DWORD len; BOOL r; /* calculate how much space we need to send the startup info */ - len = (strlenW(name) + 1) * sizeof(WCHAR); + len = (strlenW(name) + 1) * sizeof(WCHAR) + data_size; ssi = HeapAlloc(GetProcessHeap(),0,FIELD_OFFSET(service_start_info, data[len])); ssi->cmd = WINESERV_SENDCONTROL; - ssi->control = dwControl; + ssi->control = control; ssi->total_size = FIELD_OFFSET(service_start_info, data[len]); ssi->name_size = strlenW(name) + 1; strcpyW((WCHAR *)ssi->data, name); + if (data_size) memcpy(&ssi->data[ssi->name_size * sizeof(WCHAR)], data, data_size); r = process_send_command(process, ssi, ssi->total_size, result); HeapFree( GetProcessHeap(), 0, ssi ); @@ -1185,7 +1187,7 @@ DWORD __cdecl svcctl_ControlService( return ERROR_SERVICE_REQUEST_TIMEOUT; } - process_send_control(process, service->service_entry->name, dwControl, &result); + process_send_control(process, service->service_entry->name, dwControl, NULL, 0, &result); if (lpServiceStatus) {

1 0

Sebastian Lackner : advapi32: Validate received service name.
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: 7a200887bb9a455b83b462060b290e6a5a9db225 URL: http://source.winehq.org/git/wine.git/?a=commit;h=7a200887bb9a455b83b462060… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Wed Aug 10 08:31:34 2016 +0200 advapi32: Validate received service name. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/advapi32/service.c | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c index 0eb0a47..273e7c7 100644 --- a/dlls/advapi32/service.c +++ b/dlls/advapi32/service.c @@ -424,7 +424,8 @@ static DWORD WINAPI service_control_dispatcher(LPVOID arg) { service_data *service; service_start_info info; - WCHAR *data = NULL; + BYTE *data = NULL; + WCHAR *name; BOOL r; DWORD data_size = 0, count, result; @@ -460,16 +461,24 @@ static DWORD WINAPI service_control_dispatcher(LPVOID arg) } } - /* find the service */ + /* validate service name */ + name = (WCHAR *)data; + if (!info.name_size || data_size < info.name_size * sizeof(WCHAR) || name[info.name_size - 1]) + { + ERR( "got request without valid service name\n" ); + result = ERROR_INVALID_PARAMETER; + goto done; + } - if (!(service = find_service_by_name( data ))) + /* find the service */ + if (!(service = find_service_by_name( name ))) { - FIXME( "got request %u for unknown service %s\n", info.cmd, debugstr_w(data)); + FIXME( "got request %u for unknown service %s\n", info.cmd, debugstr_w(name)); result = ERROR_INVALID_PARAMETER; goto done; } - TRACE( "got request %u for service %s\n", info.cmd, debugstr_w(data) ); + TRACE( "got request %u for service %s\n", info.cmd, debugstr_w(name) ); /* handle the request */ switch (info.cmd) @@ -477,12 +486,12 @@ static DWORD WINAPI service_control_dispatcher(LPVOID arg) case WINESERV_STARTINFO: if (!service->handle) { - if (!(service->handle = OpenServiceW( disp->manager, data, SERVICE_SET_STATUS )) || - !(service->full_access_handle = OpenServiceW( disp->manager, data, + if (!(service->handle = OpenServiceW( disp->manager, name, SERVICE_SET_STATUS )) || + !(service->full_access_handle = OpenServiceW( disp->manager, name, GENERIC_READ|GENERIC_WRITE ))) - FIXME( "failed to open service %s\n", debugstr_w(data) ); + FIXME( "failed to open service %s\n", debugstr_w(name) ); } - result = service_handle_start(service, data, data_size / sizeof(WCHAR)); + result = service_handle_start(service, (WCHAR *)data, data_size / sizeof(WCHAR)); break; case WINESERV_SENDCONTROL: result = service_handle_control(service, info.control);

1 0

Sebastian Lackner : services: Preparation to allow arbitrary data in service RPC messages.
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: 5f2b96b859d1087557949d855d6fd0e68b128a9d URL: http://source.winehq.org/git/wine.git/?a=commit;h=5f2b96b859d1087557949d855… Author: Sebastian Lackner <sebastian(a)fds-team.de> Date: Wed Aug 10 08:30:29 2016 +0200 services: Preparation to allow arbitrary data in service RPC messages. Signed-off-by: Sebastian Lackner <sebastian(a)fds-team.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- include/wine/svcctl.idl | 2 +- programs/services/rpc.c | 4 ++-- programs/services/services.c | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/include/wine/svcctl.idl b/include/wine/svcctl.idl index cadc5fd..98412d6 100644 --- a/include/wine/svcctl.idl +++ b/include/wine/svcctl.idl @@ -46,7 +46,7 @@ typedef struct service_start_info_t DWORD total_size; /* total request size */ DWORD name_size; /* size of name in data buffer */ DWORD control; /* control code */ - WCHAR data[1]; + BYTE data[1]; } service_start_info; [ diff --git a/programs/services/rpc.c b/programs/services/rpc.c index 3ebf378..54947c6 100644 --- a/programs/services/rpc.c +++ b/programs/services/rpc.c @@ -1046,14 +1046,14 @@ static BOOL process_send_control(struct process_entry *process, const WCHAR *nam BOOL r; /* calculate how much space we need to send the startup info */ - len = strlenW(name) + 1; + len = (strlenW(name) + 1) * sizeof(WCHAR); ssi = HeapAlloc(GetProcessHeap(),0,FIELD_OFFSET(service_start_info, data[len])); ssi->cmd = WINESERV_SENDCONTROL; ssi->control = dwControl; ssi->total_size = FIELD_OFFSET(service_start_info, data[len]); ssi->name_size = strlenW(name) + 1; - strcpyW(ssi->data, name); + strcpyW((WCHAR *)ssi->data, name); r = process_send_command(process, ssi, ssi->total_size, result); HeapFree( GetProcessHeap(), 0, ssi ); diff --git a/programs/services/services.c b/programs/services/services.c index ae5da2b..8e49906 100644 --- a/programs/services/services.c +++ b/programs/services/services.c @@ -861,17 +861,17 @@ static BOOL process_send_start_message(struct process_entry *process, const WCHA len = strlenW(name) + 1; for (i=0; i<argc; i++) len += strlenW(argv[i])+1; - len++; + len = (len + 1) * sizeof(WCHAR); ssi = HeapAlloc(GetProcessHeap(),0,FIELD_OFFSET(service_start_info, data[len])); ssi->cmd = WINESERV_STARTINFO; ssi->control = 0; ssi->total_size = FIELD_OFFSET(service_start_info, data[len]); ssi->name_size = strlenW(name) + 1; - strcpyW(ssi->data, name); + strcpyW((WCHAR *)ssi->data, name); /* copy service args into a single buffer*/ - p = &ssi->data[ssi->name_size]; + p = (WCHAR *)&ssi->data[ssi->name_size * sizeof(WCHAR)]; for (i=0; i<argc; i++) { strcpyW(p, argv[i]);

1 0

Michael Stefaniuc : ole32/tests: Use todo_wine_if().
by Alexandre Julliard 10 Aug '16

10 Aug '16

Module: wine Branch: master Commit: b6a505f9a57c5077bd1805746e9e5800b4c0bb56 URL: http://source.winehq.org/git/wine.git/?a=commit;h=b6a505f9a57c5077bd1805746… Author: Michael Stefaniuc <mstefani(a)redhat.de> Date: Tue Aug 9 22:34:25 2016 +0200 ole32/tests: Use todo_wine_if(). Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ole32/tests/propvariant.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/dlls/ole32/tests/propvariant.c b/dlls/ole32/tests/propvariant.c index 0786a8e..ade45fb 100644 --- a/dlls/ole32/tests/propvariant.c +++ b/dlls/ole32/tests/propvariant.c @@ -166,16 +166,7 @@ static void expect(HRESULT hr, VARTYPE vt, BOOL copy, int line) } else if(flags == PROP_V0) ok(hr == S_OK, "%s (%s): got %08x\n", wine_vtypes[idx], modifier, hr); - else if(flags & PROP_TODO) - { - todo_wine - { - if(hr != S_OK) - win_skip("%s (%s): unsupported\n", wine_vtypes[idx], modifier); - else ok(hr == S_OK, "%s (%s): got %08x\n", wine_vtypes[idx], modifier, hr); - } - } - else + else todo_wine_if(flags & PROP_TODO) { if(hr != S_OK) win_skip("%s (%s): unsupported\n", wine_vtypes[idx], modifier);

1 0

← Newer
1
...
49
50
51
52
53
54
55
...
78
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits August 2016