wine-commits December 2017

wine-commits@winehq.org

2 participants
450 discussions

Andrew Eikum : ntdll: Report NtReadFileScatter results asynchronously.
by Alexandre Julliard 07 Dec '17

07 Dec '17

Module: wine Branch: master Commit: 52627611359fa74409c67dd4879003a5f410a2df URL: http://source.winehq.org/git/wine.git/?a=commit;h=52627611359fa74409c67dd48… Author: Andrew Eikum <aeikum(a)codeweavers.com> Date: Wed Dec 6 15:07:45 2017 -0600 ntdll: Report NtReadFileScatter results asynchronously. Signed-off-by: Andrew Eikum <aeikum(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/kernel32/tests/file.c | 104 ++++++++++++++++++++++++++++++++++++++++----- dlls/ntdll/file.c | 29 ++++++------- 2 files changed, 108 insertions(+), 25 deletions(-) diff --git a/dlls/kernel32/tests/file.c b/dlls/kernel32/tests/file.c index 0b8cef2..4980e02 100644 --- a/dlls/kernel32/tests/file.c +++ b/dlls/kernel32/tests/file.c @@ -4347,13 +4347,16 @@ static void test_SetFileValidData(void) static void test_WriteFileGather(void) { char temp_path[MAX_PATH], filename[MAX_PATH]; - HANDLE hfile, hiocp1, hiocp2; - DWORD ret, size; + HANDLE hfile, hiocp1, hiocp2, evt; + DWORD ret, size, tx; ULONG_PTR key; FILE_SEGMENT_ELEMENT fse[2]; OVERLAPPED ovl, *povl = NULL; SYSTEM_INFO si; - LPVOID buf = NULL; + LPVOID wbuf = NULL, rbuf1; + BOOL br; + + evt = CreateEventW( NULL, TRUE, FALSE, NULL ); ret = GetTempPathA( MAX_PATH, temp_path ); ok( ret != 0, "GetTempPathA error %d\n", GetLastError() ); @@ -4371,12 +4374,18 @@ static void test_WriteFileGather(void) ok( hiocp2 != 0, "CreateIoCompletionPort failed err %u\n", GetLastError() ); GetSystemInfo( &si ); - buf = VirtualAlloc( NULL, si.dwPageSize, MEM_COMMIT, PAGE_READWRITE ); - ok( buf != NULL, "VirtualAlloc failed err %u\n", GetLastError() ); + wbuf = VirtualAlloc( NULL, si.dwPageSize, MEM_COMMIT, PAGE_READWRITE ); + ok( wbuf != NULL, "VirtualAlloc failed err %u\n", GetLastError() ); + + rbuf1 = VirtualAlloc( NULL, si.dwPageSize, MEM_COMMIT, PAGE_READWRITE ); + ok( rbuf1 != NULL, "VirtualAlloc failed err %u\n", GetLastError() ); memset( &ovl, 0, sizeof(ovl) ); + ovl.hEvent = evt; memset( fse, 0, sizeof(fse) ); - fse[0].Buffer = buf; + fse[0].Buffer = wbuf; + memset( wbuf, 0x42, si.dwPageSize ); + SetLastError( 0xdeadbeef ); if (!WriteFileGather( hfile, fse, si.dwPageSize, NULL, &ovl )) ok( GetLastError() == ERROR_IO_PENDING, "WriteFileGather failed err %u\n", GetLastError() ); @@ -4384,20 +4393,95 @@ static void test_WriteFileGather(void) ok( ret, "GetQueuedCompletionStatus failed err %u\n", GetLastError()); ok( povl == &ovl, "wrong ovl %p\n", povl ); + tx = 0; + br = GetOverlappedResult( hfile, &ovl, &tx, TRUE ); + ok( br == TRUE, "GetOverlappedResult failed: %u\n", GetLastError() ); + ok( tx == si.dwPageSize, "got unexpected bytes transferred: %u\n", tx ); + + ResetEvent( evt ); + + /* read exact size */ memset( &ovl, 0, sizeof(ovl) ); + ovl.hEvent = evt; memset( fse, 0, sizeof(fse) ); - fse[0].Buffer = buf; - if (!ReadFileScatter( hfile, fse, si.dwPageSize, NULL, &ovl )) - ok( GetLastError() == ERROR_IO_PENDING, "ReadFileScatter failed err %u\n", GetLastError() ); + fse[0].Buffer = rbuf1; + memset( rbuf1, 0, si.dwPageSize ); + SetLastError( 0xdeadbeef ); + br = ReadFileScatter( hfile, fse, si.dwPageSize, NULL, &ovl ); + ok( br == FALSE, "ReadFileScatter should be asynchronous\n" ); + ok( GetLastError() == ERROR_IO_PENDING, "ReadFileScatter failed err %u\n", GetLastError() ); ret = GetQueuedCompletionStatus( hiocp2, &size, &key, &povl, 1000 ); ok( ret, "GetQueuedCompletionStatus failed err %u\n", GetLastError()); ok( povl == &ovl, "wrong ovl %p\n", povl ); + tx = 0; + br = GetOverlappedResult( hfile, &ovl, &tx, TRUE ); + ok( br == TRUE, "GetOverlappedResult failed: %u\n", GetLastError() ); + ok( tx == si.dwPageSize, "got unexpected bytes transferred: %u\n", tx ); + + ok( memcmp( rbuf1, wbuf, si.dwPageSize ) == 0, + "data was not read into buffer\n" ); + + ResetEvent( evt ); + + /* start read at EOF */ + memset( &ovl, 0, sizeof(ovl) ); + ovl.hEvent = evt; + S(U(ovl)).OffsetHigh = 0; + S(U(ovl)).Offset = si.dwPageSize; + memset( fse, 0, sizeof(fse) ); + fse[0].Buffer = rbuf1; + SetLastError( 0xdeadbeef ); + br = ReadFileScatter( hfile, fse, si.dwPageSize, NULL, &ovl ); + ok( br == FALSE, "ReadFileScatter should have failed\n" ); + ok( GetLastError() == ERROR_HANDLE_EOF || + GetLastError() == ERROR_IO_PENDING, "ReadFileScatter gave wrong error %u\n", GetLastError() ); + if (GetLastError() == ERROR_IO_PENDING) + { + SetLastError( 0xdeadbeef ); + ret = GetQueuedCompletionStatus( hiocp2, &size, &key, &povl, 1000 ); + ok( !ret, "GetQueuedCompletionStatus should have returned failure\n" ); + ok( GetLastError() == ERROR_HANDLE_EOF, "Got wrong error: %u\n", GetLastError() ); + ok( povl == &ovl, "wrong ovl %p\n", povl ); + + SetLastError( 0xdeadbeef ); + br = GetOverlappedResult( hfile, &ovl, &tx, TRUE ); + ok( br == FALSE, "GetOverlappedResult should have failed\n" ); + ok( GetLastError() == ERROR_HANDLE_EOF, "Got wrong error: %u\n", GetLastError() ); + } + else + { + SetLastError( 0xdeadbeef ); + ret = GetQueuedCompletionStatus( hiocp2, &size, &key, &povl, 100 ); + ok( !ret, "GetQueuedCompletionStatus failed err %u\n", GetLastError() ); + ok( GetLastError() == WAIT_TIMEOUT, "GetQueuedCompletionStatus gave wrong error %u\n", GetLastError() ); + ok( povl == NULL, "wrong ovl %p\n", povl ); + } + + ResetEvent( evt ); + CloseHandle( hfile ); CloseHandle( hiocp1 ); CloseHandle( hiocp2 ); - VirtualFree( buf, 0, MEM_RELEASE ); + + /* file handle must be overlapped */ + hfile = CreateFileA( filename, GENERIC_READ, 0, 0, OPEN_EXISTING, + FILE_FLAG_NO_BUFFERING | FILE_ATTRIBUTE_NORMAL, 0 ); + ok( hfile != INVALID_HANDLE_VALUE, "CreateFile failed err %u\n", GetLastError() ); + + memset( &ovl, 0, sizeof(ovl) ); + memset( fse, 0, sizeof(fse) ); + fse[0].Buffer = rbuf1; + memset( rbuf1, 0, si.dwPageSize ); + SetLastError( 0xdeadbeef ); + br = ReadFileScatter( hfile, fse, si.dwPageSize, NULL, &ovl ); + ok( br == FALSE, "ReadFileScatter should fail\n" ); + ok( GetLastError() == ERROR_INVALID_PARAMETER, "ReadFileScatter failed err %u\n", GetLastError() ); + + VirtualFree( wbuf, 0, MEM_RELEASE ); + VirtualFree( rbuf1, 0, MEM_RELEASE ); + CloseHandle( evt ); DeleteFileA( filename ); } diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index ca2afa0..9df15ff 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -1086,25 +1086,24 @@ NTSTATUS WINAPI NtReadFileScatter( HANDLE file, HANDLE event, PIO_APC_ROUTINE ap send_completion = cvalue != 0; - error: if (needs_close) close( unix_handle ); - if (status == STATUS_SUCCESS) - { - io_status->u.Status = status; - io_status->Information = total; - TRACE("= SUCCESS (%u)\n", total); - if (event) NtSetEvent( event, NULL ); - if (apc) NtQueueApcThread( GetCurrentThread(), (PNTAPCFUNC)apc, - (ULONG_PTR)apc_user, (ULONG_PTR)io_status, 0 ); - } - else - { - TRACE("= 0x%08x\n", status); - if (status != STATUS_PENDING && event) NtResetEvent( event, NULL ); - } + io_status->u.Status = status; + io_status->Information = total; + TRACE("= 0x%08x (%u)\n", status, total); + if (event) NtSetEvent( event, NULL ); + if (apc) NtQueueApcThread( GetCurrentThread(), (PNTAPCFUNC)apc, + (ULONG_PTR)apc_user, (ULONG_PTR)io_status, 0 ); if (send_completion) NTDLL_AddCompletion( file, cvalue, status, total ); + return STATUS_PENDING; + +error: + if (needs_close) close( unix_handle ); + + TRACE("= 0x%08x\n", status); + if (event) NtResetEvent( event, NULL ); + return status; }

1 0

Lauri Kenttä : po: Update Finnish translation.
by Alexandre Julliard 07 Dec '17

07 Dec '17

Module: wine Branch: master Commit: 35e45b9401c6f87ba5bfbba4181f26098d9f0462 URL: http://source.winehq.org/git/wine.git/?a=commit;h=35e45b9401c6f87ba5bfbba41… Author: Lauri Kenttä <lauri.kentta(a)gmail.com> Date: Thu Dec 7 17:08:50 2017 +0200 po: Update Finnish translation. Signed-off-by: Lauri Kenttä <lauri.kentta(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- po/fi.po | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/po/fi.po b/po/fi.po index 9809abe..0c4fa20 100644 --- a/po/fi.po +++ b/po/fi.po @@ -11993,17 +11993,6 @@ msgid "Icons (*.ico)" msgstr "Kuvakkeet (*.ico)" #: reg.rc:35 -#, fuzzy -#| msgid "" -#| "Usage:\n" -#| " REG [operation] [parameters]\n" -#| "\n" -#| "Supported operations:\n" -#| " ADD | DELETE | IMPORT | QUERY\n" -#| "\n" -#| "For help on a specific operation, type:\n" -#| " REG [operation] /?\n" -#| "\n" msgid "" "Usage:\n" " REG [operation] [parameters]\n" @@ -12019,7 +12008,7 @@ msgstr "" " REG [toiminto] [parametrit]\n" "\n" "Tuetut toiminnot:\n" -" ADD, DELETE, IMPORT, QUERY\n" +" ADD, DELETE, IMPORT, EXPORT, QUERY\n" "\n" "Ohjeen kustakin toiminnosta saa komennolla\n" " REG [toiminto] /?\n" @@ -12163,22 +12152,16 @@ msgid "reg: Unrecognized escape sequence [\\%1!c!]\n" msgstr "reg: Tuntematon merkintä [\\%1!c!]\n" #: reg.rc:70 -#, fuzzy -#| msgid "REG IMPORT file.reg\n" msgid "REG EXPORT key_name file.reg [/y]\n" -msgstr "REG IMPORT tiedosto.reg\n" +msgstr "REG EXPORT avaimen_nimi tiedosto.reg\n" #: reg.rc:71 -#, fuzzy -#| msgid "regedit: Invalid system key [%1]\n" msgid "reg: Invalid system key [%1]\n" -msgstr "regedit: Järjestelmäavain [%1] ei kelpaa\n" +msgstr "reg: Järjestelmäavain [%1] ei kelpaa\n" #: reg.rc:72 -#, fuzzy -#| msgid "The registry value '%1' already exists. Do you want to overwrite it?" msgid "The file '%1' already exists. Do you want to overwrite it?" -msgstr "Rekisterin arvo '%1' on jo olemassa. Haluatko korvata sen?" +msgstr "Tiedosto '%1' on jo olemassa. Haluatko korvata sen?" #: regedit.rc:34 msgid "&Registry"

1 0

Alexandre Julliard : ntdll: Display floating point arguments in relay debugging on i386 and x86-64.
by Alexandre Julliard 07 Dec '17

07 Dec '17

Module: wine Branch: master Commit: 8c1bb2aa61abd8a6458c446efa55f8b261f63da9 URL: http://source.winehq.org/git/wine.git/?a=commit;h=8c1bb2aa61abd8a6458c446ef… Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Dec 7 11:14:02 2017 +0100 ntdll: Display floating point arguments in relay debugging on i386 and x86-64. Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- dlls/ntdll/relay.c | 397 ++++++++++++++++++++++++++++++++--------------- tools/winebuild/build.h | 1 + tools/winebuild/spec32.c | 169 ++++++++++++-------- 3 files changed, 383 insertions(+), 184 deletions(-) Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=8c1bb2aa61abd8a6458c4…

1 0

Francois Gouget : testbot/web: Remove some unused escapeHTML() import directives.
by Alexandre Julliard 07 Dec '17

07 Dec '17

Module: tools Branch: master Commit: 4d2bfb54e860c77723c9081a1522105e0a7389cb URL: http://source.winehq.org/git/tools.git/?a=commit;h=4d2bfb54e860c77723c9081a… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Dec 7 04:15:14 2017 +0100 testbot/web: Remove some unused escapeHTML() import directives. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/web/Feedback.pl | 1 - testbot/web/ForgotPassword.pl | 1 - testbot/web/ResetPassword.pl | 1 - 3 files changed, 3 deletions(-) diff --git a/testbot/web/Feedback.pl b/testbot/web/Feedback.pl index e22dc3a..ded705a 100644 --- a/testbot/web/Feedback.pl +++ b/testbot/web/Feedback.pl @@ -21,7 +21,6 @@ use strict; package FeedbackPage; -use CGI qw(:standard escapeHTML); use ObjectModel::BasicPropertyDescriptor; use ObjectModel::CGI::FreeFormPage; use WineTestBot::Config; diff --git a/testbot/web/ForgotPassword.pl b/testbot/web/ForgotPassword.pl index 801b50d..c6240e7 100644 --- a/testbot/web/ForgotPassword.pl +++ b/testbot/web/ForgotPassword.pl @@ -21,7 +21,6 @@ use strict; package ForgotPasswordPage; -use CGI qw(:standard escapeHTML); use ObjectModel::BasicPropertyDescriptor; use ObjectModel::CGI::FreeFormPage; use WineTestBot::Users; diff --git a/testbot/web/ResetPassword.pl b/testbot/web/ResetPassword.pl index d512968..431a4da 100644 --- a/testbot/web/ResetPassword.pl +++ b/testbot/web/ResetPassword.pl @@ -21,7 +21,6 @@ use strict; package ResetPasswordPage; -use CGI qw(:standard escapeHTML); use ObjectModel::BasicPropertyDescriptor; use ObjectModel::CGI::FreeFormPage; use WineTestBot::Users;

1 0

Francois Gouget : testbot/web: Add ids so one can link to a given job on the Home page.
by Alexandre Julliard 07 Dec '17

07 Dec '17

Module: tools Branch: master Commit: 62bfba14f69d3a021e7945f36f653d539b3690eb URL: http://source.winehq.org/git/tools.git/?a=commit;h=62bfba14f69d3a021e7945f3… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Dec 7 04:15:03 2017 +0100 testbot/web: Add ids so one can link to a given job on the Home page. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/web/index.pl | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/testbot/web/index.pl b/testbot/web/index.pl index 3f3a91e..b0c2d45 100644 --- a/testbot/web/index.pl +++ b/testbot/web/index.pl @@ -87,7 +87,8 @@ sub GenerateDataCell($$$$) my $PropertyName = $PropertyDescriptor->GetName(); if ($PropertyName eq "Status") { - print "<td><a href='/JobDetails.pl?Key=", uri_escape($Item->GetKey()), "'>"; + my $EscapedKey = uri_escape($Item->GetKey()); + print "<td id='job$EscapedKey'><a href='/JobDetails.pl?Key=$EscapedKey'>"; my %HTMLChunks = ("queued" => "<span class='queued'>queued</span>", "running" => "<span class='running'>running</span>",

1 0

Francois Gouget : testbot/web: Use our escapeHTML() instead of calling directly the CGI one.
by Alexandre Julliard 07 Dec '17

07 Dec '17

Module: tools Branch: master Commit: 96e0fdacae01d741bc0144e8f699f5cccbeaff87 URL: http://source.winehq.org/git/tools.git/?a=commit;h=96e0fdacae01d741bc0144e8… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Dec 7 04:13:44 2017 +0100 testbot/web: Use our escapeHTML() instead of calling directly the CGI one. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/web/Login.pl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/testbot/web/Login.pl b/testbot/web/Login.pl index 99757c5..f17d60e 100644 --- a/testbot/web/Login.pl +++ b/testbot/web/Login.pl @@ -21,7 +21,6 @@ use strict; package LoginPage; -use CGI qw(:standard escapeHTML); use ObjectModel::BasicPropertyDescriptor; use ObjectModel::CGI::FreeFormPage; use WineTestBot::Config; @@ -79,7 +78,7 @@ sub GenerateFields($) if (defined($self->GetParam("Target"))) { print "<div><input type='hidden' name='Target' value='", - escapeHTML($self->GetParam("Target")), "'></div>\n"; + $self->escapeHTML($self->GetParam("Target")), "'></div>\n"; } $self->SUPER::GenerateFields();

1 0

Francois Gouget : testbot: Remove extraneous colons in new() calls.
by Alexandre Julliard 07 Dec '17

07 Dec '17

Module: tools Branch: master Commit: b4b9a015de557b5efeaa4457b40e8daad952614c URL: http://source.winehq.org/git/tools.git/?a=commit;h=b4b9a015de557b5efeaa4457… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Dec 7 04:13:24 2017 +0100 testbot: Remove extraneous colons in new() calls. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/Branches.pm | 4 ++-- testbot/lib/WineTestBot/Roles.pm | 4 ++-- testbot/lib/WineTestBot/Users.pm | 4 ++-- testbot/lib/WineTestBot/VMs.pm | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/testbot/lib/WineTestBot/Branches.pm b/testbot/lib/WineTestBot/Branches.pm index 63a582c..bfd24dd 100644 --- a/testbot/lib/WineTestBot/Branches.pm +++ b/testbot/lib/WineTestBot/Branches.pm @@ -97,8 +97,8 @@ sub CreateItem($) sub CreateBranches(;$) { my ($ScopeObject) = @_; - return WineTestBot::Branches::->new("Branches", "Branches", "Branch", - \@PropertyDescriptors, $ScopeObject); + return WineTestBot::Branches->new("Branches", "Branches", "Branch", + \@PropertyDescriptors, $ScopeObject); } 1; diff --git a/testbot/lib/WineTestBot/Roles.pm b/testbot/lib/WineTestBot/Roles.pm index 86c5a13..7c59e6a 100644 --- a/testbot/lib/WineTestBot/Roles.pm +++ b/testbot/lib/WineTestBot/Roles.pm @@ -73,8 +73,8 @@ sub CreateItem($) sub CreateRoles(;$) { my ($ScopeObject) = @_; - return WineTestBot::Roles::->new("Roles", "Roles", "Role", - \@PropertyDescriptors, $ScopeObject); + return WineTestBot::Roles->new("Roles", "Roles", "Role", + \@PropertyDescriptors, $ScopeObject); } 1; diff --git a/testbot/lib/WineTestBot/Users.pm b/testbot/lib/WineTestBot/Users.pm index 9618a18..2139b6d 100644 --- a/testbot/lib/WineTestBot/Users.pm +++ b/testbot/lib/WineTestBot/Users.pm @@ -333,8 +333,8 @@ sub CreateItem($) sub CreateUsers(;$) { my ($ScopeObject) = @_; - return WineTestBot::Users::->new("Users", "Users", "User", - \@PropertyDescriptors, $ScopeObject); + return WineTestBot::Users->new("Users", "Users", "User", + \@PropertyDescriptors, $ScopeObject); } sub AuthenticateLDAP($$$) diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm index 30b6124..7db0aa5 100644 --- a/testbot/lib/WineTestBot/VMs.pm +++ b/testbot/lib/WineTestBot/VMs.pm @@ -553,8 +553,8 @@ sub CreateItem($) sub CreateVMs(;$) { my ($ScopeObject) = @_; - return WineTestBot::VMs::->new("VMs", "VMs", "VM", - \@PropertyDescriptors, $ScopeObject); + return WineTestBot::VMs->new("VMs", "VMs", "VM", + \@PropertyDescriptors, $ScopeObject); } sub SortKeysBySortOrder($$)

1 0

Francois Gouget : testbot: Document a quirk of Collection::Add().
by Alexandre Julliard 07 Dec '17

07 Dec '17

Module: tools Branch: master Commit: 97036c17e646267916d87da7570a420631611d9a URL: http://source.winehq.org/git/tools.git/?a=commit;h=97036c17e646267916d87da7… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Dec 7 04:13:09 2017 +0100 testbot: Document a quirk of Collection::Add(). Not only does it not force loading from the database, it marks the Collection as loaded. So if Add() is the first call on a Collection, calling GetKeys() or GetItems() later on will only return the new Item. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/ObjectModel/Collection.pm | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/testbot/lib/ObjectModel/Collection.pm b/testbot/lib/ObjectModel/Collection.pm index 9d3d3ae..1b29ec1 100644 --- a/testbot/lib/ObjectModel/Collection.pm +++ b/testbot/lib/ObjectModel/Collection.pm @@ -168,6 +168,11 @@ sub Load($) Instantiates a new Item and adds it to the Collection. +Note that not only does calling Add() not force loading from the database, +it marks the Collection as loaded. So if Add() is the first call on a +Collection, calling GetKeys() or GetItems() later on will only return the new +Item. + See Item->new() for details on the Item's default column values and for important information regarding its primary key.

1 0

Francois Gouget : testbot: Don' t fail setting the Status of a brand new VM.
by Alexandre Julliard 07 Dec '17

07 Dec '17

Module: tools Branch: master Commit: d4fe0e1bf6dece453384768d25e422ff527d375e URL: http://source.winehq.org/git/tools.git/?a=commit;h=d4fe0e1bf6dece453384768d… Author: Francois Gouget <fgouget(a)codeweavers.com> Date: Thu Dec 7 04:12:52 2017 +0100 testbot: Don't fail setting the Status of a brand new VM. Signed-off-by: Francois Gouget <fgouget(a)codeweavers.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- testbot/lib/WineTestBot/VMs.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testbot/lib/WineTestBot/VMs.pm b/testbot/lib/WineTestBot/VMs.pm index b931342..30b6124 100644 --- a/testbot/lib/WineTestBot/VMs.pm +++ b/testbot/lib/WineTestBot/VMs.pm @@ -221,7 +221,7 @@ sub Status($;$) my $CurrentStatus = $self->SUPER::Status; return $CurrentStatus if (!defined $NewStatus); - if ($NewStatus ne $CurrentStatus) + if (!defined $CurrentStatus or $NewStatus ne $CurrentStatus) { $self->SUPER::Status($NewStatus); $self->{OldStatus} = $CurrentStatus;

1 0

Austin English : maintainers: Move WineHQ URLs to https.
by Alexandre Julliard 06 Dec '17

06 Dec '17

Module: wine Branch: master Commit: 83bbeab9b2d0ceac2548d2a9d8e5aefb0d9f5606 URL: http://source.winehq.org/git/wine.git/?a=commit;h=83bbeab9b2d0ceac2548d2a9d… Author: Austin English <austinenglish(a)gmail.com> Date: Wed Dec 6 13:51:09 2017 -0600 maintainers: Move WineHQ URLs to https. Signed-off-by: Austin English <austinenglish(a)gmail.com> Signed-off-by: Alexandre Julliard <julliard(a)winehq.org> --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2f92151..6845a7a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3,7 +3,7 @@ List of Wine subsection maintainers When submitting patches to Wine, the guidelines at -<http://wiki.winehq.org/SubmittingPatches> should be followed. This file +<https://wiki.winehq.org/SubmittingPatches> should be followed. This file contains a list of maintainers for subsections of Wine. When submitting patches, you may want to CC relevant people from this list. If you have questions about your work in an area of Wine, you may find a list of @@ -317,7 +317,7 @@ F: */ Stable Branch M: Michael Stefaniuc <mstefani(a)winehq.org> -W: http://wiki.winehq.org/StableRules +W: https://wiki.winehq.org/StableRules Staging Branch M: Sebastian Lackner <sebastian(a)fds-team.de>

1 0

← Newer
1
...
26
27
28
29
30
31
32
...
45
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

2001

wine-commits December 2017